subject:"\[jira\] \[Commented\] \(HBASE\-7382\) Port ZK.multi support from HBASE\-6775 to 0.96"

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-25 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562630#comment-13562630
 ] 

Hudson commented on HBASE-7382:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #374 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/374/])
HBASE-7382 Port ZK.multi support from HBASE-6775 to 0.96 (Gregory, Himanshu 
and Ted) (Revision 1438317)

 Result = FAILURE
tedyu : 
Files : 
* 
/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
* /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMulti.java


 Port ZK.multi support from HBASE-6775 to 0.96
 -

 Key: HBASE-7382
 URL: https://issues.apache.org/jira/browse/HBASE-7382
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Gregory Chanan
Assignee: Himanshu Vashishtha
Priority: Critical
 Fix For: 0.96.0

 Attachments: 7382-trunk-v3.txt, 7382-trunk-v4.txt, 7382-trunk-v5.txt, 
 7382-trunk-v6.txt, HBASE-7382-trunk.patch


 HBASE-6775 adds support for ZK.multi ZKUtil and uses it for the 0.92/0.94 
 compatibility fix implemented in HBASE-6710.
 ZK.multi support is most likely useful in 0.96, but since HBASE-6710 is not 
 relevant for 0.96, perhaps we should find another use case first before we 
 port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561865#comment-13561865
 ] 

Hadoop QA commented on HBASE-7382:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12566334/7382-trunk-v2.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 1 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.regionserver.wal.TestHLog

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4163//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4163//console

This message is automatically generated.

 Port ZK.multi support from HBASE-6775 to 0.96
 -

 Key: HBASE-7382
 URL: https://issues.apache.org/jira/browse/HBASE-7382
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Gregory Chanan
Assignee: Himanshu Vashishtha
Priority: Critical
 Fix For: 0.96.0

 Attachments: 7382-trunk-v2.txt, HBASE-7382-trunk.patch


 HBASE-6775 adds support for ZK.multi ZKUtil and uses it for the 0.92/0.94 
 compatibility fix implemented in HBASE-6710.
 ZK.multi support is most likely useful in 0.96, but since HBASE-6710 is not 
 relevant for 0.96, perhaps we should find another use case first before we 
 port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Himanshu Vashishtha (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561980#comment-13561980
 ] 

Himanshu Vashishtha commented on HBASE-7382:


[~te...@apache.org]: Why you have changes in TestDistributedLogSplitting for 
this patch?
Looks like the failed test is due to that change.


 Port ZK.multi support from HBASE-6775 to 0.96
 -

 Key: HBASE-7382
 URL: https://issues.apache.org/jira/browse/HBASE-7382
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Gregory Chanan
Assignee: Himanshu Vashishtha
Priority: Critical
 Fix For: 0.96.0

 Attachments: 7382-trunk-v2.txt, HBASE-7382-trunk.patch


 HBASE-6775 adds support for ZK.multi ZKUtil and uses it for the 0.92/0.94 
 compatibility fix implemented in HBASE-6710.
 ZK.multi support is most likely useful in 0.96, but since HBASE-6710 is not 
 relevant for 0.96, perhaps we should find another use case first before we 
 port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562049#comment-13562049
]

Hadoop QA commented on HBASE-7382:
--

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12566375/7382-trunk-v3.txt
against trunk revision .

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.

{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.

{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.

{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100

{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestZKBasedOpenCloseRegion

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4166//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4166//console

This message is automatically generated.

Port ZK.multi support from HBASE-6775 to 0.96
-

Key: HBASE-7382
URL: https://issues.apache.org/jira/browse/HBASE-7382
Project: HBase
Issue Type: Bug
Components: Zookeeper
Reporter: Gregory Chanan
Assignee: Himanshu Vashishtha
Priority: Critical
Fix For: 0.96.0

Attachments: 7382-trunk-v3.txt, HBASE-7382-trunk.patch

HBASE-6775 adds support for ZK.multi ZKUtil and uses it for the 0.92/0.94
compatibility fix implemented in HBASE-6710.
ZK.multi support is most likely useful in 0.96, but since HBASE-6710 is not
relevant for 0.96, perhaps we should find another use case first before we
port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562152#comment-13562152
]

Hadoop QA commented on HBASE-7382:
--

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12566397/7382-trunk-v4.txt
against trunk revision .

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.

{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.

{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.

{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100

{color:red}-1 core tests{color}. The patch failed these unit tests:

org.apache.hadoop.hbase.coprocessor.example.TestBulkDeleteProtocol

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4168//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4168//console

This message is automatically generated.

Port ZK.multi support from HBASE-6775 to 0.96
-

Attachments: 7382-trunk-v3.txt, 7382-trunk-v4.txt,
HBASE-7382-trunk.patch

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562157#comment-13562157
 ] 

Ted Yu commented on HBASE-7382:
---

[~gchanan], [~lhofhansl]:
Can you take a look at patch v4 ?

Thanks

 Port ZK.multi support from HBASE-6775 to 0.96
 -

 Key: HBASE-7382
 URL: https://issues.apache.org/jira/browse/HBASE-7382
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Gregory Chanan
Assignee: Himanshu Vashishtha
Priority: Critical
 Fix For: 0.96.0

 Attachments: 7382-trunk-v3.txt, 7382-trunk-v4.txt, 
 HBASE-7382-trunk.patch


 HBASE-6775 adds support for ZK.multi ZKUtil and uses it for the 0.92/0.94 
 compatibility fix implemented in HBASE-6710.
 ZK.multi support is most likely useful in 0.96, but since HBASE-6710 is not 
 relevant for 0.96, perhaps we should find another use case first before we 
 port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Gregory Chanan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562226#comment-13562226
 ] 

Gregory Chanan commented on HBASE-7382:
---

{code}
This allows certain ZooKeeper operations to complete more quickly and prevents 
some issues
with rare ZooKeeper failure scenarios (see the release note of HBASE-6710 for 
an example).
{code}

This isn't relevant in 0.96, can we give a different example?

 Port ZK.multi support from HBASE-6775 to 0.96
 -

 Key: HBASE-7382
 URL: https://issues.apache.org/jira/browse/HBASE-7382
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Gregory Chanan
Assignee: Himanshu Vashishtha
Priority: Critical
 Fix For: 0.96.0

 Attachments: 7382-trunk-v3.txt, 7382-trunk-v4.txt, 
 HBASE-7382-trunk.patch


 HBASE-6775 adds support for ZK.multi ZKUtil and uses it for the 0.92/0.94 
 compatibility fix implemented in HBASE-6710.
 ZK.multi support is most likely useful in 0.96, but since HBASE-6710 is not 
 relevant for 0.96, perhaps we should find another use case first before we 
 port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562235#comment-13562235
 ] 

Ted Yu commented on HBASE-7382:
---

Himanshu beat me :-) How about using the following (referring to HBASE-2611):
All the active region servers try to move the logs of peers under the dead 
regionserver znode. It involves creating Op objects for creating new znodes and 
deleting old ones. As per the multi API guarantee, only one regionserver will 
be successful in moving the znodes.

 Port ZK.multi support from HBASE-6775 to 0.96
 -

 Key: HBASE-7382
 URL: https://issues.apache.org/jira/browse/HBASE-7382
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Gregory Chanan
Assignee: Himanshu Vashishtha
Priority: Critical
 Fix For: 0.96.0

 Attachments: 7382-trunk-v3.txt, 7382-trunk-v4.txt, 
 HBASE-7382-trunk.patch


 HBASE-6775 adds support for ZK.multi ZKUtil and uses it for the 0.92/0.94 
 compatibility fix implemented in HBASE-6710.
 ZK.multi support is most likely useful in 0.96, but since HBASE-6710 is not 
 relevant for 0.96, perhaps we should find another use case first before we 
 port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Gregory Chanan (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562250#comment-13562250
]

Gregory Chanan commented on HBASE-7382:
---

#1. I think the hbase-default.xml description is too complicated. If I'm a
user, I just want a general idea of what it's used for and a pointer for more
information if I want to dig in. Your description could be a good release note
for HBASE-2611?

How about this instead:
{code}
This allows certain ZooKeeper operations to complete more quickly and prevents
some issues
with rare Replication failure scenarios (see the release note of HBASE-2611 for
an example).
{code}

#2. It worries me a little bit that a SetData and a CreateAndFailSilent with
the same path/data will have the same hash. That is probably a rare situation,
but better to make them different?

I'm +1 otherwise.

Port ZK.multi support from HBASE-6775 to 0.96
-

Attachments: 7382-trunk-v3.txt, 7382-trunk-v4.txt, 7382-trunk-v5.txt,
HBASE-7382-trunk.patch

[jira] [Commented] (HBASE-7382) Port ZK.multi support from HBASE-6775 to 0.96

2013-01-24 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562279#comment-13562279
]

Hadoop QA commented on HBASE-7382:
--

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12566423/7382-trunk-v5.txt
against trunk revision .