[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306559#comment-16306559 ] Hudson commented on HBASE-8518: --- FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4308 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4308/]) HBASE-8518 Get rid of hbase.hstore.compaction.complete setting (chia7712: rev a21eb68f9584e69157fed683cc512ee3e8963dfb) * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Kuan-Po Tseng >Priority: Minor > Labels: beginner > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-8518-1.patch, HBASE-8518.master.v0.patch, > HBASE-8518.master.v1.patch, HBASE-8518.master.v2.patch, > HBASE-8518.master.v3.patch, HBASE-8518.master.v4.patch, > HBASE-8518.master.v5.patch, HBASE-8518.wip.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[
https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306515#comment-16306515
]
Hadoop QA commented on HBASE-8518:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
51s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
8s{color} | {color:red} hbase-server: The patch generated 1 new + 109 unchanged
- 0 fixed = 110 total (was 109) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
46s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 6s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 99m 54s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
46s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}153m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-8518 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12904028/HBASE-8518.master.v4.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1f27e47cc607 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 5a1c36f70a |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306507#comment-16306507 ] Chia-Ping Tsai commented on HBASE-8518: --- TestMemstoreLABWithoutPool pass locally, and it should be unrelated to the patch. Will commit it with checkstyle fixes. > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Kuan-Po Tseng >Priority: Minor > Labels: beginner > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-8518-1.patch, HBASE-8518.master.v0.patch, > HBASE-8518.master.v1.patch, HBASE-8518.master.v2.patch, > HBASE-8518.master.v3.patch, HBASE-8518.master.v4.patch, > HBASE-8518.master.v5.patch, HBASE-8518.wip.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[
https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306485#comment-16306485
]
Hadoop QA commented on HBASE-8518:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
7s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
7s{color} | {color:red} hbase-server: The patch generated 1 new + 109 unchanged
- 0 fixed = 110 total (was 109) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 26m 19s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 14m
14s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 82m 42s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestMemstoreLABWithoutPool |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-8518 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12904034/HBASE-8518.master.v5.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6960959a20b8 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 5a1c36f70a |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d;
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[
https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306425#comment-16306425
]
Chia-Ping Tsai commented on HBASE-8518:
---
Replace the "hbase.hregion.impl" by HConstants.REGION_IMPL
{code}
public void testRecoveredEditsReplayCompaction(boolean mismatchedRegionName)
throws Exception {
+CONF.setClass("hbase.hregion.impl", HRegionForTesting.class, Region.class);
{code}
The IA.Private is unnecessary in this test file.
{code}
+ @InterfaceAudience.Private
+ public static class HStoreForTesting extends HStore {
{code}
{code}
+ @InterfaceAudience.Private
+ public static class HRegionForTesting extends HRegion {
{code}
> Get rid of hbase.hstore.compaction.complete setting
> ---
>
> Key: HBASE-8518
> URL: https://issues.apache.org/jira/browse/HBASE-8518
> Project: HBase
> Issue Type: Improvement
>Reporter: Sergey Shelukhin
>Assignee: Kuan-Po Tseng
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-8518-1.patch, HBASE-8518.master.v0.patch,
> HBASE-8518.master.v1.patch, HBASE-8518.master.v2.patch,
> HBASE-8518.master.v3.patch, HBASE-8518.master.v4.patch, HBASE-8518.wip.patch
>
>
> hbase.hstore.compaction.complete is a strange setting that causes the
> finished compaction to not complete (files are just left in tmp) in HStore.
> It's used by one test.
> The setting with the same name is also used by CompactionTool, but that usage
> is semi-unrelated and could probably be removed easily.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[
https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306340#comment-16306340
]
Mike Drob commented on HBASE-8518:
--
{code}
+/**
+ * If CF isn't MobEnabled, return HStoreForTesting.
+ * @param family
+ * @return HStoreForTesting, a HStore for testing.
+ * @throws IOException
+ */
+@Override
+protected HStore instantiateHStore(final ColumnFamilyDescriptor family)
throws IOException {
{code}
nit: remove or add docs on family and throws, please.
> Get rid of hbase.hstore.compaction.complete setting
> ---
>
> Key: HBASE-8518
> URL: https://issues.apache.org/jira/browse/HBASE-8518
> Project: HBase
> Issue Type: Improvement
>Reporter: Sergey Shelukhin
>Assignee: Kuan-Po Tseng
>Priority: Minor
> Labels: beginner
> Attachments: HBASE-8518-1.patch, HBASE-8518.master.v0.patch,
> HBASE-8518.master.v1.patch, HBASE-8518.master.v2.patch,
> HBASE-8518.master.v3.patch, HBASE-8518.wip.patch
>
>
> hbase.hstore.compaction.complete is a strange setting that causes the
> finished compaction to not complete (files are just left in tmp) in HStore.
> It's used by one test.
> The setting with the same name is also used by CompactionTool, but that usage
> is semi-unrelated and could probably be removed easily.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[
https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306246#comment-16306246
]
Chia-Ping Tsai commented on HBASE-8518:
---
Remove the {{VisibleForTesting}} from the test files.
{code}
+ @InterfaceAudience.Private
+ @VisibleForTesting
+ public static class HStoreForTesting extends HStore {
{code}
Remove the unused docs.
{code}
+/**
+ * Constructor
+ * @param region
+ * @param family
+ * @param confParam
+ * @throws IOException
+ */
+@VisibleForTesting
{code}
Otherwise LGTM
> Get rid of hbase.hstore.compaction.complete setting
> ---
>
> Key: HBASE-8518
> URL: https://issues.apache.org/jira/browse/HBASE-8518
> Project: HBase
> Issue Type: Improvement
>Reporter: Sergey Shelukhin
>Assignee: Kuan-Po Tseng
>Priority: Minor
> Labels: beginner
> Attachments: HBASE-8518-1.patch, HBASE-8518.master.v0.patch,
> HBASE-8518.master.v1.patch, HBASE-8518.master.v2.patch, HBASE-8518.wip.patch
>
>
> hbase.hstore.compaction.complete is a strange setting that causes the
> finished compaction to not complete (files are just left in tmp) in HStore.
> It's used by one test.
> The setting with the same name is also used by CompactionTool, but that usage
> is semi-unrelated and could probably be removed easily.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304120#comment-16304120 ] Kuan-Po Tseng commented on HBASE-8518: -- [~chia7712] Thanks for your comment. I will give it a try. > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Kuan-Po Tseng >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304099#comment-16304099 ] Chia-Ping Tsai commented on HBASE-8518: --- bq. And I don't know this solution is okay or not. You can change the HRegion instance by the configuration. And then override the HRegion#instantiateHStore to create your HStore. If you are busy, I can offer the patch. :) > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Kuan-Po Tseng >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125785#comment-16125785 ] brandboat commented on HBASE-8518: -- And I don't know this solution is okay or not. > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: brandboat >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125782#comment-16125782 ] brandboat commented on HBASE-8518: -- To keep this test "testRecoveredEditsReplayCompaction()", there must have a way to let compaction not complete. What I have already thought now is add another TestHRegion extends from HRegion, overriding all method which uses HStore and replace all HStore to TestHStore which has a method that we can trigger compaction not complete. But the problem is if HRegion has something changed inside the mehtod that I have already overrided, this patch would lose efficacy. > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: brandboat >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113192#comment-16113192 ] Chia-Ping Tsai commented on HBASE-8518: --- bq. may I take over this issue ? Go ahead. > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: brandboat >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113045#comment-16113045 ] brandboat commented on HBASE-8518: -- [~sershe], [~chia7712] , may I take over this issue ? It seems that samar has already removed the hbase.hstore.compaction.complete in the CompactTool.java and HStore.java in patch. The remaining is refactor the test code, right ? > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664387#comment-13664387 ] Sergey Shelukhin commented on HBASE-8518: - The test is necessary by itself... there should be better hook to induce compaction failures in HStore, maybe some refactoring Get rid of hbase.hstore.compaction.complete setting --- Key: HBASE-8518 URL: https://issues.apache.org/jira/browse/HBASE-8518 Project: HBase Issue Type: Improvement Reporter: Sergey Shelukhin Priority: Minor Labels: noob Attachments: HBASE-8518-1.patch hbase.hstore.compaction.complete is a strange setting that causes the finished compaction to not complete (files are just left in tmp) in HStore. It's used by one test. The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated and could probably be removed easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664642#comment-13664642 ] Enis Soztutar commented on HBASE-8518: -- bq. The test is necessary by itself. +1. We have to refactor the test to instead not rely on uncomplete compactions. Get rid of hbase.hstore.compaction.complete setting --- Key: HBASE-8518 URL: https://issues.apache.org/jira/browse/HBASE-8518 Project: HBase Issue Type: Improvement Reporter: Sergey Shelukhin Priority: Minor Labels: noob Attachments: HBASE-8518-1.patch hbase.hstore.compaction.complete is a strange setting that causes the finished compaction to not complete (files are just left in tmp) in HStore. It's used by one test. The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated and could probably be removed easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660509#comment-13660509 ] samar commented on HBASE-8518: -- the test testRecoveredEditsReplayCompaction is centered around the hbase.hstore.compaction.complete setting. First it sets it so that compaction happens.. then it manually tries to complete the compaction by moving the files from the tmp and writeCompactionWalRecord. As the variable would be gone there would be no files in tmp, and compaction would have been written to wal. with the hbase.hstore.compaction.complete gone would it still make sense the have the test. The only way to still have it is we could not let the compaction complete happen. Get rid of hbase.hstore.compaction.complete setting --- Key: HBASE-8518 URL: https://issues.apache.org/jira/browse/HBASE-8518 Project: HBase Issue Type: Improvement Reporter: Sergey Shelukhin Priority: Minor Labels: noob Attachments: HBASE-8518-1.patch hbase.hstore.compaction.complete is a strange setting that causes the finished compaction to not complete (files are just left in tmp) in HStore. It's used by one test. The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated and could probably be removed easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660511#comment-13660511 ] samar commented on HBASE-8518: -- My last statement was not clear. I meant to say , we can have the test case , if we can allow the compaction to happen but compaction complete to fail. Suggestions please Get rid of hbase.hstore.compaction.complete setting --- Key: HBASE-8518 URL: https://issues.apache.org/jira/browse/HBASE-8518 Project: HBase Issue Type: Improvement Reporter: Sergey Shelukhin Priority: Minor Labels: noob Attachments: HBASE-8518-1.patch hbase.hstore.compaction.complete is a strange setting that causes the finished compaction to not complete (files are just left in tmp) in HStore. It's used by one test. The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated and could probably be removed easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[
https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659334#comment-13659334
]
Hadoop QA commented on HBASE-8518:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583437/HBASE-8518-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestMasterShutdown
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5715//console
This message is automatically generated.
Get rid of hbase.hstore.compaction.complete setting
---
Key: HBASE-8518
URL: https://issues.apache.org/jira/browse/HBASE-8518
Project: HBase
Issue Type: Improvement
Reporter: Sergey Shelukhin
Priority: Minor
Labels: noob
Attachments: HBASE-8518-1.patch
hbase.hstore.compaction.complete is a strange setting that causes the
finished compaction to not complete (files are just left in tmp) in HStore.
It's used by one test.
The setting with the same name is also used by CompactionTool, but that usage
is semi-unrelated and could probably be removed easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659415#comment-13659415 ] samar commented on HBASE-8518: -- TestMasterShutdown test failure may not be related to the current patch Get rid of hbase.hstore.compaction.complete setting --- Key: HBASE-8518 URL: https://issues.apache.org/jira/browse/HBASE-8518 Project: HBase Issue Type: Improvement Reporter: Sergey Shelukhin Priority: Minor Labels: noob Attachments: HBASE-8518-1.patch hbase.hstore.compaction.complete is a strange setting that causes the finished compaction to not complete (files are just left in tmp) in HStore. It's used by one test. The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated and could probably be removed easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659912#comment-13659912 ] Sergey Shelukhin commented on HBASE-8518: - The test should be modified rather then removed, it's actually useful... the rest looks good Get rid of hbase.hstore.compaction.complete setting --- Key: HBASE-8518 URL: https://issues.apache.org/jira/browse/HBASE-8518 Project: HBase Issue Type: Improvement Reporter: Sergey Shelukhin Priority: Minor Labels: noob Attachments: HBASE-8518-1.patch hbase.hstore.compaction.complete is a strange setting that causes the finished compaction to not complete (files are just left in tmp) in HStore. It's used by one test. The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated and could probably be removed easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660192#comment-13660192 ] Enis Soztutar commented on HBASE-8518: -- Thanks for the patch. You should not remove the test but fix it instead. Get rid of hbase.hstore.compaction.complete setting --- Key: HBASE-8518 URL: https://issues.apache.org/jira/browse/HBASE-8518 Project: HBase Issue Type: Improvement Reporter: Sergey Shelukhin Priority: Minor Labels: noob Attachments: HBASE-8518-1.patch hbase.hstore.compaction.complete is a strange setting that causes the finished compaction to not complete (files are just left in tmp) in HStore. It's used by one test. The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated and could probably be removed easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658251#comment-13658251 ] samar commented on HBASE-8518: -- Looks like a flag which allow compacted files to be created but not used. May be someone who wants to see the time /size of compaction without affecting the stores. Does not seem very useful. Get rid of hbase.hstore.compaction.complete setting --- Key: HBASE-8518 URL: https://issues.apache.org/jira/browse/HBASE-8518 Project: HBase Issue Type: Improvement Reporter: Sergey Shelukhin Priority: Minor Labels: noob hbase.hstore.compaction.complete is a strange setting that causes the finished compaction to not complete (files are just left in tmp) in HStore. It's used by one test. The setting with the same name is also used by CompactionTool, but that usage is semi-unrelated and could probably be removed easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
