[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866490#comment-13866490 ] Anoop Sam John commented on HBASE-9846: --- bq.-1 javadoc. The javadoc tool appears to have generated 2 warning messages. Is this related Ram? Else all look good. +1 Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch, HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866620#comment-13866620
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622152/HBASE-9846_7.patch
against trunk revision .
ATTACHMENT ID: 12622152
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 40 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8376//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch, HBASE-9846_1.patch,
HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch,
HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch, HBASE-9846_7.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866920#comment-13866920 ] Hudson commented on HBASE-9846: --- FAILURE: Integrated in HBase-TRUNK #4802 (See [https://builds.apache.org/job/HBase-TRUNK/4802/]) HBASE-9846-Integration test and LoadTestTool support for cell ACLs(Ram) (ramkrishna: rev 1556866) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithACL.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGeneratorWithACL.java Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0, 0.99.0 Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch, HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch, HBASE-9846_7.patch Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866976#comment-13866976 ] Hudson commented on HBASE-9846: --- SUCCESS: Integrated in HBase-0.98 #66 (See [https://builds.apache.org/job/HBase-0.98/66/]) HBASE-9846-Integration test and LoadTestTool support for cell ACLs (Ram) (ramkrishna: rev 1556868) * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithACL.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGeneratorWithACL.java Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0, 0.99.0 Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch, HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch, HBASE-9846_7.patch Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867000#comment-13867000 ] Hudson commented on HBASE-9846: --- FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #60 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/60/]) HBASE-9846-Integration test and LoadTestTool support for cell ACLs (Ram) (ramkrishna: rev 1556868) * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithACL.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGeneratorWithACL.java Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0, 0.99.0 Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch, HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch, HBASE-9846_7.patch Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867151#comment-13867151 ] Hudson commented on HBASE-9846: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #47 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/47/]) HBASE-9846-Integration test and LoadTestTool support for cell ACLs(Ram) (ramkrishna: rev 1556866) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithACL.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGeneratorWithACL.java Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0, 0.99.0 Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch, HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch, HBASE-9846_7.patch Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865186#comment-13865186
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621925/HBASE-9846_5.patch
against trunk revision .
ATTACHMENT ID: 12621925
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 34 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8360//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch, HBASE-9846_1.patch,
HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch,
HBASE-9846_5.patch, HBASE-9846_5.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865408#comment-13865408
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621960/HBASE-9846_6.patch
against trunk revision .
ATTACHMENT ID: 12621960
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 40 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8365//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch, HBASE-9846_1.patch,
HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch,
HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865725#comment-13865725 ] Andrew Purtell commented on HBASE-9846: --- +1 Javadoc for the new integration test should be updated to describe what it checks for. Can be fixed up at commit time. Thanks a lot Ram! Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch, HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866303#comment-13866303 ] ramkrishna.s.vasudevan commented on HBASE-9846: --- Thanks for the review and +1 Andy. Will commit later in the evening unless objections. Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch, HBASE-9846_5.patch, HBASE-9846_5.patch, HBASE-9846_6.patch Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863999#comment-13863999
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621756/HBASE-9846_3.patch
against trunk revision .
ATTACHMENT ID: 12621756
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 37 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the trunk's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+updaterThreads = new MultiThreadedUpdaterWithACL(dataGen, conf,
tableName, updatePercent, userOwner);
+LOG.error(Failed to mutate: + keyBase + after +
(System.currentTimeMillis() - start) +
+private void recordFailure(final Mutation m, final long keyBase, final
long start, IOException e) {
+LOG.error(Failed to insert: + keyBase + after +
(System.currentTimeMillis() - start) +
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8354//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch, HBASE-9846_1.patch,
HBASE-9846_2.patch, HBASE-9846_3.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864042#comment-13864042
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621767/HBASE-9846_4.patch
against trunk revision .
ATTACHMENT ID: 12621767
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 37 new
or modified tests.
{color:red}-1 hadoop1.0{color}. The patch failed to compile against the
hadoop 1.0 profile.
Here is snippet of errors:
{code}[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile
(default-testCompile) on project hbase-server: Compilation failure: Compilation
failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java:[568,10]
cannot find symbol
[ERROR] symbol : class LoadTestDataGenerator
[ERROR] location: class org.apache.hadoop.hbase.util.LoadTestTool
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java:[443,4]
cannot find symbol
[ERROR] symbol : class LoadTestDataGenerator
--
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile
(default-testCompile) on project hbase-server: Compilation failure
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
--
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation
failure
at
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
at
org.apache.maven.plugin.TestCompilerMojo.execute(TestCompilerMojo.java:161)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more{code}
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8356//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch, HBASE-9846_1.patch,
HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864787#comment-13864787
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621820/HBASE-9846_5.patch
against trunk revision .
ATTACHMENT ID: 12621820
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 34 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the trunk's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static GrantResponse grant(Configuration conf, final TableName
tableName, final String userName,
+ * Maps user with Table instance. Because the table instance has to be
created per user inorder to work
+ * Maps user with Table instance. Because the table instance has to be
created per user inorder to work
+private void recordFailure(final Mutation m, final long keyBase, final
long start, IOException e) {
+LOG.error(Failed to insert: + keyBase + after +
(System.currentTimeMillis() - start) +
+ + 1st arguement which would be the user list and the 2nd argument
should be the factor representing +
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8357//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch, HBASE-9846_1.patch,
HBASE-9846_2.patch, HBASE-9846_3.patch, HBASE-9846_4.patch, HBASE-9846_5.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862943#comment-13862943 ] ramkrishna.s.vasudevan commented on HBASE-9846: --- https://reviews.apache.org/r/16646/ - RB link. Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862987#comment-13862987
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621590/HBASE-9846_2.patch
against trunk revision .
ATTACHMENT ID: 12621590
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 37 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the trunk's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Batch.CallAccessControlService, GrantResponse callable = new
Batch.CallAccessControlService, GrantResponse() {
+ AccessControlProtos.TablePermission.Builder permissionBuilder =
AccessControlProtos.TablePermission
+AccessControlProtos.Permission.Action.READ,
AccessControlProtos.Permission.Action.WRITE };
+ AccessControlClient.grant(conf, table, userOwner.getShortName(),
COLUMN_FAMILY, null, actions);
+updaterThreads = new MultiThreadedUpdaterWithACL(dataGen, conf,
tableName, updatePercent, userOwner);
+LOG.error(Failed to mutate: + keyBase + after +
(System.currentTimeMillis() - start) +
+private void recordFailure(final Mutation m, final long keyBase, final
long start, IOException e) {
+LOG.error(Failed to insert: + keyBase + after +
(System.currentTimeMillis() - start) +
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8346//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch, HBASE-9846_1.patch, HBASE-9846_2.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861387#comment-13861387
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621280/HBASE-9846_1.patch
against trunk revision .
ATTACHMENT ID: 12621280
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 55 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+String.format(%d:%d:%d, colsPerKey, recordSize,
writeThreads), startKey, numKeys));
+ Batch.CallAccessControlService, GrantResponse callable = new
Batch.CallAccessControlService, GrantResponse() {
+ AccessControlProtos.TablePermission.Builder permissionBuilder =
AccessControlProtos.TablePermission
+ public static final String OPT_USAGE_ACL_USERS = Specifies the users that
will be associated with the permissions. Users will be +
+ picked up in a round robin fashion. In order to use this option
AccessController should be turned on.;
+ public static final String OPT_USAGE_ACL_PERMS = Specifies the permissions
that needs to be added. Permissions will be +
+ picked up in a round robin fashion. Every permission will be
mapped with the users specified +
+ Eg: READ:WRITE, READ, ADMIN. If the acl_users are 'user1,
'user2','user3' then user1 will have READ and WRITE permissions, +
+user2 will have READ permission and user3 will have ADMIN
permissions. In order to use this option AccessController should be turned on.;
+AccessControlProtos.Permission.Action.READ,
AccessControlProtos.Permission.Action.WRITE };
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8329//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch, HBASE-9846_1.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[
https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861203#comment-13861203
]
Hadoop QA commented on HBASE-9846:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620917/HBASE-9846.patch
against trunk revision .
ATTACHMENT ID: 12620917
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 55 new
or modified tests.
{color:red}-1 hadoop1.0{color}. The patch failed to compile against the
hadoop 1.0 profile.
Here is snippet of errors:
{code}[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile
(default-testCompile) on project hbase-it: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java:[277,29]
cannot find symbol
[ERROR] symbol : method
verifyResultAgainstDataGenerator(org.apache.hadoop.hbase.client.Result,boolean,boolean)
[ERROR] location: class org.apache.hadoop.hbase.util.MultiThreadedWriter
[ERROR] - [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile
(default-testCompile) on project hbase-it: Compilation failure
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java:[277,29]
cannot find symbol
symbol : method
verifyResultAgainstDataGenerator(org.apache.hadoop.hbase.client.Result,boolean,boolean)
location: class org.apache.hadoop.hbase.util.MultiThreadedWriter
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
--
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation
failure
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java:[277,29]
cannot find symbol
symbol : method
verifyResultAgainstDataGenerator(org.apache.hadoop.hbase.client.Result,boolean,boolean)
location: class org.apache.hadoop.hbase.util.MultiThreadedWriter
at
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729){code}
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8325//console
This message is automatically generated.
Integration test and LoadTestTool support for cell ACLs
---
Key: HBASE-9846
URL: https://issues.apache.org/jira/browse/HBASE-9846
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: ramkrishna.s.vasudevan
Fix For: 0.98.0
Attachments: HBASE-9846.patch
Cell level ACLs should have an integration test and LoadTestTool support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859034#comment-13859034 ] Andrew Purtell commented on HBASE-9846: --- See https://issues.apache.org/jira/browse/HBASE-9858?focusedCommentId=13859033page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13859033 Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859350#comment-13859350 ] ramkrishna.s.vasudevan commented on HBASE-9846: --- Yes. Also adding some more changes to verify the results in case it is null based on user. Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858324#comment-13858324 ] ramkrishna.s.vasudevan commented on HBASE-9846: --- Thanks Andy for your suggestions. bq.As far as running under different users, you have to open the HTable in the wanted security context not just switch to it for operations on an HTable opened by a different subject earlier I did this and it works. I modified things in the Reader/Writer/Updater threads to suppor this model. So the 2nd part of the suggestion we would work up along with HBASE-9858. Though the generator part is going to be the same the changes for ACL would come from this patch. Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857614#comment-13857614 ] Andrew Purtell commented on HBASE-9846: --- See my comment on the related issue for visibility labels. I think we should be plugging in data generator classes specified on the command line instead of hacking the tool with lots of special case CLI options. As far as running under different users, you have to open the HTable in the wanted security context not just switch to it for operations on an HTable opened by a different subject earlier. To keep things simple what about launching multiple tools in threads started with doAs to set the desired security context ahead of its initialization. With the -skip_init option a LoadTestTool instance will start up against an existing table without taking any admin actions. Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857618#comment-13857618 ] Andrew Purtell commented on HBASE-9846: --- As for testing the ACL and labels features themselves, LTT generates keys using an integer counter, and prepends a md5 hash of the counter to it to construct the full key. Point is we can reserve ranges of the counter values as readable and not readable and then test for that. Could be a range or a modulus (e.g. counter % 100 is not readable by user X). Here it would make sense to modify LTT and its CLI to accept parameters that communicate an expected number of read failures. Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857305#comment-13857305 ] ramkrishna.s.vasudevan commented on HBASE-9846: --- I tried out the pattern in HBASE-9858 but the core change is that extended the MultiThreadedReader/Writer/Updater and overridden some of the methods in them. So wanted to execute the puts/gets and all the mutations as a specific user. The user list and the permissions are passed as input to the tool. When we run this as a cluster how to run a specific action with a specific user? Using user.runAs did not work as expected. Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: ramkrishna.s.vasudevan Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856277#comment-13856277 ] ramkrishna.s.vasudevan commented on HBASE-9846: --- Can i take this up? Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856435#comment-13856435 ] Andrew Purtell commented on HBASE-9846: --- Sure! Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Sub-task Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9846) Integration test and LoadTestTool support for cell ACLs
[ https://issues.apache.org/jira/browse/HBASE-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13805901#comment-13805901 ] Andrew Purtell commented on HBASE-9846: --- What ACLs to include on what cells is dependent on test scenario. Might make sense to do this building on or in conjunction with HBASE-9824 so we can reach in and replace the KV generator. Integration test and LoadTestTool support for cell ACLs --- Key: HBASE-9846 URL: https://issues.apache.org/jira/browse/HBASE-9846 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0 Cell level ACLs should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1#6144)
