[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861435#comment-13861435
]
Hadoop QA commented on HBASE-9858:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621288/HBASE-9858_V4.patch
against trunk revision .
ATTACHMENT ID: 12621288
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 49 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8330//console
This message is automatically generated.
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch, HBASE-9858_V2.patch,
HBASE-9858_V3.patch, HBASE-9858_V4.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861503#comment-13861503 ] Ted Yu commented on HBASE-9858: --- +1 Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0 Attachments: HBASE-9858.patch, HBASE-9858_V2.patch, HBASE-9858_V3.patch, HBASE-9858_V4.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861771#comment-13861771 ] Hudson commented on HBASE-9858: --- SUCCESS: Integrated in HBase-TRUNK #4783 (See [https://builds.apache.org/job/HBase-TRUNK/4783/]) HBASE-9858 Integration test and LoadTestTool support for cell Visibility (anoopsamjohn: rev 1555145) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngest.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithTags.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithVisibilityLabels.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/StripeCompactionsPerformanceEvaluation.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedAction.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadParallel.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0, 0.99.0 Attachments: HBASE-9858.patch, HBASE-9858_V2.patch, HBASE-9858_V3.patch, HBASE-9858_V4.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861832#comment-13861832 ] Hudson commented on HBASE-9858: --- SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #49 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/49/]) HBASE-9858 Integration test and LoadTestTool support for cell Visibility (anoopsamjohn: rev 1555148) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngest.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithTags.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithVisibilityLabels.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/StripeCompactionsPerformanceEvaluation.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedAction.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadParallel.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0, 0.99.0 Attachments: HBASE-9858.patch, HBASE-9858_V2.patch, HBASE-9858_V3.patch, HBASE-9858_V4.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861837#comment-13861837 ] Hudson commented on HBASE-9858: --- SUCCESS: Integrated in HBase-0.98 #53 (See [https://builds.apache.org/job/HBase-0.98/53/]) HBASE-9858 Integration test and LoadTestTool support for cell Visibility (anoopsamjohn: rev 1555148) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngest.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithTags.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithVisibilityLabels.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java * /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/StripeCompactionsPerformanceEvaluation.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedAction.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadParallel.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0, 0.99.0 Attachments: HBASE-9858.patch, HBASE-9858_V2.patch, HBASE-9858_V3.patch, HBASE-9858_V4.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861937#comment-13861937 ] Hudson commented on HBASE-9858: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #40 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/40/]) HBASE-9858 Integration test and LoadTestTool support for cell Visibility (anoopsamjohn: rev 1555145) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngest.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithTags.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithVisibilityLabels.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/StripeCompactionsPerformanceEvaluation.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestDataGeneratorWithTags.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedAction.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadParallel.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0, 0.99.0 Attachments: HBASE-9858.patch, HBASE-9858_V2.patch, HBASE-9858_V3.patch, HBASE-9858_V4.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860899#comment-13860899 ] Andrew Purtell commented on HBASE-9858: --- +1 v2 patch lgtm Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0 Attachments: HBASE-9858.patch, HBASE-9858_V2.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860981#comment-13860981
]
Ted Yu commented on HBASE-9858:
---
Typo - should be hyphen:
{code}
+ public static final char HIPHON = '-';
{code}
{code}
- int colsPerKey, int recordSize, int writeThreads, boolean useTags, int
maxTagsPerKey) throws Exception {
+ protected void runIngestTest(long defaultRunTime, int keysPerServerPerIter,
int colsPerKey,
+ int recordSize, int writeThreads) throws Exception {
{code}
The last two parameters are removed because they're not used ?
{code}
+ private static final String[] VISIBILITY_EXPS = { secret confidential
!private,
+ topsecret | confidential, confidential private, public,
topsecret private };
{code}
Can you add expression involving '|' and '!' at the same time ?
{code}
+public class LoadTestDataGeneratorWithVisibilityLabels extends
DefaultDataGenerator {
{code}
Mind adding annotation for audience ?
Same for this class:
{code}
+public class LoadTestDataGeneratorWithTags extends DefaultDataGenerator {
{code}
{code}
+ throw new IllegalArgumentException(LoadTestDataGeneratorWithTags must
have
+ + 4 initialization arguments);
{code}
Mind adding short description of what purpose the 4 arguments serve ?
{code}
+ public void start(long startKey, long endKey, int numThreads) throws
IOException {
+ super.start(startKey, endKey, numThreads);
{code}
nit: indentation
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch, HBASE-9858_V2.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861168#comment-13861168 ] Anoop Sam John commented on HBASE-9858: --- bq.The last two parameters are removed because they're not used ? No. Previously LoadTestTool was having boolean whether to use tags and other tag specific details so that it was getting used in Mutation generation. Now we moved this out to Generator class. We have a LoadTestDataGeneratorWithTags which deals with this maxTagsPerKey etc. I will work on other comments and give an updated patch soon Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0 Attachments: HBASE-9858.patch, HBASE-9858_V2.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861275#comment-13861275
]
Hadoop QA commented on HBASE-9858:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621250/HBASE-9858_V3.patch
against trunk revision .
ATTACHMENT ID: 12621250
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 49 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8327//console
This message is automatically generated.
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch, HBASE-9858_V2.patch,
HBASE-9858_V3.patch, HBASE-9858_V4.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861306#comment-13861306
]
Hadoop QA commented on HBASE-9858:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621259/HBASE-9858_V4.patch
against trunk revision .
ATTACHMENT ID: 12621259
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 49 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels
org.apache.hadoop.hbase.rest.TestScannersWithLabels
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8328//console
This message is automatically generated.
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch, HBASE-9858_V2.patch,
HBASE-9858_V3.patch, HBASE-9858_V4.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859033#comment-13859033 ] Andrew Purtell commented on HBASE-9858: --- Right, add some protected methods that allow extension of how gets and mutations are constructed, then create a generator under src/test in the security.visibility package that overrides these and does something interesting. We can then use this generator for testing by selecting it on the LTT command line. We can use the same approach for cell ACLs. Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0 Attachments: HBASE-9858.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859383#comment-13859383
]
Hadoop QA commented on HBASE-9858:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620906/HBASE-9858_V2.patch
against trunk revision .
ATTACHMENT ID: 12620906
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 49 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8308//console
This message is automatically generated.
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch, HBASE-9858_V2.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858572#comment-13858572
]
Anoop Sam John commented on HBASE-9858:
---
We already have a LoadTestDataGenerator which generates RKs, columns etc.
I am adding 2 new methods to this class.
{code}
public abstract Mutation beforeMutate(long rowkeyBase, Mutation m);
public abstract Get beforeGet(long rowkeyBase, Get get);
{code}
The Mutation/Get as such is created within LoadTestTool and related classes.
Before apply on to HTables, this generator can modify it. How abt this min
change Andy?Done these changes on this patch. I can change the Tags part
also in similar way.
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857419#comment-13857419 ] Anoop Sam John commented on HBASE-9858: --- Sure Andy. Let me try out ur suggestion Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0 Attachments: HBASE-9858.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857156#comment-13857156
]
Andrew Purtell commented on HBASE-9858:
---
In my opinion, it's ok to add command line switches to LTT for new schema
features/settings or modes of operation. However, when we get down into the
details of how cells should be constructed, and what tags to use, and such, it
gets ugly fast. I think the existing command line flag for adding tags should
be removed actually.
Let's consider a new command line option that specifies a class to use for
value generation. The parameter can be a colon delimited one, like -read and
-write. The first element would be the name of the class and all remaining
elements, if present, would be passed as String[] to the class to initialize
it, e.g. {{-generator
org.apache.hadoop.hbase.security.visibility.LoadTestDataGenerator}}.
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856623#comment-13856623
]
ramkrishna.s.vasudevan commented on HBASE-9858:
---
I think the line
{code}
if (!(m instanceof Delete) visibilityExps != null visibilityExps.length
0) {
+ m.setCellVisibility(new CellVisibility(
+ visibilityExps[(int) (keyBase % visibilityExps.length)]));
+}
{code}
is needed here also in MultiThreadedUpdater
{code}
case PUT:
Put put = new Put(rowKey);
put.add(cf, column, hashCodeBytes);
mutate(table, put, rowKeyBase, rowKey, cf, column,
checkedValue);
buf.append(MutationType.PUT.getNumber());
break;
{code}
Sorry for missing this.
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856274#comment-13856274 ] Anoop Sam John commented on HBASE-9858: --- Not addressing HBASE-9824 here. We can visit that later and make necessary changes in all Tests which uses LoadTestTool. Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0 Attachments: HBASE-9858.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856280#comment-13856280 ] ramkrishna.s.vasudevan commented on HBASE-9858: --- +1 on patch. Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0 Attachments: HBASE-9858.patch Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856331#comment-13856331
]
Hadoop QA commented on HBASE-9858:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620329/HBASE-9858.patch
against trunk revision .
ATTACHMENT ID: 12620329
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 39 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8279//console
This message is automatically generated.
Integration test and LoadTestTool support for cell Visibility
-
Key: HBASE-9858
URL: https://issues.apache.org/jira/browse/HBASE-9858
Project: HBase
Issue Type: Sub-task
Components: security
Affects Versions: 0.98.0
Reporter: Anoop Sam John
Assignee: Anoop Sam John
Fix For: 0.98.0
Attachments: HBASE-9858.patch
Cell level visibility should have an integration test and LoadTestTool
support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-9858) Integration test and LoadTestTool support for cell Visibility
[ https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834275#comment-13834275 ] Andrew Purtell commented on HBASE-9858: --- This is related to HBASE-9846. In both cases, how would we accomplish this? With HBASE-9824? Integration test and LoadTestTool support for cell Visibility - Key: HBASE-9858 URL: https://issues.apache.org/jira/browse/HBASE-9858 Project: HBase Issue Type: Sub-task Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Fix For: 0.98.0 Cell level visibility should have an integration test and LoadTestTool support. -- This message was sent by Atlassian JIRA (v6.1#6144)
