[jira] [Commented] (HBASE-9880) client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867
[ https://issues.apache.org/jira/browse/HBASE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813758#comment-13813758 ] Hudson commented on HBASE-9880: --- FAILURE: Integrated in hbase-0.96-hadoop2 #113 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/113/]) HBASE-9880 client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867 (nkeywal: rev 1538676) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867 -- Key: HBASE-9880 URL: https://issues.apache.org/jira/browse/HBASE-9880 Project: HBase Issue Type: Test Reporter: stack Assignee: Nicolas Liochon Attachments: 9880.v1.patch It looks like the backport of HBASE-9867 broke 0.96 build (fine on trunk). This was my patch. Let me fix. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9880) client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867
[
https://issues.apache.org/jira/browse/HBASE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812773#comment-13812773
]
Nicolas Liochon commented on HBASE-9880:
It seems to be a real bug in the AsyncProcess, unrelated to the patch. I don't
know why it happens only now.
{code}
private void backgroundFlushCommits(boolean synchronous) throws
InterruptedIOException, RetriesExhaustedWithDetailsException {
if (!synchronous this.writeAsyncBuffer.isEmpty()) return;// this
is the fix
{code}
(ps: I'm not a jira-jacker :-), just that I had this failure in a patch I'm
going to push soon - hopefully -).
client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867
--
Key: HBASE-9880
URL: https://issues.apache.org/jira/browse/HBASE-9880
Project: HBase
Issue Type: Test
Reporter: stack
Assignee: stack
It looks like the backport of HBASE-9867 broke 0.96 build (fine on trunk).
This was my patch. Let me fix.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9880) client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867
[
https://issues.apache.org/jira/browse/HBASE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812867#comment-13812867
]
Nicolas Liochon commented on HBASE-9880:
trunk has this already. Not clear why 0.96 does not. There is no difference
between the two branches for AsyncProcess.
{noformat}
$ git diff 0.96 clean --
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
diff --git
a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
index 21447e0..00de79e 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
@@ -207,7 +207,7 @@ public class HTable implements HTableInterface {
this.pool = getDefaultExecutor(this.configuration);
this.finishSetup();
}
-
+
public static ThreadPoolExecutor getDefaultExecutor(Configuration conf) {
int maxThreads = conf.getInt(hbase.htable.threads.max,
Integer.MAX_VALUE);
if (maxThreads == 0) {
@@ -911,7 +911,6 @@ public class HTable implements HTableInterface {
*/
private void backgroundFlushCommits(boolean synchronous) throws
InterruptedIOException, RetriesExhaustedWithDetailsException {
-if (this.writeAsyncBuffer.isEmpty()) return;
try {
do {
@@ -1230,7 +1229,7 @@ public class HTable implements HTableInterface {
return;
}
flushCommits();
-if (cleanupPoolOnClose this.pool != null) {
+if (cleanupPoolOnClose) {
this.pool.shutdown();
}
if (cleanupConnectionOnClose) {
{noformat}
client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867
--
Key: HBASE-9880
URL: https://issues.apache.org/jira/browse/HBASE-9880
Project: HBase
Issue Type: Test
Reporter: stack
Assignee: stack
Attachments: 9880.v1.patch
It looks like the backport of HBASE-9867 broke 0.96 build (fine on trunk).
This was my patch. Let me fix.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9880) client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867
[ https://issues.apache.org/jira/browse/HBASE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812983#comment-13812983 ] stack commented on HBASE-9880: -- +1 on the patch. Did I fumble the application of HBASE-9867 to 0.96 leaving this line in? client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867 -- Key: HBASE-9880 URL: https://issues.apache.org/jira/browse/HBASE-9880 Project: HBase Issue Type: Test Reporter: stack Assignee: stack Attachments: 9880.v1.patch It looks like the backport of HBASE-9867 broke 0.96 build (fine on trunk). This was my patch. Let me fix. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9880) client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867
[ https://issues.apache.org/jira/browse/HBASE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812997#comment-13812997 ] Nicolas Liochon commented on HBASE-9880: Yes, actually it's in your patch in HBASE-9867. So at the end it's a good news, the test caught the issue. client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867 -- Key: HBASE-9880 URL: https://issues.apache.org/jira/browse/HBASE-9880 Project: HBase Issue Type: Test Reporter: stack Assignee: stack Attachments: 9880.v1.patch It looks like the backport of HBASE-9867 broke 0.96 build (fine on trunk). This was my patch. Let me fix. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9880) client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867
[ https://issues.apache.org/jira/browse/HBASE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813509#comment-13813509 ] Hudson commented on HBASE-9880: --- FAILURE: Integrated in hbase-0.96 #179 (See [https://builds.apache.org/job/hbase-0.96/179/]) HBASE-9880 client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867 (nkeywal: rev 1538676) * /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867 -- Key: HBASE-9880 URL: https://issues.apache.org/jira/browse/HBASE-9880 Project: HBase Issue Type: Test Reporter: stack Assignee: Nicolas Liochon Attachments: 9880.v1.patch It looks like the backport of HBASE-9867 broke 0.96 build (fine on trunk). This was my patch. Let me fix. -- This message was sent by Atlassian JIRA (v6.1#6144)
