[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835919#comment-13835919 ] Ted Yu commented on HBASE-9949: --- The fix was not in 0.96 > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0, 0.96.2 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt, 9949.addendum > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830742#comment-13830742 ] Andrew Purtell commented on HBASE-9949: --- bq. The testing bits were taken out through 9949.addendum Great, thanks Ted. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt, 9949.addendum > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830741#comment-13830741 ] Ted Yu commented on HBASE-9949: --- The testing bits were taken out through 9949.addendum > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt, 9949.addendum > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830737#comment-13830737 ] Andrew Purtell commented on HBASE-9949: --- Shall we revert the HBASE-9949 commit to trunk until we have consensus on the testing part? Seems both Jon and I, and probably Stack also given his comment on dev@, have an issue with the testing bits that were committed. (Sorry I didn't come around to this issue before it went it.) > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt, 9949.addendum > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826848#comment-13826848 ] Hudson commented on HBASE-9949: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #844 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/844/]) HBASE-9949 Addendum takes out test infrastructure and new test (tedyu: rev 1543305) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionEvent.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt, 9949.addendum > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[
https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826704#comment-13826704
]
Ted Yu commented on HBASE-9949:
---
@Jon:
I was thinking about the following approach for testing :
1. Introduce config parameter for StoreScanner implementation which would be
used by HStore for creating scanner
2. In TestStoreScanner, add StoreScanner implementation which extends
StoreScanner and set the above config parameter to this class.
3. Register custom ChangedReadersObserver through the following API of HStore :
{code}
public void addChangedReaderObserver(ChangedReadersObserver o) {
{code}
The BEFORE_SEEK hook would be activated before Store.getScanner() is called.
The AFTER_SEEK hook can be activated at the end of ctor of StoreScanner wrapper
created in #2
The custom ChangedReadersObserver would activate the COMPACT_COMPLETE hook.
What do you think ?
> Fix the race condition between Compaction and StoreScanner.init
> ---
>
> Key: HBASE-9949
> URL: https://issues.apache.org/jira/browse/HBASE-9949
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 0.89-fb
>Reporter: Manukranth Kolloju
>Assignee: Manukranth Kolloju
>Priority: Minor
> Fix For: 0.89-fb, 0.98.0
>
> Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt,
> 9949-trunk-v2.txt, 9949-trunk-v3.txt, 9949.addendum
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The StoreScanner constructor has multiple stages and there can be a race
> betwwen an ongoing compaction and the StoreScanner constructor where we might
> get the list of scanners before a compaction and seek on those scanners after
> the compaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826326#comment-13826326 ] Hudson commented on HBASE-9949: --- SUCCESS: Integrated in HBase-TRUNK #4687 (See [https://builds.apache.org/job/HBase-TRUNK/4687/]) HBASE-9949 Addendum takes out test infrastructure and new test (tedyu: rev 1543305) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionEvent.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt, 9949.addendum > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826177#comment-13826177 ] Ted Yu commented on HBASE-9949: --- Checked in addendum to trunk. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt, 9949.addendum > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826169#comment-13826169 ] Jonathan Hsieh commented on HBASE-9949: --- Sounds great. Thanks! Want to start the thread on dev list? > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826166#comment-13826166 ] Ted Yu commented on HBASE-9949: --- How about I take out the new infrastructure through an addendum and keep the fix (since you're fine with it). That would give us more time in streamlining proper test infrastructure for this ? > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826162#comment-13826162 ] Jonathan Hsieh commented on HBASE-9949: --- Hey [~te...@apache.org] commented on Friday or Thursday that I'm concerned about this infrastructure creeping in throughout the code. Specifically the in the main comment i mentioned that "This was not addressed" and then you committed without addressing the concern I had with the code in the review and there were no +1's in review board. (Though sergey had a conditional +1 in jira). I'm assuming this was a an oversight. To be clear, I'm basically fine with the fix -- I'm mostly concerned about the new framework. It seems like yet another infrastructure and it is one that I'm not particularly fond of because of it seems cumbersome and has the potential to perf impact in other areas if extended. This will take more work but it can be done in a way that makes the code more readable and maintainable and I'd rather we move in that direction instead of adding yet more one of infrastructures. Can we instead make use a factories patterns + mocks to do this injection? Happy to move this discussion to the mailing list. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824864#comment-13824864 ] Hudson commented on HBASE-9949: --- FAILURE: Integrated in hbase-0.96-hadoop2 #121 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/121/]) HBASE-9949 Revert due to TestHRegion failure (tedyu: rev 1542569) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionEvent.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824773#comment-13824773 ] Hudson commented on HBASE-9949: --- SUCCESS: Integrated in HBase-TRUNK #4682 (See [https://builds.apache.org/job/HBase-TRUNK/4682/]) HBASE-9949 Fix the race condition between Compaction and StoreScanner.init (tedyu: rev 1542519) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionEvent.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824757#comment-13824757 ] Hudson commented on HBASE-9949: --- SUCCESS: Integrated in hbase-0.96 #191 (See [https://builds.apache.org/job/hbase-0.96/191/]) HBASE-9949 Revert due to TestHRegion failure (tedyu: rev 1542569) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionEvent.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java HBASE-9949 Addendum removes readpoint parameter for getScanner() (tedyu: rev 1542528) * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824677#comment-13824677 ] Hudson commented on HBASE-9949: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #839 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/839/]) HBASE-9949 Fix the race condition between Compaction and StoreScanner.init (tedyu: rev 1542519) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionEvent.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824609#comment-13824609 ] Hudson commented on HBASE-9949: --- FAILURE: Integrated in hbase-0.96-hadoop2 #120 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/120/]) HBASE-9949 Addendum removes readpoint parameter for getScanner() (tedyu: rev 1542528) * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java HBASE-9949 Fix the race condition between Compaction and StoreScanner.init (tedyu: rev 1542518) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionEvent.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0, 0.96.1 > > Attachments: 9949-0.96.addendum, 9949-trunk-v1.txt, > 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824517#comment-13824517 ] Hudson commented on HBASE-9949: --- FAILURE: Integrated in hbase-0.96 #190 (See [https://builds.apache.org/job/hbase-0.96/190/]) HBASE-9949 Fix the race condition between Compaction and StoreScanner.init (tedyu: rev 1542518) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionEvent.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0, 0.96.1 > > Attachments: 9949-trunk-v1.txt, 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824492#comment-13824492 ] Ted Yu commented on HBASE-9949: --- Integrated to 0.96 and trunk. Thanks for the reviews, Jon and Sergey. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb, 0.98.0, 0.96.1 > > Attachments: 9949-trunk-v1.txt, 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823762#comment-13823762 ] Ted Yu commented on HBASE-9949: --- Planning to integrate over the weekend, if there is no further comment. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb > > Attachments: 9949-trunk-v1.txt, 9949-trunk-v2.txt, 9949-trunk-v3.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[
https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823265#comment-13823265
]
Hadoop QA commented on HBASE-9949:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614001/9949-trunk-v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7873//console
This message is automatically generated.
> Fix the race condition between Compaction and StoreScanner.init
> ---
>
> Key: HBASE-9949
> URL: https://issues.apache.org/jira/browse/HBASE-9949
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 0.89-fb
>Reporter: Manukranth Kolloju
>Assignee: Manukranth Kolloju
>Priority: Minor
> Fix For: 0.89-fb
>
> Attachments: 9949-trunk-v1.txt, 9949-trunk-v2.txt, 9949-trunk-v3.txt
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The StoreScanner constructor has multiple stages and there can be a race
> betwwen an ongoing compaction and the StoreScanner constructor where we might
> get the list of scanners before a compaction and seek on those scanners after
> the compaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823041#comment-13823041 ] Manukranth Kolloju commented on HBASE-9949: --- [~sershe], in prod, this operation should have absolutely low impact. The only concern if any should be about the readability of the code going forward. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb > > Attachments: 9949-trunk-v1.txt, 9949-trunk-v2.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[
https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822996#comment-13822996
]
Ted Yu commented on HBASE-9949:
---
By default InjectionHandler#processEvent() is no-op. There is no impact on
performance.
The test uses specialized InjectionHandler:
{code}
+StoreScannerCompactionRaceCondition ih =
+new StoreScannerCompactionRaceCondition(s, 5);
+InjectionHandler.set(ih);
{code}
> Fix the race condition between Compaction and StoreScanner.init
> ---
>
> Key: HBASE-9949
> URL: https://issues.apache.org/jira/browse/HBASE-9949
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 0.89-fb
>Reporter: Manukranth Kolloju
>Assignee: Manukranth Kolloju
>Priority: Minor
> Fix For: 0.89-fb
>
> Attachments: 9949-trunk-v1.txt, 9949-trunk-v2.txt
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The StoreScanner constructor has multiple stages and there can be a race
> betwwen an ongoing compaction and the StoreScanner constructor where we might
> get the list of scanners before a compaction and seek on those scanners after
> the compaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822975#comment-13822975 ] Sergey Shelukhin commented on HBASE-9949: - minor nit on rb, can be fixed on commit; I'm +0.9, noticed that [~jmhsieh] was also leery of the approach on RB. I think it may warrant more discussion - how we do this kind of stuff (since presumably this injection will start being used all over the place if committed), but if there's general agreement then I'm +1 > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb > > Attachments: 9949-trunk-v1.txt, 9949-trunk-v2.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[
https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822181#comment-13822181
]
Hadoop QA commented on HBASE-9949:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12613721/9949-trunk-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7852//console
This message is automatically generated.
> Fix the race condition between Compaction and StoreScanner.init
> ---
>
> Key: HBASE-9949
> URL: https://issues.apache.org/jira/browse/HBASE-9949
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 0.89-fb
>Reporter: Manukranth Kolloju
>Assignee: Manukranth Kolloju
>Priority: Minor
> Fix For: 0.89-fb
>
> Attachments: 9949-trunk-v1.txt, 9949-trunk-v2.txt
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The StoreScanner constructor has multiple stages and there can be a race
> betwwen an ongoing compaction and the StoreScanner constructor where we might
> get the list of scanners before a compaction and seek on those scanners after
> the compaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821724#comment-13821724 ] Sergey Shelukhin commented on HBASE-9949: - some code feedback on RB. It would be nice if one more person would look at general approach :) > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb > > Attachments: 9949-trunk-v1.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[
https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821032#comment-13821032
]
Hadoop QA commented on HBASE-9949:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12613482/9949-trunk-v1.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7832//console
This message is automatically generated.
> Fix the race condition between Compaction and StoreScanner.init
> ---
>
> Key: HBASE-9949
> URL: https://issues.apache.org/jira/browse/HBASE-9949
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 0.89-fb
>Reporter: Manukranth Kolloju
>Assignee: Manukranth Kolloju
>Priority: Minor
> Fix For: 0.89-fb
>
> Attachments: 9949-trunk-v1.txt
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The StoreScanner constructor has multiple stages and there can be a race
> betwwen an ongoing compaction and the StoreScanner constructor where we might
> get the list of scanners before a compaction and seek on those scanners after
> the compaction.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820805#comment-13820805 ] Manukranth Kolloju commented on HBASE-9949: --- [~yuzhih...@gmail.com] We use the other event InjectionEvents in testing parts of master etc. So, they might not apply to trunk. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb > > Attachments: 9949-trunk-v1.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820801#comment-13820801 ] Ted Yu commented on HBASE-9949: --- I put the patch on https://reviews.apache.org/r/15465/ The unused events would be dropped in next patch. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb > > Attachments: 9949-trunk-v1.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820792#comment-13820792 ] Sergey Shelukhin commented on HBASE-9949: - can you create an RB? Many on the injectionhandler events appear to be unused. Overall, I wonder if there could be better approach... I guess it's better than some things we have, like not completing compaction on config. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb > > Attachments: 9949-trunk-v1.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9949) Fix the race condition between Compaction and StoreScanner.init
[ https://issues.apache.org/jira/browse/HBASE-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820759#comment-13820759 ] Ted Yu commented on HBASE-9949: --- TestStoreScanner#testCompactionRaceCondition passes locally. > Fix the race condition between Compaction and StoreScanner.init > --- > > Key: HBASE-9949 > URL: https://issues.apache.org/jira/browse/HBASE-9949 > Project: HBase > Issue Type: Bug > Components: Scanners >Affects Versions: 0.89-fb >Reporter: Manukranth Kolloju >Assignee: Manukranth Kolloju >Priority: Minor > Fix For: 0.89-fb > > Attachments: 9949-trunk-v1.txt > > Original Estimate: 48h > Remaining Estimate: 48h > > The StoreScanner constructor has multiple stages and there can be a race > betwwen an ongoing compaction and the StoreScanner constructor where we might > get the list of scanners before a compaction and seek on those scanners after > the compaction. -- This message was sent by Atlassian JIRA (v6.1#6144)
