[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16456: --- Attachment: 16456-v3.patch boolean isInit() method should be package private. This is the version I committed. > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Ted Yu >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0 > > Attachments: 16456-v3.patch, HBASE-16456-v1.patch, > HBASE-16456-v2.patch, findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16456: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch, Guangxu. > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Ted Yu >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16456-v1.patch, HBASE-16456-v2.patch, > findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16456: --- Hadoop Flags: Reviewed Fix Version/s: 2.0.0 > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Ted Yu >Assignee: Guangxu Cheng >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-16456-v1.patch, HBASE-16456-v2.patch, > findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-16456: -- Attachment: HBASE-16456-v2.patch patch for v2 > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Ted Yu >Priority: Minor > Attachments: HBASE-16456-v1.patch, HBASE-16456-v2.patch, > findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-16456: -- Affects Version/s: 2.0.0 Status: Patch Available (was: Open) patch for v2 > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Ted Yu >Priority: Minor > Attachments: HBASE-16456-v1.patch, findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-16456: -- Status: Open (was: Patch Available) > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Attachments: HBASE-16456-v1.patch, findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-16456: -- Status: Patch Available (was: Open) > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Attachments: HBASE-16456-v1.patch, findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guangxu Cheng updated HBASE-16456: -- Attachment: HBASE-16456-v1.patch > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Attachments: HBASE-16456-v1.patch, findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16456) Fix findbugs warnings in hbase-rsgroup module
[ https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16456: --- Attachment: findbugs-rsgroup.html > Fix findbugs warnings in hbase-rsgroup module > - > > Key: HBASE-16456 > URL: https://issues.apache.org/jira/browse/HBASE-16456 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Attachments: findbugs-rsgroup.html > > > https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html > : > Multithreaded correctness Warnings > Code Warning > SCnew > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices) > invokes > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start() > SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set, > String) calls Thread.sleep() with a lock held > Performance Warnings > Code Warning > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > WMI > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > Dodgy code Warnings > Code Warning > REC Exception is caught when Exception is not thrown in > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline() > STWrite to static field > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from > instance method > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
