[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread chunhui shen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545706#comment-13545706
 ] 

chunhui shen commented on HBASE-7403:
-

bq.When can we get this below situation?
{code}
if ((regionInfoA == null || regionInfoB == null)) {
{code}
After deleting the table or redo merging from the state COMPLETE_MERGING, this 
situation is OK.

bq.Should we not check this even before the merge has started
We receive the merge request in a zookeeper event handler, and I don't want to 
check the above situation in that handler because that handler is synchronized

bq.Y should not we resubmit here?
It is a new merge request, but we can't get the regioninfo of merging regions, 
it seems user send a wrong request.

bq.Do we need to wait for the main region to be assigned
It's no necessary

bq.In EXECUTE_MERGING do we need to handle any failure saying it must move to 
CANCEL_MERGING.
Once we entered the state EXECUTE_MERGING, we couldn't CANCEL_MERGING, we only 
ensure that we could redo it until successful after abort or failture

bq.will it be reassigned by SSH?
It won't happen, the merging regions won't be assigned to anywhere, see 
SSH#processDeadRegion and RegionMergeManager#mergingRegions

bq.I think the Merger thread should read the znode and try to restart the merge 
right?
Yes, bingo! We record the merge state on ZK, so we can be easy to redo it



 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive merge request
 Merge transaction is executed on the master
 Support calling merge request through API or shell tool
 About the merge process, please see the attachment and patch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7403) Online Merge

2013-01-07 Thread chunhui shen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chunhui shen updated HBASE-7403:


Attachment: hbase-7403-trunkv7.patch

Uploading patchv7
Also in review board:
https://reviews.apache.org/r/8716/

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive merge request
 Merge transaction is executed on the master
 Support calling merge request through API or shell tool
 About the merge process, please see the attachment and patch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7495) parallel scanner seek in StoreScanner's constructor

2013-01-07 Thread chunhui shen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545713#comment-13545713
 ] 

chunhui shen commented on HBASE-7495:
-

[~xieliang007]
We have do the parallel scanner seek testing long ago, but seems no improvement.

Waiting for your new result.

 parallel scanner seek in StoreScanner's constructor
 ---

 Key: HBASE-7495
 URL: https://issues.apache.org/jira/browse/HBASE-7495
 Project: HBase
  Issue Type: Bug
  Components: Scanners
Affects Versions: 0.94.3, 0.96.0
Reporter: liang xie
Assignee: liang xie

 seems there's a potential improvable space before doing scanner.next:
 {code:title=StoreScanner.java|borderStyle=solid}
 if (explicitColumnQuery  lazySeekEnabledGlobally) {
   for (KeyValueScanner scanner : scanners) {
 scanner.requestSeek(matcher.getStartKey(), false, true);
   }
 } else {
   for (KeyValueScanner scanner : scanners) {
 scanner.seek(matcher.getStartKey());
   }
 }
 {code} 
 we can do scanner.requestSeek or scanner.seek in parallel, instead of current 
 serialization, to reduce latency for special case.
 Any ideas on it ?  I'll have a try if the comments/suggestions are positive:)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6031) RegionServer does not go down while aborting

2013-01-07 Thread liang xie (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545720#comment-13545720
 ] 

liang xie commented on HBASE-6031:
--

we hit this issue today as well:)

Attached rs_shutdown_hung20130107.jstack was a thread dump during hung ocurred

I've filed HADOOP-9181 to resolve it

 RegionServer does not go down while aborting
 

 Key: HBASE-6031
 URL: https://issues.apache.org/jira/browse/HBASE-6031
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: rs_shutdown_hung20130107.jstack, rsthread.txt


 Following is the thread dump.
 {code}
 1997531088@qtp-716941846-5 prio=10 tid=0x7f7c5820c800 nid=0xe1b in 
 Object.wait() [0x7f7c56ae8000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
   at java.lang.Object.wait(Native Method)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.blockWritable(SelectChannelEndPoint.java:279)
   - locked 0x7f7cfe0616d0 (a 
 org.mortbay.jetty.nio.SelectChannelConnector$ConnectorEndPoint)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.blockForOutput(AbstractGenerator.java:545)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.write(AbstractGenerator.java:639)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.write(AbstractGenerator.java:580)
   at java.io.ByteArrayOutputStream.writeTo(ByteArrayOutputStream.java:109)
   - locked 0x7f7cfe74d758 (a 
 org.mortbay.util.ByteArrayOutputStream2)
   at 
 org.mortbay.jetty.AbstractGenerator$OutputWriter.write(AbstractGenerator.java:904)
   at java.io.Writer.write(Writer.java:96)
   - locked 0x7f7cfca02fc0 (a 
 org.mortbay.jetty.HttpConnection$OutputWriter)
   at java.io.PrintWriter.write(PrintWriter.java:361)
   - locked 0x7f7cfca02fc0 (a 
 org.mortbay.jetty.HttpConnection$OutputWriter)
   at org.jamon.escaping.HtmlEscaping.write(HtmlEscaping.java:43)
   at 
 org.jamon.escaping.AbstractCharacterEscaping.write(AbstractCharacterEscaping.java:35)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(RSStatusTmplImpl.java:222)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.renderNoFlush(RSStatusTmpl.java:180)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.render(RSStatusTmpl.java:171)
   at 
 org.apache.hadoop.hbase.regionserver.RSStatusServlet.doGet(RSStatusServlet.java:48)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
   at 
 org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221)
   at 
 org.apache.hadoop.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:109)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
   at 
 org.apache.hadoop.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:932)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
   at 
 org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
   at 
 org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
   at 
 org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
   at 
 org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
   at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
   at 
 org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
   at 
 org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
   at org.mortbay.jetty.Server.handle(Server.java:326)
   at 
 org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
   at 
 org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
   at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
   at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
   at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
   at 
 org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
 1374615312@qtp-716941846-3 prio=10 tid=0x7f7c58214800 nid=0xc42 in 
 Object.wait() [0x7f7c55bd9000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
   at java.lang.Object.wait(Native Method)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.blockWritable(SelectChannelEndPoint.java:279)
 

[jira] [Updated] (HBASE-6031) RegionServer does not go down while aborting

2013-01-07 Thread liang xie (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang xie updated HBASE-6031:
-

Attachment: rs_shutdown_hung20130107.jstack

 RegionServer does not go down while aborting
 

 Key: HBASE-6031
 URL: https://issues.apache.org/jira/browse/HBASE-6031
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: rs_shutdown_hung20130107.jstack, rsthread.txt


 Following is the thread dump.
 {code}
 1997531088@qtp-716941846-5 prio=10 tid=0x7f7c5820c800 nid=0xe1b in 
 Object.wait() [0x7f7c56ae8000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
   at java.lang.Object.wait(Native Method)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.blockWritable(SelectChannelEndPoint.java:279)
   - locked 0x7f7cfe0616d0 (a 
 org.mortbay.jetty.nio.SelectChannelConnector$ConnectorEndPoint)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.blockForOutput(AbstractGenerator.java:545)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.write(AbstractGenerator.java:639)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.write(AbstractGenerator.java:580)
   at java.io.ByteArrayOutputStream.writeTo(ByteArrayOutputStream.java:109)
   - locked 0x7f7cfe74d758 (a 
 org.mortbay.util.ByteArrayOutputStream2)
   at 
 org.mortbay.jetty.AbstractGenerator$OutputWriter.write(AbstractGenerator.java:904)
   at java.io.Writer.write(Writer.java:96)
   - locked 0x7f7cfca02fc0 (a 
 org.mortbay.jetty.HttpConnection$OutputWriter)
   at java.io.PrintWriter.write(PrintWriter.java:361)
   - locked 0x7f7cfca02fc0 (a 
 org.mortbay.jetty.HttpConnection$OutputWriter)
   at org.jamon.escaping.HtmlEscaping.write(HtmlEscaping.java:43)
   at 
 org.jamon.escaping.AbstractCharacterEscaping.write(AbstractCharacterEscaping.java:35)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(RSStatusTmplImpl.java:222)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.renderNoFlush(RSStatusTmpl.java:180)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.render(RSStatusTmpl.java:171)
   at 
 org.apache.hadoop.hbase.regionserver.RSStatusServlet.doGet(RSStatusServlet.java:48)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
   at 
 org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221)
   at 
 org.apache.hadoop.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:109)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
   at 
 org.apache.hadoop.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:932)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
   at 
 org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
   at 
 org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
   at 
 org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
   at 
 org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
   at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
   at 
 org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
   at 
 org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
   at org.mortbay.jetty.Server.handle(Server.java:326)
   at 
 org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
   at 
 org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
   at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
   at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
   at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
   at 
 org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
 1374615312@qtp-716941846-3 prio=10 tid=0x7f7c58214800 nid=0xc42 in 
 Object.wait() [0x7f7c55bd9000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
   at java.lang.Object.wait(Native Method)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.blockWritable(SelectChannelEndPoint.java:279)
   - locked 0x7f7cfdbb6cc8 (a 
 org.mortbay.jetty.nio.SelectChannelConnector$ConnectorEndPoint)
   at 
 

[jira] [Commented] (HBASE-6031) RegionServer does not go down while aborting

2013-01-07 Thread liang xie (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545724#comment-13545724
 ] 

liang xie commented on HBASE-6031:
--

Due to qtp-* was not a daemon thread, our hbase shutdownhook was not be 
triggered

 RegionServer does not go down while aborting
 

 Key: HBASE-6031
 URL: https://issues.apache.org/jira/browse/HBASE-6031
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: rs_shutdown_hung20130107.jstack, rsthread.txt


 Following is the thread dump.
 {code}
 1997531088@qtp-716941846-5 prio=10 tid=0x7f7c5820c800 nid=0xe1b in 
 Object.wait() [0x7f7c56ae8000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
   at java.lang.Object.wait(Native Method)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.blockWritable(SelectChannelEndPoint.java:279)
   - locked 0x7f7cfe0616d0 (a 
 org.mortbay.jetty.nio.SelectChannelConnector$ConnectorEndPoint)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.blockForOutput(AbstractGenerator.java:545)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.write(AbstractGenerator.java:639)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.write(AbstractGenerator.java:580)
   at java.io.ByteArrayOutputStream.writeTo(ByteArrayOutputStream.java:109)
   - locked 0x7f7cfe74d758 (a 
 org.mortbay.util.ByteArrayOutputStream2)
   at 
 org.mortbay.jetty.AbstractGenerator$OutputWriter.write(AbstractGenerator.java:904)
   at java.io.Writer.write(Writer.java:96)
   - locked 0x7f7cfca02fc0 (a 
 org.mortbay.jetty.HttpConnection$OutputWriter)
   at java.io.PrintWriter.write(PrintWriter.java:361)
   - locked 0x7f7cfca02fc0 (a 
 org.mortbay.jetty.HttpConnection$OutputWriter)
   at org.jamon.escaping.HtmlEscaping.write(HtmlEscaping.java:43)
   at 
 org.jamon.escaping.AbstractCharacterEscaping.write(AbstractCharacterEscaping.java:35)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(RSStatusTmplImpl.java:222)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.renderNoFlush(RSStatusTmpl.java:180)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.render(RSStatusTmpl.java:171)
   at 
 org.apache.hadoop.hbase.regionserver.RSStatusServlet.doGet(RSStatusServlet.java:48)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
   at 
 org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221)
   at 
 org.apache.hadoop.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:109)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
   at 
 org.apache.hadoop.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:932)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
   at 
 org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
   at 
 org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
   at 
 org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
   at 
 org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
   at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
   at 
 org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
   at 
 org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
   at org.mortbay.jetty.Server.handle(Server.java:326)
   at 
 org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
   at 
 org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
   at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
   at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
   at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
   at 
 org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
 1374615312@qtp-716941846-3 prio=10 tid=0x7f7c58214800 nid=0xc42 in 
 Object.wait() [0x7f7c55bd9000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
   at java.lang.Object.wait(Native Method)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.blockWritable(SelectChannelEndPoint.java:279)
   - locked 0x7f7cfdbb6cc8 (a 
 

[jira] [Created] (HBASE-7504) -ROOT- may be offline forever after FullGC of RS

2013-01-07 Thread chunhui shen (JIRA)
chunhui shen created HBASE-7504:
---

 Summary: -ROOT- may be offline forever after FullGC of  RS
 Key: HBASE-7504
 URL: https://issues.apache.org/jira/browse/HBASE-7504
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen


1.FullGC happen on ROOT regionserver.
2.ZK session timeout, master expire the regionserver and submit to 
ServerShutdownHandler
3.Regionserver complete the FullGC
4.In the process of ServerShutdownHandler, verifyRootRegionLocation returns true
5.ServerShutdownHandler skip assigning -ROOT- region
6.Regionserver abort itself because it reveive YouAreDeadException after a 
regionserver report
7.-ROO- is offline now, and won't be assigned any more unless we restart master



Master Log:
{code}
2012-10-31 19:51:39,043 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
Added=dw88.kgb.sqa.cm4,60020,1351671478752 to dead servers, submitted shutdown 
handler to be executed, root=true, meta=false
2012-10-31 19:51:39,045 INFO 
org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Splitting logs 
for dw88.kgb.sqa.cm4,60020,1351671478752
2012-10-31 19:51:50,113 INFO 
org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Server 
dw88.kgb.sqa.cm4,60020,1351671478752 was carrying ROOT. Trying to assign.
2012-10-31 19:52:15,939 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
Server REPORT rejected; currently processing 
dw88.kgb.sqa.cm4,60020,1351671478752 as dead server
2012-10-31 19:52:15,945 INFO 
org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Skipping log 
splitting for dw88.kgb.sqa.cm4,60020,1351671478752
{code}

No log of assigning -ROOT-

Regionserver log:
{code}
2012-10-31 19:52:15,923 WARN org.apache.hadoop.hbase.util.Sleeper: We slept 
229128ms instead of 10ms, this is likely due to a long garbage collecting 
pause and it's usually bad, see 
http://hbase.apache.org/book.html#trouble.rs.runtime.zkexpired
{code}




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7504) -ROOT- may be offline forever after FullGC of RS

2013-01-07 Thread chunhui shen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chunhui shen updated HBASE-7504:


Attachment: 7504-trunk v1.patch

 -ROOT- may be offline forever after FullGC of  RS
 -

 Key: HBASE-7504
 URL: https://issues.apache.org/jira/browse/HBASE-7504
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Attachments: 7504-trunk v1.patch


 1.FullGC happen on ROOT regionserver.
 2.ZK session timeout, master expire the regionserver and submit to 
 ServerShutdownHandler
 3.Regionserver complete the FullGC
 4.In the process of ServerShutdownHandler, verifyRootRegionLocation returns 
 true
 5.ServerShutdownHandler skip assigning -ROOT- region
 6.Regionserver abort itself because it reveive YouAreDeadException after a 
 regionserver report
 7.-ROO- is offline now, and won't be assigned any more unless we restart 
 master
 Master Log:
 {code}
 2012-10-31 19:51:39,043 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Added=dw88.kgb.sqa.cm4,60020,1351671478752 to dead servers, submitted 
 shutdown handler to be executed, root=true, meta=false
 2012-10-31 19:51:39,045 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Splitting logs 
 for dw88.kgb.sqa.cm4,60020,1351671478752
 2012-10-31 19:51:50,113 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Server 
 dw88.kgb.sqa.cm4,60020,1351671478752 was carrying ROOT. Trying to assign.
 2012-10-31 19:52:15,939 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Server REPORT rejected; currently processing 
 dw88.kgb.sqa.cm4,60020,1351671478752 as dead server
 2012-10-31 19:52:15,945 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Skipping log 
 splitting for dw88.kgb.sqa.cm4,60020,1351671478752
 {code}
 No log of assigning -ROOT-
 Regionserver log:
 {code}
 2012-10-31 19:52:15,923 WARN org.apache.hadoop.hbase.util.Sleeper: We slept 
 229128ms instead of 10ms, this is likely due to a long garbage collecting 
 pause and it's usually bad, see 
 http://hbase.apache.org/book.html#trouble.rs.runtime.zkexpired
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7504) -ROOT- may be offline forever after FullGC of RS

2013-01-07 Thread chunhui shen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chunhui shen updated HBASE-7504:


Attachment: 7504-trunk v1.patch

 -ROOT- may be offline forever after FullGC of  RS
 -

 Key: HBASE-7504
 URL: https://issues.apache.org/jira/browse/HBASE-7504
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Attachments: 7504-trunk v1.patch


 1.FullGC happen on ROOT regionserver.
 2.ZK session timeout, master expire the regionserver and submit to 
 ServerShutdownHandler
 3.Regionserver complete the FullGC
 4.In the process of ServerShutdownHandler, verifyRootRegionLocation returns 
 true
 5.ServerShutdownHandler skip assigning -ROOT- region
 6.Regionserver abort itself because it reveive YouAreDeadException after a 
 regionserver report
 7.-ROO- is offline now, and won't be assigned any more unless we restart 
 master
 Master Log:
 {code}
 2012-10-31 19:51:39,043 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Added=dw88.kgb.sqa.cm4,60020,1351671478752 to dead servers, submitted 
 shutdown handler to be executed, root=true, meta=false
 2012-10-31 19:51:39,045 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Splitting logs 
 for dw88.kgb.sqa.cm4,60020,1351671478752
 2012-10-31 19:51:50,113 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Server 
 dw88.kgb.sqa.cm4,60020,1351671478752 was carrying ROOT. Trying to assign.
 2012-10-31 19:52:15,939 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Server REPORT rejected; currently processing 
 dw88.kgb.sqa.cm4,60020,1351671478752 as dead server
 2012-10-31 19:52:15,945 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Skipping log 
 splitting for dw88.kgb.sqa.cm4,60020,1351671478752
 {code}
 No log of assigning -ROOT-
 Regionserver log:
 {code}
 2012-10-31 19:52:15,923 WARN org.apache.hadoop.hbase.util.Sleeper: We slept 
 229128ms instead of 10ms, this is likely due to a long garbage collecting 
 pause and it's usually bad, see 
 http://hbase.apache.org/book.html#trouble.rs.runtime.zkexpired
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7504) -ROOT- may be offline forever after FullGC of RS

2013-01-07 Thread chunhui shen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chunhui shen updated HBASE-7504:


Attachment: (was: 7504-trunk v1.patch)

 -ROOT- may be offline forever after FullGC of  RS
 -

 Key: HBASE-7504
 URL: https://issues.apache.org/jira/browse/HBASE-7504
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Attachments: 7504-trunk v1.patch


 1.FullGC happen on ROOT regionserver.
 2.ZK session timeout, master expire the regionserver and submit to 
 ServerShutdownHandler
 3.Regionserver complete the FullGC
 4.In the process of ServerShutdownHandler, verifyRootRegionLocation returns 
 true
 5.ServerShutdownHandler skip assigning -ROOT- region
 6.Regionserver abort itself because it reveive YouAreDeadException after a 
 regionserver report
 7.-ROO- is offline now, and won't be assigned any more unless we restart 
 master
 Master Log:
 {code}
 2012-10-31 19:51:39,043 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Added=dw88.kgb.sqa.cm4,60020,1351671478752 to dead servers, submitted 
 shutdown handler to be executed, root=true, meta=false
 2012-10-31 19:51:39,045 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Splitting logs 
 for dw88.kgb.sqa.cm4,60020,1351671478752
 2012-10-31 19:51:50,113 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Server 
 dw88.kgb.sqa.cm4,60020,1351671478752 was carrying ROOT. Trying to assign.
 2012-10-31 19:52:15,939 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Server REPORT rejected; currently processing 
 dw88.kgb.sqa.cm4,60020,1351671478752 as dead server
 2012-10-31 19:52:15,945 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Skipping log 
 splitting for dw88.kgb.sqa.cm4,60020,1351671478752
 {code}
 No log of assigning -ROOT-
 Regionserver log:
 {code}
 2012-10-31 19:52:15,923 WARN org.apache.hadoop.hbase.util.Sleeper: We slept 
 229128ms instead of 10ms, this is likely due to a long garbage collecting 
 pause and it's usually bad, see 
 http://hbase.apache.org/book.html#trouble.rs.runtime.zkexpired
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545731#comment-13545731
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.regionserver.TestSplitTransaction

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3889//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to 

[jira] [Created] (HBASE-7505) Server will hang when stopping cluster, caused by waiting for split threads

2013-01-07 Thread chunhui shen (JIRA)
chunhui shen created HBASE-7505:
---

 Summary: Server will hang when stopping cluster, caused by waiting 
for split threads
 Key: HBASE-7505
 URL: https://issues.apache.org/jira/browse/HBASE-7505
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0


We will retry 100 times (about 3200 minitues) for 
HRegionServer#postOpenDeployTasks now, see 
HConnectionManager#setServerSideHConnectionRetries.

However, 
when we stopping the cluster, we will wait for split threads in  
HRegionServer#join,
if META/ROOT server has already been stopped, the split thread won't exit 
because it is in the retrying for HRegionServer#postOpenDeployTasks


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7505) Server will hang when stopping cluster, caused by waiting for split threads

2013-01-07 Thread chunhui shen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chunhui shen updated HBASE-7505:


Attachment: 7505-trunk v1.patch

 Server will hang when stopping cluster, caused by waiting for split threads
 ---

 Key: HBASE-7505
 URL: https://issues.apache.org/jira/browse/HBASE-7505
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7505-trunk v1.patch


 We will retry 100 times (about 3200 minitues) for 
 HRegionServer#postOpenDeployTasks now, see 
 HConnectionManager#setServerSideHConnectionRetries.
 However, 
 when we stopping the cluster, we will wait for split threads in  
 HRegionServer#join,
 if META/ROOT server has already been stopped, the split thread won't exit 
 because it is in the retrying for HRegionServer#postOpenDeployTasks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-7506) Judgement of carrtying ROOT/META will become wrong when expiring server

2013-01-07 Thread chunhui shen (JIRA)
chunhui shen created HBASE-7506:
---

 Summary: Judgement of carrtying ROOT/META will become wrong when 
expiring server
 Key: HBASE-7506
 URL: https://issues.apache.org/jira/browse/HBASE-7506
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0


We will check whether server carrying ROOT/META when expiring the server.
See ServerManager#expireServer.

If the dead server carrying META, we assign meta directly in the process of 
ServerShutdownHandler.
If the dead server carrying ROOT, we will offline ROOT and then 
verifyAndAssignRootWithRetries()

How judgement of carrtying ROOT/META become wrong?
If region is in RIT, and isCarryingRegion() return true after addressing from 
zk.
However, once RIT time out(could be caused by this.allRegionServersOffline  
!noRSAvailable, see AssignmentManager#TimeoutMonitor)   and we assign it to 
otherwhere, this judgement become wrong.
See AssignmentManager#isCarryingRegion for details

With the wrong judgement of carrtying ROOT/META, we would assign ROOT/META 
twice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545749#comment-13545749
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3888//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive merge request
 Merge transaction is executed on the master
 Support 

[jira] [Updated] (HBASE-7506) Judgement of carrtying ROOT/META will become wrong when expiring server

2013-01-07 Thread chunhui shen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chunhui shen updated HBASE-7506:


Attachment: 7506-trunk v1.patch

 Judgement of carrtying ROOT/META will become wrong when expiring server
 ---

 Key: HBASE-7506
 URL: https://issues.apache.org/jira/browse/HBASE-7506
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7506-trunk v1.patch


 We will check whether server carrying ROOT/META when expiring the server.
 See ServerManager#expireServer.
 If the dead server carrying META, we assign meta directly in the process of 
 ServerShutdownHandler.
 If the dead server carrying ROOT, we will offline ROOT and then 
 verifyAndAssignRootWithRetries()
 How judgement of carrtying ROOT/META become wrong?
 If region is in RIT, and isCarryingRegion() return true after addressing from 
 zk.
 However, once RIT time out(could be caused by this.allRegionServersOffline  
 !noRSAvailable, see AssignmentManager#TimeoutMonitor)   and we assign it to 
 otherwhere, this judgement become wrong.
 See AssignmentManager#isCarryingRegion for details
 With the wrong judgement of carrtying ROOT/META, we would assign ROOT/META 
 twice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-7507) Make memstore flush be able to retry after exception

2013-01-07 Thread chunhui shen (JIRA)
chunhui shen created HBASE-7507:
---

 Summary: Make memstore flush be able to retry after exception
 Key: HBASE-7507
 URL: https://issues.apache.org/jira/browse/HBASE-7507
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0


We will abort regionserver if memstore flush throws exception.

I thinks we could do retry to make regionserver more stable because file system 
may be not ok in a transient time. e.g. Switching namenode in the NamenodeHA 
environment

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7507) Make memstore flush be able to retry after exception

2013-01-07 Thread chunhui shen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chunhui shen updated HBASE-7507:


Description: 
We will abort regionserver if memstore flush throws exception.

I thinks we could do retry to make regionserver more stable because file system 
may be not ok in a transient time. e.g. Switching namenode in the NamenodeHA 
environment



{code}
HRegion#internalFlushcache(){

...
try {
...
}catch(Throwable t){
DroppedSnapshotException dse = new DroppedSnapshotException(region:  +
  Bytes.toStringBinary(getRegionName()));
dse.initCause(t);
throw dse;
}
...

}

MemStoreFlusher#flushRegion(){
...
region.flushcache();
...
 try {
}catch(DroppedSnapshotException ex){
server.abort(Replay of HLog required. Forcing server shutdown, ex);
}

...
}
{code}

  was:
We will abort regionserver if memstore flush throws exception.

I thinks we could do retry to make regionserver more stable because file system 
may be not ok in a transient time. e.g. Switching namenode in the NamenodeHA 
environment


 Make memstore flush be able to retry after exception
 

 Key: HBASE-7507
 URL: https://issues.apache.org/jira/browse/HBASE-7507
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0


 We will abort regionserver if memstore flush throws exception.
 I thinks we could do retry to make regionserver more stable because file 
 system may be not ok in a transient time. e.g. Switching namenode in the 
 NamenodeHA environment
 {code}
 HRegion#internalFlushcache(){
 ...
 try {
 ...
 }catch(Throwable t){
 DroppedSnapshotException dse = new DroppedSnapshotException(region:  +
   Bytes.toStringBinary(getRegionName()));
 dse.initCause(t);
 throw dse;
 }
 ...
 }
 MemStoreFlusher#flushRegion(){
 ...
 region.flushcache();
 ...
  try {
 }catch(DroppedSnapshotException ex){
 server.abort(Replay of HLog required. Forcing server shutdown, ex);
 }
 ...
 }
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7507) Make memstore flush be able to retry after exception

2013-01-07 Thread chunhui shen (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chunhui shen updated HBASE-7507:


Attachment: 7507-trunk v1.patch

 Make memstore flush be able to retry after exception
 

 Key: HBASE-7507
 URL: https://issues.apache.org/jira/browse/HBASE-7507
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7507-trunk v1.patch


 We will abort regionserver if memstore flush throws exception.
 I thinks we could do retry to make regionserver more stable because file 
 system may be not ok in a transient time. e.g. Switching namenode in the 
 NamenodeHA environment
 {code}
 HRegion#internalFlushcache(){
 ...
 try {
 ...
 }catch(Throwable t){
 DroppedSnapshotException dse = new DroppedSnapshotException(region:  +
   Bytes.toStringBinary(getRegionName()));
 dse.initCause(t);
 throw dse;
 }
 ...
 }
 MemStoreFlusher#flushRegion(){
 ...
 region.flushcache();
 ...
  try {
 }catch(DroppedSnapshotException ex){
 server.abort(Replay of HLog required. Forcing server shutdown, ex);
 }
 ...
 }
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545784#comment-13545784
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor

 {color:red}-1 core zombie tests{color}.  There are 6 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3890//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use 

[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545786#comment-13545786
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3891//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to 

[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545794#comment-13545794
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestFromClientSide

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3892//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive 

[jira] [Commented] (HBASE-6031) RegionServer does not go down while aborting

2013-01-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545821#comment-13545821
 ] 

ramkrishna.s.vasudevan commented on HBASE-6031:
---

Thanks Liang.

 RegionServer does not go down while aborting
 

 Key: HBASE-6031
 URL: https://issues.apache.org/jira/browse/HBASE-6031
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.0
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: rs_shutdown_hung20130107.jstack, rsthread.txt


 Following is the thread dump.
 {code}
 1997531088@qtp-716941846-5 prio=10 tid=0x7f7c5820c800 nid=0xe1b in 
 Object.wait() [0x7f7c56ae8000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
   at java.lang.Object.wait(Native Method)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.blockWritable(SelectChannelEndPoint.java:279)
   - locked 0x7f7cfe0616d0 (a 
 org.mortbay.jetty.nio.SelectChannelConnector$ConnectorEndPoint)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.blockForOutput(AbstractGenerator.java:545)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.write(AbstractGenerator.java:639)
   at 
 org.mortbay.jetty.AbstractGenerator$Output.write(AbstractGenerator.java:580)
   at java.io.ByteArrayOutputStream.writeTo(ByteArrayOutputStream.java:109)
   - locked 0x7f7cfe74d758 (a 
 org.mortbay.util.ByteArrayOutputStream2)
   at 
 org.mortbay.jetty.AbstractGenerator$OutputWriter.write(AbstractGenerator.java:904)
   at java.io.Writer.write(Writer.java:96)
   - locked 0x7f7cfca02fc0 (a 
 org.mortbay.jetty.HttpConnection$OutputWriter)
   at java.io.PrintWriter.write(PrintWriter.java:361)
   - locked 0x7f7cfca02fc0 (a 
 org.mortbay.jetty.HttpConnection$OutputWriter)
   at org.jamon.escaping.HtmlEscaping.write(HtmlEscaping.java:43)
   at 
 org.jamon.escaping.AbstractCharacterEscaping.write(AbstractCharacterEscaping.java:35)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(RSStatusTmplImpl.java:222)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.renderNoFlush(RSStatusTmpl.java:180)
   at 
 org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.render(RSStatusTmpl.java:171)
   at 
 org.apache.hadoop.hbase.regionserver.RSStatusServlet.doGet(RSStatusServlet.java:48)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
   at 
 org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221)
   at 
 org.apache.hadoop.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:109)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
   at 
 org.apache.hadoop.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:932)
   at 
 org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
   at 
 org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
   at 
 org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
   at 
 org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
   at 
 org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
   at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
   at 
 org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
   at 
 org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
   at org.mortbay.jetty.Server.handle(Server.java:326)
   at 
 org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
   at 
 org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
   at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
   at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
   at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
   at 
 org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
 1374615312@qtp-716941846-3 prio=10 tid=0x7f7c58214800 nid=0xc42 in 
 Object.wait() [0x7f7c55bd9000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
   at java.lang.Object.wait(Native Method)
   at 
 org.mortbay.io.nio.SelectChannelEndPoint.blockWritable(SelectChannelEndPoint.java:279)
   - locked 0x7f7cfdbb6cc8 (a 
 org.mortbay.jetty.nio.SelectChannelConnector$ConnectorEndPoint)
   at 
 

[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545833#comment-13545833
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor

 {color:red}-1 core zombie tests{color}.  There are 6 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3893//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use 

[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545835#comment-13545835
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestFromClientSide
  org.apache.hadoop.hbase.replication.TestReplication

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3894//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 

[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545838#comment-13545838
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3895//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive merge request
 Merge transaction is executed on the master
 Support 

[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545854#comment-13545854
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3896//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive merge request
 Merge transaction is executed on the master
 Support 

[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time

2013-01-07 Thread Jean-Marc Spaggiari (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545870#comment-13545870
 ] 

Jean-Marc Spaggiari commented on HBASE-7503:


Hi Ted,

Thanks for your comments.

2 questions.
1) What do you mean by Restore interrupt status? Should I throw it back? (and 
then add throws InterruptedException on the methode signature)
2) Regarding MultiGetRequest, just to make sure, that will also mean to add a 
ServerCallable constructor which can take a list of get? Then we need to give 
it only gets who are relying on the same region? But what if in the meantime 
the region split and the gets are no more all on the same region? Should we 
manage retries there too? 

This last point is making the modification way bigger and there will be a need 
of some design thinking.

 Add exists(List) in HTableInterface to allow multiple parallel exists at one 
 time
 -

 Key: HBASE-7503
 URL: https://issues.apache.org/jira/browse/HBASE-7503
 Project: HBase
  Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
 Fix For: 0.96.0

 Attachments: HBASE-7503-v0-trunk.patch

   Original Estimate: 5m
  Remaining Estimate: 5m

 We need to have a Boolean[] exists(ListGet gets) throws IOException method 
 implemented in HTableInterface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545895#comment-13545895
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.replication.TestReplication

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3897//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to 

[jira] [Updated] (HBASE-7403) Online Merge

2013-01-07 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-7403:
--

Status: Open  (was: Patch Available)

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive merge request
 Merge transaction is executed on the master
 Support calling merge request through API or shell tool
 About the merge process, please see the attachment and patch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545929#comment-13545929
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestFromClientSide

 {color:red}-1 core zombie tests{color}.  There are 7 zombie test(s):   
at 
org.apache.hadoop.hbase.catalog.TestCatalogTracker.testServerNotRunningIOException(TestCatalogTracker.java:250)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3898//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if 

[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545933#comment-13545933
 ] 

Hadoop QA commented on HBASE-7403:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12563531/hbase-7403-trunkv7.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3899//console

This message is automatically generated.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive merge request
 Merge transaction is executed on the master
 Support 

[jira] [Updated] (HBASE-7506) Judgment of carrying ROOT/META will become wrong when expiring server

2013-01-07 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-7506:
--

Summary: Judgment of carrying ROOT/META will become wrong when expiring 
server  (was: Judgement of carrtying ROOT/META will become wrong when expiring 
server)

 Judgment of carrying ROOT/META will become wrong when expiring server
 -

 Key: HBASE-7506
 URL: https://issues.apache.org/jira/browse/HBASE-7506
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7506-trunk v1.patch


 We will check whether server carrying ROOT/META when expiring the server.
 See ServerManager#expireServer.
 If the dead server carrying META, we assign meta directly in the process of 
 ServerShutdownHandler.
 If the dead server carrying ROOT, we will offline ROOT and then 
 verifyAndAssignRootWithRetries()
 How judgement of carrtying ROOT/META become wrong?
 If region is in RIT, and isCarryingRegion() return true after addressing from 
 zk.
 However, once RIT time out(could be caused by this.allRegionServersOffline  
 !noRSAvailable, see AssignmentManager#TimeoutMonitor)   and we assign it to 
 otherwhere, this judgement become wrong.
 See AssignmentManager#isCarryingRegion for details
 With the wrong judgement of carrtying ROOT/META, we would assign ROOT/META 
 twice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-3996) Support multiple tables and scanners as input to the mapper in map/reduce jobs

2013-01-07 Thread Bryan Baugher (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Baugher updated HBASE-3996:
-

Attachment: 3996-v11.txt

Fixed test error, line length and added stability annotation.

I was finally able to get the test to run so I may try to clean up / add more 
tests in the meantime.

 Support multiple tables and scanners as input to the mapper in map/reduce jobs
 --

 Key: HBASE-3996
 URL: https://issues.apache.org/jira/browse/HBASE-3996
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce
Reporter: Eran Kutner
Assignee: Lars Hofhansl
 Fix For: 0.96.0, 0.94.5

 Attachments: 3996-v10.txt, 3996-v11.txt, 3996-v2.txt, 3996-v3.txt, 
 3996-v4.txt, 3996-v5.txt, 3996-v6.txt, 3996-v7.txt, 3996-v8.txt, 3996-v9.txt, 
 HBase-3996.patch


 It seems that in many cases feeding data from multiple tables or multiple 
 scanners on a single table can save a lot of time when running map/reduce 
 jobs.
 I propose a new MultiTableInputFormat class that would allow doing this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time

2013-01-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545962#comment-13545962
 ] 

Ted Yu commented on HBASE-7503:
---

For #1, I meant adding the following call:
{code}
Thread.currentThread().interrupt();
{code}
For #2, we do need to find a good design. ProtobufUtil.getRemoteException() can 
be used to examine the cause of failure so that we take proper action 
accordingly.

 Add exists(List) in HTableInterface to allow multiple parallel exists at one 
 time
 -

 Key: HBASE-7503
 URL: https://issues.apache.org/jira/browse/HBASE-7503
 Project: HBase
  Issue Type: Improvement
Reporter: Jean-Marc Spaggiari
Assignee: Jean-Marc Spaggiari
Priority: Minor
 Fix For: 0.96.0

 Attachments: HBASE-7503-v0-trunk.patch

   Original Estimate: 5m
  Remaining Estimate: 5m

 We need to have a Boolean[] exists(ListGet gets) throws IOException method 
 implemented in HTableInterface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7507) Make memstore flush be able to retry after exception

2013-01-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545990#comment-13545990
 ] 

Ted Yu commented on HBASE-7507:
---

{code}
+  lastException = new IOException(e);
{code}
If e is instanceof IOException, we don't need to wrap it, right ?
{code}
+  // Path name is null if there is no entries to flush
{code}
'no entries' - 'no entry'
{code}
+validateStoreFile(pathName);
{code}
Why moving the location of validateStoreFile() call ?

 Make memstore flush be able to retry after exception
 

 Key: HBASE-7507
 URL: https://issues.apache.org/jira/browse/HBASE-7507
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7507-trunk v1.patch


 We will abort regionserver if memstore flush throws exception.
 I thinks we could do retry to make regionserver more stable because file 
 system may be not ok in a transient time. e.g. Switching namenode in the 
 NamenodeHA environment
 {code}
 HRegion#internalFlushcache(){
 ...
 try {
 ...
 }catch(Throwable t){
 DroppedSnapshotException dse = new DroppedSnapshotException(region:  +
   Bytes.toStringBinary(getRegionName()));
 dse.initCause(t);
 throw dse;
 }
 ...
 }
 MemStoreFlusher#flushRegion(){
 ...
 region.flushcache();
 ...
  try {
 }catch(DroppedSnapshotException ex){
 server.abort(Replay of HLog required. Forcing server shutdown, ex);
 }
 ...
 }
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-7407:
---

Status: Open  (was: Patch Available)

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-7407:
---

Attachment: 7407.v3.patch

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546008#comment-13546008
 ] 

nkeywal commented on HBASE-7407:


bq. I was thinking should we call unassign/open instead which handles more 
error cases, such as ServerNotRunningYetException in case the regionserver is 
online but not ready for RPC?

I've refactored the code to share the open region call with the assign function.
I don't think we can do a full assign in this case: the opening may be in 
progress already. 
In this code, we still abort if we have an error. It can be changed.

bq. Another thing is that RegionStates@regionOnline should be used to online a 
region when we revert to original state if sendRegionClose returns false. 
#updateRegionState will keep the region in transition.
I've change it to a full assign, it seems correct as well, and then we should 
not have this issue. What do you think?

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Comment Edited] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546008#comment-13546008
 ] 

nkeywal edited comment on HBASE-7407 at 1/7/13 4:23 PM:


bq. I was thinking should we call unassign/open instead which handles more 
error cases, such as ServerNotRunningYetException in case the regionserver is 
online but not ready for RPC?

I've refactored the code to share the open region call with the assign function.
I don't think we can do a full assign in this case: the opening may be in 
progress already. 
In this code, we still abort if we have an error. It can be changed.

bq. Another thing is that RegionStates@regionOnline should be used to online a 
region when we revert to original state if sendRegionClose returns false. 
#updateRegionState will keep the region in transition.
I've change it to a full assign, it seems correct as well, and then we should 
not have this issue. What do you think?

Lastly, I've added a lock during the process failover, imho we can meet race 
conditions without this...

  was (Author: nkeywal):
bq. I was thinking should we call unassign/open instead which handles more 
error cases, such as ServerNotRunningYetException in case the regionserver is 
online but not ready for RPC?

I've refactored the code to share the open region call with the assign function.
I don't think we can do a full assign in this case: the opening may be in 
progress already. 
In this code, we still abort if we have an error. It can be changed.

bq. Another thing is that RegionStates@regionOnline should be used to online a 
region when we revert to original state if sendRegionClose returns false. 
#updateRegionState will keep the region in transition.
I've change it to a full assign, it seems correct as well, and then we should 
not have this issue. What do you think?
  
 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3996) Support multiple tables and scanners as input to the mapper in map/reduce jobs

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546013#comment-13546013
 ] 

Hadoop QA commented on HBASE-3996:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563581/3996-v11.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.replication.TestReplicationWithCompression
  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
  org.apache.hadoop.hbase.replication.TestReplication

 {color:red}-1 core zombie tests{color}.  There are 6 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3901//console

This message is automatically generated.

 Support multiple tables and scanners as input to the mapper in map/reduce jobs
 --

 Key: HBASE-3996
 URL: https://issues.apache.org/jira/browse/HBASE-3996
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce
Reporter: Eran Kutner
Assignee: Lars Hofhansl
 Fix For: 0.96.0, 0.94.5

 Attachments: 3996-v10.txt, 3996-v11.txt, 3996-v2.txt, 3996-v3.txt, 
 3996-v4.txt, 3996-v5.txt, 3996-v6.txt, 3996-v7.txt, 3996-v8.txt, 3996-v9.txt, 
 HBase-3996.patch


 It seems that in many cases feeding data from multiple tables or multiple 
 scanners on a single table can save a lot of time when running map/reduce 
 jobs.
 I propose a new MultiTableInputFormat class that would allow doing this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7504) -ROOT- may be offline forever after FullGC of RS

2013-01-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546023#comment-13546023
 ] 

ramkrishna.s.vasudevan commented on HBASE-7504:
---

{code}
}else{
{code}
A space is needed before and after else.
Also before throwing IOException we could LOG an error message i feel.
+1 on patch.

 -ROOT- may be offline forever after FullGC of  RS
 -

 Key: HBASE-7504
 URL: https://issues.apache.org/jira/browse/HBASE-7504
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Attachments: 7504-trunk v1.patch


 1.FullGC happen on ROOT regionserver.
 2.ZK session timeout, master expire the regionserver and submit to 
 ServerShutdownHandler
 3.Regionserver complete the FullGC
 4.In the process of ServerShutdownHandler, verifyRootRegionLocation returns 
 true
 5.ServerShutdownHandler skip assigning -ROOT- region
 6.Regionserver abort itself because it reveive YouAreDeadException after a 
 regionserver report
 7.-ROO- is offline now, and won't be assigned any more unless we restart 
 master
 Master Log:
 {code}
 2012-10-31 19:51:39,043 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Added=dw88.kgb.sqa.cm4,60020,1351671478752 to dead servers, submitted 
 shutdown handler to be executed, root=true, meta=false
 2012-10-31 19:51:39,045 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Splitting logs 
 for dw88.kgb.sqa.cm4,60020,1351671478752
 2012-10-31 19:51:50,113 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Server 
 dw88.kgb.sqa.cm4,60020,1351671478752 was carrying ROOT. Trying to assign.
 2012-10-31 19:52:15,939 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Server REPORT rejected; currently processing 
 dw88.kgb.sqa.cm4,60020,1351671478752 as dead server
 2012-10-31 19:52:15,945 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Skipping log 
 splitting for dw88.kgb.sqa.cm4,60020,1351671478752
 {code}
 No log of assigning -ROOT-
 Regionserver log:
 {code}
 2012-10-31 19:52:15,923 WARN org.apache.hadoop.hbase.util.Sleeper: We slept 
 229128ms instead of 10ms, this is likely due to a long garbage collecting 
 pause and it's usually bad, see 
 http://hbase.apache.org/book.html#trouble.rs.runtime.zkexpired
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3996) Support multiple tables and scanners as input to the mapper in map/reduce jobs

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546037#comment-13546037
 ] 

Hadoop QA commented on HBASE-3996:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563581/3996-v11.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3902//console

This message is automatically generated.

 Support multiple tables and scanners as input to the mapper in map/reduce jobs
 --

 Key: HBASE-3996
 URL: https://issues.apache.org/jira/browse/HBASE-3996
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce
Reporter: Eran Kutner
Assignee: Lars Hofhansl
 Fix For: 0.96.0, 0.94.5

 Attachments: 3996-v10.txt, 3996-v11.txt, 3996-v2.txt, 3996-v3.txt, 
 3996-v4.txt, 3996-v5.txt, 3996-v6.txt, 3996-v7.txt, 3996-v8.txt, 3996-v9.txt, 
 HBase-3996.patch


 It seems that in many cases feeding data from multiple tables or multiple 
 scanners on a single table can save a lot of time when running map/reduce 
 jobs.
 I propose a new MultiTableInputFormat class that would allow doing this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7507) Make memstore flush be able to retry after exception

2013-01-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546040#comment-13546040
 ] 

ramkrishna.s.vasudevan commented on HBASE-7507:
---

Seems good Chunhui.  Why don't we expose it as a configuration with default 1 
so that any one can change it if they have an env as stated by your usecase.


 Make memstore flush be able to retry after exception
 

 Key: HBASE-7507
 URL: https://issues.apache.org/jira/browse/HBASE-7507
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7507-trunk v1.patch


 We will abort regionserver if memstore flush throws exception.
 I thinks we could do retry to make regionserver more stable because file 
 system may be not ok in a transient time. e.g. Switching namenode in the 
 NamenodeHA environment
 {code}
 HRegion#internalFlushcache(){
 ...
 try {
 ...
 }catch(Throwable t){
 DroppedSnapshotException dse = new DroppedSnapshotException(region:  +
   Bytes.toStringBinary(getRegionName()));
 dse.initCause(t);
 throw dse;
 }
 ...
 }
 MemStoreFlusher#flushRegion(){
 ...
 region.flushcache();
 ...
  try {
 }catch(DroppedSnapshotException ex){
 server.abort(Replay of HLog required. Forcing server shutdown, ex);
 }
 ...
 }
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7505) Server will hang when stopping cluster, caused by waiting for split threads

2013-01-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546046#comment-13546046
 ] 

ramkrishna.s.vasudevan commented on HBASE-7505:
---

Makes sense.  +1.

 Server will hang when stopping cluster, caused by waiting for split threads
 ---

 Key: HBASE-7505
 URL: https://issues.apache.org/jira/browse/HBASE-7505
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7505-trunk v1.patch


 We will retry 100 times (about 3200 minitues) for 
 HRegionServer#postOpenDeployTasks now, see 
 HConnectionManager#setServerSideHConnectionRetries.
 However, 
 when we stopping the cluster, we will wait for split threads in  
 HRegionServer#join,
 if META/ROOT server has already been stopped, the split thread won't exit 
 because it is in the retrying for HRegionServer#postOpenDeployTasks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7506) Judgment of carrying ROOT/META will become wrong when expiring server

2013-01-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546048#comment-13546048
 ] 

ramkrishna.s.vasudevan commented on HBASE-7506:
---

You got this in trunk?  Am not able to visualise the problem due to not so good 
grip on the Trunk code base wrt recent changes.
May be Jimmy can look this.
Will try to look into it once again later tomorrow.
[~jxiang]
Want to take a look at this?

 Judgment of carrying ROOT/META will become wrong when expiring server
 -

 Key: HBASE-7506
 URL: https://issues.apache.org/jira/browse/HBASE-7506
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7506-trunk v1.patch


 We will check whether server carrying ROOT/META when expiring the server.
 See ServerManager#expireServer.
 If the dead server carrying META, we assign meta directly in the process of 
 ServerShutdownHandler.
 If the dead server carrying ROOT, we will offline ROOT and then 
 verifyAndAssignRootWithRetries()
 How judgement of carrtying ROOT/META become wrong?
 If region is in RIT, and isCarryingRegion() return true after addressing from 
 zk.
 However, once RIT time out(could be caused by this.allRegionServersOffline  
 !noRSAvailable, see AssignmentManager#TimeoutMonitor)   and we assign it to 
 otherwhere, this judgement become wrong.
 See AssignmentManager#isCarryingRegion for details
 With the wrong judgement of carrtying ROOT/META, we would assign ROOT/META 
 twice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7505) Server will hang when stopping cluster, caused by waiting for split threads

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546049#comment-13546049
 ] 

nkeywal commented on HBASE-7505:


+1, some tests hangs because of this and it seems difficult to manage in 
production.

 Server will hang when stopping cluster, caused by waiting for split threads
 ---

 Key: HBASE-7505
 URL: https://issues.apache.org/jira/browse/HBASE-7505
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7505-trunk v1.patch


 We will retry 100 times (about 3200 minitues) for 
 HRegionServer#postOpenDeployTasks now, see 
 HConnectionManager#setServerSideHConnectionRetries.
 However, 
 when we stopping the cluster, we will wait for split threads in  
 HRegionServer#join,
 if META/ROOT server has already been stopped, the split thread won't exit 
 because it is in the retrying for HRegionServer#postOpenDeployTasks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-7407:
---

Status: Patch Available  (was: Open)

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7403) Online Merge

2013-01-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546068#comment-13546068
 ] 

ramkrishna.s.vasudevan commented on HBASE-7403:
---

bq.We receive the merge request in a zookeeper event handler, and I don't want 
to check the above situation in that handler because that handler is 
synchronized

Ok makes sense.

bq.It is a new merge request, but we can't get the regioninfo of merging 
regions, it seems user send a wrong request.

But i felt like, while doing complete_merging if due to some reason we dont get 
regioninfo and we retry why not the same thing happen here in CREATE_MERGE too.

bq.see SSH#processDeadRegion and RegionMergeManager#mergingRegions
Thanks.  I missed it in the code.

bq.I think the Merger thread should read the znode and try to restart the merge 
right?

Don't think am asking this again. My point was does the failed merge 
transaction, restart again on master restart?
Because the resubmit queue is going to be empty right?  Should we forcefully 
read the merge znode and completed the failed merge as do for SPLIT.

Thanks for your answers.

 Online Merge
 

 Key: HBASE-7403
 URL: https://issues.apache.org/jira/browse/HBASE-7403
 Project: HBase
  Issue Type: New Feature
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0, 0.94.5

 Attachments: 7403-trunkv5.patch, 7403-trunkv6.patch, 7403v5.diff, 
 7403-v5.txt, 7403v5.txt, hbase-7403-94v1.patch, hbase-7403-trunkv1.patch, 
 hbase-7403-trunkv5.patch, hbase-7403-trunkv6.patch, hbase-7403-trunkv7.patch, 
 merge region.pdf


 The feature of this online merge:
 1.Online,no necessary to disable table
 2.Less change for current code, could applied in trunk,0.94 or 0.92,0.90
 3.Easy to call merege request, no need to input a long region name, only 
 encoded name enough
 4.No limit when operation, you don't need to tabke care the events like 
 Server Dead, Balance, Split, Disabing/Enabing table, no need to take care 
 whether you send a wrong merge request, it has alread done for you
 5.Only little offline time for two merging regions
 We need merge in the following cases:
 1.Region hole or region overlap, can’t be fix by hbck
 2.Region become empty because of TTL and not reasonable Rowkey design
 3.Region is always empty or very small because of presplit when create table
 4.Too many empty or small regions would reduce the system performance(e.g. 
 mslab)
 Current merge tools only support offline and are not able to redo if 
 exception is thrown in the process of merging, causing a dirty data
 For online system, we need a online merge.
 This implement logic of this patch for  Online Merge is :
 For example, merge regionA and regionB into regionC
 1.Offline the two regions A and B
 2.Merge the two regions in the HDFS(Create regionC’s directory, move 
 regionA’s and regionB’s file to regionC’s directory, delete regionA’s and 
 regionB’s directory)
 3.Add the merged regionC to .META.
 4.Assign the merged regionC
 As design of this patch , once we do the merge work in the HDFS,we could redo 
 it until successful if it throws exception or abort or server restart, but 
 couldn’t be rolled back. 
 It depends on
 Use zookeeper to record the transaction journal state, make redo easier
 Use zookeeper to send/receive merge request
 Merge transaction is executed on the master
 Support calling merge request through API or shell tool
 About the merge process, please see the attachment and patch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7505) Server will hang when stopping cluster, caused by waiting for split threads

2013-01-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546069#comment-13546069
 ] 

ramkrishna.s.vasudevan commented on HBASE-7505:
---

@Chunhui
You got 2 +1s for this already.  Wanna commit this yourself :)?

 Server will hang when stopping cluster, caused by waiting for split threads
 ---

 Key: HBASE-7505
 URL: https://issues.apache.org/jira/browse/HBASE-7505
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7505-trunk v1.patch


 We will retry 100 times (about 3200 minitues) for 
 HRegionServer#postOpenDeployTasks now, see 
 HConnectionManager#setServerSideHConnectionRetries.
 However, 
 when we stopping the cluster, we will wait for split threads in  
 HRegionServer#join,
 if META/ROOT server has already been stopped, the split thread won't exit 
 because it is in the retrying for HRegionServer#postOpenDeployTasks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7419) revisit hfilelink file name format.

2013-01-07 Thread Matteo Bertozzi (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matteo Bertozzi updated HBASE-7419:
---

Attachment: HBASE-7419-v2.patch

v2 is same patch as before reverting the changes in Reference.java no longer 
needed.

Will commit unless there are objections.

 revisit hfilelink file name format.
 ---

 Key: HBASE-7419
 URL: https://issues.apache.org/jira/browse/HBASE-7419
 Project: HBase
  Issue Type: Sub-task
  Components: Client, master, regionserver, snapshots, Zookeeper
Reporter: Jonathan Hsieh
Assignee: Matteo Bertozzi
 Fix For: hbase-6055, 0.96.0

 Attachments: HBASE-7419-v0.patch, HBASE-7419-v1.patch, 
 HBASE-7419-v2.patch


 Valid table names are concatted with a '.' to a valid regions names is also a 
 valid table name, and lead to the incorrect interpretation.
 {code}
 true hfile name constraints: [0-9]+(?:_SeqID_[0-9]+)?
 region name constraints: [a-f0-9]{16}  (but we currently just use 
 [a-f0-9]+.)
 table name constraints : [a-zA-Z0-9_][a-zA-Z0-9_.-]*
 {code}
 Notice that the table name constraints completely covers all region name 
 constraints and true hfile name constraints.   (a valid hfile name is a valid 
 part of a table name, and a valid enc region name is a valid part of a table 
 name.
 Currently the hfilelink filename convention is hfile-region-table.  
 Unfortunately, making a ref to this uses the name 
 hfile-region-table.parentregion -- the contactnation of 
 table.parentregion is a valid table name used to get interpreted as such. 
  The fix in HBASE-7339 requires a FileNotFoundException before going down the 
 hfile link resolution path. 
 Regardless of what we do, we need to add some char invalid for table names to 
 the hfilelink or reference filename convention.
 Suggestion: if we changed the order of the hfile-link name we could avoid 
 some of the confusion -- table@region-hfile.parentregion (or some 
 other separator char than '@') could be used to avoid handling on the initial 
 filenotfoundexception but I think we'd still need a good chunk of the logic 
 to handle opening half-storefile reader throw a hfilelink.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7468) TestSplitTransactionOnCluster hangs frequently

2013-01-07 Thread ramkrishna.s.vasudevan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546084#comment-13546084
 ] 

ramkrishna.s.vasudevan commented on HBASE-7468:
---

Thanks Lars.  I will look into this tomorrow and see if i can find something.  
Good on you.

 TestSplitTransactionOnCluster hangs frequently
 --

 Key: HBASE-7468
 URL: https://issues.apache.org/jira/browse/HBASE-7468
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: Lars Hofhansl
 Attachments: 7468-jstack.txt, 7468-output.zip, 
 TestSplitTransactionOnCluster-jstack.txt


 This what I saw once in a local build.
 {code}
 java.lang.Thread.State: TIMED_WAITING (sleeping)
 at java.lang.Thread.sleep(Native Method)
 at 
 org.apache.hadoop.hbase.client.HBaseAdmin.disableTable(HBaseAdmin.java:831)
 at 
 org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testShouldClearRITWhenNodeFoundInSplittingState(TestSplitTransactionOnCluster.java:650)
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)
nkeywal created HBASE-7508:
--

 Summary: Fix simple findbugs
 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7471) Enable Cleaners required for Snapshots by default?

2013-01-07 Thread Jonathan Hsieh (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-7471:
--

Description: 
Currently, snapshots require admins to add configuration to their 
hbase-site.xml to have snapshot functionality available.  It is at the moment 
off by default.

{code}
 property
namehbase.snapshot.enabled/name
valuetrue/value
  /property
{code}

Maybe we should just enable snapshots by default.  Discuss.

  was:Maybe we should just enable snapshots by default.  Discuss.


 Enable Cleaners required for Snapshots by default?
 --

 Key: HBASE-7471
 URL: https://issues.apache.org/jira/browse/HBASE-7471
 Project: HBase
  Issue Type: Sub-task
  Components: Client, master, regionserver, snapshots, Zookeeper
Reporter: Jonathan Hsieh
 Fix For: hbase-6055, 0.96.0


 Currently, snapshots require admins to add configuration to their 
 hbase-site.xml to have snapshot functionality available.  It is at the moment 
 off by default.
 {code}
  property
 namehbase.snapshot.enabled/name
 valuetrue/value
   /property
 {code}
 Maybe we should just enable snapshots by default.  Discuss.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-7508:
---

Attachment: 7508.v1.patch

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-7508:
---

Status: Patch Available  (was: Open)

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7419) revisit hfilelink file name format.

2013-01-07 Thread Jonathan Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546113#comment-13546113
 ] 

Jonathan Hsieh commented on HBASE-7419:
---

+1, go for it.

 revisit hfilelink file name format.
 ---

 Key: HBASE-7419
 URL: https://issues.apache.org/jira/browse/HBASE-7419
 Project: HBase
  Issue Type: Sub-task
  Components: Client, master, regionserver, snapshots, Zookeeper
Reporter: Jonathan Hsieh
Assignee: Matteo Bertozzi
 Fix For: hbase-6055, 0.96.0

 Attachments: HBASE-7419-v0.patch, HBASE-7419-v1.patch, 
 HBASE-7419-v2.patch


 Valid table names are concatted with a '.' to a valid regions names is also a 
 valid table name, and lead to the incorrect interpretation.
 {code}
 true hfile name constraints: [0-9]+(?:_SeqID_[0-9]+)?
 region name constraints: [a-f0-9]{16}  (but we currently just use 
 [a-f0-9]+.)
 table name constraints : [a-zA-Z0-9_][a-zA-Z0-9_.-]*
 {code}
 Notice that the table name constraints completely covers all region name 
 constraints and true hfile name constraints.   (a valid hfile name is a valid 
 part of a table name, and a valid enc region name is a valid part of a table 
 name.
 Currently the hfilelink filename convention is hfile-region-table.  
 Unfortunately, making a ref to this uses the name 
 hfile-region-table.parentregion -- the contactnation of 
 table.parentregion is a valid table name used to get interpreted as such. 
  The fix in HBASE-7339 requires a FileNotFoundException before going down the 
 hfile link resolution path. 
 Regardless of what we do, we need to add some char invalid for table names to 
 the hfilelink or reference filename convention.
 Suggestion: if we changed the order of the hfile-link name we could avoid 
 some of the confusion -- table@region-hfile.parentregion (or some 
 other separator char than '@') could be used to avoid handling on the initial 
 filenotfoundexception but I think we'd still need a good chunk of the logic 
 to handle opening half-storefile reader throw a hfilelink.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6015) HBCK rerun should check all the regions which it checked in the first run

2013-01-07 Thread Jonathan Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546116#comment-13546116
 ] 

Jonathan Hsieh commented on HBASE-6015:
---

sounds good.

 HBCK rerun should check all the regions which it checked in the first run
 -

 Key: HBASE-6015
 URL: https://issues.apache.org/jira/browse/HBASE-6015
 Project: HBase
  Issue Type: Bug
  Components: hbck
Reporter: Anoop Sam John

 When after the 1st round of run and possible fixes, HBCK does a rerun to 
 check the consistency of the regions. At this rerun
 1.It should check all the regions which it checked in the 1st round. 
 2.It should check only those regions which it checked in the 1st round. Might 
 be some other regions can come out of the timelag check at rerun time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Jonathan Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546121#comment-13546121
 ] 

Jonathan Hsieh commented on HBASE-7508:
---

Squish these into a single line?
{code}
 ArrayListColumnDescriptor columns = new 
ArrayListColumnDescriptor();
-ColumnDescriptor col = null;
+ColumnDescriptor col;
 col = new ColumnDescriptor();
 col.name = ByteBuffer.wrap(bytes(entry:));
 col.maxVersions = 10;
@@ -227,7 +227,7 @@ public class DemoClient {
 client.mutateRow(ByteBuffer.wrap(t), ByteBuffer.wrap(row), 
mutations, dummyAttributes);
 printRow(client.getRow(ByteBuffer.wrap(t), ByteBuffer.wrap(row), 
dummyAttributes));
 
-Mutation m = null;
+Mutation m;
 mutations = new ArrayListMutation();
 m = new Mutation();
 m.column = ByteBuffer.wrap(bytes(entry:foo));
@@ -272,7 +272,7 @@ public class DemoClient {
{code}

Findbugs is lgpl. http://findbugs.sourceforge.net/manual/license.htmlThis 
adds a code dependency Can we do this via the excludes file instead?
{code}
*/
+  @edu.umd.cs.findbugs.annotations.SuppressWarnings(value=MS_SHOULD_BE_FINAL)

{code}

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-7509) Enable RS to query a secondary datanode in parallel, if the primary takes too long

2013-01-07 Thread Amitanand Aiyer (JIRA)
Amitanand Aiyer created HBASE-7509:
--

 Summary: Enable RS to query a secondary datanode in parallel, if 
the primary takes too long
 Key: HBASE-7509
 URL: https://issues.apache.org/jira/browse/HBASE-7509
 Project: HBase
  Issue Type: Improvement
Reporter: Amitanand Aiyer
Priority: Minor




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7506) Judgment of carrying ROOT/META will become wrong when expiring server

2013-01-07 Thread Jimmy Xiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546123#comment-13546123
 ] 

Jimmy Xiang commented on HBASE-7506:


This is subtle. This part is not touched wrt recent changes. I agree it is 
possible root/meta could be assigning to the dead rs, which is processing by 
SSH.
The existing code assigns root/meta again is not efficient, but won't cause any 
problem in such a case.

It makes sense to check it again. However, if they are still RIT at this 
re-checking moment, it is probably not efficient to re-assign them than wait, 
right?

So I think we can do the following:

1. remove class MetaServerShutdownHandler;
2. in ServerShutdownHandler, make isCarryingRoot and isCarryingMeta local 
variables to process method, dynamically set it based on AM, as in Chunhui's 
patch;
3. in verifyAndAssignRootWithRetries, check if root is RIT, if so, should we 
time it out and wait, or just force-reassgin?
4. Can we have a similar verifyAndAssignMetaWithRetries in SSH?  If meta can be 
verified, no need to re-assign?

[~ram_krish], what do you think?

Adding [~nkeywal] too.


 Judgment of carrying ROOT/META will become wrong when expiring server
 -

 Key: HBASE-7506
 URL: https://issues.apache.org/jira/browse/HBASE-7506
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7506-trunk v1.patch


 We will check whether server carrying ROOT/META when expiring the server.
 See ServerManager#expireServer.
 If the dead server carrying META, we assign meta directly in the process of 
 ServerShutdownHandler.
 If the dead server carrying ROOT, we will offline ROOT and then 
 verifyAndAssignRootWithRetries()
 How judgement of carrtying ROOT/META become wrong?
 If region is in RIT, and isCarryingRegion() return true after addressing from 
 zk.
 However, once RIT time out(could be caused by this.allRegionServersOffline  
 !noRSAvailable, see AssignmentManager#TimeoutMonitor)   and we assign it to 
 otherwhere, this judgement become wrong.
 See AssignmentManager#isCarryingRegion for details
 With the wrong judgement of carrtying ROOT/META, we would assign ROOT/META 
 twice.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546129#comment-13546129
 ] 

Hadoop QA commented on HBASE-7407:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563588/7407.v3.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.master.TestRollingRestart

 {color:red}-1 core zombie tests{color}.  There are 6 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3905//console

This message is automatically generated.

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7419) revisit hfilelink file name format.

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546132#comment-13546132
 ] 

stack commented on HBASE-7419:
--

In hdfs, a path is a URI (http://en.wikipedia.org/wiki/URI_scheme).  For the 
URI 'scheme' part rules, this is usually protocols specific and the URI 
parsers just do a pass-through (they are supposed to).  Looking at the 
Path.java class to see how it handles the scheme, I see no special casing for 
'@' in Path.java.  I was afraid it'd get interpreted somewhere in our parsing 
code as delimiter between username and hostname (mailto: and http: 
protocols).  Probably best to just avoid it though if possible.  '=' sounds 
like it will work but is hard to read without thinking equality or assignment.

Regards the patch, it looks good.  Are there enough tests of different filename 
combinations?  Regexes' can surprise in interesting ways.

 revisit hfilelink file name format.
 ---

 Key: HBASE-7419
 URL: https://issues.apache.org/jira/browse/HBASE-7419
 Project: HBase
  Issue Type: Sub-task
  Components: Client, master, regionserver, snapshots, Zookeeper
Reporter: Jonathan Hsieh
Assignee: Matteo Bertozzi
 Fix For: hbase-6055, 0.96.0

 Attachments: HBASE-7419-v0.patch, HBASE-7419-v1.patch, 
 HBASE-7419-v2.patch


 Valid table names are concatted with a '.' to a valid regions names is also a 
 valid table name, and lead to the incorrect interpretation.
 {code}
 true hfile name constraints: [0-9]+(?:_SeqID_[0-9]+)?
 region name constraints: [a-f0-9]{16}  (but we currently just use 
 [a-f0-9]+.)
 table name constraints : [a-zA-Z0-9_][a-zA-Z0-9_.-]*
 {code}
 Notice that the table name constraints completely covers all region name 
 constraints and true hfile name constraints.   (a valid hfile name is a valid 
 part of a table name, and a valid enc region name is a valid part of a table 
 name.
 Currently the hfilelink filename convention is hfile-region-table.  
 Unfortunately, making a ref to this uses the name 
 hfile-region-table.parentregion -- the contactnation of 
 table.parentregion is a valid table name used to get interpreted as such. 
  The fix in HBASE-7339 requires a FileNotFoundException before going down the 
 hfile link resolution path. 
 Regardless of what we do, we need to add some char invalid for table names to 
 the hfilelink or reference filename convention.
 Suggestion: if we changed the order of the hfile-link name we could avoid 
 some of the confusion -- table@region-hfile.parentregion (or some 
 other separator char than '@') could be used to avoid handling on the initial 
 filenotfoundexception but I think we'd still need a good chunk of the logic 
 to handle opening half-storefile reader throw a hfilelink.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546135#comment-13546135
 ] 

stack commented on HBASE-7508:
--

+1

Why does it want you not to assign null to local variables?

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546148#comment-13546148
 ] 

stack commented on HBASE-7407:
--

[~jxiang] What you think of the new patch Jimmy?  Thanks boss.

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread Jimmy Xiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546169#comment-13546169
 ] 

Jimmy Xiang commented on HBASE-7407:


We have a DoNotRetryIOException.  Does this mean all other exceptions are 
retriable? Do we need a PleaseRetryException?

Why do we need another lock? The caller of processRegionsInTransition should 
already have the lock, right?

I thought about the issue again. I am fine with other changes. As to the 
assignment manager change, I think it is better to use the original logic which 
is much simpler.  One enhancement to the original logic we can do, is that we 
can time out those region transitions earlier so that timeout monitor can 
reassign them earlier, if needed.

One thing I need to point out is that this method is only called during a 
failure recovery (master and some region servers are died together).

Adding [~ram_krish], Ram, can you take a look?


 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7507) Make memstore flush be able to retry after exception

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546173#comment-13546173
 ] 

stack commented on HBASE-7507:
--

I'd be fine making this configurable as long as retry enabled was the default.

Flushing is not the only write we do.  Should we open a new issue to retry all 
hdfs operations?  Put the retries into our wrapper around our filesystem 
instance, HFileSystem?



 Make memstore flush be able to retry after exception
 

 Key: HBASE-7507
 URL: https://issues.apache.org/jira/browse/HBASE-7507
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Fix For: 0.96.0

 Attachments: 7507-trunk v1.patch


 We will abort regionserver if memstore flush throws exception.
 I thinks we could do retry to make regionserver more stable because file 
 system may be not ok in a transient time. e.g. Switching namenode in the 
 NamenodeHA environment
 {code}
 HRegion#internalFlushcache(){
 ...
 try {
 ...
 }catch(Throwable t){
 DroppedSnapshotException dse = new DroppedSnapshotException(region:  +
   Bytes.toStringBinary(getRegionName()));
 dse.initCause(t);
 throw dse;
 }
 ...
 }
 MemStoreFlusher#flushRegion(){
 ...
 region.flushcache();
 ...
  try {
 }catch(DroppedSnapshotException ex){
 server.abort(Replay of HLog required. Forcing server shutdown, ex);
 }
 ...
 }
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546175#comment-13546175
 ] 

nkeywal commented on HBASE-7508:


bq. Why does it want you not to assign null to local variables?
Because IntelliJ complains when there are unused assignment ;-). I think it's 
right, and it allows to see clearly when you're forgetting something.

bq. Findbugs is lgpl. http://findbugs.sourceforge.net/manual/license.html This 
adds a code dependency Can we do this via the excludes file instead?
It's less efficient... What do you think of copy-pasting this as a workaround? 
https://github.com/stephenc/findbugs-annotations

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-7510) RegionTransitionData uses EventType enum index and not the value

2013-01-07 Thread Matteo Bertozzi (JIRA)
Matteo Bertozzi created HBASE-7510:
--

 Summary: RegionTransitionData uses EventType enum index and not 
the value
 Key: HBASE-7510
 URL: https://issues.apache.org/jira/browse/HBASE-7510
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3, 0.92.2
Reporter: Matteo Bertozzi


RegionTransitionData.write() uses eventType.ordinal() that is the index in the 
enum and not the value specified in the enum definition.
so, to keep compatibility (e.g. rolling upgrades) we can't add stuff in the 
middle, remove or move around EventHand.EventType items.

This is just a 0.92/0.94 problem. In trunk/protobuf is fixed since we use 
eventType.getCode() that returns the assigned value and not the enum index.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546185#comment-13546185
 ] 

nkeywal commented on HBASE-7407:


bq. We have a DoNotRetryIOException. Does this mean all other exceptions are 
retriable? 
Unfortunately no. For example, ServerNotRunningYetException is retriable but 
RegionServerStoppedException is not. Still they both extends IOException.

bq. Do we need a PleaseRetryException?
If we want to distinguish the different cases between:
- retriable
- not retriable
- don't know 

then yes :-). And the don't know can means 'not coded' or 'I really don't know'.

bq. Why do we need another lock? The caller of processRegionsInTransition 
should already have the lock, right?
Yes you're right. I will fix this.

bq. One enhancement to the original logic we can do, is that we can time out 
those region transitions earlier so that timeout monitor can reassign them 
earlier, if needed.
I'm not a big fan, it's adding an extra case. Resending seems much better. 
What's the issue you're seeing?





 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7504) -ROOT- may be offline forever after FullGC of RS

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546188#comment-13546188
 ] 

stack commented on HBASE-7504:
--

+1 on patch with Ram's suggested fix addressed on commit.

 -ROOT- may be offline forever after FullGC of  RS
 -

 Key: HBASE-7504
 URL: https://issues.apache.org/jira/browse/HBASE-7504
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.94.3
Reporter: chunhui shen
Assignee: chunhui shen
 Attachments: 7504-trunk v1.patch


 1.FullGC happen on ROOT regionserver.
 2.ZK session timeout, master expire the regionserver and submit to 
 ServerShutdownHandler
 3.Regionserver complete the FullGC
 4.In the process of ServerShutdownHandler, verifyRootRegionLocation returns 
 true
 5.ServerShutdownHandler skip assigning -ROOT- region
 6.Regionserver abort itself because it reveive YouAreDeadException after a 
 regionserver report
 7.-ROO- is offline now, and won't be assigned any more unless we restart 
 master
 Master Log:
 {code}
 2012-10-31 19:51:39,043 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Added=dw88.kgb.sqa.cm4,60020,1351671478752 to dead servers, submitted 
 shutdown handler to be executed, root=true, meta=false
 2012-10-31 19:51:39,045 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Splitting logs 
 for dw88.kgb.sqa.cm4,60020,1351671478752
 2012-10-31 19:51:50,113 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Server 
 dw88.kgb.sqa.cm4,60020,1351671478752 was carrying ROOT. Trying to assign.
 2012-10-31 19:52:15,939 DEBUG org.apache.hadoop.hbase.master.ServerManager: 
 Server REPORT rejected; currently processing 
 dw88.kgb.sqa.cm4,60020,1351671478752 as dead server
 2012-10-31 19:52:15,945 INFO 
 org.apache.hadoop.hbase.master.handler.ServerShutdownHandler: Skipping log 
 splitting for dw88.kgb.sqa.cm4,60020,1351671478752
 {code}
 No log of assigning -ROOT-
 Regionserver log:
 {code}
 2012-10-31 19:52:15,923 WARN org.apache.hadoop.hbase.util.Sleeper: We slept 
 229128ms instead of 10ms, this is likely due to a long garbage collecting 
 pause and it's usually bad, see 
 http://hbase.apache.org/book.html#trouble.rs.runtime.zkexpired
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Jonathan Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546194#comment-13546194
 ] 

Jonathan Hsieh commented on HBASE-7508:
---

I dislike this lawyerly stuff but it is important that we do this correctly.  
Avoiding it or just using known ok ways (we've been using excludes files here) 
seems the safest way.  Is there a precedent elsewhere with LGPL+Apache 
compatibility?  Should we ping apache legal? 

Here's the rules I found with a little bit of search. 
http://www.apache.org/licenses/GPL-compatibility.html
There were a few other suggesting they are compatible but these were from 
non-authoritative sources.

Technically, I'd be satisfied if we used the workaround.  (the description of 
that project is quite humorous!).  This should just be a pom inclusion right?  
It seems like it would eliminate the possibility of including the lgpl jars 
from our tarballs.



 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-7511) Replace fsReadLatency metrics with preads latency

2013-01-07 Thread Rishit Shroff (JIRA)
Rishit Shroff created HBASE-7511:


 Summary: Replace fsReadLatency metrics with preads latency
 Key: HBASE-7511
 URL: https://issues.apache.org/jira/browse/HBASE-7511
 Project: HBase
  Issue Type: Bug
Reporter: Rishit Shroff
Priority: Minor


With Hbase now using preads for all the read ops, the read latency metrics need 
to be updated to capture the stats about the pread latencies. This issue to 
track that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3996) Support multiple tables and scanners as input to the mapper in map/reduce jobs

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546201#comment-13546201
 ] 

Hadoop QA commented on HBASE-3996:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563581/3996-v11.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

 {color:red}-1 core zombie tests{color}.  There are 7 zombie test(s):   
at 
org.apache.hadoop.hbase.catalog.TestCatalogTracker.testServerNotRunningIOException(TestCatalogTracker.java:250)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3906//console

This message is automatically generated.

 Support multiple tables and scanners as input to the mapper in map/reduce jobs
 --

 Key: HBASE-3996
 URL: https://issues.apache.org/jira/browse/HBASE-3996
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce
Reporter: Eran Kutner
Assignee: Lars Hofhansl
 Fix For: 0.96.0, 0.94.5

 Attachments: 3996-v10.txt, 3996-v11.txt, 3996-v2.txt, 3996-v3.txt, 
 3996-v4.txt, 3996-v5.txt, 3996-v6.txt, 3996-v7.txt, 3996-v8.txt, 3996-v9.txt, 
 HBase-3996.patch


 It seems that in many cases feeding data from multiple tables or multiple 
 scanners on a single table can save a lot of time when running map/reduce 
 jobs.
 I propose a new MultiTableInputFormat class that would allow doing this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread Jimmy Xiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546204#comment-13546204
 ] 

Jimmy Xiang commented on HBASE-7407:


bq. then yes :-). And the don't know can means 'not coded' or 'I really don't 
know'.

I see.  I think by retriable, you mean it is retriable on the same region 
server, right?  Some exception may not be retriable on the same region server, 
but retriable on another region server. Is that possible?

bq. I'm not a big fan, it's adding an extra case. Resending seems much better. 
What's the issue you're seeing?

I don't see any issue. My concern is that we are going to have some duplicated 
logic, and it will make the code hard to understand/maintain.  For the 
scenarios targeted by the patch, I think timeout monitor can handle it too.  If 
so, then why not let TM do the work?  If TM doesn't handle it fast enough, we 
can time it out quickly.





 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7511) Replace fsReadLatency metrics with preads latency

2013-01-07 Thread Elliott Clark (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-7511:
-

Component/s: metrics

 Replace fsReadLatency metrics with preads latency
 -

 Key: HBASE-7511
 URL: https://issues.apache.org/jira/browse/HBASE-7511
 Project: HBase
  Issue Type: Bug
  Components: metrics
Reporter: Rishit Shroff
Priority: Minor

 With Hbase now using preads for all the read ops, the read latency metrics 
 need to be updated to capture the stats about the pread latencies. This issue 
 to track that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-6028) Implement a cancel for in-progress compactions

2013-01-07 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-6028:
-

  Tags: noob
Labels: compaction noob operations regionserver  (was: compaction 
operations regionserver)

 Implement a cancel for in-progress compactions
 --

 Key: HBASE-6028
 URL: https://issues.apache.org/jira/browse/HBASE-6028
 Project: HBase
  Issue Type: Bug
  Components: regionserver
Reporter: Derek Wollenstein
Priority: Minor
  Labels: compaction, noob, operations, regionserver

 Depending on current server load, it can be extremely expensive to run 
 periodic minor / major compactions.  It would be helpful to have a feature 
 where a user could use the shell or a client tool to explicitly cancel an 
 in-progress compactions.  This would allow a system to recover when too many 
 regions became eligible for compactions at once

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546216#comment-13546216
 ] 

nkeywal commented on HBASE-7407:


bq. I see. I think by retriable, you mean it is retriable on the same region 
server, right? Some exception may not be retriable on the same region server, 
but retriable on another region server. Is that possible?

Yes. That's what we do for an open: don't retry on this one. That's the case 
for open: don't retry on this one.

bq. My concern is that we are going to have some duplicated logic, and it will 
make the code hard to understand/maintain. For the scenarios targeted by the 
patch, I think timeout monitor can handle it too. If so, then why not let TM do 
the work? If TM doesn't handle it fast enough, we can time it out quickly.

If the master fails, we should reopen the regions in progress as soon as 
possible, relying on a timeout seems dangerous to me:
- in such scenarios, the system is likely overloaded: so reassigning regions 
aggressively would be adding load on top of on already complex situation
- not being aggressive means waiting for a long time: time to detect that the 
master is dead + time for the workaround. It means we're over the minute best 
case.

The TM is an expensive feature, we should not need it on a standard workflow 
(and failures are standard :-) (but its function of 'last chance checker' is 
useful: it's a safety net, but it should not be anything else). 


 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546224#comment-13546224
 ] 

Hadoop QA commented on HBASE-7508:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563604/7508.v1.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.TestZooKeeper

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3908//console

This message is automatically generated.

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546225#comment-13546225
 ] 

Hadoop QA commented on HBASE-7407:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563588/7407.v3.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3907//console

This message is automatically generated.

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546227#comment-13546227
 ] 

nkeywal commented on HBASE-7508:


@[~jmhsieh]
It seems it's available on a public repo 
(http://mvnrepository.com/artifact/com.github.stephenc.findbugs/findbugs-annotations/)
 so it seems yep we could have it. Let me try.

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546234#comment-13546234
 ] 

stack commented on HBASE-7508:
--

We can't ship LGPL.  IMO, it should be fine having us depend on an LGPL at 
compile time as long as the dependency was pulled by maven at compile time.

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546236#comment-13546236
 ] 

stack commented on HBASE-7407:
--

[~nkeywal] Can you add the following succinct comment to the TM code in a 
prominent place the next time you make a patch related to it? I think it will 
help others who come later messing in this area.

The TM is an expensive feature, we should not need it on a standard workflow 
(and failures are standard  (but its function of 'last chance checker' is 
useful: it's a safety net, but it should not be anything else).

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7511) Replace fsReadLatency metrics with preads latency

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546238#comment-13546238
 ] 

stack commented on HBASE-7511:
--

[~rshroff] Good point (We don't use pread 'everywhere'... but yeah, a very 
significant proportion of reads are pread).

 Replace fsReadLatency metrics with preads latency
 -

 Key: HBASE-7511
 URL: https://issues.apache.org/jira/browse/HBASE-7511
 Project: HBase
  Issue Type: Bug
  Components: metrics
Reporter: Rishit Shroff
Priority: Minor

 With Hbase now using preads for all the read ops, the read latency metrics 
 need to be updated to capture the stats about the pread latencies. This issue 
 to track that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546239#comment-13546239
 ] 

nkeywal commented on HBASE-7508:


It's suppose to be RetentionPolicy.CLASS. I.e. not needed at runtime. I 
checked, it's the case. But in the library, I found one annotation (that we 
don't use) with runtime annotation.

The apache library I mentioned above works. I got the same number of issues. 
It's available in one of the repo we already have. Maybe the simplest option is 
to link with this one?


 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7510) RegionTransitionData uses EventType enum index and not the value

2013-01-07 Thread Jonathan Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546247#comment-13546247
 ] 

Jonathan Hsieh commented on HBASE-7510:
---

I think for compatibility, we are stuck with this.  Maybe we can close this out 
by adding a comments in the 0.94/0.92 code documenting this unexpected behavior?

 RegionTransitionData uses EventType enum index and not the value
 

 Key: HBASE-7510
 URL: https://issues.apache.org/jira/browse/HBASE-7510
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.92.2, 0.94.3
Reporter: Matteo Bertozzi

 RegionTransitionData.write() uses eventType.ordinal() that is the index in 
 the enum and not the value specified in the enum definition.
 so, to keep compatibility (e.g. rolling upgrades) we can't add stuff in the 
 middle, remove or move around EventHand.EventType items.
 This is just a 0.92/0.94 problem. In trunk/protobuf is fixed since we use 
 eventType.getCode() that returns the assigned value and not the enum index.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread Jimmy Xiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546251#comment-13546251
 ] 

Jimmy Xiang commented on HBASE-7407:


Since the patch is getting big, can you put it on RB?

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3996) Support multiple tables and scanners as input to the mapper in map/reduce jobs

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546250#comment-13546250
 ] 

Hadoop QA commented on HBASE-3996:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563581/3996-v11.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.replication.TestReplication
  org.apache.hadoop.hbase.master.TestMasterFailover

 {color:red}-1 core zombie tests{color}.  There are 6 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3909//console

This message is automatically generated.

 Support multiple tables and scanners as input to the mapper in map/reduce jobs
 --

 Key: HBASE-3996
 URL: https://issues.apache.org/jira/browse/HBASE-3996
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce
Reporter: Eran Kutner
Assignee: Lars Hofhansl
 Fix For: 0.96.0, 0.94.5

 Attachments: 3996-v10.txt, 3996-v11.txt, 3996-v2.txt, 3996-v3.txt, 
 3996-v4.txt, 3996-v5.txt, 3996-v6.txt, 3996-v7.txt, 3996-v8.txt, 3996-v9.txt, 
 HBase-3996.patch


 It seems that in many cases feeding data from multiple tables or multiple 
 scanners on a single table can save a lot of time when running map/reduce 
 jobs.
 I propose a new MultiTableInputFormat class that would allow doing this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Jonathan Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546252#comment-13546252
 ] 

Jonathan Hsieh commented on HBASE-7508:
---

I'm fine with the non-lgpl library, or with excludes file approaches.  Your 
choice, and simple is good.  

If you choose the library, we need to document this -- if someone sees this 
again it would be good to have a comment about this in our pom, on maybe in the 
docs (in a grep'able way?)


 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (HBASE-7476) HBase shell count command doesn't escape binary output

2013-01-07 Thread stack (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack resolved HBASE-7476.
--

   Resolution: Fixed
Fix Version/s: 0.94.5
   0.96.0
 Hadoop Flags: Reviewed

Committed to trunk and 0.94 branch.  Thank you for the patch Gabriel

 HBase shell count command doesn't escape binary output
 --

 Key: HBASE-7476
 URL: https://issues.apache.org/jira/browse/HBASE-7476
 Project: HBase
  Issue Type: Bug
  Components: shell
Reporter: Gabriel Reid
Priority: Minor
 Fix For: 0.96.0, 0.94.5

 Attachments: HBASE-7476_1.patch, HBASE-7476.patch


 When running the the count command in the HBase shell, the row key is printed 
 each time a count interval is reached. However, the key is printed verbatim, 
 meaning that non-printable characters are directly printed to the terminal. 
 This can cause confusing results, or even leave the terminal in an unusable 
 state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-3996) Support multiple tables and scanners as input to the mapper in map/reduce jobs

2013-01-07 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-3996:
--

Status: Open  (was: Patch Available)

 Support multiple tables and scanners as input to the mapper in map/reduce jobs
 --

 Key: HBASE-3996
 URL: https://issues.apache.org/jira/browse/HBASE-3996
 Project: HBase
  Issue Type: Improvement
  Components: mapreduce
Reporter: Eran Kutner
Assignee: Lars Hofhansl
 Fix For: 0.96.0, 0.94.5

 Attachments: 3996-v10.txt, 3996-v11.txt, 3996-v2.txt, 3996-v3.txt, 
 3996-v4.txt, 3996-v5.txt, 3996-v6.txt, 3996-v7.txt, 3996-v8.txt, 3996-v9.txt, 
 HBase-3996.patch


 It seems that in many cases feeding data from multiple tables or multiple 
 scanners on a single table can save a lot of time when running map/reduce 
 jobs.
 I propose a new MultiTableInputFormat class that would allow doing this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546261#comment-13546261
 ] 

Hadoop QA commented on HBASE-7508:
--

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563604/7508.v1.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3910//console

This message is automatically generated.

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7407) TestMasterFailover under tests some cases and over tests some others

2013-01-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546262#comment-13546262
 ] 

Hadoop QA commented on HBASE-7407:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12563588/7407.v3.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

{color:green}+1 core tests{color}.  The patch passed unit tests in .

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3911//console

This message is automatically generated.

 TestMasterFailover under tests some cases and over tests some others
 

 Key: HBASE-7407
 URL: https://issues.apache.org/jira/browse/HBASE-7407
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Attachments: 7407.v1.patch, 7407.v2.patch, 7407.v3.patch


 The tests are done with this settings:
 conf.setInt(hbase.master.assignment.timeoutmonitor.period, 2000);
 conf.setInt(hbase.master.assignment.timeoutmonitor.timeout, 4000);
 As a results:
 1) some tests seems to work, but in real life, the recovery would take 5 
 minutes or more, as in production there always higher. So we don't see the 
 real issues.
 2) The tests include specific cases that should not happen in production. It 
 works because the timeout catches everything, but these scenarios do not need 
 to be optimized, as they cannot happen. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546268#comment-13546268
 ] 

nkeywal commented on HBASE-7508:


Let's go for the library way then.
And ok for the doc work as well.
If nobody objects, I will commit this patch soon, as this touches multiple 
files. I will do the doc this week.

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Jonathan Hsieh (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546272#comment-13546272
 ] 

Jonathan Hsieh commented on HBASE-7508:
---

+1

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546274#comment-13546274
 ] 

stack commented on HBASE-7508:
--

+1 You will open another issue to do the doc/lib?

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HBASE-7512) Document the findbugs library annotation

2013-01-07 Thread nkeywal (JIRA)
nkeywal created HBASE-7512:
--

 Summary: Document the findbugs library annotation
 Key: HBASE-7512
 URL: https://issues.apache.org/jira/browse/HBASE-7512
 Project: HBase
  Issue Type: Improvement
  Components: documentation
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
 Fix For: 0.96.0


See HBASE-7508

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546277#comment-13546277
 ] 

nkeywal commented on HBASE-7508:


Done. Thanks for the review!

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-7508:
---

Attachment: 7508.v2.patch

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch, 7508.v2.patch, 7508.v2.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nkeywal updated HBASE-7508:
---

Status: Open  (was: Patch Available)

 Fix simple findbugs
 ---

 Key: HBASE-7508
 URL: https://issues.apache.org/jira/browse/HBASE-7508
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Trivial
 Fix For: 0.96.0

 Attachments: 7508.v1.patch, 7508.v2.patch, 7508.v2.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


  1   2   3   >