[jira] [Updated] (HBASE-10092) Move to slf4j
[ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-10092: Attachment: HBASE-10092.master.004.patch Fixed checkstyle issues. > Move to slf4j > - > > Key: HBASE-10092 > URL: https://issues.apache.org/jira/browse/HBASE-10092 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Balazs Meszaros >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, > HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, > HBASE-10092.master.003.patch, HBASE-10092.master.004.patch, HBASE-10092.patch > > > Allows logging with less friction. See http://logging.apache.org/log4j/2.x/ > This rather radical transition can be done w/ minor change given they have an > adapter for apache's logging, the one we use. They also have and adapter for > slf4j so we likely can remove at least some of the 4 versions of this module > our dependencies make use of. > I made a start in attached patch but am currently stuck in maven dependency > resolve hell courtesy of our slf4j. Fixing will take some concentration and > a good net connection, an item I currently lack. Other TODOs are that will > need to fix our little log level setting jsp page -- will likely have to undo > our use of hadoop's tool here -- and the config system changes a little. > I will return to this project soon. Will bring numbers. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-10092) Move to slf4j
[ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298556#comment-16298556 ] Balazs Meszaros edited comment on HBASE-10092 at 12/20/17 2:12 PM: --- Fixed checkstyle issues and rebased. was (Author: balazs.meszaros): Fixed checkstyle issues. > Move to slf4j > - > > Key: HBASE-10092 > URL: https://issues.apache.org/jira/browse/HBASE-10092 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: Balazs Meszaros >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, > HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, > HBASE-10092.master.003.patch, HBASE-10092.master.004.patch, HBASE-10092.patch > > > Allows logging with less friction. See http://logging.apache.org/log4j/2.x/ > This rather radical transition can be done w/ minor change given they have an > adapter for apache's logging, the one we use. They also have and adapter for > slf4j so we likely can remove at least some of the 4 versions of this module > our dependencies make use of. > I made a start in attached patch but am currently stuck in maven dependency > resolve hell courtesy of our slf4j. Fixing will take some concentration and > a good net connection, an item I currently lack. Other TODOs are that will > need to fix our little log level setting jsp page -- will likely have to undo > our use of hadoop's tool here -- and the config system changes a little. > I will return to this project soon. Will bring numbers. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20571:
Attachment: HBASE-20571.branch-2.0.002.patch
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 2.0.1
>
> Attachments: HBASE-20571.branch-2.0.001.patch,
> HBASE-20571.branch-2.0.002.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-15002) TestRSKilledWhenInitializing is flakey
[ https://issues.apache.org/jira/browse/HBASE-15002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros resolved HBASE-15002. - Resolution: Duplicate TestRSKilledWhenInitializing is currently ignored, see HBASE-19515. > TestRSKilledWhenInitializing is flakey > -- > > Key: HBASE-15002 > URL: https://issues.apache.org/jira/browse/HBASE-15002 > Project: HBase > Issue Type: Sub-task > Components: flakey, test >Reporter: stack >Priority: Major > > https://builds.apache.org/view/H-L/view/HBase/job/HBase-1.2/449/jdk=latest1.8,label=Hadoop/testReport/junit/org.apache.hadoop.hbase.regionserver/TestRSKilledWhenInitializing/testRSTermnationAfterRegisteringToMasterBeforeCreatingEphemeralNod/history/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-15024) TestChoreService is flakey
[ https://issues.apache.org/jira/browse/HBASE-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros resolved HBASE-15024. - Resolution: Cannot Reproduce TestChoreService is not flaky currently. > TestChoreService is flakey > -- > > Key: HBASE-15024 > URL: https://issues.apache.org/jira/browse/HBASE-15024 > Project: HBase > Issue Type: Sub-task > Components: flakey, test >Reporter: stack >Priority: Critical > > https://builds.apache.org/job/HBase-Trunk_matrix/jdk=latest1.8,label=Hadoop/lastCompletedBuild/testReport/org.apache.hadoop.hbase/TestChoreService/testShutdownRejectsNewSchedules/history/ > Fails a bunch lately -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-15307) TestFailedAppendAndSync.testLockupAroundBadAssignSync is flakey
[
https://issues.apache.org/jira/browse/HBASE-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros resolved HBASE-15307.
-
Resolution: Won't Fix
This unit test does not exist anymore.
> TestFailedAppendAndSync.testLockupAroundBadAssignSync is flakey
> ---
>
> Key: HBASE-15307
> URL: https://issues.apache.org/jira/browse/HBASE-15307
> Project: HBase
> Issue Type: Sub-task
> Components: flakey, test
>Reporter: stack
>Assignee: stack
>Priority: Critical
>
> {code}
> Error Message
> test timed out after 30 milliseconds
> Stacktrace
> org.junit.runners.model.TestTimedOutException: test timed out after 30
> milliseconds
> at java.lang.Thread.sleep(Native Method)
> at org.apache.hadoop.hbase.util.Threads.sleep(Threads.java:148)
> at
> org.apache.hadoop.hbase.regionserver.TestFailedAppendAndSync.testLockupAroundBadAssignSync(TestFailedAppendAndSync.java:242)
> Standard Output
> 2016-02-22 18:14:09,154 INFO [main] hbase.ResourceChecker(148): before:
> regionserver.TestFailedAppendAndSync#testLockupAroundBadAssignSync Thread=4,
> OpenFileDescriptor=206, MaxFileDescriptor=6, SystemLoadAverage=1043,
> ProcessCount=300, AvailableMemoryMB=1709
> 2016-02-22 18:14:09,809 DEBUG [main] hbase.HBaseTestingUtility(338): Setting
> hbase.rootdir to
> /home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/latest1.8/label/yahoo-not-h2/hbase-server/target/test-data/892bb23a-6932-4631-b4e0-a6384423d533
> 2016-02-22 18:14:10,167 WARN [Time-limited test] util.NativeCodeLoader(62):
> Unable to load native-hadoop library for your platform... using builtin-java
> classes where applicable
> 2016-02-22 18:14:10,452 INFO [Time-limited test] wal.FSHLog(527): WAL
> configuration: blocksize=32 MB, rollsize=30.40 MB, prefix=wal, suffix=,
> logDir=/home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/latest1.8/label/yahoo-not-h2/hbase-server/target/test-data/892bb23a-6932-4631-b4e0-a6384423d533/TestHRegiontestLockupAroundBadAssignSync/testLockupAroundBadAssignSync,
>
> archiveDir=/home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/latest1.8/label/yahoo-not-h2/hbase-server/target/test-data/892bb23a-6932-4631-b4e0-a6384423d533/TestHRegiontestLockupAroundBadAssignSync/oldWALs
> 2016-02-22 18:14:10,534 INFO [Time-limited test] wal.FSHLog(874): New WAL
> /home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/latest1.8/label/yahoo-not-h2/hbase-server/target/test-data/892bb23a-6932-4631-b4e0-a6384423d533/TestHRegiontestLockupAroundBadAssignSync/testLockupAroundBadAssignSync/wal.1456164850475
> 2016-02-22 18:14:10,673 INFO [Time-limited test] regionserver.HRegion(6118):
> creating HRegion testLockupAroundBadAssignSync HTD ==
> 'testLockupAroundBadAssignSync', {TABLE_ATTRIBUTES => {DURABILITY =>
> 'SYNC_WAL', READONLY => 'false'}, {NAME => 'MyCF', BLOOMFILTER => 'ROW',
> VERSIONS => '2147483647', IN_MEMORY => 'false', KEEP_DELETED_CELLS =>
> 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', COMPRESSION =>
> 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536',
> REPLICATION_SCOPE => '0'} RootDir =
> /home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/latest1.8/label/yahoo-not-h2/hbase-server/target/test-data/892bb23a-6932-4631-b4e0-a6384423d533
> Table name == testLockupAroundBadAssignSync
> 2016-02-22 18:14:10,950 DEBUG [Time-limited test] regionserver.HRegion(718):
> Instantiated
> testLockupAroundBadAssignSync,,1456164850613.7eee51a40e497870a49a2965af62a054.
> 2016-02-22 18:14:11,253 INFO
> [StoreOpener-7eee51a40e497870a49a2965af62a054-1] hfile.CacheConfig(292):
> CacheConfig:disabled
> 2016-02-22 18:14:11,265 INFO
> [StoreOpener-7eee51a40e497870a49a2965af62a054-1]
> compactions.CompactionConfiguration(107): size [134217728,
> 9223372036854775807, 9223372036854775807); files [3, 10); ratio 1.20;
> off-peak ratio 5.00; throttle point 2684354560; major period 60480,
> major jitter 0.50, min locality to compact 0.00
> 2016-02-22 18:14:11,269 DEBUG
> [StoreOpener-7eee51a40e497870a49a2965af62a054-1]
> regionserver.HRegionFileSystem(202): No StoreFiles for:
> /home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/latest1.8/label/yahoo-not-h2/hbase-server/target/test-data/892bb23a-6932-4631-b4e0-a6384423d533/data/default/testLockupAroundBadAssignSync/7eee51a40e497870a49a2965af62a054/MyCF
> 2016-02-22 18:14:11,303 DEBUG [Time-limited test] regionserver.HRegion(3838):
> Found 0 recovered edits file(s) under
> /home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/latest1.8/label/yahoo-not-h2/hbase-server/target/test-data/892bb23a-6932-4631-b4e0-a6384423d533/data/default/testLockupAroundBadAssignSync/7eee51a40e497870a49a2965af62a054
> 2016-02-22
[jira] [Resolved] (HBASE-15262) TestZooKeeperMainServer#testCommandLineWorks fails with CancelledKeyException
[
https://issues.apache.org/jira/browse/HBASE-15262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros resolved HBASE-15262.
-
Resolution: Won't Fix
Release Note: This unit test does not exist anymore.
> TestZooKeeperMainServer#testCommandLineWorks fails with CancelledKeyException
> -
>
> Key: HBASE-15262
> URL: https://issues.apache.org/jira/browse/HBASE-15262
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Priority: Major
>
> {code}
> 2016-02-11 11:34:50,418 ERROR [SyncThread:0] server.NIOServerCnxn(178):
> Unexpected Exception:
> java.nio.channels.CancelledKeyException
> at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:73)
> at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:77)
> at
> org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:151)
> at
> org.apache.zookeeper.server.ZooKeeperServer.finishSessionInit(ZooKeeperServer.java:607)
> at
> org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:181)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:200)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:131)
> [code}
> The test is expecting zk to do a System.exit but an existing zk or previous
> test is getting us this CancelledKeyException...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20563) Use parameterized logging in hbase-common
[ https://issues.apache.org/jira/browse/HBASE-20563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20563: Fix Version/s: 3.0.0 Status: Patch Available (was: Open) > Use parameterized logging in hbase-common > - > > Key: HBASE-20563 > URL: https://issues.apache.org/jira/browse/HBASE-20563 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20563.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20563) Use parameterized logging in hbase-common
[ https://issues.apache.org/jira/browse/HBASE-20563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20563: Attachment: HBASE-20563.master.001.patch > Use parameterized logging in hbase-common > - > > Key: HBASE-20563 > URL: https://issues.apache.org/jira/browse/HBASE-20563 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20563.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-20562) [UMBRELLA] Use parameterized logging
Balazs Meszaros created HBASE-20562:
---
Summary: [UMBRELLA] Use parameterized logging
Key: HBASE-20562
URL: https://issues.apache.org/jira/browse/HBASE-20562
Project: HBase
Issue Type: Umbrella
Affects Versions: 3.0.0
Reporter: Balazs Meszaros
We should use parameterized log message feature of slf4j/logback. (Use {}
instead of string concatenation.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-20563) Use parameterized logging in hbase-common
Balazs Meszaros created HBASE-20563: --- Summary: Use parameterized logging in hbase-common Key: HBASE-20563 URL: https://issues.apache.org/jira/browse/HBASE-20563 Project: HBase Issue Type: Sub-task Affects Versions: 3.0.0 Reporter: Balazs Meszaros Assignee: Balazs Meszaros -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20549) Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
[
https://issues.apache.org/jira/browse/HBASE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20549:
Description:
I'm studying flushing and blocking memstores. I came across the MBean
Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
metrics on blocked flush time, etc. See below. All metrics are zero. I tried to
get it going. It is connected to the heap tuner facitlity that we might want to
turn on. I managed to get the latter going w/ below configs (need to dump
out more on what this thing is doing because it is tricky enabling it)
{code:java}
hbase.regionserver.global.memstore.size.min.range
0.39
hbase.regionserver.global.memstore.size.max.range
0.41
hfile.block.cache.size.max.range
0.41
hfile.block.cache.size.min.range
0.39
{code}
... but still the metrics are not updated.
We should make this bean work whether tuning is on or off or remove it.
!Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
was:
I'm studying flushing and blocking memstores. I came across the MBean
Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
metrics on blocked flush time, etc. See below. All metrics are zero. I tried to
get it going. It is connected to the heap tuner facitlity that we might want to
turn on. I managed to get the latter going w/ below configs (need to dump
out more on what this thing is doing because it is tricky enabling it)
{code}
hbase.regionserver.global.memstore.size.min.range
0.39
hbase.regionserver.global.memstore.size.max.range
0.41
hfile.block.cache.size.max.range
0.41
hfile.block.cache.size.min.range
0.39
{code}
... but still the metrics are not updated.
We should make this bean work whether tuning is on or off or remove it.
!Screen Shot 2018-05-08 at 10.05.57 PM.png!
> Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
> -
>
> Key: HBASE-20549
> URL: https://issues.apache.org/jira/browse/HBASE-20549
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Priority: Major
> Attachments: Screen Shot 2018-05-08 at 10.05.57 PM.png
>
>
> I'm studying flushing and blocking memstores. I came across the MBean
> Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
> metrics on blocked flush time, etc. See below. All metrics are zero. I tried
> to get it going. It is connected to the heap tuner facitlity that we might
> want to turn on. I managed to get the latter going w/ below configs (need
> to dump out more on what this thing is doing because it is tricky enabling it)
> {code:java}
>
>
>
> hbase.regionserver.global.memstore.size.min.range
>
> 0.39
>
>
>
> hbase.regionserver.global.memstore.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.min.range
>
> 0.39
>
>
> {code}
> ... but still the metrics are not updated.
> We should make this bean work whether tuning is on or off or remove it.
> !Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work started] (HBASE-20549) Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
[
https://issues.apache.org/jira/browse/HBASE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-20549 started by Balazs Meszaros.
---
> Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
> -
>
> Key: HBASE-20549
> URL: https://issues.apache.org/jira/browse/HBASE-20549
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Attachments: Screen Shot 2018-05-08 at 10.05.57 PM.png
>
>
> I'm studying flushing and blocking memstores. I came across the MBean
> Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
> metrics on blocked flush time, etc. See below. All metrics are zero. I tried
> to get it going. It is connected to the heap tuner facitlity that we might
> want to turn on. I managed to get the latter going w/ below configs (need
> to dump out more on what this thing is doing because it is tricky enabling it)
> {code:java}
>
>
>
> hbase.regionserver.global.memstore.size.min.range
>
> 0.39
>
>
>
> hbase.regionserver.global.memstore.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.min.range
>
> 0.39
>
>
> {code}
> ... but still the metrics are not updated.
> We should make this bean work whether tuning is on or off or remove it.
> !Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-20549) Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
[
https://issues.apache.org/jira/browse/HBASE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros reassigned HBASE-20549:
---
Assignee: Balazs Meszaros
> Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
> -
>
> Key: HBASE-20549
> URL: https://issues.apache.org/jira/browse/HBASE-20549
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Attachments: Screen Shot 2018-05-08 at 10.05.57 PM.png
>
>
> I'm studying flushing and blocking memstores. I came across the MBean
> Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
> metrics on blocked flush time, etc. See below. All metrics are zero. I tried
> to get it going. It is connected to the heap tuner facitlity that we might
> want to turn on. I managed to get the latter going w/ below configs (need
> to dump out more on what this thing is doing because it is tricky enabling it)
> {code:java}
>
>
>
> hbase.regionserver.global.memstore.size.min.range
>
> 0.39
>
>
>
> hbase.regionserver.global.memstore.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.min.range
>
> 0.39
>
>
> {code}
> ... but still the metrics are not updated.
> We should make this bean work whether tuning is on or off or remove it.
> !Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
Balazs Meszaros created HBASE-20571:
---
Summary: JMXJsonServlet generates invalid JSON if it has NaN in
metrics
Key: HBASE-20571
URL: https://issues.apache.org/jira/browse/HBASE-20571
Project: HBase
Issue Type: Bug
Components: UI
Reporter: Balazs Meszaros
Assignee: Balazs Meszaros
{{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
{code}
"l1CacheHitCount" : 0,
"l1CacheMissCount" : 0,
"l1CacheHitRatio" : NaN,
"l1CacheMissRatio" : NaN,
"l2CacheHitCount" : 0,
"l2CacheMissCount" : 0,
"l2CacheHitRatio" : 0.0,
"l2CacheMissRatio" : 0.0,
{code}
NaN is an invalid character sequence in JSON. We should not response NaN in
metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20571:
Attachment: HBASE-20571.branch-2.0.001.patch
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Attachments: HBASE-20571.branch-2.0.001.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20571:
Fix Version/s: 2.0.1
Status: Patch Available (was: Open)
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 2.0.1
>
> Attachments: HBASE-20571.branch-2.0.001.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20571:
Attachment: HBASE-20571.branch-1.004.patch
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0, 2.0.1, 1.4.5
>
> Attachments: HBASE-20571.branch-1.003.patch,
> HBASE-20571.branch-1.004.patch, HBASE-20571.branch-2.0.001.patch,
> HBASE-20571.branch-2.0.002.patch, HBASE-20571.branch-2.0.002.patch,
> HBASE-20571.branch-2.0.003.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20571:
Fix Version/s: 1.4.5
3.0.0
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0, 2.0.1, 1.4.5
>
> Attachments: HBASE-20571.branch-2.0.001.patch,
> HBASE-20571.branch-2.0.002.patch, HBASE-20571.branch-2.0.002.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20571:
Attachment: HBASE-20571.branch-1.003.patch
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0, 2.0.1, 1.4.5
>
> Attachments: HBASE-20571.branch-1.003.patch,
> HBASE-20571.branch-2.0.001.patch, HBASE-20571.branch-2.0.002.patch,
> HBASE-20571.branch-2.0.002.patch, HBASE-20571.branch-2.0.003.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20571:
Attachment: (was: HBASE-20571.branch-1.003.patch)
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0, 2.0.1, 1.4.5
>
> Attachments: HBASE-20571.branch-2.0.001.patch,
> HBASE-20571.branch-2.0.002.patch, HBASE-20571.branch-2.0.002.patch,
> HBASE-20571.branch-2.0.003.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477319#comment-16477319
]
Balazs Meszaros commented on HBASE-20571:
-
I uploaded a more general solution, where JSONBean class serializes special
floating point values as "NaN", "Infinity" or "-Infinity".
[~apurtell] yes, it also affects branch-1, patch is there.
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0, 2.0.1, 1.4.5
>
> Attachments: HBASE-20571.branch-1.003.patch,
> HBASE-20571.branch-2.0.001.patch, HBASE-20571.branch-2.0.002.patch,
> HBASE-20571.branch-2.0.002.patch, HBASE-20571.branch-2.0.003.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20571) JMXJsonServlet generates invalid JSON if it has NaN in metrics
[
https://issues.apache.org/jira/browse/HBASE-20571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20571:
Attachment: HBASE-20571.branch-2.0.003.patch
HBASE-20571.branch-1.003.patch
> JMXJsonServlet generates invalid JSON if it has NaN in metrics
> --
>
> Key: HBASE-20571
> URL: https://issues.apache.org/jira/browse/HBASE-20571
> Project: HBase
> Issue Type: Bug
> Components: UI
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0, 2.0.1, 1.4.5
>
> Attachments: HBASE-20571.branch-1.003.patch,
> HBASE-20571.branch-2.0.001.patch, HBASE-20571.branch-2.0.002.patch,
> HBASE-20571.branch-2.0.002.patch, HBASE-20571.branch-2.0.003.patch
>
>
> {{/jmx}} servlet responses invalid JSON, if some metrics are NaN:
> {code}
> "l1CacheHitCount" : 0,
> "l1CacheMissCount" : 0,
> "l1CacheHitRatio" : NaN,
> "l1CacheMissRatio" : NaN,
> "l2CacheHitCount" : 0,
> "l2CacheMissCount" : 0,
> "l2CacheHitRatio" : 0.0,
> "l2CacheMissRatio" : 0.0,
> {code}
> NaN is an invalid character sequence in JSON. We should not response NaN in
> metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20581) HBase book documentation wrong for REST operations on schema endpoints
[
https://issues.apache.org/jira/browse/HBASE-20581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475481#comment-16475481
]
Balazs Meszaros commented on HBASE-20581:
-
+1 ship it!
> HBase book documentation wrong for REST operations on schema endpoints
> --
>
> Key: HBASE-20581
> URL: https://issues.apache.org/jira/browse/HBASE-20581
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Kevin Risden
>Assignee: Josh Elser
>Priority: Critical
> Attachments: HBASE-20581.001.patch
>
>
> On [https://hbase.apache.org/book.html#_using_rest_endpoints]
> The documentation states that to update a table schema (the configuration for
> a column family), the {{PUT}} HTTP verb will update the current configuration
> with the "fragment" of configuration provided, while the {{POST}} HTTP verb
> will replace the current configuration with whatever is provided.
> In reality, the opposite is true: {{POST}} updates the configuration, {{PUT}}
> replaces. The old javadoc for the o.a.h.h.rest package got it right, but the
> entry on the HBase book transposed this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.007.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch, HBASE-20656.master.003.patch, > HBASE-20656.master.004.patch, HBASE-20656.master.005.patch, > HBASE-20656.master.006.patch, HBASE-20656.master.007.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505863#comment-16505863 ] Balazs Meszaros commented on HBASE-20656: - [~mdrob] sure, corrected it. > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch, HBASE-20656.master.003.patch, > HBASE-20656.master.004.patch, HBASE-20656.master.005.patch, > HBASE-20656.master.006.patch, HBASE-20656.master.007.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.008.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch, HBASE-20656.master.003.patch, > HBASE-20656.master.004.patch, HBASE-20656.master.005.patch, > HBASE-20656.master.006.patch, HBASE-20656.master.007.patch, > HBASE-20656.master.008.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507783#comment-16507783 ] Balazs Meszaros commented on HBASE-20656: - Indentation is fixed now. > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch, HBASE-20656.master.003.patch, > HBASE-20656.master.004.patch, HBASE-20656.master.005.patch, > HBASE-20656.master.006.patch, HBASE-20656.master.007.patch, > HBASE-20656.master.008.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492790#comment-16492790 ] Balazs Meszaros commented on HBASE-20656: - The package of WALEdit for example was changed in 2.0, so if we want to check these kind of incompatibilities, we have to create an 1.x coprocessor somehow: - write a coprocessor which depends on our 1.x source tree. It would be possible if we created a new module in our source, but it would introduce other building issues. - generate programatically the class file, which requires a byte code manipulation library, - add it as binary into our source tree (that's what I did), - do not check the tool at all :) I do not know if we have any other choices. > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.004.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch, HBASE-20656.master.003.patch, > HBASE-20656.master.004.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.003.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch, HBASE-20656.master.003.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.002.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493422#comment-16493422 ] Balazs Meszaros commented on HBASE-20656: - [~mdrob] sorry, I don't understand it. The package of WALEdit has been changed. How can I write a code, which depends on the old package? I solved it by adding a jar, another solution would be byte-code generation. I have no other idea. > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493422#comment-16493422 ] Balazs Meszaros edited comment on HBASE-20656 at 5/29/18 11:36 AM: --- [~mdrob] sorry, I don't understand it. The package of WALEdit has been changed. How can I write a code, which depends on the old package? I solved it by adding a jar, another solution would be byte-code generation. I have no other idea. (I will fix the build issues later.) was (Author: balazs.meszaros): [~mdrob] sorry, I don't understand it. The package of WALEdit has been changed. How can I write a code, which depends on the old package? I solved it by adding a jar, another solution would be byte-code generation. I have no other idea. > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.005.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch, HBASE-20656.master.003.patch, > HBASE-20656.master.004.patch, HBASE-20656.master.005.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.006.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch, > HBASE-20656.master.002.patch, HBASE-20656.master.003.patch, > HBASE-20656.master.004.patch, HBASE-20656.master.005.patch, > HBASE-20656.master.006.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
Balazs Meszaros created HBASE-20656: --- Summary: Validate pre-2.0 coprocessors against HBase 2.0+ Key: HBASE-20656 URL: https://issues.apache.org/jira/browse/HBASE-20656 Project: HBase Issue Type: New Feature Components: tooling Affects Versions: 3.0.0 Reporter: Balazs Meszaros Assignee: Balazs Meszaros We have co-processors for a while, but the API has been changed recently. We should give some tooling for our users to determine if they can use the previous co-processors safely or not. The tool should: - try to load the co-processors on our current classpath for ensuring class references are on our classpath, - should check for previously removed co-processor methods. In this version we check only method signatures. Code references should be checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.001.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Status: Patch Available (was: Open) > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: (was: HBASE-20656.master.001.patch) > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20656) Validate pre-2.0 coprocessors against HBase 2.0+
[ https://issues.apache.org/jira/browse/HBASE-20656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20656: Attachment: HBASE-20656.master.001.patch > Validate pre-2.0 coprocessors against HBase 2.0+ > > > Key: HBASE-20656 > URL: https://issues.apache.org/jira/browse/HBASE-20656 > Project: HBase > Issue Type: New Feature > Components: tooling >Affects Versions: 3.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-20656.master.001.patch > > > We have co-processors for a while, but the API has been changed recently. We > should give some tooling for our users to determine if they can use the > previous co-processors safely or not. > The tool should: > - try to load the co-processors on our current classpath for ensuring class > references are on our classpath, > - should check for previously removed co-processor methods. > In this version we check only method signatures. Code references should be > checked in further versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-20833) Modify pre-upgrade coprocessor validator to support table level coprocessors
Balazs Meszaros created HBASE-20833: --- Summary: Modify pre-upgrade coprocessor validator to support table level coprocessors Key: HBASE-20833 URL: https://issues.apache.org/jira/browse/HBASE-20833 Project: HBase Issue Type: New Feature Reporter: Balazs Meszaros Assignee: Balazs Meszaros -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros reassigned HBASE-20649: --- Assignee: Balazs Meszaros > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523435#comment-16523435 ] Balazs Meszaros commented on HBASE-20649: - I did a small modification, now it also checks the contents of archive directory. [~busbey] can you take a quick look? > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20649: Attachment: HBASE-20649.master.004.patch > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20833) Modify pre-upgrade coprocessor validator to support table level coprocessors
[ https://issues.apache.org/jira/browse/HBASE-20833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20833: Fix Version/s: 3.0.0 Status: Patch Available (was: Open) > Modify pre-upgrade coprocessor validator to support table level coprocessors > > > Key: HBASE-20833 > URL: https://issues.apache.org/jira/browse/HBASE-20833 > Project: HBase > Issue Type: New Feature >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20833.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20833) Modify pre-upgrade coprocessor validator to support table level coprocessors
[ https://issues.apache.org/jira/browse/HBASE-20833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20833: Attachment: HBASE-20833.master.001.patch > Modify pre-upgrade coprocessor validator to support table level coprocessors > > > Key: HBASE-20833 > URL: https://issues.apache.org/jira/browse/HBASE-20833 > Project: HBase > Issue Type: New Feature >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20833.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20549) Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
[
https://issues.apache.org/jira/browse/HBASE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20549:
Fix Version/s: 3.0.0
Status: Patch Available (was: In Progress)
> Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
> -
>
> Key: HBASE-20549
> URL: https://issues.apache.org/jira/browse/HBASE-20549
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20549.master.001.patch, Screen Shot 2018-05-08 at
> 10.05.57 PM.png
>
>
> I'm studying flushing and blocking memstores. I came across the MBean
> Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
> metrics on blocked flush time, etc. See below. All metrics are zero. I tried
> to get it going. It is connected to the heap tuner facitlity that we might
> want to turn on. I managed to get the latter going w/ below configs (need
> to dump out more on what this thing is doing because it is tricky enabling it)
> {code:java}
>
>
>
> hbase.regionserver.global.memstore.size.min.range
>
> 0.39
>
>
>
> hbase.regionserver.global.memstore.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.min.range
>
> 0.39
>
>
> {code}
> ... but still the metrics are not updated.
> We should make this bean work whether tuning is on or off or remove it.
> !Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20549) Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
[
https://issues.apache.org/jira/browse/HBASE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20549:
Attachment: HBASE-20549.master.001.patch
> Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
> -
>
> Key: HBASE-20549
> URL: https://issues.apache.org/jira/browse/HBASE-20549
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20549.master.001.patch, Screen Shot 2018-05-08 at
> 10.05.57 PM.png
>
>
> I'm studying flushing and blocking memstores. I came across the MBean
> Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
> metrics on blocked flush time, etc. See below. All metrics are zero. I tried
> to get it going. It is connected to the heap tuner facitlity that we might
> want to turn on. I managed to get the latter going w/ below configs (need
> to dump out more on what this thing is doing because it is tricky enabling it)
> {code:java}
>
>
>
> hbase.regionserver.global.memstore.size.min.range
>
> 0.39
>
>
>
> hbase.regionserver.global.memstore.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.min.range
>
> 0.39
>
>
> {code}
> ... but still the metrics are not updated.
> We should make this bean work whether tuning is on or off or remove it.
> !Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20487) Sorting table regions by region name does not work on web UI
[
https://issues.apache.org/jira/browse/HBASE-20487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453725#comment-16453725
]
Balazs Meszaros commented on HBASE-20487:
-
Yes, the sorting works now.
> Sorting table regions by region name does not work on web UI
>
>
> Key: HBASE-20487
> URL: https://issues.apache.org/jira/browse/HBASE-20487
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20487.master.001.patch
>
>
> Table regions on {{table.jsp}} cannot be sorted by Name column.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20549) Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
[
https://issues.apache.org/jira/browse/HBASE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20549:
Attachment: (was: HBASE-20549.master.001.patch)
> Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
> -
>
> Key: HBASE-20549
> URL: https://issues.apache.org/jira/browse/HBASE-20549
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20549.master.001.patch, Screen Shot 2018-05-08 at
> 10.05.57 PM.png
>
>
> I'm studying flushing and blocking memstores. I came across the MBean
> Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
> metrics on blocked flush time, etc. See below. All metrics are zero. I tried
> to get it going. It is connected to the heap tuner facitlity that we might
> want to turn on. I managed to get the latter going w/ below configs (need
> to dump out more on what this thing is doing because it is tricky enabling it)
> {code:java}
>
>
>
> hbase.regionserver.global.memstore.size.min.range
>
> 0.39
>
>
>
> hbase.regionserver.global.memstore.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.min.range
>
> 0.39
>
>
> {code}
> ... but still the metrics are not updated.
> We should make this bean work whether tuning is on or off or remove it.
> !Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20549) Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
[
https://issues.apache.org/jira/browse/HBASE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balazs Meszaros updated HBASE-20549:
Attachment: HBASE-20549.master.001.patch
> Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
> -
>
> Key: HBASE-20549
> URL: https://issues.apache.org/jira/browse/HBASE-20549
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20549.master.001.patch, Screen Shot 2018-05-08 at
> 10.05.57 PM.png
>
>
> I'm studying flushing and blocking memstores. I came across the MBean
> Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
> metrics on blocked flush time, etc. See below. All metrics are zero. I tried
> to get it going. It is connected to the heap tuner facitlity that we might
> want to turn on. I managed to get the latter going w/ below configs (need
> to dump out more on what this thing is doing because it is tricky enabling it)
> {code:java}
>
>
>
> hbase.regionserver.global.memstore.size.min.range
>
> 0.39
>
>
>
> hbase.regionserver.global.memstore.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.min.range
>
> 0.39
>
>
> {code}
> ... but still the metrics are not updated.
> We should make this bean work whether tuning is on or off or remove it.
> !Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20549) Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
[
https://issues.apache.org/jira/browse/HBASE-20549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531336#comment-16531336
]
Balazs Meszaros commented on HBASE-20549:
-
The mentioned BlockedFlushes, UnblockedFlushes, IncreaseBlockSize, ... are
strictly related to the tuner. There isn't any other code which updates those
metrics. The only exception is blockCacheSize and memStoreSize metrics, because
these metrics are independent from the tuner.
> Dead MBean: Hadoop:service=HBase,sub=Memory,name=RegionServer
> -
>
> Key: HBASE-20549
> URL: https://issues.apache.org/jira/browse/HBASE-20549
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20549.master.001.patch, Screen Shot 2018-05-08 at
> 10.05.57 PM.png
>
>
> I'm studying flushing and blocking memstores. I came across the MBean
> Hadoop:service=HBase,sub=Memory,name=RegionServer It looks promising with
> metrics on blocked flush time, etc. See below. All metrics are zero. I tried
> to get it going. It is connected to the heap tuner facitlity that we might
> want to turn on. I managed to get the latter going w/ below configs (need
> to dump out more on what this thing is doing because it is tricky enabling it)
> {code:java}
>
>
>
> hbase.regionserver.global.memstore.size.min.range
>
> 0.39
>
>
>
> hbase.regionserver.global.memstore.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.max.range
>
> 0.41
>
>
>
> hfile.block.cache.size.min.range
>
> 0.39
>
>
> {code}
> ... but still the metrics are not updated.
> We should make this bean work whether tuning is on or off or remove it.
> !Screen Shot 2018-05-08 at 10.05.57 PM.png|width=440,height=692!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19666) TestDefaultCompactSelection test failed
[ https://issues.apache.org/jira/browse/HBASE-19666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309606#comment-16309606 ] Balazs Meszaros commented on HBASE-19666: - Thank you [~chia7712]! > TestDefaultCompactSelection test failed > --- > > Key: HBASE-19666 > URL: https://issues.apache.org/jira/browse/HBASE-19666 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0 >Reporter: Jingyun Tian >Assignee: Balazs Meszaros >Priority: Critical > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19666.v0.patch > > > hadoop.hbase.regionserver.TestDefaultCompactSelection > [ERROR] Failures: > [ERROR] > TestDefaultCompactSelection.testCompactionRatio:74->TestCompactionPolicy.compactEquals:182->TestCompactionPolicy.compactEquals:201 > expected:<[[4, 2, 1]]> but was:<[[]]> > [ERROR] > TestDefaultCompactSelection.testStuckStoreCompaction:145->TestCompactionPolicy.compactEquals:182->TestCompactionPolicy.compactEquals:201 > expected:<[[]30, 30, 30]> but was:<[[99, 30, ]30, 30, 30]> -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19598) Fix TestAssignmentManagerMetrics flaky test
[ https://issues.apache.org/jira/browse/HBASE-19598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19598: Attachment: TestUtil.java > Fix TestAssignmentManagerMetrics flaky test > --- > > Key: HBASE-19598 > URL: https://issues.apache.org/jira/browse/HBASE-19598 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-beta-1 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: TestUtil.java > > > TestAssignmentManagerMetrics fails constantly. After bisecting, it seems that > commit 010012cbcb broke it (HBASE-18946). > The test method runs successfully, but it cannot shut the minicluster down, > and hangs forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19598) Fix TestAssignmentManagerMetrics flaky test
[
https://issues.apache.org/jira/browse/HBASE-19598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327268#comment-16327268
]
Balazs Meszaros commented on HBASE-19598:
-
I wrote the simplest test case which can demonstrate the issue (TestUtil.java
attachment). If we abort a region server, then
{{TEST_UTIL.shutdownMiniCluster()}} hangs forever.
> Fix TestAssignmentManagerMetrics flaky test
> ---
>
> Key: HBASE-19598
> URL: https://issues.apache.org/jira/browse/HBASE-19598
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-1
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>Priority: Major
> Attachments: TestUtil.java
>
>
> TestAssignmentManagerMetrics fails constantly. After bisecting, it seems that
> commit 010012cbcb broke it (HBASE-18946).
> The test method runs successfully, but it cannot shut the minicluster down,
> and hangs forever.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-19767) Master web UI shows negative values for Remaining KVs
[ https://issues.apache.org/jira/browse/HBASE-19767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19767: Attachment: Screen Shot 2018-01-12 at 12.18.41 PM.png It can also show greater than 100% percentages (see screenshot). > Master web UI shows negative values for Remaining KVs > - > > Key: HBASE-19767 > URL: https://issues.apache.org/jira/browse/HBASE-19767 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Jean-Marc Spaggiari > Fix For: 2.0.0-beta-2 > > Attachments: Screen Shot 2018-01-12 at 12.18.41 PM.png > > > In the Master Web UI, under the compaction tab, the Remaining KVs sometimes > shows negative values. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19400) Add missing security hooks for MasterService RPCs
[ https://issues.apache.org/jira/browse/HBASE-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339217#comment-16339217 ] Balazs Meszaros commented on HBASE-19400: - Ok [~appy], you can take it :) > Add missing security hooks for MasterService RPCs > - > > Key: HBASE-19400 > URL: https://issues.apache.org/jira/browse/HBASE-19400 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-beta-1 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-19400.master.001.patch, > HBASE-19400.master.002.patch > > > The following RPC methods do not call the observers, therefore they are not > guarded by AccessController: > - normalize > - setNormalizerRunning > - runCatalogScan > - enableCatalogJanitor > - runCleanerChore > - setCleanerChoreRunning > - execMasterService > - execProcedure > - execProcedureWithRet -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19886) Display maintenance mode in shell, web UI, JMX
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19886: Attachment: HBASE-19886.master.001.patch > Display maintenance mode in shell, web UI, JMX > -- > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI, JMX. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19886) Display maintenance mode in shell, web UI, JMX
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19886: Attachment: (was: HBASE-19886.master.001.patch) > Display maintenance mode in shell, web UI, JMX > -- > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI, JMX. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-19886) Display maintenance mode in shell, web UI, JMX
Balazs Meszaros created HBASE-19886: --- Summary: Display maintenance mode in shell, web UI, JMX Key: HBASE-19886 URL: https://issues.apache.org/jira/browse/HBASE-19886 Project: HBase Issue Type: New Feature Affects Versions: 2.0.0, 3.0.0, 1.4.2 Reporter: Balazs Meszaros Assignee: Balazs Meszaros Maintenance mode was introduced in HBASE-16008. This mode is controlled by hbck. Splitting an balancing is disabled in this mode. It would be useful to present this information to users through shell, web UI, JMX. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19886) Display maintenance mode in shell, web UI, JMX
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19886: Attachment: HBASE-19886.master.001.patch > Display maintenance mode in shell, web UI, JMX > -- > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Attachments: HBASE-19886.master.001.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI, JMX. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19886: Summary: Display maintenance mode in shell, web UI (was: Display maintenance mode in shell, web UI, JMX) > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI, JMX. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349991#comment-16349991 ] Balazs Meszaros edited comment on HBASE-19886 at 2/2/18 8:50 AM: - Thanks [~stack], I removed it from metrics, [~appy] also suggested it. was (Author: balazs.meszaros): Ok, I removed it from metrics. > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch, > HBASE-19886.master.002.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19886: Description: Maintenance mode was introduced in HBASE-16008. This mode is controlled by hbck. Splitting an balancing is disabled in this mode. It would be useful to present this information to users through shell, web UI. (was: Maintenance mode was introduced in HBASE-16008. This mode is controlled by hbck. Splitting an balancing is disabled in this mode. It would be useful to present this information to users through shell, web UI, JMX.) > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349991#comment-16349991 ] Balazs Meszaros commented on HBASE-19886: - Ok, I removed it from metrics. > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch, > HBASE-19886.master.002.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19886) Display maintenance mode in shell, web UI
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19886: Attachment: HBASE-19886.master.002.patch > Display maintenance mode in shell, web UI > - > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch, > HBASE-19886.master.002.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19886) Display maintenance mode in shell, web UI, JMX
[ https://issues.apache.org/jira/browse/HBASE-19886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-19886: Fix Version/s: 1.4.2 3.0.0 2.0.0 Status: Patch Available (was: Open) > Display maintenance mode in shell, web UI, JMX > -- > > Key: HBASE-19886 > URL: https://issues.apache.org/jira/browse/HBASE-19886 > Project: HBase > Issue Type: New Feature >Affects Versions: 2.0.0, 3.0.0, 1.4.2 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0, 3.0.0, 1.4.2 > > Attachments: HBASE-19886.master.001.patch > > > Maintenance mode was introduced in HBASE-16008. This mode is controlled by > hbck. Splitting an balancing is disabled in this mode. It would be useful to > present this information to users through shell, web UI, JMX. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-19854) Add a link to Ref Guide PDF
[ https://issues.apache.org/jira/browse/HBASE-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros resolved HBASE-19854. - Resolution: Won't Fix It is also possible to find it through the search box if I search for "reference guide". I think we can close this. > Add a link to Ref Guide PDF > --- > > Key: HBASE-19854 > URL: https://issues.apache.org/jira/browse/HBASE-19854 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Laxmi Narsimha Rao Oruganti >Priority: Minor > > Many a times, users want to have an offline copy of Ref Guide. Some people > prefer to save HTML, and some people prefer it in PDF format. Hence, Apache > HBase team generates PDF version of document periodically and keeps it > available at: [https://hbase.apache.org/apache_hbase_reference_guide.pdf] > It would be good if a link to this URL is available in the online guide so > that users would become aware that there is a PDF version. Right now, unless > some one explicitly looks for it using Google/Bing search, they would not > know. > > As the PDF URL is fixed for latest documentation, it can be a static href. > However, I don't have any clues about how to make sure to get > "version-relevant" PDF link for archived ref guides. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19598) Fix TestAssignmentManagerMetrics flaky test
[
https://issues.apache.org/jira/browse/HBASE-19598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305465#comment-16305465
]
Balazs Meszaros commented on HBASE-19598:
-
I have identified several problems:
1. The initialization hangs in {{HMaster.waitForMasterActive}}:
{code:java}
protected void waitForMasterActive(){
boolean tablesOnMaster = LoadBalancer.isTablesOnMaster(conf);
while (!(tablesOnMaster && activeMaster) && !isStopped() && !isAborted()) {
sleeper.sleep();
}
}
{code}
TablesOnMaster=false in this test case, so {{HMaster}} thread waits here. It is
called from {{HRegionServer.run}} -> {{preRegistrationInitialization}} ->
{{initializeZooKeeper}}.
2. Nobody calls {{HMaster.stop}}.
When we call {{TEST_UTIL.shutdownMiniCluster}} from the test case, then it
shuts down HBase mini cluster. After some function calls it enters into
{{JVMClusterUtil.shutdown}} and it calls {{HMaster.shutdown}}, which calls
{{ServerManager.shutdownCluster}}, but nobody calls {{HMaster.stop}}. That's
the reason why it hangs.
So how should we properly shut down the mini cluster?
> Fix TestAssignmentManagerMetrics flaky test
> ---
>
> Key: HBASE-19598
> URL: https://issues.apache.org/jira/browse/HBASE-19598
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-1
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>
> TestAssignmentManagerMetrics fails constantly. After bisecting, it seems that
> commit 010012cbcb broke it (HBASE-18946).
> The test method runs successfully, but it cannot shut the minicluster down,
> and hangs forever.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19666) TestDefaultCompactSelection test failed
[
https://issues.apache.org/jira/browse/HBASE-19666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309409#comment-16309409
]
Balazs Meszaros commented on HBASE-19666:
-
+1
I also tried to figure out why it is failed and I also came to the same
resolution ({{hbase.hstore.blockingStoreFiles}} must be set to {{10}}).
But it is enough to modify only {{TestDefaultCompactSelection}} with the
following function:
{code:java}
@Override
protected void config() {
super.config();
this.conf.setLong("hbase.hstore.blockingStoreFiles", 10);
}
{code}
> TestDefaultCompactSelection test failed
> ---
>
> Key: HBASE-19666
> URL: https://issues.apache.org/jira/browse/HBASE-19666
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0
>Reporter: Jingyun Tian
>Assignee: Chia-Ping Tsai
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19666.v0.patch
>
>
> hadoop.hbase.regionserver.TestDefaultCompactSelection
> [ERROR] Failures:
> [ERROR]
> TestDefaultCompactSelection.testCompactionRatio:74->TestCompactionPolicy.compactEquals:182->TestCompactionPolicy.compactEquals:201
> expected:<[[4, 2, 1]]> but was:<[[]]>
> [ERROR]
> TestDefaultCompactSelection.testStuckStoreCompaction:145->TestCompactionPolicy.compactEquals:182->TestCompactionPolicy.compactEquals:201
> expected:<[[]30, 30, 30]> but was:<[[99, 30, ]30, 30, 30]>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-19598) Fix TestAssignmentManagerMetrics flaky test
Balazs Meszaros created HBASE-19598: --- Summary: Fix TestAssignmentManagerMetrics flaky test Key: HBASE-19598 URL: https://issues.apache.org/jira/browse/HBASE-19598 Project: HBase Issue Type: Bug Affects Versions: 2.0.0-beta-1 Reporter: Balazs Meszaros Assignee: Balazs Meszaros TestAssignmentManagerMetrics fails constantly. After bisecting, it seems that commit 010012cbcb broke it (HBASE-18946). The test method runs successfully, but it cannot shut the minicluster down, and hangs forever. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19598) Fix TestAssignmentManagerMetrics flaky test
[
https://issues.apache.org/jira/browse/HBASE-19598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301493#comment-16301493
]
Balazs Meszaros commented on HBASE-19598:
-
[~stack] why was this change?
{code:java}
public void shutdownCluster() {
String statusStr = "Cluster shutdown requested of master=" +
this.master.getServerName();
LOG.info(statusStr);
this.clusterShutdown.set(true);
this.master.stop(statusStr); // <-- THIS LINE WAS REMOVED
}
{code}
If I put it back, the test passes.
> Fix TestAssignmentManagerMetrics flaky test
> ---
>
> Key: HBASE-19598
> URL: https://issues.apache.org/jira/browse/HBASE-19598
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-1
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>
> TestAssignmentManagerMetrics fails constantly. After bisecting, it seems that
> commit 010012cbcb broke it (HBASE-18946).
> The test method runs successfully, but it cannot shut the minicluster down,
> and hangs forever.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19598) Fix TestAssignmentManagerMetrics flaky test
[
https://issues.apache.org/jira/browse/HBASE-19598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301493#comment-16301493
]
Balazs Meszaros edited comment on HBASE-19598 at 12/22/17 2:15 PM:
---
[~stack] why was this change in {{ServerManager}}?
{code:java}
public void shutdownCluster() {
String statusStr = "Cluster shutdown requested of master=" +
this.master.getServerName();
LOG.info(statusStr);
this.clusterShutdown.set(true);
this.master.stop(statusStr); // <-- THIS LINE WAS REMOVED
}
{code}
If I put it back, the test passes.
was (Author: balazs.meszaros):
[~stack] why was this change?
{code:java}
public void shutdownCluster() {
String statusStr = "Cluster shutdown requested of master=" +
this.master.getServerName();
LOG.info(statusStr);
this.clusterShutdown.set(true);
this.master.stop(statusStr); // <-- THIS LINE WAS REMOVED
}
{code}
If I put it back, the test passes.
> Fix TestAssignmentManagerMetrics flaky test
> ---
>
> Key: HBASE-19598
> URL: https://issues.apache.org/jira/browse/HBASE-19598
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-beta-1
>Reporter: Balazs Meszaros
>Assignee: Balazs Meszaros
>
> TestAssignmentManagerMetrics fails constantly. After bisecting, it seems that
> commit 010012cbcb broke it (HBASE-18946).
> The test method runs successfully, but it cannot shut the minicluster down,
> and hangs forever.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20853: Attachment: HBASE-20853.master.004.patch > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch, > HBASE-20853.master.002.patch, HBASE-20853.master.003.patch, > HBASE-20853.master.004.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546613#comment-16546613 ] Balazs Meszaros commented on HBASE-20853: - Thanks [~chia7712], I wrote a safer code. > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch, > HBASE-20853.master.002.patch, HBASE-20853.master.003.patch, > HBASE-20853.master.004.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[
https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547964#comment-16547964
]
Balazs Meszaros commented on HBASE-20853:
-
Let me revert the delete function [~chia7712]. The problem is
{{delete(List)}} does not throw an exception if the row is missing, but
this behavior is not defined for {{delete(Delete)}}.
> Polish "Add defaults to Table Interface so Implementors don't have to"
> --
>
> Key: HBASE-20853
> URL: https://issues.apache.org/jira/browse/HBASE-20853
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Labels: beginner, beginners
> Fix For: 3.0.0, 2.0.2, 2.1.1
>
> Attachments: HBASE-20853.master.001.patch,
> HBASE-20853.master.002.patch, HBASE-20853.master.003.patch,
> HBASE-20853.master.004.patch, HBASE-20853.master.005.patch
>
>
> This issue is to address feedback that came in after commit on the parent
> (FYI [~chia7712]). See tail of parent issue and amendment attached to parent
> adding better defaults to the Table Interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20853: Attachment: HBASE-20853.master.005.patch > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch, > HBASE-20853.master.002.patch, HBASE-20853.master.003.patch, > HBASE-20853.master.004.patch, HBASE-20853.master.005.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[
https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547964#comment-16547964
]
Balazs Meszaros edited comment on HBASE-20853 at 7/18/18 3:23 PM:
--
Let me revert the delete function [~chia7712]. The problem is
{{delete(List)}} does not throw an exception if the row is missing, but
this behavior is not defined for {{delete(Delete)}}.
Other functions seem to be ok.
was (Author: balazs.meszaros):
Let me revert the delete function [~chia7712]. The problem is
{{delete(List)}} does not throw an exception if the row is missing, but
this behavior is not defined for {{delete(Delete)}}.
> Polish "Add defaults to Table Interface so Implementors don't have to"
> --
>
> Key: HBASE-20853
> URL: https://issues.apache.org/jira/browse/HBASE-20853
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Reporter: stack
>Assignee: Balazs Meszaros
>Priority: Major
> Labels: beginner, beginners
> Fix For: 3.0.0, 2.0.2, 2.1.1
>
> Attachments: HBASE-20853.master.001.patch,
> HBASE-20853.master.002.patch, HBASE-20853.master.003.patch,
> HBASE-20853.master.004.patch, HBASE-20853.master.005.patch
>
>
> This issue is to address feedback that came in after commit on the parent
> (FYI [~chia7712]). See tail of parent issue and amendment attached to parent
> adding better defaults to the Table Interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20853: Attachment: HBASE-20853.master.003.patch > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch, > HBASE-20853.master.002.patch, HBASE-20853.master.003.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545238#comment-16545238 ] Balazs Meszaros commented on HBASE-20853: - I added a default implementation for getTableDescriptor. I did not change getName, because it does not throw an exception unlike getDescriptor.. > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch, > HBASE-20853.master.002.patch, HBASE-20853.master.003.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555345#comment-16555345 ] Balazs Meszaros commented on HBASE-20649: - [~busbey], is there anything which is missing from my patch? > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch, HBASE-20649.master.005.patch, > HBASE-20649.master.006.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20833) Modify pre-upgrade coprocessor validator to support table level coprocessors
[ https://issues.apache.org/jira/browse/HBASE-20833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20833: Attachment: HBASE-20833.master.003.patch > Modify pre-upgrade coprocessor validator to support table level coprocessors > > > Key: HBASE-20833 > URL: https://issues.apache.org/jira/browse/HBASE-20833 > Project: HBase > Issue Type: New Feature >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20833.master.001.patch, > HBASE-20833.master.003.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20649: Fix Version/s: 3.0.0 Status: Patch Available (was: In Progress) > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20649: Attachment: (was: HBASE-20649.master.005.patch) > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20649: Attachment: HBASE-20649.master.005.patch > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch, HBASE-20649.master.005.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538429#comment-16538429 ] Balazs Meszaros commented on HBASE-20649: - Thanks for the deep testing [~busbey]. I did a rebase and some concurrency fixes. > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch, HBASE-20649.master.005.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20649: Attachment: HBASE-20649.master.005.patch > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch, HBASE-20649.master.005.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20649: Attachment: (was: HBASE-20649.master.005.patch) > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20649: Attachment: HBASE-20649.master.005.patch > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch, HBASE-20649.master.005.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540251#comment-16540251 ] Balazs Meszaros commented on HBASE-20853: - Ok thanks for the clarification [~chia7712]. I will add an update soon. > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540211#comment-16540211 ] Balazs Meszaros commented on HBASE-20853: - I understand it, but why does your code increment the value of a cell? It seems to be a checkAndDelete. > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20853: Attachment: HBASE-20853.master.001.patch > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros reassigned HBASE-20853: --- Assignee: Balazs Meszaros > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540146#comment-16540146 ] Balazs Meszaros commented on HBASE-20853: - I added the default implementations where I was able to do it. I cannot understand [your comment|https://issues.apache.org/jira/browse/HBASE-20812?focusedCommentId=16528978=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16528978] [~chia7712]. How increment relates to delete? > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20853: Status: Patch Available (was: Open) > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20649: Attachment: HBASE-20649.master.006.patch > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch, HBASE-20649.master.005.patch, > HBASE-20649.master.006.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding
[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542794#comment-16542794 ] Balazs Meszaros commented on HBASE-20649: - I added some extra documentation. > Validate HFiles do not have PREFIX_TREE DataBlockEncoding > - > > Key: HBASE-20649 > URL: https://issues.apache.org/jira/browse/HBASE-20649 > Project: HBase > Issue Type: New Feature >Reporter: Peter Somogyi >Assignee: Balazs Meszaros >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20649.master.001.patch, > HBASE-20649.master.002.patch, HBASE-20649.master.003.patch, > HBASE-20649.master.004.patch, HBASE-20649.master.005.patch, > HBASE-20649.master.006.patch > > > HBASE-20592 adds a tool to check column families on the cluster do not have > PREFIX_TREE encoding. > Since it is possible that DataBlockEncoding was already changed but HFiles > are not rewritten yet we would need a tool that can verify the content of > hfiles in the cluster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20853) Polish "Add defaults to Table Interface so Implementors don't have to"
[ https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-20853: Attachment: HBASE-20853.master.002.patch > Polish "Add defaults to Table Interface so Implementors don't have to" > -- > > Key: HBASE-20853 > URL: https://issues.apache.org/jira/browse/HBASE-20853 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: Balazs Meszaros >Priority: Major > Labels: beginner, beginners > Fix For: 3.0.0, 2.0.2, 2.1.1 > > Attachments: HBASE-20853.master.001.patch, > HBASE-20853.master.002.patch > > > This issue is to address feedback that came in after commit on the parent > (FYI [~chia7712]). See tail of parent issue and amendment attached to parent > adding better defaults to the Table Interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20833) Modify pre-upgrade coprocessor validator to support table level coprocessors
[ https://issues.apache.org/jira/browse/HBASE-20833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536706#comment-16536706 ] Balazs Meszaros commented on HBASE-20833: - Done. > Modify pre-upgrade coprocessor validator to support table level coprocessors > > > Key: HBASE-20833 > URL: https://issues.apache.org/jira/browse/HBASE-20833 > Project: HBase > Issue Type: New Feature >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20833.master.001.patch, > HBASE-20833.master.003.patch, HBASE-20833.master.004.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
