[jira] [Commented] (HIVE-22121) Turning on hive.tez.bucket.pruning produce wrong results
[ https://issues.apache.org/jira/browse/HIVE-22121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914833#comment-16914833 ] Hive QA commented on HIVE-22121: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 14s{color} | {color:blue} ql in master has 2254 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 41s{color} | {color:red} ql: The patch generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 40s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18395/dev-support/hive-personality.sh | | git revision | master / ece9a54 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18395/yetus/diff-checkstyle-ql.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18395/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Turning on hive.tez.bucket.pruning produce wrong results > > > Key: HIVE-22121 > URL: https://issues.apache.org/jira/browse/HIVE-22121 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.0, 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22121.1patch, HIVE-22121.2.patch, HIVE-22121.3.patch > > > *Reproducer* > {code:sql} > set hive.query.results.cache.enabled=false; > set hive.optimize.ppd.storage=true; > set hive.optimize.index.filter=true; > set hive.tez.bucket.pruning=true; > CREATE TABLE `test_table`( >`col_1` int, >`col_2` string, >`col_3` string) > CLUSTERED BY ( >col_1) > INTO 4 BUCKETS; > insert into test_table values(1, 'one', 'ONE'), (2, 'two', 'TWO'), > (3,'three','THREE'),(4,'four','FOUR'); > select * from test_table; > explain select col_1, col_2, col_3 from test_table where col_1 <> 2 order by > col_2; > select col_1, col_2, col_3 from test_table where col_1 <> 2 order by col_2; > {code} > Above sql query produce zero rows. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22140) Metrics: unify codahale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914738#comment-16914738 ] Hive QA commented on HIVE-22140: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12978441/HIVE-22140.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16745 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18394/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18394/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18394/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12978441 - PreCommit-HIVE-Build > Metrics: unify codahale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1minute for metastore (so changing it to 6ms is my proposal) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22140) Metrics: unify codahale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914719#comment-16914719 ] Hive QA commented on HIVE-22140: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 34s{color} | {color:blue} standalone-metastore/metastore-common in master has 32 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 19m 46s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18394/dev-support/hive-personality.sh | | git revision | master / ece9a54 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore/metastore-common U: standalone-metastore/metastore-common | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18394/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Metrics: unify codahale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1minute for metastore (so changing it to 6ms is my proposal) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: >
[jira] [Updated] (HIVE-22074) Slow compilation due to IN to OR transformation
[ https://issues.apache.org/jira/browse/HIVE-22074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vineet Garg updated HIVE-22074: --- Fix Version/s: 4.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master, thanks [~jcamachorodriguez] > Slow compilation due to IN to OR transformation > --- > > Key: HIVE-22074 > URL: https://issues.apache.org/jira/browse/HIVE-22074 > Project: Hive > Issue Type: Improvement > Components: Logical Optimizer >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22074.1.patch, HIVE-22074.2.patch, > HIVE-22074.3.patch, HIVE-22074.4.patch, HIVE-22074.5.patch, HIVE-22074.6.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently Hive transform IN expressions to OR to apply various CBO rules. > This incur significant performance hit if IN consist of large number of > expressions. > It is better to not transform IN expressions to OR in such cases because > overall benefit of various optimizations/transformations is unrealized due to > the compilation overhead -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22121) Turning on hive.tez.bucket.pruning produce wrong results
[ https://issues.apache.org/jira/browse/HIVE-22121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914603#comment-16914603 ] Vineet Garg commented on HIVE-22121: [~gopalv] I have added positive test case. > Turning on hive.tez.bucket.pruning produce wrong results > > > Key: HIVE-22121 > URL: https://issues.apache.org/jira/browse/HIVE-22121 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.0, 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22121.1patch, HIVE-22121.2.patch, HIVE-22121.3.patch > > > *Reproducer* > {code:sql} > set hive.query.results.cache.enabled=false; > set hive.optimize.ppd.storage=true; > set hive.optimize.index.filter=true; > set hive.tez.bucket.pruning=true; > CREATE TABLE `test_table`( >`col_1` int, >`col_2` string, >`col_3` string) > CLUSTERED BY ( >col_1) > INTO 4 BUCKETS; > insert into test_table values(1, 'one', 'ONE'), (2, 'two', 'TWO'), > (3,'three','THREE'),(4,'four','FOUR'); > select * from test_table; > explain select col_1, col_2, col_3 from test_table where col_1 <> 2 order by > col_2; > select col_1, col_2, col_3 from test_table where col_1 <> 2 order by col_2; > {code} > Above sql query produce zero rows. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22121) Turning on hive.tez.bucket.pruning produce wrong results
[ https://issues.apache.org/jira/browse/HIVE-22121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vineet Garg updated HIVE-22121: --- Status: Open (was: Patch Available) > Turning on hive.tez.bucket.pruning produce wrong results > > > Key: HIVE-22121 > URL: https://issues.apache.org/jira/browse/HIVE-22121 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.0, 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22121.1patch, HIVE-22121.2.patch, HIVE-22121.3.patch > > > *Reproducer* > {code:sql} > set hive.query.results.cache.enabled=false; > set hive.optimize.ppd.storage=true; > set hive.optimize.index.filter=true; > set hive.tez.bucket.pruning=true; > CREATE TABLE `test_table`( >`col_1` int, >`col_2` string, >`col_3` string) > CLUSTERED BY ( >col_1) > INTO 4 BUCKETS; > insert into test_table values(1, 'one', 'ONE'), (2, 'two', 'TWO'), > (3,'three','THREE'),(4,'four','FOUR'); > select * from test_table; > explain select col_1, col_2, col_3 from test_table where col_1 <> 2 order by > col_2; > select col_1, col_2, col_3 from test_table where col_1 <> 2 order by col_2; > {code} > Above sql query produce zero rows. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22121) Turning on hive.tez.bucket.pruning produce wrong results
[ https://issues.apache.org/jira/browse/HIVE-22121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vineet Garg updated HIVE-22121: --- Attachment: HIVE-22121.3.patch > Turning on hive.tez.bucket.pruning produce wrong results > > > Key: HIVE-22121 > URL: https://issues.apache.org/jira/browse/HIVE-22121 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.0, 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22121.1patch, HIVE-22121.2.patch, HIVE-22121.3.patch > > > *Reproducer* > {code:sql} > set hive.query.results.cache.enabled=false; > set hive.optimize.ppd.storage=true; > set hive.optimize.index.filter=true; > set hive.tez.bucket.pruning=true; > CREATE TABLE `test_table`( >`col_1` int, >`col_2` string, >`col_3` string) > CLUSTERED BY ( >col_1) > INTO 4 BUCKETS; > insert into test_table values(1, 'one', 'ONE'), (2, 'two', 'TWO'), > (3,'three','THREE'),(4,'four','FOUR'); > select * from test_table; > explain select col_1, col_2, col_3 from test_table where col_1 <> 2 order by > col_2; > select col_1, col_2, col_3 from test_table where col_1 <> 2 order by col_2; > {code} > Above sql query produce zero rows. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22121) Turning on hive.tez.bucket.pruning produce wrong results
[ https://issues.apache.org/jira/browse/HIVE-22121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vineet Garg updated HIVE-22121: --- Status: Patch Available (was: Open) > Turning on hive.tez.bucket.pruning produce wrong results > > > Key: HIVE-22121 > URL: https://issues.apache.org/jira/browse/HIVE-22121 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.0, 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Attachments: HIVE-22121.1patch, HIVE-22121.2.patch, HIVE-22121.3.patch > > > *Reproducer* > {code:sql} > set hive.query.results.cache.enabled=false; > set hive.optimize.ppd.storage=true; > set hive.optimize.index.filter=true; > set hive.tez.bucket.pruning=true; > CREATE TABLE `test_table`( >`col_1` int, >`col_2` string, >`col_3` string) > CLUSTERED BY ( >col_1) > INTO 4 BUCKETS; > insert into test_table values(1, 'one', 'ONE'), (2, 'two', 'TWO'), > (3,'three','THREE'),(4,'four','FOUR'); > select * from test_table; > explain select col_1, col_2, col_3 from test_table where col_1 <> 2 order by > col_2; > select col_1, col_2, col_3 from test_table where col_1 <> 2 order by col_2; > {code} > Above sql query produce zero rows. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22134) Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an application
[ https://issues.apache.org/jira/browse/HIVE-22134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914559#comment-16914559 ] Hive QA commented on HIVE-22134: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12978432/HIVE-22134.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16745 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.TestTxnCommands.testMergeOnTezEdges (batchId=350) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18393/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18393/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18393/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12978432 - PreCommit-HIVE-Build > Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an > application > -- > > Key: HIVE-22134 > URL: https://issues.apache.org/jira/browse/HIVE-22134 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: N Campbell >Assignee: Naveen Gangam >Priority: Major > Attachments: HIVE-22134.patch > > > An application that uses JAX-RS 1.1 can be broken by the Hive 3.1 standalone > JAR. > For example, an application is running in IBM Websphere Liberty Profile > (WLP) which detects the classes packaged in the Apache Hive standalone JAR. > This results in WLP assuming that the application is providing it's > implementation and should not use the default in WLP. > Can the Apache Hive JDBC team confirm why these classes are in the JAR. > Can the Apache Hive JDBC team schedule to remove them if they are not > mandatory. > Can the Apache Hive JDBC team confirm which individual JAR files can be > copied instead of the uber-standalone JAR which would not include these > conflicting classes. > This is the class which triggers the problem if all of the jersey stuff is > deleted the issue will go away > org.glassfish.jersey.server.internal.RuntimeDelegateImpl > {{org.glassfish.jersey.*}} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codahale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Summary: Metrics: unify codahale metric frequency unit between metastore and hiveserver2 (was: Metrics: unify codehale metric frequency unit between metastore and hiveserver2) > Metrics: unify codahale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1minute for metastore (so changing it to 6ms is my proposal) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Attachment: HIVE-22140.01.patch > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1minute for metastore (so changing it to 6ms is my proposal) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22134) Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an application
[ https://issues.apache.org/jira/browse/HIVE-22134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914547#comment-16914547 ] Thejas M Nair commented on HIVE-22134: -- +1 [~ngangam] Can you also please verify that it works with a kerberos enabled cluster ? (more jars are required for kerberos than non-kerberos). > Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an > application > -- > > Key: HIVE-22134 > URL: https://issues.apache.org/jira/browse/HIVE-22134 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: N Campbell >Assignee: Naveen Gangam >Priority: Major > Attachments: HIVE-22134.patch > > > An application that uses JAX-RS 1.1 can be broken by the Hive 3.1 standalone > JAR. > For example, an application is running in IBM Websphere Liberty Profile > (WLP) which detects the classes packaged in the Apache Hive standalone JAR. > This results in WLP assuming that the application is providing it's > implementation and should not use the default in WLP. > Can the Apache Hive JDBC team confirm why these classes are in the JAR. > Can the Apache Hive JDBC team schedule to remove them if they are not > mandatory. > Can the Apache Hive JDBC team confirm which individual JAR files can be > copied instead of the uber-standalone JAR which would not include these > conflicting classes. > This is the class which triggers the problem if all of the jersey stuff is > deleted the issue will go away > org.glassfish.jersey.server.internal.RuntimeDelegateImpl > {{org.glassfish.jersey.*}} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22134) Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an application
[ https://issues.apache.org/jira/browse/HIVE-22134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914538#comment-16914538 ] Hive QA commented on HIVE-22134: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 20s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc xml compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18393/dev-support/hive-personality.sh | | git revision | master / f379447 | | Default Java | 1.8.0_111 | | modules | C: jdbc U: jdbc | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18393/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an > application > -- > > Key: HIVE-22134 > URL: https://issues.apache.org/jira/browse/HIVE-22134 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: N Campbell >Assignee: Naveen Gangam >Priority: Major > Attachments: HIVE-22134.patch > > > An application that uses JAX-RS 1.1 can be broken by the Hive 3.1 standalone > JAR. > For example, an application is running in IBM Websphere Liberty Profile > (WLP) which detects the classes packaged in the Apache Hive standalone JAR. > This results in WLP assuming that the application is providing it's > implementation and should not use the default in WLP. > Can the Apache Hive JDBC team confirm why these classes are in the JAR. > Can the Apache Hive JDBC team schedule to remove them if they are not > mandatory. > Can the Apache Hive JDBC team confirm which individual JAR files can be > copied instead of the uber-standalone JAR which would not include these > conflicting classes. > This is the class which triggers the problem if all of the jersey stuff is > deleted the issue will go away > org.glassfish.jersey.server.internal.RuntimeDelegateImpl > {{org.glassfish.jersey.*}} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22142) Hive grantPrivileges() and revokePrivileges() api doesn't give the owner information in the HivePrivilegeObject sent in it
[ https://issues.apache.org/jira/browse/HIVE-22142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramesh Mani updated HIVE-22142: --- Description: With the Owner informations now available to Ranger, api like grantPrivileges() and revokePrivileges() needs to have the owner information in the HivePrivilegeObject sent in it. Without this Grant or Revoke won't be creating a ranger policy for Owners. > Hive grantPrivileges() and revokePrivileges() api doesn't give the owner > information in the HivePrivilegeObject sent in it > -- > > Key: HIVE-22142 > URL: https://issues.apache.org/jira/browse/HIVE-22142 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Mani >Priority: Critical > > With the Owner informations now available to Ranger, api like > grantPrivileges() and revokePrivileges() needs to have the owner information > in the HivePrivilegeObject sent in it. Without this Grant or Revoke won't be > creating a ranger policy for Owners. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22134) Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an application
[ https://issues.apache.org/jira/browse/HIVE-22134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-22134: - Status: Patch Available (was: Open) Removed glassfish.jersey.* jars from being included in the hive-jdbc-standalone.jar. Also includes a fix for HIVE-22129 to remove MSSQL-JDBC driver classes. > Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an > application > -- > > Key: HIVE-22134 > URL: https://issues.apache.org/jira/browse/HIVE-22134 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: N Campbell >Assignee: Naveen Gangam >Priority: Major > Attachments: HIVE-22134.patch > > > An application that uses JAX-RS 1.1 can be broken by the Hive 3.1 standalone > JAR. > For example, an application is running in IBM Websphere Liberty Profile > (WLP) which detects the classes packaged in the Apache Hive standalone JAR. > This results in WLP assuming that the application is providing it's > implementation and should not use the default in WLP. > Can the Apache Hive JDBC team confirm why these classes are in the JAR. > Can the Apache Hive JDBC team schedule to remove them if they are not > mandatory. > Can the Apache Hive JDBC team confirm which individual JAR files can be > copied instead of the uber-standalone JAR which would not include these > conflicting classes. > This is the class which triggers the problem if all of the jersey stuff is > deleted the issue will go away > org.glassfish.jersey.server.internal.RuntimeDelegateImpl > {{org.glassfish.jersey.*}} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22134) Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an application
[ https://issues.apache.org/jira/browse/HIVE-22134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naveen Gangam updated HIVE-22134: - Attachment: HIVE-22134.patch > Hive 3.1 driver includes org.glassfish.jersey.* which can interfer with an > application > -- > > Key: HIVE-22134 > URL: https://issues.apache.org/jira/browse/HIVE-22134 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: N Campbell >Assignee: Naveen Gangam >Priority: Major > Attachments: HIVE-22134.patch > > > An application that uses JAX-RS 1.1 can be broken by the Hive 3.1 standalone > JAR. > For example, an application is running in IBM Websphere Liberty Profile > (WLP) which detects the classes packaged in the Apache Hive standalone JAR. > This results in WLP assuming that the application is providing it's > implementation and should not use the default in WLP. > Can the Apache Hive JDBC team confirm why these classes are in the JAR. > Can the Apache Hive JDBC team schedule to remove them if they are not > mandatory. > Can the Apache Hive JDBC team confirm which individual JAR files can be > copied instead of the uber-standalone JAR which would not include these > conflicting classes. > This is the class which triggers the problem if all of the jersey stuff is > deleted the issue will go away > org.glassfish.jersey.server.internal.RuntimeDelegateImpl > {{org.glassfish.jersey.*}} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sankar Hariappan updated HIVE-21698: Fix Version/s: 4.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) Committed to master. Thanks [~nareshpr] and [~ShubhamChaurasia] for the contribution! > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21698.1.patch, HIVE-21698.2.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914370#comment-16914370 ] Sankar Hariappan commented on HIVE-21698: - +1, [^HIVE-21698.2.patch] LGTM. > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.2.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914361#comment-16914361 ] Hive QA commented on HIVE-21698: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12978412/HIVE-21698.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16745 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18392/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18392/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18392/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12978412 - PreCommit-HIVE-Build > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.2.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HIVE-22139) Will not pad Decimal numbers with trailing zeros if select from value
[ https://issues.apache.org/jira/browse/HIVE-22139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naresh P R reassigned HIVE-22139: - Assignee: Naresh P R > Will not pad Decimal numbers with trailing zeros if select from value > - > > Key: HIVE-22139 > URL: https://issues.apache.org/jira/browse/HIVE-22139 > Project: Hive > Issue Type: Bug > Components: SQL >Affects Versions: 3.1.1 >Reporter: Yuming Wang >Assignee: Naresh P R >Priority: Major > > How to reproduce: > {code:sql} > hive> SELECT CAST(1 AS decimal(38, 18)); > OK > 1 > Time taken: 0.226 seconds, Fetched: 1 row(s) > hive> CREATE TABLE HIVE_22139 AS SELECT CAST(1 AS decimal(38, 18)) as c; > OK > Time taken: 2.278 seconds > hive> SELECT * FROM HIVE_22139; > OK > 1.00 > Time taken: 0.07 seconds, Fetched: 1 row(s) > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22129) Hive 3.1 standalone JAR includes Microsoft SQL Server JDBC driver
[ https://issues.apache.org/jira/browse/HIVE-22129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914330#comment-16914330 ] David Mollitor commented on HIVE-22129: --- {code} hive-shims -> hive-shims-0.23 -> hadoop-yarn-resourcemanager -> hadoop-yarn-server-common -> mssql-jdbc {code} Now sure why Hive need the entire YARN ResourceManager as a dependency. > Hive 3.1 standalone JAR includes Microsoft SQL Server JDBC driver > - > > Key: HIVE-22129 > URL: https://issues.apache.org/jira/browse/HIVE-22129 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: N Campbell >Assignee: Naveen Gangam >Priority: Major > Attachments: ApacheHive.png > > > The Apache Hive 3.1 JDBC driver, specifically the standalone JAR has included > the Microsoft SQL Server JDBC driver. A mutual customer may be trying to use > their own copy of a Microsoft JDBC driver and the Apache Hive driver. > Potentially the JRE will pick up the code in the Apache Hive driver. > What is it included at all and can it be removed going forward? > !ApacheHive.png! -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914323#comment-16914323 ] Hive QA commented on HIVE-21698: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 12s{color} | {color:blue} ql in master has 2254 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} ql: The patch generated 0 new + 89 unchanged - 3 fixed = 89 total (was 92) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 43s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18392/dev-support/hive-personality.sh | | git revision | master / 9482a0c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18392/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.2.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914293#comment-16914293 ] Hive QA commented on HIVE-22140: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12978393/HIVE-22140.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 16745 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestObjectStore.catalogs (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDatabaseOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDeprecatedConfigIsOverwritten (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropParitionsCleanup (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropPartitionsCacheCrossSession (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSqlErrorMetrics (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testEmptyTrustStoreProps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testMasterKeyOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testMaxEventResponse (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testPartitionOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testQueryCloseOnError (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testRoleOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testTableOps (batchId=232) org.apache.hadoop.hive.metastore.TestObjectStore.testUseSSLProperty (batchId=232) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18391/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18391/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18391/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 14 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12978393 - PreCommit-HIVE-Build > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1minute for metastore (so changing it to 6ms is my proposal) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naresh P R updated HIVE-21698: -- Attachment: HIVE-21698.2.patch > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.2.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Description: Currently, different default value and even different unit are used for json metric file generation frequency (for metastore and hiveserver2), which is confusing, especially in a situation when a metastore config can fall back to a corresponding hive config (metastore.metrics.file.frequency -> hive.service.metrics.file.frequency). I think ms would be appropriate for both of them, without even changing the default 1minute for metastore (so changing it to 6ms is my proposal) hive.service.metrics.file.frequency Hiveserver2: https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java {code:java} HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms", new TimeValidator(TimeUnit.MILLISECONDS), "For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + "the frequency of updating JSON metrics file."), {code} Metastore: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java {code:java} METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, "For json metric reporter, the frequency of updating JSON metrics file."), {code} was: Currently, different default value and even different unit are used for json metric file generation frequency (for metastore and hiveserver2), which is confusing, especially in a situation when a metastore config can fall back to a corresponding hive config (metastore.metrics.file.frequency -> hive.service.metrics.file.frequency). I think ms would be appropriate for both of them, without even changing the default 1m for metastore (so changing it to 6ms) hive.service.metrics.file.frequency Hiveserver2: https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java {code:java} HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms", new TimeValidator(TimeUnit.MILLISECONDS), "For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + "the frequency of updating JSON metrics file."), {code} Metastore: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java {code:java} METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, "For json metric reporter, the frequency of updating JSON metrics file."), {code} > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1minute for metastore (so changing it to 6ms is my proposal) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Fix Version/s: 4.0.0 > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914255#comment-16914255 ] Hive QA commented on HIVE-22140: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 31s{color} | {color:blue} standalone-metastore/metastore-common in master has 32 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 19m 30s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18391/dev-support/hive-personality.sh | | git revision | master / 9482a0c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore/metastore-common U: standalone-metastore/metastore-common | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18391/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Attachments: HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: >
[jira] [Commented] (HIVE-22099) Several date related UDFs can't handle Julian dates properly since HIVE-20007
[ https://issues.apache.org/jira/browse/HIVE-22099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914204#comment-16914204 ] Karen Coppage commented on HIVE-22099: -- [~szita] [~jcamachorodriguez] what do you think about changing these UDFs as well? * from_unixtime (UDFFromUnixTime.java) * to_unix_timestamp (GenericUDFToUnixTimeStamp.java) > Several date related UDFs can't handle Julian dates properly since HIVE-20007 > - > > Key: HIVE-22099 > URL: https://issues.apache.org/jira/browse/HIVE-22099 > Project: Hive > Issue Type: Bug >Reporter: Adam Szita >Assignee: Adam Szita >Priority: Major > Attachments: HIVE-22099.0.patch, HIVE-22099.1.patch, > HIVE-22099.2.patch, HIVE-22099.3.patch, HIVE-22099.4.patch, HIVE-22099.5.patch > > > Currently dates that belong to Julian calendar (before Oct 15, 1582) are > handled improperly by date/timestamp UDFs. > E.g. DateFormat UDF: > Although the dates are in Julian calendar, the formatter insists to print > these according to Gregorian calendar causing multiple days of difference in > some cases: > > {code:java} > beeline> select date_format('1001-01-05','dd---MM--'); > ++ > | _c0 | > ++ > | 30---12--1000 | > ++{code} > I've observed similar problems in the following UDFs: > * add_months > * date_format > * day > * month > * months_between > * weekofyear > * year > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Description: Currently, different default value and even different unit are used for json metric file generation frequency (for metastore and hiveserver2), which is confusing, especially in a situation when a metastore config can fall back to a corresponding hive config (metastore.metrics.file.frequency -> hive.service.metrics.file.frequency). I think ms would be appropriate for both of them, without even changing the default 1m for metastore (so changing it to 6ms) hive.service.metrics.file.frequency Hiveserver2: https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java {code:java} HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms", new TimeValidator(TimeUnit.MILLISECONDS), "For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + "the frequency of updating JSON metrics file."), {code} Metastore: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java {code:java} METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, "For json metric reporter, the frequency of updating JSON metrics file."), {code} was: Currently, different default value and even different unit are used for json metric file generation frequency (for metastore and hiveserver2), which is confusing, especially in a situation when a metastore config can fall back to a corresponding hive config. I think ms would be appropriate for both of them, without even changing the default 1m for metastore (so changing it to 6ms) hive.service.metrics.file.frequency Hiveserver2: https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java {code:java} HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms", new TimeValidator(TimeUnit.MILLISECONDS), "For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + "the frequency of updating JSON metrics file."), {code} Metastore: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java {code:java} METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, "For json metric reporter, the frequency of updating JSON metrics file."), {code} > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Attachments: HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config (metastore.metrics.file.frequency -> > hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914185#comment-16914185 ] Laszlo Bodor commented on HIVE-22140: - could you please review [~alangates]? small patch > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Attachments: HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config. > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Status: Patch Available (was: Open) > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Attachments: HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config. > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Attachment: HIVE-22140.01.patch > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > Attachments: HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config. > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-21828) Tez: Use a pre-parsed TezConfiguration from DagUtils
[ https://issues.apache.org/jira/browse/HIVE-21828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Magyar updated HIVE-21828: - Resolution: Fixed Status: Resolved (was: Patch Available) > Tez: Use a pre-parsed TezConfiguration from DagUtils > > > Key: HIVE-21828 > URL: https://issues.apache.org/jira/browse/HIVE-21828 > Project: Hive > Issue Type: Bug >Reporter: Gopal V >Assignee: Attila Magyar >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21828.1.patch, HIVE-21828.2.patch, > HIVE-21828.5.patch, HIVE-21828.6.patch, HIVE-21828.7.patch, > HIVE-21828.8.patch, HIVE-21828.9.patch > > > The HS2 tez-site.xml does not change dynamically - the XML parsed components > of the config can be obtained statically and kept across sessions. > This allows for the replacing of "new TezConfiguration()" with a HS2 local > version instead. > The configuration object however has to reference the right resource file > (i.e location of tez-site.xml) without reparsing it for each query. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Summary: Metrics: unify codehale metric frequency unit between metastore and hiveserver2 (was: Metrics: unify codehale metric frequency unit and default between metastore and hiveserver2) > Metrics: unify codehale metric frequency unit between metastore and > hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config. > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit and default between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Description: Currently, different default value and even different unit are used for json metric file generation frequency (for metastore and hiveserver2), which is confusing, especially in a situation when a metastore config can fall back to a corresponding hive config. I think ms would be appropriate for both of them, without even changing the default 1m for metastore (so changing it to 6ms) hive.service.metrics.file.frequency Hiveserver2: https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java {code:java} HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms", new TimeValidator(TimeUnit.MILLISECONDS), "For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + "the frequency of updating JSON metrics file."), {code} Metastore: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java {code:java} METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, "For json metric reporter, the frequency of updating JSON metrics file."), {code} was: Currently, different default value and even different unit are used for json metric file generation frequency, which is confusing, especially in a situation when a metastore config can fall back to hive a corresponding hive config. I think ms would be appropriate for both of them, without even changing the default 1m for metastore (so changing it to 6ms) Hiveserver2: https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java {code:java} HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms", new TimeValidator(TimeUnit.MILLISECONDS), "For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + "the frequency of updating JSON metrics file."), {code} Metastore: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java {code:java} METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, "For json metric reporter, the frequency of updating JSON metrics file."), {code} > Metrics: unify codehale metric frequency unit and default between metastore > and hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Priority: Major > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config. > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HIVE-22140) Metrics: unify codehale metric frequency unit and default between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor reassigned HIVE-22140: --- Assignee: Laszlo Bodor > Metrics: unify codehale metric frequency unit and default between metastore > and hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Assignee: Laszlo Bodor >Priority: Major > > Currently, different default value and even different unit are used for json > metric file generation frequency (for metastore and hiveserver2), which is > confusing, especially in a situation when a metastore config can fall back to > a corresponding hive config. > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit and default between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Description: Currently, different default value and even different unit are used for json metric file generation frequency, which is confusing, especially in a situation when a metastore config can fall back to hive a corresponding hive config. I think ms would be appropriate for both of them, without even changing the default 1m for metastore (so changing it to 6ms) Hiveserver2: https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java {code:java} HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms", new TimeValidator(TimeUnit.MILLISECONDS), "For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + "the frequency of updating JSON metrics file."), {code} Metastore: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java {code:java} METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, "For json metric reporter, the frequency of updating JSON metrics file."), {code} was: Currently different default and even different unit is used for json metric file generation frequency, which is confusing. For > Metrics: unify codehale metric frequency unit and default between metastore > and hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Priority: Major > > Currently, different default value and even different unit are used for json > metric file generation frequency, which is confusing, especially in a > situation when a metastore config can fall back to hive a corresponding hive > config. > I think ms would be appropriate for both of them, without even changing the > default 1m for metastore (so changing it to 6ms) > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", > "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class > org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics > file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit and default between metastore and hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Summary: Metrics: unify codehale metric frequency unit and default between metastore and hiveserver2 (was: Metrics: unify codehale metric frequency unit and default) > Metrics: unify codehale metric frequency unit and default between metastore > and hiveserver2 > --- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Priority: Major > > Currently different default and even different unit is used for json metric > file generation frequency, which is confusing. > For -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HIVE-22140) Metrics: unify codehale metric frequency unit and default
[ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: Description: Currently different default and even different unit is used for json metric file generation frequency, which is confusing. For > Metrics: unify codehale metric frequency unit and default > - > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Laszlo Bodor >Priority: Major > > Currently different default and even different unit is used for json metric > file generation frequency, which is confusing. > For -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914109#comment-16914109 ] Sankar Hariappan commented on HIVE-21698: - [~nareshpr] DAGUtils.localizeTempFiles can return null. But the caller TezSessionState.ensureLocalResources doesn't validate it before using it. Please add the check. > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper and anonymize passwords before logging
[ https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914090#comment-16914090 ] Hive QA commented on HIVE-15931: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12859257/HIVE-15931.5.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18390/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18390/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18390/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-08-23 09:36:55.559 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-18390/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-08-23 09:36:55.562 + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive db59ec6..9482a0c master -> origin/master + git reset --hard HEAD HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded. (use "git pull" to update your local branch) + git reset --hard origin/master HEAD is now at 9482a0c HIVE-21828: Tez: Use a pre-parsed TezConfiguration from DagUtils - Addendum2 (Attila Magyar via Gopal V) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-08-23 09:36:56.968 + rm -rf ../yetus_PreCommit-HIVE-Build-18390 + mkdir ../yetus_PreCommit-HIVE-Build-18390 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-18390 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18390/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/beeline/src/java/org/apache/hive/beeline/Commands.java: does not exist in index error: a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java: does not exist in index error: a/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java: does not exist in index error: a/jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java: does not exist in index error: a/jdbc/src/java/org/apache/hive/jdbc/Utils.java: does not exist in index error: a/jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java: does not exist in index error: a/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver.java: does not exist in index error: patch failed: itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:2863 Falling back to three-way merge... Applied patch to 'itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java' cleanly. error: patch failed: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:175 Falling back to three-way merge... Applied patch to 'jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java' with conflicts. error: patch failed: jdbc/src/java/org/apache/hive/jdbc/Utils.java:294 Falling back to three-way merge... Applied patch to 'jdbc/src/java/org/apache/hive/jdbc/Utils.java' with conflicts. error: patch failed: jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java:70 Falling back to three-way merge... Applied patch to 'jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java' with conflicts. Going to apply patch with: git apply -p1 error: patch failed: itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:2863 Falling back to three-way merge... Applied patch to 'itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java'
[jira] [Commented] (HIVE-21105) LLAP: provide an option to configure #retries and time between retries for LLAP-ZK SecretManager
[ https://issues.apache.org/jira/browse/HIVE-21105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914088#comment-16914088 ] Hive QA commented on HIVE-21105: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12954243/HIVE-21105.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16745 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18389/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18389/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18389/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12954243 - PreCommit-HIVE-Build > LLAP: provide an option to configure #retries and time between retries for > LLAP-ZK SecretManager > > > Key: HIVE-21105 > URL: https://issues.apache.org/jira/browse/HIVE-21105 > Project: Hive > Issue Type: Bug > Components: llap >Affects Versions: 3.1.1, 2.3.4 >Reporter: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-21105.1.patch > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-21828) Tez: Use a pre-parsed TezConfiguration from DagUtils
[ https://issues.apache.org/jira/browse/HIVE-21828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914063#comment-16914063 ] Laszlo Bodor commented on HIVE-21828: - pushed as https://github.com/apache/hive/commit/9482a0c0319427d74af6829d7766c16e44938500 thanks [~amagyar], [~gopalv]! > Tez: Use a pre-parsed TezConfiguration from DagUtils > > > Key: HIVE-21828 > URL: https://issues.apache.org/jira/browse/HIVE-21828 > Project: Hive > Issue Type: Bug >Reporter: Gopal V >Assignee: Attila Magyar >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-21828.1.patch, HIVE-21828.2.patch, > HIVE-21828.5.patch, HIVE-21828.6.patch, HIVE-21828.7.patch, > HIVE-21828.8.patch, HIVE-21828.9.patch > > > The HS2 tez-site.xml does not change dynamically - the XML parsed components > of the config can be obtained statically and kept across sessions. > This allows for the replacing of "new TezConfiguration()" with a HS2 local > version instead. > The configuration object however has to reference the right resource file > (i.e location of tez-site.xml) without reparsing it for each query. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-21105) LLAP: provide an option to configure #retries and time between retries for LLAP-ZK SecretManager
[ https://issues.apache.org/jira/browse/HIVE-21105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914056#comment-16914056 ] Hive QA commented on HIVE-21105: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 55s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 37s{color} | {color:blue} common in master has 61 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 32s{color} | {color:blue} llap-common in master has 90 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} llap-common: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 16m 55s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18389/dev-support/hive-personality.sh | | git revision | master / db59ec6 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18389/yetus/diff-checkstyle-llap-common.txt | | modules | C: common llap-common U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18389/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > LLAP: provide an option to configure #retries and time between retries for > LLAP-ZK SecretManager > > > Key: HIVE-21105 > URL: https://issues.apache.org/jira/browse/HIVE-21105 > Project: Hive > Issue Type: Bug > Components: llap >Affects Versions: 3.1.1, 2.3.4 >Reporter: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-21105.1.patch > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naresh P R reassigned HIVE-21698: - Assignee: Shubham Goyal (was: Naresh P R) > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Goyal >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Naresh P R reassigned HIVE-21698: - Assignee: Naresh P R (was: Shubham Goyal) > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-19748) Add appropriate null checks to DecimalColumnStatsAggregator
[ https://issues.apache.org/jira/browse/HIVE-19748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914041#comment-16914041 ] Hive QA commented on HIVE-19748: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12941085/HIVE-19748.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18388/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18388/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18388/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-08-23 08:14:51.790 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-18388/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-08-23 08:14:51.793 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-08-23 08:14:52.556 + rm -rf ../yetus_PreCommit-HIVE-Build-18388 + mkdir ../yetus_PreCommit-HIVE-Build-18388 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-18388 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18388/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index error: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index error: src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-18388 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12941085 - PreCommit-HIVE-Build > Add appropriate null checks to DecimalColumnStatsAggregator > --- > > Key: HIVE-19748 > URL: https://issues.apache.org/jira/browse/HIVE-19748 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-19748.1.patch, HIVE-19748.1.patch, > HIVE-19748.1.patch, HIVE-19748.1.patch > > > In some of our internal testing, we noticed that calls to > MetaStoreUtils.decimalToDoublee(Decimal decimal) from within > DecimalColumnStatsAggregator end up passing null Decimal values to the method. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914039#comment-16914039 ] Hive QA commented on HIVE-21698: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12978365/HIVE-21698.1.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16745 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18387/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18387/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18387/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12978365 - PreCommit-HIVE-Build > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-21698) TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while localizing resources
[ https://issues.apache.org/jira/browse/HIVE-21698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914017#comment-16914017 ] Hive QA commented on HIVE-21698: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 8s{color} | {color:blue} ql in master has 2254 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} ql: The patch generated 0 new + 89 unchanged - 3 fixed = 89 total (was 92) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 34s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18387/dev-support/hive-personality.sh | | git revision | master / db59ec6 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18387/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > TezSessionState#ensureLocalResources() causes IndexOutOfBoundsException while > localizing resources > -- > > Key: HIVE-21698 > URL: https://issues.apache.org/jira/browse/HIVE-21698 > Project: Hive > Issue Type: Bug > Components: Query Processor, Tez >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Naresh P R >Priority: Major > Attachments: HIVE-21698.1.patch, HIVE-21698.patch > > > The cause of exception is due to [this loops > over|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L633] > {{newFilesNotFromConf}} and tries to access {{newResources.get(i)}} in that. > Size of {{newResources}} is determined by [utils.localizeTempFiles() > here|https://github.com/apache/hive/blob/rel/release-3.1.1/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java#L629] > which may return a smaller list depending upon the {{skipFilesFromConf}} and > this would result in {{newResources.size()}} < {{newFilesNotFromConf.length}} > causing IndexOutOfBounds. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-16951) ACID Compactor, PartialScanTask, MergeFileTask, ColumnTruncateTask, HCatUtil don't close JobClient
[ https://issues.apache.org/jira/browse/HIVE-16951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913996#comment-16913996 ] Hive QA commented on HIVE-16951: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12874746/HIVE-16951.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18386/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18386/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18386/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-08-23 06:52:22.866 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-18386/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-08-23 06:52:22.869 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-08-23 06:52:23.504 + rm -rf ../yetus_PreCommit-HIVE-Build-18386 + mkdir ../yetus_PreCommit-HIVE-Build-18386 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-18386 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18386/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java: does not exist in index error: ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java: does not exist in index error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java:219 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java' cleanly. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java:280 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java' with conflicts. error: core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java: does not exist in index error: src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-18386 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12874746 - PreCommit-HIVE-Build > ACID Compactor, PartialScanTask, MergeFileTask, ColumnTruncateTask, HCatUtil > don't close JobClient >
[jira] [Commented] (HIVE-18244) CachedStore: Fix UT when CachedStore is enabled
[ https://issues.apache.org/jira/browse/HIVE-18244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913994#comment-16913994 ] Hive QA commented on HIVE-18244: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12935008/HIVE-18244.2.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18385/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18385/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18385/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-08-23 06:51:06.415 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-18385/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-08-23 06:51:06.418 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-08-23 06:51:07.487 + rm -rf ../yetus_PreCommit-HIVE-Build-18385 + mkdir ../yetus_PreCommit-HIVE-Build-18385 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-18385 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18385/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/data/conf/hive-site.xml: does not exist in index error: a/data/conf/llap/hive-site.xml: does not exist in index error: a/data/conf/perf-reg/tez/hive-site.xml: does not exist in index error: a/data/conf/tez/hive-site.xml: does not exist in index error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: does not exist in index error: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: does not exist in index error: patch failed: conf/hive-site.xml:135 Falling back to three-way merge... Applied patch to 'conf/hive-site.xml' with conflicts. error: conf/llap/hive-site.xml: does not exist in index error: conf/perf-reg/tez/hive-site.xml: does not exist in index error: conf/tez/hive-site.xml: does not exist in index error: metastore-server/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-18385 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12935008 - PreCommit-HIVE-Build > CachedStore: Fix UT when CachedStore is enabled > --- > > Key: HIVE-18244 > URL: https://issues.apache.org/jira/browse/HIVE-18244 > Project: Hive > Issue Type: Sub-task >Reporter: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-18244.1.patch, HIVE-18244.2.patch, > HIVE-18244.2.patch > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-12374) Improve setting of JVM configs for HS2 and Metastore shell scripts
[ https://issues.apache.org/jira/browse/HIVE-12374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913993#comment-16913993 ] Hive QA commented on HIVE-12374: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12771592/HIVE-12374.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18384/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18384/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18384/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-08-23 06:49:46.829 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-18384/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-08-23 06:49:46.832 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-08-23 06:49:47.462 + rm -rf ../yetus_PreCommit-HIVE-Build-18384 + mkdir ../yetus_PreCommit-HIVE-Build-18384 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-18384 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18384/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/bin/ext/hiveserver2.sh: does not exist in index error: a/bin/ext/metastore.sh: does not exist in index error: a/conf/hive-env.sh.template: does not exist in index error: patch failed: bin/ext/hiveserver2.sh:17 Falling back to three-way merge... Applied patch to 'bin/ext/hiveserver2.sh' with conflicts. error: patch failed: bin/ext/metastore.sh:17 Falling back to three-way merge... Applied patch to 'bin/ext/metastore.sh' with conflicts. error: patch failed: conf/hive-env.sh.template:50 Falling back to three-way merge... Applied patch to 'conf/hive-env.sh.template' cleanly. Going to apply patch with: git apply -p1 error: patch failed: bin/ext/hiveserver2.sh:17 Falling back to three-way merge... Applied patch to 'bin/ext/hiveserver2.sh' with conflicts. error: patch failed: bin/ext/metastore.sh:17 Falling back to three-way merge... Applied patch to 'bin/ext/metastore.sh' with conflicts. error: patch failed: conf/hive-env.sh.template:50 Falling back to three-way merge... Applied patch to 'conf/hive-env.sh.template' cleanly. U bin/ext/hiveserver2.sh U bin/ext/metastore.sh + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-18384 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12771592 - PreCommit-HIVE-Build > Improve setting of JVM configs for HS2 and Metastore shell scripts > --- > > Key: HIVE-12374 > URL: https://issues.apache.org/jira/browse/HIVE-12374 > Project: Hive > Issue Type: Improvement > Components: HiveServer2, Metastore >Reporter: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-12374.1.patch > > > Adding {{HIVESERVER2_JVM_OPTS}} and {{METASTORE_JVM_OPTS}} env variables, > which will eventually set {{HADOOP_CLIENT_OPTS}} (since we start the > processes using hadoop jar ...). Also setting these
[jira] [Commented] (HIVE-20754) JDBC: Add some missing classes to jdbc standalone jar (follow up to HIVE-19801)
[ https://issues.apache.org/jira/browse/HIVE-20754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913990#comment-16913990 ] Hive QA commented on HIVE-20754: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12944176/HIVE-20754.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16745 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18383/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18383/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18383/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12944176 - PreCommit-HIVE-Build > JDBC: Add some missing classes to jdbc standalone jar (follow up to > HIVE-19801) > --- > > Key: HIVE-20754 > URL: https://issues.apache.org/jira/browse/HIVE-20754 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 3.1.0 >Reporter: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-20754.1.patch > > > Some more classes are needed in a secure cluster -- This message was sent by Atlassian Jira (v8.3.2#803003)