[jira] [Assigned] (HIVE-21630) Refactor database object reference access
[
https://issues.apache.org/jira/browse/HIVE-21630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati reassigned HIVE-21630:
---
Assignee: (was: David Lavati)
> Refactor database object reference access
> -
>
> Key: HIVE-21630
> URL: https://issues.apache.org/jira/browse/HIVE-21630
> Project: Hive
> Issue Type: Improvement
>Reporter: David Lavati
>Priority: Major
> Labels: refactor
>
> There are many places in which "
> {databasename}
> .
> {tablename}
> " is passed as a single string; there are some places where the they travel
> as 2 separate arguments or as a {{String[]}}.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass
> these informations together. Making this better is required if we would want
> to enable dot in tablenames: HIVE-16907, HIVE-21151
> The refactor requires large rework especially in the ql module: this ticket
> serves as an umbrella for these steps.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work stopped] (HIVE-21630) Refactor database object reference access
[
https://issues.apache.org/jira/browse/HIVE-21630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-21630 stopped by David Lavati.
---
> Refactor database object reference access
> -
>
> Key: HIVE-21630
> URL: https://issues.apache.org/jira/browse/HIVE-21630
> Project: Hive
> Issue Type: Improvement
>Reporter: David Lavati
>Assignee: David Lavati
>Priority: Major
> Labels: refactor
>
> There are many places in which "
> {databasename}
> .
> {tablename}
> " is passed as a single string; there are some places where the they travel
> as 2 separate arguments or as a {{String[]}}.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass
> these informations together. Making this better is required if we would want
> to enable dot in tablenames: HIVE-16907, HIVE-21151
> The refactor requires large rework especially in the ql module: this ticket
> serves as an umbrella for these steps.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HIVE-22304) Upgrade ORC version to 1.6.2
[ https://issues.apache.org/jira/browse/HIVE-22304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati resolved HIVE-22304. - Resolution: Won't Do Already bumped to 1.6.9 in HIVE-25384, closing. > Upgrade ORC version to 1.6.2 > > > Key: HIVE-22304 > URL: https://issues.apache.org/jira/browse/HIVE-22304 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Priority: Major > Attachments: HIVE-22304.1.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HIVE-22304) Upgrade ORC version to 1.6.2
[ https://issues.apache.org/jira/browse/HIVE-22304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22304: Status: Open (was: Patch Available) > Upgrade ORC version to 1.6.2 > > > Key: HIVE-22304 > URL: https://issues.apache.org/jira/browse/HIVE-22304 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Attachments: HIVE-22304.1.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HIVE-22304) Upgrade ORC version to 1.6.2
[ https://issues.apache.org/jira/browse/HIVE-22304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22304: --- Assignee: (was: David Lavati) > Upgrade ORC version to 1.6.2 > > > Key: HIVE-22304 > URL: https://issues.apache.org/jira/browse/HIVE-22304 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Priority: Major > Attachments: HIVE-22304.1.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22585: --- Assignee: (was: David Lavati) > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch, > HIVE-22585.03.patch, HIVE-22585.04.patch, HIVE-22585.05.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. > This change includes the following: > * Remove reliance on Utilities.getDbTableName > * Introduce a contract in TableName to always store catalog.dbname.tablename > in lowercase > * Make TableName a parsable type for ExplainTask > * Additional refactors to leverage the TableName object -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22585: Status: Open (was: Patch Available) > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch, > HIVE-22585.03.patch, HIVE-22585.04.patch, HIVE-22585.05.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. > This change includes the following: > * Remove reliance on Utilities.getDbTableName > * Introduce a contract in TableName to always store catalog.dbname.tablename > in lowercase > * Make TableName a parsable type for ExplainTask > * Additional refactors to leverage the TableName object -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HIVE-22308) Add missing support of Azure Blobstore schemes
[
https://issues.apache.org/jira/browse/HIVE-22308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati updated HIVE-22308:
Assignee: (was: David Lavati)
Status: Open (was: Patch Available)
> Add missing support of Azure Blobstore schemes
> --
>
> Key: HIVE-22308
> URL: https://issues.apache.org/jira/browse/HIVE-22308
> Project: Hive
> Issue Type: Improvement
>Reporter: David Lavati
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22308.02.patch, HIVE-22308.02.patch,
> HIVE-22308.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Azure has been used as a filesystem for Hive, but its various schemes aren't
> registered under
> {{HiveConf.HIVE_BLOBSTORE_SUPPORTED_SCHEMES.}}
> Found the list of elements in:
> https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemUriSchemes.java
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HIVE-23490) REPL LOAD config to bootstrap external tables with purge
[ https://issues.apache.org/jira/browse/HIVE-23490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-23490: --- Assignee: (was: David Lavati) > REPL LOAD config to bootstrap external tables with purge > > > Key: HIVE-23490 > URL: https://issues.apache.org/jira/browse/HIVE-23490 > Project: Hive > Issue Type: New Feature > Components: repl >Reporter: David Lavati >Priority: Major > > When replicating data from e.g. an onprem HDFS cluster to cloud storage, a > common scenario is to load it as external table. However proper cleanup is > usually missing here, so when the user deletes a table on the source side, > it's ideal to purge it on the target side. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HIVE-22307) Upgrade Hadoop version to 3.1.3
[ https://issues.apache.org/jira/browse/HIVE-22307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22307: --- Assignee: (was: David Lavati) > Upgrade Hadoop version to 3.1.3 > --- > > Key: HIVE-22307 > URL: https://issues.apache.org/jira/browse/HIVE-22307 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22307.patch, HIVE-22307.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HIVE-23483) Remove DynamicSerDe
[ https://issues.apache.org/jira/browse/HIVE-23483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-23483: --- Assignee: David Lavati > Remove DynamicSerDe > --- > > Key: HIVE-23483 > URL: https://issues.apache.org/jira/browse/HIVE-23483 > Project: Hive > Issue Type: Task >Reporter: Ashutosh Chauhan >Assignee: David Lavati >Priority: Major > > It is used to read thrift data files. AFAIK no one uses thrift for data > serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HIVE-23483) Remove DynamicSerDe
[ https://issues.apache.org/jira/browse/HIVE-23483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-23483 started by David Lavati. --- > Remove DynamicSerDe > --- > > Key: HIVE-23483 > URL: https://issues.apache.org/jira/browse/HIVE-23483 > Project: Hive > Issue Type: Task >Reporter: Ashutosh Chauhan >Assignee: David Lavati >Priority: Major > > It is used to read thrift data files. AFAIK no one uses thrift for data > serialization. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-20359: Status: Open (was: Patch Available) > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.1.0 > > Attachments: HIVE-20359.01.branch-3.1.patch, > HIVE-20359.01.branch-3.1.patch, HIVE-20359.01.patch, HIVE-20359.01.patch, > HIVE-20359.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-19548) Enable TestSSL#testSSLFetchHttp
[
https://issues.apache.org/jira/browse/HIVE-19548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119501#comment-17119501
]
David Lavati commented on HIVE-19548:
-
I ran into this in a much older version as well, my findings might help someone
fixing this:
Error was:
{code:java}
testSSLFetchHttp(org.apache.hive.jdbc.TestSSL) Time elapsed: 12.568 sec <<<
ERROR!
org.apache.hive.service.cli.HiveSQLException: Error while compiling statement:
FAILED: SemanticException [Error 10072]: Database does not exist: default
at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:279)
at org.apache.hive.jdbc.Utils.verifySuccessWithInfo(Utils.java:265)
at
org.apache.hive.jdbc.HiveStatement.runAsyncOnServer(HiveStatement.java:304)
at org.apache.hive.jdbc.HiveStatement.execute(HiveStatement.java:245)
at org.apache.hive.jdbc.TestSSL.setupTestTableWithData(TestSSL.java:492)
at org.apache.hive.jdbc.TestSSL.testSSLFetchHttp(TestSSL.java:369)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
Caused by: org.apache.hive.service.cli.HiveSQLException: Error while compiling
statement: FAILED: SemanticException [Error 10072]: Database does not exist:
default{code}
This happens during the create table command in the data setup:
{code:java}
Statement stmt = hs2Conn.createStatement();
stmt.execute("set hive.support.concurrency = false");
stmt.execute("drop table if exists " + tableName);
stmt.execute("create table " + tableName
+ " (under_col int comment 'the under column', value string)"); {code}
This is probably some kind of concurrency/timing issue.
If I debug this and check {{show databases}} before the create command, I do
get back the default value. Also I had a passing test when run alone.
> Enable TestSSL#testSSLFetchHttp
> ---
>
> Key: HIVE-19548
> URL: https://issues.apache.org/jira/browse/HIVE-19548
> Project: Hive
> Issue Type: Test
> Components: Test
>Affects Versions: 3.1.0
>Reporter: Jesus Camacho Rodriguez
>Priority: Critical
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23490) REPL LOAD config to bootstrap external tables with purge
[
https://issues.apache.org/jira/browse/HIVE-23490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110364#comment-17110364
]
David Lavati commented on HIVE-23490:
-
Based on HIVE-19981 this can probably be achieved with {{REPL LOAD db FROM dir
WITH ('HIVE_EXTERNALTABLE_PURGE_DEFAULT'='true')}}
Will post my findings here.
> REPL LOAD config to bootstrap external tables with purge
>
>
> Key: HIVE-23490
> URL: https://issues.apache.org/jira/browse/HIVE-23490
> Project: Hive
> Issue Type: New Feature
> Components: repl
>Reporter: David Lavati
>Assignee: David Lavati
>Priority: Major
> Fix For: 4.0.0
>
>
> When replicating data from e.g. an onprem HDFS cluster to cloud storage, a
> common scenario is to load it as external table. However proper cleanup is
> usually missing here, so when the user deletes a table on the source side,
> it's ideal to purge it on the target side.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-23490) REPL LOAD config to bootstrap external tables with purge
[ https://issues.apache.org/jira/browse/HIVE-23490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-23490: Component/s: repl > REPL LOAD config to bootstrap external tables with purge > > > Key: HIVE-23490 > URL: https://issues.apache.org/jira/browse/HIVE-23490 > Project: Hive > Issue Type: New Feature > Components: repl >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > > When replicating data from e.g. an onprem HDFS cluster to cloud storage, a > common scenario is to load it as external table. However proper cleanup is > usually missing here, so when the user deletes a table on the source side, > it's ideal to purge it on the target side. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23490) REPL LOAD config to bootstrap external tables with purge
[ https://issues.apache.org/jira/browse/HIVE-23490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-23490: Fix Version/s: 4.0.0 > REPL LOAD config to bootstrap external tables with purge > > > Key: HIVE-23490 > URL: https://issues.apache.org/jira/browse/HIVE-23490 > Project: Hive > Issue Type: New Feature > Components: repl >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0 > > > When replicating data from e.g. an onprem HDFS cluster to cloud storage, a > common scenario is to load it as external table. However proper cleanup is > usually missing here, so when the user deletes a table on the source side, > it's ideal to purge it on the target side. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-23490) REPL LOAD config to bootstrap external tables with purge
[ https://issues.apache.org/jira/browse/HIVE-23490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-23490: --- > REPL LOAD config to bootstrap external tables with purge > > > Key: HIVE-23490 > URL: https://issues.apache.org/jira/browse/HIVE-23490 > Project: Hive > Issue Type: New Feature >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > > When replicating data from e.g. an onprem HDFS cluster to cloud storage, a > common scenario is to load it as external table. However proper cleanup is > usually missing here, so when the user deletes a table on the source side, > it's ideal to purge it on the target side. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22585: Attachment: HIVE-22585.05.patch > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch, > HIVE-22585.03.patch, HIVE-22585.04.patch, HIVE-22585.05.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. > This change includes the following: > * Remove reliance on Utilities.getDbTableName > * Introduce a contract in TableName to always store catalog.dbname.tablename > in lowercase > * Make TableName a parsable type for ExplainTask > * Additional refactors to leverage the TableName object -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090039#comment-17090039 ] David Lavati commented on HIVE-22585: - This grew out of proportions due to the qout changes... :) But at least it starts to look final now. > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch, > HIVE-22585.03.patch, HIVE-22585.04.patch, HIVE-22585.05.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. > This change includes the following: > * Remove reliance on Utilities.getDbTableName > * Introduce a contract in TableName to always store catalog.dbname.tablename > in lowercase > * Make TableName a parsable type for ExplainTask > * Additional refactors to leverage the TableName object -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23088) Using Strings from log4j breaks non-log4j users
[
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088927#comment-17088927
]
David Lavati commented on HIVE-23088:
-
Thank you [~pgaref], I'm not familiar with the state of branch-3, but if my new
reupload has similar results, I guess it's business as usual. The change is
probably simple enough to merge it there as well though.
> Using Strings from log4j breaks non-log4j users
> ---
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Vova Vysotskyi
>Assignee: David Lavati
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch,
> HIVE-23088.01.branch-3.patch, HIVE-23088.01.branch-3.patch,
> HIVE-23088.01.patch, HIVE-23088.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class
> from log4j, but it may break clients who use other loggers and should exclude
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement
> for this one:
> {{Strings.isBlank}} -> {{StringUtils.isBlank}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-23088) Using Strings from log4j breaks non-log4j users
[
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati updated HIVE-23088:
Attachment: HIVE-23088.01.branch-3.patch
> Using Strings from log4j breaks non-log4j users
> ---
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Vova Vysotskyi
>Assignee: David Lavati
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch,
> HIVE-23088.01.branch-3.patch, HIVE-23088.01.branch-3.patch,
> HIVE-23088.01.patch, HIVE-23088.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class
> from log4j, but it may break clients who use other loggers and should exclude
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement
> for this one:
> {{Strings.isBlank}} -> {{StringUtils.isBlank}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-23088) Using Strings from log4j breaks non-log4j users
[
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati updated HIVE-23088:
Attachment: HIVE-23088.01.branch-3.patch
> Using Strings from log4j breaks non-log4j users
> ---
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Vova Vysotskyi
>Assignee: David Lavati
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch,
> HIVE-23088.01.branch-3.patch, HIVE-23088.01.patch, HIVE-23088.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class
> from log4j, but it may break clients who use other loggers and should exclude
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement
> for this one:
> {{Strings.isBlank}} -> {{StringUtils.isBlank}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-23088) Using Strings from log4j breaks non-log4j users
[
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati updated HIVE-23088:
Attachment: HIVE-23088.01.patch
> Using Strings from log4j breaks non-log4j users
> ---
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Vova Vysotskyi
>Assignee: David Lavati
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch, HIVE-23088.01.patch,
> HIVE-23088.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class
> from log4j, but it may break clients who use other loggers and should exclude
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement
> for this one:
> {{Strings.isBlank}} -> {{StringUtils.isBlank}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-23088) Using Strings from log4j breaks non-log4j users
[
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati updated HIVE-23088:
Attachment: HIVE-23088.01.patch
HIVE-23088.01.branch-3.patch
Fix Version/s: 3.1.3
3.2.0
4.0.0
Status: Patch Available (was: Open)
The main issue is from the fact that HookUtils is a public-facing class.
I'm leaving LlapWrappedAppender as is, as it's a log4j-based wrapper with a
bunch of related classes already being used in it.
On branch-3 I've used the already imported StringUtils classes regardless of
commons-lang 2v3, when present.
> Using Strings from log4j breaks non-log4j users
> ---
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Vova Vysotskyi
>Assignee: David Lavati
>Priority: Major
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-23088.01.branch-3.patch, HIVE-23088.01.patch
>
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class
> from log4j, but it may break clients who use other loggers and should exclude
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement
> for this one:
> {{Strings.isBlank}} -> {{StringUtils.isBlank}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HIVE-23088) Using Strings from log4j breaks non-log4j users
[
https://issues.apache.org/jira/browse/HIVE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati reassigned HIVE-23088:
---
Assignee: David Lavati
> Using Strings from log4j breaks non-log4j users
> ---
>
> Key: HIVE-23088
> URL: https://issues.apache.org/jira/browse/HIVE-23088
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.1.2
>Reporter: Vova Vysotskyi
>Assignee: David Lavati
>Priority: Major
>
> {{HookUtils}} uses explicitly {{org.apache.logging.log4j.util.Strings}} class
> from log4j, but it may break clients who use other loggers and should exclude
> log4j from the classpath.
> {{commons-lang}} has class {{StringUtils}} which may be used as a replacement
> for this one:
> {{Strings.isBlank}} -> {{StringUtils.isBlank}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23150) Create an Object Identifier Parser for All Components to Use
[ https://issues.apache.org/jira/browse/HIVE-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077447#comment-17077447 ] David Lavati commented on HIVE-23150: - [~belugabehr] TableName currently uses splitting because there are too many cans of worms that need to be opened/resolved for it's internals to be more sophisticated. I chose to weed out a lot of String manipulation and organize it under a class, which then can be globally refactored at least. Changing 1 single thing that affects a core ql function, can ripple out to hundreds of test cases, so most approaches seemed to be painful either way. Similarly to your idea, I wanted to do multiple steps under HIVE-21630, but recently I haven't had much time to finish HIVE-22585. As for refactoring, some bothersome hotspots are around replication, material views, security. Nonetheless it's good to see that more of us are looking at this group of issues :) > Create an Object Identifier Parser for All Components to Use > > > Key: HIVE-23150 > URL: https://issues.apache.org/jira/browse/HIVE-23150 > Project: Hive > Issue Type: Sub-task >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > Attachments: HIVE-23150.1.patch > > > Create a parser for parsing (and validating) MySQL/MariaDB style object > identifiers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23033) MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE
[ https://issues.apache.org/jira/browse/HIVE-23033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063572#comment-17063572 ] David Lavati commented on HIVE-23033: - Thank you for the help & review [~ngangam]! :) > MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE > --- > > Key: HIVE-23033 > URL: https://issues.apache.org/jira/browse/HIVE-23033 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0, 3.1.1, 3.1.2 >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-23033.1.patch, HIVE-23033.2.branch-3.patch, > HIVE-23033.2.patch > > > * The inital value for this table in the schema scripts was removed in > HIVE-17566: > https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 > * This was fixed in a number of scripts in HIVE-18781, but not for mssql: > https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 > * This is as is since then > When using the schematool, the table gets initialized by other means. > This could be backported to all active branches for 3.x as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23033) MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE
[ https://issues.apache.org/jira/browse/HIVE-23033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061653#comment-17061653 ] David Lavati commented on HIVE-23033: - [~ngangam] thanks for the feedback, I wasn't sure of the proper releases. I've added a branch-3 specific version as well and now both versions init the schema in their proper upgrades + their last version init scripts. > MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE > --- > > Key: HIVE-23033 > URL: https://issues.apache.org/jira/browse/HIVE-23033 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0, 3.1.1, 3.1.2 >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-23033.1.patch, HIVE-23033.2.branch-3.patch, > HIVE-23033.2.patch > > > * The inital value for this table in the schema scripts was removed in > HIVE-17566: > https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 > * This was fixed in a number of scripts in HIVE-18781, but not for mssql: > https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 > * This is as is since then > When using the schematool, the table gets initialized by other means. > This could be backported to all active branches for 3.x as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23033) MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE
[ https://issues.apache.org/jira/browse/HIVE-23033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-23033: Attachment: HIVE-23033.2.branch-3.patch > MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE > --- > > Key: HIVE-23033 > URL: https://issues.apache.org/jira/browse/HIVE-23033 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0, 3.1.1, 3.1.2 >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-23033.1.patch, HIVE-23033.2.branch-3.patch, > HIVE-23033.2.patch > > > * The inital value for this table in the schema scripts was removed in > HIVE-17566: > https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 > * This was fixed in a number of scripts in HIVE-18781, but not for mssql: > https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 > * This is as is since then > When using the schematool, the table gets initialized by other means. > This could be backported to all active branches for 3.x as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23033) MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE
[ https://issues.apache.org/jira/browse/HIVE-23033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-23033: Attachment: HIVE-23033.2.patch > MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE > --- > > Key: HIVE-23033 > URL: https://issues.apache.org/jira/browse/HIVE-23033 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0, 3.1.1, 3.1.2 >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-23033.1.patch, HIVE-23033.2.branch-3.patch, > HIVE-23033.2.patch > > > * The inital value for this table in the schema scripts was removed in > HIVE-17566: > https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 > * This was fixed in a number of scripts in HIVE-18781, but not for mssql: > https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 > * This is as is since then > When using the schematool, the table gets initialized by other means. > This could be backported to all active branches for 3.x as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23033) MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE
[ https://issues.apache.org/jira/browse/HIVE-23033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-23033: Fix Version/s: (was: 3.1.3) 3.2.0 > MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE > --- > > Key: HIVE-23033 > URL: https://issues.apache.org/jira/browse/HIVE-23033 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0, 3.1.1, 3.1.2 >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-23033.1.patch > > > * The inital value for this table in the schema scripts was removed in > HIVE-17566: > https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 > * This was fixed in a number of scripts in HIVE-18781, but not for mssql: > https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 > * This is as is since then > When using the schematool, the table gets initialized by other means. > This could be backported to all active branches for 3.x as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23033) MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE
[ https://issues.apache.org/jira/browse/HIVE-23033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-23033: Description: * The inital value for this table in the schema scripts was removed in HIVE-17566: https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 * This was fixed in a number of scripts in HIVE-18781, but not for mssql: https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 * This is as is since then When using the schematool, the table gets initialized by other means. This could be backported to all active branches for 3.x as well. was: * The inital value for this table in the schema scripts was removed in HIVE-17566: https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 * This was fixed in a number of scripts in HIVE-18781, but not for mssql: https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 * This is as is since then When using the schematool, the table gets initialized by other means. > MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE > --- > > Key: HIVE-23033 > URL: https://issues.apache.org/jira/browse/HIVE-23033 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0, 3.1.0, 3.1.1, 3.1.2 >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0, 3.1.3 > > Attachments: HIVE-23033.1.patch > > > * The inital value for this table in the schema scripts was removed in > HIVE-17566: > https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 > * This was fixed in a number of scripts in HIVE-18781, but not for mssql: > https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 > * This is as is since then > When using the schematool, the table gets initialized by other means. > This could be backported to all active branches for 3.x as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-23033) MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE
[ https://issues.apache.org/jira/browse/HIVE-23033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-23033: Attachment: HIVE-23033.1.patch Status: Patch Available (was: Open) > MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE > --- > > Key: HIVE-23033 > URL: https://issues.apache.org/jira/browse/HIVE-23033 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.2, 3.1.1, 3.1.0, 3.0.0 >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0, 3.1.3 > > Attachments: HIVE-23033.1.patch > > > * The inital value for this table in the schema scripts was removed in > HIVE-17566: > https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 > * This was fixed in a number of scripts in HIVE-18781, but not for mssql: > https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 > * This is as is since then > When using the schematool, the table gets initialized by other means. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-23033) MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE
[ https://issues.apache.org/jira/browse/HIVE-23033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-23033: --- > MSSQL metastore schema init script doesn't initialize NOTIFICATION_SEQUENCE > --- > > Key: HIVE-23033 > URL: https://issues.apache.org/jira/browse/HIVE-23033 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.2, 3.1.1, 3.1.0, 3.0.0 >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0, 3.1.3 > > > * The inital value for this table in the schema scripts was removed in > HIVE-17566: > https://github.com/apache/hive/commit/32b7abac961ca3879d23b074357f211fc7c49131#diff-3d1a4bae0d5d53c8e4ea79951ebf5eceL598 > * This was fixed in a number of scripts in HIVE-18781, but not for mssql: > https://github.com/apache/hive/commit/59483bca262880d3e7ef1b873d3c21176e9294cb#diff-4f43efd5a45cc362cb138287d90dbf82 > * This is as is since then > When using the schematool, the table gets initialized by other means. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23021) PreCommit builds are not getting triggered
[ https://issues.apache.org/jira/browse/HIVE-23021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058994#comment-17058994 ] David Lavati commented on HIVE-23021: - [~pkumarsinha] precommits are run at https://builds.apache.org/job/PreCommit-HIVE-Build/ and there's usually a queue for a number of jiras. Currently your issue will be next as build #21104 For more info see https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing > PreCommit builds are not getting triggered > -- > > Key: HIVE-23021 > URL: https://issues.apache.org/jira/browse/HIVE-23021 > Project: Hive > Issue Type: Bug > Components: Testing Infrastructure >Reporter: PRAVIN KUMAR SINHA >Assignee: Ashutosh Chauhan >Priority: Blocker > > Tried different naming conventions for the patch file name, despite the > PreCommit builds aren't getting triggered. Can someone please look into this? > Apache HIVE JIRA: https://issues.apache.org/jira/browse/HIVE-22997 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22126) hive-exec packaging should shade guava
[ https://issues.apache.org/jira/browse/HIVE-22126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22126: --- Assignee: Eugene Chung (was: David Lavati) > hive-exec packaging should shade guava > -- > > Key: HIVE-22126 > URL: https://issues.apache.org/jira/browse/HIVE-22126 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: Eugene Chung >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22126.01.patch, HIVE-22126.02.patch, > HIVE-22126.03.patch, HIVE-22126.04.patch, HIVE-22126.05.patch, > HIVE-22126.06.patch, HIVE-22126.07.patch, HIVE-22126.08.patch, > HIVE-22126.09.patch, HIVE-22126.09.patch > > > The ql/pom.xml includes complete guava library into hive-exec.jar > https://github.com/apache/hive/blob/master/ql/pom.xml#L990 This causes a > problems for downstream clients of hive which have hive-exec.jar in their > classpath since they are pinned to the same guava version as that of hive. > We should shade guava classes so that other components which depend on > hive-exec can independently use a different version of guava as needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22126) hive-exec packaging should shade guava
[ https://issues.apache.org/jira/browse/HIVE-22126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22126: --- Assignee: David Lavati (was: Eugene Chung) > hive-exec packaging should shade guava > -- > > Key: HIVE-22126 > URL: https://issues.apache.org/jira/browse/HIVE-22126 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22126.01.patch, HIVE-22126.02.patch, > HIVE-22126.03.patch, HIVE-22126.04.patch, HIVE-22126.05.patch, > HIVE-22126.06.patch, HIVE-22126.07.patch, HIVE-22126.08.patch, > HIVE-22126.09.patch, HIVE-22126.09.patch > > > The ql/pom.xml includes complete guava library into hive-exec.jar > https://github.com/apache/hive/blob/master/ql/pom.xml#L990 This causes a > problems for downstream clients of hive which have hive-exec.jar in their > classpath since they are pinned to the same guava version as that of hive. > We should shade guava classes so that other components which depend on > hive-exec can independently use a different version of guava as needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22126) hive-exec packaging should shade guava
[ https://issues.apache.org/jira/browse/HIVE-22126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22126: Attachment: HIVE-22126.09.patch > hive-exec packaging should shade guava > -- > > Key: HIVE-22126 > URL: https://issues.apache.org/jira/browse/HIVE-22126 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22126.01.patch, HIVE-22126.02.patch, > HIVE-22126.03.patch, HIVE-22126.04.patch, HIVE-22126.05.patch, > HIVE-22126.06.patch, HIVE-22126.07.patch, HIVE-22126.08.patch, > HIVE-22126.09.patch, HIVE-22126.09.patch > > > The ql/pom.xml includes complete guava library into hive-exec.jar > https://github.com/apache/hive/blob/master/ql/pom.xml#L990 This causes a > problems for downstream clients of hive which have hive-exec.jar in their > classpath since they are pinned to the same guava version as that of hive. > We should shade guava classes so that other components which depend on > hive-exec can independently use a different version of guava as needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-20359: --- Assignee: (was: David Lavati) > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-20359.01.branch-3.1.patch, > HIVE-20359.01.branch-3.1.patch, HIVE-20359.01.patch, HIVE-20359.01.patch, > HIVE-20359.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HIVE-5787) Move non-type specific column statistics to ColumnStatistics object in ORC
[
https://issues.apache.org/jira/browse/HIVE-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati resolved HIVE-5787.
Resolution: Abandoned
> Move non-type specific column statistics to ColumnStatistics object in ORC
> --
>
> Key: HIVE-5787
> URL: https://issues.apache.org/jira/browse/HIVE-5787
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 0.13.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Minor
> Labels: orcfile
>
> Non-type statistics like min, max, numNulls etc. can be moved to
> ColumnStatistics class. This avoids ugly checks like
> {code} if (index instanceof IntegerColumnStatistics) {
> return ((IntegerColumnStatistics) index).getMinimum();
> } else if (index instanceof DoubleColumnStatistics) {
> return ((DoubleColumnStatistics) index).getMinimum();
> } else if (index instanceof StringColumnStatistics) {
> return ((StringColumnStatistics) index).getMinimum();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22585: Attachment: HIVE-22585.04.patch > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch, > HIVE-22585.03.patch, HIVE-22585.04.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. > This change includes the following: > * Remove reliance on Utilities.getDbTableName > * Introduce a contract in TableName to always store catalog.dbname.tablename > in lowercase > * Make TableName a parsable type for ExplainTask > * Additional refactors to leverage the TableName object -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22585: Description: This is a followup to HIVE-21198 to address some additional improvement ideas for the TableName object mentioned in [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy usages of db/tablenames, as a number of places still rely on certain state changes/black magic. This change includes the following: * Remove reliance on Utilities.getDbTableName * Introduce a contract in TableName to always store catalog.dbname.tablename in lowercase * Make TableName a parsable type for ExplainTask * Additional refactors to leverage the TableName object was:This is a followup to HIVE-21198 to address some additional improvement ideas for the TableName object mentioned in [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy usages of db/tablenames, as a number of places still rely on certain state changes/black magic. > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch, > HIVE-22585.03.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. > This change includes the following: > * Remove reliance on Utilities.getDbTableName > * Introduce a contract in TableName to always store catalog.dbname.tablename > in lowercase > * Make TableName a parsable type for ExplainTask > * Additional refactors to leverage the TableName object -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22220) Upgrade Accumulo version to the latest 2.0 release
[ https://issues.apache.org/jira/browse/HIVE-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043588#comment-17043588 ] David Lavati commented on HIVE-0: - Looks like this is also blocked by guava, as accumulo 2.0 uses guava 27: https://github.com/apache/accumulo/commit/82661b605452a9c2f738c5960bda0d3c9981887a > Upgrade Accumulo version to the latest 2.0 release > -- > > Key: HIVE-0 > URL: https://issues.apache.org/jira/browse/HIVE-0 > Project: Hive > Issue Type: Improvement >Reporter: Ivan Suller >Assignee: Ivan Suller >Priority: Major > > To make Thrift upgrade (HIVE-21000) possible we have to upgrade Accumulo to > at least 2.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043566#comment-17043566 ] David Lavati commented on HIVE-20359: - hbase.TestPutResultWritable.testPut is failing due to the protobuf version mismatch: hbase uses protobuf 2.x externally (see [here|https://github.com/apache/hbase/blob/2.0.0-alpha4RC0/pom.xml#L1385]). This is being addressed right now in HBASE-19146, but only for hbase 3 which is ~1 year away from GA. I didn't find any sign of this being addressed for hbase 2.x. HBASE-22394 is also a blocker for upgrading hbase in HIVE-22447 (even if this was fixed in hbase 2.x) > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-20359.01.branch-3.1.patch, > HIVE-20359.01.branch-3.1.patch, HIVE-20359.01.patch, HIVE-20359.01.patch, > HIVE-20359.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-20359: Attachment: HIVE-20359.01.patch > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-20359.01.branch-3.1.patch, > HIVE-20359.01.branch-3.1.patch, HIVE-20359.01.patch, HIVE-20359.01.patch, > HIVE-20359.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-20359: Attachment: HIVE-20359.01.branch-3.1.patch HIVE-20359.01.patch Status: Patch Available (was: In Progress) > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.1.0 > > Attachments: HIVE-20359.01.branch-3.1.patch, > HIVE-20359.01.branch-3.1.patch, HIVE-20359.01.patch, HIVE-20359.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22126) hive-exec packaging should shade guava
[ https://issues.apache.org/jira/browse/HIVE-22126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041945#comment-17041945 ] David Lavati commented on HIVE-22126: - I just spotted this issue: [~euigeun_chung] HIVE-21569 was recently going in a direction to shade guava as there are other issues with a simple bump, mostly wrt spark. Maybe we can align our findings here. cc [~abstractdog] > hive-exec packaging should shade guava > -- > > Key: HIVE-22126 > URL: https://issues.apache.org/jira/browse/HIVE-22126 > Project: Hive > Issue Type: Bug >Reporter: Vihang Karajgaonkar >Assignee: Eugene Chung >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22126.01.patch, HIVE-22126.02.patch, > HIVE-22126.03.patch > > > The ql/pom.xml includes complete guava library into hive-exec.jar > https://github.com/apache/hive/blob/master/ql/pom.xml#L990 This causes a > problems for downstream clients of hive which have hive-exec.jar in their > classpath since they are pinned to the same guava version as that of hive. > We should shade guava classes so that other components which depend on > hive-exec can independently use a different version of guava as needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-20359: Fix Version/s: 4.0.0 > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-20359.01.branch-3.1.patch, HIVE-20359.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-20359: Attachment: HIVE-20359.01.patch > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > Attachments: HIVE-20359.01.branch-3.1.patch, HIVE-20359.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-20359: Attachment: HIVE-20359.01.branch-3.1.patch > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > Attachments: HIVE-20359.01.branch-3.1.patch, HIVE-20359.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041740#comment-17041740 ] David Lavati commented on HIVE-20359: - I see this hasn't been touched for a while and [3.11.4|https://github.com/protocolbuffers/protobuf/releases/tag/v3.11.4] is the latest release since then, [~nbhat] I'm taking a shot at this, if you don't mind. > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: Naresh Bhat >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-20359 started by David Lavati. --- > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-20359) Update protobuf version in pom.xml
[ https://issues.apache.org/jira/browse/HIVE-20359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-20359: --- Assignee: David Lavati (was: Naresh Bhat) > Update protobuf version in pom.xml > -- > > Key: HIVE-20359 > URL: https://issues.apache.org/jira/browse/HIVE-20359 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.0 > Environment: ARM64 Server machines with CentOS/Debian OS. >Reporter: Naresh Bhat >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > > The following protoc version's used in hive is very old i.e. 2.5.0 > [https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/] . The > v2.5.0 does not have aarch64 support. But the AArch64 support started from > v3.5.0 on-words in google's protobuf project release. The hive release > version branch v3/3.0/3.1/master branch build fails on AArch64 because of old > protoc version 2.5.0, in which there is no AArch64 support/exe available. > After I replaced to latest available protoc version 3.6.1 the hive master > branch pom.xml files, The hive compiled without any issues on ARM64 machine. > This Jira ticket is used to propose a patch on Hive mailing list > [https://git.linaro.org/people/naresh.bhat/apache/hive.git/] to update > pom.xml files protobuf version. I will also cherry-pick patches for other > branches v3/3.0/3.1, and create a pull request. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22585: Attachment: HIVE-22585.03.patch > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch, > HIVE-22585.03.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22915) java.lang.NoSuchMethodError: com.google.common.base.Preconditions.checkArgument
[ https://issues.apache.org/jira/browse/HIVE-22915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22915: Summary: java.lang.NoSuchMethodError: com.google.common.base.Preconditions.checkArgument (was: hive is not running.) > java.lang.NoSuchMethodError: > com.google.common.base.Preconditions.checkArgument > --- > > Key: HIVE-22915 > URL: https://issues.apache.org/jira/browse/HIVE-22915 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 2.3.4 > Environment: Ubuntu 16.04 >Reporter: pradeepkumar >Priority: Critical > > Hi Team, > I am Not able to run hive. Getting following error on hive version above 3.X, > i tried all the versions. It is very critical issue.SLF4J: Class path > contains multiple SLF4J bindings. > SLF4J: Found binding in > [jar:file:/home/sreeramadasu/Downloads/hive/lib/log4j-slf4j-impl-2.6.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: Found binding in > [jar:file:/home/sreeramadasu/Downloads/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: See [http://www.slf4j.org/codes.html#multiple_bindings] for an > explanation. > SLF4J: Actual binding is of type > [org.apache.logging.slf4j.Log4jLoggerFactory] > Exception in thread "main" java.lang.NoSuchMethodError: > com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V > at org.apache.hadoop.conf.Configuration.set(Configuration.java:1357) > at org.apache.hadoop.conf.Configuration.set(Configuration.java:1338) > at org.apache.hadoop.mapred.JobConf.setJar(JobConf.java:536) > at org.apache.hadoop.mapred.JobConf.setJarByClass(JobConf.java:554) > at org.apache.hadoop.mapred.JobConf.(JobConf.java:448) > at org.apache.hadoop.hive.conf.HiveConf.initialize(HiveConf.java:4045) > at org.apache.hadoop.hive.conf.HiveConf.(HiveConf.java:4003) > at > org.apache.hadoop.hive.common.LogUtils.initHiveLog4jCommon(LogUtils.java:81) > at org.apache.hadoop.hive.common.LogUtils.initHiveLog4j(LogUtils.java:65) > at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:702) > at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:686) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236) > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22915) hive is not running.
[ https://issues.apache.org/jira/browse/HIVE-22915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041154#comment-17041154 ] David Lavati commented on HIVE-22915: - This is like HIVE-22718 and many other similar issues: You have 2 incompatible versions of guava on your classpath. Maybe the Hadoop/Spark version or something else you're using is not compatible with this Hive version. > hive is not running. > > > Key: HIVE-22915 > URL: https://issues.apache.org/jira/browse/HIVE-22915 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 2.3.4 > Environment: Ubuntu 16.04 >Reporter: pradeepkumar >Priority: Critical > > Hi Team, > I am Not able to run hive. Getting following error on hive version above 3.X, > i tried all the versions. It is very critical issue.SLF4J: Class path > contains multiple SLF4J bindings. > SLF4J: Found binding in > [jar:file:/home/sreeramadasu/Downloads/hive/lib/log4j-slf4j-impl-2.6.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: Found binding in > [jar:file:/home/sreeramadasu/Downloads/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: See [http://www.slf4j.org/codes.html#multiple_bindings] for an > explanation. > SLF4J: Actual binding is of type > [org.apache.logging.slf4j.Log4jLoggerFactory] > Exception in thread "main" java.lang.NoSuchMethodError: > com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V > at org.apache.hadoop.conf.Configuration.set(Configuration.java:1357) > at org.apache.hadoop.conf.Configuration.set(Configuration.java:1338) > at org.apache.hadoop.mapred.JobConf.setJar(JobConf.java:536) > at org.apache.hadoop.mapred.JobConf.setJarByClass(JobConf.java:554) > at org.apache.hadoop.mapred.JobConf.(JobConf.java:448) > at org.apache.hadoop.hive.conf.HiveConf.initialize(HiveConf.java:4045) > at org.apache.hadoop.hive.conf.HiveConf.(HiveConf.java:4003) > at > org.apache.hadoop.hive.common.LogUtils.initHiveLog4jCommon(LogUtils.java:81) > at org.apache.hadoop.hive.common.LogUtils.initHiveLog4j(LogUtils.java:65) > at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:702) > at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:686) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236) > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22585: Attachment: HIVE-22585.02.patch > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HIVE-22475) Update slf4j to 1.7.25
[ https://issues.apache.org/jira/browse/HIVE-22475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati resolved HIVE-22475. - Resolution: Duplicate Superseded by HIVE-22780 for 1.7.30 > Update slf4j to 1.7.25 > -- > > Key: HIVE-22475 > URL: https://issues.apache.org/jira/browse/HIVE-22475 > Project: Hive > Issue Type: Improvement >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > > Druid handler is already there. Updating will allow the entire project to be > on the same version. > https://github.com/apache/hive/blob/38190f3e95752c85188682d8a78d259455e173c2/itests/qtest-druid/pom.xml#L228 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HIVE-22667) ORC version upgrade including ORC-578
[ https://issues.apache.org/jira/browse/HIVE-22667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati resolved HIVE-22667. - Resolution: Duplicate > ORC version upgrade including ORC-578 > - > > Key: HIVE-22667 > URL: https://issues.apache.org/jira/browse/HIVE-22667 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Priority: Major > > This is a preemptive ticket for bumping the ORC version to something that > will include ORC-578: > While working with ORC-578 and hive, the new orc dependency of threeten-extra > caused NoClassDefFoundError while running tez queries containing timestamps, > as some required classes from this dependency didn't get bundled into the fat > jars that are copied to tez clients. > > To resolve this, threeten-extra has to be included in the hive-exec fat jar > in ql/pom.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22807) NoSuchMethodError when running hive or schematool
[ https://issues.apache.org/jira/browse/HIVE-22807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027546#comment-17027546 ] David Lavati commented on HIVE-22807: - * Hadoop 3.2.1 was released in September only, but yes, this compatibility note is a bit too vague * For the bump there were a few attempts, my last impression was that we have to wait for spark 3 or do huge shadings (see HIVE-21569 it would be nice to have some discussion on it though as I might have missed things) * 3.1.0, see https://github.com/apache/hive/blob/rel/release-3.1.2/pom.xml#L150 > NoSuchMethodError when running hive or schematool > - > > Key: HIVE-22807 > URL: https://issues.apache.org/jira/browse/HIVE-22807 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.2 > Environment: jdk1.8.0_241 > hadoop 3.2.1 >Reporter: Reinhard Eilmsteiner >Priority: Major > > After execution of the steps described in > [https://cwiki.apache.org/confluence/display/Hive/GettingStarted?show-miniview > > |https://cwiki.apache.org/confluence/display/Hive/GettingStarted?show-miniview]I > run into the following exception when executing hive and schematool: > Exception in thread "main" java.lang.NoSuchMethodError: > com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V > at org.apache.hadoop.conf.Configuration.set(Configuration.java:1357) > at org.apache.hadoop.conf.Configuration.set(Configuration.java:1338) > at org.apache.hadoop.mapred.JobConf.setJar(JobConf.java:536) > at org.apache.hadoop.mapred.JobConf.setJarByClass(JobConf.java:554) > at org.apache.hadoop.mapred.JobConf.(JobConf.java:448) > at org.apache.hadoop.hive.conf.HiveConf.initialize(HiveConf.java:5141) > at org.apache.hadoop.hive.conf.HiveConf.(HiveConf.java:5104) > at org.apache.hive.beeline.HiveSchemaTool.(HiveSchemaTool.java:96) > at org.apache.hive.beeline.HiveSchemaTool.main(HiveSchemaTool.java:1473) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22807) NoSuchMethodError when running hive or schematool
[ https://issues.apache.org/jira/browse/HIVE-22807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027514#comment-17027514 ] David Lavati commented on HIVE-22807: - Hi [~eilmrein], haddop 3.2.1 has [guava 27|https://github.com/apache/hadoop/blob/rel/release-3.2.1/hadoop-project/pom.xml#L95], while hive due to other dependencies is currently on 19. You'd have to shade usage of one away if you want to use these versions together, however this can prove to be a complex task. > NoSuchMethodError when running hive or schematool > - > > Key: HIVE-22807 > URL: https://issues.apache.org/jira/browse/HIVE-22807 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.2 > Environment: jdk1.8.0_241 > hadoop 3.2.1 >Reporter: Reinhard Eilmsteiner >Priority: Major > > After execution of the steps described in > [https://cwiki.apache.org/confluence/display/Hive/GettingStarted?show-miniview > > |https://cwiki.apache.org/confluence/display/Hive/GettingStarted?show-miniview]I > run into the following exception when executing hive and schematool: > Exception in thread "main" java.lang.NoSuchMethodError: > com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V > at org.apache.hadoop.conf.Configuration.set(Configuration.java:1357) > at org.apache.hadoop.conf.Configuration.set(Configuration.java:1338) > at org.apache.hadoop.mapred.JobConf.setJar(JobConf.java:536) > at org.apache.hadoop.mapred.JobConf.setJarByClass(JobConf.java:554) > at org.apache.hadoop.mapred.JobConf.(JobConf.java:448) > at org.apache.hadoop.hive.conf.HiveConf.initialize(HiveConf.java:5141) > at org.apache.hadoop.hive.conf.HiveConf.(HiveConf.java:5104) > at org.apache.hive.beeline.HiveSchemaTool.(HiveSchemaTool.java:96) > at org.apache.hive.beeline.HiveSchemaTool.main(HiveSchemaTool.java:1473) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at org.apache.hadoop.util.RunJar.run(RunJar.java:323) > at org.apache.hadoop.util.RunJar.main(RunJar.java:236) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22780) Upgrade slf4j version to 1.7.30
[ https://issues.apache.org/jira/browse/HIVE-22780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22780: Attachment: HIVE-22780.01.patch Status: Patch Available (was: Open) > Upgrade slf4j version to 1.7.30 > --- > > Key: HIVE-22780 > URL: https://issues.apache.org/jira/browse/HIVE-22780 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22780.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22475) Update slf4j to 1.7.25
[ https://issues.apache.org/jira/browse/HIVE-22475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024392#comment-17024392 ] David Lavati commented on HIVE-22475: - [~belugabehr] if you don't mind, I'm giving a go at upgrading to 1.7.30 in HIVE-22780 > Update slf4j to 1.7.25 > -- > > Key: HIVE-22475 > URL: https://issues.apache.org/jira/browse/HIVE-22475 > Project: Hive > Issue Type: Improvement >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > > Druid handler is already there. Updating will allow the entire project to be > on the same version. > https://github.com/apache/hive/blob/38190f3e95752c85188682d8a78d259455e173c2/itests/qtest-druid/pom.xml#L228 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22780) Upgrade slf4j version to 1.7.30
[ https://issues.apache.org/jira/browse/HIVE-22780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22780: --- > Upgrade slf4j version to 1.7.30 > --- > > Key: HIVE-22780 > URL: https://issues.apache.org/jira/browse/HIVE-22780 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22653) Remove commons-lang leftovers
[
https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023083#comment-17023083
]
David Lavati commented on HIVE-22653:
-
{quote}it might have been diffed against the wrong branch?
{quote}
It's possible yes, I'm keeping the PR in order and up to date though, as
commons-lang-2 keeps crawling back.
> Remove commons-lang leftovers
> -
>
> Key: HIVE-22653
> URL: https://issues.apache.org/jira/browse/HIVE-22653
> Project: Hive
> Issue Type: Bug
>Reporter: David Lavati
>Assignee: David Lavati
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch,
> HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch,
> HIVE-22653.04.patch, HIVE-22653.04.patch, HIVE-22653.05.patch,
> HIVE-22653.06.patch, HIVE-22653.07.patch, HIVE-22653.07.patch,
> HIVE-22653.08.patch, HIVE-22653.08.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct
> dependency, however a high number of files still refer to commons-lang, which
> is transitively brought in either way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.08.patch > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch, HIVE-22653.04.patch, HIVE-22653.05.patch, > HIVE-22653.06.patch, HIVE-22653.07.patch, HIVE-22653.07.patch, > HIVE-22653.08.patch, HIVE-22653.08.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.08.patch > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch, HIVE-22653.04.patch, HIVE-22653.05.patch, > HIVE-22653.06.patch, HIVE-22653.07.patch, HIVE-22653.07.patch, > HIVE-22653.08.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-21569) Bump guava version to 28.1-jre
[ https://issues.apache.org/jira/browse/HIVE-21569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015018#comment-17015018 ] David Lavati commented on HIVE-21569: - Looks like this will be taken care of in spark 3.0, see SPARK-30272 > Bump guava version to 28.1-jre > -- > > Key: HIVE-21569 > URL: https://issues.apache.org/jira/browse/HIVE-21569 > Project: Hive > Issue Type: Task > Components: Hive >Reporter: Laszlo Pinter >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21569.01.patch, HIVE-21569.02.patch, > HIVE-21569.03.patch, HIVE-21569.04.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Changes required to bump guava to 28.1-jre -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.07.patch > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch, HIVE-22653.04.patch, HIVE-22653.05.patch, > HIVE-22653.06.patch, HIVE-22653.07.patch, HIVE-22653.07.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014473#comment-17014473 ] David Lavati commented on HIVE-22653: - Test failure seems due to HIVE-22722 > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch, HIVE-22653.04.patch, HIVE-22653.05.patch, > HIVE-22653.06.patch, HIVE-22653.07.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work stopped] (HIVE-22307) Upgrade Hadoop version to 3.1.3
[ https://issues.apache.org/jira/browse/HIVE-22307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-22307 stopped by David Lavati. --- > Upgrade Hadoop version to 3.1.3 > --- > > Key: HIVE-22307 > URL: https://issues.apache.org/jira/browse/HIVE-22307 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Attachments: HIVE-22307.patch, HIVE-22307.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22307) Upgrade Hadoop version to 3.1.3
[ https://issues.apache.org/jira/browse/HIVE-22307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22307: Status: In Progress (was: Patch Available) > Upgrade Hadoop version to 3.1.3 > --- > > Key: HIVE-22307 > URL: https://issues.apache.org/jira/browse/HIVE-22307 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Attachments: HIVE-22307.patch, HIVE-22307.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22585) Clean up catalog/db/table name usage
[ https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22585: Attachment: HIVE-22585.01.patch Status: Patch Available (was: Open) > Clean up catalog/db/table name usage > > > Key: HIVE-22585 > URL: https://issues.apache.org/jira/browse/HIVE-22585 > Project: Hive > Issue Type: Sub-task >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available, refactor > Attachments: HIVE-22585.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > This is a followup to HIVE-21198 to address some additional improvement ideas > for the TableName object mentioned in > [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy > usages of db/tablenames, as a number of places still rely on certain state > changes/black magic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22486) Send only accessed columns for masking policies request
[ https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014319#comment-17014319 ] David Lavati commented on HIVE-22486: - Readded 90 with git diff --no-prefix - as 91. Looks like the precommit job is now picking on this, even though I didn't see a related change upstream. > Send only accessed columns for masking policies request > --- > > Key: HIVE-22486 > URL: https://issues.apache.org/jira/browse/HIVE-22486 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 4.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, > HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, > HIVE-22486.90.patch, HIVE-22486.90.patch, HIVE-22486.91.patch, > HIVE-22486.patch, HIVE-22486.patchaddendum > > Time Spent: 1h > Remaining Estimate: 0h > > Currently, we send all columns for masking request, even if they are not > accessed by the given query. We could send only those columns for which the > masking policy will be necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22486) Send only accessed columns for masking policies request
[ https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22486: Attachment: HIVE-22486.91.patch > Send only accessed columns for masking policies request > --- > > Key: HIVE-22486 > URL: https://issues.apache.org/jira/browse/HIVE-22486 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 4.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, > HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, > HIVE-22486.90.patch, HIVE-22486.90.patch, HIVE-22486.91.patch, > HIVE-22486.patch, HIVE-22486.patchaddendum > > Time Spent: 1h > Remaining Estimate: 0h > > Currently, we send all columns for masking request, even if they are not > accessed by the given query. We could send only those columns for which the > masking policy will be necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22486) Send only accessed columns for masking policies request
[ https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22486: --- Assignee: Jesus Camacho Rodriguez (was: David Lavati) > Send only accessed columns for masking policies request > --- > > Key: HIVE-22486 > URL: https://issues.apache.org/jira/browse/HIVE-22486 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 4.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, > HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, > HIVE-22486.90.patch, HIVE-22486.90.patch, HIVE-22486.91.patch, > HIVE-22486.patch, HIVE-22486.patchaddendum > > Time Spent: 1h > Remaining Estimate: 0h > > Currently, we send all columns for masking request, even if they are not > accessed by the given query. We could send only those columns for which the > masking policy will be necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22486) Send only accessed columns for masking policies request
[ https://issues.apache.org/jira/browse/HIVE-22486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22486: --- Assignee: David Lavati (was: Jesus Camacho Rodriguez) > Send only accessed columns for masking policies request > --- > > Key: HIVE-22486 > URL: https://issues.apache.org/jira/browse/HIVE-22486 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 4.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22486.01.patch, HIVE-22486.02.patch, > HIVE-22486.03.patch, HIVE-22486.05.patch, HIVE-22486.06.patch, > HIVE-22486.90.patch, HIVE-22486.90.patch, HIVE-22486.patch, > HIVE-22486.patchaddendum > > Time Spent: 1h > Remaining Estimate: 0h > > Currently, we send all columns for masking request, even if they are not > accessed by the given query. We could send only those columns for which the > masking policy will be necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.07.patch > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch, HIVE-22653.04.patch, HIVE-22653.05.patch, > HIVE-22653.06.patch, HIVE-22653.07.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.06.patch > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch, HIVE-22653.04.patch, HIVE-22653.05.patch, > HIVE-22653.06.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.05.patch > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch, HIVE-22653.04.patch, HIVE-22653.05.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.04.patch > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch, HIVE-22653.04.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Status: In Progress (was: Patch Available) > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.04.patch Status: Patch Available (was: In Progress) > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch, > HIVE-22653.04.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.04.patch Status: Patch Available (was: In Progress) Sorry, now I know that changing testutils/ptest2 needs separate testing as it's not covered in the precommit jobs. The new patch compiles and all testutils/ptest2 tests pass as well except for TestScripts, which is failing on master as well. I can't reopen the PR, but have uploaded the commit there as well, or I can open a new one. > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch, HIVE-22653.04.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-22653 started by David Lavati. --- > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch > > Time Spent: 20m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.03.patch Status: Patch Available (was: In Progress) commons-lang is a banned import now, handled by an enforcer rule > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch, HIVE-22653.03.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Status: In Progress (was: Patch Available) > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.02.patch Status: Patch Available (was: In Progress) > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010606#comment-17010606 ] David Lavati commented on HIVE-22653: - TestGenericUDFInitCap#testInitCap was failing indeed. commons-lang3.WordUtils became deprecated and got moved to commons-text instead. However a regression was introduced there as mentioned in TEXT-175. As a workaround I've introduced all the whitespace chars as delimiters - which matches the original implementation through Character.isWhitespace (except for also enabling non-breaking spaces, see [https://docs.oracle.com/javase/8/docs/api/java/lang/Character.html#isWhitespace-char-]) > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Status: In Progress (was: Patch Available) > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch, > HIVE-22653.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22667) ORC version upgrade including ORC-578
[ https://issues.apache.org/jira/browse/HIVE-22667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001642#comment-17001642 ] David Lavati commented on HIVE-22667: - Also adding ORC-27 as a related ticket, as ORC-578 addreses some issues caused by it. > ORC version upgrade including ORC-578 > - > > Key: HIVE-22667 > URL: https://issues.apache.org/jira/browse/HIVE-22667 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Priority: Major > > This is a preemptive ticket for bumping the ORC version to something that > will include ORC-578: > While working with ORC-578 and hive, the new orc dependency of threeten-extra > caused NoClassDefFoundError while running tez queries containing timestamps, > as some required classes from this dependency didn't get bundled into the fat > jars that are copied to tez clients. > > To resolve this, threeten-extra has to be included in the hive-exec fat jar > in ql/pom.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.01.patch > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch, HIVE-22653.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22304) Upgrade ORC version to 1.6.2
[ https://issues.apache.org/jira/browse/HIVE-22304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22304: Summary: Upgrade ORC version to 1.6.2 (was: Upgrade ORC version to 1.6.0) > Upgrade ORC version to 1.6.2 > > > Key: HIVE-22304 > URL: https://issues.apache.org/jira/browse/HIVE-22304 > Project: Hive > Issue Type: Improvement >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Attachments: HIVE-22304.1.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22656) tried to access method com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator; from class org.apache.hadoop.hive.ql.exec.Fe
[ https://issues.apache.org/jira/browse/HIVE-22656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999009#comment-16999009 ] David Lavati commented on HIVE-22656: - Hi [~markyao], Apache Hive 3.1.2 uses guava 19 (see https://github.com/apache/hive/blob/8190d2be7b7165effa62bd21b7d60ef81fb0e4af/pom.xml#L147 ) Guava has a lot of breaking changes between 14 and 16 as far as I remember, using 14 probably won't work, probably guava 19 will, if you don't have other conflicts. Bumping guava in hive is not an entirely easy task currently, see HIVE-21569. > tried to access method > com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator; > from class org.apache.hadoop.hive.ql.exec.FetchOperator > --- > > Key: HIVE-22656 > URL: https://issues.apache.org/jira/browse/HIVE-22656 > Project: Hive > Issue Type: Bug >Affects Versions: 3.1.2 > Environment: HADOOP 3.2.1 HIVE 3.1.2 guava-28.1-jre >Reporter: yaotailin >Priority: Critical > > (1) I use jdbc way to query a table but get a exception.*tried to access > method > com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator; > from class org.apache.hadoop.hive.ql.exec.FetchOperator* > (2) I try to degraded guava 14.01, I can't run *bin/hiveserver2* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati updated HIVE-22653: Attachment: HIVE-22653.01.patch Status: Patch Available (was: In Progress) > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22653.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-22653 started by David Lavati. --- > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0 > > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22653) Remove commons-lang leftovers
[ https://issues.apache.org/jira/browse/HIVE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Lavati reassigned HIVE-22653: --- > Remove commons-lang leftovers > - > > Key: HIVE-22653 > URL: https://issues.apache.org/jira/browse/HIVE-22653 > Project: Hive > Issue Type: Bug >Reporter: David Lavati >Assignee: David Lavati >Priority: Major > Fix For: 4.0.0 > > > HIVE-7145 removed commons-lang - in favor of commons-lang3 - as a direct > dependency, however a high number of files still refer to commons-lang, which > is transitively brought in either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HIVE-22589) Add storage support for ProlepticCalendar
[
https://issues.apache.org/jira/browse/HIVE-22589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati reassigned HIVE-22589:
---
Assignee: Jesus Camacho Rodriguez (was: David Lavati)
> Add storage support for ProlepticCalendar
> -
>
> Key: HIVE-22589
> URL: https://issues.apache.org/jira/browse/HIVE-22589
> Project: Hive
> Issue Type: Bug
> Components: Avro, ORC, Parquet
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-22589.01.patch, HIVE-22589.patch, HIVE-22589.patch
>
>
> Hive recently moved its processing to the proleptic calendar, which has
> created some issues for users who have dates before 1580 AD.
> I'd propose extending the column vectors for times & dates to encode which
> calendar they are using.
> * create DateColumnVector that extends LongColumnVector
> * add a method to change calendars to both DateColumnVector and
> TimestampColumnVector.
> {code}
> /**
>* Change the calendar to or from proleptic. If the new and old values of
> the flag are the
>* same, nothing is done.
>* useProleptic - set the flag for the proleptic calendar
>* updateData - change the data to match the new value of the flag.
>*/
> void changeCalendar(useProleptic: boolean, updateData: boolean);
> /**
>* Detect whether this data is using the proleptic calendar.
>*/
> boolean usingProlepticCalendar();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HIVE-22589) Add storage support for ProlepticCalendar
[
https://issues.apache.org/jira/browse/HIVE-22589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Lavati updated HIVE-22589:
Attachment: HIVE-22589.01.patch
> Add storage support for ProlepticCalendar
> -
>
> Key: HIVE-22589
> URL: https://issues.apache.org/jira/browse/HIVE-22589
> Project: Hive
> Issue Type: Bug
> Components: Avro, ORC, Parquet
>Reporter: Jesus Camacho Rodriguez
>Assignee: David Lavati
>Priority: Major
> Fix For: 4.0.0, 3.2.0, 3.1.3
>
> Attachments: HIVE-22589.01.patch, HIVE-22589.patch, HIVE-22589.patch
>
>
> Hive recently moved its processing to the proleptic calendar, which has
> created some issues for users who have dates before 1580 AD.
> I'd propose extending the column vectors for times & dates to encode which
> calendar they are using.
> * create DateColumnVector that extends LongColumnVector
> * add a method to change calendars to both DateColumnVector and
> TimestampColumnVector.
> {code}
> /**
>* Change the calendar to or from proleptic. If the new and old values of
> the flag are the
>* same, nothing is done.
>* useProleptic - set the flag for the proleptic calendar
>* updateData - change the data to match the new value of the flag.
>*/
> void changeCalendar(useProleptic: boolean, updateData: boolean);
> /**
>* Detect whether this data is using the proleptic calendar.
>*/
> boolean usingProlepticCalendar();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
