[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058697#comment-17058697 ] Zoltan Haindrich commented on HIVE-16355: - pushed an addendum to fix the header issue; thank you! > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-16355.06.patch, HIVE-16355.1.patch, > HIVE-16355.2.patch, HIVE-16355.2.patch, HIVE-16355.3.patch, > HIVE-16355.4.patch, HIVE-16355.4.patch, HIVE-16355.5.patch > > Time Spent: 10m > Remaining Estimate: 0h > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041114#comment-17041114 ] Ádám Szita commented on HIVE-16355: --- This patch introduced a file which is missing ASF license header - [~kgyrtkirk] can you please fix it? > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-16355.06.patch, HIVE-16355.1.patch, > HIVE-16355.2.patch, HIVE-16355.2.patch, HIVE-16355.3.patch, > HIVE-16355.4.patch, HIVE-16355.4.patch, HIVE-16355.5.patch > > Time Spent: 10m > Remaining Estimate: 0h > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038867#comment-17038867 ] Miklos Gergely commented on HIVE-16355: --- +1 > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Attachments: HIVE-16355.06.patch, HIVE-16355.1.patch, > HIVE-16355.2.patch, HIVE-16355.2.patch, HIVE-16355.3.patch, > HIVE-16355.4.patch, HIVE-16355.4.patch, HIVE-16355.5.patch > > Time Spent: 10m > Remaining Estimate: 0h > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035087#comment-17035087 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12993118/HIVE-16355.06.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17990 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20569/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20569/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20569/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12993118 - PreCommit-HIVE-Build > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Labels: pull-request-available > Attachments: HIVE-16355.06.patch, HIVE-16355.1.patch, > HIVE-16355.2.patch, HIVE-16355.2.patch, HIVE-16355.3.patch, > HIVE-16355.4.patch, HIVE-16355.4.patch, HIVE-16355.5.patch > > Time Spent: 10m > Remaining Estimate: 0h > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035076#comment-17035076 ] Hive QA commented on HIVE-16355: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 59s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 35s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 44s{color} | {color:blue} service in master has 51 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 30s{color} | {color:blue} jdbc in master has 16 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 35s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 33s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} service: The patch generated 1 new + 23 unchanged - 2 fixed = 24 total (was 25) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} jdbc: The patch generated 3 new + 28 unchanged - 7 fixed = 31 total (was 35) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 10s{color} | {color:red} root: The patch generated 4 new + 51 unchanged - 9 fixed = 55 total (was 60) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 24s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 58m 1s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile xml | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-20569/dev-support/hive-personality.sh | | git revision | master / 8f46884 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20569/yetus/diff-checkstyle-service.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20569/yetus/diff-checkstyle-jdbc.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20569/yetus/diff-checkstyle-root.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-20569/yetus/patch-asflicense-problems.txt | | modules | C: service jdbc . U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-20569/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL:
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169295#comment-16169295 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12885123/HIVE-16355.5.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 11035 tests executed *Failed tests:* {noformat} TestAccumuloCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=230) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_view] (batchId=39) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask_hash] (batchId=28) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=156) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[drop_table_failure2] (batchId=89) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=234) org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver (batchId=241) org.apache.hadoop.hive.ql.TestAcidOnTez.testCtasTezUnion (batchId=215) org.apache.hadoop.hive.ql.TestAcidOnTez.testNonStandardConversion01 (batchId=215) org.apache.hive.jdbc.TestJdbcWithMiniHS2.testHttpRetryOnServerIdleTimeout (batchId=227) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6850/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6850/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6850/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 11 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12885123 - PreCommit-HIVE-Build > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch, > HIVE-16355.4.patch, HIVE-16355.5.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151745#comment-16151745 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12885123/HIVE-16355.5.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 11028 tests executed *Failed tests:* {noformat} TestThriftCLIServiceWithHttp - did not produce a TEST-*.xml file (likely timed out) (batchId=223) TestTxnCommandsBase - did not produce a TEST-*.xml file (likely timed out) (batchId=280) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=61) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[dynamic_rdd_cache] (batchId=170) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning] (batchId=169) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=100) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=234) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6662/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6662/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6662/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12885123 - PreCommit-HIVE-Build > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch, > HIVE-16355.4.patch, HIVE-16355.5.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151701#comment-16151701 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12885122/HIVE-16355.4.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6659/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6659/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6659/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2017-09-03 06:33:41.435 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-6659/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2017-09-03 06:33:41.438 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at e3c71b0 HIVE-17405: HoS DPP ConstantPropagate should use ConstantPropagateOption.SHORTCUT (Sahil Takiar, reviewed by Rui Li) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at e3c71b0 HIVE-17405: HoS DPP ConstantPropagate should use ConstantPropagateOption.SHORTCUT (Sahil Takiar, reviewed by Rui Li) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2017-09-03 06:33:42.386 + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: patch failed: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:20 error: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java: patch does not apply The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12885122 - PreCommit-HIVE-Build > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch, > HIVE-16355.4.patch, HIVE-16355.5.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078679#comment-16078679 ] Vaibhav Gumashta commented on HIVE-16355: - Thanks for looking into this [~kgyrtkirk]. I agree, for now using the ServiceLoader approach might be an overkill since there is only one implementation. Added some minor comments on rb. > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075036#comment-16075036 ] Zoltan Haindrich commented on HIVE-16355: - [~thejas], [~vgumashta], [~hagleitn] could you please take a look? > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034761#comment-16034761 ] Zoltan Haindrich commented on HIVE-16355: - [~thejas] [~vgumashta] could you please take a look? > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025239#comment-16025239 ] Zoltan Haindrich commented on HIVE-16355: - [~thejas] could you please take a look? > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013252#comment-16013252 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12868377/HIVE-16355.4.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10717 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[table_nonprintable] (batchId=140) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=144) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3] (batchId=97) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] (batchId=97) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5290/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5290/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5290/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12868377 - PreCommit-HIVE-Build > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002174#comment-16002174 ] Zoltan Haindrich commented on HIVE-16355: - [~vgumashta], [~thejas]: ping > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993786#comment-15993786 ] Zoltan Haindrich commented on HIVE-16355: - [~vgumashta], [~thejas]: could you please take a look at these changes? > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982750#comment-15982750 ] Peter Vary commented on HIVE-16355: --- +1 (Non binding) > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974366#comment-15974366 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12863963/HIVE-16355.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10567 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver (batchId=101) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_count_distinct] (batchId=109) org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4755/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4755/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4755/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12863963 - PreCommit-HIVE-Build > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974167#comment-15974167 ] Zoltan Haindrich commented on HIVE-16355: - [~pvary] I've looked into it...this is something which seemed like a good idea when I've written the the patch...but it wouldn't be any better than this; doing only this using a serviceloader seems like much more like an overkill; than a real good use - since there shouldn't be any users who will implement it - because of this the most logical way to handle the case when it detects that there are multiple implementations available: would be to throw an exception; because that's currently an unexpected situation - however users loading service more than once may bump into it...which might seem awkward... anyway: it seems to me that adding the neccessary interfaces/other stuff would just complicate things without adding valueI may possibly come back to it later when I've seen more: if I see that it could add real value, I will do it. > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968710#comment-15968710 ] Peter Vary commented on HIVE-16355: --- Hi [~kgyrtkirk], How complicated would be to use serviceloader as stated in the comment? I would prefer that solution above using reflection. Thanks, Peter > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968133#comment-15968133 ] Zoltan Haindrich commented on HIVE-16355: - failures are not related > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962289#comment-15962289 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12862626/HIVE-16355.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10561 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency] (batchId=234) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] (batchId=234) org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=221) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4622/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4622/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4622/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12862626 - PreCommit-HIVE-Build > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953735#comment-15953735 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12861727/HIVE-16355.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10565 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_select] (batchId=148) org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=174) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4517/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4517/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4517/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12861727 - PreCommit-HIVE-Build > Service: embedded mode should only be available if service is loaded onto the > classpath > --- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16355) Service: embedded mode should only be available if service is loaded onto the classpath
[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953390#comment-15953390 ] Hive QA commented on HIVE-16355: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12861696/HIVE-16355.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4515/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4515/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4515/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2017-04-03 12:28:43.294 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-4515/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2017-04-03 12:28:43.297 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 5e84e49 HIVE-16290: Stats: StatsRulesProcFactory::evaluateComparator estimates are wrong when minValue == filterValue (Rajesh Balamohan, Gopal V reviewed by Gopal V) + git clean -f -d Removing ql/src/java/org/apache/hadoop/hive/ql/parse/repl/ Removing ql/src/test/org/apache/hadoop/hive/ql/parse/repl/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 5e84e49 HIVE-16290: Stats: StatsRulesProcFactory::evaluateComparator estimates are wrong when minValue == filterValue (Rajesh Balamohan, Gopal V reviewed by Gopal V) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2017-04-03 12:28:44.501 + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Going to apply patch with: patch -p0 patching file jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java patching file service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java patching file service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java patching file service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/metastore/target/generated-sources/antlr3/org/apache/hadoop/hive/metastore/parser/FilterParser.java does not exist: must build /data/hiveptest/working/apache-github-source-source/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g org/apache/hadoop/hive/metastore/parser/Filter.g DataNucleus Enhancer (version 4.1.17) for API "JDO" DataNucleus Enhancer : Classpath >> /usr/share/maven/boot/plexus-classworlds-2.x.jar ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDatabase ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MFieldSchema ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MType ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTable ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MConstraint ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MSerDeInfo ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MOrder ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MColumnDescriptor ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MStringList ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MStorageDescriptor ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartition ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MIndex