[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236086#comment-16236086
 ] 

ASF GitHub Bot commented on HIVE-17812:
---

Github user alanfgates closed the pull request at:

https://github.com/apache/hive/pull/261


> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Standalone Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.0.0
>
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, 
> HIVE-17812.4.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235202#comment-16235202
 ] 

Hive QA commented on HIVE-17812:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12895310/HIVE-17812.4.patch

{color:green}SUCCESS:{color} +1 due to 9 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 11349 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
 (batchId=62)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] 
(batchId=156)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc]
 (batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] 
(batchId=111)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut 
(batchId=206)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints 
(batchId=223)
org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerHighShuffleBytes 
(batchId=231)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7591/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7591/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7591/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12895310 - PreCommit-HIVE-Build

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, 
> HIVE-17812.4.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Vihang Karajgaonkar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234313#comment-16234313
 ] 

Vihang Karajgaonkar commented on HIVE-17812:


Thanks [~alangates] that seems reasonable to me. Thanks for incorporating the 
suggested changes. The rest of the changes look fine to me. +1

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Alan Gates (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234080#comment-16234080
 ] 

Alan Gates commented on HIVE-17812:
---

How about the following:

In this patch I change {{IHMSHander getHandler()}} to {{IHMSHandler 
getIHMSHandler()}}.  In the next patch (which will include HiveMetaStore.java 
and thus HMSHandler) I will add back {{HMSHandler getHandler()}} and mark it 
deprecated as you suggest.  I don't need to add back the constructor since only 
the metastore should be constructing these events.  I will do this in the next 
patch to avoid pulling in HiveMetaStore.java into this already large (and 
mostly reviewed) patch.

As for HMSHandler being public, you are correct it's not.  In fact IHMSHandler 
is marked private.  This is weird given that a public interface is handing out 
references to them.  I propose as part of this change we move IHMSHandler to 
public/evolving, noting that it is used by listeners, and specifically mark 
HMSHandler as private.

I don't believe any of these changes will require us to recompile clients.  But 
any listeners who call {{getHandler().getHiveConf()}} will have to be 
recompiled.

Seem reasonable?

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Vihang Karajgaonkar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227779#comment-16227779
 ] 

Vihang Karajgaonkar commented on HIVE-17812:


Thanks for the response [~alangates] Sorry if I am missing something obvious. 
Is HMSHandler a public API? I don't see it annotated with @Public. If it is not 
a public API I don't see a reason why changing {{getHiveConf()}} to 
{{getConf()}} will be backwards incompatible. Are there other changes as well 
to the public API other than {{getConf()}}? I agree that if there are going to 
be backwards incompatible changes coming later which would need recompile of 
all HMSClients then there is no point in fixing this as well. 

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Alan Gates (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227371#comment-16227371
 ] 

Alan Gates commented on HIVE-17812:
---

Yes and no.  To do that I'll have to move HiveMetaStore along with this patch.  
That's fine, as I'll have to move it anyway.

But that patch will include changes to HMSHandler that will also be backward 
incompatible.  The getHiveConf method will be removed and replaced by getConf.  
This can't be avoided because HMSHandler will no longer have a HiveConf object 
to return and can't even reference HiveConf since standalone-metastore doesn't 
depend on common.  So, we're just kicking the can down the road.  I suspect all 
listeners will be broken without a shim layer whichever way we go.

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Vihang Karajgaonkar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227161#comment-16227161
 ] 

Vihang Karajgaonkar commented on HIVE-17812:


Hi [~alangates] Do you think we can alleviate the compatibility concerns a bit 
by deprecating the constructor which uses {{HMSHandler}} and introducing a new 
constructor instead of modifying the existing one? We can also do something 
similar with {{getHandler()}} method by deprecating it and introducing a new 
method called {{getIHMSHandler()}} which returns IHMSHandler. Do you see 
problems with this approach?

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Vihang Karajgaonkar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216009#comment-16216009
 ] 

Vihang Karajgaonkar commented on HIVE-17812:


Hi [~alangates] I did a first pass on the patch and added some comments in the 
github review. I went over your comment regarding backwards incompatibility 
above after I submitted the review comments so some of them might seem 
redundant.

bq. Is this avoidable? Yes, I could move events and listeners in a bigger patch 
along with HiveMetaStore. However, other changes are going to break listeners 
and events anyway. Namely, the change from HiveConf -> Conf (which is not 
avoidable). Also, if we do split the metastore into a separate TLP in the 
future it will change class names, which will also obviously impact 
implementations of listener.
We should look into what it will take to build a shim that would support 
existing listeners. This would need to live in the metastore module rather than 
standalone-metastore, since it will need to reference HiveConf.

The change from {{HMSHandler}} to {{IHMSHandler}} in the events makes sense to 
me from design point of view. But I think it is unclear if it is worth breaking 
backwards compatibility. I am not sure I understand why it would have broken 
the compatibility because of HiveConf -> Conf change. Do the events use conf 
object? Based on what I looked (I didn't look at all the events but few sample 
of the important events) I didn't see conf being used. If we change the class 
names, we might still be able to provide some shims layer to preserve 
compatibility with respect to the public API if we don't modify the method 
signatures. What do you think?


> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208183#comment-16208183
 ] 

Hive QA commented on HIVE-17812:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12892650/HIVE-17812.3.patch

{color:green}SUCCESS:{color} +1 due to 9 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 11276 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan]
 (batchId=163)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] 
(batchId=110)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_notin] 
(batchId=133)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_scalar] 
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_select] 
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_views] 
(batchId=108)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query16] 
(batchId=243)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query94] 
(batchId=243)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] 
(batchId=241)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query16] 
(batchId=241)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query94] 
(batchId=241)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut 
(batchId=204)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7353/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7353/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7353/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 12 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12892650 - PreCommit-HIVE-Build

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.3.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206789#comment-16206789
 ] 

Hive QA commented on HIVE-17812:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12892468/HIVE-17812.2.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7334/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7334/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7334/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2017-10-16 23:46:05.347
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-7334/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2017-10-16 23:46:05.349
+ cd apache-github-source-source
+ git fetch origin
>From https://github.com/apache/hive
   599a74f..45b9b8d  master -> origin/master
+ git reset --hard HEAD
HEAD is now at 599a74f HIVE-17391 Compaction fails if there is an empty value 
in tblproperties (Steve Yeom via Eugene Koifman)
+ git clean -f -d
Removing 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveSqlSumEmptyIsZeroAggFunction.java
Removing 
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEpochMilli.java
Removing ql/src/test/queries/clientpositive/timestamptz_3.q
Removing ql/src/test/results/clientpositive/timestamptz_3.q.out
Removing standalone-metastore/src/gen/org/
+ git checkout master
Already on 'master'
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.
  (use "git pull" to update your local branch)
+ git reset --hard origin/master
HEAD is now at 45b9b8d HIVE-16688 Make sure Alter Table to set transaction=true 
acquires X lock (Eugene Koifman, reviewed by Alan Gates)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2017-10-16 23:46:06.919
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: patch failed: 
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java:19
error: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java: 
patch does not apply
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12892468 - PreCommit-HIVE-Build

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Alan Gates (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206744#comment-16206744
 ] 

Alan Gates commented on HIVE-17812:
---

To clarify my comments above, the biggest compatibility issue is in 
ListenerEvent, where I changed the constructor to take IHMSHandler rather than 
HMSHandler.  Since every event inherits from ListenerEvent, this trickles down 
to all of the events.  Also, in a future patch HMSHandler.getHiveConf will have 
to be removed since HMSHandler will no longer have access to HiveConf once it 
moves to standalone-metastore.

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
> Attachments: HIVE-17812.2.patch, HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205063#comment-16205063
 ] 

Hive QA commented on HIVE-17812:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12892227/HIVE-17812.patch

{color:green}SUCCESS:{color} +1 due to 9 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 11233 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_bucket_sort] 
(batchId=80)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] 
(batchId=145)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan]
 (batchId=163)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] 
(batchId=110)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_notin] 
(batchId=133)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_scalar] 
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_select] 
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_views] 
(batchId=108)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query16] 
(batchId=243)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query94] 
(batchId=243)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] 
(batchId=241)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query16] 
(batchId=241)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query94] 
(batchId=241)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut 
(batchId=204)
org.apache.hadoop.hive.ql.TestTxnCommands.testTimeOutReaper (batchId=284)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7314/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7314/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7314/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 15 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12892227 - PreCommit-HIVE-Build

> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
> Attachments: HIVE-17812.patch
>
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17812) Move remaining classes that HiveMetaStore depends on

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204785#comment-16204785
 ] 

ASF GitHub Bot commented on HIVE-17812:
---

GitHub user alanfgates opened a pull request:

https://github.com/apache/hive/pull/261

HIVE-17812



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alanfgates/hive hive17812

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit 15ce382059ee985ece8621bb9849776184d4805b
Author: Alan Gates 
Date:   2017-08-28T21:18:53Z

Moved EventMessage and friends.

commit eb6e31f25d3af16e8d1f9ebe88f16e25bcb56eeb
Author: Alan Gates 
Date:   2017-08-28T21:39:27Z

Moved JSON message implementations.

commit 8150c599e49373b0d3e7d55423b653c2d1757fc9
Author: Alan Gates 
Date:   2017-08-28T23:56:09Z

Moved RetryingHMSHandler

commit ab945374b3ddb9fdd1e20c06c99c8154434295db
Author: Alan Gates 
Date:   2017-08-30T17:35:31Z

Moved events.  As a part of this I had to change events and listeners to 
take IHMSHandler interface rather than a direct reference to HMSHandler.  I 
believe this is an improvement as it gives a clean separation between the 
interface and the implementation.  But it will break existing listeners.  As 
part of this I had to add a few methods to IHMSHandler.  We may need to 
continue to add methods here to support existing external listeners.

commit fdde7842526d0ba7871333de72c5e38e3a2c2a58
Author: Alan Gates 
Date:   2017-08-31T18:00:44Z

Moved the listeners.  Also moved one event that either I missed or that 
snuck in after I moved the others.

commit 5cb1950fc2f91dc412e897c952e076348248d2f6
Author: Alan Gates 
Date:   2017-08-31T20:02:13Z

Moved AlterHandler and HiveAlterHandler.  Also did a partial cleanup of 
MetaStoreUtils.  Need to do more.

commit 7a7dde55e60a0b09db22becd7f839c9eaa25d0bd
Author: Alan Gates 
Date:   2017-09-01T19:11:50Z

Converted extenders of HouseKeeperService to instead implement 
RunnableConfigurable and use the general ThreadPool.

commit 5506814216dc212b0e79eefc458ec841dc2ca123
Author: Alan Gates 
Date:   2017-09-01T22:03:42Z

Moved FileMetadataManager.

commit 446be8e95a0399185ea9d23362bd878d325d0f63
Author: Alan Gates 
Date:   2017-10-14T19:02:27Z

Fixes after the rebase.  Also fixed acid house keeping threads to only open 
txn handler once instead of on every run.




> Move remaining classes that HiveMetaStore depends on 
> -
>
> Key: HIVE-17812
> URL: https://issues.apache.org/jira/browse/HIVE-17812
> Project: Hive
>  Issue Type: Sub-task
>  Components: Metastore
>Reporter: Alan Gates
>Assignee: Alan Gates
>  Labels: pull-request-available
>
> There are several remaining pieces that need moved before we can move 
> HiveMetaStore itself.  These include NotificationListener and 
> implementations, Events, AlterHandler, and a few other miscellaneous pieces.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)