[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626595#comment-16626595 ] Sergey Shelukhin commented on HIVE-20551: - -1 this patch for ints is unnecessary and probably introduces some overhead. It's impossible to do string injection via an integer. Can this be removed from integral type lists? > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch, > HIVE-20551.06.patch, HIVE-20551.07.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626542#comment-16626542 ] Daniel Dai commented on HIVE-20551: --- mm_dp.q fail because it is added right after HIVE-18778. HIVE-18778 breaks the golden file of HIVE-20620. I will regenerate mm_dp.q.out. > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch, > HIVE-20551.06.patch, HIVE-20551.07.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626394#comment-16626394
]
Hive QA commented on HIVE-20551:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12941036/HIVE-20551.07.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14996 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_dp]
(batchId=155)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14021/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14021/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14021/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12941036 - PreCommit-HIVE-Build
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch,
> HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch,
> HIVE-20551.06.patch, HIVE-20551.07.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626271#comment-16626271
]
Hive QA commented on HIVE-20551:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
13s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 17s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-14021/dev-support/hive-personality.sh
|
| git revision | master / 672755d |
| Default Java | 1.8.0_111 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14021/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14021/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-14021/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch,
> HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch,
> HIVE-20551.06.patch, HIVE-20551.07.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624844#comment-16624844
]
Hive QA commented on HIVE-20551:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12940796/HIVE-20551.06.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14993 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13982/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13982/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13982/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12940796 - PreCommit-HIVE-Build
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch,
> HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch,
> HIVE-20551.06.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624827#comment-16624827
]
Hive QA commented on HIVE-20551:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13982/dev-support/hive-personality.sh
|
| git revision | master / cdba00c |
| Default Java | 1.8.0_111 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13982/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13982/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13982/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch,
> HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch,
> HIVE-20551.06.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619895#comment-16619895
]
Hive QA commented on HIVE-20551:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12940159/HIVE-20551.05.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14976 tests
executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testKillQuery (batchId=251)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13890/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13890/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13890/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12940159 - PreCommit-HIVE-Build
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch,
> HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619837#comment-16619837
]
Hive QA commented on HIVE-20551:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13890/dev-support/hive-personality.sh
|
| git revision | master / 8ebde04 |
| Default Java | 1.8.0_111 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13890/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13890/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13890/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch,
> HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617956#comment-16617956 ] Sergey Shelukhin commented on HIVE-20551: - The IN statements constructed in this manner always use integers afair, so there's nothing that can be injected. Only the IN (string...) statements should be affected (if any). > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch, HIVE-20551.04.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617708#comment-16617708
]
Hive QA commented on HIVE-20551:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12939935/HIVE-20551.04.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13858/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13858/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13858/
Messages:
{noformat}
This message was trimmed, see log for full details
error: patch failed:
ql/src/test/results/clientpositive/spark/vectorization_part_project.q.out:69
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/vectorization_part_project.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out:1232
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/vectorized_case.q.out:314
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/vectorized_case.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/vectorized_mapjoin.q.out:102
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/vectorized_mapjoin.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out:154
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/vectorized_timestamp_funcs.q.out:258
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/spark/vectorized_timestamp_funcs.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/spark/windowing.q.out:1856
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/spark/windowing.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/stat_estimate_drill.q.out:84
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/stat_estimate_drill.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/stat_estimate_related_col.q.out:89
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/stat_estimate_related_col.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out:324
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out:97
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out:353
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/tez/explainanalyze_4.q.out:338
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/tez/explainanalyze_4.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/udtf_json_tuple.q.out:189
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/udtf_json_tuple.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/udtf_parse_url_tuple.q.out:208
Falling back to three-way merge...
Applied patch to
'ql/src/test/results/clientpositive/udtf_parse_url_tuple.q.out' cleanly.
error: patch failed: ql/src/test/results/clientpositive/union_null.q.out:6
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/union_null.q.out' cleanly.
error: patch failed: ql/src/test/results/clientpositive/union_offcbo.q.out:281
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/union_offcbo.q.out'
cleanly.
error: patch failed: ql/src/test/results/clientpositive/union_ppr.q.out:45
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/union_ppr.q.out' cleanly.
error: patch failed:
ql/src/test/results/clientpositive/union_remove_6_subq.q.out:525
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/union_remove_6_subq.q.out'
cleanly.
error: patch failed:
ql/src/test/results/clientpositive/update_all_partitioned.q.out:53
Falling back to three-way merge...
Applied patch to
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616863#comment-16616863
]
Hive QA commented on HIVE-20551:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12939881/HIVE-20551.03.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13841/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13841/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13841/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-09-16 19:12:02.938
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-13841/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-09-16 19:12:02.942
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at a37827e HIVE-18908: FULL OUTER JOIN to MapJoin (Matt McCline,
reviewed by Teddy Choi)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at a37827e HIVE-18908: FULL OUTER JOIN to MapJoin (Matt McCline,
reviewed by Teddy Choi)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-09-16 19:12:03.750
+ rm -rf ../yetus_PreCommit-HIVE-Build-13841
+ mkdir ../yetus_PreCommit-HIVE-Build-13841
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-13841
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-13841/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
Going to apply patch with: git apply -p0
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc5440930319684051664.exe, --version]
libprotoc 2.5.0
protoc-jar: executing: [/tmp/protoc5440930319684051664.exe,
-I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore,
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources,
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator Version 3.5.2
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process
(process-resource-bundles) on project hive-pre-upgrade: Execution
process-resource-bundles of goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process failed.
ConcurrentModificationException -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hive-pre-upgrade
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-13841
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12939881 - PreCommit-HIVE-Build
> Create PreparedStatement query dynamically when IN clause is used
> -
>
>
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616266#comment-16616266
]
Hive QA commented on HIVE-20551:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12939694/HIVE-20551.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14940 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13802/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13802/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13802/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12939694 - PreCommit-HIVE-Build
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616261#comment-16616261
]
Hive QA commented on HIVE-20551:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13802/dev-support/hive-personality.sh
|
| git revision | master / 08d9083 |
| Default Java | 1.8.0_111 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13802/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13802/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13802/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614540#comment-16614540
]
Hive QA commented on HIVE-20551:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12939551/HIVE-20551.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 972 failed/errored test(s), 14939 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[buckets]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[create_like]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[import_addpartition_blobstore_to_blobstore]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[import_addpartition_blobstore_to_local]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[import_addpartition_blobstore_to_warehouse]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[import_addpartition_local_to_blobstore]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[import_blobstore_to_blobstore]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[import_blobstore_to_local]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[import_blobstore_to_warehouse]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[import_local_to_blobstore]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_empty_into_blobstore]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_into_dynamic_partitions]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions_merge_move]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions_merge_only]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[insert_overwrite_dynamic_partitions_move_only]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[join]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[load_data]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[orc_buckets]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[orc_format_part]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[orc_nonstd_partitions_loc]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[parquet_buckets]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[parquet_format_part]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[parquet_nonstd_partitions_loc]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[rcfile_buckets]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[rcfile_format_part]
(batchId=267)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[rcfile_nonstd_partitions_loc]
(batchId=267)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_insert_overwrite]
(batchId=52)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats3] (batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats4] (batchId=65)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_stats] (batchId=41)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_subquery]
(batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_table_stats]
(batchId=56)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_vectorization_partition]
(batchId=77)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[add_part_multiple]
(batchId=74)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter2] (batchId=10)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter3] (batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter5] (batchId=44)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alterColumnStatsPart]
(batchId=92)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_char2] (batchId=39)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge] (batchId=28)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge_2]
(batchId=43)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge_2_orc]
(batchId=79)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge_3]
(batchId=84)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_merge_stats]
(batchId=64)
[jira] [Commented] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[
https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614499#comment-16614499
]
Hive QA commented on HIVE-20551:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
13s{color} | {color:red} metastore-server in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
14s{color} | {color:red} metastore-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13776/dev-support/hive-personality.sh
|
| git revision | master / 35f86c7 |
| Default Java | 1.8.0_111 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13776/yetus/branch-findbugs-standalone-metastore_metastore-server.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13776/yetus/patch-findbugs-standalone-metastore_metastore-server.txt
|
| modules | C: standalone-metastore/metastore-server U:
standalone-metastore/metastore-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13776/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Create PreparedStatement query dynamically when IN clause is used
> -
>
> Key: HIVE-20551
> URL: https://issues.apache.org/jira/browse/HIVE-20551
> Project: Hive
> Issue Type: Bug
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-20551.01.patch
>
>
> In the MetaStoreDirectSql class when IN clause is used, the query statement
> is created via string concatenation.
> Since JDBC API allows only one literal for one “?” parameter,
> PreparedStatement doesn’t work for IN clause queries. To create the
> PreparedStatement query dynamically based on the size of the elements in IN
> clause, the makeParams() should be used instead of concatenation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
