[jira] [Commented] (HIVE-21878) Metric for AM to show whether it is currently running a DAG

2019-06-26 Thread Peter Vary (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873108#comment-16873108
 ] 

Peter Vary commented on HIVE-21878:
---

[~jdere]: Thanks for the patch!

Few minor comments:
 * Probably it would be better to use gauge instead of counter 
([https://copperegg.zendesk.com/hc/en-us/articles/214635123-Data-types-for-custom-metrics-gauges-vs-counters])
 * Maybe accidentally you changed to '*' based import.

Other than that LGTM.

Thanks,

Peter

> Metric for AM to show whether it is currently running a DAG
> ---
>
> Key: HIVE-21878
> URL: https://issues.apache.org/jira/browse/HIVE-21878
> Project: Hive
>  Issue Type: Bug
>  Components: Tez
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21878.1.patch, HIVE-21878.1.patch
>
>
> Add a basic gauge metric to indicate whether a Tez AM is currently running a 
> DAG for a Hive query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21878) Metric for AM to show whether it is currently running a DAG

2019-06-26 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873038#comment-16873038
 ] 

Hive QA commented on HIVE-21878:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12972904/HIVE-21878.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16340 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17745/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17745/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17745/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12972904 - PreCommit-HIVE-Build

> Metric for AM to show whether it is currently running a DAG
> ---
>
> Key: HIVE-21878
> URL: https://issues.apache.org/jira/browse/HIVE-21878
> Project: Hive
>  Issue Type: Bug
>  Components: Tez
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21878.1.patch, HIVE-21878.1.patch
>
>
> Add a basic gauge metric to indicate whether a Tez AM is currently running a 
> DAG for a Hive query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21878) Metric for AM to show whether it is currently running a DAG

2019-06-26 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872998#comment-16872998
 ] 

Hive QA commented on HIVE-21878:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
23s{color} | {color:blue} llap-tez in master has 17 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
10s{color} | {color:red} llap-tez: The patch generated 1 new + 77 unchanged - 0 
fixed = 78 total (was 77) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 43s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17745/dev-support/hive-personality.sh
 |
| git revision | master / 967a1cc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17745/yetus/diff-checkstyle-llap-tez.txt
 |
| modules | C: llap-tez U: llap-tez |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17745/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Metric for AM to show whether it is currently running a DAG
> ---
>
> Key: HIVE-21878
> URL: https://issues.apache.org/jira/browse/HIVE-21878
> Project: Hive
>  Issue Type: Bug
>  Components: Tez
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21878.1.patch, HIVE-21878.1.patch
>
>
> Add a basic gauge metric to indicate whether a Tez AM is currently running a 
> DAG for a Hive query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21878) Metric for AM to show whether it is currently running a DAG

2019-06-14 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864606#comment-16864606
 ] 

Hive QA commented on HIVE-21878:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12971854/HIVE-21878.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16154 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTablesBootstrap.testBootstrapAcidTablesDuringIncrementalWithConcurrentWrites
 (batchId=246)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17587/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17587/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17587/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12971854 - PreCommit-HIVE-Build

> Metric for AM to show whether it is currently running a DAG
> ---
>
> Key: HIVE-21878
> URL: https://issues.apache.org/jira/browse/HIVE-21878
> Project: Hive
>  Issue Type: Bug
>  Components: Tez
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21878.1.patch
>
>
> Add a basic gauge metric to indicate whether a Tez AM is currently running a 
> DAG for a Hive query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21878) Metric for AM to show whether it is currently running a DAG

2019-06-14 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864595#comment-16864595
 ] 

Hive QA commented on HIVE-21878:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
27s{color} | {color:blue} llap-tez in master has 17 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
12s{color} | {color:red} llap-tez: The patch generated 1 new + 77 unchanged - 0 
fixed = 78 total (was 77) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 53s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17587/dev-support/hive-personality.sh
 |
| git revision | master / c6a2d79 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17587/yetus/diff-checkstyle-llap-tez.txt
 |
| modules | C: llap-tez U: llap-tez |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17587/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Metric for AM to show whether it is currently running a DAG
> ---
>
> Key: HIVE-21878
> URL: https://issues.apache.org/jira/browse/HIVE-21878
> Project: Hive
>  Issue Type: Bug
>  Components: Tez
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21878.1.patch
>
>
> Add a basic gauge metric to indicate whether a Tez AM is currently running a 
> DAG for a Hive query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)