[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885963#comment-16885963 ] Zoltan Haindrich commented on HIVE-21980: - findbugs is looking into the antlr generated code; antlr doesnt show any warning > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch, > HIVE-21980.02.patch, HIVE-21980.03.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885431#comment-16885431 ] Vineet Garg commented on HIVE-21980: LGTM. I am wondering why FindBugs is complaining about Dead store in generated code. Does ANTLR also show warning while building? > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch, > HIVE-21980.02.patch, HIVE-21980.03.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885090#comment-16885090 ] Zoltan Haindrich commented on HIVE-21980: - [~vgarg], [~jcamachorodriguez] Could you please take a look? > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch, > HIVE-21980.02.patch, HIVE-21980.03.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885016#comment-16885016 ] Hive QA commented on HIVE-21980: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12974682/HIVE-21980.03.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16660 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18028/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18028/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18028/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12974682 - PreCommit-HIVE-Build > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch, > HIVE-21980.02.patch, HIVE-21980.03.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884959#comment-16884959 ] Hive QA commented on HIVE-21980: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 1s{color} | {color:blue} ql in master has 2253 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 41s{color} | {color:red} ql: The patch generated 3 new + 4 unchanged - 2 fixed = 7 total (was 6) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 18s{color} | {color:red} ql generated 9 new + 2240 unchanged - 13 fixed = 2249 total (was 2253) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 1s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Dead store to LPAREN29 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource() At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource() At HiveParser_FromClauseParser.java:[line 1856] | | | Dead store to RPAREN31 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource() At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource() At HiveParser_FromClauseParser.java:[line 1863] | | | Dead store to LPAREN47 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr() At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr() At HiveParser_FromClauseParser.java:[line 2279] | | | Dead store to RPAREN49 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr() At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr() At HiveParser_FromClauseParser.java:[line 2286] | | | Should org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA14 be a _static_ inner class? At HiveParser_FromClauseParser.java:inner class? At HiveParser_FromClauseParser.java:[lines 8657-8670] | | | Dead store to LA21_31 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA21.specialStateTransition(int, IntStream) At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA21.specialStateTransition(int, IntStream) At HiveParser_FromClauseParser.java:[line 8867] | | | Dead store to LA24_31 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA24.specialStateTransition(int, IntStream) At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA24.specialStateTransition(int, IntStream) At HiveParser_FromClauseParser.java:[line 9080] | | | Should org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA39 be a _static_ inner class? At HiveParser_FromClauseParser.java:inner class? At HiveParser_FromClauseParser.java:[lines 9368-9381] | | | Should
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884145#comment-16884145 ] Hive QA commented on HIVE-21980: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12974508/HIVE-21980.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16660 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[subq_insert] (batchId=100) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18006/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18006/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18006/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12974508 - PreCommit-HIVE-Build > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch, > HIVE-21980.02.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884119#comment-16884119 ] Hive QA commented on HIVE-21980: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 10s{color} | {color:blue} ql in master has 2253 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 42s{color} | {color:red} ql: The patch generated 3 new + 4 unchanged - 2 fixed = 7 total (was 6) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 23s{color} | {color:red} ql generated 9 new + 2240 unchanged - 13 fixed = 2249 total (was 2253) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 52s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Dead store to LPAREN29 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource() At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource() At HiveParser_FromClauseParser.java:[line 1856] | | | Dead store to RPAREN31 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource() At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.atomjoinSource() At HiveParser_FromClauseParser.java:[line 1863] | | | Dead store to LPAREN47 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr() At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr() At HiveParser_FromClauseParser.java:[line 2279] | | | Dead store to RPAREN49 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr() At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser.uniqueJoinExpr() At HiveParser_FromClauseParser.java:[line 2286] | | | Should org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA14 be a _static_ inner class? At HiveParser_FromClauseParser.java:inner class? At HiveParser_FromClauseParser.java:[lines 8657-8670] | | | Dead store to LA21_31 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA21.specialStateTransition(int, IntStream) At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA21.specialStateTransition(int, IntStream) At HiveParser_FromClauseParser.java:[line 8867] | | | Dead store to LA24_31 in org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA24.specialStateTransition(int, IntStream) At HiveParser_FromClauseParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA24.specialStateTransition(int, IntStream) At HiveParser_FromClauseParser.java:[line 9080] | | | Should org.apache.hadoop.hive.ql.parse.HiveParser_FromClauseParser$DFA39 be a _static_ inner class? At HiveParser_FromClauseParser.java:inner class? At HiveParser_FromClauseParser.java:[lines 9368-9381] | | | Should
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883726#comment-16883726 ] Zoltan Haindrich commented on HIVE-21980: - I'm afraid that we just can't merge the 2 '()' recursions...or at least not without rethinking/redesigning the setop rules entirely. eventually I came up with a solution which should most probably work for every case just like before. for some reason one of the druid tests doesn't want to run on my machine; I guess I've a bad day..the others are passing > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch, > HIVE-21980.02.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883628#comment-16883628 ] Zoltan Haindrich commented on HIVE-21980: - yeah; I wasn't (really) expecting that...but to be honest I was afraid of something like this :D I see a way to make this work; but the ambiguity problem from the fact that we support adding any amount of parenthesises to both 'selectStatement' and to 'joins'; I think we could just remove it from 'selectStatement' and let the one handling joins do it instead; that way we could probably also get rid of the syn pred as well - I will open a separate ticket for this > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883234#comment-16883234 ] Vineet Garg commented on HIVE-21980: [~kgyrtkirk] Looks like there are test failures due to the change in grammar. > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883168#comment-16883168 ] Hive QA commented on HIVE-21980: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12974372/HIVE-21980.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 16648 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite] (batchId=295) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[setop_subq] (batchId=7) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stats_part] (batchId=52) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_mv] (batchId=197) org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_basic] (batchId=295) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_create_rewrite_dummy] (batchId=175) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17980/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17980/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17980/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12974372 - PreCommit-HIVE-Build > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883131#comment-16883131 ] Hive QA commented on HIVE-21980: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 6m 14s{color} | {color:blue} ql in master has 2255 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 38s{color} | {color:red} ql: The patch generated 3 new + 4 unchanged - 2 fixed = 7 total (was 6) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 31m 54s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17980/dev-support/hive-personality.sh | | git revision | master / 4e8b940 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17980/yetus/diff-checkstyle-ql.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17980/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HIVE-21980) Parsing time can be high in case of deeply nested subqueries
[ https://issues.apache.org/jira/browse/HIVE-21980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882720#comment-16882720 ] Zoltan Haindrich commented on HIVE-21980: - [~vgarg] Could you please take a look? > Parsing time can be high in case of deeply nested subqueries > > > Key: HIVE-21980 > URL: https://issues.apache.org/jira/browse/HIVE-21980 > Project: Hive > Issue Type: Improvement > Components: Parser >Reporter: Zoltan Haindrich >Assignee: Zoltan Haindrich >Priority: Major > Attachments: HIVE-21980.01.patch, HIVE-21980.01.patch > > > for queries which are recursively doing: > {code} > SELECT ... > FROM (SELECT ... > FROM ( [...] > ) JOIN > (SELECT ... > FROM ( [...] ) > JOIN ( [...] > ) > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016)