[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-05-18 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23017.6.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch, 
> HIVE-23017.3.patch, HIVE-23017.4.patch, HIVE-23017.5.patch, 
> HIVE-23017.6.patch, HIVE-23017.6.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-05-14 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23017.6.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch, 
> HIVE-23017.3.patch, HIVE-23017.4.patch, HIVE-23017.5.patch, HIVE-23017.6.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-05-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23017.5.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch, 
> HIVE-23017.3.patch, HIVE-23017.4.patch, HIVE-23017.5.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-05-12 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23017.4.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch, 
> HIVE-23017.3.patch, HIVE-23017.4.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-05-12 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23017.3.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch, 
> HIVE-23017.3.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-05-12 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: (was: HIVE-23053.3.patch)

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-05-12 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23053.3.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-05-11 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23017.2.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch, HIVE-23017.2.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-03-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: (was: HIVE-23017.1.patch)

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-03-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23017.1.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-03-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Status: Patch Available  (was: Open)

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-03-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Attachment: HIVE-23017.1.patch

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Attachments: HIVE-23017.1.patch
>
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-03-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Labels:   (was: n00b newbie noob)

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-03-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Description: 
{code:java|title=FetchTask}
public class FetchTask extends Task implements Serializable {
  private static final long serialVersionUID = 1L;
  private int maxRows = 100;
  private FetchOperator fetch;
  private ListSinkOperator sink;
  private int totalRows;
  private static transient final Logger LOG = 
LoggerFactory.getLogger(FetchTask.class);
  JobConf job = null;
{code}

The Tasks class is base class for many other.  Cleaner to simply make the 
{{Logger}} {{protected}} and usable by other classes.

  was:
{code:java|title=FetchTask}
public class FetchTask extends Task implements Serializable {
  private static final long serialVersionUID = 1L;
  private int maxRows = 100;
  private FetchOperator fetch;
  private ListSinkOperator sink;
  private int totalRows;
  private static transient final Logger LOG = 
LoggerFactory.getLogger(FetchTask.class);
  JobConf job = null;
{code}

The Tasks class is base class for many other.  Cleaner to simply make the 
{{Logger}} usable by other classes.


> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
>  Labels: n00b, newbie, noob
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} {{protected}} and usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-03-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Description: 
{code:java|title=FetchTask}
public class FetchTask extends Task implements Serializable {
  private static final long serialVersionUID = 1L;
  private int maxRows = 100;
  private FetchOperator fetch;
  private ListSinkOperator sink;
  private int totalRows;
  private static transient final Logger LOG = 
LoggerFactory.getLogger(FetchTask.class);
  JobConf job = null;
{code}

The Tasks class is base class for many other.  Cleaner to simply make the 
{{Logger}} usable by other classes.

  was:
{code:java|title=FetchTask}
public class FetchTask extends Task implements Serializable {
  private static final long serialVersionUID = 1L;
  private int maxRows = 100;
  private FetchOperator fetch;
  private ListSinkOperator sink;
  private int totalRows;
  private static transient final Logger LOG = 
LoggerFactory.getLogger(FetchTask.class);
  JobConf job = null;
{code}

There is not need for this {{Logger}} to be transient.  Please remove as it is 
useless overheard.


> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
>  Labels: n00b, newbie, noob
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> The Tasks class is base class for many other.  Cleaner to simply make the 
> {{Logger}} usable by other classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (HIVE-23017) Use Inherited Logger in Tasks

2020-03-13 Thread David Mollitor (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-23017:
--
Summary: Use Inherited Logger in Tasks  (was: Remove Superfluous 
'Transient' Keyword From FetchTask)

> Use Inherited Logger in Tasks
> -
>
> Key: HIVE-23017
> URL: https://issues.apache.org/jira/browse/HIVE-23017
> Project: Hive
>  Issue Type: Improvement
>Reporter: David Mollitor
>Priority: Minor
>  Labels: n00b, newbie, noob
>
> {code:java|title=FetchTask}
> public class FetchTask extends Task implements Serializable {
>   private static final long serialVersionUID = 1L;
>   private int maxRows = 100;
>   private FetchOperator fetch;
>   private ListSinkOperator sink;
>   private int totalRows;
>   private static transient final Logger LOG = 
> LoggerFactory.getLogger(FetchTask.class);
>   JobConf job = null;
> {code}
> There is not need for this {{Logger}} to be transient.  Please remove as it 
> is useless overheard.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)