[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=457097=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-457097 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 10/Jul/20 11:27 Start Date: 10/Jul/20 11:27 Worklog Time Spent: 10m Work Description: klcopp merged pull request #1216: URL: https://github.com/apache/hive/pull/1216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 457097) Time Spent: 2h (was: 1h 50m) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Karen Coppage >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[
https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=456583=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456583
]
ASF GitHub Bot logged work on HIVE-23760:
-
Author: ASF GitHub Bot
Created on: 09/Jul/20 12:45
Start Date: 09/Jul/20 12:45
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1216:
URL: https://github.com/apache/hive/pull/1216#discussion_r452189602
##
File path:
itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##
@@ -175,24 +165,18 @@ public void createTopicWithData(String topic, List events) {
}
}
- public void createTopic(String topic) {
-int sessionTimeoutMs = 1000;
-ZkClient zkClient = new ZkClient(
-this.zkString, sessionTimeoutMs, sessionTimeoutMs,
-ZKStringSerializer$.MODULE$
-);
-ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString,
sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+Properties properties = new Properties();
+properties.setProperty("bootstrap.servers", "localhost:9092");
+properties.setProperty("key.deserializer",
"org.apache.kafka.common.serialization.StringDeserializer");
+
properties.setProperty("value.deserializer","org.apache.kafka.common.serialization.StringDeserializer");
Review comment:
nit-nit: space? :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 456583)
Time Spent: 1h 50m (was: 1h 40m)
> Upgrading to Kafka 2.5 Clients
> --
>
> Key: HIVE-23760
> URL: https://issues.apache.org/jira/browse/HIVE-23760
> Project: Hive
> Issue Type: Improvement
> Components: kafka integration
>Reporter: Andras Katona
>Assignee: Karen Coppage
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[
https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=456468=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456468
]
ASF GitHub Bot logged work on HIVE-23760:
-
Author: ASF GitHub Bot
Created on: 09/Jul/20 07:53
Start Date: 09/Jul/20 07:53
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1216:
URL: https://github.com/apache/hive/pull/1216#discussion_r452031376
##
File path:
itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##
@@ -175,24 +165,20 @@ public void createTopicWithData(String topic, List events) {
}
}
- public void createTopic(String topic) {
-int sessionTimeoutMs = 1000;
-ZkClient zkClient = new ZkClient(
-this.zkString, sessionTimeoutMs, sessionTimeoutMs,
-ZKStringSerializer$.MODULE$
-);
-ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString,
sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+Properties properties = new Properties();
+properties.setProperty("bootstrap.servers", "localhost:9092");
+properties.setProperty("key.deserializer",
"org.apache.kafka.common.serialization"
Review comment:
Maybe optimizer fixes this automatically, but could we just break the
line at the ',' instead of adding a new concatenation?
##
File path:
itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##
@@ -175,24 +165,20 @@ public void createTopicWithData(String topic, List events) {
}
}
- public void createTopic(String topic) {
-int sessionTimeoutMs = 1000;
-ZkClient zkClient = new ZkClient(
-this.zkString, sessionTimeoutMs, sessionTimeoutMs,
-ZKStringSerializer$.MODULE$
-);
-ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString,
sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+Properties properties = new Properties();
+properties.setProperty("bootstrap.servers", "localhost:9092");
+properties.setProperty("key.deserializer",
"org.apache.kafka.common.serialization"
++ ".StringDeserializer");
+
properties.setProperty("value.deserializer","org.apache.kafka.common.serialization"
Review comment:
Maybe optimizer fixes this automatically, but could we just break the
line at the ',' instead of adding a new concatenation?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 456468)
Time Spent: 1h 40m (was: 1.5h)
> Upgrading to Kafka 2.5 Clients
> --
>
> Key: HIVE-23760
> URL: https://issues.apache.org/jira/browse/HIVE-23760
> Project: Hive
> Issue Type: Improvement
> Components: kafka integration
>Reporter: Andras Katona
>Assignee: Karen Coppage
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=456189=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456189 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 08/Jul/20 15:08 Start Date: 08/Jul/20 15:08 Worklog Time Spent: 10m Work Description: klcopp commented on pull request #1216: URL: https://github.com/apache/hive/pull/1216#issuecomment-655578545 @pvary, would you mind taking a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 456189) Time Spent: 1.5h (was: 1h 20m) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Karen Coppage >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=455275=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455275 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 07/Jul/20 07:45 Start Date: 07/Jul/20 07:45 Worklog Time Spent: 10m Work Description: klcopp commented on pull request #1175: URL: https://github.com/apache/hive/pull/1175#issuecomment-654663659 Moved to https://github.com/apache/hive/pull/1216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 455275) Time Spent: 1h 20m (was: 1h 10m) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Karen Coppage >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=455274=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455274 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 07/Jul/20 07:44 Start Date: 07/Jul/20 07:44 Worklog Time Spent: 10m Work Description: klcopp closed pull request #1175: URL: https://github.com/apache/hive/pull/1175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 455274) Time Spent: 1h 10m (was: 1h) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Karen Coppage >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=455273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455273 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 07/Jul/20 07:44 Start Date: 07/Jul/20 07:44 Worklog Time Spent: 10m Work Description: klcopp opened a new pull request #1216: URL: https://github.com/apache/hive/pull/1216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 455273) Time Spent: 1h (was: 50m) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Karen Coppage >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=453398=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453398 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 01/Jul/20 12:42 Start Date: 01/Jul/20 12:42 Worklog Time Spent: 10m Work Description: akatona84 opened a new pull request #1175: URL: https://github.com/apache/hive/pull/1175 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HIVE-X: Fix a typo in YYY) For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 453398) Time Spent: 50m (was: 40m) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Karen Coppage >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=453394=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453394 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 01/Jul/20 12:39 Start Date: 01/Jul/20 12:39 Worklog Time Spent: 10m Work Description: belugabehr closed pull request #1175: URL: https://github.com/apache/hive/pull/1175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 453394) Time Spent: 40m (was: 0.5h) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Karen Coppage >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=453393=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453393 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 01/Jul/20 12:39 Start Date: 01/Jul/20 12:39 Worklog Time Spent: 10m Work Description: belugabehr commented on pull request #1175: URL: https://github.com/apache/hive/pull/1175#issuecomment-652393923 Will close/open to re-launch tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 453393) Time Spent: 0.5h (was: 20m) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Karen Coppage >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=450469=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450469 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 24/Jun/20 14:48 Start Date: 24/Jun/20 14:48 Worklog Time Spent: 10m Work Description: akatona84 commented on pull request #1175: URL: https://github.com/apache/hive/pull/1175#issuecomment-648867767 @klcopp I've changed my mind and created PR for kafka upgrade :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 450469) Time Spent: 20m (was: 10m) > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Andras Katona >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23760) Upgrading to Kafka 2.5 Clients
[ https://issues.apache.org/jira/browse/HIVE-23760?focusedWorklogId=450466=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450466 ] ASF GitHub Bot logged work on HIVE-23760: - Author: ASF GitHub Bot Created on: 24/Jun/20 14:42 Start Date: 24/Jun/20 14:42 Worklog Time Spent: 10m Work Description: akatona84 opened a new pull request #1175: URL: https://github.com/apache/hive/pull/1175 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HIVE-X: Fix a typo in YYY) For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 450466) Remaining Estimate: 0h Time Spent: 10m > Upgrading to Kafka 2.5 Clients > -- > > Key: HIVE-23760 > URL: https://issues.apache.org/jira/browse/HIVE-23760 > Project: Hive > Issue Type: Improvement > Components: kafka integration >Reporter: Andras Katona >Assignee: Andras Katona >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
