[jira] [Work logged] (HIVE-24308) FIX conditions used for DPHJ conversion
[ https://issues.apache.org/jira/browse/HIVE-24308?focusedWorklogId=529917=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529917 ] ASF GitHub Bot logged work on HIVE-24308: - Author: ASF GitHub Bot Created on: 01/Jan/21 01:09 Start Date: 01/Jan/21 01:09 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #1604: URL: https://github.com/apache/hive/pull/1604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 529917) Time Spent: 1h (was: 50m) > FIX conditions used for DPHJ conversion > - > > Key: HIVE-24308 > URL: https://issues.apache.org/jira/browse/HIVE-24308 > Project: Hive > Issue Type: Bug >Reporter: Panagiotis Garefalakis >Assignee: Panagiotis Garefalakis >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Found a weird scenario when looking at the ConvertJoinMapJoin logic: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1198] > When the distinct keys cannot fit in memory AND the DPHJ ShuffleSize is > lower than expected the code returns a MJ because of the condition above! > In general, I believe the ShuffleSize check: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1624] > should be part of the shuffleJoin DPHJ conversion. > And the preferred conversion would be: MJ > DPHJ > SMB -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24308) FIX conditions used for DPHJ conversion
[ https://issues.apache.org/jira/browse/HIVE-24308?focusedWorklogId=527915=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527915 ] ASF GitHub Bot logged work on HIVE-24308: - Author: ASF GitHub Bot Created on: 24/Dec/20 01:03 Start Date: 24/Dec/20 01:03 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #1604: URL: https://github.com/apache/hive/pull/1604#issuecomment-750677688 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 527915) Time Spent: 50m (was: 40m) > FIX conditions used for DPHJ conversion > - > > Key: HIVE-24308 > URL: https://issues.apache.org/jira/browse/HIVE-24308 > Project: Hive > Issue Type: Bug >Reporter: Panagiotis Garefalakis >Assignee: Panagiotis Garefalakis >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Found a weird scenario when looking at the ConvertJoinMapJoin logic: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1198] > When the distinct keys cannot fit in memory AND the DPHJ ShuffleSize is > lower than expected the code returns a MJ because of the condition above! > In general, I believe the ShuffleSize check: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1624] > should be part of the shuffleJoin DPHJ conversion. > And the preferred conversion would be: MJ > DPHJ > SMB -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24308) FIX conditions used for DPHJ conversion
[ https://issues.apache.org/jira/browse/HIVE-24308?focusedWorklogId=504213=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504213 ] ASF GitHub Bot logged work on HIVE-24308: - Author: ASF GitHub Bot Created on: 23/Oct/20 15:18 Start Date: 23/Oct/20 15:18 Worklog Time Spent: 10m Work Description: pgaref opened a new pull request #1604: URL: https://github.com/apache/hive/pull/1604 FIX conditions used for DPHJ conversion ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504213) Time Spent: 0.5h (was: 20m) > FIX conditions used for DPHJ conversion > - > > Key: HIVE-24308 > URL: https://issues.apache.org/jira/browse/HIVE-24308 > Project: Hive > Issue Type: Bug >Reporter: Panagiotis Garefalakis >Assignee: Panagiotis Garefalakis >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Found a weird scenario when looking at the ConvertJoinMapJoin logic: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1198] > When the distinct keys cannot fit in memory AND the DPHJ ShuffleSize is > lower than expected the code returns a MJ because of the condition above! > In general, I believe the ShuffleSize check: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1624] > should be part of the shuffleJoin DPHJ conversion. > And the preferred conversion would be: MJ > DPHJ > SMB -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24308) FIX conditions used for DPHJ conversion
[ https://issues.apache.org/jira/browse/HIVE-24308?focusedWorklogId=504214=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504214 ] ASF GitHub Bot logged work on HIVE-24308: - Author: ASF GitHub Bot Created on: 23/Oct/20 15:18 Start Date: 23/Oct/20 15:18 Worklog Time Spent: 10m Work Description: pgaref closed pull request #1604: URL: https://github.com/apache/hive/pull/1604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504214) Time Spent: 40m (was: 0.5h) > FIX conditions used for DPHJ conversion > - > > Key: HIVE-24308 > URL: https://issues.apache.org/jira/browse/HIVE-24308 > Project: Hive > Issue Type: Bug >Reporter: Panagiotis Garefalakis >Assignee: Panagiotis Garefalakis >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Found a weird scenario when looking at the ConvertJoinMapJoin logic: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1198] > When the distinct keys cannot fit in memory AND the DPHJ ShuffleSize is > lower than expected the code returns a MJ because of the condition above! > In general, I believe the ShuffleSize check: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1624] > should be part of the shuffleJoin DPHJ conversion. > And the preferred conversion would be: MJ > DPHJ > SMB -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24308) FIX conditions used for DPHJ conversion
[ https://issues.apache.org/jira/browse/HIVE-24308?focusedWorklogId=504139=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504139 ] ASF GitHub Bot logged work on HIVE-24308: - Author: ASF GitHub Bot Created on: 23/Oct/20 12:49 Start Date: 23/Oct/20 12:49 Worklog Time Spent: 10m Work Description: pgaref commented on pull request #1604: URL: https://github.com/apache/hive/pull/1604#issuecomment-715320363 @rbalamohan @jesus Can you please take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504139) Time Spent: 20m (was: 10m) > FIX conditions used for DPHJ conversion > - > > Key: HIVE-24308 > URL: https://issues.apache.org/jira/browse/HIVE-24308 > Project: Hive > Issue Type: Bug >Reporter: Panagiotis Garefalakis >Assignee: Panagiotis Garefalakis >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Found a weird scenario when looking at the ConvertJoinMapJoin logic: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1198] > When the distinct keys cannot fit in memory AND the DPHJ ShuffleSize is > lower than expected the code returns a MJ because of the condition above! > In general, I believe the ShuffleSize check: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1624] > should be part of the shuffleJoin DPHJ conversion. > And the preferred conversion would be: MJ > DPHJ > SMB -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24308) FIX conditions used for DPHJ conversion
[ https://issues.apache.org/jira/browse/HIVE-24308?focusedWorklogId=504138=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504138 ] ASF GitHub Bot logged work on HIVE-24308: - Author: ASF GitHub Bot Created on: 23/Oct/20 12:44 Start Date: 23/Oct/20 12:44 Worklog Time Spent: 10m Work Description: pgaref opened a new pull request #1604: URL: https://github.com/apache/hive/pull/1604 Change-Id: Iaa1d4a5c857b6c494aa220c6c96d7659a2a68aa4 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504138) Remaining Estimate: 0h Time Spent: 10m > FIX conditions used for DPHJ conversion > - > > Key: HIVE-24308 > URL: https://issues.apache.org/jira/browse/HIVE-24308 > Project: Hive > Issue Type: Bug >Reporter: Panagiotis Garefalakis >Assignee: Panagiotis Garefalakis >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Found a weird scenario when looking at the ConvertJoinMapJoin logic: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1198] > When the distinct keys cannot fit in memory AND the DPHJ ShuffleSize is > lower than expected the code returns a MJ because of the condition above! > In general, I believe the ShuffleSize check: > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java#L1624] > should be part of the shuffleJoin DPHJ conversion. > And the preferred conversion would be: MJ > DPHJ > SMB -- This message was sent by Atlassian Jira (v8.3.4#803005)
