[jira] [Created] (IGNITE-11980) Repairs count metric (ReadRepair)
Anton Vinogradov created IGNITE-11980: - Summary: Repairs count metric (ReadRepair) Key: IGNITE-11980 URL: https://issues.apache.org/jira/browse/IGNITE-11980 Project: Ignite Issue Type: Task Reporter: Anton Vinogradov Ignite should provide metric of how many repairs happened during ReadRepar feature usage. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (IGNITE-11927) [IEP-35] Add ability to configure subset of metrics
[
https://issues.apache.org/jira/browse/IGNITE-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884683#comment-16884683
]
Andrey Gura edited comment on IGNITE-11927 at 7/14/19 1:53 PM:
---
Anyway, I've took a look and have some comments:
1. There is no need to be disabled or enabled for particular metric value. So
{{disabled}} flag in {{AbstractMetric}} is redundant.
2. We enable or disable metrics for one source of metrics. So we can just
remove {{MetricRegistry}} from {{GridMetricManager}} when metrics disabled.
3. There is no need for {{disabled}} flag in {{MetricRegistry}}. As we discused
early, when metric disabled they don't consume any memory. MetricsRegistry
should be collected by GC. After enabling it can be created and registered into
{{GridMetricManager}} again.
4. Please, separate buckets configuration and metrics enabling/disabling into
two different tickets.
5. Please, create review in Upsource.
6. Please, run TC and take a look to results before code review.
Could you please fix this issues? Thanks.
was (Author: agura):
Anyway, I've took a look and have some comments:
1. There is no need to be disabled or enabled for particular metric value. So
{{disabled}} flag in {{AbstractMetric}} is redundant.
2. We enable or disable metrics for one source of metrics. So we can just
remove {{MetricRegistry}} from {{GridMetricManager}} when metrics disabled.
3. There is no need for {{disabled}} flag in {{MetricRegistry}}. As we discused
early, when metric disabled they don't consume any memory. MetricsRegistry
should be collected by GC. After enabling it can be created and registered into
{{GridMetricManager}} again.
4. Please, separate buckets configuration and metrics enabling/disabling into
two different tickets.
5. Please, create review in Upsource.
6. Please, run TC and take a look to results before code review.
> [IEP-35] Add ability to configure subset of metrics
> ---
>
> Key: IGNITE-11927
> URL: https://issues.apache.org/jira/browse/IGNITE-11927
> Project: Ignite
> Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
> Labels: IEP-35
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Ignite should be able to:
> * Enable or disable an arbitrary subset of the metrics. User should be able
> to do it in runtime.
> * Configure Histogram metrics
> * Configure HitRate metrics.
> We should provide 2 ways to configure metric:
> 1. -Configuration file.- Discussed on dev-list. Agreed to go with the
> simplest solution - JMX method.
> 2. JMX method.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (IGNITE-11927) [IEP-35] Add ability to configure subset of metrics
[
https://issues.apache.org/jira/browse/IGNITE-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884683#comment-16884683
]
Andrey Gura commented on IGNITE-11927:
--
Anyway, I've took a look and have some comments:
1. There is no need to be disabled or enabled for particular metric value. So
{{disabled}} flag in {{AbstractMetric}} is redundant.
2. We enable or disable metrics for one source of metrics. So we can just
remove {{MetricRegistry}} from {{GridMetricManager}} when metrics disabled.
3. There is no need for {{disabled}} flag in {{MetricRegistry}}. As we discused
early, when metric disabled they don't consume any memory. MetricsRegistry
should be collected by GC. After enabling it can be created and registered into
{{GridMetricManager}} again.
4. Please, separate buckets configuration and metrics enabling/disabling into
two different tickets.
5. Please, create review in Upsource.
6. Please, run TC and take a look to results before code review.
> [IEP-35] Add ability to configure subset of metrics
> ---
>
> Key: IGNITE-11927
> URL: https://issues.apache.org/jira/browse/IGNITE-11927
> Project: Ignite
> Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
> Labels: IEP-35
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Ignite should be able to:
> * Enable or disable an arbitrary subset of the metrics. User should be able
> to do it in runtime.
> * Configure Histogram metrics
> * Configure HitRate metrics.
> We should provide 2 ways to configure metric:
> 1. -Configuration file.- Discussed on dev-list. Agreed to go with the
> simplest solution - JMX method.
> 2. JMX method.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (IGNITE-11927) [IEP-35] Add ability to configure subset of metrics
[ https://issues.apache.org/jira/browse/IGNITE-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884676#comment-16884676 ] Andrey Gura commented on IGNITE-11927: -- [~NIzhikov] What about TC? > [IEP-35] Add ability to configure subset of metrics > --- > > Key: IGNITE-11927 > URL: https://issues.apache.org/jira/browse/IGNITE-11927 > Project: Ignite > Issue Type: Improvement >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > Labels: IEP-35 > Time Spent: 10m > Remaining Estimate: 0h > > Ignite should be able to: > * Enable or disable an arbitrary subset of the metrics. User should be able > to do it in runtime. > * Configure Histogram metrics > * Configure HitRate metrics. > We should provide 2 ways to configure metric: > 1. -Configuration file.- Discussed on dev-list. Agreed to go with the > simplest solution - JMX method. > 2. JMX method. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11921) [IEP-35] Migrate CacheGroupMetrics
[ https://issues.apache.org/jira/browse/IGNITE-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884605#comment-16884605 ] Nikolay Izhikov commented on IGNITE-11921: -- Fail of the test is not related to the changes. Test now is very unstable - https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-8410532475647722188&tab=testDetails Success rate - 16,4% Tests runs: 360 total/301 fail > [IEP-35] Migrate CacheGroupMetrics > -- > > Key: IGNITE-11921 > URL: https://issues.apache.org/jira/browse/IGNITE-11921 > Project: Ignite > Issue Type: Improvement >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > Labels: IEP-35 > Time Spent: 10m > Remaining Estimate: 0h > > After merging of IGNITE-11848 we should migrate `CacheGroupMetricsMXBean` to > the new metric framework. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-11921) [IEP-35] Migrate CacheGroupMetrics
[
https://issues.apache.org/jira/browse/IGNITE-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884603#comment-16884603
]
Ignite TC Bot commented on IGNITE-11921:
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}MVCC Cache 7{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=4297031]]
* IgniteCacheMvccTestSuite7: MvccCacheGroupMetricsTest.testCacheGroupMetrics
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4297040&buildTypeId=IgniteTests24Java8_RunAll]
> [IEP-35] Migrate CacheGroupMetrics
> --
>
> Key: IGNITE-11921
> URL: https://issues.apache.org/jira/browse/IGNITE-11921
> Project: Ignite
> Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
> Labels: IEP-35
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After merging of IGNITE-11848 we should migrate `CacheGroupMetricsMXBean` to
> the new metric framework.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
