[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867697#comment-16867697 ] Ilya Suntsov commented on IGNITE-10896: --- [~Denis Chudov] the message above still actual. > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839386#comment-16839386 ] Ilya Suntsov commented on IGNITE-10896: --- [~Denis Chudov] Also I see null in the exception message in the log: {noformat} cat /home/isuntsov/858_test/idle_verify-2019-05-14T15-22-20_895.txt idle_verify failed.There are no caches matching given filter options.Idle verify failed on nodes: Node ID: e5a981f6-9d0b-4cd7-aad3-fe3cc7fa6101 [172.25.1.29] consistent ID: poc-tester-server-172.25.1.29-id-0 Exception message: null {noformat} > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839383#comment-16839383 ] Ilya Suntsov commented on IGNITE-10896: --- [~Denis Chudov] I've checked the fix. I've tried to pass as parameter regexp that doesn't match any node's cache. \{noformat} bin/control.sh --cache idle_verify cachepoc1.* --cache-filter PERSISTENT --host 172.25.1.29 Control utility [ver. 2.5.8#20190511-sha1:8b27f3a6] 2019 Copyright(C) Apache Software Foundation User: isuntsov Time: 2019-05-14T15:22:20.565 idle_verify failed.There are no caches matching given filter options.Idle verify failed on nodes: Node ID: e5a981f6-9d0b-4cd7-aad3-fe3cc7fa6101 [172.25.1.29] consistent ID: poc-tester-server-172.25.1.29-id-0 See log for additional information. /home/isuntsov/858_test/idle_verify-2019-05-14T15-22-20_895.txt {noformat} The message is CORRECT but I think that text formatting doesn't look well. I guess should be: {noformat} idle_verify failed. There are no caches matching given filter options: [ cachepoc1.*; PERSISTENT]. Idle verify failed on nodes: Node ID: e5a981f6-9d0b-4cd7-aad3-fe3cc7fa6101 [172.25.1.29] Consistent ID: poc-tester-server-172.25.1.29-id-0 See log for additional information: /home/isuntsov/858_test/idle_verify-2019-05-14T15-22-20_895.txt {noformat} > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808883#comment-16808883 ] Ivan Rakov commented on IGNITE-10896: - [~Denis Chudov], 1. {code:java} try { Pattern.compile(cacheName); } catch (PatternSyntaxException e) { throw new RuntimeException(format("Invalid cache name regexp '%s': %s", cacheName, e.getMessage())); } {code} catch should be on separate line 2. As I see from the code, cache filtering actually works on group names as well. Let's meтtion it in --cache help output. 3. Let's cover that non-trivial cache filter (e.g. PERSISTENT) works simultaneously with regexp filtering. 4. I agree with Sergey on his points 5 and 6. A descriptive message should be displayed in case there are no caches that match the filter. 5. "idle_verify task args were following" - doesn't it sound a bit rough? What about "idle_verify task was executed with the following args"? > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 1h > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806652#comment-16806652 ] Sergey Antonov commented on IGNITE-10896: - [~Denis Chudov] I left comments in PR. > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 1h > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805841#comment-16805841 ] Ignite TC Bot commented on IGNITE-10896: {panel:title=-- Run :: All: No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} [TeamCity *-- Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=3455839buildTypeId=IgniteTests24Java8_RunAll] > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804039#comment-16804039 ] Sergey Antonov commented on IGNITE-10896: - [~Denis Chudov] 1) We should check, that all regexps are correct, before sending task to cluster. 2) I didn't find validation cache filter conditions for conflicts (i.e. {{--caches cache1 --exclude-caches cache1 }}). 3) Please add tests for idle_verify command without {{--dump}} option. 4) Please add info about default values for cache filter options to help output {{--cache help}} 5) We shouldn't throw exception if node not have matched caches. Sending special task result (matched caches not found) looks better. 6) I got odd control.sh output in {{testCacheIdleVerifyDumpMultipleOptionsFail()}} {code:java} Control utility [ver. 2.7.0-SNAPSHOT#20190328-sha1:DEV] 2019 Copyright(C) Apache Software Foundation User: santonov Time: 2019-03-28T18:24:18.794 VisorIdleVerifyDumpTask successfully written output to 'C:\git\apache-ignite\work\idle-dump-2019-03-28T18-24-19_477.txt' idle_verify failed on 2 nodes. idle_verify check has finished, found 0 partitions idle_verify task args were following: --cache-filter ALL --exclude-caches .* {code} User could be confused this message. Please fix it. > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803931#comment-16803931 ] Ivan Rakov commented on IGNITE-10896: - [~antonoal], please take a look as well. > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801141#comment-16801141 ] Ignite TC Bot commented on IGNITE-10896: {panel:title=- Run :: IntelliJ IDEA Inspections: No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} [TeamCity *- Run :: IntelliJ IDEA Inspections* Results|https://ci.ignite.apache.org/viewLog.html?buildId=3413159buildTypeId=IgniteTests24Java8_RunIntelliJIdeaInspections] > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Assignee: Denis Chudov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
[ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755801#comment-16755801 ] Artem Budnikov commented on IGNITE-10896: - The behaviour that [~ARomantsov] suggests for the two options should be extended to all three options. It'll be better if all three options can be used simultaneously. Mutually exclusive filtering options are really confusing. This is how I envision it: The default value for `--exclude-caches` is an empty set. The default value for `--cache-filter` is no filtering. The default value for `\-\-caches` is all caches. All three options can be used simultaneously or all three can be omitted (in which case the default values are used). If the result of applying the options is an empty set, the script should print a warning to the console. > Add ability to use simultaneous cache filtering options with control.sh > --cache idle_verify > --- > > Key: IGNITE-10896 > URL: https://issues.apache.org/jira/browse/IGNITE-10896 > Project: Ignite > Issue Type: Improvement >Reporter: ARomantsov >Priority: Major > Fix For: 2.8 > > > Now I can use only one of next options > 1) --exclude-caches cache1,...,cacheN > 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT > 3) cache1,...,cacheN > Trying to use two or more of this options currently results in error: > {noformat} > Error: Should use only one of option: --excludeCaches, --cache-filter or pass > caches explicitly > {noformat} > Instead, utility should do the following: > 1) when two or more options specified, result cache set to make dump of > should be logical AND of results of each option applied individually. > ex. > {noformat} > cache.* --cache-filter PERSISTENT > {noformat} > should select all persistent caches starting from 'cache' > {noformat} >--cache-filter ALL >--exclude-caches wrong-.*-caches > {noformat} > should select all caches but matching 'wrong-.*-caches' regexp > etc. > 2) filtering options passed to control utility should be logged into result > dump file, so that user could understand that dump was taken from subset of > cluster caches > 3) when result of filter or filters AND'ing is empty set of cache names, > proper error message should be given and no dump file generated. > e.g. > {noformat}Error: can't find any cache matching cache names '--skup-zerus' and > cache filter 'PERSISTENT', dump won't be generated.{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)