[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[ https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801972#comment-16801972 ] Alexey Goncharuk commented on IGNITE-11299: --- Changes look good to me. > During SSL Handshake GridNioServer.processWrite is invoked constantly > - > > Key: IGNITE-11299 > URL: https://issues.apache.org/jira/browse/IGNITE-11299 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.7 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Blocker > Labels: important, ssl > Fix For: 2.8, 2.7.5 > > Time Spent: 50m > Remaining Estimate: 0h > > Causes busy looping in processSelectionKeyOptimized() > This also causes problems on Windows/Java 11 since if key is always ready for > writing it will never be shown as ready for reading. > The reason for this behavior that during handshake we never un-listen OP_WRITE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[
https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798940#comment-16798940
]
Ignite TC Bot commented on IGNITE-11299:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3376416buildTypeId=IgniteTests24Java8_RunAll]
> During SSL Handshake GridNioServer.processWrite is invoked constantly
> -
>
> Key: IGNITE-11299
> URL: https://issues.apache.org/jira/browse/IGNITE-11299
> Project: Ignite
> Issue Type: Bug
> Components: general
>Affects Versions: 2.7
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Blocker
> Labels: important, ssl
> Fix For: 2.8, 2.7.5
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Causes busy looping in processSelectionKeyOptimized()
> This also causes problems on Windows/Java 11 since if key is always ready for
> writing it will never be shown as ready for reading.
> The reason for this behavior that during handshake we never un-listen OP_WRITE
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[
https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798547#comment-16798547
]
Ignite TC Bot commented on IGNITE-11299:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}SPI (URI Deploy){color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3376332]]
{color:#d04437}Platform C++ (Linux Clang){color} [[tests 500 JVM CRASH , Exit
Code , Failure on metric
|https://ci.ignite.apache.org/viewLog.html?buildId=3376346]]
* IgniteOdbcTest: SslQueriesTestSuite: TestConnectionSslSuccess - 1,2% fails in
last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionVersionMismatchError - 0,9%
fails in last 772 master runs.
* IgniteOdbcTest: StreamingTestSuite: TestStreamingManyObjects - 0,9% fails in
last 772 master runs.
* IgniteOdbcTest: SqlEscConvertFunctionTestSuite:
TestEscConvertFunctionByteArray - 0,9% fails in last 772 master runs.
* IgniteOdbcTest: SqlEscConvertFunctionTestSuite: TestEscConvertFunctionBool -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: SqlEscConvertFunctionTestSuite: TestEscConvertFunctionDecimal
- 0,9% fails in last 772 master runs.
* IgniteOdbcTest: SqlEscConvertFunctionTestSuite: TestEscConvertFunctionFloat -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: SqlEscConvertFunctionTestSuite: TestEscConvertFunctionDate -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: SqlEscConvertFunctionTestSuite: TestEscConvertFunctionTime -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: SqlEscConvertFunctionTestSuite:
TestEscConvertFunctionTimestamp - 0,9% fails in last 772 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorSubDouble - 0,9% fails in
last 772 master runs.
* IgniteOdbcTest: SqlTypesTestSuite: TestGuidTrivial - 0,9% fails in last 772
master runs.
* IgniteOdbcTest: SqlTypesTestSuite: TestGuidEqualsToColumn - 0,9% fails in
last 772 master runs.
* IgniteOdbcTest: SqlTypesTestSuite: TestByteArraySelect - 0,9% fails in last
772 master runs.
* IgniteOdbcTest: SqlTypesTestSuite: TestByteArrayParam - 0,9% fails in last
772 master runs.
* IgniteOdbcTest: SqlTypesTestSuite: TestByteParamInsert - 0,9% fails in last
772 master runs.
* IgniteOdbcTest: TypesTestSuite: TestZeroDecimal - 0,9% fails in last 772
master runs.
* IgniteOdbcTest: StreamingTestSuite: TestStreamingSimple - 0,9% fails in last
772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionCommit - 0,9%
fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionRollbackInsert -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionRollbackUpdate1 -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionRollbackUpdate2 -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionRollbackDelete1 -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionRollbackDelete2 -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionTxModeError - 0,9%
fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionTxModeIgnore -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionConnectionTxModeCommit -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: StreamingTestSuite: TestStreamingClosingStatement - 0,9%
fails in last 772 master runs.
* IgniteOdbcTest: StreamingTestSuite: TestStreamingSeveralStatements - 0,9%
fails in last 772 master runs.
* IgniteOdbcTest: StreamingTestSuite: TestStreamingSeveralStatementsClosing -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: StreamingTestSuite: TestStreamingDifferentStatements - 0,9%
fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionEnvironmentCommit - 0,9%
fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionEnvironmentRollbackInsert -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionEnvironmentRollbackUpdate1 -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionEnvironmentRollbackUpdate2 -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionEnvironmentRollbackDelete1 -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionEnvironmentRollbackDelete2 -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionEnvironmentTxModeError -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite: TransactionEnvironmentTxModeIgnore -
0,9% fails in last 772 master runs.
* IgniteOdbcTest: TransactionTestSuite:
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[ https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784282#comment-16784282 ] Ilya Kasnacheev commented on IGNITE-11299: -- [~agoncharuk] since there is no negative feedback I suggest merging this change. WDYT? Can you do that? > During SSL Handshake GridNioServer.processWrite is invoked constantly > - > > Key: IGNITE-11299 > URL: https://issues.apache.org/jira/browse/IGNITE-11299 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.7 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: ssl > Time Spent: 40m > Remaining Estimate: 0h > > Causes busy looping in processSelectionKeyOptimized() > This also causes problems on Windows/Java 11 since if key is always ready for > writing it will never be shown as ready for reading. > The reason for this behavior that during handshake we never un-listen OP_WRITE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[ https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779048#comment-16779048 ] Ilya Kasnacheev commented on IGNITE-11299: -- Also fixed TcpDiscoverySslParametersTest.testNonExistentCipherSuite under Java 11. Still waiting for review! > During SSL Handshake GridNioServer.processWrite is invoked constantly > - > > Key: IGNITE-11299 > URL: https://issues.apache.org/jira/browse/IGNITE-11299 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.7 >Reporter: Ilya Kasnacheev >Assignee: Ilya Kasnacheev >Priority: Major > Labels: ssl > Time Spent: 40m > Remaining Estimate: 0h > > Causes busy looping in processSelectionKeyOptimized() > This also causes problems on Windows/Java 11 since if key is always ready for > writing it will never be shown as ready for reading. > The reason for this behavior that during handshake we never un-listen OP_WRITE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[ https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767225#comment-16767225 ] Ilya Kasnacheev commented on IGNITE-11299: -- [~yzhdanov] [~sboikov] [~dpavlov] please review NIO SSL patch. I have ran some suites on Java 11 - SSL works, ditto SPI on Windows: https://ci.ignite.apache.org/viewLog.html?buildId=3077134=IgniteTests24Java8_SpiWindows https://ci.ignite.apache.org/viewLog.html?buildId=3077015=queuedBuildOverviewTab https://ci.ignite.apache.org/viewLog.html?buildId=3076776=IgniteTests24Java8_CacheFailoverSsl=testsInfo https://ci.ignite.apache.org/viewLog.html?buildId=3076778=queuedBuildOverviewTab https://ci.ignite.apache.org/viewLog.html?buildId=3076518; This is in addition to regular Visa shown above. > During SSL Handshake GridNioServer.processWrite is invoked constantly > - > > Key: IGNITE-11299 > URL: https://issues.apache.org/jira/browse/IGNITE-11299 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.7 >Reporter: Ilya Kasnacheev >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[
https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767220#comment-16767220
]
Ignite TC Bot commented on IGNITE-11299:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}SPI{color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=3077015]]
* IgniteSpiTestSuite: TcpDiscoverySslParametersTest.testNonExistentCipherSuite
- 0,0% fails in last 418 master runs.
{color:#d04437}Basic 1{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3071192]]
*
SetTxTimeoutOnPartitionMapExchangeTest.testSetTxTimeoutOnClientDuringPartitionMapExchange
(last started)
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3071265buildTypeId=IgniteTests24Java8_RunAll]
> During SSL Handshake GridNioServer.processWrite is invoked constantly
> -
>
> Key: IGNITE-11299
> URL: https://issues.apache.org/jira/browse/IGNITE-11299
> Project: Ignite
> Issue Type: Bug
> Components: general
>Affects Versions: 2.7
>Reporter: Ilya Kasnacheev
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[ https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766114#comment-16766114 ] Ilya Kasnacheev commented on IGNITE-11299: -- Yes, it seem to fix Windows under Java 11 too. I expect that under Windows it will either generate 'write available' or 'read available' socket events but not 'write and read available'. So until you unregister OP_WRITE you will not be getting read events even if reading is actually available. > During SSL Handshake GridNioServer.processWrite is invoked constantly > - > > Key: IGNITE-11299 > URL: https://issues.apache.org/jira/browse/IGNITE-11299 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.7 >Reporter: Ilya Kasnacheev >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[ https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766094#comment-16766094 ] Ilya Kasnacheev commented on IGNITE-11299: -- in BlockingSslHandler we also do not check whether ch.write(outNetBuf); had actually written everything. > During SSL Handshake GridNioServer.processWrite is invoked constantly > - > > Key: IGNITE-11299 > URL: https://issues.apache.org/jira/browse/IGNITE-11299 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11299) During SSL Handshake GridNioServer.processWrite is invoked constantly
[ https://issues.apache.org/jira/browse/IGNITE-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766092#comment-16766092 ] Ilya Kasnacheev commented on IGNITE-11299: -- We set *key.interestOps(key.interestOps() | SelectionKey.OP_WRITE);* in registerWrite() but in processWriteSsl(), we only unset *key.interestOps(key.interestOps() & (~SelectionKey.OP_WRITE));* after handshake is finished. This means that until handshake is finished, processWrite will be triggered endlessly in processSelectedKeysOptimized() for this SelectorKey - socket is available for write most often, which is validated by adding logging to processWrite() Fixing this might also fix SSL on Windows under Java 11. Then again, maybe not. > During SSL Handshake GridNioServer.processWrite is invoked constantly > - > > Key: IGNITE-11299 > URL: https://issues.apache.org/jira/browse/IGNITE-11299 > Project: Ignite > Issue Type: Bug >Reporter: Ilya Kasnacheev >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
