[jira] [Commented] (IGNITE-11512) Add counter left partition for index rebuild in CacheGroupMetricsMXBean
[ https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854955#comment-16854955 ] Stanilovsky Evgeny commented on IGNITE-11512: - [~ivan.glukos] thanks, is it ok now ? > Add counter left partition for index rebuild in CacheGroupMetricsMXBean > --- > > Key: IGNITE-11512 > URL: https://issues.apache.org/jira/browse/IGNITE-11512 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.7 >Reporter: Alexand Polyakov >Assignee: Stanilovsky Evgeny >Priority: Major > > Now, if ran rebuild indexes, this can determined only on load CPU and thread > dump. The presence of the "how many partitions left to index" metric will > help determine whether the rebuilding is going on and on which cache, as well > as the percentage of completion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11512) Add counter left partition for index rebuild in CacheGroupMetricsMXBean
[
https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854744#comment-16854744
]
Ignite TC Bot commented on IGNITE-11512:
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Inspections)*{color} [[tests 0 Failure on metric
|https://ci.ignite.apache.org/viewLog.html?buildId=4031891]]
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4000936&buildTypeId=IgniteTests24Java8_RunAll]
> Add counter left partition for index rebuild in CacheGroupMetricsMXBean
> ---
>
> Key: IGNITE-11512
> URL: https://issues.apache.org/jira/browse/IGNITE-11512
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 2.7
>Reporter: Alexand Polyakov
>Assignee: Stanilovsky Evgeny
>Priority: Major
>
> Now, if ran rebuild indexes, this can determined only on load CPU and thread
> dump. The presence of the "how many partitions left to index" metric will
> help determine whether the rebuilding is going on and on which cache, as well
> as the percentage of completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11512) Add counter left partition for index rebuild in CacheGroupMetricsMXBean
[ https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853334#comment-16853334 ] Ivan Rakov commented on IGNITE-11512: - Looks good to me. Please fix abbreviation plugin reports and proceed to merge (as long as fresh TC bot visa is received). > Add counter left partition for index rebuild in CacheGroupMetricsMXBean > --- > > Key: IGNITE-11512 > URL: https://issues.apache.org/jira/browse/IGNITE-11512 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.7 >Reporter: Alexand Polyakov >Assignee: Stanilovsky Evgeny >Priority: Major > > Now, if ran rebuild indexes, this can determined only on load CPU and thread > dump. The presence of the "how many partitions left to index" metric will > help determine whether the rebuilding is going on and on which cache, as well > as the percentage of completion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11512) Add counter left partition for index rebuild in CacheGroupMetricsMXBean
[
https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849746#comment-16849746
]
Ignite TC Bot commented on IGNITE-11512:
{panel:title=--> Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Inspections)*{color} [[tests 0 Failure on metric
|https://ci.ignite.apache.org/viewLog.html?buildId=3968280]]
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3967030&buildTypeId=IgniteTests24Java8_RunAll]
> Add counter left partition for index rebuild in CacheGroupMetricsMXBean
> ---
>
> Key: IGNITE-11512
> URL: https://issues.apache.org/jira/browse/IGNITE-11512
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 2.7
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
>
> Now, if ran rebuild indexes, this can determined only on load CPU and thread
> dump. The presence of the "how many partitions left to index" metric will
> help determine whether the rebuilding is going on and on which cache, as well
> as the percentage of completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11512) Add counter left partition for index rebuild in CacheGroupMetricsMXBean
[ https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844621#comment-16844621 ] Alexand Polyakov commented on IGNITE-11512: --- [~ivan.glukos], questions on comments 3. specially out from the visitor to initialize the value before creating threads 6. don't understand the comment, in fact there are 2 tests: rebuild of indexes (indexes are physically removed from disk); create index (sql CREATE INDEX) 7. Variable.apache.ignite.internal.processors.cache.CacheGroupMetricsImpl#indexBuildCountPartitionsLeft and it does not require an MXBean, or do something else mean > Add counter left partition for index rebuild in CacheGroupMetricsMXBean > --- > > Key: IGNITE-11512 > URL: https://issues.apache.org/jira/browse/IGNITE-11512 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 2.7 >Reporter: Alexand Polyakov >Assignee: Alexand Polyakov >Priority: Major > > Now, if ran rebuild indexes, this can determined only on load CPU and thread > dump. The presence of the "how many partitions left to index" metric will > help determine whether the rebuilding is going on and on which cache, as well > as the percentage of completion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11512) Add counter left partition for index rebuild in CacheGroupMetricsMXBean
[
https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824634#comment-16824634
]
Ivan Rakov commented on IGNITE-11512:
-
[~a-polyakov], some comments:
1) CacheGroupMetricsMXBean lacks @MXBeanDescription for new method (you can
override method like it's done in CacheMetricsMXBean).
2) Please put spaces around binary operator '='
{code:java}
metrics=new CacheGroupMetricsImpl();
{code}
3) Both places in code where you call "setIndexBuildCountPartitionsLeft" use
SchemaIndexCacheVisitorImpl. Can we move "setIndexBuildCountPartitionsLeft"
inside SchemaIndexCacheVisitorImpl to avoid code duplication?
4) Please add public modifier to
CacheGroupMetrics#getIndexBuildCountPartitionsLeft
5) CacheGroupMetricsImpl.java:26 - unnecessary blank line
6) Abbreviation plugin reports about "indexBuildCountPartitionsLeft" in
CacheGroupMetricsImpl and some field names in
CacheGroupMetricsMBeanWithIndexTest, please fix.
7) From my point of view, it would be better to move all logic from
CacheGroupMetricsMXBeanImpl to CacheGroupMetricsImpl
(CacheGroupMetricsMXBeanImpl would just delegate all method calls to
CacheGroupMetricsImpl). Advantages: we'll be able to unit-test cache group
metrics without registering MXBean, we'll be able to post metrics to another
metrics consumer without registering MXBean and so on. What do you think?
> Add counter left partition for index rebuild in CacheGroupMetricsMXBean
> ---
>
> Key: IGNITE-11512
> URL: https://issues.apache.org/jira/browse/IGNITE-11512
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 2.7
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
>
> Now, if ran rebuild indexes, this can determined only on load CPU and thread
> dump. The presence of the "how many partitions left to index" metric will
> help determine whether the rebuilding is going on and on which cache, as well
> as the percentage of completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11512) Add counter left partition for index rebuild in CacheGroupMetricsMXBean
[
https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805413#comment-16805413
]
Ignite TC Bot commented on IGNITE-11512:
{panel:title=--> Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3446980&buildTypeId=IgniteTests24Java8_RunAll]
> Add counter left partition for index rebuild in CacheGroupMetricsMXBean
> ---
>
> Key: IGNITE-11512
> URL: https://issues.apache.org/jira/browse/IGNITE-11512
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 2.7
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
>
> Now, if ran rebuild indexes, this can determined only on load CPU and thread
> dump. The presence of the "how many partitions left to index" metric will
> help determine whether the rebuilding is going on and on which cache, as well
> as the percentage of completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11512) Add counter left partition for index rebuild in CacheGroupMetricsMXBean
[
https://issues.apache.org/jira/browse/IGNITE-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796819#comment-16796819
]
Ignite TC Bot commented on IGNITE-11512:
{panel:title=--> Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3330932&buildTypeId=IgniteTests24Java8_RunAll]
> Add counter left partition for index rebuild in CacheGroupMetricsMXBean
> ---
>
> Key: IGNITE-11512
> URL: https://issues.apache.org/jira/browse/IGNITE-11512
> Project: Ignite
> Issue Type: Improvement
> Components: general
>Affects Versions: 2.7
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
>
> Now, if ran rebuild indexes, this can determined only on load CPU and thread
> dump. The presence of the "how many partitions left to index" metric will
> help determine whether the rebuilding is going on and on which cache, as well
> as the percentage of completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
