[jira] [Commented] (IGNITE-13364) Improve index inline defaults
[
https://issues.apache.org/jira/browse/IGNITE-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400435#comment-17400435
]
Ignite TC Bot commented on IGNITE-13364:
{panel:title=Branch: [pull/9167/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9167/head] Base: [master] : New Tests
(2)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Cache 5{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=6138847]]
* {color:#013220}IgniteCacheWithIndexingTestSuite:
ComputeInlineSizeTest.testSQLIndexes - PASSED{color}
* {color:#013220}IgniteCacheWithIndexingTestSuite:
ComputeInlineSizeTest.testAnnotationPrecision - PASSED{color}
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=613buildTypeId=IgniteTests24Java8_RunAll]
> Improve index inline defaults
> --
>
> Key: IGNITE-13364
> URL: https://issues.apache.org/jira/browse/IGNITE-13364
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Evgeniy Rudenko
>Assignee: Maksim Timonin
>Priority: Major
> Fix For: 2.12
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We need to improve how inline size is calculated by default for
> variable-length types.
> Currently if a varlength type is encountered inline size just defaults to 10,
> which is almost always not enough.
> A more sensible behavior would be the following:
> 1. Add a fixed default to the inline size calculation for every
> variable-length type. For example, if the default inlined size for a string
> is 10 then an index like (INT, VARCHAR, VARCHAR, INT) should have inline size
> default as 5 + 10 + 10 + 5 = 30 (5 for each int, 10 for each string).
> 2. Add special support for VARCHAR_FIXED - if a VARCHAR has known length then
> that length is used for inline size calculation
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13364) Improve index inline defaults
[ https://issues.apache.org/jira/browse/IGNITE-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374663#comment-17374663 ] Maksim Timonin commented on IGNITE-13364: - [~korlov] thanks! [~slukyanov], [~tledkov-gridgain] could you please have a look too? > Improve index inline defaults > -- > > Key: IGNITE-13364 > URL: https://issues.apache.org/jira/browse/IGNITE-13364 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Evgeniy Rudenko >Assignee: Maksim Timonin >Priority: Major > Fix For: 2.12 > > Time Spent: 50m > Remaining Estimate: 0h > > We need to improve how inline size is calculated by default for > variable-length types. > Currently if a varlength type is encountered inline size just defaults to 10, > which is almost always not enough. > A more sensible behavior would be the following: > 1. Add a fixed default to the inline size calculation for every > variable-length type. For example, if the default inlined size for a string > is 10 then an index like (INT, VARCHAR, VARCHAR, INT) should have inline size > default as 5 + 10 + 10 + 5 = 30 (5 for each int, 10 for each string). > 2. Add special support for VARCHAR_FIXED - if a VARCHAR has known length then > that length is used for inline size calculation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13364) Improve index inline defaults
[ https://issues.apache.org/jira/browse/IGNITE-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366490#comment-17366490 ] Konstantin Orlov commented on IGNITE-13364: --- [~timonin.maksim], LGTM! > Improve index inline defaults > -- > > Key: IGNITE-13364 > URL: https://issues.apache.org/jira/browse/IGNITE-13364 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Evgeniy Rudenko >Assignee: Maksim Timonin >Priority: Major > Fix For: 2.12 > > Time Spent: 50m > Remaining Estimate: 0h > > We need to improve how inline size is calculated by default for > variable-length types. > Currently if a varlength type is encountered inline size just defaults to 10, > which is almost always not enough. > A more sensible behavior would be the following: > 1. Add a fixed default to the inline size calculation for every > variable-length type. For example, if the default inlined size for a string > is 10 then an index like (INT, VARCHAR, VARCHAR, INT) should have inline size > default as 5 + 10 + 10 + 5 = 30 (5 for each int, 10 for each string). > 2. Add special support for VARCHAR_FIXED - if a VARCHAR has known length then > that length is used for inline size calculation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13364) Improve index inline defaults
[
https://issues.apache.org/jira/browse/IGNITE-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17361601#comment-17361601
]
Ignite TC Bot commented on IGNITE-13364:
{panel:title=Branch: [pull/9167/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9167/head] Base: [master] : New Tests
(2)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Cache 5{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=6044383]]
* {color:#013220}IgniteCacheWithIndexingTestSuite:
ComputeInlineSizeTest.testSQLIndexes - PASSED{color}
* {color:#013220}IgniteCacheWithIndexingTestSuite:
ComputeInlineSizeTest.testAnnotaitionPrecision - PASSED{color}
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6043361buildTypeId=IgniteTests24Java8_RunAll]
> Improve index inline defaults
> --
>
> Key: IGNITE-13364
> URL: https://issues.apache.org/jira/browse/IGNITE-13364
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Evgeniy Rudenko
>Assignee: Maksim Timonin
>Priority: Major
> Fix For: 2.12
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We need to improve how inline size is calculated by default for
> variable-length types.
> Currently if a varlength type is encountered inline size just defaults to 10,
> which is almost always not enough.
> A more sensible behavior would be the following:
> 1. Add a fixed default to the inline size calculation for every
> variable-length type. For example, if the default inlined size for a string
> is 10 then an index like (INT, VARCHAR, VARCHAR, INT) should have inline size
> default as 5 + 10 + 10 + 5 = 30 (5 for each int, 10 for each string).
> 2. Add special support for VARCHAR_FIXED - if a VARCHAR has known length then
> that length is used for inline size calculation
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-13364) Improve index inline defaults
[ https://issues.apache.org/jira/browse/IGNITE-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360921#comment-17360921 ] Maksim Timonin commented on IGNITE-13364: - Hi [~slukyanov] ! I've submitted a new patch [1] for this ticket. Could you please have a look? [1] https://github.com/apache/ignite/pull/9167 > Improve index inline defaults > -- > > Key: IGNITE-13364 > URL: https://issues.apache.org/jira/browse/IGNITE-13364 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Evgeniy Rudenko >Assignee: Maksim Timonin >Priority: Major > Fix For: 2.12 > > Time Spent: 50m > Remaining Estimate: 0h > > We need to improve how inline size is calculated by default for > variable-length types. > Currently if a varlength type is encountered inline size just defaults to 10, > which is almost always not enough. > A more sensible behavior would be the following: > 1. Add a fixed default to the inline size calculation for every > variable-length type. For example, if the default inlined size for a string > is 10 then an index like (INT, VARCHAR, VARCHAR, INT) should have inline size > default as 5 + 10 + 10 + 5 = 30 (5 for each int, 10 for each string). > 2. Add special support for VARCHAR_FIXED - if a VARCHAR has known length then > that length is used for inline size calculation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13364) Improve index inline defaults
[ https://issues.apache.org/jira/browse/IGNITE-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261316#comment-17261316 ] Stanislav Lukyanov commented on IGNITE-13364: - The patch LGTM! I've started a devlist discussion on this since this has a compatibility impact and probably should be discussed before merging. https://lists.apache.org/thread.html/r22ca5271f590816517d4afbc7df633c1c3f39d01657241902e710595%40%3Cdev.ignite.apache.org%3E > Improve index inline defaults > -- > > Key: IGNITE-13364 > URL: https://issues.apache.org/jira/browse/IGNITE-13364 > Project: Ignite > Issue Type: Improvement > Components: sql >Reporter: Evgeniy Rudenko >Assignee: Evgeniy Rudenko >Priority: Major > Fix For: 2.10 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We need to improve how inline size is calculated by default for > variable-length types. > Currently if a varlength type is encountered inline size just defaults to 10, > which is almost always not enough. > A more sensible behavior would be the following: > 1. Add a fixed default to the inline size calculation for every > variable-length type. For example, if the default inlined size for a string > is 10 then an index like (INT, VARCHAR, VARCHAR, INT) should have inline size > default as 5 + 10 + 10 + 5 = 30 (5 for each int, 10 for each string). > 2. Add special support for VARCHAR_FIXED - if a VARCHAR has known length then > that length is used for inline size calculation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-13364) Improve index inline defaults
[
https://issues.apache.org/jira/browse/IGNITE-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180175#comment-17180175
]
Ignite TC Bot commented on IGNITE-13364:
{panel:title=Branch: [pull/8161/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8161/head] Base: [master] : New Tests
(7)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Cache 5{color} [[tests
7|https://ci.ignite.apache.org/viewLog.html?buildId=5549471]]
* {color:#013220}IgniteCacheWithIndexingTestSuite:
H2ComputeInlineSizeTest.testDefaultSizeForByteArray - PASSED{color}
* {color:#013220}IgniteCacheWithIndexingTestSuite:
H2ComputeInlineSizeTest.testDefaultSizeForLargeIndex - PASSED{color}
* {color:#013220}IgniteCacheWithIndexingTestSuite:
H2ComputeInlineSizeTest.testDefaultSizeForCompositeIndex - PASSED{color}
* {color:#013220}IgniteCacheWithIndexingTestSuite:
H2ComputeInlineSizeTest.testDefaultSizeForString - PASSED{color}
* {color:#013220}IgniteCacheWithIndexingTestSuite:
H2ComputeInlineSizeTest.testDefaultSizeForStringWithDefinedLength -
PASSED{color}
* {color:#013220}IgniteCacheWithIndexingTestSuite:
H2ComputeInlineSizeTest.testDefaultSizeForStringWithIncorrectSql - PASSED{color}
* {color:#013220}IgniteCacheWithIndexingTestSuite:
H2ComputeInlineSizeTest.testDefaultSizeForBytesWithDefinedLength - PASSED{color}
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5549457buildTypeId=IgniteTests24Java8_RunAll]
> Improve index inline defaults
> --
>
> Key: IGNITE-13364
> URL: https://issues.apache.org/jira/browse/IGNITE-13364
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Evgeniy Rudenko
>Assignee: Evgeniy Rudenko
>Priority: Major
> Fix For: 2.10
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We need to improve how inline size is calculated by default for
> variable-length types.
> Currently if a varlength type is encountered inline size just defaults to 10,
> which is almost always not enough.
> A more sensible behavior would be the following:
> 1. Add a fixed default to the inline size calculation for every
> variable-length type. For example, if the default inlined size for a string
> is 10 then an index like (INT, VARCHAR, VARCHAR, INT) should have inline size
> default as 5 + 10 + 10 + 5 = 30 (5 for each int, 10 for each string).
> 2. Add special support for VARCHAR_FIXED - if a VARCHAR has known length then
> that length is used for inline size calculation
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
