[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142578#comment-15142578 ] Anton Vinogradov commented on IGNITE-2555: -- Konstantin, You can set it at "..." - > Changes -> Build branch. Anyway, I already run "Run Cache", lets wait for results http://204.14.53.151/project.html?projectId=IgniteTests_IgniteTests=pull%2F468%2Fmerge > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143026#comment-15143026 ] ASF GitHub Bot commented on IGNITE-2555: Github user ruskim closed the pull request at: https://github.com/apache/ignite/pull/468 > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142534#comment-15142534 ] Konstantin Margorin commented on IGNITE-2555: - Hi Anton. I updated the test and included it to IgniteBasicTestSuite. Ignite Basic tests passed: http://204.14.53.151/viewLog.html?buildId=112610=buildChangesDiv=IgniteTests_IgniteBasic But looks like I could not run "Run Cache" tash with my patch - there is no option to select my patch there. > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141036#comment-15141036 ] Konstantin Margorin commented on IGNITE-2555: - Anton, I added test for checking local node metrics logging. Should I add it to any test suite? > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141055#comment-15141055 ] Anton Vinogradov commented on IGNITE-2555: -- Konstantin, Pullrequest looks good to me. But, as I told before, each commit should be covered by tests. As far as I can see metrics works when log.isInfoEnabled() is true and IgniteConfiguration.getMetricsLogFrequency() is not null. I see no tests where metricsLogFrequency set to non default value. So, before merging changes to master new test should be created with metricsLogFrequency set to 1 second, and log.isInfoEnabled is true. This test should start couple of nodes and check somehow that nodes alive 20 seconds later. For example you may check that cache put/get works. Also, good point is to add one more test that checks output is correct. You can set custom IgniteLogger to IgniteConfiguration and check input of info() method. > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141068#comment-15141068 ] Anton Vinogradov commented on IGNITE-2555: -- Konstantin, Your answer was right before mine :) Yes, test should be added to some suite. IgniteBasicTestSuite seems to be a good enough. Please add second node to test and check they both alive after 10 seconds. After that please run "Run Cache" tash at TeamCity and check results. In case you'll gain some test fails please check they also fails at master branch. > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141060#comment-15141060 ] Konstantin Margorin commented on IGNITE-2555: - Looks like collision :) My test is already in pull request. > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140571#comment-15140571 ] Konstantin Margorin commented on IGNITE-2555: - Anton, thank you for explanation. License & Javadoc tests passed at TeamCity: http://204.14.53.151/viewType.html?buildTypeId=IgniteTests_RatJavadoc_IgniteTests=pull%2F468%2Fmerge=buildTypeStatusDiv Looks like there are no other test suites affected by my patch. What I need to do more, to complete the task? > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140603#comment-15140603 ] Anton Vinogradov commented on IGNITE-2555: -- Konstantin, I see you changed IgniteKernal, one of the main classes at Apache Ignite. So, you need to find or write test covers your changes. Did you use existing test to check your changes? We have to ensure that changes brings no NullPointerException or something like that. I recomend you to run all cache suites, and suits contains tests that covers changes. > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140527#comment-15140527 ] ASF GitHub Bot commented on IGNITE-2555: Github user ruskim closed the pull request at: https://github.com/apache/ignite/pull/468 > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140534#comment-15140534 ] Anton Vinogradov commented on IGNITE-2555: -- Konstantin, You should check your changes at Ignite TeamCity before review. See https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute for details. > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140533#comment-15140533 ] ASF GitHub Bot commented on IGNITE-2555: GitHub user ruskim reopened a pull request: https://github.com/apache/ignite/pull/468 IGNITE-2555 fix Added offheap usage (used/free/committed) to local node reports. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ruskim/ignite IGNITE-2555 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/468.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #468 commit db1417f98133d35e10ae4acd20428b51e2b1 Author: ruskimDate: 2016-02-09T18:06:32Z fix IGNITE-2555 commit 78dfb1815a8ffda8aae8a6471e13a73a9a4cfa78 Author: ruskim Date: 2016-02-10T08:55:31Z added node uptime to ket parameters log > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Assignee: Konstantin Margorin >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139386#comment-15139386 ] ASF GitHub Bot commented on IGNITE-2555: GitHub user ruskim opened a pull request: https://github.com/apache/ignite/pull/468 IGNITE-2555 fix Added offheap usage (used/free/committed) to local node reports. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ruskim/ignite IGNITE-2555 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/468.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #468 commit db1417f98133d35e10ae4acd20428b51e2b1 Author: ruskimDate: 2016-02-09T18:06:32Z fix IGNITE-2555 > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
[ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138843#comment-15138843 ] Vladimir Ozerov commented on IGNITE-2555: - Corresponding code could be found in IgniteKernal class (look for the phrase "Metrics for local node"). Essentially, we need to process "m.getNonHeap*" methods in the same way as we did that for "m.getHeap*". > Include offheap usage in metrics report > --- > > Key: IGNITE-2555 > URL: https://issues.apache.org/jira/browse/IGNITE-2555 > Project: Ignite > Issue Type: Task >Affects Versions: 1.5.0.final >Reporter: Sergey Kozlov >Priority: Minor > Labels: newbie > > The local node prints out the set of key parameters in its log (or console). > It makes sense to add offheap usage (used/free/committed) to that report. > {noformat} > Metrics for local node (to disable set 'metricsLogFrequency' to 0) > ^-- Node [id=41b12e0f, name=null] > ^-- H/N/C [hosts=1, nodes=14, CPUs=8] > ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%] > ^-- Heap [used=1364MB, free=27,44%, comm=1881MB] > ^-- Public thread pool [active=0, idle=16, qSize=0] > ^-- System thread pool [active=1, idle=15, qSize=0] > ^-- Outbound messages queue [size=0] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)