[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029580#comment-16029580 ] ASF GitHub Bot commented on IGNITE-4795: Github user SomeFire closed the pull request at: https://github.com/apache/ignite/pull/1630 > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, sql, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation, important > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965880#comment-15965880 ] Andrey Gura commented on IGNITE-4795: - Code changes and TC look good to me. Merged into master branch. [~SomeFire], thanks a lot for your contribution. > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation, important > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963294#comment-15963294 ] Andrey Gura commented on IGNITE-4795: - [~SomeFire], thanks again. I've reviewed and your changes looks good to me. Waiting for TC. > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation, important > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960457#comment-15960457 ] Ryabov Dmitrii commented on IGNITE-4795: [~agura], I finished fixes. Can you look it again? > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation, important > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955467#comment-15955467 ] Andrey Gura commented on IGNITE-4795: - [~SomeFire], Yes, I think that {{TransactionCheckedException}} should be removed. From my point of view it is redundant entity. About 3 item. I think we should emphasize that all methods that throw {{TransactionException}} have transactional behaviour in case of cache with atomicity mode {{TRANSACTIONAL}}. > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation, important > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955212#comment-15955212 ] Ryabov Dmitrii commented on IGNITE-4795: [~agura], I made fix, can you look it? About third item - I have no idea how to describe it more. Is it enough or can you orient me with advice? About {{TransactionCheckedException}} - Avoid? Do you mean remove it completely? > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation, important > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945603#comment-15945603 ] Andrey Gura commented on IGNITE-4795: - [~SomeFire], I've reviewd your changes and have a couple comments: * {{TransactionException}} class. Please javadoc for constructors and linked items ({{link}} javadoc tag). Also header with Apache license should be added. * {{TransactionException}} class. And javadoc that makes some clarification about transactional behaviour. See issue description, item 3: "Make extensive documentation in the header of TransactionException to get understanding of transactional and non-transactional methods behaviour." * {{TransactionDeadlockException}} class. Unused import. * {{TransactionHeuristicException}} class. Unused import. * {{TransactionOptimisticException}} class. Unused import. * {{TransactionRollbackException}} class. Unused import. * {{TransactionTimeoutException}} class. Unused import. * {{Transaction}} class. Please, rollback your changes. This interface should not be chnaged. * {{IgniteCache}} class. Please improve javadoc ("Transactions paragraph"). Just describe that transactional methods throw {{TransactionException}}. * {{IgniteCache}} class. Please replace in javadoc items like this {{@see org.apache.ignite.transactions.TransactionException}} to {{throws}} tags, document this tags and add {{TransactionException}} to {{throws}} clause for all transactional methods. * {{IgniteCache}} Please merge latest changes from master into your branch and make similar changes for methods for {{Async}} suffix. > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation, important > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929538#comment-15929538 ] ASF GitHub Bot commented on IGNITE-4795: Github user SomeFire closed the pull request at: https://github.com/apache/ignite/pull/1631 > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929536#comment-15929536 ] ASF GitHub Bot commented on IGNITE-4795: GitHub user SomeFire opened a pull request: https://github.com/apache/ignite/pull/1631 IGNITE-4795 +licensies You can merge this pull request into a Git repository by running: $ git pull https://github.com/SomeFire/ignite ignite-4795 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1631.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1631 commit 630f6db753e1fee024209cd122b7f3aae991cee4 Author: Дмитрий Рябов Date: 2017-03-06T12:53:27Z Merge pull request #2 from apache/master update commit 009c3943fab8483cf72f4408595140be14e2410b Author: Dmitrii Ryabov Date: 2017-03-07T12:50:51Z TransactionException created and nested by concrete exceptions. commit f006e1f202da292b1d29f09dc9fbee33f826dda3 Author: Dmitrii Ryabov Date: 2017-03-10T12:14:37Z TransactionException created and nested by concrete exceptions. commit 61a6a8e37775280a66ae28348f417f5874cb5373 Author: Dmitrii Ryabov Date: 2017-03-10T12:16:38Z TransactionCheckedException created and nested by IgniteTx...CheckedException. Some IgniteCheckedException throws changed to TCE throws. commit 1be332720846c2ec8ebe7bfca13c9d1fb63ff1d3 Author: Dmitrii Ryabov Date: 2017-03-14T14:31:16Z Added note about visibility of changes inside transaction. commit 1afa5b6b9af89e73ec3262d1475acce509f5 Author: Dmitrii Ryabov Date: 2017-03-17T07:33:16Z Licensies to TE and TCE. > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928333#comment-15928333 ] Ryabov Dmitrii commented on IGNITE-4795: I'm not sure what to add to javadoc, couse methods already have {{@throw}} annotation explaining their runtime exceptions. > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928322#comment-15928322 ] ASF GitHub Bot commented on IGNITE-4795: GitHub user SomeFire opened a pull request: https://github.com/apache/ignite/pull/1630 IGNITE-4795 IGNITE-4795 TransactionException marker created. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SomeFire/ignite master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1630.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1630 commit 630f6db753e1fee024209cd122b7f3aae991cee4 Author: Дмитрий Рябов Date: 2017-03-06T12:53:27Z Merge pull request #2 from apache/master update commit 009c3943fab8483cf72f4408595140be14e2410b Author: Dmitrii Ryabov Date: 2017-03-07T12:50:51Z TransactionException created and nested by concrete exceptions. commit f006e1f202da292b1d29f09dc9fbee33f826dda3 Author: Dmitrii Ryabov Date: 2017-03-10T12:14:37Z TransactionException created and nested by concrete exceptions. commit 61a6a8e37775280a66ae28348f417f5874cb5373 Author: Dmitrii Ryabov Date: 2017-03-10T12:16:38Z TransactionCheckedException created and nested by IgniteTx...CheckedException. Some IgniteCheckedException throws changed to TCE throws. commit 1be332720846c2ec8ebe7bfca13c9d1fb63ff1d3 Author: Dmitrii Ryabov Date: 2017-03-14T14:31:16Z Added note about visibility of changes inside transaction. commit a771d755cc807a62832ae3a97918aca5c980ce35 Author: Дмитрий Рябов Date: 2017-03-16T15:55:35Z IGNITE-4795 IGNITE-4795 TransactionExceptions. > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924361#comment-15924361 ] Ryabov Dmitrii commented on IGNITE-4795: [~ein], I added note about put/get (item 4) in javadoc of Transaction class. But I'm not sure about third item. I don't know what to write about methods behaviour. Can you suggest anything? You also can check my changes here https://github.com/SomeFire/ignite/pull/3/files > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902443#comment-15902443 ] Alexandr Kuramshin commented on IGNITE-4795: [~SomeFire], I think all be the winner of that. > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899223#comment-15899223 ] Ryabov Dmitrii commented on IGNITE-4795: [~ein], what about IgniteTxTimeoutCheckedException and other transaction checked exceptions? Do we need TransactionCheckedException marker? > Inherit TransactionException and update Javadoc > --- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website >Affects Versions: 1.8 >Reporter: Alexandr Kuramshin >Assignee: Ryabov Dmitrii > Labels: documentation > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)