[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-04-19 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974810#comment-15974810
 ] 

Andrey Gura commented on IGNITE-4797:
-

Hi, [~kay_jpr]

Thanks you very much for your contribution. But during work on new page memory 
architecture offheap metrics were totally reworked so I can't merge your change.

Thanks again.

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>Assignee: Kartik Somani
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-04-10 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963292#comment-15963292
 ] 

Andrey Gura commented on IGNITE-4797:
-

[~kay_jpr],

thank, I'll take a look during this week.

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>Assignee: Kartik Somani
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-04-05 Thread Kartik Somani (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957196#comment-15957196
 ] 

Kartik Somani commented on IGNITE-4797:
---

I've addressed your comments [~agura], and raised another pull request. Please 
review

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>Assignee: Kartik Somani
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-04-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957185#comment-15957185
 ] 

ASF GitHub Bot commented on IGNITE-4797:


GitHub user kartiksomani opened a pull request:

https://github.com/apache/ignite/pull/1743

ignite-4797: Added API for system allocated size in CacheMetrics

Addressed comments made by Andrey Gura

https://issues.apache.org/jira/browse/IGNITE-4797


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kartiksomani/ignite ignite-4797

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1743


commit 4d02758bedc01ad9da2ada23b1ce3fbc62610f91
Author: Kartik Somani 
Date:   2017-04-05T16:32:40Z

ignite-4797: Added API for system allocated size in CacheMetrics




> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>Assignee: Kartik Somani
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-03-21 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935342#comment-15935342
 ] 

Andrey Gura commented on IGNITE-4797:
-

[~kay_jpr] I've review your changes and have a few comments (see below):

# {{CacheMetricsSnapshot}} class has copying constructor that performs some 
aggregations. It also should take into account system allocated size.
# {{CacheMetricsSnapshot}} class implements {{Externalizable}} interface. 
Please add system allocation size serialization related code.
# System allocated size should be add to {{ClusterMetricsSnapshot}} class. 
Please look at usage of {{nonHeapUsed}} field and implement logic in a similar 
way.
# It seems that better name for method in MBean is 
{{getOffheapSystemAllocatedSize}}.

Could you please fix this comments.

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>Assignee: Kartik Somani
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-03-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932246#comment-15932246
 ] 

ASF GitHub Bot commented on IGNITE-4797:


GitHub user kartiksomani opened a pull request:

https://github.com/apache/ignite/pull/1640

ignite-4797: Added API for system allocated size in CacheMetrics

Added getSystemAllocatedSize API 
(https://issues.apache.org/jira/browse/IGNITE-4797) to expose offHeap memory 
allocated for internal data structures.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kartiksomani/ignite master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1640


commit 06bdac750ca369a9f7b047cd7ea5a3707d2dc974
Author: Kartik Somani 
Date:   2017-03-20T06:05:41Z

ignite-4797: Added API for system allocated size in CacheMetrics




> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>Assignee: Kartik Somani
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-03-13 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907129#comment-15907129
 ] 

Andrey Gura commented on IGNITE-4797:
-

[~kay_jpr]

Yes, it will. It's right direction.

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>Assignee: Kartik Somani
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-03-12 Thread Kartik Somani (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906476#comment-15906476
 ] 

Kartik Somani commented on IGNITE-4797:
---

[My First Bug]
The approach that I see is, I'll add the interface for getSystemAllocatedSize() 
to the CacheMetrics and CacheMetricsMxBean Interface. In CacheMetricsImpl, I'll 
use GridCacheContext object (cctx) object to get and return the 
systemAllocatedSize using : cctx.unsafeMemory.systemAllocatedSize(). 

CacheLocalMetricsMxBean will then call cache.metrics0.getSystemAllocatedSize() 
to return the metric.

Will this work?

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>Assignee: Kartik Somani
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-03-09 Thread Kartik Somani (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903713#comment-15903713
 ] 

Kartik Somani commented on IGNITE-4797:
---

Sure I'll do that. Thank you.

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-03-09 Thread Andrey Gura (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902883#comment-15902883
 ] 

Andrey Gura commented on IGNITE-4797:
-

[~kay_jpr] Could you please send mail to Apache Ignite dev list and ask to add 
you to contributors lists?

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (IGNITE-4797) Need to expose offheap memory allocated size metric for internal data structures

2017-03-07 Thread Kartik Somani (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900020#comment-15900020
 ] 

Kartik Somani commented on IGNITE-4797:
---

I would like to work on this as my first ticket here. How can I assign it to 
myself?

> Need to expose offheap memory allocated size metric for internal data 
> structures
> 
>
> Key: IGNITE-4797
> URL: https://issues.apache.org/jira/browse/IGNITE-4797
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Andrey Gura
>  Labels: newbie
> Fix For: 2.0
>
>
> Offheap caches expose offheap memory allocated size via 
> {{CacheMetricsMXBean.getOffHeapAllocatedSize()}}. But this metric doesn't 
> take into account offheap memory that allocated for internal data structures 
> (GridUnsafeMap and LRU eviction policy). 
> However Ignite collects this metric (see 
> GridUnsafeMemory.systemAllocatedSize() method).
> Need to expose this metric via {{CacheMetricsMXBean}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)