[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179682#comment-16179682
 ] 

ASF GitHub Bot commented on IGNITE-5736:


Github user daradurvs closed the pull request at:

https://github.com/apache/ignite/pull/2425


> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.3
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135164#comment-16135164
 ] 

Vyacheslav Daradur commented on IGNITE-5736:


[~vozerov], 

bq. so I am not sure what is the goal if this task.
The main goal of this task to test a data storing in the compatibility mode in 
a proper way.

bq. All we need is a flag on configuration {e.g. BinaryConfiguration)
Why do you want use a flag on configuration instead of system property?

There are many places with same logic where is used system property, for 
example:  {{BinaryUtils.USE_STR_SERIALIZATION_VER_2}}, 
{{BinaryUtils.WRAP_TREES}}, {{BinaryUtils.FIELDS_SORTED_ORDER}}.

> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.2
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[Vladimir Ozerov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135067#comment-16135067
 ] 

Vladimir Ozerov commented on IGNITE-5736:
-

[~daradurvs], Ignite doesn't support compatibility between releases, so I am 
not sure what is the goal if this task. I think these changes will not be 
included into the product. All we need is a flag on configuration {e.g. 
BinaryConfiguration), which will control whether we write values as varint or 
not. It should be {{false}} by default, so that new Ignite has chances to start 
on persistent data produced by previous version.

I propose to close both IGNITE-5732 and IGNITE-5736 as "Won't Fix" and focus on 
implementation itself. 

> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.2
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127411#comment-16127411
 ] 

Vyacheslav Daradur commented on IGNITE-5736:


[Ci.tests|https://ci.ignite.apache.org/viewLog.html?buildId=767976] looks good 
to me, except CPP-platform. The PR doesn't contain CPP-changes.

> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.2
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121963#comment-16121963
 ] 

Vyacheslav Daradur commented on IGNITE-5736:


[~vozerov], could you please review the test and compatibility module?

> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.2
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121448#comment-16121448
 ] 

Vyacheslav Daradur commented on IGNITE-5736:


[PR-2425|https://github.com/apache/ignite/pull/2425] contains changes of 3 
tasks:
IGNITE-5732 Provide API to test compatibility with old releases
IGNITE-5097 BinaryMarshaller should write ints in "varint" encoding where it 
makes sense (parent issue)
IGNITE-5736 Add test of backward-compatibility (current issue)

[Upsource review 
created.|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-274]

[Upsource link to VarintArraysSizeCompatibilityTest 
only.|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-274?filePath=/modules/compatibility/src/test/java/org/apache/ignite/compatibility/binary/VarintArraysSizeCompatibilityTest.java]

> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.2
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120293#comment-16120293
 ] 

Vyacheslav Daradur commented on IGNITE-5736:


[Link to VarintArraysSizeCompatibilityTest 
only.|https://github.com/dradurvs/ignite/blob/44e50af75b438b3524babe93b0fa64067bb26105/modules/compatibility/src/test/java/org/apache/ignite/compatibility/binary/VarintArraysSizeCompatibilityTest.java]

> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.2
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120026#comment-16120026
 ] 

ASF GitHub Bot commented on IGNITE-5736:


Github user daradurvs closed the pull request at:

https://github.com/apache/ignite/pull/2387


> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.2
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[Vyacheslav Daradur (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112844#comment-16112844
 ] 

Vyacheslav Daradur commented on IGNITE-5736:


[Link to VarintArraysSizeCompatibilityTest 
only.|https://github.com/daradurvs/ignite/blob/c1cddffc986a0f4e3a41a3074f72bb5bf115ef37/modules/core/src/test/java/org/apache/ignite/internal/binary/VarintArraysSizeCompatibilityTest.java]

> Add test of backward-compatibility
> --
>
> Key: IGNITE-5736
> URL: https://issues.apache.org/jira/browse/IGNITE-5736
> Project: Ignite
>  Issue Type: Sub-task
>  Components: general
>Reporter: Vyacheslav Daradur
>Assignee: Vyacheslav Daradur
> Fix For: 2.2
>
>
> Need to add unit-test to test compatibility with AI 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5736) Add test of backward-compatibility

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112840#comment-16112840
 ] 

ASF GitHub Bot commented on IGNITE-5736:


GitHub user daradurvs opened a pull request:

https://github.com/apache/ignite/pull/2387

IGNITE-5736 Add test of backward-compatibility



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daradurvs/ignite ignite-5736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2387


commit 1e1e8432dc936df7c62557575a57c4a159b4bca6
Author: Vyacheslav Daradur 
Date:   2017-05-31T08:41:56Z

ignite-5097: writing arrays length in varint encoding was implemented

commit d162d3e3d9036cddb275b4a3d86b8f5de9795185
Author: daradurvs 
Date:   2017-06-01T18:35:13Z

ignite-5097: doUnsafeWriteUnsignedVarint method was added

commit bfe381b3a7498eb5bebeb25026a43d36656c6041
Author: daradurvs 
Date:   2017-06-04T21:25:48Z

ignite-5097: dotNET - writing arrays length in varint encoding was 
implemented

commit 516fcf41e4e973abf41cdd19acd2c9ea1bfb9445
Author: daradurvs 
Date:   2017-06-04T21:26:00Z

ignite-5097: dotNET - hardcoded hashcode values in the tests were changed 
according to new conditions

commit fb43cbd77e9c83ef1aeb9dced923d9ca094a8be3
Author: Vyacheslav Daradur 
Date:   2017-07-05T20:25:27Z

Merge branch 'master' into ignite-5097_2

commit 398cb205c26c65f369dc3bdc4198f6032a206e87
Author: daradurvs 
Date:   2017-07-06T18:12:09Z

ignite-5097: compatibility property to allow to keep data in old format was 
added in Java part

commit 4105cf073e0e23f44c0c271407ce5415f867a352
Author: daradurvs 
Date:   2017-07-06T18:12:55Z

ignite-5097: dotNET - compatibility property to allow to keep data in old 
format was added

commit 86082a8052ce2e5c818183a18d16eddf54d5e346
Author: Vyacheslav Daradur 
Date:   2017-07-07T14:15:14Z

ignite-5097: compatibility mode test was added

commit 6aadaa985d021d38accedeaa3ada6790eb1981a9
Author: daradurvs 
Date:   2017-07-07T17:46:56Z

ignite-5097: dotNET - compatibility mode tests were added; fix constant 
condition

commit bd24ccf6e8c2b4deb85cd3ad48635be9addaecd3
Author: Vyacheslav Daradur 
Date:   2017-07-10T15:22:01Z

ignite-5097: dotNET - fix compatibility property condition

commit 5f3e1543c8de140a533d0fbdbfca74a2ffd89a36
Author: Vyacheslav Daradur 
Date:   2017-07-10T15:32:44Z

ignite-5097: rename constant of compatibility mode

commit ac59755342093609c2c9505ccde3308ebf1f1ed4
Author: daradurvs 
Date:   2017-07-10T17:42:00Z

ignite-5097: dotNET - fix compatibility mode test

commit bc2c07a63cd28b2e99d195b1f307c900e0ca
Author: Vyacheslav Daradur 
Date:   2017-07-14T15:02:27Z

ignite-5732: added test plugin to allow join topology nodes with different 
version

commit 45dc0c662f8392ead950c722f63c91e3467683fa
Author: daradurvs 
Date:   2017-08-01T14:53:07Z

ignite-5732: functional of starting node from Maven artifact was added (wip 
commits squashed)

commit 3321b2b48481e7c672cb250bd6c92e22c659d559
Author: daradurvs 
Date:   2017-08-01T15:00:22Z

ignite-5732: added MavenUtils

commit 3a1c2df63d8c30cdf4520083afd6f73a326a906e
Author: daradurvs 
Date:   2017-08-01T16:13:15Z

ignite-5732: minor refactoring

commit c4baa2847cd34a8733cad0929302eb8ecd89beae
Author: daradurvs 
Date:   2017-08-01T17:31:59Z

ignite-5732: minor refactoring 2

commit dbb5df2e8136b2a7b159fd11565d05fa2bd9f076
Author: daradurvs 
Date:   2017-08-02T10:33:14Z

ignite-5732: plugins were moved to another package

commit 8fbf34e3f84d77d6af8b40847eaa2f9faa0075fd
Author: daradurvs 
Date:   2017-08-02T11:10:46Z

ignite-5732: fix spi-attributes error in log

commit 9c205a303dbea0154f683e9514c926f4d53b8d12
Author: daradurvs 
Date:   2017-08-02T13:42:59Z

ignite-5732: refactoring; fixes of review notes

commit 35b56df32c8a9e0a06b9f9803999d3e32035959b
Author: daradurvs 
Date:   2017-08-02T15:24:42Z

ignite-5732: MavenUtils refactoring

commit 4eb47095eb37102f276f240a642a99e6eaedc23b
Author: daradurvs 
Date:   2017-08-02T16:07:55Z

ignite-5732: refactoring according to review note (DRY principle); minor 
style fixes

commit 03b4d916b3a8f7132d06a7f561c3c64d1ee6254f
Author: