[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811868#comment-17811868 ] Anton Vinogradov commented on IGNITE-8801: -- [~scottmf] > what is the implication of making a cache TRANSACTIONAL as opposed to ATOMIC? > IOW, why can't all caches be TRANSACTIONAL? Simple answer is "tx caches are much slower than atomic" and should be used only when special (distributed tx) guaranties are required. > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 5h > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811353#comment-17811353 ] Scott Feldstein commented on IGNITE-8801: - thanks for the response [~timonin.maksim] We noticed this issue when upgrading to 2.16.0 in the Ignite Hibernate L2 cache implementation. There are two caches the {{default-update-timestamps-region}} and {{{}default-query-results-region{}}}, both of these are updated by hibernate in their transactional boundary and we have no control of the precise ordering afaict. For the time being I updated our implementation (which is a mirror of the ignite hibernate impl) to create these caches using TRANSACTIONAL mode. Not sure if that will have any implications for atomic caches since the timestamps and query caches are used for transactional / non-transactional updates. The overall problem that I see is - in frameworks such as hibernate developers may have no control over the precise ordering of updates. This will cause issues where Ignite will not accommodate the desired behavior due to this restriction. That being said, perhaps the switch to TRANSACTIONAL mode for these hibernate internal caches is benign and I'm overreacting :) But I imagine you'll run into issues at some point where developers simply can't control the ordering of updates on caches that can't as easily be switched to TRANSACTIONAL. Question - what is the implication of making a cache TRANSACTIONAL as opposed to ATOMIC? IOW, why can't all caches be TRANSACTIONAL? > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 5h > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809916#comment-17809916 ] Maksim Timonin commented on IGNITE-8801: [~scottmf] hi! This ticket didn't remove the support, it just changed default behavior. The opportunity to use atomic operations within transaction can be enabled with the IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property set to `true`. It works for 2.15. In 2.16 version this opportunity was completely removed in the ticket IGNITE-20579. There was a huge refactoring of Ignite transaction protocol in tickets https://issues.apache.org/jira/browse/IGNITE-19844 and https://issues.apache.org/jira/browse/IGNITE-13871. This behavior makes transactional code more complex and makes bugs more difficult to fix. In more details [~av] can help. It looks like the discussion of the final decision wasn't properly written down on the devlist. While there are scenarios where this behavior might look applicable, it is not safe enough. This is more of an "undocumented feature" than a proper use of Ignite. It is better to split operations across atomic and transactional caches over time, or threads. You can describe your scenario, maybe we can recommend a solution. > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 5h > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808840#comment-17808840 ] Scott Feldstein commented on IGNITE-8801: - hi, i understand this question is really late in the game but could someone explain why this was ultimately merged when the last two comments in the [dev thread|https://lists.apache.org/thread/3wxpx2tw9xnn74139nkqopdom5mh6q74] correctly point out that there are valid use-cases for atomic and transactional caches to be commingled? Was there some other conversation that occurred around this? > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 5h > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641738#comment-17641738 ] Julia Bakulina commented on IGNITE-8801: [~timonin.maksim] thank you for the review > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 5h > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641500#comment-17641500 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : New Tests (3)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#8b}Basic 4{color} [[tests 3|https://ci2.ignite.apache.org/viewLog.html?buildId=6940231]] * {color:#013220}IgniteBasicTestSuite2: AtomicOperationsInTxTest.testSetOfAtomicOperationsWithinTransactionsCheckFalseSystemPropertyTrue - PASSED{color} * {color:#013220}IgniteBasicTestSuite2: AtomicOperationsInTxTest.testSetOfAtomicOperationsWithinTransactionsCheckFalseSystemPropertyFalse - PASSED{color} * {color:#013220}IgniteBasicTestSuite2: AtomicOperationsInTxTest.testAllowAtomicOperationsBeforeTransactionStarts - PASSED{color} {panel} [TeamCity *-- Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6940107buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 4h 50m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640732#comment-17640732 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : New Tests (13)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#8b}PDS 2{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=6819479]] * {color:#013220}IgnitePdsTestSuite2: IgnitePdsCorruptedStoreTest.testNodeInvalidatedWhenPersistenceIsCorrupted - PASSED{color} {color:#8b}Platform .NET (Core Linux){color} [[tests 12|https://ci2.ignite.apache.org/viewLog.html?buildId=6820252]] * {color:#013220}DotNetCore: ComponentModel.Win32Exception (2) - PASSED{color} * {color:#013220}DotNetCore: NetworkInformation.NetworkInformationException (2) - PASSED{color} * {color:#013220}DotNetCore: WebSockets.WebSocketException (2) - PASSED{color} * {color:#013220}DotNetCore: Sockets.SocketException (2) - PASSED{color} * {color:#013220}DotNetCore: ServicesTest.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestAsync.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestAsyncBinaryArrays.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestFullFooter.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestFullFooterBinaryArrays.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ShellTests.TestExecuteSafeLogsException - PASSED{color} * {color:#013220}DotNetCore: ShellTests.TestExecuteSafeReturnsStdout - PASSED{color} ... and 1 new tests {panel} [TeamCity *-- Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6819525buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 4h 50m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640147#comment-17640147 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : New Tests (13)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#8b}PDS 2{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=6819479]] * {color:#013220}IgnitePdsTestSuite2: IgnitePdsCorruptedStoreTest.testNodeInvalidatedWhenPersistenceIsCorrupted - PASSED{color} {color:#8b}Platform .NET (Core Linux){color} [[tests 12|https://ci2.ignite.apache.org/viewLog.html?buildId=6820252]] * {color:#013220}DotNetCore: ComponentModel.Win32Exception (2) - PASSED{color} * {color:#013220}DotNetCore: NetworkInformation.NetworkInformationException (2) - PASSED{color} * {color:#013220}DotNetCore: WebSockets.WebSocketException (2) - PASSED{color} * {color:#013220}DotNetCore: Sockets.SocketException (2) - PASSED{color} * {color:#013220}DotNetCore: ServicesTest.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestAsync.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestAsyncBinaryArrays.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestFullFooter.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestFullFooterBinaryArrays.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ShellTests.TestExecuteSafeLogsException - PASSED{color} * {color:#013220}DotNetCore: ShellTests.TestExecuteSafeReturnsStdout - PASSED{color} ... and 1 new tests {panel} [TeamCity *-- Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6819525buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638675#comment-17638675 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : New Tests (13)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#8b}Platform .NET (Core Linux){color} [[tests 12|https://ci2.ignite.apache.org/viewLog.html?buildId=6820252]] * {color:#013220}DotNetCore: ComponentModel.Win32Exception (2) - PASSED{color} * {color:#013220}DotNetCore: NetworkInformation.NetworkInformationException (2) - PASSED{color} * {color:#013220}DotNetCore: WebSockets.WebSocketException (2) - PASSED{color} * {color:#013220}DotNetCore: Sockets.SocketException (2) - PASSED{color} * {color:#013220}DotNetCore: ServicesTest.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestAsync.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestAsyncBinaryArrays.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestFullFooter.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestFullFooterBinaryArrays.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ShellTests.TestExecuteSafeLogsException - PASSED{color} * {color:#013220}DotNetCore: ShellTests.TestExecuteSafeReturnsStdout - PASSED{color} ... and 1 new tests {color:#8b}PDS 2{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=6819479]] * {color:#013220}IgnitePdsTestSuite2: IgnitePdsCorruptedStoreTest.testNodeInvalidatedWhenPersistenceIsCorrupted - PASSED{color} {panel} [TeamCity *-- Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6819525buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 50m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638561#comment-17638561 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : New Tests (13)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#8b}Platform .NET (Core Linux){color} [[tests 12|https://ci2.ignite.apache.org/viewLog.html?buildId=6820252]] * {color:#013220}DotNetCore: ComponentModel.Win32Exception (2) - PASSED{color} * {color:#013220}DotNetCore: NetworkInformation.NetworkInformationException (2) - PASSED{color} * {color:#013220}DotNetCore: WebSockets.WebSocketException (2) - PASSED{color} * {color:#013220}DotNetCore: Sockets.SocketException (2) - PASSED{color} * {color:#013220}DotNetCore: ServicesTest.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestAsync.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestAsyncBinaryArrays.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestFullFooter.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ServicesTestFullFooterBinaryArrays.TestDeploymentExceptionSerializable - PASSED{color} * {color:#013220}DotNetCore: ShellTests.TestExecuteSafeLogsException - PASSED{color} * {color:#013220}DotNetCore: ShellTests.TestExecuteSafeReturnsStdout - PASSED{color} ... and 1 new tests {color:#8b}PDS 2{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=6819479]] * {color:#013220}IgnitePdsTestSuite2: IgnitePdsCorruptedStoreTest.testNodeInvalidatedWhenPersistenceIsCorrupted - PASSED{color} {panel} [TeamCity *-- Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6819525buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 50m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637653#comment-17637653 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : New Tests (1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1} {color:#8b}PDS 2{color} [[tests 1|https://ci2.ignite.apache.org/viewLog.html?buildId=6819479]] * {color:#013220}IgnitePdsTestSuite2: IgnitePdsCorruptedStoreTest.testNodeInvalidatedWhenPersistenceIsCorrupted - PASSED{color} {panel} [TeamCity *-- Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6819525buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 50m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629540#comment-17629540 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel} [TeamCity *-- Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6819525buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 40m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628287#comment-17628287 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel} [TeamCity *-- Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=6833260buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Fix For: 2.15 > > Time Spent: 40m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > {{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As per the latest round of discussion on Ignite Dev List as of 28/10/2022 we > agreed on the following: > 1) Revert deprecation IGNITE-17916 - reverted > 2) Change default value in 2.15. > 3) Notify users in release notes, an exception message - how to change the > behavior back. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627669#comment-17627669 ] Julia Bakulina commented on IGNITE-8801: As from devlist as of 28/10/2022: 1. Revert deprecation IGNITE-17916 - reverted 2. Change default value in 2.15. 3. Notify users in release notes, an exception message - how to change the behavior back. > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Time Spent: 40m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > \{{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As decided during the discussion in Ignite Dev List, we need to break changes > of IGNITE-8801 into 2 steps: > 1) deprecate IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property during the next > release - IGNITE-17916; > 2) delete this property in the release after the next one - IGNITE-8801. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627581#comment-17627581 ] Maksim Timonin commented on IGNITE-8801: Link to devlist [https://lists.apache.org/thread/3wxpx2tw9xnn74139nkqopdom5mh6q74] Let's make this ticket now. > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Time Spent: 40m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > \{{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As decided during the discussion in Ignite Dev List, we need to break changes > of IGNITE-8801 into 2 steps: > 1) deprecate IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property during the next > release - IGNITE-17916; > 2) delete this property in the release after the next one - IGNITE-8801. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619747#comment-17619747 ] Julia Bakulina commented on IGNITE-8801: As decided on DevList, the ticket is divided into two parts: - IGNITE-17916 - deprecates IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property in version 2.15.0. - IGNITE-8801 - deletes IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property in version 2.16.0. That is why this ticket is still unresolved and waits for 2.16.0 version > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Time Spent: 40m > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > \{{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. > As decided during the discussion in Ignite Dev List, we need to break changes > of IGNITE-8801 into 2 steps: > 1) deprecate IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property during the next > release - IGNITE-17916; > 2) delete this property in the release after the next one - IGNITE-8801. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617751#comment-17617751 ] Julia Bakulina commented on IGNITE-8801: [~timoninmaxim], hi, please review the changes > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Time Spent: 0.5h > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > \{{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617741#comment-17617741 ] Ignite TC Bot commented on IGNITE-8801: --- {panel:title=Branch: [pull/10318/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel} {panel:title=Branch: [pull/10318/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel} [TeamCity *-- Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6819525buildTypeId=IgniteTests24Java8_RunAll] > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > Time Spent: 0.5h > Remaining Estimate: 0h > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > \{{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614107#comment-17614107 ] Ryabov Dmitrii commented on IGNITE-8801: Yes, you can take it. > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Julia Bakulina >Priority: Minor > Labels: ise > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > \{{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614099#comment-17614099 ] Julia Bakulina commented on IGNITE-8801: [~SomeFire] Hello Dmitrii, don't you mind if I take this ticket? I would like to solve this issue > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Sub-task >Reporter: Ryabov Dmitrii >Assignee: Ryabov Dmitrii >Priority: Minor > Labels: ise > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > \{{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (IGNITE-8801) Change default behaviour of atomic operations inside transactions
[ https://issues.apache.org/jira/browse/IGNITE-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532721#comment-16532721 ] ASF GitHub Bot commented on IGNITE-8801: GitHub user SomeFire opened a pull request: https://github.com/apache/ignite/pull/4304 IGNITE-8801 Change default behaviour of atomic operations inside txs You can merge this pull request into a Git repository by running: $ git pull https://github.com/SomeFire/ignite ignite-8801 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4304 commit 2437cc03edaf183f73a646fc682da515ec4867c5 Author: Dmitrii Ryabov Date: 2018-07-04T09:35:18Z IGNITE-8801 Change default behaviour of atomic operations inside transactions > Change default behaviour of atomic operations inside transactions > - > > Key: IGNITE-8801 > URL: https://issues.apache.org/jira/browse/IGNITE-8801 > Project: Ignite > Issue Type: Task >Reporter: Ryabov Dmitrii >Assignee: Ryabov Dmitrii >Priority: Minor > Fix For: 3.0 > > > Need to change default behaviour of atomic operations to fail inside > transactions. > 1) Remove IGNITE_ALLOW_ATOMIC_OPS_IN_TX system property. > 2) Set default value to restrict atomic operations in > \{{CacheOperationContext}} constructor without arguments and arguments for > calls of another constructor. > 3) Fix javadocs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)