[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630642#comment-16630642
]
ASF GitHub Bot commented on IGNITE-9549:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/4734
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
> Fix For: 2.7
>
> Attachments: Possible blockers.png,
> org.apache.ignite.internal.processors.cache.query.CacheScanQueryFailoverTest#testScanQueryWithFailedClosures.png,
>
> org.apache.ignite.internal.processors.query.h2.GridIndexRebuildWithMvccEnabledSelfTest#testIndexRebuild.png,
> screenshot-1.png
>
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629897#comment-16629897
]
Ignite TC Bot commented on IGNITE-9549:
---
{panel:title=Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform C++ (Windows x86){color} [[tests 48 TIMEOUT , Out Of
Memory Error , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=1939127]]
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorAddDouble - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorConcatString - 9,0% fails
in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorDivDouble - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorEquealInt - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorGreaterDouble - 9,0% fails
in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorGreaterEquealInt - 9,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorGreaterInt - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorLessDouble - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorLessEquealInt - 9,0% fails
in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorLessInt - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorModDouble - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorMultDouble - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorMultInt - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorNotEquealInt - 9,0% fails
in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorSubDouble - 9,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorAddInt - 8,0% fails in last
100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorDivInt - 8,0% fails in last
100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorEquealDouble - 8,0% fails
in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorGreaterEquealDouble - 8,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorGreaterString - 8,0% fails
in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorLessEquealDouble - 8,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorLessString - 8,0% fails in
last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorModInt - 8,0% fails in last
100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorNotEquealDouble - 8,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorSubInt - 8,0% fails in last
100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionRand - 7,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionRound - 7,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionSign - 7,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionSin - 7,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionSqrt - 7,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionTan - 7,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionTruncate -
7,0% fails in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorEquealString - 7,0% fails
in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorGreaterEquealString - 7,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlOperatorTestSuite: TestOperatorLessEquealString - 7,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionExp - 6,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionFloor - 6,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionLog - 6,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionLog10 - 6,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionMod - 6,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionPi - 6,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumericFunctionPower - 6,0%
fails in last 100 master runs.
* IgniteOdbcTest: SqlNumericFunctionTestSuite: TestNumeric
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628518#comment-16628518
]
Alexand Polyakov commented on IGNITE-9549:
--
!Possible blockers.png!
!org.apache.ignite.internal.processors.cache.query.CacheScanQueryFailoverTest#testScanQueryWithFailedClosures.png!
!screenshot-1.png!
!org.apache.ignite.internal.processors.query.h2.GridIndexRebuildWithMvccEnabledSelfTest#testIndexRebuild.png!
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
> Fix For: 2.7
>
> Attachments: Possible blockers.png,
> org.apache.ignite.internal.processors.cache.query.CacheScanQueryFailoverTest#testScanQueryWithFailedClosures.png,
>
> org.apache.ignite.internal.processors.query.h2.GridIndexRebuildWithMvccEnabledSelfTest#testIndexRebuild.png,
> screenshot-1.png
>
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628467#comment-16628467
]
Alexand Polyakov commented on IGNITE-9549:
--
add "Licenses Headers"
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
> Fix For: 2.7
>
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628395#comment-16628395
]
Ivan Bessonov commented on IGNITE-9549:
---
[~a-polyakov] did you check test results by yourself? "_Licenses Headers_"
failed because you forgot to add license headers to new classes, please fix it
and inspect other failed tests with low fail rate.
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
> Fix For: 2.7
>
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628377#comment-16628377
]
Alexand Polyakov commented on IGNITE-9549:
--
[~ibessonov] TC retest
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
> Fix For: 2.7
>
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627484#comment-16627484
]
Alexand Polyakov commented on IGNITE-9549:
--
for documentation:
Сбор информации о распределении партиций.
control.sh cache distribution nodeId|null [cacheName1,...,cacheNameN]
[--user-attributes attributeName1[,...,attributeNameN]]
nodeId|null - должен быть указан идентификатор узла или null - запуск на всех
узлах
[cacheName1,...,cacheNameN] имя одного или нескольки кешей, параметр не
обязателен
[--user-attributes attributeName1[,...,attributeNameN]] - дополнительные
атрибуты которые будут считаны с узла
(org.apache.ignite.cluster.ClusterNode#attribute) и добавлены в результат
вывод cache distribution
[groupId,partition,nodeId,primary,state,updateCounter,partitionSize,nodeAddresses]
[next group: id=1544803905, name=default]
1544803905,0,12f01a16,B,OWNING,4,4,[127.0.0.1]
1544803905,0,3d85277a,P,OWNING,4,4,[127.0.0.1]
1544803905,1,12f01a16,P,OWNING,4,4,[127.0.0.1]
если настроен user-attributes то будут соответствующие дополнительные колонки
[groupId,partition,nodeId,primary,state,updateCounter,partitionSize,nodeAddresses,CELL,ZONE,DC]
[next group: id=1544803905, name=default]
1544803905,0,12f01a16,B,OWNING,4,4,[127.0.0.1],1,2,3
1544803905,0,3d85277a,P,OWNING,4,4,[127.0.0.1],1,2,1
1544803905,1,12f01a16,P,OWNING,4,4,[127.0.0.1],1,2,1
1544803905,1,3d85277a,B,OWNING,4,4,[127.0.0.1],1,2,3
partitionSize - количество элементов в партиции
Cброс LOST-партиций (org.apache.ignite.Ignite#resetLostPartitions)
control.sh cache reset_lost_partitions cacheName1[,...,cacheNameN]
cacheName1[,...,cacheNameN] - имена кешей, поле обязательно, минимум 1 кеш
вывод cache reset_lost_partitions
Reset LOST-partitions performed successfully. Cache group (name = 'default', id
= 1544803905), caches ([default]).
Reset LOST-partitions performed successfully. Cache group (name =
'ignite-sys-cache', id = -2100569601), caches ([ignite-sys-cache])
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
> Fix For: 2.7
>
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623389#comment-16623389
]
Ivan Bessonov commented on IGNITE-9549:
---
[~a-polyakov] Please merge latest master and run TC one more time. Current TC
results don't look good.
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
> Fix For: 2.7
>
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623378#comment-16623378
]
Ivan Bessonov commented on IGNITE-9549:
---
[~a-polyakov] Looks good, thank you!
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623369#comment-16623369
]
Alexand Polyakov commented on IGNITE-9549:
--
Hello Ivan, thanks for the comments, PR updated
Re: CacheDistributionTaskResult, line 308, there's a chance that you'll have
several commas in a row if "userAttribute" is null for some reason.
The separator is needed to save the location of the columns
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622135#comment-16622135
]
Ivan Bessonov commented on IGNITE-9549:
---
* User attributes in CommandHandler should probably be trimmed in line 1630,
just like it's done for cache names. Maybe also check empty attributes.
* "New add user attribute in result" javadoc in CacheArguments doesn't look
clear at all. Something like "Additional user attributes." for both methods
would be better. Please also don't skip dots at the end of sentences.
* CacheDistributionTaskResult, line 308, there's a chance that you'll have
several commas in a row if "userAttribute" is null for some reason.
* CacheResetLostPartitionsTaskResult, line 38, technically you could get NPE
here if I understand it correctly.
* "testCacheDistribution" test has non-intuitive asserts in the end, please
add some clarifying comments.
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9549) control.sh add command to collect information on the distribution of partitions and reset lost partitions
[
https://issues.apache.org/jira/browse/IGNITE-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611885#comment-16611885
]
ASF GitHub Bot commented on IGNITE-9549:
GitHub user a-polyakov opened a pull request:
https://github.com/apache/ignite/pull/4734
IGNITE-9549 control.sh add command to collect information on the dist…
…ribution of partitions and reset lost partitions
Signed-off-by: a-polyakov
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/a-polyakov/ignite IGNITE-9549
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/4734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4734
commit 17bc1534e4b8bf9c13cb072ac424a7592d310fba
Author: a-polyakov
Date: 2018-09-12T10:16:34Z
IGNITE-9549 control.sh add command to collect information on the
distribution of partitions and reset lost partitions
Signed-off-by: a-polyakov
> control.sh add command to collect information on the distribution of
> partitions and reset lost partitions
> -
>
> Key: IGNITE-9549
> URL: https://issues.apache.org/jira/browse/IGNITE-9549
> Project: Ignite
> Issue Type: Improvement
>Reporter: Alexand Polyakov
>Assignee: Alexand Polyakov
>Priority: Major
>
> control.sh add command to collect information on the distribution of
> partitions
> {noformat}
> control.sh --cache distribution nodeId|null [cacheName1[,...,cacheNameN]]
> [--user-attributes userAttribute[,...,userAttributeN]]
> {noformat}
> return
> [next group: id=??, name=??]
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> ...
> groupId,partition,nodeId,primary,state,updateCounter,size,nodeAddresses[,userAttribute[,...,userAttributeN]]
> reset lost partitions
> {noformat}
> control.sh --cache reset_lost_partitions cacheName1[,...,cacheNameN]
> {noformat}
> return
> Reset LOST-partitions performed successfully. Cache group (name = '??', id =
> ??)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
