[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 Wicky Tam changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #15 from Wicky Tam --- Thanks for your support! ok, I'll submit 2 bugs.! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 Philippe Mouawad changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #14 from Philippe Mouawad --- (In reply to Wicky Tam from comment #13) > I downloaded the nightly build Jmeter（LATEST > (r1659-30a71a3112e436889d69ab9d2cb5403f4a3ab59c)）and tested it. > > I find that regex extractor and Response Assertion can find the string in > sub-sub-sampler in this version of jmeter. > > It solve the issue of point 2. > > what about other issues? Maybe a thanks would be a good start . For point 1, please open a separate enhancement request. AFAIK , it always worked like this , I am not sure we can change behaviour, so we would add a new option, this needs to be discussed For point 3, please also open a separate bug and clarify how it differs from 1. It's not clear for me. Thank you in advance > > > (In reply to Felix Schumacher from comment #12) > > The fix has been committed. Could you please test the next nightly build? > > > > commit 1a2f24ab25f2a571f7bcb599b4be692eb47dde92 > > AuthorDate: Sun Mar 8 15:26:25 2020 +0100 > > > > Recurse into sub samplers more deeply when checking assertions > > > > With this change we recurse up to three levels into sub results of > > SampleResults > > instead of only one level deep. > > > > This helps in case of parallel downloads of embedded elements of a web > > page, which > > get stored as sub-sub-sampleresults. > > > > Bugzilla Id: 64196 > > --- > > .../org/apache/jmeter/threads/JMeterThread.java| 38 > > +- > > xdocs/changes.xml | 1 + > > 2 files changed, 24 insertions(+), 15 deletions(-) > > > > commit 30a71a3112e436889d69ab9d2cb5403f4a3ab59c > > AuthorDate: Sun Mar 8 16:58:35 2020 +0100 > > > > Recurse into sampleResults for getSampleList > > > > With this change we collect the sampleList of a SampleReult by recursing > > up to > > three levels into sub results of SampleResults instead of only one level > > deep. > > > > This helps in case of parallel downloads of embedded elements of a web > > page, which > > get stored as sub-sub-sampleresults. Before this change a regex Post > > Processor would > > not see those sub-sub-sampleresults. > > > > Bugzilla Id: 64196 > > --- > > .../jmeter/testelement/AbstractScopedTestElement.java | 19 > > ++- > > xdocs/changes.xml | 1 + > > 2 files changed, 19 insertions(+), 1 deletion(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 Wicky Tam changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #13 from Wicky Tam --- I downloaded the nightly build Jmeter（LATEST (r1659-30a71a3112e436889d69ab9d2cb5403f4a3ab59c)）and tested it. I find that regex extractor and Response Assertion can find the string in sub-sub-sampler in this version of jmeter. It solve the issue of point 2. what about other issues? (In reply to Felix Schumacher from comment #12) > The fix has been committed. Could you please test the next nightly build? > > commit 1a2f24ab25f2a571f7bcb599b4be692eb47dde92 > AuthorDate: Sun Mar 8 15:26:25 2020 +0100 > > Recurse into sub samplers more deeply when checking assertions > > With this change we recurse up to three levels into sub results of > SampleResults > instead of only one level deep. > > This helps in case of parallel downloads of embedded elements of a web > page, which > get stored as sub-sub-sampleresults. > > Bugzilla Id: 64196 > --- > .../org/apache/jmeter/threads/JMeterThread.java| 38 > +- > xdocs/changes.xml | 1 + > 2 files changed, 24 insertions(+), 15 deletions(-) > > commit 30a71a3112e436889d69ab9d2cb5403f4a3ab59c > AuthorDate: Sun Mar 8 16:58:35 2020 +0100 > > Recurse into sampleResults for getSampleList > > With this change we collect the sampleList of a SampleReult by recursing > up to > three levels into sub results of SampleResults instead of only one level > deep. > > This helps in case of parallel downloads of embedded elements of a web > page, which > get stored as sub-sub-sampleresults. Before this change a regex Post > Processor would > not see those sub-sub-sampleresults. > > Bugzilla Id: 64196 > --- > .../jmeter/testelement/AbstractScopedTestElement.java | 19 > ++- > xdocs/changes.xml | 1 + > 2 files changed, 19 insertions(+), 1 deletion(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 Felix Schumacher changed: What|Removed |Added Keywords||FixedInTrunk Status|NEW |NEEDINFO --- Comment #12 from Felix Schumacher --- The fix has been committed. Could you please test the next nightly build? commit 1a2f24ab25f2a571f7bcb599b4be692eb47dde92 AuthorDate: Sun Mar 8 15:26:25 2020 +0100 Recurse into sub samplers more deeply when checking assertions With this change we recurse up to three levels into sub results of SampleResults instead of only one level deep. This helps in case of parallel downloads of embedded elements of a web page, which get stored as sub-sub-sampleresults. Bugzilla Id: 64196 --- .../org/apache/jmeter/threads/JMeterThread.java| 38 +- xdocs/changes.xml | 1 + 2 files changed, 24 insertions(+), 15 deletions(-) commit 30a71a3112e436889d69ab9d2cb5403f4a3ab59c AuthorDate: Sun Mar 8 16:58:35 2020 +0100 Recurse into sampleResults for getSampleList With this change we collect the sampleList of a SampleReult by recursing up to three levels into sub results of SampleResults instead of only one level deep. This helps in case of parallel downloads of embedded elements of a web page, which get stored as sub-sub-sampleresults. Before this change a regex Post Processor would not see those sub-sub-sampleresults. Bugzilla Id: 64196 --- .../jmeter/testelement/AbstractScopedTestElement.java | 19 ++- xdocs/changes.xml | 1 + 2 files changed, 19 insertions(+), 1 deletion(-) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 Wicky Tam changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #11 from Wicky Tam --- Due to the failure of patching with the “patch” command, I manually modified the source code of the program according to the patch file you gave me. and I tried my best to compile JMeter, but I failed.Because I'm not good at programming,so I can't do anything now. so could u please help me to compile or do anther thing to solve the problem？Thanks！ (In reply to Felix Schumacher from comment #8) > Created attachment 37073 [details] > Recurse deepr into subsamplers for assertion checks > > I have not found a webpage, that would generate sub-sub-samplers for me, but > I think I know where the recursion has to happen. Would you be able to > compile JMeter with the attached patch for yourself? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #10 from Felix Schumacher --- Created attachment 37075 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37075=edit Recurse into sampleResults to construct getSampleList This will recurse deeper into sub sub samples to get sample lists to be used by regex extractor (for example). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #9 from Felix Schumacher --- Created attachment 37074 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37074=edit Test plan to show that sub-sub-samples are not considered by assertions The attached plan is adapted from the originally submitted plan. It uses a demo site, that is currently online and can be used for testing. It checks, that there is no "file: test1\d.css" found in any of the samples (including sub-samples). If the patch is applied and JMeter recurses into sub-sub-samples, the test plan fails (as intended). So one of the two aspects of this bug should be fixed with the patch. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 Felix Schumacher changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #8 from Felix Schumacher --- Created attachment 37073 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37073=edit Recurse deepr into subsamplers for assertion checks I have not found a webpage, that would generate sub-sub-samplers for me, but I think I know where the recursion has to happen. Would you be able to compile JMeter with the attached patch for yourself? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 Wicky Tam changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #7 from Wicky Tam --- Thanks for your reply. It's the first time that I use this system to submit the bug. I will create 1 issue per item. (In reply to Philippe Mouawad from comment #1) > Hello > > Could you clarify points 2 and 3 with examples and screenshots showing > problems ? > > Also it would be better to create 1 issue per item . > > Thanks -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #6 from Wicky Tam --- attachment 37069/37070/37071 is for point 2.attachment 37072 is for point 3. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #5 from Wicky Tam --- Created attachment 37072 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37072=edit script & screenshot for point 3 based on the script of point 2，but change the regular expressions of Response Assertion to be “(?i)/body”。this regular expressions can match in sub_sampler and not in main sampler. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #4 from Wicky Tam --- Created attachment 37071 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37071=edit result tree -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #3 from Wicky Tam --- Created attachment 37070 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37070=edit the date captured by wireshark -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 --- Comment #2 from Wicky Tam --- Created attachment 37069 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37069=edit the jmeter script -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64196] Response Assertion do wrong when there are sub-requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=64196 Philippe Mouawad changed: What|Removed |Added Status|NEW |NEEDINFO CC||p.mouawad@ubik-ingenierie.c ||om --- Comment #1 from Philippe Mouawad --- Hello Could you clarify points 2 and 3 with examples and screenshots showing problems ? Also it would be better to create 1 issue per item . Thanks -- You are receiving this mail because: You are the assignee for the bug.
