[jira] [Created] (KYLIN-2050) Potentially ineffective call to close() in QueryCli
Ted Yu created KYLIN-2050:
-
Summary: Potentially ineffective call to close() in QueryCli
Key: KYLIN-2050
URL: https://issues.apache.org/jira/browse/KYLIN-2050
Project: Kylin
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Here is related code:
{code}
} finally {
if (rs != null) {
rs.close();
}
if (stmt != null) {
stmt.close();
}
if (conn != null) {
conn.close();
}
}
{code}
If the first or second close() throws exception, the subsequent close() would
be skipped.
This pattern may appear in other class(es).
See
http://stackoverflow.com/questions/2225221/closing-database-connections-in-java
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KYLIN-2039) Refactor REST Request/Response Object into standalone library
[ https://issues.apache.org/jira/browse/KYLIN-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519961#comment-15519961 ] Billy(Yiming) Liu commented on KYLIN-2039: -- Otherwise, there are some duplicated code between JDBC project and Server-Base. > Refactor REST Request/Response Object into standalone library > - > > Key: KYLIN-2039 > URL: https://issues.apache.org/jira/browse/KYLIN-2039 > Project: Kylin > Issue Type: Improvement > Components: REST Service >Reporter: Billy(Yiming) Liu >Assignee: Zhong,Jason >Priority: Minor > > Currently, the Request/Response objects locate at server-base project under > org/apache/kylin/rest/request[response,model]. They are POJOs which are used > to communicate between any REST client and Kylin Server. If someone wants to > integrate Kylin by REST API, he has to import kylin-server library. The > kylin-server is the project to host the Query/Job web server. This is library > will introduce almost all kylin backend libraries indirectly(by pom > dependency). But those are not the required components in client side. So I > will suggest refactoring some REST code into standalone lightweight library, > and make the client-server communication much easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (KYLIN-1843) LRU cache for in memory dimensions
[ https://issues.apache.org/jira/browse/KYLIN-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Billy(Yiming) Liu closed KYLIN-1843. > LRU cache for in memory dimensions > -- > > Key: KYLIN-1843 > URL: https://issues.apache.org/jira/browse/KYLIN-1843 > Project: Kylin > Issue Type: Improvement > Components: Query Engine >Affects Versions: v1.2, v1.5.2 >Reporter: Abhilash L L >Assignee: Billy(Yiming) Liu > Fix For: v1.5.3 > > Attachments: KYLIN-1843.patch > > > The dimensions are kept in memory to fill up the result set. > Now as and when more cubes are created, all the dimensions keep accumulating > in the memory > This means tomcat memory requirements always keep increasing > It would help if less frequently used dimensions are swapped out to keep > memory in check. > We can have a Cache Manager which gets to decide which dimensions are kept in > memory and brings in as and when its required. The size of the cache should > be tuneable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KYLIN-2048) After save model, the new model dialog shows again.
[ https://issues.apache.org/jira/browse/KYLIN-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519926#comment-15519926 ] Billy(Yiming) Liu commented on KYLIN-2048: -- It actually happens everytime. Landing Page ->Click button to New Model -> Save Model ->Should be Landing Page, but be New Model again. >From original process, you may suppose user could create model by model >sequentially. But at most cases, one model is enough. > After save model, the new model dialog shows again. > --- > > Key: KYLIN-2048 > URL: https://issues.apache.org/jira/browse/KYLIN-2048 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v1.5.4 >Reporter: liyang >Assignee: Zhong,Jason > > After save model, the new model dialog shows again, which is not expected. > Instead, it should go back to model landing page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KYLIN-2049) Incorrect AVG result with NULL measure values
liyang created KYLIN-2049: - Summary: Incorrect AVG result with NULL measure values Key: KYLIN-2049 URL: https://issues.apache.org/jira/browse/KYLIN-2049 Project: Kylin Issue Type: Bug Reporter: liyang Thanks to Itay. From - http://stackoverflow.com/questions/39664918/apache-kylin-null-value-measures-become-zeros I'm trying to build a Kylin Cube that will get me the Average of a SmallInt nullable column Col1. I expect any null value to not be counted towards this average. When I work on my table in Hive this is exactly the result that I'm getting when applying the AVG function. However when I build the cube in Kylin on top of this table all the null values in my measurements columns are becoming zeros and then counted towards the calculation of the AVG. Is there a way to force Kylin to treat nulls as nulls? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KYLIN-2048) After save model, the new model dialog shows again.
[ https://issues.apache.org/jira/browse/KYLIN-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519097#comment-15519097 ] Zhong,Jason commented on KYLIN-2048: can no reproduce this. > After save model, the new model dialog shows again. > --- > > Key: KYLIN-2048 > URL: https://issues.apache.org/jira/browse/KYLIN-2048 > Project: Kylin > Issue Type: Bug > Components: Web >Affects Versions: v1.5.4 >Reporter: liyang >Assignee: Zhong,Jason > > After save model, the new model dialog shows again, which is not expected. > Instead, it should go back to model landing page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (KYLIN-2047) Ineffective null check in MetadataManager
[
https://issues.apache.org/jira/browse/KYLIN-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Li resolved KYLIN-2047.
Resolution: Fixed
Fix Version/s: v1.6.0
> Ineffective null check in MetadataManager
> -
>
> Key: KYLIN-2047
> URL: https://issues.apache.org/jira/browse/KYLIN-2047
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Dong Li
>Priority: Minor
> Fix For: v1.6.0
>
>
> {code}
> public DataModelDesc dropModel(DataModelDesc desc) throws IOException {
> logger.info("Dropping model '" + desc.getName() + "'");
> ResourceStore store = getStore();
> if (desc != null)
> store.deleteResource(desc.getResourcePath());
> {code}
> null check for desc is done after dereference, which is ineffective.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (KYLIN-2044) Unclosed DataInputByteBuffer in BitmapCounter#peekLength
[
https://issues.apache.org/jira/browse/KYLIN-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Li resolved KYLIN-2044.
Resolution: Fixed
Fix Version/s: v1.6.0
> Unclosed DataInputByteBuffer in BitmapCounter#peekLength
>
>
> Key: KYLIN-2044
> URL: https://issues.apache.org/jira/browse/KYLIN-2044
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Dong Li
>Priority: Minor
> Fix For: v1.6.0
>
>
> {code}
> DataInputByteBuffer input = new DataInputByteBuffer();
> input.reset(new ByteBuffer[] { in });
> MutableRoaringBitmap bitmap = new MutableRoaringBitmap();
> try {
> bitmap.deserialize(input);
> } catch (IOException e) {
> throw new IllegalStateException(e);
> }
> {code}
> input should be closed upon return from the method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (KYLIN-2045) Wrong argument order in JobInstanceExtractor#executeExtract()
[
https://issues.apache.org/jira/browse/KYLIN-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Li resolved KYLIN-2045.
Resolution: Fixed
Fix Version/s: v1.6.0
> Wrong argument order in JobInstanceExtractor#executeExtract()
> -
>
> Key: KYLIN-2045
> URL: https://issues.apache.org/jira/browse/KYLIN-2045
> Project: Kylin
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Dong Li
> Fix For: v1.6.0
>
>
> {code}
> List jobInstances = listJobInstances(cube, project,
> startTime, endTime);
> {code}
> However, the order of first two arguments is reversed:
> {code}
> private List listJobInstances(String project, String cube,
> long startTime, long endTime) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (KYLIN-2033) Refactor broadcast of metadata change
[ https://issues.apache.org/jira/browse/KYLIN-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liyang resolved KYLIN-2033. --- Resolution: Fixed Fix Version/s: v1.6.0 > Refactor broadcast of metadata change > - > > Key: KYLIN-2033 > URL: https://issues.apache.org/jira/browse/KYLIN-2033 > Project: Kylin > Issue Type: Improvement >Reporter: liyang > Fix For: v1.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KYLIN-2033) Refactor broadcast of metadata change
[ https://issues.apache.org/jira/browse/KYLIN-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liyang reassigned KYLIN-2033: - Assignee: liyang > Refactor broadcast of metadata change > - > > Key: KYLIN-2033 > URL: https://issues.apache.org/jira/browse/KYLIN-2033 > Project: Kylin > Issue Type: Improvement >Reporter: liyang >Assignee: liyang > Fix For: v1.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-2033) Refactor broadcast of metadata change
[ https://issues.apache.org/jira/browse/KYLIN-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liyang updated KYLIN-2033: -- Summary: Refactor broadcast of metadata change (was: Refactor broadcast of metadata) > Refactor broadcast of metadata change > - > > Key: KYLIN-2033 > URL: https://issues.apache.org/jira/browse/KYLIN-2033 > Project: Kylin > Issue Type: Improvement >Reporter: liyang > Fix For: v1.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-2033) Refactor broadcast of metadata
[ https://issues.apache.org/jira/browse/KYLIN-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liyang updated KYLIN-2033: -- Summary: Refactor broadcast of metadata (was: Refactor broadcast to allow extensible entities) > Refactor broadcast of metadata > -- > > Key: KYLIN-2033 > URL: https://issues.apache.org/jira/browse/KYLIN-2033 > Project: Kylin > Issue Type: Improvement >Reporter: liyang > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
