[jira] [Commented] (KYLIN-3251) Add a hook that can customer made test_case_data

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384485#comment-16384485
 ] 

ASF subversion and git services commented on KYLIN-3251:


Commit a05a4d0058976f7a940fdf840643ab7c820ff6e4 in kylin's branch 
refs/heads/sync from [~Aron.tao]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a05a4d0 ]

KYLIN-3251, add a hook that can customize test_case_data and add 
MetadataCleanupJob UT.

minor, refine test.

minor, refine test.


> Add a hook that can customer made test_case_data
> 
>
> Key: KYLIN-3251
> URL: https://issues.apache.org/jira/browse/KYLIN-3251
> Project: Kylin
>  Issue Type: Improvement
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3265) Add "jobSearchMode" as a condition to "/kylin/api/jobs" API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384483#comment-16384483
 ] 

ASF subversion and git services commented on KYLIN-3265:


Commit 0efcf9c9e66879bbee633d9799aa529aefcde543 in kylin's branch 
refs/heads/sync from shaofengshi
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=0efcf9c ]

KYLIN-3265 update test case to cover it


> Add "jobSearchMode" as a condition to "/kylin/api/jobs" API
> ---
>
> Key: KYLIN-3265
> URL: https://issues.apache.org/jira/browse/KYLIN-3265
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Affects Versions: v2.3.0
>Reporter: Shaofeng SHI
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN-3265.master.002.patch, 
> KYLIN-3265.master.003.patch, Screen Shot 2018-02-26 at 1.55.21 PM.png
>
>
> In kylin 2.3, the "/kylin/jobs" API will return both cubing job and 
> checkpoint job together, this changed the API's behavior as there isn't 
> checkpoint job before. We should keep the api only return cubing jobs to be 
> compitable as before, and extend the API to add another condition 
> 'jobSearchMode' to determine which kind of job should be returned. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3233) CacheController can not handle if cacheKey has "/"

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384479#comment-16384479
 ] 

ASF subversion and git services commented on KYLIN-3233:


Commit d63160d2df0ea7db7f919d10a5f94c3f05bb6653 in kylin's branch 
refs/heads/sync from [~Aron.tao]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=d63160d ]

KYLIN-3233, fix CacheController if cacheKey has "/".


> CacheController can not handle if cacheKey has "/"
> --
>
> Key: KYLIN-3233
> URL: https://issues.apache.org/jira/browse/KYLIN-3233
> Project: Kylin
>  Issue Type: Improvement
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3266) Improve CI coverage

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384482#comment-16384482
 ] 

ASF subversion and git services commented on KYLIN-3266:


Commit a040c9a7f419fa1599d35f3becea3f4d67cfcef3 in kylin's branch 
refs/heads/sync from Li Yang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a040c9a ]

KYLIN-3266 improve kylin CI BuildCubeWithEngine coverage


> Improve CI coverage
> ---
>
> Key: KYLIN-3266
> URL: https://issues.apache.org/jira/browse/KYLIN-3266
> Project: Kylin
>  Issue Type: Improvement
>Affects Versions: v2.4.0
>Reporter: liyang
>Assignee: liyang
>Priority: Major
>
> The current CI, aka BuildCubeWithEngine, only test merge on the MR engine. 
> The merge operation is not tested on Spark engine. Need to improve the test 
> coverage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3234) ResourceStore should add a API that can recursively list path.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384480#comment-16384480
 ] 

ASF subversion and git services commented on KYLIN-3234:


Commit 4823d8b0f5b344f4b94b82bd7c8bc1d5bc7bc07a in kylin's branch 
refs/heads/sync from [~Aron.tao]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=4823d8b ]

KYLIN-3234, add HDFS resource store implementation.


> ResourceStore should add a API that can recursively list path.
> --
>
> Key: KYLIN-3234
> URL: https://issues.apache.org/jira/browse/KYLIN-3234
> Project: Kylin
>  Issue Type: Improvement
>Reporter: jiatao.tao
>Assignee: jiatao.tao
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3227) Automatically remove the blank at the end of lines in properties files

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384481#comment-16384481
 ] 

ASF subversion and git services commented on KYLIN-3227:


Commit 24d319eddc58a4ab5a612c11b7a824582afb3b92 in kylin's branch 
refs/heads/sync from GuangYaoLee92
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=24d319e ]

KYLIN-3227 Automatically remove the blank at the end of lines in properties 
files (#4035)


> Automatically remove the blank at the end of lines in properties files
> --
>
> Key: KYLIN-3227
> URL: https://issues.apache.org/jira/browse/KYLIN-3227
> Project: Kylin
>  Issue Type: Bug
>  Components: Environment 
>Affects Versions: v2.2.0
>Reporter: Guangyao Li
>Assignee: Guangyao Li
>Priority: Minor
> Fix For: v2.3.0
>
> Attachments: 
> KYLIN-3277-Automatically-remove-the-blank-at-the-end.patch
>
>
> In the 'kylin.properties' file:
> eg: kylin.engine.spark-conf.spark.executor.instances=1 
> There is a blank space bebind "1"
> The Kylin will startup failure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3267) add override MR config at project/cube level only for mem-hungry build steps like "Build columnar page index"

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384484#comment-16384484
 ] 

ASF subversion and git services commented on KYLIN-3267:


Commit 451b7bae796e47358900678ac18dce24a2e6d8df in kylin's branch 
refs/heads/sync from [~Yifei94]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=451b7ba ]

KYLIN-3267 MR config override at project/cube level only for mem-hungry build 
steps


> add override MR config at project/cube level only for mem-hungry build steps 
> like "Build columnar page index"
> -
>
> Key: KYLIN-3267
> URL: https://issues.apache.org/jira/browse/KYLIN-3267
> Project: Kylin
>  Issue Type: Bug
>Reporter: Yifei Wu
>Assignee: Yifei Wu
>Priority: Major
>
> Currently, users can override MR config at project/cube level via kylin 
> properties {{kylin.engine.mr.config-override.}}
> However, this applies to all MR steps. It is more reasonable to add 
> override-configs only for certain memory-hungry steps like in-mem cubing and 
> "Build columnar page index"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383372#comment-16383372
 ] 

ASF subversion and git services commented on KYLIN-3236:


Commit 39ef73ccade23fe3c0e95ea1e29b5090d9b16e76 in kylin's branch 
refs/heads/master from [~xingpeng1]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=39ef73c ]

KYLIN-3236 The function 'reGenerateAdvancedDict()' has an error logical 
judgment, which will cause an exception when you edit the cube.

Signed-off-by: xingpeng1 


> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.4.0
>
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[Peng Xing (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383367#comment-16383367
 ] 

Peng Xing commented on KYLIN-3236:
--

Hi [~Zhixiong Chen]
Thanks for your reply, the pull request url is 
https://github.com/apache/kylin/pull/110

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383361#comment-16383361
 ] 

ASF GitHub Bot commented on KYLIN-3236:
---

xingpeng1 opened a new pull request #110: KYLIN-3236
URL: https://github.com/apache/kylin/pull/110
 
 
KYLIN-3236 The function 'reGenerateAdvancedDict()' has an error logical 
judgment, which will cause an exception when you edit the cube.
   
   Signed-off-by: xingpeng1 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383362#comment-16383362
 ] 

ASF GitHub Bot commented on KYLIN-3236:
---

asfgit commented on issue #110: KYLIN-3236
URL: https://github.com/apache/kylin/pull/110#issuecomment-369859958
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)