[jira] [Commented] (KYLIN-3811) Support the standalone HBase cluster using HDFS HA
[ https://issues.apache.org/jira/browse/KYLIN-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780192#comment-16780192 ] Chao Long commented on KYLIN-3811: -- Hi Wei, after applying the patch, I found this file KylinLoadIncrementalHFiles make mvn test fail, can you check it? Thank you. Btw, Is it a bug of Hbase? If yes, can we fix it in Hbase? > Support the standalone HBase cluster using HDFS HA > -- > > Key: KYLIN-3811 > URL: https://issues.apache.org/jira/browse/KYLIN-3811 > Project: Kylin > Issue Type: Improvement > Components: Storage - HBase >Affects Versions: v2.3.1 >Reporter: zhangwei >Assignee: zhangwei >Priority: Minor > Attachments: hdfs_ha.patch, hdfs_ha_2.patch, screenshot-1.png > > > 独立hbase 集群的 hdfs namenode主备切换导致Kylin无法正常工作的问题 > 痛点: > ylin.hbase.cluster.fs=hdfs://namenode:54310，在hbase的hdfs namenode切换之后会，和hbase > hdfs相关的步骤会出现失败 > 我们的方案:(所有的修改都基于kylin的代码，不需要hbase 做修改) > kylin.properties > kylin.hbase.cluster.fs=hdfs://nshbase > kylin.storage.hbase.cluster-hdfs-config-file=hbase-hdfs-site.xml > hbase-hdfs-site.xml配置 hbase hdfs的HA连接方式，其中dfs.nameservices= nshbase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] codecov-io edited a comment on issue #492: KYLIN-3835 [Defective TableSchemaUpdateChecker]
codecov-io edited a comment on issue #492: KYLIN-3835 [Defective TableSchemaUpdateChecker] URL: https://github.com/apache/kylin/pull/492#issuecomment-468141136 # [Codecov](https://codecov.io/gh/apache/kylin/pull/492?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@e5c7c0d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/492?src=pr=tree) ```diff @@Coverage Diff@@ ## master #492 +/- ## = Coverage ? 24.45% Complexity? 4963 = Files ? 1144 Lines ?69490 Branches ? 9914 = Hits ?16997 Misses?50775 Partials ? 1718 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/492?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/kylin/metadata/model/DataModelManager.java](https://codecov.io/gh/apache/kylin/pull/492/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsTWFuYWdlci5qYXZh) | `35.18% <ø> (ø)` | `12 <0> (?)` | | | [...e/kylin/rest/service/TableSchemaUpdateChecker.java](https://codecov.io/gh/apache/kylin/pull/492/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNjaGVtYVVwZGF0ZUNoZWNrZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/492/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==) | `14.45% <0%> (ø)` | `9 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/492?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/492?src=pr=footer). Last update [e5c7c0d...53addf3](https://codecov.io/gh/apache/kylin/pull/492?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty
[
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780179#comment-16780179
]
ASF GitHub Bot commented on KYLIN-3836:
---
Wayne1c commented on pull request #493: KYLIN-3836 fix Kylin StringUtil.join()
may cause NPE if iterator is e…
URL: https://github.com/apache/kylin/pull/493
…mpty
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
> Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {quote}
> public static String join(Iterable parts, String separator) {
> StringBuilder buf = new StringBuilder();
> Iterator iterator = parts.iterator();
> if (iterator == null || (!iterator.hasNext())) {
> return null;
> }
> {quote}
> org.apache.kylin.job.exception.ExecuteException:
> org.apache.kylin.job.exception.ExecuteException:
> java.lang.NullPointerException
> at
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
> at
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.kylin.job.exception.ExecuteException:
> java.lang.NullPointerException
> at
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
> at
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
> at
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
> ... 4 more
> Caused by: java.lang.NullPointerException
> at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
> at com.google.common.base.Splitter.split(Splitter.java:383)
> at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
> at
> org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
> at
> org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
> at
> org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
> at
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
> ... 6 more
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] Wayne1c opened a new pull request #493: KYLIN-3836 fix Kylin StringUtil.join() may cause NPE if iterator is e…
Wayne1c opened a new pull request #493: KYLIN-3836 fix Kylin StringUtil.join() may cause NPE if iterator is e… URL: https://github.com/apache/kylin/pull/493 …mpty This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #493: KYLIN-3836 fix Kylin StringUtil.join() may cause NPE if iterator is e…
asfgit commented on issue #493: KYLIN-3836 fix Kylin StringUtil.join() may cause NPE if iterator is e… URL: https://github.com/apache/kylin/pull/493#issuecomment-468157896 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #492: KYLIN-3835 [Defective TableSchemaUpdateChecker]
codecov-io commented on issue #492: KYLIN-3835 [Defective TableSchemaUpdateChecker] URL: https://github.com/apache/kylin/pull/492#issuecomment-468141136 # [Codecov](https://codecov.io/gh/apache/kylin/pull/492?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@e5c7c0d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/492?src=pr=tree) ```diff @@Coverage Diff@@ ## master #492 +/- ## = Coverage ? 24.45% Complexity? 4962 = Files ? 1144 Lines ?69490 Branches ? 9914 = Hits ?16993 Misses?50777 Partials ? 1720 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/492?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/kylin/metadata/model/DataModelManager.java](https://codecov.io/gh/apache/kylin/pull/492/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsTWFuYWdlci5qYXZh) | `35.18% <ø> (ø)` | `12 <0> (?)` | | | [...e/kylin/rest/service/TableSchemaUpdateChecker.java](https://codecov.io/gh/apache/kylin/pull/492/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNjaGVtYVVwZGF0ZUNoZWNrZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/492/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==) | `14.45% <0%> (ø)` | `9 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/492?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/492?src=pr=footer). Last update [e5c7c0d...53addf3](https://codecov.io/gh/apache/kylin/pull/492?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3835) [Defective TableSchemaUpdateChecker] Don't check used models when reload table
[ https://issues.apache.org/jira/browse/KYLIN-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780104#comment-16780104 ] ASF GitHub Bot commented on KYLIN-3835: --- Qsimple commented on pull request #492: KYLIN-3835 [Defective TableSchemaUpdateChecker] URL: https://github.com/apache/kylin/pull/492  1. delete unnecessarily IOException in DataModelManager. 2. change TableSchemaUpdateChecker constructor This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Defective TableSchemaUpdateChecker] Don't check used models when reload table > -- > > Key: KYLIN-3835 > URL: https://issues.apache.org/jira/browse/KYLIN-3835 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.5.2 >Reporter: Yuzhang QIU >Priority: Major > > 1. load table1 from hive. > 2. create model1 based on table1 and use table1.column1 as dimension1 > 3. alter table1.column1 to table1.column11 in hive. > 4. reload table1 successfully. (it's bug) > 5. swicth to model, the model1 still exist. I can create cube1 based on > model1 and launch a build job, of course, the job turn out error after a > period of time. (can't find table1.column1, etc) > 6. reload metadata in system page, the model1 is disappeared from Web UI, and > cube1 change to DESCBROKEN, and can't be deleted due to "null" (trace the > log, I found it's caused by null DataModelDesc in CubeInstance). > 7. I want to recreated the model1, but Kylin tell me model1 already existed > in current project. yes, I use 'sh bin/metadata.sh backup', I found the > model1's metadata is still stored in Hbase. > 8. I hacked the code, the reload table validation is checked in > TableSchemaUpdateChecker.allowLoad(), but it just check the used cubes. If a > model using the changed table without any cube based on it, the table can be > reloaded successfully! > I think it shouldn't be like this. > Best regard -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Qsimple opened a new pull request #492: KYLIN-3835 [Defective TableSchemaUpdateChecker]
Qsimple opened a new pull request #492: KYLIN-3835 [Defective TableSchemaUpdateChecker] URL: https://github.com/apache/kylin/pull/492  1. delete unnecessarily IOException in DataModelManager. 2. change TableSchemaUpdateChecker constructor This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #492: KYLIN-3835 [Defective TableSchemaUpdateChecker]
asfgit commented on issue #492: KYLIN-3835 [Defective TableSchemaUpdateChecker] URL: https://github.com/apache/kylin/pull/492#issuecomment-468136640 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #488: KYLIN-3820 Add a curator-based scheduler
coveralls commented on issue #488: KYLIN-3820 Add a curator-based scheduler URL: https://github.com/apache/kylin/pull/488#issuecomment-468132392 ## Pull Request Test Coverage Report for [Build 4176](https://coveralls.io/builds/21880485) * **114** of **177** **(64.41%)** changed or added relevant lines in **4** files are covered. * **2** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.1%**) to **27.06%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/21880485/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L366) | 0 | 4 | 0.0% | [core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorLeaderSelector.java](https://coveralls.io/builds/21880485/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorLeaderSelector.java#L56) | 30 | 43 | 69.77% | [core-common/src/main/java/org/apache/kylin/common/ServerMode.java](https://coveralls.io/builds/21880485/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FServerMode.java#L21) | 0 | 17 | 0.0% | [core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorScheduler.java](https://coveralls.io/builds/21880485/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorScheduler.java#L89) | 84 | 113 | 74.34% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/21880485/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/21880485/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | Totals | [](https://coveralls.io/builds/21880485) | | :-- | --: | | Change from base [Build 4170](https://coveralls.io/builds/21871775): | 0.1% | | Covered Lines: | 18836 | | Relevant Lines: | 69609 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls edited a comment on issue #489: KYLIN-2620 Make the condition stricter to answer query with topN
coveralls edited a comment on issue #489: KYLIN-2620 Make the condition stricter to answer query with topN URL: https://github.com/apache/kylin/pull/489#issuecomment-467762777 ## Pull Request Test Coverage Report for [Build 4175](https://coveralls.io/builds/21880449) * **0** of **36** **(0.0%)** changed or added relevant lines in **6** files are covered. * **67** unchanged lines in **7** files lost coverage. * Overall coverage decreased (**-0.02%**) to **26.945%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/realization/SQLDigest.java](https://coveralls.io/builds/21880449/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Frealization%2FSQLDigest.java#L125) | 0 | 1 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/OLAPContext.java](https://coveralls.io/builds/21880449/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPContext.java#L135) | 0 | 1 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/OLAPLimitRel.java](https://coveralls.io/builds/21880449/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPLimitRel.java#L81) | 0 | 1 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/21880449/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L537) | 0 | 2 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/OLAPSortRel.java](https://coveralls.io/builds/21880449/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPSortRel.java#L77) | 0 | 8 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java](https://coveralls.io/builds/21880449/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNMeasureType.java#L266) | 0 | 23 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [query/src/main/java/org/apache/kylin/query/relnode/OLAPSortRel.java](https://coveralls.io/builds/21880449/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPSortRel.java#L86) | 1 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/21880449/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L539) | 1 | 43.88% | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/21880449/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/21880449/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/21880449/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21880449/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | [core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java](https://coveralls.io/builds/21880449/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNMeasureType.java#L298) | 57 | 3.97% | | Totals | [](https://coveralls.io/builds/21880449) | | :-- | --: | | Change from base [Build 4170](https://coveralls.io/builds/21871775): | -0.02% | | Covered Lines: | 18716 | | Relevant Lines: | 69460 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty
[
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chao Long updated KYLIN-3836:
-
Description:
{quote}
public static String join(Iterable parts, String separator) {
StringBuilder buf = new StringBuilder();
Iterator iterator = parts.iterator();
if (iterator == null || (!iterator.hasNext())) {
return null;
}
{quote}
org.apache.kylin.job.exception.ExecuteException:
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.kylin.job.exception.ExecuteException:
java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 4 more
Caused by: java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
at com.google.common.base.Splitter.split(Splitter.java:383)
at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
at
org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
at
org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
at
org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 6 more
was:
{quote}public static String join(Iterable parts, String separator) {
StringBuilder buf = new StringBuilder();
Iterator iterator = parts.iterator();
if (iterator == null || (!iterator.hasNext())){
return null;
}
.
{quote}
org.apache.kylin.job.exception.ExecuteException:
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.kylin.job.exception.ExecuteException:
java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 4 more
Caused by: java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
at com.google.common.base.Splitter.split(Splitter.java:383)
at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
at
org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
at
org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
at
org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 6 more
> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
> Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {quote}
> public static String join(Iterable parts, String separator) {
> StringBuilder buf = new StringBuilder();
> Iterator iterator = parts.iterator();
> if (iterator == null || (!iterator.hasNext())) {
> return null;
> }
> {quote}
> org.apache.kylin.job.exception.ExecuteException:
> org.apache.kylin.job.exception.ExecuteException:
> java.lang.NullPointerException
> at
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
> at
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
> at
>
[jira] [Updated] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty
[
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chao Long updated KYLIN-3836:
-
Description:
{quote}public static String join(Iterable parts, String separator) {
StringBuilder buf = new StringBuilder();
Iterator iterator = parts.iterator();
if (iterator == null || (!iterator.hasNext())){
return null;
}
.
{quote}
org.apache.kylin.job.exception.ExecuteException:
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.kylin.job.exception.ExecuteException:
java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 4 more
Caused by: java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
at com.google.common.base.Splitter.split(Splitter.java:383)
at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
at
org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
at
org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
at
org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 6 more
was:
{quote}
public static String join(Iterable parts, String separator) {
StringBuilder buf = new StringBuilder();
Iterator iterator = parts.iterator();
if (iterator == null || (!iterator.hasNext())) {
return null;
}
.
{quote}
org.apache.kylin.job.exception.ExecuteException:
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.kylin.job.exception.ExecuteException:
java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 4 more
Caused by: java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
at com.google.common.base.Splitter.split(Splitter.java:383)
at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
at
org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
at
org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
at
org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 6 more
> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
> Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {quote}public static String join(Iterable parts, String separator) {
> StringBuilder buf = new StringBuilder();
> Iterator iterator = parts.iterator();
> if (iterator == null || (!iterator.hasNext())){
> return null;
> }
> .
> {quote}
> org.apache.kylin.job.exception.ExecuteException:
> org.apache.kylin.job.exception.ExecuteException:
> java.lang.NullPointerException
> at
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
> at
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
> at
>
[jira] [Updated] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty
[
https://issues.apache.org/jira/browse/KYLIN-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chao Long updated KYLIN-3836:
-
Description:
{quote}
public static String join(Iterable parts, String separator) {
StringBuilder buf = new StringBuilder();
Iterator iterator = parts.iterator();
if (iterator == null || (!iterator.hasNext())) {
return null;
}
.
{quote}
org.apache.kylin.job.exception.ExecuteException:
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.kylin.job.exception.ExecuteException:
java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 4 more
Caused by: java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
at com.google.common.base.Splitter.split(Splitter.java:383)
at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
at
org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
at
org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
at
org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 6 more
was:
org.apache.kylin.job.exception.ExecuteException:
org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.kylin.job.exception.ExecuteException:
java.lang.NullPointerException
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
at
org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 4 more
Caused by: java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
at com.google.common.base.Splitter.split(Splitter.java:383)
at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181)
at
org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95)
at
org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62)
at
org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48)
at
org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168)
... 6 more
> Kylin StringUtil.join() may cause NPE if iterator is empty
> --
>
> Key: KYLIN-3836
> URL: https://issues.apache.org/jira/browse/KYLIN-3836
> Project: Kylin
> Issue Type: Bug
>Reporter: Chao Long
>Assignee: Chao Long
>Priority: Major
> Fix For: v2.6.1
>
>
> {quote}
> public static String join(Iterable parts, String separator) {
> StringBuilder buf = new StringBuilder();
> Iterator iterator = parts.iterator();
> if (iterator == null || (!iterator.hasNext())) {
> return null;
> }
> .
> {quote}
> org.apache.kylin.job.exception.ExecuteException:
> org.apache.kylin.job.exception.ExecuteException:
> java.lang.NullPointerException
> at
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183)
> at
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.kylin.job.exception.ExecuteException:
>
[jira] [Created] (KYLIN-3836) Kylin StringUtil.join() may cause NPE if iterator is empty
Chao Long created KYLIN-3836: Summary: Kylin StringUtil.join() may cause NPE if iterator is empty Key: KYLIN-3836 URL: https://issues.apache.org/jira/browse/KYLIN-3836 Project: Kylin Issue Type: Bug Reporter: Chao Long Assignee: Chao Long Fix For: v2.6.1 org.apache.kylin.job.exception.ExecuteException: org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183) at org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:183) at org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71) at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168) ... 4 more Caused by: java.lang.NullPointerException at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191) at com.google.common.base.Splitter.split(Splitter.java:383) at org.apache.kylin.common.util.StringUtil.splitAndTrim(StringUtil.java:181) at org.apache.kylin.source.hive.GarbageCollectionStep.getIntermediateTables(GarbageCollectionStep.java:95) at org.apache.kylin.source.hive.GarbageCollectionStep.cleanUpIntermediateFlatTable(GarbageCollectionStep.java:62) at org.apache.kylin.source.hive.GarbageCollectionStep.doWork(GarbageCollectionStep.java:48) at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:168) ... 6 more -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3820) Add a curator-based scheduler
[ https://issues.apache.org/jira/browse/KYLIN-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780023#comment-16780023 ] ASF GitHub Bot commented on KYLIN-3820: --- Wayne1c commented on pull request #488: KYLIN-3820 Add a curator-based scheduler URL: https://github.com/apache/kylin/pull/488 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a curator-based scheduler > - > > Key: KYLIN-3820 > URL: https://issues.apache.org/jira/browse/KYLIN-3820 > Project: Kylin > Issue Type: Improvement >Reporter: Chao Long >Assignee: Chao Long >Priority: Major > Fix For: v3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3820) Add a curator-based scheduler
[ https://issues.apache.org/jira/browse/KYLIN-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780020#comment-16780020 ] ASF GitHub Bot commented on KYLIN-3820: --- Wayne1c commented on pull request #491: KYLIN-3820 KYLIN-3834 Add a curator-based scheduler URL: https://github.com/apache/kylin/pull/491 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add a curator-based scheduler > - > > Key: KYLIN-3820 > URL: https://issues.apache.org/jira/browse/KYLIN-3820 > Project: Kylin > Issue Type: Improvement >Reporter: Chao Long >Assignee: Chao Long >Priority: Major > Fix For: v3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Wayne1c closed pull request #488: KYLIN-3820 Add a curator-based scheduler
Wayne1c closed pull request #488: KYLIN-3820 Add a curator-based scheduler URL: https://github.com/apache/kylin/pull/488 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #491: KYLIN-3820 KYLIN-3834 Add a curator-based scheduler
asfgit commented on issue #491: KYLIN-3820 KYLIN-3834 Add a curator-based scheduler URL: https://github.com/apache/kylin/pull/491#issuecomment-468110422 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Wayne1c opened a new pull request #491: KYLIN-3820 KYLIN-3834 Add a curator-based scheduler
Wayne1c opened a new pull request #491: KYLIN-3820 KYLIN-3834 Add a curator-based scheduler URL: https://github.com/apache/kylin/pull/491 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3322) TopN requires a SUM to work
[ https://issues.apache.org/jira/browse/KYLIN-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779823#comment-16779823 ] KANG-SEN LU commented on KYLIN-3322: If the second point is properly handled, then first point is not important. Could it be that when kylin decided to access TOPN(SUM(X), GROUP-BY B), it does not check if in the real query the GROUP-BY list does include dimension B? That would be a serious problem. I am curious why you are willing to accept this unnecessary requirement that the SUM(X) must be defined in the same cube that TOPN(SUM(X)) is configured. I suspect there are some code somehow assumes SUM(X) is a metric when processing TOPN(SUM(X)). Maybe it is just too difficult to debug this buggy code. Kang-sen > TopN requires a SUM to work > --- > > Key: KYLIN-3322 > URL: https://issues.apache.org/jira/browse/KYLIN-3322 > Project: Kylin > Issue Type: Bug > Components: Measure - TopN >Reporter: liyang >Assignee: Na Zhai >Priority: Major > > Currently if user creates a measure of TopN seller by sum of price, it is > required that user also creates a measure of SUM(price). Otherwise, NPE will > be thrown at query time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3727) kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常
[ https://issues.apache.org/jira/browse/KYLIN-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779680#comment-16779680 ] Alexander commented on KYLIN-3727: -- Set up system cube follow by instructions. - Got exception. (Fresh cube build will be empty). > kylin2.5.2 不能构建空的cube,否则出现 HadoopShellException异常 > -- > > Key: KYLIN-3727 > URL: https://issues.apache.org/jira/browse/KYLIN-3727 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.5.2 >Reporter: shiyu >Assignee: Lijun Cao >Priority: Major > Labels: Kylin > Attachments: image-2018-12-19-08-38-19-791.png > > > 注:kylin 已经开启,是否容忍数据源为空，默认值为 TRUE > kylin.job.allow-empty-segment=true > 出错位置:#12 Step Name: Load HFile to HBase Table > !image-2018-12-19-08-38-19-791.png! > 异常信息:HadoopShellException > org.apache.kylin.engine.mr.exception.HadoopShellException: result code:-1 > at > org.apache.kylin.engine.mr.common.HadoopShellExecutable.doWork(HadoopShellExecutable.java:73) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164) > at > org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:70) > at > org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:164) > at > org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:113) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] asfgit commented on issue #490: Added small Unit Tests
asfgit commented on issue #490: Added small Unit Tests URL: https://github.com/apache/kylin/pull/490#issuecomment-467932233 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] TheRealHaui opened a new pull request #490: Added small Unit Tests
TheRealHaui opened a new pull request #490: Added small Unit Tests URL: https://github.com/apache/kylin/pull/490 Added small Unit Tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3322) TopN requires a SUM to work
[ https://issues.apache.org/jira/browse/KYLIN-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779298#comment-16779298 ] Shaofeng SHI commented on KYLIN-3322: - Hi Kang-sen, good points. For the first concern, I'm afraid Kylin may not know which is the best cube to anser the SUM(x), the cost based selection have much room to improve. As for the second, KYLIN-2620 is trying to add more checks for TOPN queries. If the query is not a TopN, will not use it to answer. > TopN requires a SUM to work > --- > > Key: KYLIN-3322 > URL: https://issues.apache.org/jira/browse/KYLIN-3322 > Project: Kylin > Issue Type: Bug > Components: Measure - TopN >Reporter: liyang >Assignee: Na Zhai >Priority: Major > > Currently if user creates a measure of TopN seller by sum of price, it is > required that user also creates a measure of SUM(price). Otherwise, NPE will > be thrown at query time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3835) [Defective TableSchemaUpdateChecker] Don't check used models when reload table
[ https://issues.apache.org/jira/browse/KYLIN-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779284#comment-16779284 ] Shaofeng SHI commented on KYLIN-3835: - hi Yuzhang, the problem you described is true; welcome to raise a pull request to Kylin! > [Defective TableSchemaUpdateChecker] Don't check used models when reload table > -- > > Key: KYLIN-3835 > URL: https://issues.apache.org/jira/browse/KYLIN-3835 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v2.5.2 >Reporter: Yuzhang QIU >Priority: Major > > 1. load table1 from hive. > 2. create model1 based on table1 and use table1.column1 as dimension1 > 3. alter table1.column1 to table1.column11 in hive. > 4. reload table1 successfully. (it's bug) > 5. swicth to model, the model1 still exist. I can create cube1 based on > model1 and launch a build job, of course, the job turn out error after a > period of time. (can't find table1.column1, etc) > 6. reload metadata in system page, the model1 is disappeared from Web UI, and > cube1 change to DESCBROKEN, and can't be deleted due to "null" (trace the > log, I found it's caused by null DataModelDesc in CubeInstance). > 7. I want to recreated the model1, but Kylin tell me model1 already existed > in current project. yes, I use 'sh bin/metadata.sh backup', I found the > model1's metadata is still stored in Hbase. > 8. I hacked the code, the reload table validation is checked in > TableSchemaUpdateChecker.allowLoad(), but it just check the used cubes. If a > model using the changed table without any cube based on it, the table can be > reloaded successfully! > I think it shouldn't be like this. > Best regard -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (KYLIN-3835) [Defective TableSchemaUpdateChecker] Don't check used models when reload table
Yuzhang QIU created KYLIN-3835: -- Summary: [Defective TableSchemaUpdateChecker] Don't check used models when reload table Key: KYLIN-3835 URL: https://issues.apache.org/jira/browse/KYLIN-3835 Project: Kylin Issue Type: Bug Components: REST Service Affects Versions: v2.5.2 Reporter: Yuzhang QIU 1. load table1 from hive. 2. create model1 based on table1 and use table1.column1 as dimension1 3. alter table1.column1 to table1.column11 in hive. 4. reload table1 successfully. (it's bug) 5. swicth to model, the model1 still exist. I can create cube1 based on model1 and launch a build job, of course, the job turn out error after a period of time. (can't find table1.column1, etc) 6. reload metadata in system page, the model1 is disappeared from Web UI, and cube1 change to DESCBROKEN, and can't be deleted due to "null" (trace the log, I found it's caused by null DataModelDesc in CubeInstance). 7. I want to recreated the model1, but Kylin tell me model1 already existed in current project. yes, I use 'sh bin/metadata.sh backup', I found the model1's metadata is still stored in Hbase. 8. I hacked the code, the reload table validation is checked in TableSchemaUpdateChecker.allowLoad(), but it just check the used cubes. If a model using the changed table without any cube based on it, the table can be reloaded successfully! I think it shouldn't be like this. Best regard -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] allenma commented on a change in pull request #481: KYLIN-3821 Add consume lag stats
allenma commented on a change in pull request #481: KYLIN-3821 Add consume lag
stats
URL: https://github.com/apache/kylin/pull/481#discussion_r260692914
##
File path:
stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/consumer/KafkaConnector.java
##
@@ -112,7 +126,38 @@ private void fillBuffer() {
for (TopicPartition topicPartition : records.partitions()) {
newBuffer.addAll(records.records(topicPartition));
}
+if (updateLag) {
+calConsumeLag();
+updateLag = false;
+}
this.buffer = newBuffer;
}
+public void calConsumeLag() {
+List topicPartitions = Lists.newArrayList();
+for (Partition partition : partitions) {
+topicPartitions.add(new TopicPartition(topic,
partition.getPartitionId()));
+long currentOffset = kafkaConsumer.position(new
TopicPartition(topic, partition.getPartitionId()));
+partitionCurrentOffsets.put(partition.getPartitionId(),
currentOffset);
+}
+Map lastestEventOffset =
kafkaConsumer.endOffsets(topicPartitions);
+for (Map.Entry entry :
lastestEventOffset.entrySet()) {
+long diff = entry.getValue()
+-
partitionCurrentOffsets.getOrDefault(entry.getKey().partition(),
Long.MAX_VALUE);
+lagStats.put(entry.getKey().partition(), diff);
+}
+}
+
+@Override
+public Map consumeLag() {
Review comment:
It is better to return a latest partition offsets in the Streaming
connector, and calculate the consume lag in the ConsumerChannel class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] allenma commented on a change in pull request #481: KYLIN-3821 Add consume lag stats
allenma commented on a change in pull request #481: KYLIN-3821 Add consume lag
stats
URL: https://github.com/apache/kylin/pull/481#discussion_r260695771
##
File path:
stream-core/src/main/java/org/apache/kylin/stream/core/consumer/IStreamingConnector.java
##
@@ -1,46 +1,55 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
-*/
-
-package org.apache.kylin.stream.core.consumer;
-
-import java.util.List;
-
-import org.apache.kylin.stream.core.model.StreamingMessage;
-import org.apache.kylin.stream.core.source.Partition;
-
-/**
- * the streaming connector is used to connect to streaming source
- */
-public interface IStreamingConnector {
-void open();
-
-void close();
-
-/**
- * wake up the connector if the connector is blocked
- */
-void wakeup();
-
-List getConsumePartitions();
-
-/**
- * get next event
- * @return
- */
-StreamingMessage nextEvent();
-}
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+
+package org.apache.kylin.stream.core.consumer;
+
+import java.util.List;
+import java.util.Map;
+
+import org.apache.kylin.stream.core.model.StreamingMessage;
+import org.apache.kylin.stream.core.source.Partition;
+
+/**
+ * the streaming connector is used to connect to streaming source
+ */
+public interface IStreamingConnector {
+void open();
+
+void close();
+
+/**
+ * wake up the connector if the connector is blocked
+ */
+void wakeup();
+
+List getConsumePartitions();
+
+/**
+ * get next event
+ * @return
+ */
+StreamingMessage nextEvent();
+
+/**
+ * Fetch the consume lag of each partition which own by current receiver
+ * consume lag is the difference between the latest event's offset and
current cosuming event's offset
+ *
+ * @return a Map which key is the id of topic partition and value is the
consume lag
+ */
+Map consumeLag();
Review comment:
It is better to add a method: getLatestPosition(), and calculate the lag in
the consumer side. Not sure we need return the ISourcePosition interface or
not, currently the position abstraction is not very good.
And why the code diff is replace the whole original file rather than add a
new method?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (KYLIN-3714) com.esotericsoftware.kryo.KryoException: java.lang.IllegalArgumentException: Class is not registered: scala.reflect.ManifestFactory$$anon$2
[ https://issues.apache.org/jira/browse/KYLIN-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander resolved KYLIN-3714. -- Resolution: Fixed > com.esotericsoftware.kryo.KryoException: java.lang.IllegalArgumentException: > Class is not registered: scala.reflect.ManifestFactory$$anon$2 > --- > > Key: KYLIN-3714 > URL: https://issues.apache.org/jira/browse/KYLIN-3714 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: v2.5.1 > Environment: kylin2.5.1 > spark2.1.2 >Reporter: wangxianbin >Assignee: Alexander >Priority: Major > Fix For: v2.6.1 > > Attachments: Class is not registered.png, KYLIN-3714.master.001.patch > > > Class is not registered in step "Extract Fact Table Distinct Columns", when > use spark as build engine, error as follow: > com.esotericsoftware.kryo.KryoException: java.lang.IllegalArgumentException: > Class is not registered: scala.reflect.ManifestFactory$$anon$2 Note: To > register this class use: > kryo.register(scala.reflect.ManifestFactory$$anon$2.class); Serialization > trace: evidence$1 (org.apache.spark.util.collection.CompactBuffer) at > com.esotericsoftware.kryo.serializers.ObjectField.write(ObjectField.java:101) > at > com.esotericsoftware.kryo.serializers.FieldSerializer.write(FieldSerializer.java:518) > at com.esotericsoftware.kryo.Kryo.writeClassAndObject(Kryo.java:628) at > org.apache.spark.serializer.KryoSerializationStream.writeObject(KryoSerializer.scala:207) > at > org.apache.spark.serializer.SerializationStream.writeValue(Serializer.scala:135) > at > org.apache.spark.storage.DiskBlockObjectWriter.write(DiskBlockObjectWriter.scala:239) > at > org.apache.spark.util.collection.ExternalAppendOnlyMap.org$apache$spark$util$collection$ExternalAppendOnlyMap$$spillMemoryIteratorToDisk(ExternalAppendOnlyMap.scala:227) > at > org.apache.spark.util.collection.ExternalAppendOnlyMap.spill(ExternalAppendOnlyMap.scala:186) > at > org.apache.spark.util.collection.ExternalAppendOnlyMap.spill(ExternalAppendOnlyMap.scala:56) > at org.apache.spark.util.collection.Spillable.maybeSpill(Spillable.scala:97) > at > org.apache.spark.util.collection.ExternalAppendOnlyMap.insertAll(ExternalAppendOnlyMap.scala:160) > at org.apache.spark.Aggregator.combineValuesByKey(Aggregator.scala:41) at > org.apache.spark.shuffle.BlockStoreShuffleReader.read(BlockStoreShuffleReader.scala:91) > at org.apache.spark.rdd.ShuffledRDD.compute(ShuffledRDD.scala:109) at > org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323) at > org.apache.spark.rdd.RDD.iterator(RDD.scala:287) at > org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38) at > org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323) at > org.apache.spark.rdd.RDD.iterator(RDD.scala:287) at > org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38) at > org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323) at > org.apache.spark.rdd.RDD.iterator(RDD.scala:287) at > org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:87) at > org.apache.spark.scheduler.Task.run(Task.scala:99) at > org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:325) at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:745) Caused by: > java.lang.IllegalArgumentException: Class is not registered: > scala.reflect.ManifestFactory$$anon$2 Note: To register this class use: > kryo.register(scala.reflect.ManifestFactory$$anon$2.class); at > com.esotericsoftware.kryo.Kryo.getRegistration(Kryo.java:488) at > com.esotericsoftware.kryo.util.DefaultClassResolver.writeClass(DefaultClassResolver.java:97) > at com.esotericsoftware.kryo.Kryo.writeClass(Kryo.java:517) at > com.esotericsoftware.kryo.serializers.ObjectField.write(ObjectField.java:76) > ... 27 more -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (KYLIN-3833) Potential OOM in Spark Extract Fact Table Distinct Columns step
[ https://issues.apache.org/jira/browse/KYLIN-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander resolved KYLIN-3833. -- Resolution: Fixed > Potential OOM in Spark Extract Fact Table Distinct Columns step > --- > > Key: KYLIN-3833 > URL: https://issues.apache.org/jira/browse/KYLIN-3833 > Project: Kylin > Issue Type: Bug > Components: Spark Engine >Affects Versions: v2.5.1 > Environment: CentOS 7 > 3 workers and 1 master. > 4 cpu, 16GB RAM each >Reporter: Alexander >Assignee: Alexander >Priority: Minor > Fix For: v2.6.1 > > Attachments: KYLIN-3833.master.001.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] shaofengshi commented on issue #480: Update documents
shaofengshi commented on issue #480: Update documents URL: https://github.com/apache/kylin/pull/480#issuecomment-467763405 Merged with patch, thank you Na! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi closed pull request #480: Update documents
shaofengshi closed pull request #480: Update documents URL: https://github.com/apache/kylin/pull/480 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (KYLIN-3322) TopN requires a SUM to work
[ https://issues.apache.org/jira/browse/KYLIN-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779016#comment-16779016 ] ASF subversion and git services commented on KYLIN-3322: Commit 8e16be631ed74a2b31b5936d1266641ed3be98c8 in kylin's branch refs/heads/document from GinaZhai [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=8e16be6 ] KYLIN-3322 TopN requires a SUM to work > TopN requires a SUM to work > --- > > Key: KYLIN-3322 > URL: https://issues.apache.org/jira/browse/KYLIN-3322 > Project: Kylin > Issue Type: Bug > Components: Measure - TopN >Reporter: liyang >Assignee: Na Zhai >Priority: Major > > Currently if user creates a measure of TopN seller by sum of price, it is > required that user also creates a measure of SUM(price). Otherwise, NPE will > be thrown at query time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3805) Add documentation about the purpose of each directory
[ https://issues.apache.org/jira/browse/KYLIN-3805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779015#comment-16779015 ] ASF subversion and git services commented on KYLIN-3805: Commit 7750d28204e327f091edd867db35aa10a0449c86 in kylin's branch refs/heads/document from GinaZhai [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=7750d28 ] KYLIN-3805 Add documentation about the purpose of each directory > Add documentation about the purpose of each directory > - > > Key: KYLIN-3805 > URL: https://issues.apache.org/jira/browse/KYLIN-3805 > Project: Kylin > Issue Type: Improvement > Components: Documentation >Reporter: Na Zhai >Assignee: Na Zhai >Priority: Major > > Kylin is lack of docs about the purpose of each HDFS directory and unzipped > directory of Kylin tar package. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] coveralls commented on issue #489: KYLIN-2620 Make the condition stricter to answer query with topN
coveralls commented on issue #489: KYLIN-2620 Make the condition stricter to answer query with topN URL: https://github.com/apache/kylin/pull/489#issuecomment-467762777 ## Pull Request Test Coverage Report for [Build 4173](https://coveralls.io/builds/21874096) * **0** of **26** **(0.0%)** changed or added relevant lines in **6** files are covered. * **11** unchanged lines in **7** files lost coverage. * Overall coverage decreased (**-0.01%**) to **26.95%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/metadata/realization/SQLDigest.java](https://coveralls.io/builds/21874096/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Frealization%2FSQLDigest.java#L125) | 0 | 1 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/OLAPContext.java](https://coveralls.io/builds/21874096/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPContext.java#L135) | 0 | 1 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/OLAPLimitRel.java](https://coveralls.io/builds/21874096/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPLimitRel.java#L81) | 0 | 1 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/21874096/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L537) | 0 | 2 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/OLAPSortRel.java](https://coveralls.io/builds/21874096/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPSortRel.java#L77) | 0 | 8 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java](https://coveralls.io/builds/21874096/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNMeasureType.java#L287) | 0 | 13 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java](https://coveralls.io/builds/21874096/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNMeasureType.java#L405) | 1 | 4.17% | | [query/src/main/java/org/apache/kylin/query/relnode/OLAPSortRel.java](https://coveralls.io/builds/21874096/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPSortRel.java#L86) | 1 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/21874096/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L539) | 1 | 43.88% | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/21874096/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/21874096/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/21874096/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21874096/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/21874096) | | :-- | --: | | Change from base [Build 4170](https://coveralls.io/builds/21871775): | -0.01% | | Covered Lines: | 18716 | | Relevant Lines: | 69448 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
