[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module
[ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106631#comment-16106631 ] liyang commented on KYLIN-2745: --- Those setting files are there intentionally, such that all eclipse developer will have exact same IDE settings on compilers, code formatter etc. These are project level settings, which overrides any default Eclipse setting. This enforces coding convention, error/warning convention across all Kylin developers and saves many unnecessary communication. A very good thing in my opinion. Have a tool to enforce standard is much better than replying on manual setups. I'm not sure how to do the same with intelliJ. If there is way, I think we shall do it for intelliJ too. > Remove eclipse .settings directory from each module > --- > > Key: KYLIN-2745 > URL: https://issues.apache.org/jira/browse/KYLIN-2745 > Project: Kylin > Issue Type: Task >Affects Versions: Future, v2.0.0 >Reporter: nirav patel >Assignee: nirav patel > Fix For: Future > > Attachments: KYLIN-2745.patch > > > I think this directory should not be part of git repo at all. It should be > listed in .gitignore file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module
[ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100325#comment-16100325 ] nirav patel commented on KYLIN-2745: Sounds good to me. > Remove eclipse .settings directory from each module > --- > > Key: KYLIN-2745 > URL: https://issues.apache.org/jira/browse/KYLIN-2745 > Project: Kylin > Issue Type: Task >Affects Versions: Future, v2.0.0 >Reporter: nirav patel >Assignee: nirav patel > Fix For: Future > > Attachments: KYLIN-2745.patch > > > I think this directory should not be part of git repo at all. It should be > listed in .gitignore file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module
[ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100109#comment-16100109 ] Shaofeng SHI commented on KYLIN-2745: - I agree with Dong; Before we find the solution to replace it, let's keep as-is. > Remove eclipse .settings directory from each module > --- > > Key: KYLIN-2745 > URL: https://issues.apache.org/jira/browse/KYLIN-2745 > Project: Kylin > Issue Type: Task >Affects Versions: Future, v2.0.0 >Reporter: nirav patel >Assignee: nirav patel > Fix For: Future > > Attachments: KYLIN-2745.patch > > > I think this directory should not be part of git repo at all. It should be > listed in .gitignore file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module
[ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100097#comment-16100097 ] Dong Li commented on KYLIN-2745: I agreed to find a better solution, and let's discuss about it here. But before we make the conclusion, I suggest to revert the commit to bring back those setting files at this moment, or most developers who followed the dev_env document will be affected. > Remove eclipse .settings directory from each module > --- > > Key: KYLIN-2745 > URL: https://issues.apache.org/jira/browse/KYLIN-2745 > Project: Kylin > Issue Type: Task >Affects Versions: Future, v2.0.0 >Reporter: nirav patel >Assignee: nirav patel > Fix For: Future > > Attachments: KYLIN-2745.patch > > > I think this directory should not be part of git repo at all. It should be > listed in .gitignore file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module
[ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097419#comment-16097419 ] nirav patel commented on KYLIN-2745: Hi Dong Li, How about exporting code formatter files and include them in "config" or "extra" directories or make it available for download from http. Or Just have a manual guidelines for intelliJ. It seems like those formatter are fairly static files and need one time setup. That is also a reason I don't see it as git candidate. I have also not seen .settings files being committed for most other projects on github. That directory also stores many other eclipse preferences, plugin preferences etc so highly likely that it is going to vary from person to person depending upon their environment. It comes up in commit all the time and becomes hard to avoid not checking them in accidentally. Thanks > Remove eclipse .settings directory from each module > --- > > Key: KYLIN-2745 > URL: https://issues.apache.org/jira/browse/KYLIN-2745 > Project: Kylin > Issue Type: Task >Affects Versions: Future, v2.0.0 >Reporter: nirav patel >Assignee: nirav patel > Fix For: Future > > Attachments: KYLIN-2745.patch > > > I think this directory should not be part of git repo at all. It should be > listed in .gitignore file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module
[ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097344#comment-16097344 ] Dong Li commented on KYLIN-2745: Hi Shaofeng and Nirav, In fact, these setting files are used for code formatting. In this document, eclipse formatter is suggested for non-eclipse users: http://kylin.apache.org/development/dev_env.html So I would suggest to keep these files, and also remove them from .gitignore. Thanks. > Remove eclipse .settings directory from each module > --- > > Key: KYLIN-2745 > URL: https://issues.apache.org/jira/browse/KYLIN-2745 > Project: Kylin > Issue Type: Task >Affects Versions: Future, v2.0.0 >Reporter: nirav patel >Assignee: nirav patel > Fix For: Future > > Attachments: KYLIN-2745.patch > > > I think this directory should not be part of git repo at all. It should be > listed in .gitignore file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module
[ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095871#comment-16095871 ] Shaofeng SHI commented on KYLIN-2745: - I see .settings has been added in gitignore file, so leaving these files in GIT doesn't have value. Patch merged in master branch: https://github.com/apache/kylin/commit/945e4fd46c3eaa3fc92610e3910e2e726697c25b Thanks Nirav! > Remove eclipse .settings directory from each module > --- > > Key: KYLIN-2745 > URL: https://issues.apache.org/jira/browse/KYLIN-2745 > Project: Kylin > Issue Type: Task >Affects Versions: Future, v2.0.0 >Reporter: nirav patel >Assignee: nirav patel > Fix For: Future > > Attachments: KYLIN-2745.patch > > > I think this directory should not be part of git repo at all. It should be > listed in .gitignore file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module
[ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092506#comment-16092506 ] Shaofeng SHI commented on KYLIN-2745: - Thanks Nirav; The patch looks good to me (I'm using IntelliJ). [~liyang.g...@gmail.com] Yang, I know you're using Eclipse, are you okay with this? > Remove eclipse .settings directory from each module > --- > > Key: KYLIN-2745 > URL: https://issues.apache.org/jira/browse/KYLIN-2745 > Project: Kylin > Issue Type: Task >Affects Versions: Future, v2.0.0 >Reporter: nirav patel >Assignee: nirav patel > Fix For: Future > > Attachments: KYLIN-2745.patch > > > I think this directory should not be part of git repo at all. It should be > listed in .gitignore file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
