[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396298#comment-16396298
 ] 

ASF subversion and git services commented on KYLIN-3236:


Commit 2a72dadd0b785c4bd18210230398471013eb1293 in kylin's branch 
refs/heads/2.3.x from [~xingpeng1]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=2a72dad ]

KYLIN-3236 The function 'reGenerateAdvancedDict()' has an error logical 
judgment, which will cause an exception when you edit the cube.

Signed-off-by: xingpeng1 


> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.3.1
>
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383372#comment-16383372
 ] 

ASF subversion and git services commented on KYLIN-3236:


Commit 39ef73ccade23fe3c0e95ea1e29b5090d9b16e76 in kylin's branch 
refs/heads/master from [~xingpeng1]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=39ef73c ]

KYLIN-3236 The function 'reGenerateAdvancedDict()' has an error logical 
judgment, which will cause an exception when you edit the cube.

Signed-off-by: xingpeng1 


> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Fix For: v2.4.0
>
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[Peng Xing (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383367#comment-16383367
 ] 

Peng Xing commented on KYLIN-3236:
--

Hi [~Zhixiong Chen]
Thanks for your reply, the pull request url is 
https://github.com/apache/kylin/pull/110

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383361#comment-16383361
 ] 

ASF GitHub Bot commented on KYLIN-3236:
---

xingpeng1 opened a new pull request #110: KYLIN-3236
URL: https://github.com/apache/kylin/pull/110
 
 
KYLIN-3236 The function 'reGenerateAdvancedDict()' has an error logical 
judgment, which will cause an exception when you edit the cube.
   
   Signed-off-by: xingpeng1 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383362#comment-16383362
 ] 

ASF GitHub Bot commented on KYLIN-3236:
---

asfgit commented on issue #110: KYLIN-3236
URL: https://github.com/apache/kylin/pull/110#issuecomment-369859958
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[Zhixiong Chen (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383123#comment-16383123
 ] 

Zhixiong Chen commented on KYLIN-3236:
--

OK, 

Sorry for late to review this patch.

It is fine with me.

Could you make a pull request in Kylin master ?

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[Peng Xing (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383116#comment-16383116
 ] 

Peng Xing commented on KYLIN-3236:
--

Hi [~Zhixiong Chen], can you help to review this new patch, thanks!

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[Zhixiong Chen (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352206#comment-16352206
 ] 

Zhixiong Chen commented on KYLIN-3236:
--

Do you use TRANS_ID in count_distinct measure ?

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[Peng Xing (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352201#comment-16352201
 ] 

Peng Xing commented on KYLIN-3236:
--

Hi [~Zhixiong Chen], thanks for your reply, I'm so sorry, maybe I did not 
express clearly.
Please look at these three picture attachments, it indeed has some problem, 
then I find out the code has an error logical judgment.

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch, 1.PNG, 
> 2.PNG, 3.PNG
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3236) The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube.

[Zhixiong Chen (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352184#comment-16352184
 ] 

Zhixiong Chen commented on KYLIN-3236:
--

Hi,[~xingpeng1]

I think it isn't a bug.

Global dictionary only used in count_distinct measure that return type is 
'bitmap'.

So Kaisen in KYLIN-2604 remove the dictionary that not be used in 
count_distinct.

 

> The function 'reGenerateAdvancedDict()' has an error logical judgment, which 
> will cause an exception when you edit the cube.
> 
>
> Key: KYLIN-3236
> URL: https://issues.apache.org/jira/browse/KYLIN-3236
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.3.0
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Major
>  Labels: patch
> Attachments: 
> 0001-KYLIN-3236-The-function-reGenerateAdvancedDict-has-a.patch
>
>
> # When remove deprecated distinct measures, the code has an error logical 
> judgment In function 'reGenerateAdvancedDict()', as follows:
> {code:java}
> //remove deprecated distinct measures
> angular.forEach($scope.cubeMetaFrame.dictionaries, function (dict, index) 
> {
>   if (distinctMeasures.indexOf(dict.column) === -1 && 
> reuseColumns.indexOf(dict.column) === -1) {
> $scope.cubeMetaFrame.dictionaries.splice(index, 1);
>   }
> });
> {code}
> This will result in accidental deletion of advanced dictionaries.
>  Please review the patch, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)