[jira] [Commented] (KYLIN-4697) User info update logic is not correct
[ https://issues.apache.org/jira/browse/KYLIN-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211529#comment-17211529 ] ASF GitHub Bot commented on KYLIN-4697: --- hit-lacus merged pull request #1433: URL: https://github.com/apache/kylin/pull/1433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User info update logic is not correct > - > > Key: KYLIN-4697 > URL: https://issues.apache.org/jira/browse/KYLIN-4697 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: JiangYang >Priority: Major > Fix For: v3.1.1 > > > There are mainly two issues: > * The logic for KylinAuthenticationProvider.needUpdateUser() is not correct > due to not considering ALL_USERS > * The logic of updateUser in some places is not correct due to not following > copy on write. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4697) User info update logic is not correct
[ https://issues.apache.org/jira/browse/KYLIN-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204439#comment-17204439 ] ASF GitHub Bot commented on KYLIN-4697: --- coveralls commented on pull request #1433: URL: https://github.com/apache/kylin/pull/1433#issuecomment-701145737 ## Pull Request Test Coverage Report for [Build 6417](https://coveralls.io/builds/33818665) * **0** of **17** **(0.0%)** changed or added relevant lines in **5** files are covered. * **10** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.01%**) to **28.041%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/controller/UserController.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FUserController.java#L220) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/security/KylinUserManager.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FKylinUserManager.java#L144) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/KylinUserService.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserService.java#L214) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/KylinUserGroupService.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserGroupService.java#L157) | 0 | 3 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/security/KylinAuthenticationProvider.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FKylinAuthenticationProvider.java#L119) | 0 | 11 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [server-base/src/main/java/org/apache/kylin/rest/security/KylinAuthenticationProvider.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FKylinAuthenticationProvider.java#L150) | 1 | 0% | | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/33818665/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46) | 9 | 60.0% | | Totals | [](https://coveralls.io/builds/33818665) | | :-- | --: | | Change from base [Build 6416](https://coveralls.io/builds/33804340): | -0.01% | | Covered Lines: | 26251 | | Relevant Lines: | 93616 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User info update logic is not correct > - > > Key: KYLIN-4697 > URL: https://issues.apache.org/jira/browse/KYLIN-4697 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: JiangYang >Priority: Major > Fix For: v3.1.1 > > > There are mainly two issues: > * The logic for KylinAuthenticationProvider.needUpdateUser() is not correct > due to not considering ALL_USERS > * The logic of updateUser in some places is not correct due to not following > copy on write. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4697) User info update logic is not correct
[ https://issues.apache.org/jira/browse/KYLIN-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204417#comment-17204417 ] ASF GitHub Bot commented on KYLIN-4697: --- Ted-Jiang opened a new pull request #1433: URL: https://github.com/apache/kylin/pull/1433 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User info update logic is not correct > - > > Key: KYLIN-4697 > URL: https://issues.apache.org/jira/browse/KYLIN-4697 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: JiangYang >Priority: Major > Fix For: v3.1.1 > > > There are mainly two issues: > * The logic for KylinAuthenticationProvider.needUpdateUser() is not correct > due to not considering ALL_USERS > * The logic of updateUser in some places is not correct due to not following > copy on write. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4697) User info update logic is not correct
[ https://issues.apache.org/jira/browse/KYLIN-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178763#comment-17178763 ] Zhong Yanghong commented on KYLIN-4697: --- There's one more thing we need to take care of. In HBase, the rowkey is case-sensitive. While in Kylin, the user name is case-insensitive. We need to avoid the case that there's multiple HBase records existing for the same user. Otherwise, WriteConflictException may occur when updating user info. > User info update logic is not correct > - > > Key: KYLIN-4697 > URL: https://issues.apache.org/jira/browse/KYLIN-4697 > Project: Kylin > Issue Type: Bug >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > > There are mainly two issues: > * The logic for KylinAuthenticationProvider.needUpdateUser() is not correct > due to not considering ALL_USERS > * The logic of updateUser in some places is not correct due to not following > copy on write. -- This message was sent by Atlassian Jira (v8.3.4#803005)
