[jira] [Commented] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-07-10 Thread Zach Chen (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564747#comment-17564747
 ] 

Zach Chen commented on LUCENE-10480:


{quote}I'll see if I can run the original nightly benchmark code / tests from 
my machine to see if there's any difference.
{quote}
I tried to run ** *nightlyBench.py* locally on my machine over the weekend, but 
that turns out to require some changes to the script itself,  and I haven't 
been able to run it fully so far.

On the other hand, I tried a few more run configurations with ** *localrun.py,* 
including running it in a virtual ubuntu box  (as the nightly benchmark runs on 
linux box), but still have no luck so far re-producing the 
[AndHighOrMedMed|https://home.apache.org/~mikemccand/lucenebench/AndHighOrMedMed.html]
 slow-down. 

[~jpountz], just curious, are you able to reproduce the slow-down locally on 
your end as well ?

> Specialize 2-clauses disjunctions
> -
>
> Key: LUCENE-10480
> URL: https://issues.apache.org/jira/browse/LUCENE-10480
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Adrien Grand
>Priority: Minor
>  Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> WANDScorer is nice, but it also has lots of overhead to maintain its 
> invariants: one linked list for the current candidates, one priority queue of 
> scorers that are behind, another one for scorers that are ahead. All this 
> could be simplified in the 2-clauses case, which feels worth specializing for 
> as it's very common that end users enter queries that only have two terms?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-07-10 Thread Vigya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564743#comment-17564743
 ] 

Vigya Sharma commented on LUCENE-10448:
---

Created PR - [https://github.com/apache/lucene/pull/1014] to add a comment 
explaining the no-pause behavior of writeBytes().

> MergeRateLimiter doesn't always limit instant rate.
> ---
>
> Key: LUCENE-10448
> URL: https://issues.apache.org/jira/browse/LUCENE-10448
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: core/other
>Affects Versions: 8.11.1
>Reporter: kkewwei
>Priority: Major
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> We can see the code in *MergeRateLimiter*:
> {code:java}
> private long maybePause(long bytes, long curNS) throws 
> MergePolicy.MergeAbortedException {
>
> double rate = mbPerSec; 
> double secondsToPause = (bytes / 1024. / 1024.) / rate;
> long targetNS = lastNS + (long) (10 * secondsToPause);
> long curPauseNS = targetNS - curNS;
> // We don't bother with thread pausing if the pause is smaller than 2 
> msec.
> if (curPauseNS <= MIN_PAUSE_NS) {
>   // Set to curNS, not targetNS, to enforce the instant rate, not
>   // the "averaged over all history" rate:
>   lastNS = curNS;
>   return -1;
> }
>..
>   }
> {code}
> If a Segment is been merged, *maybePause* is called in 7:00, lastNS=7:00, 
> then the *maybePause* is called in 7:05 again,  so the value of 
> *targetNS=lastNS + (long) (10 * secondsToPause)* must be smaller than 
> *curNS*, no matter how big the bytes is, we will return -1 and ignore to 
> pause. 
> I count the total times(callTimes) calling *maybePause* and ignored pause 
> times(ignorePauseTimes) and detail ignored bytes(detailBytes):
> {code:java}
> [2022-03-02T15:16:51,972][DEBUG][o.e.i.e.I.EngineMergeScheduler] [node1] 
> [index1][21] merge segment [_4h] done: took [26.8s], [123.6 MB], [61,219 
> docs], [0s stopped], [24.4s throttled], [242.5 MB written], [11.2 MB/sec 
> throttle], [callTimes=857], [ignorePauseTimes=25],  [detailBytes(mb) = 
> [0.28899956, 0.28140354, 0.28015518, 0.27990818, 0.2801447, 0.27991104, 
> 0.27990723, 0.27990913, 0.2799101, 0.28010082, 0.2799921, 0.2799673, 
> 0.28144264, 0.27991295, 0.27990818, 0.27993107, 0.2799387, 0.27998447, 
> 0.28002167, 0.27992058, 0.27998066, 0.28098202, 0.28125, 0.28125, 0.28125]]
> {code}
> There are 857 times calling *maybePause*, including 25 times which is ignored 
> to pause, we can see that the ignored detail bytes (such as 0.28125mb) are 
> not small.
> As long as the interval between two *maybePause* calls is relatively long, 
> the pause action that should be executed will not be executed.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] vigyasharma closed pull request #738: LUCENE-10448: Avoid instant rate write bursts by writing bytes buffer in chunks

2022-07-10 Thread GitBox


vigyasharma closed pull request #738: LUCENE-10448: Avoid instant rate write 
bursts by writing bytes buffer in chunks
URL: https://github.com/apache/lucene/pull/738


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] vigyasharma commented on pull request #738: LUCENE-10448: Avoid instant rate write bursts by writing bytes buffer in chunks

2022-07-10 Thread GitBox


vigyasharma commented on PR #738:
URL: https://github.com/apache/lucene/pull/738#issuecomment-1179856740

   Created #1014 to add the comment. Closing this PR now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] vigyasharma opened a new pull request, #1014: Add comment for no pauses in RateLimitedIndexOutput.writeBytes

2022-07-10 Thread GitBox


vigyasharma opened a new pull request, #1014:
URL: https://github.com/apache/lucene/pull/1014

   This PR is based on the discussion in #738 
([comment](https://github.com/apache/lucene/pull/738#issuecomment-1156523966)]..
 
   
   `RateLimitedIndexOutput.writeBytes()` does not pause while writing the 
provided array slice. A big array write after a long pause can cause instant 
write rate to breach the configured limit. This is different from the other 
APIs, which only write a single byte/int/short/long, and hence won't spike the 
instant rate. 
   
   This has been a cause of confusion for some users. The PR adds a comment to 
call it out. More details in jira 
[LUCENE-10448](https://issues.apache.org/jira/browse/LUCENE-10448).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-10649) Failure in TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField

2022-07-10 Thread Vigya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564713#comment-17564713
 ] 

Vigya Sharma commented on LUCENE-10649:
---

Could this be related to the merge-on-refresh change?

I set {{maxFullFlushMergeWaitMillis = 0}} in IndexWriterConfig, and ran the 
test (with same random seed) on repeat for 500 times, and it passed. Without 
the change, I usually get the failure in a couple of runs.
{code:bash}
./gradlew test --tests 
TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField 
-Dtests.seed=A7496D7D3957981A -Dtests.multiplier=3 -Dtests.locale=sr-Latn-BA 
-Dtests.timezone=Etc/GMT-7 -Dtests.asserts=true -Dtests.file.encoding=UTF-8 
-Dtests.iters=500 -Dtests.failfast=true
{code}
 

 

> Failure in TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField
> ---
>
> Key: LUCENE-10649
> URL: https://issues.apache.org/jira/browse/LUCENE-10649
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Vigya Sharma
>Priority: Major
>
> Failing Build Link: 
> [https://jenkins.thetaphi.de/job/Lucene-main-Linux/35617/testReport/junit/org.apache.lucene.index/TestDemoParallelLeafReader/testRandomMultipleSchemaGensSameField/]
> Repro:
> {code:java}
> gradlew test --tests 
> TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField 
> -Dtests.seed=A7496D7D3957981A -Dtests.multiplier=3 -Dtests.locale=sr-Latn-BA 
> -Dtests.timezone=Etc/GMT-7 -Dtests.asserts=true -Dtests.file.encoding=UTF-8 
> {code}
> Error:
> {code:java}
> java.lang.AssertionError: expected:<103> but was:<2147483647>
>     at 
> __randomizedtesting.SeedInfo.seed([A7496D7D3957981A:F71866BCCEA1C903]:0)
>     at org.junit.Assert.fail(Assert.java:89)
>     at org.junit.Assert.failNotEquals(Assert.java:835)
>     at org.junit.Assert.assertEquals(Assert.java:647)
>     at org.junit.Assert.assertEquals(Assert.java:633)
>     at 
> org.apache.lucene.index.TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField(TestDemoParallelLeafReader.java:1347)
>     at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-10649) Failure in TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField

2022-07-10 Thread Vigya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564711#comment-17564711
 ] 

Vigya Sharma commented on LUCENE-10649:
---

>From initial debugging, it seems that the test expects all {{maxDoc}} 
>documents to be present in the docValues field, which is not the case. I 
>printed {{leaf.maxDoc()}} and {{{}numbers.cost(){}}}, and they have different 
>values:

{code:java}
System.out.println(" --> vigya - maxdoc: " + maxDoc + ", cost: " + 
numbers.cost());
--> vigya - maxdoc: 351, cost: 103
{code}

It seems that for this random-test-path, we create a 
{{SparseNumericDocValues(IndexedDisi disi)}} doc values producer, and the 
IndexedDisi itself contains only 103 values. I wonder if something changed 
recently, that breaks the assumption that NumericDocValues in this test will 
always have all the docs indexed.
The IndexedDisi was also created with 103 values.

{code:java}
System.out.printf("\n--> creating IndexedDisi. numvalues: %d\n", 
entry.numValues);
--> creating IndexedDisi. numvalues: 103
{code}

> Failure in TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField
> ---
>
> Key: LUCENE-10649
> URL: https://issues.apache.org/jira/browse/LUCENE-10649
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Vigya Sharma
>Priority: Major
>
> Failing Build Link: 
> [https://jenkins.thetaphi.de/job/Lucene-main-Linux/35617/testReport/junit/org.apache.lucene.index/TestDemoParallelLeafReader/testRandomMultipleSchemaGensSameField/]
> Repro:
> {code:java}
> gradlew test --tests 
> TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField 
> -Dtests.seed=A7496D7D3957981A -Dtests.multiplier=3 -Dtests.locale=sr-Latn-BA 
> -Dtests.timezone=Etc/GMT-7 -Dtests.asserts=true -Dtests.file.encoding=UTF-8 
> {code}
> Error:
> {code:java}
> java.lang.AssertionError: expected:<103> but was:<2147483647>
>     at 
> __randomizedtesting.SeedInfo.seed([A7496D7D3957981A:F71866BCCEA1C903]:0)
>     at org.junit.Assert.fail(Assert.java:89)
>     at org.junit.Assert.failNotEquals(Assert.java:835)
>     at org.junit.Assert.assertEquals(Assert.java:647)
>     at org.junit.Assert.assertEquals(Assert.java:633)
>     at 
> org.apache.lucene.index.TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField(TestDemoParallelLeafReader.java:1347)
>     at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Created] (LUCENE-10649) Failure in TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField

2022-07-10 Thread Vigya Sharma (Jira)
Vigya Sharma created LUCENE-10649:
-

 Summary: Failure in 
TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField
 Key: LUCENE-10649
 URL: https://issues.apache.org/jira/browse/LUCENE-10649
 Project: Lucene - Core
  Issue Type: Bug
Reporter: Vigya Sharma


Failing Build Link: 
[https://jenkins.thetaphi.de/job/Lucene-main-Linux/35617/testReport/junit/org.apache.lucene.index/TestDemoParallelLeafReader/testRandomMultipleSchemaGensSameField/]


Repro:
{code:java}
gradlew test --tests 
TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField 
-Dtests.seed=A7496D7D3957981A -Dtests.multiplier=3 -Dtests.locale=sr-Latn-BA 
-Dtests.timezone=Etc/GMT-7 -Dtests.asserts=true -Dtests.file.encoding=UTF-8 
{code}
Error:
{code:java}
java.lang.AssertionError: expected:<103> but was:<2147483647>
    at __randomizedtesting.SeedInfo.seed([A7496D7D3957981A:F71866BCCEA1C903]:0)
    at org.junit.Assert.fail(Assert.java:89)
    at org.junit.Assert.failNotEquals(Assert.java:835)
    at org.junit.Assert.assertEquals(Assert.java:647)
    at org.junit.Assert.assertEquals(Assert.java:633)
    at 
org.apache.lucene.index.TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField(TestDemoParallelLeafReader.java:1347)
    at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
 {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on pull request #30: shoshin (初心) / Fresh Eyes improvements to README

2022-07-10 Thread GitBox


mikemccand commented on PR #30:
URL: 
https://github.com/apache/lucene-jira-archive/pull/30#issuecomment-1179740996

   > As for attachments, I have already committed all attachments for all 
issues (from a snapshot) in this repo - please use them for testing.
   
   Ahh yes thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta merged pull request #30: shoshin (初心) / Fresh Eyes improvements to README

2022-07-10 Thread GitBox


mocobeta merged PR #30:
URL: https://github.com/apache/lucene-jira-archive/pull/30


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on pull request #30: shoshin (初心) / Fresh Eyes improvements to README

2022-07-10 Thread GitBox


mocobeta commented on PR #30:
URL: 
https://github.com/apache/lucene-jira-archive/pull/30#issuecomment-1179738207

   Thank you @mikemccand for improving this, will merge this soon.
   As for attachments, I have already committed all attachments for all issues 
(from a snapshot) in this repo - please use them for testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #30: shoshin (初心) / Fresh Eyes improvements to README

2022-07-10 Thread GitBox


mikemccand commented on code in PR #30:
URL: https://github.com/apache/lucene-jira-archive/pull/30#discussion_r917400656


##
migration/README.md:
##
@@ -54,14 +56,14 @@ LUCENE-10502
 ...
 ```
 
-Downloaded attachments should be committed to a dedicated repo/branch for them.
+Downloaded attachments should be separatly committed to a dedicated branch 
named `attachments` (or matching the `GITHUB_ATT_BRANCH` env variable) for them.

Review Comment:
   Woops, I'll fix this typo (`separatly`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #30: shoshin (初心) / Fresh Eyes improvements to README

2022-07-10 Thread GitBox


mikemccand opened a new pull request, #30:
URL: https://github.com/apache/lucene-jira-archive/pull/30

   Thank you @mocobeta for the awesome `README` instructions!  I was able to 
migrate my own few Jira issues to [my test GitHub 
repo](https://github.com/mikemccand/stargazers-migration-test/issues), and made 
a few small edits to the `README` for small things I hit.  I needed to get this 
working so I could test my improvements on #27.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #12: Make a test set for improving markup conversion quality

2022-07-10 Thread GitBox


mocobeta commented on issue #12:
URL: 
https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1179721279

   > I sort of think this is a feature not a bug? But, it is not a priority to 
handle these mixed cases well! If the converter is escaping some and missing 
others I think we can let it be, unless it's impacting too many cases.
   
   I've seen some quote symbols `>` were escaped in the converted results but 
not sure if this is a "feature" or "bug"... I think there may be mixed 
situations (some markdowns are preserved as-is and rendered as the authors 
intended, and some are escaped).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mocobeta commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179720010

   > For step 9, maybe we can ask/plan for volunteers in the dev community to 
help check for anything that went wrong during the import process. We of course 
should test as much as possible in this development phase (thank you 
@mocobeta!) before we migrate as well.
   
   Thanks. Instead of manually checking after the actual migration I'd ask the 
dev community to check if there are major conversion bugs after the final test 
migration. For small/minor fixes, committers can update any issues/comments 
anytime.
   
   > We don't have to rush this migration.
   
   While there is no harry for Lucene TLP, I cannot prolong this project for a 
long period due to my situation. Sorry but let me set the timeline someday this 
August (or September, at the latest). If this takes more time, I think I will 
have to leave this in the middle hoping someone takes over this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #27: Improve the `Jira Information` header?

2022-07-10 Thread GitBox


mikemccand commented on issue #27:
URL: 
https://github.com/apache/lucene-jira-archive/issues/27#issuecomment-1179719901

   > ... but I'm have some trouble finding where this text is generated in the 
Jira export / GitHub import source code...
   
   [Found 
it](https://github.com/apache/lucene-jira-archive/blob/main/migration/src/jira2github_import.py#L91)!
  Woot!  I'll take a stab...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #12: Make a test set for improving markup conversion quality

2022-07-10 Thread GitBox


mikemccand commented on issue #12:
URL: 
https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1179718268

   > I don't think unintentional markdowns will be properly rendered after 
migration. Markdowns in Jira are (correctly) escaped in the converter.
   
   Oh, I though the original author of that comment (Fuad) indeed meant for 
those `===` to become headers, and I was happy that the converter "missed" 
escaping them.
   
   Here is another example (comment) from that same issue where the "miss" was 
great -- we properly rendered a code block in the GitHub issue when Jira missed 
it:
   
   ![Screen Shot 2022-07-10 at 8 18 11 
AM](https://user-images.githubusercontent.com/796508/178144625-7c179e83-9f2b-4f1d-801c-d293ba5f5737.png)
   
   Original JIra:
   
   ![Screen Shot 2022-07-10 at 8 18 02 
AM](https://user-images.githubusercontent.com/796508/178144634-b39ce7ee-798d-4618-b9ec-15ccfc7c0a2e.png)
   
   The original comment used block indentation, which MD interprets as code 
block.
   
   I sort of think this is a feature not a bug?  But, it is not a priority to 
handle these mixed cases well!  If the converter is escaping some and missing 
others I think we can let it be, unless it's impacting too many cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #29: Can/should we make Jira read-only on migration to GitHub issues?

2022-07-10 Thread GitBox


mikemccand commented on issue #29:
URL: 
https://github.com/apache/lucene-jira-archive/issues/29#issuecomment-1179717361

   This [Atlassian JIra documentation looks like a great 
start](https://confluence.atlassian.com/jirakb/how-to-make-jira-issues-read-only-using-workflow-properties-1063568771.html)!
  Not sure if we can update these properties ourselves or we need an Infra 
ticket, but it looks quite simple.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mikemccand commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179717138

   > As for "making JIra read-only", can you please explicitly gain consensus 
among devs in dev@ list, as I wrote in #15?
   
   I opened #29 to make progress on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #29: Can/should we make Jira read-only on migration to GitHub issues?

2022-07-10 Thread GitBox


mikemccand opened a new issue, #29:
URL: https://github.com/apache/lucene-jira-archive/issues/29

   I think it is crazy trappy to leave Jira as writable after "switching" to 
GitHub issues.  New users, people seeing old emails in archives and clicking on 
Jira links, old links in our Wiki/blog posts that we fail/forget to update, 
will all entice new users to make changes in Jira.  I think this is really 
quite dangerous, and would specifically impact new users (not us old timers) 
which is the worst possible impact since our community grows only at its 
periphery of new users/contributors/developers.
   
   In fact, I don't think we can even call it a switch/migration if we have two 
writable issue tracking systems.
   
   Second, it is apparently not hard (at least, I heard from @rmuir that people 
do this by accident sometimes!  I have not researched much myself) to restrict 
the workflow of Jira so that nothing is writable.
   
   We should also [add a comment to every Jira pointing to the migrated GitHub 
issue](https://github.com/apache/lucene-jira-archive/issues/15), and perhaps 
ideally (lower priority) [automatically redirect Jira issues to the right 
GitHub issue](https://github.com/apache/lucene-jira-archive/issues/28).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mikemccand commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179716082

   > I really don't want to say this but - just to be clear, I'm working on 
this migration project as an individual without support/returns from any 
organizations.
   
   I totally understand @mocobeta and I am in absolute awe of the energy you've 
put into this.  I'm sorry I have failed to make enough time to help.  I know it 
is an insanely difficult project.  I'm sorry if I am causing more stress!  We 
don't have to rush this migration.  Please don't burn out :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mikemccand commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179715650

   > I would love if these old URLs could simply redirect to github, unless a 
special token is passed ("noredirect") was used in the URL - this is what 
spring folks did.
   
   I opened #28 for this.  Thanks @dweiss!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #28: Could we work with Infra to have Jira issues redirect to the right GitHub issue?

2022-07-10 Thread GitBox


mikemccand opened a new issue, #28:
URL: https://github.com/apache/lucene-jira-archive/issues/28

   Spinoff from @dweiss's idea 
[here](https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1172257611).
   
   This is a lower priority task, and should not block the migration.
   
   It would be awesome if we could redirect future attempts to load legacy Jira 
issues to the corresponding GitHub issue, unless an explicit opt-out parameter 
is included to express explicit intent to load the old issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mikemccand commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179715196

   For step 9, maybe we can ask/plan for volunteers in the dev community to 
help check for anything that went wrong during the import process.  We of 
course should test as much as possible in this development phase (thank you 
@mocobeta!) before we migrate as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub"

2022-07-10 Thread GitBox


mikemccand commented on issue #15:
URL: 
https://github.com/apache/lucene-jira-archive/issues/15#issuecomment-1179715096

   > @mikemccand I know it's technically possible, but I'm unsure if it can be 
done without additional discussion in the dev@ mail list. This is another 
issue; please feel free to raise an issue and/or start a discussion in the dev 
list to gain consensus - and change the Jira workflow - I just have no extra 
energy to organize another possibly controversial conversation.
   
   OK, I'm sorry for adding stress!  I'll open a separate issue here to discuss 
/ gain consensus.
   
   > Regardless of whether we make Jira read-only or not, I think we should add 
comments to let readers who reach Jira issues know the issues were moved to 
GitHub.
   
   +1 -- let's leave this issue open for that purpose.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #27: Improve the `Jira Information` header?

2022-07-10 Thread GitBox


mikemccand opened a new issue, #27:
URL: https://github.com/apache/lucene-jira-archive/issues/27

   I think we should polish the header a bit.  Here is an example of what it 
looks like now:
   
   ```
   Jira information
   Original Jira: https://issues.apache.org/jira/browse/LUCENE-2230
   Reporter: Fuad Efendi
   Assignee:
   Created: 2010-01-21T20:18:24.387+
   Updated: 2011-05-17T19:43:13.861+
   Resolved: None
   
   Issue Links:
   
   Sub-Tasks:
   
   Pull Requests:
   ```
   
   Could we?:
 * Change the header to `Legacy Jira Details`
 * If there are no issue links, sub tasks, pull requests, Assignee, 
Resolved, etc., let's not output those empty lines
 * Render original Jira as a hyperlink with issue as the text, i.e. 
[LUCENE-2230](https://issues.apache.org/jira/browse/LUCENE-2230).  No need for 
the `Original Jira` header I think?
 *  Render dates like `2010-01-21` (leave off the timestamp, timezone)
   
   So then maybe it could look something like this:
   
   ```
   Legacy Jira LUCENE-2230
   Reporter: Fuad Efendi
   Created: 2010-01-21
   Updated: 2011-05-17
   ```
   
   I can maybe take a stab at this ... but I'm have some trouble finding where 
this text is generated in the Jira export / GitHub import source code...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mocobeta commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179710966

   I understand it may not fulfill everyone's request/hope though, I already 
have too much on my plate. Please feel free to work on further improvements on 
Jira side, if you think it should be done for the move to GitHub (making Jira 
read-only, redirecting to GitHub from Jira, and so on).
   
   I really don't want to say this but - just to be clear, I'm working on this 
migration project as an individual without support from any organizations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #12: Make a test set for improving markup conversion quality

2022-07-10 Thread GitBox


mocobeta commented on issue #12:
URL: 
https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1179706447

   > Hi @mocobeta -- I couldn't understand what went wrong in this issue?
   
   I meant this comment. This should be plain text, not interpreted as headers.
   
   ![Screenshot from 2022-07-10 
20-01-27](https://user-images.githubusercontent.com/1825333/178142132-7ba62c9e-6fcc-4c61-add7-0fb08956225e.png)
   
   > Indeed, there was at least one comment (I think?) where the author used 
Markdown (which does not work in Jira, yet many of us forget and use it anyway, 
just like seeing a naked bq. here on GitHub or in emails!) and then the 
rendering worked on migration! A surprising benefit of migration ;)
   
   I don't think unintentional markdowns will be properly rendered after 
migration. Markdowns in Jira are (correctly) escaped in the converter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mocobeta commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179704932

   > 2b) On Y date, send email saying migration will start shortly, reminding 
that Jira will be read-only for the duration.
   > 2c) Then, make Jira read-only ([this seems like a good 
hint](https://confluence.atlassian.com/jirakb/how-to-make-jira-issues-read-only-using-workflow-properties-1063568771.html)).
   
   As for "making JIra read-only", can you please explicitly gain consensus 
among devs in dev@list, as I wrote in #15?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #12: Make a test set for improving markup conversion quality

2022-07-10 Thread GitBox


mikemccand commented on issue #12:
URL: 
https://github.com/apache/lucene-jira-archive/issues/12#issuecomment-1179704669

   > * 
[LUCENE-2230](https://github.com/mocobeta/sandbox-lucene-10557/issues/2472) - 
won't fix, maybe not a big problem
   
   Hi @mocobeta -- I couldn't understand what went wrong in this issue?
   
   Indeed, there was at least one comment (I think?) where the author used 
Markdown (which does not work in Jira, yet many of us forget and use it anyway, 
just like seeing a naked `bq.` here on GitHub or in emails!) and then the 
rendering worked on migration!  A surprising benefit of migration ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub"

2022-07-10 Thread GitBox


mocobeta commented on issue #15:
URL: 
https://github.com/apache/lucene-jira-archive/issues/15#issuecomment-1179704284

   > We should also make Jira effectively read-only by editing the workflow for 
our project to disable any actual changes. @rmuir had suggested this is 
possible and indeed sometimes happens by accident ;)
   
   @mikemccand I know it's technically possible, but I'm unsure if it can be 
done without additional discussion in the dev@ mail list. This is another 
issue; please feel free to raise an issue and/or start a discussion in the dev 
list to gain consensus - and change the Jira workflow - I just have no extra 
energy to organize a possibly controversial conversation.
   
   Regardless of whether we make Jira read-only or not, I think we should add 
comments to let readers who reach Jira issues know the issues were moved to 
GitHub.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub"

2022-07-10 Thread GitBox


mikemccand commented on issue #15:
URL: 
https://github.com/apache/lucene-jira-archive/issues/15#issuecomment-1179702708

   I have not tested this, but as of Jira 5.0 (I think we are running 5.x at 
Apache), we could use the [Jira REST 
API](https://developer.atlassian.com/server/jira/platform/updating-an-issue-via-the-jira-rest-apis-6848604/)
 to append a comment to each Jira issue.  Not sure if this can bypass the 
read-only workflow, maybe?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mikemccand commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179702122

   Could we separate step 2) into:
   
   ```
   2a) Announce X days in advance that on Y date, Jira will go read-only and we 
will migrate to GitHub issues, taking estimated Z time to complete.
   2b) On Y date, send email saying migration will start shortly, reminding 
that Jira will be read-only for the duration.
   2c) Then, make Jira read-only ([this seems like a good 
hint](https://confluence.atlassian.com/jirakb/how-to-make-jira-issues-read-only-using-workflow-properties-1063568771.html)).
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #7: Make a detailed migration plan

2022-07-10 Thread GitBox


mikemccand commented on issue #7:
URL: 
https://github.com/apache/lucene-jira-archive/issues/7#issuecomment-1179701707

   > Sure, I agree this can be postponed - I just wanted to signal that it'd be 
a nice thing to have. We wouldn't be able to do it anyway - I think it'd have 
to be a request to infra to set up such a redirect (and we'd need to produce a 
mapping file of old-new urls).
   
   Let's at least open an issue for this (lower priority) future task.  It 
would be great if we could work with Infra to eventually achieve this.  But I 
agree it need not block the initial migration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub"

2022-07-10 Thread GitBox


mikemccand commented on issue #15:
URL: 
https://github.com/apache/lucene-jira-archive/issues/15#issuecomment-1179701515

   We should also make Jira effectively read-only by editing the workflow for 
our project to disable any actual changes.  @rmuir had suggested this is 
possible and indeed sometimes happens by accident ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org