[jira] [Commented] (MNG-4996) Maven3 parallel build fails occasionally for classpath problems.

2018-09-16 Thread Umberto Nicoletti (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617112#comment-16617112
 ] 

Umberto Nicoletti commented on MNG-4996:


We seem to be hitting this exact problem: we have a project with ~ 80 modules 
and build with *-T8*. Very often the build will fail to compile tests (only 
tests compilation is affected, nothing else).

We're investigating if it's really the problem with the aggregation module 
described in the above comment, but it's very likely it is.

 

This issue should not be closed.

> Maven3 parallel build fails occasionally for classpath problems.
> 
>
> Key: MNG-4996
> URL: https://issues.apache.org/jira/browse/MNG-4996
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.0.1
> Environment: maven 3.0.1, maven 3.0
>Reporter: Kari J. Niemi
>Assignee: Kristian Rosenvold
>Priority: Major
>
> In a multimodule (>120 modules) maven build, the compiler plug-in would seem 
> to fail in creating a correct class-path every now and then.
> Instead of this entry in maven -X logs for a single module build:
> 
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile' with basic 
> configurator -->
> ..
> [DEBUG]   (f) classpathElements = 
> [/home/karniemi/"mymodulepath"/target/classes, 
> /home/karniemi/.m2/repository/org/apache/servicemix/servicemix-utils/1.2.0/servicemix-utils-1.2.0.jar,
>  
> /home/karniemi/.m2/repository/org/apache/geronimo/specs/geronimo-stax-api_1.0_spec/1.0.1/geronimo-stax-api_1.0_spec-1.0.1.jar,
>  
> /home/karniemi/.m2/repository/org/codehaus/woodstox/wstx-asl/3.2.6/wstx-asl-3.2.6.jar,
>  
> /home/karniemi/.m2/repository/org/apache/servicemix/specs/org.apache.servicemix.specs.jbi-api-1.0/1.4.0/org.apache.servicemix.specs.jbi-api-1.0-1.4.0.jar,
>  
> /home/karniemi/.m2/repository/org/apache/geronimo/specs/geronimo-activation_1.1_spec/1.0.2/geronimo-activation_1.1_spec-1.0.2.jar,
>  /home/karniemi/.m2/repository/log4j/log4j/1.2.14/log4j-1.2.14.jar]
> 
> every now and then I get this in the parallel build:
> 
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile' with basic 
> configurator -->
> ...
> [DEBUG]   (f) classpathElements = 
> [/home/karniemi/"mymodulepath"/target/classes]
> 
> And of course the compilation fails because none of the dependencies are 
> added to the classpath. Sometimes it goes fine in the multi-module build, but 
> every now and then it fails for this.
> In both maven runs I can see that the dependencies are resolved fine:
> --
> [DEBUG] "mymodule":jar:DYNAMIC-SNAPSHOT
> [DEBUG]junit:junit:jar:4.7:test
> [DEBUG]org.apache.servicemix:servicemix-utils:jar:1.2.0:provided
> [DEBUG]   
> org.apache.geronimo.specs:geronimo-stax-api_1.0_spec:jar:1.0.1:provided
> [DEBUG]   org.codehaus.woodstox:wstx-asl:jar:3.2.6:provided
> [DEBUG]   
> org.apache.servicemix.specs:org.apache.servicemix.specs.jbi-api-1.0:jar:1.4.0:provided
>  (scope managed from compile) (version managed from 1.1.0)
> [DEBUG]  
> org.apache.geronimo.specs:geronimo-activation_1.1_spec:jar:1.0.2:provided
> [DEBUG]log4j:log4j:jar:1.2.14:provided
> ---
>  
> The  pluginArtifactMap looks like this:
> 
> [DEBUG]   (s) pluginArtifactMap = 
> {org.apache.maven.plugins:maven-surefire-plugin=org.apache.maven.plugins:maven-surefire-plugin:maven-plugin:2.6:,
>  
> org.apache.maven.surefire:surefire-booter=org.apache.maven.surefire:surefire-booter:jar:2.6:compile,
>  
> org.apache.maven.surefire:surefire-api=org.apache.maven.surefire:surefire-api:jar:2.6:compile,
>  
> org.apache.maven.surefire:maven-surefire-common=org.apache.maven.surefire:maven-surefire-common:jar:2.6:compile,
>  
> org.apache.maven.shared:maven-common-artifact-filters=org.apache.maven.shared:maven-common-artifact-filters:jar:1.2:compile,
>  
> org.codehaus.plexus:plexus-utils=org.codehaus.plexus:plexus-utils:jar:2.0.5:compile,
>  junit:junit=junit:junit:jar:3.8.1:compile, 
> org.apache.maven.reporting:maven-reporting-api=org.apache.maven.reporting:maven-reporting-api:jar:2.0.9:compile}
> 
> I'm really using jbi-maven-plugin for most of the modules, and that plugin 
> binds the other plugins -also the compiler-plugin -to maven life-cycle phases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6480) Eclipse.org site is down, and you are unable to build Maven?

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617111#comment-16617111
 ] 

Hudson commented on MNG-6480:
-

Build failed in Jenkins: Maven TLP » maven » master #79

See https://builds.apache.org/job/maven-box/job/maven/job/master/79/

> Eclipse.org site is down, and you are unable to build Maven?
> 
>
> Key: MNG-6480
> URL: https://issues.apache.org/jira/browse/MNG-6480
> Project: Maven
>  Issue Type: Improvement
>Reporter: Cservenak, Tamas
>Priority: Major
> Fix For: 3.6.0-candidate
>
>
> Was trying to build Maven locally, just to see it is failing (actually, too 
> way long was stuck in console). Had no idea what is happening until I did 
> {{-X}}, to see it is {{maven-remote-resources-plugin}} (see below).
> I am quite surprised to see, that if {{eclipse.org}} site is down (as in this 
> moment), one cannot build Apache Maven, and I find it quite ironic.
> {noformat}
> [DEBUG] URLResourceLoader: Exception when looking for 
> 'http://www.eclipse.org/legal/epl-v10.html' at ''
> java.net.SocketException: Unexpected end of file from server
>   at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:792)
>   at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
>   at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:789)
>   at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
>   at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1536)
>   at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)
>   at java.net.URL.openStream(URL.java:1045)
>   at 
> org.codehaus.plexus.resource.loader.URLResourceLoader.getResource(URLResourceLoader.java:73)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getResource(DefaultResourceManager.java:159)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getResourceAsFile(DefaultResourceManager.java:91)
>   at sun.reflect.GeneratedMethodAccessor69.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
>   at 
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
>   at 
> org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
>   at 
> org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
>   at 
> org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:567)
>   at 
> org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:71)
>   at 
> org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:142)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
>   at 
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
>   at 
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
>   at 
> org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
>   at 
> org.apache.velocity.runtime.RuntimeInstance.render(RuntimeInstance.java:1378)
>   at 
> org.apache.velocity.runtime.RuntimeInstance.evaluate(RuntimeInstance.java:1314)
>   at org.apache.velocity.app.Velocity.evaluate(Velocity.java:254)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1218)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute(ProcessRemoteResourcesMojo.java:520)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> 

[GitHub] khmarbaise commented on a change in pull request #176: Fix to prevent warning due to CI-friendly version in the parent pom

2018-09-16 Thread GitBox
khmarbaise commented on a change in pull request #176: Fix to prevent warning 
due to CI-friendly version in the parent pom
URL: https://github.com/apache/maven/pull/176#discussion_r217950350
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
 ##
 @@ -669,6 +669,9 @@ private void initProject( MavenProject project, 
Map projec
 else
 {
 Artifact parentArtifact = project.getParentArtifact();
+if 
(parentArtifact.getVersion().matches("\\$\\{(revision|sha1|changelist)}")) {
+
parentArtifact.setVersion(project.getModel().getParent().getVersion());
 
 Review comment:
   First the pattern is not enough if we really allow to use ci friendly in 
parent cause things like this `${revision}-${changelist}` are also possible 
which will not work with this pattern..Furthermore an integration test is 
needed for such things. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 11

2018-09-16 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617094#comment-16617094
 ] 

Karl Heinz Marbaise commented on MNG-6481:
--

JDK 11 latest RC1 (EA 28) should be available on all nodes see INFRA-17027 so 
we should check if we can run on 7,8,9,10,11...Yes we should do this cause many 
people are on 8,9,10 etc. 

> Allow to compile and test Maven with Java 11
> 
>
> Key: MNG-6481
> URL: https://issues.apache.org/jira/browse/MNG-6481
> Project: Maven
>  Issue Type: Improvement
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> Java 11 is coming closer, let's prepare to use it for the development of 
> Maven.
> A minimal requirement to run Maven - still Java 7.
>  * compile and pass Maven's tests with Java 11
>  * adjust ITs to run under Java 11
> Do we need compile and to pass all tests with Java 9 and 10?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6479) Upgrade XMLUnit to 2.2.1

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616918#comment-16616918
 ] 

Hudson commented on MNG-6479:
-

Build succeeded in Jenkins: Maven TLP » maven » master #78

See https://builds.apache.org/job/maven-box/job/maven/job/master/78/

> Upgrade XMLUnit to 2.2.1
> 
>
> Key: MNG-6479
> URL: https://issues.apache.org/jira/browse/MNG-6479
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Priority: Trivial
> Fix For: 3.6.0-candidate
>
>
> Upgrade XMLUnit test dependency from 1.x line to 2.2.1 and correct test cases
> _XMLUnit 2.x will never try to compare unmatched nodes with arbitrary other 
> nodes_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6481) Allow to compile and test Maven with Java 11

2018-09-16 Thread Sylwester Lachiewicz (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MNG-6481:
--
Fix Version/s: 3.6.x-candidate

> Allow to compile and test Maven with Java 11
> 
>
> Key: MNG-6481
> URL: https://issues.apache.org/jira/browse/MNG-6481
> Project: Maven
>  Issue Type: Improvement
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> Java 11 is coming closer, let's prepare to use it for the development of 
> Maven.
> A minimal requirement to run Maven - still Java 7.
>  * compile and pass Maven's tests with Java 11
>  * adjust ITs to run under Java 11
> Do we need compile and to pass all tests with Java 9 and 10?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MNG-6481) Allow to compile and test Maven with Java 11

2018-09-16 Thread Sylwester Lachiewicz (JIRA)
Sylwester Lachiewicz created MNG-6481:
-

 Summary: Allow to compile and test Maven with Java 11
 Key: MNG-6481
 URL: https://issues.apache.org/jira/browse/MNG-6481
 Project: Maven
  Issue Type: Improvement
Reporter: Sylwester Lachiewicz


Java 11 is coming closer, let's prepare to use it for the development of Maven.

A minimal requirement to run Maven - still Java 7.

 * compile and pass Maven's tests with Java 11
 * adjust ITs to run under Java 11

Do we need compile and to pass all tests with Java 9 and 10?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6479) Upgrade XMLUnit to 2.2.1

2018-09-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616903#comment-16616903
 ] 

ASF GitHub Bot commented on MNG-6479:
-

olamy closed pull request #183: [MNG-6479] Upgrade XMLUnit to 2.2.1
URL: https://github.com/apache/maven/pull/183
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-model-builder/pom.xml b/maven-model-builder/pom.xml
index d447d6c019..a087c36a81 100644
--- a/maven-model-builder/pom.xml
+++ b/maven-model-builder/pom.xml
@@ -71,9 +71,13 @@ under the License.
   test
 
 
-  xmlunit
-  xmlunit
-  1.6
+  org.xmlunit
+  xmlunit-core
+  test
+
+
+  org.xmlunit
+  xmlunit-matchers
   test
 
   
diff --git 
a/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
 
b/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
index 372d0a9b73..7907014185 100644
--- 
a/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
+++ 
b/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
@@ -21,21 +21,16 @@
 
 import org.apache.maven.model.Model;
 import org.apache.maven.model.building.SimpleProblemCollector;
-import org.apache.maven.model.io.ModelParseException;
 import org.apache.maven.model.io.ModelReader;
 import org.apache.maven.model.io.ModelWriter;
 import org.codehaus.plexus.PlexusTestCase;
-import org.custommonkey.xmlunit.XMLAssert;
-import org.custommonkey.xmlunit.XMLUnit;
 
-import junit.framework.AssertionFailedError;
+import org.xmlunit.matchers.CompareMatcher;
 
 import java.io.File;
-import java.io.FileInputStream;
 import java.io.IOException;
-import java.io.InputStreamReader;
-import java.io.Reader;
-import java.nio.charset.StandardCharsets;
+
+import static org.junit.Assert.assertThat;
 
 /**
  * @author Hervé Boutemy
@@ -66,7 +61,7 @@ private File getPom( String name )
 }
 
 private Model getModel( String name )
-throws ModelParseException, IOException
+throws IOException
 {
 return reader.read( getPom( name ), null );
 }
@@ -80,7 +75,7 @@ public void testPluginConfiguration()
 /**
  * Check most classical urls inheritance: directory structure where parent 
POM in parent directory
  * and child directory == artifactId
- * @throws Exception
+ * @throws IOException Model read problem
  */
 public void testUrls()
 throws Exception
@@ -90,10 +85,10 @@ public void testUrls()
 
 /**
  * Flat directory structure: parent  child POMs in sibling 
directories, child directory == artifactId.
- * @throws Exception
+ * @throws IOException Model read problem
  */
 public void testFlatUrls()
-throws Exception
+throws IOException
 {
 testInheritance( "flat-urls" );
 }
@@ -102,10 +97,10 @@ public void testFlatUrls()
  * Tricky case: flat directory structure, but child directory != 
artifactId.
  * Model interpolation does not give same result when calculated from 
build or from repo...
  * This is why MNG-5000 fix in code is marked as bad practice (uses file 
names)
- * @throws Exception
+ * @throws IOException Model read problem
  */
 public void testFlatTrickyUrls()
-throws Exception
+throws IOException
 {
 // parent references child with artifactId (which is not directory 
name)
 // then relative path calculation will fail during build from disk but 
success when calculated from repo
@@ -115,46 +110,49 @@ public void testFlatTrickyUrls()
 testInheritance( "tricky-flat-artifactId-urls", false );
 //fail( "should have failed since module reference == artifactId 
!= directory name" );
 }
-catch ( AssertionFailedError afe )
+catch ( AssertionError afe )
 {
 // expected failure: wrong relative path calculation
 assertTrue( afe.getMessage(),
-afe.getMessage().contains( 
"http://www.apache.org/path/to/parent/child-artifact-id/; ) );
+afe.getMessage().contains(
+"Expected text value 
'http://www.apache.org/path/to/parent/child-artifact-id/' but was " +
+
"'http://www.apache.org/path/to/parent/../child-artifact-id/'" ) );
 }
 // but ok from repo: local disk is ignored
 testInheritance( "tricky-flat-artifactId-urls", true );
 
 // parent references child with directory name (which 

[GitHub] olamy closed pull request #183: [MNG-6479] Upgrade XMLUnit to 2.2.1

2018-09-16 Thread GitBox
olamy closed pull request #183: [MNG-6479] Upgrade XMLUnit to 2.2.1
URL: https://github.com/apache/maven/pull/183
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-model-builder/pom.xml b/maven-model-builder/pom.xml
index d447d6c019..a087c36a81 100644
--- a/maven-model-builder/pom.xml
+++ b/maven-model-builder/pom.xml
@@ -71,9 +71,13 @@ under the License.
   test
 
 
-  xmlunit
-  xmlunit
-  1.6
+  org.xmlunit
+  xmlunit-core
+  test
+
+
+  org.xmlunit
+  xmlunit-matchers
   test
 
   
diff --git 
a/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
 
b/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
index 372d0a9b73..7907014185 100644
--- 
a/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
+++ 
b/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
@@ -21,21 +21,16 @@
 
 import org.apache.maven.model.Model;
 import org.apache.maven.model.building.SimpleProblemCollector;
-import org.apache.maven.model.io.ModelParseException;
 import org.apache.maven.model.io.ModelReader;
 import org.apache.maven.model.io.ModelWriter;
 import org.codehaus.plexus.PlexusTestCase;
-import org.custommonkey.xmlunit.XMLAssert;
-import org.custommonkey.xmlunit.XMLUnit;
 
-import junit.framework.AssertionFailedError;
+import org.xmlunit.matchers.CompareMatcher;
 
 import java.io.File;
-import java.io.FileInputStream;
 import java.io.IOException;
-import java.io.InputStreamReader;
-import java.io.Reader;
-import java.nio.charset.StandardCharsets;
+
+import static org.junit.Assert.assertThat;
 
 /**
  * @author Hervé Boutemy
@@ -66,7 +61,7 @@ private File getPom( String name )
 }
 
 private Model getModel( String name )
-throws ModelParseException, IOException
+throws IOException
 {
 return reader.read( getPom( name ), null );
 }
@@ -80,7 +75,7 @@ public void testPluginConfiguration()
 /**
  * Check most classical urls inheritance: directory structure where parent 
POM in parent directory
  * and child directory == artifactId
- * @throws Exception
+ * @throws IOException Model read problem
  */
 public void testUrls()
 throws Exception
@@ -90,10 +85,10 @@ public void testUrls()
 
 /**
  * Flat directory structure: parent  child POMs in sibling 
directories, child directory == artifactId.
- * @throws Exception
+ * @throws IOException Model read problem
  */
 public void testFlatUrls()
-throws Exception
+throws IOException
 {
 testInheritance( "flat-urls" );
 }
@@ -102,10 +97,10 @@ public void testFlatUrls()
  * Tricky case: flat directory structure, but child directory != 
artifactId.
  * Model interpolation does not give same result when calculated from 
build or from repo...
  * This is why MNG-5000 fix in code is marked as bad practice (uses file 
names)
- * @throws Exception
+ * @throws IOException Model read problem
  */
 public void testFlatTrickyUrls()
-throws Exception
+throws IOException
 {
 // parent references child with artifactId (which is not directory 
name)
 // then relative path calculation will fail during build from disk but 
success when calculated from repo
@@ -115,46 +110,49 @@ public void testFlatTrickyUrls()
 testInheritance( "tricky-flat-artifactId-urls", false );
 //fail( "should have failed since module reference == artifactId 
!= directory name" );
 }
-catch ( AssertionFailedError afe )
+catch ( AssertionError afe )
 {
 // expected failure: wrong relative path calculation
 assertTrue( afe.getMessage(),
-afe.getMessage().contains( 
"http://www.apache.org/path/to/parent/child-artifact-id/; ) );
+afe.getMessage().contains(
+"Expected text value 
'http://www.apache.org/path/to/parent/child-artifact-id/' but was " +
+
"'http://www.apache.org/path/to/parent/../child-artifact-id/'" ) );
 }
 // but ok from repo: local disk is ignored
 testInheritance( "tricky-flat-artifactId-urls", true );
 
 // parent references child with directory name (which is not artifact 
id)
-// then relative path calculation will success during build from disk 
but failwhen calculated from repo
+// then relative path calculation will success during build from disk 
but fail when 

[jira] [Closed] (SUREFIRE-1571) Upgrade maven-plugins parent to version 33

2018-09-16 Thread Tibor Digana (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana closed SUREFIRE-1571.
--
Resolution: Fixed

https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=7c753eb0acf61e49074dfec973ceefef7da92383

> Upgrade maven-plugins parent to version 33
> --
>
> Key: SUREFIRE-1571
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1571
> Project: Maven Surefire
>  Issue Type: Dependency upgrade
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Minor
> Fix For: 2.22.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SUREFIRE-1571) Upgrade maven-plugins parent to version 33

2018-09-16 Thread Tibor Digana (JIRA)
Tibor Digana created SUREFIRE-1571:
--

 Summary: Upgrade maven-plugins parent to version 33
 Key: SUREFIRE-1571
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1571
 Project: Maven Surefire
  Issue Type: Dependency upgrade
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 2.22.1






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1532) MIME type for javascript is now officially application/javascript

2018-09-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616882#comment-16616882
 ] 

ASF GitHub Bot commented on SUREFIRE-1532:
--

Tibor17 commented on issue #188: [SUREFIRE-1532]  MIME type for javascript is 
now officially application/javascript
URL: https://github.com/apache/maven-surefire/pull/188#issuecomment-421825588
 
 
   @based2 
   Did you also run the build (mvn -P run-its install) and did you see the 
failing test `Surefire260TestWithIdenticalNamesIT`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> MIME type for javascript is now officially application/javascript
> -
>
> Key: SUREFIRE-1532
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1532
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.22.0
>Reporter: Basile Chandesris
>Priority: Minor
>  Labels: easyfix
>
>  
> ref [http://www.rfc-editor.org/rfc/rfc4329.txt 
> |http://www.rfc-editor.org/rfc/rfc4329.txt]Scripting Media Types
> src 
> [https://stackoverflow.com/questions/189850/what-is-the-javascript-mime-type-for-the-type-attribute-of-a-script-tag]
> "This is a common mistake. The MIME type for javascript wasn't standardized 
> for years. It's now officially: "application/javascript"."
> github 
> https://github.com/apache/maven-surefire/pull/188#issuecomment-401559853
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] Tibor17 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript

2018-09-16 Thread GitBox
Tibor17 commented on issue #188: [SUREFIRE-1532]  MIME type for javascript is 
now officially application/javascript
URL: https://github.com/apache/maven-surefire/pull/188#issuecomment-421825588
 
 
   @based2 
   Did you also run the build (mvn -P run-its install) and did you see the 
failing test `Surefire260TestWithIdenticalNamesIT`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-5666) Divide lifecycle in prePhases, phases and postPhases

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616877#comment-16616877
 ] 

Hudson commented on MNG-5666:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-5666 #6

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5666/6/

> Divide lifecycle in prePhases, phases and postPhases
> 
>
> Key: MNG-5666
> URL: https://issues.apache.org/jira/browse/MNG-5666
> Project: Maven
>  Issue Type: Sub-task
>  Components: FDPFC, Plugins and Lifecycle
>Reporter: Robert Scholte
>Assignee: Jason van Zyl
>Priority: Major
> Fix For: 3.x / Backlog
>
>
> Original proposal
> {quote}
> PROPOSAL 1: PerProject and PerPhase Executions
>  
> I've recently introduced the installAtEnd/deployAtEnd as an experimental 
> feature which should improve the behavior of Maven without having to wait for 
> the implementation in Maven Core, which would have a huge impact.
> The reason is that you only want to install and/or deploy only after all 
> modules have been build and verified successfully.
> This feature works for most projects, however there are cases which cannot be 
> solved by the plugin solution and require a change in the handling of 
> lifecycles in Maven Core.
> Up unto the verify-phase you want to execute all phases per project, whereas 
> the install and deploy should be executed per phase.
> Consider a root project with 2 modules, these should be executed like this
>  
> root   : validate ... verify
> module1: validate ... verify
> module2: validate ... verify
> root   : install
> module1: install
> module2: install
> root   : deploy
> module1: deploy
> module2: deploy
> {quote}
> After one of the google hangout session we came up with the following idea: 
> divide the build in pre-build, build and post-build
> First the {{pre-build}} would do a validate of the whole project.
> The {{build}} runs from {{initialize}} up to {{verify}}
> The {{post-build}} would handle the distribution, being {{install}}/{{deploy}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6473) Update Mockito to 2.21.0

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616874#comment-16616874
 ] 

Hudson commented on MNG-6473:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-5666 #6

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5666/6/

> Update Mockito to 2.21.0
> 
>
> Key: MNG-6473
> URL: https://issues.apache.org/jira/browse/MNG-6473
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Trivial
> Fix For: 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6311) Maven intolerably slow when import scope used heavily in large project

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616876#comment-16616876
 ] 

Hudson commented on MNG-6311:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-5666 #6

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5666/6/

> Maven intolerably slow when import scope used heavily in large project
> --
>
> Key: MNG-6311
> URL: https://issues.apache.org/jira/browse/MNG-6311
> Project: Maven
>  Issue Type: Bug
>  Components: core, Performance
>Affects Versions: 3.5.0, 3.5.2
>Reporter: David Churcher
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: performance
> Fix For: 3.6.0
>
> Attachments: Call-tree-–-All-threads-together.html, 
> anon-hierarchy-maven-output.zip, modelcachefix.diff
>
>
> I have a build performance problem that is identical to MNG-5312, and has 
> appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, 
> removing the ModelCache from some of the overloads for 
> DefaultProjectBuilder.build. 
> As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 
> levels of parent POMs, many of which use the import scope and have large 
> dependency-management sections, and has hundreds of dependencies that also 
> use the same parent POM hierarchy. Adding some logging shows that Maven does 
> over 800,000 uncached reads of parent POM files, which takes about half an 
> hour. With model caching this goes down to a few seconds.
> I've attached a patch that fixes this by using a class-level ModelCache in 
> DefaultProjectBuilder. This does not suffer from the memory usage problems 
> reported in MNG-6030.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6467) Remove plugin definition from pom file which is inherited

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616873#comment-16616873
 ] 

Hudson commented on MNG-6467:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-5666 #6

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5666/6/

> Remove plugin definition from pom file which is inherited
> -
>
> Key: MNG-6467
> URL: https://issues.apache.org/jira/browse/MNG-6467
> Project: Maven
>  Issue Type: Improvement
>  Components: Errors, General
>Affects Versions: 3.6.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
> Fix For: 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6475) Remove guava dependencies

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616875#comment-16616875
 ] 

Hudson commented on MNG-6475:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-5666 #6

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5666/6/

> Remove guava dependencies
> -
>
> Key: MNG-6475
> URL: https://issues.apache.org/jira/browse/MNG-6475
> Project: Maven
>  Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Phillip Webb
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
> Fix For: 3.6.0
>
>
> It looks like [this 
> commit|https://github.com/apache/maven/commit/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751]
>  removed Guava imports from the codebase, however, several dependencies are 
> still declared in the POMs. This can be problematic for projects that embed 
> Maven jars (see MNG-6306 for an example).
> I tried a local Maven build with guava dependencies removed and it appears to 
> compile without issue. I'll submit a pull request with the relevant changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module

2018-09-16 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616872#comment-16616872
 ] 

Tibor Digana commented on SUREFIRE-1568:


[~Pavel_K]
[~rfscholte]
I compared the Jigsaw command argument for executing subprocess with mine and 
with your issue.
It looks like the bug is in the class {{ModularClasspathForkConfiguration}}, 
escaped characters in the paths on the file system and especially 
{{--module-path}}.
[~rfscholte]
What are recommendations to escape the characters of the path on Linux in case 
of Jigsaw?

{noformat}
--module-path
/home/Pavel/Foo 
Boo/mavenproject19/target/classes:/home/Pavel/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar
--class-path
/home/Pavel/.m2/repository/org/apache/maven/surefire/surefire-booter/2.22.0/surefire-booter-2.22.0.jar:/home/Pavel/.m2/repository/org/apache/maven/surefire/surefire-api/2.22.0/surefire-api-2.22.0.jar:/home/Pavel/.m2/repository/org/apache/maven/surefire/surefire-logger-api/2.22.0/surefire-logger-api-2.22.0.jar:/home/Pavel/Foo
 
Boo/mavenproject19/target/test-classes:/home/Pavel/.m2/repository/org/junit/jupiter/junit-jupiter-engine/5.2.0/junit-jupiter-engine-5.2.0.jar:/home/Pavel/.m2/repository/org/apiguardian/apiguardian-api/1.0.0/apiguardian-api-1.0.0.jar:/home/Pavel/.m2/repository/org/junit/platform/junit-platform-engine/1.2.0/junit-platform-engine-1.2.0.jar:/home/Pavel/.m2/repository/org/junit/platform/junit-platform-commons/1.2.0/junit-platform-commons-1.2.0.jar:/home/Pavel/.m2/repository/org/opentest4j/opentest4j/1.1.0/opentest4j-1.1.0.jar:/home/Pavel/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.2.0/junit-jupiter-api-5.2.0.jar:/home/Pavel/.m2/repository/org/apache/maven/surefire/surefire-junit-platform/2.22.0/surefire-junit-platform-2.22.0.jar:/home/Pavel/.m2/repository/org/junit/platform/junit-platform-launcher/1.2.0/junit-platform-launcher-1.2.0.jar
--patch-module
Mavenproject19=/home/Pavel/Foo Boo/mavenproject19/target/test-classes
--add-exports
Mavenproject19/me.pavel.mavenproject19=ALL-UNNAMED
--add-modules
Mavenproject19
--add-reads
Mavenproject19=ALL-UNNAMED
org.apache.maven.surefire.booter.ForkedBooter

{noformat}


> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Priority: Major
>  Labels: junit5
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt, 
> debug2.txt, mavenproject19.zip, mavenproject19_target_and_debug.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1 
> everything is ok - my tests are executed:
> {code:java}
>     
>     org.apache.maven.plugins
>     maven-surefire-plugin
>     2.20.1
>     
>     
>     org.junit.platform
>     
> junit-platform-surefire-provider
>     1.3.0
>     
>     
>     {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I 
> get the following:
> {code:java}
>     Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
>     The forked VM terminated without properly saying goodbye. VM crash or 
> System.exit called?
>     Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java 
> '@/home/project/target/surefire/surefireargs4438382394951202560' 
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1 
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
>     Error occurred in starting fork, check output in log
>     Process Exit Code: 1
>     org.apache.maven.surefire.booter.SurefireBooterForkException: The forked 
> VM terminated without properly saying goodbye. VM crash or System.exit called?
>     Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java 
> '@/home/project/target/surefire/surefireargs4438382394951202560' 
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1 
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
>     Error occurred in starting fork, check output in log
>     Process Exit Code: 1
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
>     

[jira] [Updated] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module

2018-09-16 Thread Pavel_K (JIRA)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel_K updated SUREFIRE-1568:
--
Attachment: mavenproject19_target_and_debug.zip

> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Priority: Major
>  Labels: junit5
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt, 
> debug2.txt, mavenproject19.zip, mavenproject19_target_and_debug.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1 
> everything is ok - my tests are executed:
> {code:java}
>     
>     org.apache.maven.plugins
>     maven-surefire-plugin
>     2.20.1
>     
>     
>     org.junit.platform
>     
> junit-platform-surefire-provider
>     1.3.0
>     
>     
>     {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I 
> get the following:
> {code:java}
>     Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
>     The forked VM terminated without properly saying goodbye. VM crash or 
> System.exit called?
>     Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java 
> '@/home/project/target/surefire/surefireargs4438382394951202560' 
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1 
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
>     Error occurred in starting fork, check output in log
>     Process Exit Code: 1
>     org.apache.maven.surefire.booter.SurefireBooterForkException: The forked 
> VM terminated without properly saying goodbye. VM crash or System.exit called?
>     Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java 
> '@/home/project/target/surefire/surefireargs4438382394951202560' 
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1 
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
>     Error occurred in starting fork, check output in log
>     Process Exit Code: 1
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1194)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1022)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:868)
>     at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>     at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>     at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>     at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>     at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)
>     at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> 

[jira] [Commented] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module

2018-09-16 Thread Pavel_K (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616869#comment-16616869
 ] 

Pavel_K commented on SUREFIRE-1568:
---

[~tibor17] I uploaded full target folder and debug file (-X).

> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Priority: Major
>  Labels: junit5
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt, 
> debug2.txt, mavenproject19.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1 
> everything is ok - my tests are executed:
> {code:java}
>     
>     org.apache.maven.plugins
>     maven-surefire-plugin
>     2.20.1
>     
>     
>     org.junit.platform
>     
> junit-platform-surefire-provider
>     1.3.0
>     
>     
>     {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I 
> get the following:
> {code:java}
>     Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
>     The forked VM terminated without properly saying goodbye. VM crash or 
> System.exit called?
>     Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java 
> '@/home/project/target/surefire/surefireargs4438382394951202560' 
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1 
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
>     Error occurred in starting fork, check output in log
>     Process Exit Code: 1
>     org.apache.maven.surefire.booter.SurefireBooterForkException: The forked 
> VM terminated without properly saying goodbye. VM crash or System.exit called?
>     Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java 
> '@/home/project/target/surefire/surefireargs4438382394951202560' 
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1 
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
>     Error occurred in starting fork, check output in log
>     Process Exit Code: 1
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1194)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1022)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:868)
>     at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>     at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>     at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>     at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>     at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)
>     at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> 

[jira] [Commented] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module

2018-09-16 Thread Tibor Digana (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616867#comment-16616867
 ] 

Tibor Digana commented on SUREFIRE-1568:


[~Pavel_K]
I used your project with JDK 9 and also JDK 8 and it worked on Windows.
I will try again with Ubuntu 16.04 tomorrow but ideal situation would be if you 
run the command in debug mode {{-X}} and copy the content {{(3 files)}} from 
{{target/surefire}} to Jira.
I will try to reproduce it tomorrow but I cannot guarantee that my result will 
be identical.

> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Priority: Major
>  Labels: junit5
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt, 
> debug2.txt, mavenproject19.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1 
> everything is ok - my tests are executed:
> {code:java}
>     
>     org.apache.maven.plugins
>     maven-surefire-plugin
>     2.20.1
>     
>     
>     org.junit.platform
>     
> junit-platform-surefire-provider
>     1.3.0
>     
>     
>     {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I 
> get the following:
> {code:java}
>     Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
>     The forked VM terminated without properly saying goodbye. VM crash or 
> System.exit called?
>     Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java 
> '@/home/project/target/surefire/surefireargs4438382394951202560' 
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1 
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
>     Error occurred in starting fork, check output in log
>     Process Exit Code: 1
>     org.apache.maven.surefire.booter.SurefireBooterForkException: The forked 
> VM terminated without properly saying goodbye. VM crash or System.exit called?
>     Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java 
> '@/home/project/target/surefire/surefireargs4438382394951202560' 
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1 
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
>     Error occurred in starting fork, check output in log
>     Process Exit Code: 1
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
>     at 
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1194)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1022)
>     at 
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:868)
>     at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>     at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>     at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>     at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>     at 

[jira] [Commented] (MJMOD-18) Upgrade parent to version 33

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MJMOD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616865#comment-16616865
 ] 

Hudson commented on MJMOD-18:
-

Build succeeded in Jenkins: Maven TLP » maven-jmod-plugin » master #24

See https://builds.apache.org/job/maven-box/job/maven-jmod-plugin/job/master/24/

> Upgrade parent to version 33
> 
>
> Key: MJMOD-18
> URL: https://issues.apache.org/jira/browse/MJMOD-18
> Project: Maven JMod Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MJMOD-18) Upgrade parent to version 33

2018-09-16 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MJMOD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616859#comment-16616859
 ] 

Karl Heinz Marbaise commented on MJMOD-18:
--

Done in 
[762b6feeb3e8b929c7ce30f03a7888aae0169e9e|https://gitbox.apache.org/repos/asf?p=maven-jmod-plugin.git;a=commitdiff;h=762b6feeb3e8b929c7ce30f03a7888aae0169e9e]

> Upgrade parent to version 33
> 
>
> Key: MJMOD-18
> URL: https://issues.apache.org/jira/browse/MJMOD-18
> Project: Maven JMod Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MJMOD-18) Upgrade parent to version 33

2018-09-16 Thread Karl Heinz Marbaise (JIRA)


 [ 
https://issues.apache.org/jira/browse/MJMOD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MJMOD-18.

Resolution: Done

> Upgrade parent to version 33
> 
>
> Key: MJMOD-18
> URL: https://issues.apache.org/jira/browse/MJMOD-18
> Project: Maven JMod Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MJMOD-18) Upgrade parent to version 33

2018-09-16 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MJMOD-18:


 Summary: Upgrade parent to version 33
 Key: MJMOD-18
 URL: https://issues.apache.org/jira/browse/MJMOD-18
 Project: Maven JMod Plugin
  Issue Type: Dependency upgrade
Affects Versions: 3.0.0
Reporter: Karl Heinz Marbaise
 Fix For: 3.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (MNG-5896) Download dependency POMs in parallel

2018-09-16 Thread Sylwester Lachiewicz (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz reassigned MNG-5896:
-

Assignee: Sylwester Lachiewicz

> Download dependency POMs in parallel
> 
>
> Key: MNG-5896
> URL: https://issues.apache.org/jira/browse/MNG-5896
> Project: Maven
>  Issue Type: Improvement
>  Components: Dependencies
>Affects Versions: 3.3.3
>Reporter: Harald Wellmann
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.x-candidate, needing-scrub-3.4.0-fallout
>
>
> h3. Background
> When building a project with dependencies not yet available in the local 
> repository, I noticed that Maven 3.3.3 first downloads the dependency POMs 
> _sequentially_ and then proceeds downloading the dependency JARs with up to 5 
> threads _in parallel_.
> Due to this, when first building a project with a large number of 
> dependencies, downloading a large number of small POMs may take a lot longer 
> than downloading the much larger JARs, or even longer than building the 
> project itself, especially when a repository manager is used which increases 
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed 
> up initial builds of large projects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-5896) Download dependency POMs in parallel

2018-09-16 Thread Sylwester Lachiewicz (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MNG-5896:
--
Fix Version/s: 3.6.x-candidate

> Download dependency POMs in parallel
> 
>
> Key: MNG-5896
> URL: https://issues.apache.org/jira/browse/MNG-5896
> Project: Maven
>  Issue Type: Improvement
>  Components: Dependencies
>Affects Versions: 3.3.3
>Reporter: Harald Wellmann
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.x-candidate, needing-scrub-3.4.0-fallout
>
>
> h3. Background
> When building a project with dependencies not yet available in the local 
> repository, I noticed that Maven 3.3.3 first downloads the dependency POMs 
> _sequentially_ and then proceeds downloading the dependency JARs with up to 5 
> threads _in parallel_.
> Due to this, when first building a project with a large number of 
> dependencies, downloading a large number of small POMs may take a lot longer 
> than downloading the much larger JARs, or even longer than building the 
> project itself, especially when a repository manager is used which increases 
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed 
> up initial builds of large projects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel

2018-09-16 Thread Michael Osipov (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616851#comment-16616851
 ] 

Michael Osipov commented on MRESOLVER-7:


Will review next week.

> Download dependency POMs in parallel
> 
>
> Key: MRESOLVER-7
> URL: https://issues.apache.org/jira/browse/MRESOLVER-7
> Project: Maven Resolver
>  Issue Type: Improvement
>Affects Versions: Aether 1.0.2
>Reporter: Harald Wellmann
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.1.2
>
>
> h3. Background
> When building a project with dependencies not yet available in the local 
> repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the 
> dependency POMs _sequentially_ and then proceeds downloading the dependency 
> JARs with up to 5 threads _in parallel_.
> Due to this, when first building a project with a large number of 
> dependencies, downloading a large number of small POMs may take a lot longer 
> than downloading the much larger JARs, or even longer than building the 
> project itself, especially when a repository manager is used which increases 
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed 
> up initial builds of large projects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MJLINK-30) Upgrade parent to version 33

2018-09-16 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MJLINK-30:
-

 Summary: Upgrade parent to version 33
 Key: MJLINK-30
 URL: https://issues.apache.org/jira/browse/MJLINK-30
 Project: Maven JLink Plugin
  Issue Type: Dependency upgrade
Affects Versions: 3.0.0
Reporter: Karl Heinz Marbaise
 Fix For: 3.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MASSEMBLY-873) Maven-Assembly-Plugin freezes when building jar-with-dependencies of project depending on org.bouncycastle:bcprov-jdk15on:1.58

2018-09-16 Thread Sylwester Lachiewicz (JIRA)


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616845#comment-16616845
 ] 

Sylwester Lachiewicz commented on MASSEMBLY-873:


Yes, plexus-archiver first need to change/resolve that.

> Maven-Assembly-Plugin freezes when building jar-with-dependencies of project 
> depending on org.bouncycastle:bcprov-jdk15on:1.58
> --
>
> Key: MASSEMBLY-873
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-873
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Maven 3.5.2, Java 8u151 (32-bit) as well as 9.0 
> (64-bit), Windows 10
>Reporter: Michael Schierl
>Priority: Major
> Attachments: pom.xml
>
>
> To reproduce:
> 1. Create a new directory
> 2. Add attached pom.xml (no other sources required to reproduce; in real 
> world you would add some source that uses BouncyCastle lib, too).
> 3. Run {{mvn package}}
> Actual result:
> Maven hangs after 
> {{[INFO] Building jar: 
> C:\Daten\Eigenes\svn\iota\hang\target\bug-1.0-SNAPSHOT-jar-with-dependencies.jar}}
> , consuming one CPU core.
> Expected result:
> Maven builds a package containing no own source and the dependency 
> (bouncycastle)
> Workaround:
> In maven local repository, edit the .jar file of BouncyCastle and remove the 
> `META-INF\BC*` files. Then the package can be built again. So it seems to be 
> caused somehow by verifying signed jar files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MASSEMBLY-889) Maven assembly not able to handle large capacity .tar.gz packaging

2018-09-16 Thread Sylwester Lachiewicz (JIRA)


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616843#comment-16616843
 ] 

Sylwester Lachiewicz commented on MASSEMBLY-889:


I saw feedback from OOZIE-3120 that with 3.1 they have no problem with archive 
size.

> Maven assembly not able to handle large capacity .tar.gz packaging
> --
>
> Key: MASSEMBLY-889
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-889
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 2.4
> Environment: Linux
>Reporter: Sriram Kotni
>Priority: Major
>  Labels: maven
> Fix For: waiting-for-feedback
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> We are using Maven assembly to tar.gz file size of 2.5 gb is not able to 
> handle. Because of this we are not able support multi language Knowledge Base 
> support. There is a big impact for our business. 
> Any suggestions and alternate solutions are appreciated.
>  
> Thanks,
> Sriram



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-5951) add an option to avoid path addition to inherited URLs

2018-09-16 Thread Mark Raynsford (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616829#comment-16616829
 ] 

Mark Raynsford commented on MNG-5951:
-

Nice work. Thank you!

> add an option to avoid path addition to inherited URLs
> --
>
> Key: MNG-5951
> URL: https://issues.apache.org/jira/browse/MNG-5951
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Affects Versions: 3.0.5, 3.1.1, 3.2.5, 3.3.9
>Reporter: Jörg Sesterhenn
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: MNG-5951.zip
>
>
> What I am trying to achieve is 
> the definition of a project.url in a parent pom 
> in a way that all children inherit a url ending with 
> {code}
> ${project.groupId}/${project.artifactId}/${project.version}/ 
> {code}
> in order to be able to publish sites of all artifacts in all versions in 
> parallel
> without having to redefine the url in every child pom.
> This is currently not working as expected in maven due to the default child 
> urls calculation which leads to urls that add up parent urls like 
> http://my.domain.de/sites/de.enterprise.calculatorsGroupId/calculator-artifactID/1.0.0-SNAPSHOT/internetAppParentPOM/calculatorParentPom/calculator-artifactID/
> The part *"internetAppParentPOM/calculatorParentPom/"* is added by automatic 
> child url calculation (those are the artifactIds of all parent poms beneath 
> our enterprise parent pom where the url is defined) and *is expexted to not 
> be there at all*. The repeated artifactID at the end of the url is 
> superfluous as well but tollerable.
> I expect maven-core to be changed so that I can turn on/off the automatic 
> calculation of child URLs as an option which is by default on (current 
> behaviour so nothing will change unless configured explicitly).
> See the discussion in MSITE-672. 
> As this can not be done in the maven-site-plugin there needs to be a change 
> in Maven itself (core), in Maven Model Builder, ie the way effective model is 
> calculated, and more precisely in the inheritance step: 
> http://maven.apache.org/ref/current/maven-model-builder/.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel

2018-09-16 Thread Sylwester Lachiewicz (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616825#comment-16616825
 ] 

Sylwester Lachiewicz commented on MRESOLVER-7:
--

[~michael-o] any plan to review? Maybe include this one with new Maven 3.6?

> Download dependency POMs in parallel
> 
>
> Key: MRESOLVER-7
> URL: https://issues.apache.org/jira/browse/MRESOLVER-7
> Project: Maven Resolver
>  Issue Type: Improvement
>Affects Versions: Aether 1.0.2
>Reporter: Harald Wellmann
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.1.2
>
>
> h3. Background
> When building a project with dependencies not yet available in the local 
> repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the 
> dependency POMs _sequentially_ and then proceeds downloading the dependency 
> JARs with up to 5 threads _in parallel_.
> Due to this, when first building a project with a large number of 
> dependencies, downloading a large number of small POMs may take a lot longer 
> than downloading the much larger JARs, or even longer than building the 
> project itself, especially when a repository manager is used which increases 
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed 
> up initial builds of large projects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MRRESOURCES-101) NPE - Error rendering velocity resource

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MRRESOURCES-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy closed MRRESOURCES-101.
-
Resolution: Fixed

change included in 
https://gitbox.apache.org/repos/asf?p=maven-remote-resources-plugin.git;a=commit;h=a6aea9b5310886877e51a6952d93bcded3ce5ece

> NPE - Error rendering velocity resource
> ---
>
> Key: MRRESOURCES-101
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-101
> Project: Maven Remote Resources Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
>Reporter: Daniel Klessing
>Priority: Major
> Fix For: 1.6.0
>
> Attachments: mrresources_npe.diff
>
>
> We noticed that occasionally the maven-remote-resources-plugin kills our 
> build as a NPE with the message "Error rendering velocity resource" happend.
> Luckily I succeeded today in getting a stacktrace of the issue:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project parent: Error rendering velocity resource. NullPointerException -> 
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process 
> (default) on project parent: Error rendering velocity resource.
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error rendering 
> velocity resource.
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1246)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute(ProcessRemoteResourcesMojo.java:520)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   ... 20 more
> Caused by: java.lang.NullPointerException
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1232)
>   ... 23 more
> [ERROR] 
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> Looking into the code I noticed that an "unguarded close()" in a 
> finally-block is the culprit. By replacing it with a call to 
> {{IOUtil.close()}} the problem is gone. See the attached patch/diff.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MRRESOURCES-106) ProcessRemoteResourcesMojo#getProjects() can end up consuming a lot of memory for big projects

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MRRESOURCES-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MRRESOURCES-106:
--
Fix Version/s: 1.6.0

> ProcessRemoteResourcesMojo#getProjects() can end up consuming a lot of memory 
> for big projects
> --
>
> Key: MRRESOURCES-106
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-106
> Project: Maven Remote Resources Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
>Reporter: Thomas Mortagne
>Priority: Major
> Fix For: 1.6.0
>
>
> At XWiki we are using the remote resource plugin to generate a NOTICE files 
> we put in the META-INF of all jars. The file can be found on 
> https://github.com/xwiki/xwiki-commons/blob/master/xwiki-commons-tools/xwiki-commons-tool-license-resources/src/main/resources/META-INF/NOTICE.vm.
> We have a lot of memory issues and we kept increasing the max memory but it 
> was starting to be a bit insane (we now get a OOM with -Xmx2500m) so I 
> finally took a profiler to try to figure out where all this memory goes.
> We did noticed for a while that remote resource plugin is taking longer and 
> longer to execute during the build so I had my doubts already.
> What Yourkit is telling me is that almost half of the memory (400MB here 
> because I reduced the max memory for it to fail earlier) is retained by an 
> ArrayList of MavenProject instances located in 
> ProcessRemoteResourcesMojo#getProjects().
> It can be reproduced by building https://github.com/xwiki/xwiki-platform (you 
> will need to add some repositories in your settings.xml, you can find them on 
> http://dev.xwiki.org/xwiki/bin/view/Community/Building/#HInstallingMaven).
> Also I can probably put the memory dump I have somewhere if someone wants to 
> download it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRRESOURCES-72) Process mojo ignores offline mode

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MRRESOURCES-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616792#comment-16616792
 ] 

Hervé Boutemy commented on MRRESOURCES-72:
--

see MNG-6480
the Maven source code should probably contain license copy to avoid stupid 
downloads from outside

I don't know really if this is the fault of the plugin if Maven's LICENSE.vm 
has coded some downloads...

> Process mojo ignores offline mode
> -
>
> Key: MRRESOURCES-72
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-72
> Project: Maven Remote Resources Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
> Environment: Apache Maven 3.0.3 (r1172588; 2011-09-19 14:36:33+0200)
> Maven home: /usr/local/apache-maven-3.0.3
> Java version: 1.7.0_25, vendor: Oracle Corporation
> Java home: /usr/local/openjdk7/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "freebsd", version: "9.2-prerelease", arch: "i386", family: "unix"
>Reporter: Michael Osipov
>Priority: Major
> Fix For: more-investigation
>
> Attachments: build.log, offline.log
>
>
> Building Maven 3.1.1 with {{-o}} still tries to retrieve a remote resource 
> and fails with: 
> {noformat}
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Maven .. SUCCESS [00:04.666]
> [INFO] Maven Model ... SUCCESS [00:09.662]
> [INFO] Maven Artifact  SUCCESS [00:08.064]
> [INFO] Maven Plugin API .. SUCCESS [00:04.378]
> [INFO] Maven Model Builder ... SUCCESS [00:09.794]
> [INFO] Maven Settings  SUCCESS [00:07.018]
> [INFO] Maven Settings Builder  SUCCESS [00:03.158]
> [INFO] Maven Repository Metadata Model ... SUCCESS [00:06.664]
> [INFO] Maven Aether Provider . SUCCESS [00:07.652]
> [INFO] Maven Core  SUCCESS [00:41.676]
> [INFO] Maven Compat .. SUCCESS [00:25.343]
> [INFO] Maven Embedder  SUCCESS [00:04.635]
> [INFO] Apache Maven Distribution . FAILURE [02:31.770]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 04:15.916 (Wall Clock)
> [INFO] Finished at: 2013-11-14 09:15:00
> [INFO] Final Memory: 46M/346M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project apache-maven: Error rendering velocity resource. Invocation of 
> method 'getResourceAsFile' in  class 
> org.codehaus.plexus.resource.DefaultResourceManager threw exception 
> org.codehaus.plexus.resource.loader.ResourceNotFoundException: Could not find 
> resource 'https://glassfish.java.net/public/CDDLv1.0.html'. at 
> remote-resources[line 40, column 26] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :apache-maven
> {noformat}
> Offline mode shall be passed to every plugin execution.
> In my case, I am behind a corporate firewall and did not configure it in my 
> {{settings.xml}} because we have a local Nexus instance for that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MRRESOURCES-94) Performance issue in ProcessRemoteResourcesMojo.configureVelocityContext(...)

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MRRESOURCES-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MRRESOURCES-94:
-
Fix Version/s: 1.6.0

> Performance issue in ProcessRemoteResourcesMojo.configureVelocityContext(...)
> -
>
> Key: MRRESOURCES-94
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-94
> Project: Maven Remote Resources Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
>Reporter: Falko Modler
>Priority: Major
> Fix For: 1.6.0
>
>
> I was wondering why our multi-threaded maven build of 80+ modules took so 
> long even when excluding tests. I checked every plugin execution and to my 
> surprise, {{maven-remote-resources-plugin}} was the number 1 consumer 
> *before* compiler-plugin etc.
> We use {{maven-remote-resources-plugin}} just to exchange some few xml files 
> among the modules, nothing spectacular!
> While debugging the plugin I found out that 
> {{ProcessRemoteResourcesMojo.configureVelocityContext(VelocityContext 
> context)}} may take *up to 30 seconds* for our project setup which is not 
> acceptable.
> Almost certainly the problem is caused by the following project lookups 
> (especially {{getProjects()}}):
> {noformat}
> List projects = getProjects();
> context.put( "projects", projects );
> context.put( "projectsSortedByOrganization", 
> getProjectsSortedByOrganization( projects ) );
> {noformat}
> As we do not use velocity templates at all, the solution for us was to patch 
> the plugin to call {{configureVelocityContext(...)}} only on demand, not 
> eagerly. Of course this won't help when using velocity templates...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MRRESOURCES-101) NPE - Error rendering velocity resource

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MRRESOURCES-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MRRESOURCES-101:
--
Fix Version/s: 1.6.0

> NPE - Error rendering velocity resource
> ---
>
> Key: MRRESOURCES-101
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-101
> Project: Maven Remote Resources Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
>Reporter: Daniel Klessing
>Priority: Major
> Fix For: 1.6.0
>
> Attachments: mrresources_npe.diff
>
>
> We noticed that occasionally the maven-remote-resources-plugin kills our 
> build as a NPE with the message "Error rendering velocity resource" happend.
> Luckily I succeeded today in getting a stacktrace of the issue:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project parent: Error rendering velocity resource. NullPointerException -> 
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process 
> (default) on project parent: Error rendering velocity resource.
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error rendering 
> velocity resource.
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1246)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute(ProcessRemoteResourcesMojo.java:520)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   ... 20 more
> Caused by: java.lang.NullPointerException
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1232)
>   ... 23 more
> [ERROR] 
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> Looking into the code I noticed that an "unguarded close()" in a 
> finally-block is the culprit. By replacing it with a call to 
> {{IOUtil.close()}} the problem is gone. See the attached patch/diff.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Moved] (MNG-6480) Eclipse.org site is down, and you are unable to build Maven?

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy moved MRRESOURCES-98 to MNG-6480:
---

Issue Type: Improvement  (was: Bug)
   Key: MNG-6480  (was: MRRESOURCES-98)
   Project: Maven  (was: Maven Remote Resources Plugin)

> Eclipse.org site is down, and you are unable to build Maven?
> 
>
> Key: MNG-6480
> URL: https://issues.apache.org/jira/browse/MNG-6480
> Project: Maven
>  Issue Type: Improvement
>Reporter: Cservenak, Tamas
>Priority: Major
> Fix For: 3.6.0-candidate
>
>
> Was trying to build Maven locally, just to see it is failing (actually, too 
> way long was stuck in console). Had no idea what is happening until I did 
> {{-X}}, to see it is {{maven-remote-resources-plugin}} (see below).
> I am quite surprised to see, that if {{eclipse.org}} site is down (as in this 
> moment), one cannot build Apache Maven, and I find it quite ironic.
> {noformat}
> [DEBUG] URLResourceLoader: Exception when looking for 
> 'http://www.eclipse.org/legal/epl-v10.html' at ''
> java.net.SocketException: Unexpected end of file from server
>   at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:792)
>   at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
>   at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:789)
>   at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
>   at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1536)
>   at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)
>   at java.net.URL.openStream(URL.java:1045)
>   at 
> org.codehaus.plexus.resource.loader.URLResourceLoader.getResource(URLResourceLoader.java:73)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getResource(DefaultResourceManager.java:159)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getResourceAsFile(DefaultResourceManager.java:91)
>   at sun.reflect.GeneratedMethodAccessor69.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
>   at 
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
>   at 
> org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
>   at 
> org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
>   at 
> org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:567)
>   at 
> org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:71)
>   at 
> org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:142)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
>   at 
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
>   at 
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
>   at 
> org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
>   at 
> org.apache.velocity.runtime.RuntimeInstance.render(RuntimeInstance.java:1378)
>   at 
> org.apache.velocity.runtime.RuntimeInstance.evaluate(RuntimeInstance.java:1314)
>   at org.apache.velocity.app.Velocity.evaluate(Velocity.java:254)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1218)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute(ProcessRemoteResourcesMojo.java:520)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> 

[jira] [Updated] (MNG-6480) Eclipse.org site is down, and you are unable to build Maven?

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6480:
---
Fix Version/s: 3.6.0-candidate

> Eclipse.org site is down, and you are unable to build Maven?
> 
>
> Key: MNG-6480
> URL: https://issues.apache.org/jira/browse/MNG-6480
> Project: Maven
>  Issue Type: Improvement
>Reporter: Cservenak, Tamas
>Priority: Major
> Fix For: 3.6.0-candidate
>
>
> Was trying to build Maven locally, just to see it is failing (actually, too 
> way long was stuck in console). Had no idea what is happening until I did 
> {{-X}}, to see it is {{maven-remote-resources-plugin}} (see below).
> I am quite surprised to see, that if {{eclipse.org}} site is down (as in this 
> moment), one cannot build Apache Maven, and I find it quite ironic.
> {noformat}
> [DEBUG] URLResourceLoader: Exception when looking for 
> 'http://www.eclipse.org/legal/epl-v10.html' at ''
> java.net.SocketException: Unexpected end of file from server
>   at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:792)
>   at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
>   at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:789)
>   at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
>   at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1536)
>   at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)
>   at java.net.URL.openStream(URL.java:1045)
>   at 
> org.codehaus.plexus.resource.loader.URLResourceLoader.getResource(URLResourceLoader.java:73)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getResource(DefaultResourceManager.java:159)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getResourceAsFile(DefaultResourceManager.java:91)
>   at sun.reflect.GeneratedMethodAccessor69.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
>   at 
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
>   at 
> org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
>   at 
> org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
>   at 
> org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:567)
>   at 
> org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:71)
>   at 
> org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:142)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
>   at 
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
>   at 
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
>   at 
> org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
>   at 
> org.apache.velocity.runtime.RuntimeInstance.render(RuntimeInstance.java:1378)
>   at 
> org.apache.velocity.runtime.RuntimeInstance.evaluate(RuntimeInstance.java:1314)
>   at org.apache.velocity.app.Velocity.evaluate(Velocity.java:254)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1218)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute(ProcessRemoteResourcesMojo.java:520)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> 

[jira] [Commented] (MRRESOURCES-98) Eclipse.org site is down, and you are unable to build Maven?

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MRRESOURCES-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616791#comment-16616791
 ] 

Hervé Boutemy commented on MRRESOURCES-98:
--

perhaps we should have the licenses in our source to avoid depending on 
external sites for stupid license download

> Eclipse.org site is down, and you are unable to build Maven?
> 
>
> Key: MRRESOURCES-98
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-98
> Project: Maven Remote Resources Plugin
>  Issue Type: Bug
>Reporter: Cservenak, Tamas
>Priority: Major
>
> Was trying to build Maven locally, just to see it is failing (actually, too 
> way long was stuck in console). Had no idea what is happening until I did 
> {{-X}}, to see it is {{maven-remote-resources-plugin}} (see below).
> I am quite surprised to see, that if {{eclipse.org}} site is down (as in this 
> moment), one cannot build Apache Maven, and I find it quite ironic.
> {noformat}
> [DEBUG] URLResourceLoader: Exception when looking for 
> 'http://www.eclipse.org/legal/epl-v10.html' at ''
> java.net.SocketException: Unexpected end of file from server
>   at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:792)
>   at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
>   at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:789)
>   at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647)
>   at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1536)
>   at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)
>   at java.net.URL.openStream(URL.java:1045)
>   at 
> org.codehaus.plexus.resource.loader.URLResourceLoader.getResource(URLResourceLoader.java:73)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getResource(DefaultResourceManager.java:159)
>   at 
> org.codehaus.plexus.resource.DefaultResourceManager.getResourceAsFile(DefaultResourceManager.java:91)
>   at sun.reflect.GeneratedMethodAccessor69.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
>   at 
> org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
>   at 
> org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
>   at 
> org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
>   at 
> org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:567)
>   at 
> org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:71)
>   at 
> org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:142)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
>   at 
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
>   at 
> org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
>   at 
> org.apache.velocity.runtime.directive.Foreach.render(Foreach.java:420)
>   at 
> org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
>   at 
> org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
>   at 
> org.apache.velocity.runtime.RuntimeInstance.render(RuntimeInstance.java:1378)
>   at 
> org.apache.velocity.runtime.RuntimeInstance.evaluate(RuntimeInstance.java:1314)
>   at org.apache.velocity.app.Velocity.evaluate(Velocity.java:254)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.processResourceBundles(ProcessRemoteResourcesMojo.java:1218)
>   at 
> org.apache.maven.plugin.resources.remote.ProcessRemoteResourcesMojo.execute(ProcessRemoteResourcesMojo.java:520)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> 

[jira] [Updated] (MRRESOURCES-85) Add m2e mapping

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MRRESOURCES-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MRRESOURCES-85:
-
Fix Version/s: 1.6.0

> Add m2e mapping
> ---
>
> Key: MRRESOURCES-85
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-85
> Project: Maven Remote Resources Plugin
>  Issue Type: Improvement
>Affects Versions: 1.6.0
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 1.6.0
>
>
> Add mapping for m2e for plugin something like this.
> {code:xml}
> 
> 
>   
> 
>   
> 
>   bundle
>   process
> 
>   
>   
> 
>   true
>   true
> 
>   
> 
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6358) Maven build should not require access to apache.org

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616788#comment-16616788
 ] 

Hudson commented on MNG-6358:
-

Build succeeded in Jenkins: Maven TLP » maven » master #77

See https://builds.apache.org/job/maven-box/job/maven/job/master/77/

> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Assignee: Hervé Boutemy
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I 
> am building on has access to an internal Maven repository, but doesn't have 
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to 
> download the license. But I don't understand why it needs to do this, as the 
> license is already contained in file {{apache-jar-resource-bundle}} which is 
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 16 licence.
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies 
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking 
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to 
> /tmp/maven-build/apache-maven/target/dependency with includes 
> "META-INF/native/**" and excludes ""
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven 
> ---
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact  SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings  SUCCESS [1.905s]
> [INFO] Maven Settings Builder  SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core  SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder  SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project apache-maven: Error rendering velocity resource. Invocation of 
> method 'getResourceAsFile' in  class 
> org.codehaus.plexus.resource.DefaultResourceManager threw exception 
> org.codehaus.plexus.resource.loader.ResourceNotFoundException: Could not find 
> resource 'https://www.apache.org/licenses/LICENSE-2.0.txt'. at 
> remote-resources[line 38, column 26] -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> 

[jira] [Comment Edited] (MNG-6358) Maven build should not require access to apache.org

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616780#comment-16616780
 ] 

Hervé Boutemy edited comment on MNG-6358 at 9/16/18 4:10 PM:
-

https://gitbox.apache.org/repos/asf?p=maven.git=commit=532eb24c3d2797eb628596f119cb76615a437811
currently working urls to download text version of licenses coded in 
https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=ed8bc6bc0e90f0c37b53a68fea3e6d7c61a8e243


was (Author: hboutemy):
https://gitbox.apache.org/repos/asf?p=maven.git=commit=532eb24c3d2797eb628596f119cb76615a437811
https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=ed8bc6bc0e90f0c37b53a68fea3e6d7c61a8e243

> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Assignee: Hervé Boutemy
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I 
> am building on has access to an internal Maven repository, but doesn't have 
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to 
> download the license. But I don't understand why it needs to do this, as the 
> license is already contained in file {{apache-jar-resource-bundle}} which is 
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 16 licence.
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies 
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking 
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to 
> /tmp/maven-build/apache-maven/target/dependency with includes 
> "META-INF/native/**" and excludes ""
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven 
> ---
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact  SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings  SUCCESS [1.905s]
> [INFO] Maven Settings Builder  SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core  SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder  SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project apache-maven: Error rendering velocity resource. Invocation of 
> method 'getResourceAsFile' in  class 
> org.codehaus.plexus.resource.DefaultResourceManager threw exception 
> org.codehaus.plexus.resource.loader.ResourceNotFoundException: Could not find 
> resource 

[jira] [Closed] (MNG-6358) Maven build should not require access to apache.org

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy closed MNG-6358.
--
Resolution: Fixed
  Assignee: Hervé Boutemy

https://gitbox.apache.org/repos/asf?p=maven.git=commit=532eb24c3d2797eb628596f119cb76615a437811
https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=ed8bc6bc0e90f0c37b53a68fea3e6d7c61a8e243

> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Assignee: Hervé Boutemy
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I 
> am building on has access to an internal Maven repository, but doesn't have 
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to 
> download the license. But I don't understand why it needs to do this, as the 
> license is already contained in file {{apache-jar-resource-bundle}} which is 
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 16 licence.
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies 
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking 
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to 
> /tmp/maven-build/apache-maven/target/dependency with includes 
> "META-INF/native/**" and excludes ""
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven 
> ---
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact  SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings  SUCCESS [1.905s]
> [INFO] Maven Settings Builder  SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core  SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder  SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project apache-maven: Error rendering velocity resource. Invocation of 
> method 'getResourceAsFile' in  class 
> org.codehaus.plexus.resource.DefaultResourceManager threw exception 
> org.codehaus.plexus.resource.loader.ResourceNotFoundException: Could not find 
> resource 'https://www.apache.org/licenses/LICENSE-2.0.txt'. at 
> remote-resources[line 38, column 26] -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and 

[jira] [Comment Edited] (MNG-5870) Effective pom should not inherit SCM

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14694297#comment-14694297
 ] 

Hervé Boutemy edited comment on MNG-5870 at 9/16/18 4:07 PM:
-

like written in MPIR-234, removing scm info from effective model is IMHO 
throwing baby with bath water: a module has a scm, even if it's inside a git 
repo for example then not immediately a git repo!
then I'm -1 for this idea of removing scm inheritance

instead, scm urls for any artifact should exist: extending Maven scm url 
formats to make sure that they take into account path inside repo would not be 
that complex (and would not require any change in Maven core): MPIR should use 
Maven SCM provider to parse the scm url and extract info


was (Author: hboutemy):
like written in MPIR-234, removing scm info from effective model is IMHO 
throwing baby with bath: a module has a scm, even if it's inside a git repo for 
example!
then I'm -1 for this idea of removing scm inheritance

instead, scm urls for any artifact should exist: extending Maven scm url 
formats to make sure that they take into account path inside repo would not be 
that complex (and would not require any change in Maven core): MPIR should use 
Maven SCM provider to parse the scm url and extract info

> Effective pom should not inherit SCM
> 
>
> Key: MNG-5870
> URL: https://issues.apache.org/jira/browse/MNG-5870
> Project: Maven
>  Issue Type: Improvement
>  Components: core, Inheritance and Interpolation, POM
>Reporter: Robert Scholte
>Priority: Major
>
> Up until Maven 3.3.7 if a pom didn't specify the scm section, it would be 
> inherited and extended with the artifactId *by default*. This mechanism could 
> work for a couple of SCMs like svn and cvs, but for most it doesn't.
> This kind of scm specific logic of extending the connection or URL doesn't 
> belong in Maven core. 
> Instead we should say that scm marks this project as a valid release root. 
> The source repository page (mpir) should ask a specific Scm class for 
> handling connections and urls in case of modules.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (MNG-5870) Effective pom should not inherit SCM

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14694297#comment-14694297
 ] 

Hervé Boutemy edited comment on MNG-5870 at 9/16/18 4:06 PM:
-

like written in MPIR-234, removing scm info from effective model is IMHO 
throwing baby with bath: a module has a scm, even if it's inside a git repo for 
example!
then I'm -1 for this idea of removing scm inheritance

instead, scm urls for any artifact should exist: extending Maven scm url 
formats to make sure that they take into account path inside repo would not be 
that complex (and would not require any change in Maven core): MPIR should use 
Maven SCM provider to parse the scm url and extract info


was (Author: hboutemy):
like written in MPIR-234, removing scm info from effective model is IMHO 
throwing baby with bath
while extending Maven scm urls to make sure that they take into account path 
inside repo would not be that complex (and would not require any change in 
Maven core): MPIR should use Maven SCM provider to parse the scm url and 
extract info

> Effective pom should not inherit SCM
> 
>
> Key: MNG-5870
> URL: https://issues.apache.org/jira/browse/MNG-5870
> Project: Maven
>  Issue Type: Improvement
>  Components: core, Inheritance and Interpolation, POM
>Reporter: Robert Scholte
>Priority: Major
>
> Up until Maven 3.3.7 if a pom didn't specify the scm section, it would be 
> inherited and extended with the artifactId *by default*. This mechanism could 
> work for a couple of SCMs like svn and cvs, but for most it doesn't.
> This kind of scm specific logic of extending the connection or URL doesn't 
> belong in Maven core. 
> Instead we should say that scm marks this project as a valid release root. 
> The source repository page (mpir) should ask a specific Scm class for 
> handling connections and urls in case of modules.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MNG-4508) No way to avoid adding artifactId to site urls

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy closed MNG-4508.
--
   Resolution: Fixed
Fix Version/s: (was: 3.6.x-candidate)
   3.6.0

> No way to avoid adding artifactId to site urls
> --
>
> Key: MNG-4508
> URL: https://issues.apache.org/jira/browse/MNG-4508
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Reporter: Richard van der Hoff
>Assignee: Hervé Boutemy
>Priority: Minor
> Fix For: 3.6.0
>
>
> Currently, whenever a child pom inherits from a parent (and doesn't override 
> the relevant settings), both project.url and 
> project.distributionManagement.site.url have the name of the child artifact 
> appended.
> It would be nice to be able to have something like
> {code:xml}
> scpexe://host/blah/${project.artifactId}/${project.version}
> {code}
> and have this inherited to all child poms in the obvious way.
> My usecase for this is that we have a single parent pom for all our projects, 
> with useful settings such as distributionManagement, and I'd like to be able 
> to deploy their sites to a single directory and have Apache generate me a 
> directory listing for all the child projects. However, I curently have no way 
> of releasing the parent project without obliterating the list of child 
> projects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MNG-6059) Important use cases not covered, as child.inherit.append.path affects all children

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy closed MNG-6059.
--
   Resolution: Fixed
Fix Version/s: (was: 3.6.x-candidate)
   3.6.0

> Important use cases not covered, as child.inherit.append.path affects all 
> children
> --
>
> Key: MNG-6059
> URL: https://issues.apache.org/jira/browse/MNG-6059
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
> Environment: Apache Maven 3.4.0-SNAPSHOT 
> (227085283b6379038ec16f4cf9ad2e8869cef694; 2016-07-06T21:29:12+02:00)
>Reporter: Andreas Sewe
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.0
>
>
> The {{child.inherit.append.path}} attribute introduced with MNG-5951 
> unfortunately does not support the use case where the children of the element 
> with the attribute should follow different inheritance rules. Take a typical 
> configuration for Github, for example (taken from 
> ):
> {noformat}
> 
>   
> scm:git:git://github.com/simpligility/ossrh-demo.git
>   
> scm:git:ssh://github.com:simpligility/ossrh-demo.git
>   http://github.com/simpligility/ossrh-demo/tree/master
> 
> {noformat}
> If the {{ossrh-demo.git}} repository contains a child module called 
> {{some-module}}, then that child’s {{scm/url}} should become 
> {{http://github.com/simpligility/ossrh-demo/tree/master/some-module}} as per 
> the normal inheritance rules, but both the {{scm/connection}} and 
> {{scm/developerConnection}} URLs should remain unchanged.
> Unfortunately, this is not possible with {{*child*.inherit.append.path}}, 
> which acts on all children simultaneously.
> IMHO, this is a conceptual problem. In particular, setting 
> {{child.inherit.append.path}} on the *root* element to just control a single 
> child ({{project/url}}) feels wrong, as the attribute is in all likelihood 
> not even located close to the {{}} element it controls.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MNG-5951) add an option to avoid path addition to inherited URLs

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy closed MNG-5951.
--
   Resolution: Fixed
Fix Version/s: (was: 3.6.x-candidate)
   3.6.0

fixed by 
https://gitbox.apache.org/repos/asf?p=maven.git=commit=2e8e09f25be5a99184f23e7a15833c69ff039547

> add an option to avoid path addition to inherited URLs
> --
>
> Key: MNG-5951
> URL: https://issues.apache.org/jira/browse/MNG-5951
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Affects Versions: 3.0.5, 3.1.1, 3.2.5, 3.3.9
>Reporter: Jörg Sesterhenn
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: MNG-5951.zip
>
>
> What I am trying to achieve is 
> the definition of a project.url in a parent pom 
> in a way that all children inherit a url ending with 
> {code}
> ${project.groupId}/${project.artifactId}/${project.version}/ 
> {code}
> in order to be able to publish sites of all artifacts in all versions in 
> parallel
> without having to redefine the url in every child pom.
> This is currently not working as expected in maven due to the default child 
> urls calculation which leads to urls that add up parent urls like 
> http://my.domain.de/sites/de.enterprise.calculatorsGroupId/calculator-artifactID/1.0.0-SNAPSHOT/internetAppParentPOM/calculatorParentPom/calculator-artifactID/
> The part *"internetAppParentPOM/calculatorParentPom/"* is added by automatic 
> child url calculation (those are the artifactIds of all parent poms beneath 
> our enterprise parent pom where the url is defined) and *is expexted to not 
> be there at all*. The repeated artifactID at the end of the url is 
> superfluous as well but tollerable.
> I expect maven-core to be changed so that I can turn on/off the automatic 
> calculation of child URLs as an option which is by default on (current 
> behaviour so nothing will change unless configured explicitly).
> See the discussion in MSITE-672. 
> As this can not be done in the maven-site-plugin there needs to be a change 
> in Maven itself (core), in Maven Model Builder, ie the way effective model is 
> calculated, and more precisely in the inheritance step: 
> http://maven.apache.org/ref/current/maven-model-builder/.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6358) Maven build should not require access to apache.org

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616776#comment-16616776
 ] 

Hudson commented on MNG-6358:
-

Build succeeded in Jenkins: Maven TLP » maven » master #76

See https://builds.apache.org/job/maven-box/job/maven/job/master/76/

> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I 
> am building on has access to an internal Maven repository, but doesn't have 
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to 
> download the license. But I don't understand why it needs to do this, as the 
> license is already contained in file {{apache-jar-resource-bundle}} which is 
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 16 licence.
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies 
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking 
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to 
> /tmp/maven-build/apache-maven/target/dependency with includes 
> "META-INF/native/**" and excludes ""
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven 
> ---
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact  SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings  SUCCESS [1.905s]
> [INFO] Maven Settings Builder  SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core  SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder  SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project apache-maven: Error rendering velocity resource. Invocation of 
> method 'getResourceAsFile' in  class 
> org.codehaus.plexus.resource.DefaultResourceManager threw exception 
> org.codehaus.plexus.resource.loader.ResourceNotFoundException: Could not find 
> resource 'https://www.apache.org/licenses/LICENSE-2.0.txt'. at 
> remote-resources[line 38, column 26] -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> 

[jira] [Comment Edited] (MNG-6358) Maven build should not require access to apache.org

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616753#comment-16616753
 ] 

Hervé Boutemy edited comment on MNG-6358 at 9/16/18 3:29 PM:
-

MNG-6414 already fixed a good number of cases (including Maven core artifacts 
themselves...): thank you Sylwester
now, the list of {{lib/*.license}} files is a lot less, but what remains is a 
big mess:
- 301 "moved permanently"
- Eclipse license as html
- empty file...

looks like we should make the download algorithm more strict, or add a quality 
test to detect when things go bad...


was (Author: hboutemy):
MNG-6414 already fixed a good number of cases (including Maven core artifacts 
themselves...): thank you Sylwester
now, the list of {{lib/*.license}} files is a lot less, but what remains is a 
big mess:
- 301 "moved permanently"
- Apache License as html
- Eclipse license as html
- empty file...

looks like we should make the download algorithm more strict, or add a quality 
test to detect when things go bad...

> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I 
> am building on has access to an internal Maven repository, but doesn't have 
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to 
> download the license. But I don't understand why it needs to do this, as the 
> license is already contained in file {{apache-jar-resource-bundle}} which is 
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 16 licence.
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies 
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking 
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to 
> /tmp/maven-build/apache-maven/target/dependency with includes 
> "META-INF/native/**" and excludes ""
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven 
> ---
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact  SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings  SUCCESS [1.905s]
> [INFO] Maven Settings Builder  SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core  SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder  SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> 

[jira] [Updated] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6414:
---
Description: 
While preparing Maven distribution, maven-remote-resources-plugin uses 
{{appended-resources/META-INF/LICENSE.vm}} to add content to {{LICENSE}} and 
try to download licenses for all dependencies that are not Apache licensed (see 
end of {{LICENSE}} and resulting {{lib/*.license}} in Maven binary 
distribution, since Maven 3.2.1 MNG-5494).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/ (causing 
some issues with https: MNG-6358). 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0"

 

  was:
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed (see 
resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
MNG-5494).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/ (causing 
some issues with https: MNG-6358). 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0"

 


> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin uses 
> {{appended-resources/META-INF/LICENSE.vm}} to add content to {{LICENSE}} and 
> try to download licenses for all dependencies that are not Apache licensed 
> (see end of {{LICENSE}} and resulting {{lib/*.license}} in Maven binary 
> distribution, since Maven 3.2.1 MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-5951) add an option to avoid path addition to inherited URLs

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616767#comment-16616767
 ] 

Hudson commented on MNG-5951:
-

Build succeeded in Jenkins: Maven TLP » maven » master #75

See https://builds.apache.org/job/maven-box/job/maven/job/master/75/

> add an option to avoid path addition to inherited URLs
> --
>
> Key: MNG-5951
> URL: https://issues.apache.org/jira/browse/MNG-5951
> Project: Maven
>  Issue Type: Improvement
>  Components: Inheritance and Interpolation
>Affects Versions: 3.0.5, 3.1.1, 3.2.5, 3.3.9
>Reporter: Jörg Sesterhenn
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.x-candidate
>
> Attachments: MNG-5951.zip
>
>
> What I am trying to achieve is 
> the definition of a project.url in a parent pom 
> in a way that all children inherit a url ending with 
> {code}
> ${project.groupId}/${project.artifactId}/${project.version}/ 
> {code}
> in order to be able to publish sites of all artifacts in all versions in 
> parallel
> without having to redefine the url in every child pom.
> This is currently not working as expected in maven due to the default child 
> urls calculation which leads to urls that add up parent urls like 
> http://my.domain.de/sites/de.enterprise.calculatorsGroupId/calculator-artifactID/1.0.0-SNAPSHOT/internetAppParentPOM/calculatorParentPom/calculator-artifactID/
> The part *"internetAppParentPOM/calculatorParentPom/"* is added by automatic 
> child url calculation (those are the artifactIds of all parent poms beneath 
> our enterprise parent pom where the url is defined) and *is expexted to not 
> be there at all*. The repeated artifactID at the end of the url is 
> superfluous as well but tollerable.
> I expect maven-core to be changed so that I can turn on/off the automatic 
> calculation of child URLs as an option which is by default on (current 
> behaviour so nothing will change unless configured explicitly).
> See the discussion in MSITE-672. 
> As this can not be done in the maven-site-plugin there needs to be a change 
> in Maven itself (core), in Maven Model Builder, ie the way effective model is 
> calculated, and more precisely in the inheritance step: 
> http://maven.apache.org/ref/current/maven-model-builder/.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-5494) Add a license file that corresponds to each GAV in the distribution

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616760#comment-16616760
 ] 

Hervé Boutemy commented on MNG-5494:


https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b4dc8931f2cc7b56302df78c03a7db57211cd3a7
https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=380dc43a7abb6878962e4c133bd9c02e4330dd23

> Add a license file that corresponds to each GAV in the distribution
> ---
>
> Key: MNG-5494
> URL: https://issues.apache.org/jira/browse/MNG-5494
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Jason van Zyl
>Assignee: Jason van Zyl
>Priority: Major
> Fix For: 3.2.1
>
>
> Right now we are not collecting the licenses for each binary artifact in the 
> distribution. We tentatively decided that we will create a license file per 
> artifact and include that in the distribution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (MNG-6358) Maven build should not require access to apache.org

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616753#comment-16616753
 ] 

Hervé Boutemy edited comment on MNG-6358 at 9/16/18 2:40 PM:
-

MNG-6414 already fixed a good number of cases (including Maven core artifacts 
themselves...): thank you Sylwester
now, the list of {{lib/*.license}} files is a lot less, but what remains is a 
big mess:
- 301 "moved permanently"
- Apache License as html
- Eclipse license as html
- empty file...

looks like we should make the download algorithm more strict, or add a quality 
test to detect when things go bad...


was (Author: hboutemy):
MNG-6414 already fixed a good number of cases (including Maven core artifacts 
themselves...): thank you Sylwester
now, the list of {{lib/*.license}} files is a lot less, but what remains is a 
big mess:
- 301 "moved permanently"
- Apache License as html
- Eclipse license as html

looks like we should make the download algorithm more strict, or add a quality 
test to detect when things go bad...

> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I 
> am building on has access to an internal Maven repository, but doesn't have 
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to 
> download the license. But I don't understand why it needs to do this, as the 
> license is already contained in file {{apache-jar-resource-bundle}} which is 
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 16 licence.
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies 
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking 
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to 
> /tmp/maven-build/apache-maven/target/dependency with includes 
> "META-INF/native/**" and excludes ""
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven 
> ---
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact  SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings  SUCCESS [1.905s]
> [INFO] Maven Settings Builder  SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core  SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder  SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> 

[jira] [Commented] (MNG-6358) Maven build should not require access to apache.org

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616753#comment-16616753
 ] 

Hervé Boutemy commented on MNG-6358:


MNG-6414 already fixed a good number of cases (including Maven core artifacts 
themselves...)
now, the list of {{lib/*.license}} files is a lot less, but what remains is a 
big mess:
- 301 "moved permanently"
- Apache License as html
- Eclipse license as html

looks like we should make the download algorithm more strict, or add a quality 
test to detect when things go bad...

> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I 
> am building on has access to an internal Maven repository, but doesn't have 
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to 
> download the license. But I don't understand why it needs to do this, as the 
> license is already contained in file {{apache-jar-resource-bundle}} which is 
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 16 licence.
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies 
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking 
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to 
> /tmp/maven-build/apache-maven/target/dependency with includes 
> "META-INF/native/**" and excludes ""
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven 
> ---
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact  SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings  SUCCESS [1.905s]
> [INFO] Maven Settings Builder  SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core  SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder  SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project apache-maven: Error rendering velocity resource. Invocation of 
> method 'getResourceAsFile' in  class 
> org.codehaus.plexus.resource.DefaultResourceManager threw exception 
> org.codehaus.plexus.resource.loader.ResourceNotFoundException: Could not find 
> resource 'https://www.apache.org/licenses/LICENSE-2.0.txt'. at 
> remote-resources[line 38, column 26] -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.

[jira] [Comment Edited] (MNG-6358) Maven build should not require access to apache.org

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616753#comment-16616753
 ] 

Hervé Boutemy edited comment on MNG-6358 at 9/16/18 2:38 PM:
-

MNG-6414 already fixed a good number of cases (including Maven core artifacts 
themselves...): thank you Sylwester
now, the list of {{lib/*.license}} files is a lot less, but what remains is a 
big mess:
- 301 "moved permanently"
- Apache License as html
- Eclipse license as html

looks like we should make the download algorithm more strict, or add a quality 
test to detect when things go bad...


was (Author: hboutemy):
MNG-6414 already fixed a good number of cases (including Maven core artifacts 
themselves...)
now, the list of {{lib/*.license}} files is a lot less, but what remains is a 
big mess:
- 301 "moved permanently"
- Apache License as html
- Eclipse license as html

looks like we should make the download algorithm more strict, or add a quality 
test to detect when things go bad...

> Maven build should not require access to apache.org
> ---
>
> Key: MNG-6358
> URL: https://issues.apache.org/jira/browse/MNG-6358
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.2.1, 3.5.2
> Environment: RHEL 7.4
> JDK 1.8.0_141
>Reporter: Adam John Burley
>Priority: Minor
> Fix For: 3.6.0
>
>
> I am trying to build Maven 3.5.2 from source using Maven 3.0.5. The machine I 
> am building on has access to an internal Maven repository, but doesn't have 
> access to the Internet.
> The build fails, seemingly because it cannot access {{apache.org}} to 
> download the license. But I don't understand why it needs to do this, as the 
> license is already contained in file {{apache-jar-resource-bundle}} which is 
> retrieved as a Maven dependency.
> Here is the log I get:
> {code}
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ apache-maven ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/test/resources*/**
> [INFO] Exclude: src/test/projects/**
> [INFO] Exclude: src/test/remote-repo/**
> [INFO] Exclude: **/*.odg
> [INFO] Exclude: src/bin/m2.conf
> [INFO] Exclude: bootstrap/**
> [INFO] Exclude: README.bootstrap.txt
> [INFO] Exclude: .repository/**
> [INFO] Exclude: .maven/spy.log
> [INFO] Exclude: .java-version
> [INFO] Exclude: README.md
> [INFO] Exclude: DEPENDENCIES
> [INFO] 19 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 16 licence.
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:unpack-dependencies 
> (unpack-jansi-native) @ apache-maven ---
> [INFO] Unpacking 
> /root/.m2/repository/org/fusesource/jansi/jansi/1.16/jansi-1.16.jar to 
> /tmp/maven-build/apache-maven/target/dependency with includes 
> "META-INF/native/**" and excludes ""
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ apache-maven 
> ---
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Maven .. SUCCESS [25.091s]
> [INFO] Maven Model ... SUCCESS [18.000s]
> [INFO] Maven Artifact  SUCCESS [4.418s]
> [INFO] Maven Plugin API .. SUCCESS [4.677s]
> [INFO] Maven Builder Support . SUCCESS [1.900s]
> [INFO] Maven Model Builder ... SUCCESS [5.690s]
> [INFO] Maven Settings  SUCCESS [1.905s]
> [INFO] Maven Settings Builder  SUCCESS [2.010s]
> [INFO] Maven Repository Metadata Model ... SUCCESS [1.511s]
> [INFO] Maven Artifact Resolver Provider .. SUCCESS [5.110s]
> [INFO] Maven Core  SUCCESS [13.168s]
> [INFO] Maven SLF4J Simple Provider ... SUCCESS [5.013s]
> [INFO] Maven Embedder  SUCCESS [3.617s]
> [INFO] Maven Compat .. SUCCESS [4.462s]
> [INFO] Apache Maven Distribution . FAILURE [4:18.467s]
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 5:58.134s
> [INFO] Finished at: Mon Feb 12 21:03:11 GMT 2018
> [INFO] Final Memory: 83M/190M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) 
> on project 

[jira] [Commented] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616750#comment-16616750
 ] 

Hudson commented on MNG-6414:
-

Build succeeded in Jenkins: Maven TLP » maven » master #74

See https://builds.apache.org/job/maven-box/job/maven/job/master/74/

> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616749#comment-16616749
 ] 

Hervé Boutemy commented on MNG-6414:


https://gitbox.apache.org/repos/asf?p=maven.git=commit=ce6cc5d0088a222f23e33340a88ab2d818d3cde1

> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6479) Upgrade XMLUnit to 2.2.1

2018-09-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616748#comment-16616748
 ] 

ASF GitHub Bot commented on MNG-6479:
-

slachiewicz opened a new pull request #183: [MNG-6479] Upgrade XMLUnit to 2.2.1
URL: https://github.com/apache/maven/pull/183
 
 
   Small change only for maven-model-builder but lib later can be used by other 
modules
   
   https://github.com/xmlunit/user-guide/wiki/DiffBuilder


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade XMLUnit to 2.2.1
> 
>
> Key: MNG-6479
> URL: https://issues.apache.org/jira/browse/MNG-6479
> Project: Maven
>  Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Priority: Trivial
> Fix For: 3.6.0-candidate
>
>
> Upgrade XMLUnit test dependency from 1.x line to 2.2.1 and correct test cases
> _XMLUnit 2.x will never try to compare unmatched nodes with arbitrary other 
> nodes_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] slachiewicz opened a new pull request #183: [MNG-6479] Upgrade XMLUnit to 2.2.1

2018-09-16 Thread GitBox
slachiewicz opened a new pull request #183: [MNG-6479] Upgrade XMLUnit to 2.2.1
URL: https://github.com/apache/maven/pull/183
 
 
   Small change only for maven-model-builder but lib later can be used by other 
modules
   
   https://github.com/xmlunit/user-guide/wiki/DiffBuilder


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MNG-6479) Upgrade XMLUnit to 2.2.1

2018-09-16 Thread Sylwester Lachiewicz (JIRA)
Sylwester Lachiewicz created MNG-6479:
-

 Summary: Upgrade XMLUnit to 2.2.1
 Key: MNG-6479
 URL: https://issues.apache.org/jira/browse/MNG-6479
 Project: Maven
  Issue Type: Dependency upgrade
Reporter: Sylwester Lachiewicz
 Fix For: 3.6.0-candidate


Upgrade XMLUnit test dependency from 1.x line to 2.2.1 and correct test cases

_XMLUnit 2.x will never try to compare unmatched nodes with arbitrary other 
nodes_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread Sylwester Lachiewicz (JIRA)


 [ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz resolved MNG-6414.
---
Resolution: Fixed

> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616735#comment-16616735
 ] 

ASF GitHub Bot commented on MNG-6414:
-

asfgit closed pull request #167: MNG-6414 Add more Apache license headers to 
skip downloading license …
URL: https://github.com/apache/maven/pull/167
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm 
b/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
index 390fa42530..9b2f74f761 100644
--- a/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
+++ b/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
@@ -21,11 +21,11 @@ Apache Maven includes a number of components and libraries 
with separate
 copyright notices and license terms. Your use of those components are 
 subject to the terms and conditions of the following licenses. 
 
-#set ( $apacheTxt = "The Apache Software License, Version 2.0" )
-
+#set ( $apacheLicTexts = [ "Apache License, Version 2.0", "The Apache Software 
License, Version 2.0",
+"ASLv2", "Apache Public License 2.0", "Apache 2.0" ] )
 #foreach ( $project in $projects )
 #foreach ( $license in $project.licenses)
-#if ( ! ($apacheTxt == $license.name) ) 
+#if ( ! ($apacheLicTexts.contains( $license.name) ) )
 #set ( $artId = $project.artifact.artifactId)
 #set ( $lf = $locator )
 #set ( $url = $license.url )
@@ -33,7 +33,7 @@ subject to the terms and conditions of the following licenses.
 #if ($url == "https://glassfish.dev.java.net/public/CDDLv1.0.html;)
 #set ( $url = 'https://glassfish.java.net/public/CDDLv1.0.html' )
 #end
-#if ($url) 
+#if ($url)
 #set ( $licFile = 'lib/' + $artId + '.license' )
 #set ( $downloaded = $lf.getResourceAsFile($url, "licenses/${licFile}") )
 #end


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit closed pull request #167: MNG-6414 Add more Apache license headers to skip downloading license …

2018-09-16 Thread GitBox
asfgit closed pull request #167: MNG-6414 Add more Apache license headers to 
skip downloading license …
URL: https://github.com/apache/maven/pull/167
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm 
b/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
index 390fa42530..9b2f74f761 100644
--- a/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
+++ b/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
@@ -21,11 +21,11 @@ Apache Maven includes a number of components and libraries 
with separate
 copyright notices and license terms. Your use of those components are 
 subject to the terms and conditions of the following licenses. 
 
-#set ( $apacheTxt = "The Apache Software License, Version 2.0" )
-
+#set ( $apacheLicTexts = [ "Apache License, Version 2.0", "The Apache Software 
License, Version 2.0",
+"ASLv2", "Apache Public License 2.0", "Apache 2.0" ] )
 #foreach ( $project in $projects )
 #foreach ( $license in $project.licenses)
-#if ( ! ($apacheTxt == $license.name) ) 
+#if ( ! ($apacheLicTexts.contains( $license.name) ) )
 #set ( $artId = $project.artifact.artifactId)
 #set ( $lf = $locator )
 #set ( $url = $license.url )
@@ -33,7 +33,7 @@ subject to the terms and conditions of the following licenses.
 #if ($url == "https://glassfish.dev.java.net/public/CDDLv1.0.html;)
 #set ( $url = 'https://glassfish.java.net/public/CDDLv1.0.html' )
 #end
-#if ($url) 
+#if ($url)
 #set ( $licFile = 'lib/' + $artId + '.license' )
 #set ( $downloaded = $lf.getResourceAsFile($url, "licenses/${licFile}") )
 #end


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616726#comment-16616726
 ] 

Hudson commented on MNG-6414:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6414-apache-license #2

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6414-apache-license/2/

> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6478) Upgrade parent to 33 for sha512 checksum on release

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616725#comment-16616725
 ] 

Hudson commented on MNG-6478:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6414-apache-license #2

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6414-apache-license/2/

> Upgrade parent to 33 for sha512 checksum on release
> ---
>
> Key: MNG-6478
> URL: https://issues.apache.org/jira/browse/MNG-6478
> Project: Maven
>  Issue Type: Dependency upgrade
>Affects Versions: 3.6.0
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.0
>
>
> benefit from MPOM-205 and customize for Maven core (which does not have 
> classical release files)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6311) Maven intolerably slow when import scope used heavily in large project

2018-09-16 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616724#comment-16616724
 ] 

Hudson commented on MNG-6311:
-

Build succeeded in Jenkins: Maven TLP » maven » MNG-6414-apache-license #2

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6414-apache-license/2/

> Maven intolerably slow when import scope used heavily in large project
> --
>
> Key: MNG-6311
> URL: https://issues.apache.org/jira/browse/MNG-6311
> Project: Maven
>  Issue Type: Bug
>  Components: core, Performance
>Affects Versions: 3.5.0, 3.5.2
>Reporter: David Churcher
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: performance
> Fix For: 3.6.0
>
> Attachments: Call-tree-–-All-threads-together.html, 
> anon-hierarchy-maven-output.zip, modelcachefix.diff
>
>
> I have a build performance problem that is identical to MNG-5312, and has 
> appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, 
> removing the ModelCache from some of the overloads for 
> DefaultProjectBuilder.build. 
> As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 
> levels of parent POMs, many of which use the import scope and have large 
> dependency-management sections, and has hundreds of dependencies that also 
> use the same parent POM hierarchy. Adding some logging shows that Maven does 
> over 800,000 uncached reads of parent POM files, which takes about half an 
> hour. With model caching this goes down to a few seconds.
> I've attached a patch that fixes this by using a class-level ModelCache in 
> DefaultProjectBuilder. This does not suffer from the memory usage problems 
> reported in MNG-6030.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread Sylwester Lachiewicz (JIRA)


[ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616717#comment-16616717
 ] 

Sylwester Lachiewicz commented on MNG-6414:
---

Good idea, we can try to find the solution while working on MNG-6358.  Now a 
manual check in the distribution lib folder and in the LICENSE file.

And thanks to that notice, I discovered a few leaked artifacts with Guava.

 

> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MRRESOURCES-110) Upgrade parent to version 33

2018-09-16 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MRRESOURCES-110:
---

 Summary: Upgrade parent to version 33
 Key: MRRESOURCES-110
 URL: https://issues.apache.org/jira/browse/MRRESOURCES-110
 Project: Maven Remote Resources Plugin
  Issue Type: Dependency upgrade
Affects Versions: 1.6.0
Reporter: Karl Heinz Marbaise
 Fix For: 1.6.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRRESOURCES-91) Avoid overwrite of the destination file if the produced contents is the same

2018-09-16 Thread Karl Heinz Marbaise (JIRA)


[ 
https://issues.apache.org/jira/browse/MRRESOURCES-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616686#comment-16616686
 ] 

Karl Heinz Marbaise commented on MRRESOURCES-91:


Please do not comment on closed JIRA issues...If you like to discuss etc. 
please do it on the mailing (Dev in this case)

> Avoid overwrite of the destination file if the produced contents is the same
> 
>
> Key: MRRESOURCES-91
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-91
> Project: Maven Remote Resources Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
>Reporter: Vladimir Sitnikov
>Assignee: Kristian Rosenvold
>Priority: Major
> Fix For: 1.6.0
>
>
> maven-remote-resource-plugin is used in Apache pom to add DEPENDENCIES, and 
> the resulting file is overwritten on each build.
> It leads to jar being rebuild, etc leading to longer compilation times.
> I suggest to compare the produced contents with the existing file.
> If both are equal, skip the file being overwritten.
> The net win is subsequent build times are improved.
> Here's pull request that fixes the problem: 
> https://github.com/apache/maven-plugins/pull/40



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRRESOURCES-91) Avoid overwrite of the destination file if the produced contents is the same

2018-09-16 Thread Vladimir Sitnikov (JIRA)


[ 
https://issues.apache.org/jira/browse/MRRESOURCES-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1661#comment-1661
 ] 

Vladimir Sitnikov commented on MRRESOURCES-91:
--

[~krosenvold], would you please release maven-remote-resources-plugin 1.6?
It has been a while since the patch was merged.

> Avoid overwrite of the destination file if the produced contents is the same
> 
>
> Key: MRRESOURCES-91
> URL: https://issues.apache.org/jira/browse/MRRESOURCES-91
> Project: Maven Remote Resources Plugin
>  Issue Type: Bug
>Affects Versions: 1.5
>Reporter: Vladimir Sitnikov
>Assignee: Kristian Rosenvold
>Priority: Major
> Fix For: 1.6.0
>
>
> maven-remote-resource-plugin is used in Apache pom to add DEPENDENCIES, and 
> the resulting file is overwritten on each build.
> It leads to jar being rebuild, etc leading to longer compilation times.
> I suggest to compare the produced contents with the existing file.
> If both are equal, skip the file being overwritten.
> The net win is subsequent build times are improved.
> Here's pull request that fixes the problem: 
> https://github.com/apache/maven-plugins/pull/40



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] based2 closed pull request #194: MIME type for javascript is now officially application/javascript

2018-09-16 Thread GitBox
based2 closed pull request #194: MIME type for javascript is now officially 
application/javascript
URL: https://github.com/apache/maven-surefire/pull/194
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
 
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
index f9b948091..33196a600 100644
--- 
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
+++ 
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
@@ -78,9 +78,9 @@ public void doGenerateReport( LocalizedProperties bundle, 
Sink sink )
 sink.body();
 
 SinkEventAttributeSet atts = new SinkEventAttributeSet();
-atts.addAttribute( TYPE, "text/javascript" );
+atts.addAttribute( TYPE, "application/javascript" );
 sink.unknown( "script", new Object[]{ HtmlMarkup.TAG_TYPE_START }, 
atts );
-sink.unknown( "cdata", new Object[]{ HtmlMarkup.CDATA_TYPE, 
javascriptToggleDisplayCode() }, null );
+sink.unknown( "pcdata", new Object[]{ HtmlMarkup.PCDATA_TYPE, 
javascriptToggleDisplayCode() }, null );
 sink.unknown( "script", new Object[]{ HtmlMarkup.TAG_TYPE_END }, null 
);
 
 sink.section1();
@@ -745,8 +745,8 @@ private static void sinkLink_( Sink sink )
 private static String javascriptToggleDisplayCode()
 {
 
-// the javascript code is emitted within a commented CDATA section
-// so we have to start with a newline and comment the CDATA closing in 
the end
+// the javascript code is emitted within a commented PCDATA section
+// so we have to start with a newline and comment the PCDATA closing 
in the end
 
 return "\n" + "function toggleDisplay(elementId) {\n"
 + " var elm = document.getElementById(elementId + '-error');\n"


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] based2 opened a new pull request #194: MIME type for javascript is now officially application/javascript

2018-09-16 Thread GitBox
based2 opened a new pull request #194: MIME type for javascript is now 
officially application/javascript
URL: https://github.com/apache/maven-surefire/pull/194
 
 
mime js from text/javascript to application/javascript
   
   
https://stackoverflow.com/questions/189850/what-is-the-javascript-mime-type-for-the-type-attribute-of-a-script-tag
   
   "This is a common mistake. The MIME type for javascript wasn't standardized 
for years. It's now officially: "application/javascript"."
   http://www.rfc-editor.org/rfc/rfc4329.txt
   https://github.com/apache/maven-surefire/pull/188
   
   
ain/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
   @@ -78,7 +78,7 @@ public void doGenerateReport( LocalizedProperties bundle, 
Sink sink )
   atts.addAttribute( TYPE, "text/javascript" );
   atts.addAttribute( TYPE, "application/javascript" );
   
Please run the build locally. You will see this error

testWithIdenticalNames(org.apache.maven.surefire.its.jiras.Surefire260TestWithIdenticalNamesIT):
ReferenceError: "toggleDisplay" is not defined. (javascript url#184)
I am not sure if this is the only one.
Feel free to run the build like this mvn install -P run-its. See the 
README. There are instructions to use JDK8+.
Do not worry if it takes one hour to complete.
One hint, do not overload the PC with other tasks. The build has 
performance tests and if the delays are paused by overloaded CPU, other tests 
fail.
Squash all changes in one commit.
   
   >
https://www.w3schools.com/tags/tag_script.asp
Differences Between HTML and XHTML
   
In XHTML, the content inside scripts is declared as #PCDATA (instead of 
CDATA), which means that entities will be parsed.
   
This means that in XHTML, all special characters should be encoded, or all 
content should be wrapped inside a CDATA section
   
   
https://maven.apache.org/surefire/maven-surefire-report-plugin/surefire-report.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SUREFIRE-1532) MIME type for javascript is now officially application/javascript

2018-09-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616647#comment-16616647
 ] 

ASF GitHub Bot commented on SUREFIRE-1532:
--

based2 commented on issue #188: [SUREFIRE-1532]  MIME type for javascript is 
now officially application/javascript
URL: https://github.com/apache/maven-surefire/pull/188#issuecomment-421734451
 
 
   
https://github.com/based2/maven-surefire/commit/cc3afdb07148a22eabab02493173781a22897b2b


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> MIME type for javascript is now officially application/javascript
> -
>
> Key: SUREFIRE-1532
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1532
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.22.0
>Reporter: Basile Chandesris
>Priority: Minor
>  Labels: easyfix
>
>  
> ref [http://www.rfc-editor.org/rfc/rfc4329.txt 
> |http://www.rfc-editor.org/rfc/rfc4329.txt]Scripting Media Types
> src 
> [https://stackoverflow.com/questions/189850/what-is-the-javascript-mime-type-for-the-type-attribute-of-a-script-tag]
> "This is a common mistake. The MIME type for javascript wasn't standardized 
> for years. It's now officially: "application/javascript"."
> github 
> https://github.com/apache/maven-surefire/pull/188#issuecomment-401559853
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] based2 commented on issue #188: [SUREFIRE-1532] MIME type for javascript is now officially application/javascript

2018-09-16 Thread GitBox
based2 commented on issue #188: [SUREFIRE-1532]  MIME type for javascript is 
now officially application/javascript
URL: https://github.com/apache/maven-surefire/pull/188#issuecomment-421734451
 
 
   
https://github.com/based2/maven-surefire/commit/cc3afdb07148a22eabab02493173781a22897b2b


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616625#comment-16616625
 ] 

Hervé Boutemy commented on MNG-6414:


notice: I don't know if we can display a warning when a value is found that is 
not ideal, like "Apache Public License 2.0"
Being tolerant in our build is good, but telling about issues that original 
libraries should fix would be good also: not a blocker, just an improvement 
idea if feasible

> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6414:
---
Description: 
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed (see 
resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
MNG-5494).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/ (causing 
some issues with https: MNG-6358). 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0"

 

  was:
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed (see 
resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
MNG-5494).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/ (causing 
some issues with https: MNG-6358). 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0

 


> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6414:
---
Description: 
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed (see 
resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
MNG-5494).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/ (causing 
some issues with https: MNG-6358). 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0

 

  was:
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed (see 
resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
MNG-5494).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/. 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0

 


> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/ 
> (causing some issues with https: MNG-6358). 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6414:
---
Description: 
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed (see 
resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
MNG-5494).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/. 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0

 

  was:
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed (see 
resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/. 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0

 


> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1 
> MNG-5494).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/. 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6414:
---
Description: 
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed (see 
resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1).

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/. 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0

 

  was:
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed.

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/. 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0

 


> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed (see 
> resulting {{lib/*.license}} in Maven binary distribution, since Maven 3.2.1).
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/. 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MNG-6414) Add more Apache license header patterns to skip downloading Apache license

2018-09-16 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/MNG-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MNG-6414:
---
Description: 
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies that are not Apache licensed.

License file is not downloaded only when project/license/name is strictly equal 
to "The Apache Software License, Version 2.0": this is too restrictive, as we 
see Apache license downloaded many times from https://www.apache.org/. 

After debugging these cases, additional patterns for Apache license exist and 
need to be added to exception list in 
{{appended-resources/META-INF/LICENSE.vm}}:
 - "Apache License, Version 2.0"
 - "The Apache Software License, Version 2.0"
 - "ASLv2"
 - "Apache Public License 2.0

 

  was:
While preparing Maven distribution, maven-remote-resources-plugin try to 
download licenses for all dependencies when it's not Apache license.

License file is not downloaded only when project/license/name is striclty equal 
to "The Apache Software License, Version 2.0". 

Additional patterns for Apache license exist and need to be added to exception 
list in appended-resources/META-INF/LICENSE.vm:

- Apache License, Version 2.0
- The Apache Software License, Version 2.0
- ASLv2
- Apache Public License 2.0

 


> Add more Apache license header patterns to skip downloading Apache license
> --
>
> Key: MNG-6414
> URL: https://issues.apache.org/jira/browse/MNG-6414
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.2.1, 3.3.9, 3.5.4
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.6.0
>
>
> While preparing Maven distribution, maven-remote-resources-plugin try to 
> download licenses for all dependencies that are not Apache licensed.
> License file is not downloaded only when project/license/name is strictly 
> equal to "The Apache Software License, Version 2.0": this is too restrictive, 
> as we see Apache license downloaded many times from https://www.apache.org/. 
> After debugging these cases, additional patterns for Apache license exist and 
> need to be added to exception list in 
> {{appended-resources/META-INF/LICENSE.vm}}:
>  - "Apache License, Version 2.0"
>  - "The Apache Software License, Version 2.0"
>  - "ASLv2"
>  - "Apache Public License 2.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)