[GitHub] [maven-resolver-ant-tasks] lwr commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement
lwr commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement URL: https://github.com/apache/maven-resolver-ant-tasks/pull/2#issuecomment-594315419 I had add the testcase to expose this problem > the resolver will incorrectly resolve maven-resolver-api as compile scope This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files
[
https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050645#comment-17050645
]
Jan Luehe commented on MSHADE-291:
--
Confirmed the fix in the just-released 3.2.2. Thanks guys!
> shadedPattern applied multiples times when relocating the contents of
> META-INF/services files
> -
>
> Key: MSHADE-291
> URL: https://issues.apache.org/jira/browse/MSHADE-291
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0, 3.2.1
>Reporter: Jan Luehe
>Assignee: Robert Scholte
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.2.2
>
>
> Steps to reproduce:
> 1. Modified the test case for
> https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
>
> org.apache.maven.plugins
> maven-shade-plugin
> -2.4
> +3.1.1
>
>
>
> -org.eclipse.*
> -borg.eclipse.*
> +org.eclipse
> +org.eclipse1234
>
>
>
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows:
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-594209038 Maven Shade Plugin was already marked for verifying handling the new poms, but existing projects should still work. When running maven-shade-plugin with maven 3.7.0-SNAPHOT I see a similar issue: dep-reduced-pom-exclusions\pom.xml ... FAILED project-with-reactors-included\pom.xml (this one hangs because it doesn't have a timeout) That's enough for further investigation. Good catch! Robert On 3-3-2020 23:20:21, Enrico Olivelli wrote: It looks like that this commit is the bad guy 716cc1f [https://github.com/apache/maven/commit/716cc1fe02661897232a7cc3e4c1bb3b3df3b832] just by pushing a git revert 716cc1f [https://github.com/apache/maven/commit/716cc1fe02661897232a7cc3e4c1bb3b3df3b832] I am able to use master branch and this one, I will send a mail to dev@ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [https://github.com/apache/maven/pull/286?email_source=notificationsemail_token=AABE3UBPTDHZ244MSGKM46LRFV7CBA5CNFSM4I4MR7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVMQRQ#issuecomment-594200646], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AABE3UBNKDUBTSLRPBYCPMDRFV7CBANCNFSM4I4MR7CQ]. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-dependency-plugin] elharo opened a new pull request #36: Replace more deprecated and unused code
elharo opened a new pull request #36: Replace more deprecated and unused code URL: https://github.com/apache/maven-dependency-plugin/pull/36 @eolivelli This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6656) Introduce base for build/consumer process
[
https://issues.apache.org/jira/browse/MNG-6656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050608#comment-17050608
]
Hudson commented on MNG-6656:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-6656 #45
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6656/45/
> Introduce base for build/consumer process
> -
>
> Key: MNG-6656
> URL: https://issues.apache.org/jira/browse/MNG-6656
> Project: Maven
> Issue Type: New Feature
> Components: POM
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.7.0-candidate
>
> Attachments: MNG-6656.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The pom.xml as we know it has reached it limits, but it is quite hard to do
> improvements as long as the local pom (as part of the sources) is exactly the
> same as the file being published.
> For the Maven eco system it is important that the published file will still
> be a model 4.0.0 to ensure other projects can still depend on these artifacts.
> This will be a first step to separate the local pom from the remote pom. The
> process to come to the effective pom will change a little bit
> pre-build
> pom.xml (raw model) -> BuildPomXMLFilter -> inheritence -> effective pom/model
> This means that we can enrich the pom to make it a valid effective pom again.
> In this case we can do the following:
> - resolve the [cifriendly
> placeholders|https://maven.apache.org/maven-ci-friendly.html], so it will
> work in multimodules too.
> - resolve parent-version. By removing the version from the parent, the filter
> will get the version based on the relativePath. If the groupId and artifactId
> don't match, the version can't be solved and Maven will fail with a missing
> version for the parent.
> - resolve reactor versions. By removing the versions from reactor
> dependencies, the filter will look up the matching version. If there's no
> version for the groupId+artifactId, the version can't be solved and Maven
> will fail with a missing version for the dependency.
> pre-distribution (install/deploy)
> pom.xml -> BuildPomXMLFilter -> ConsumerPomXMLFilter -> consumer pom
> This means that the XML used to build build the effective pom is used, and
> can be adjusted during copy/upload.
> In this case we can do the following:
> - Remove the modules -elements, since this is local path information and not
> useful after building
> - Remove the relativePath-element, since this is local path information and
> not useful after building
> This PoC has the following goals:
> - It will give us experience with manipuating files before build AND during
> install/deploy.
> - We can see IDEs and CI servers can handle this and how we can move forward.
> This feature will at first be disabled by default and can be activated with
> the System property {{maven.experimental.buildconsumer=true}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-594200332 How about Maven 3.6.3? Otherwise we need to git bisect it. On 3-3-2020 23:13:21, Enrico Olivelli wrote: It looks like I have the very same problem with current master at f2e9afd [https://github.com/apache/maven/commit/f2e9afd788de919646717532d26eca38826e9924] — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [https://github.com/apache/maven/pull/286?email_source=notificationsemail_token=AABE3UAGTNBBABCV22AUEC3RFV6HZA5CNFSM4I4MR7C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVL3OI#issuecomment-594197945], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AABE3UFUHT7Y22ZWRBUJLF3RFV6HZANCNFSM4I4MR7CQ]. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] eolivelli commented on issue #286: [MNG-6656] Introduce base for build/consumer process
eolivelli commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-594200646 It looks like that this commit is the bad guy 716cc1fe02661897232a7cc3e4c1bb3b3df3b832 just by pushing a git revert 716cc1fe02661897232a7cc3e4c1bb3b3df3b832 I am able to use master branch and this one, I will send a mail to dev@ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-dependency-plugin] elharo opened a new pull request #35: remove unthrown exceptions
elharo opened a new pull request #35: remove unthrown exceptions URL: https://github.com/apache/maven-dependency-plugin/pull/35 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-dependency-plugin] elharo opened a new pull request #34: remove unused code
elharo opened a new pull request #34: remove unused code URL: https://github.com/apache/maven-dependency-plugin/pull/34 @khmarbaise This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] eolivelli commented on issue #286: [MNG-6656] Introduce base for build/consumer process
eolivelli commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-594197945 It looks like I have the very same problem with current master at f2e9afd788de919646717532d26eca38826e9924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-dependency-plugin] elharo opened a new pull request #33: fix JavaDoc errors
elharo opened a new pull request #33: fix JavaDoc errors URL: https://github.com/apache/maven-dependency-plugin/pull/33 @eolivelli This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] eolivelli commented on issue #286: [MNG-6656] Introduce base for build/consumer process
eolivelli commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-594192880 This is my stacktrace: > main" #1 prio=5 os_prio=0 cpu=260799,27ms elapsed=290,11s tid=0x7fbe34019000 nid=0x1705 runnable [0x7fbe3c07d000] >java.lang.Thread.State: RUNNABLE >at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) >at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) >at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) >at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) >at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) >at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) >at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) >at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) >at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) >at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) >at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) >at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210) >at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156) >at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148) >at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) >at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) >at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) >at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) >at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) >at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) >at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) >at org.apache.maven.cli.MavenCli.execute(MavenCli.java:977) >at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:291) >at org.apache.maven.cli.MavenCli.main(MavenCli.java:195) >at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@13/Native Method) >at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@13/NativeMethodAccessorImpl.java:62) >at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@13/DelegatingMethodAccessorImpl.java:43) >at java.lang.reflect.Method.invoke(java.base@13/Method.java:567) >at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282) >at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225) >at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406) >at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347) > This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-assembly-plugin] turbanoff commented on issue #16: [MASSEMBLY-874] maven-assembly plugin always downloads dependencies from net
turbanoff commented on issue #16: [MASSEMBLY-874] maven-assembly plugin always downloads dependencies from net URL: https://github.com/apache/maven-assembly-plugin/pull/16#issuecomment-594105560 @eolivelli @struberg any chances that it could be merged without integration test? I don't know how to write reliable test-case for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (MDEP-673) Upgrade asm to 7.3.1
[ https://issues.apache.org/jira/browse/MDEP-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise resolved MDEP-673. -- Resolution: Fixed > Upgrade asm to 7.3.1 > > > Key: MDEP-673 > URL: https://issues.apache.org/jira/browse/MDEP-673 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.2 >Reporter: Karl Heinz Marbaise >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.1.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MDEP-673) Upgrade asm to 7.3.1
[ https://issues.apache.org/jira/browse/MDEP-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MDEP-673: Assignee: Elliotte Rusty Harold (was: Karl Heinz Marbaise) > Upgrade asm to 7.3.1 > > > Key: MDEP-673 > URL: https://issues.apache.org/jira/browse/MDEP-673 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.2 >Reporter: Karl Heinz Marbaise >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.1.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-673) Upgrade asm to 7.3.1
[ https://issues.apache.org/jira/browse/MDEP-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050449#comment-17050449 ] Karl Heinz Marbaise commented on MDEP-673: -- Done with d3cf76030b97fb363ce3c0a4b8a0172706905c9e > Upgrade asm to 7.3.1 > > > Key: MDEP-673 > URL: https://issues.apache.org/jira/browse/MDEP-673 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.2 >Reporter: Karl Heinz Marbaise >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.1.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MDEP-668) Upgrade plexus-interpolation 1.26
[ https://issues.apache.org/jira/browse/MDEP-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MDEP-668. Resolution: Fixed > Upgrade plexus-interpolation 1.26 > - > > Key: MDEP-668 > URL: https://issues.apache.org/jira/browse/MDEP-668 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.2 >Reporter: Karl Heinz Marbaise >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.1.2 > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MDEP-668) Upgrade plexus-interpolation 1.26
[ https://issues.apache.org/jira/browse/MDEP-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise reassigned MDEP-668: Assignee: Elliotte Rusty Harold (was: Karl Heinz Marbaise) > Upgrade plexus-interpolation 1.26 > - > > Key: MDEP-668 > URL: https://issues.apache.org/jira/browse/MDEP-668 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.2 >Reporter: Karl Heinz Marbaise >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.1.2 > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-668) Upgrade plexus-interpolation 1.26
[ https://issues.apache.org/jira/browse/MDEP-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050446#comment-17050446 ] Karl Heinz Marbaise commented on MDEP-668: -- has been done with d3cf76030b97fb363ce3c0a4b8a0172706905c9e > Upgrade plexus-interpolation 1.26 > - > > Key: MDEP-668 > URL: https://issues.apache.org/jira/browse/MDEP-668 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.2 >Reporter: Karl Heinz Marbaise >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.1.2 > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-checkstyle-plugin] romani commented on a change in pull request #28: [MCHECKSTYLE-387] emit a warning when using an old version of checkstyle
romani commented on a change in pull request #28: [MCHECKSTYLE-387] emit a
warning when using an old version of checkstyle
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/28#discussion_r387126144
##
File path:
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
##
@@ -314,6 +314,13 @@ public URLClassLoader run()
try
{
checker.setClassLoader( projectClassLoader );
+/*
+ * MCHECKSTYLE-387: If the previous method call was successful,
emit a warning that the user is using
+ * an old version of checkstyle.
+ */
+getLogger().warn( "Old version of checkstyle detected. Consider
updating to >= v8.30" );
+getLogger().warn( "For more information see: "
++
"https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html;
);
}
catch ( NoSuchMethodError ignored )
Review comment:
This is how we proceed for years, a little from everyone, as sum there is
some progress. :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-resolver-ant-tasks] lwr edited a comment on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement
lwr edited a comment on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement URL: https://github.com/apache/maven-resolver-ant-tasks/pull/2#issuecomment-593997719 After applying the patch, the resolving mechanism still does not work as expected test case ```xml org.apache.maven.resolver maven-resolver-api 1.4.1 org.apache.maven.resolver maven-resolver-util 1.4.1 test ``` the dependency tree ``` [INFO] \- org.apache.maven.resolver:maven-resolver-util:jar:1.4.1:test [INFO]\- org.apache.maven.resolver:maven-resolver-api:jar:1.4.1:test ``` but the resolver will incorrectly resolve `maven-resolver-api` as `compile` scope I think it would be caused by the resolver itself, will 1.4.2 resolve this problem? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-resolver-ant-tasks] lwr commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement
lwr commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement URL: https://github.com/apache/maven-resolver-ant-tasks/pull/2#issuecomment-593997719 After applying the patch, the resolving mechanism still does not work as expected test case ```xml org.apache.maven.resolver maven-resolver-api 1.4.1 org.apache.maven.resolver maven-resolver-util 1.4.1 test ``` the dependency tree ``` [INFO] \- org.apache.maven.resolver:maven-resolver-util:jar:1.4.1:test [INFO]\- org.apache.maven.resolver:maven-resolver-api:jar:1.4.1:test ``` but the resolver will incorrectly resolve `maven-resolver-api` as `compile` scope I think it would be caused by the resolver itself This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MRESOLVER-98) resolver ant task doesn't appear to obey dependencyManagement
[
https://issues.apache.org/jira/browse/MRESOLVER-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050291#comment-17050291
]
William Leung commented on MRESOLVER-98:
After applying the patch, the resolving mechanism still does not work as
expected
test case
{code:xml}
org.apache.maven.resolver
maven-resolver-api
1.4.1
org.apache.maven.resolver
maven-resolver-util
1.4.1
test
{code}
the dependency tree
{noformat}
[INFO] \- org.apache.maven.resolver:maven-resolver-util:jar:1.4.1:test
[INFO]\- org.apache.maven.resolver:maven-resolver-api:jar:1.4.1:test
{noformat}
but the resolver will incorrectly resolve {{maven-resolver-api}} as {{compile}}
scope
> resolver ant task doesn't appear to obey dependencyManagement
> -
>
> Key: MRESOLVER-98
> URL: https://issues.apache.org/jira/browse/MRESOLVER-98
> Project: Maven Resolver
> Issue Type: Bug
> Components: ant tasks
>Affects Versions: ant-tasks-1.2.0
>Reporter: Jay Kahrman
>Priority: Major
> Fix For: waiting-for-feedback
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have a dependency in our pom which has dependencies that don't specify an
> upper bound to the version range. To avoid getting different versions in
> every build we use a dependencyManagement section in the POM to lock down the
> version. This works via the maven 3 CLI, and via the old ant-tasks utility we
> were using (). The maven-resolver-ant-tasks jar doesn't appear to obey the
> dependencyManagement section, however.
>
> I'm not sure is this is related to MRESOLVER-33 and/or MRESOLVER-10 and if
> updating maven-resolver-ant-tasks to depend on Maven Resolver 1.4.0 would
> solve the problem.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MPIR-373) Upgrade from 2.9 to 3.0.0 introduces additional warning
[
https://issues.apache.org/jira/browse/MPIR-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050216#comment-17050216
]
Robin Jansohn edited comment on MPIR-373 at 3/3/20 1:45 PM:
[~michael-o] / [~slachiewicz] / [~hboutemy] please fix the 3.0.1 release. It
hasn't been published to Maven Central and the project's site also still refers
to the old version 3.0.0
(https://maven.apache.org/plugins/maven-project-info-reports-plugin/).
was (Author: jansohn):
[~michael-o] please fix the 3.0.1 release. It hasn't been published to Maven
Central and the project's site also still refers to the old version 3.0.0
(https://maven.apache.org/plugins/maven-project-info-reports-plugin/).
> Upgrade from 2.9 to 3.0.0 introduces additional warning
> ---
>
> Key: MPIR-373
> URL: https://issues.apache.org/jira/browse/MPIR-373
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: GWR
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.0.1, 3.1.0
>
> Attachments: pom.xml
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> a new warning-message introduced, causing some confusion in the devteam.
> When stepping up to maven-project-info-reports-plugin:3.0.0 (from2.9) the
> stacktrace below is seen.
> mvn3.0.5, 3.3.9 and 3.5.2 all give same stacktrace.
> Seems to caused by the xml-resolver:1.2, having a pom.xml containing the
> section.
>
> {code:java}
>
> deployed
>
> {code}
> Is there some more restrictive pom validation introduced with
> maven-project-info-reports-plugin:3.0.0
> {code:java}
> $ mvn project-info-reports:dependencies
> [WARNING] Unable to create Maven project from repository for artifact
> xml-resolver:xml-resolver:jar:1.2
> org.apache.maven.project.ProjectBuildingException: Some problems were
> encountered while processing the POMs:
> [ERROR] 'distributionManagement.status' must not be specified. @ line 36,
> column 13
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:191)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:326)
> at
> org.apache.maven.report.projectinfo.dependencies.RepositoryUtils.getMavenProjectFromRepository
> (RepositoryUtils.java:125)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDescriptionsAndURLs
> (DependenciesRenderer.java:890)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDependencyListing
> (DependenciesRenderer.java:847)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDependencyListing
> (DependenciesRenderer.java:867)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDependencyListing
> (DependenciesRenderer.java:867)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDependencyListing
> (DependenciesRenderer.java:867)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderSectionDependencyTree
> (DependenciesRenderer.java:486)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderSectionProjectDependencyGraph
> (DependenciesRenderer.java:449)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderBody
> (DependenciesRenderer.java:222)
> at org.apache.maven.reporting.AbstractMavenReportRenderer.render
> (AbstractMavenReportRenderer.java:80)
> at org.apache.maven.report.projectinfo.DependenciesReport.executeReport
> (DependenciesReport.java:162)
> at org.apache.maven.reporting.AbstractMavenReport.generate
> (AbstractMavenReport.java:251)
> at org.apache.maven.report.projectinfo.AbstractProjectInfoReport.execute
> (AbstractProjectInfoReport.java:220)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
[jira] [Commented] (MPIR-373) Upgrade from 2.9 to 3.0.0 introduces additional warning
[
https://issues.apache.org/jira/browse/MPIR-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050216#comment-17050216
]
Robin Jansohn commented on MPIR-373:
[~michael-o] please fix the 3.0.1 release. It hasn't been published to Maven
Central and the project's site also still refers to the old version 3.0.0
(https://maven.apache.org/plugins/maven-project-info-reports-plugin/).
> Upgrade from 2.9 to 3.0.0 introduces additional warning
> ---
>
> Key: MPIR-373
> URL: https://issues.apache.org/jira/browse/MPIR-373
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: GWR
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.0.1, 3.1.0
>
> Attachments: pom.xml
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> a new warning-message introduced, causing some confusion in the devteam.
> When stepping up to maven-project-info-reports-plugin:3.0.0 (from2.9) the
> stacktrace below is seen.
> mvn3.0.5, 3.3.9 and 3.5.2 all give same stacktrace.
> Seems to caused by the xml-resolver:1.2, having a pom.xml containing the
> section.
>
> {code:java}
>
> deployed
>
> {code}
> Is there some more restrictive pom validation introduced with
> maven-project-info-reports-plugin:3.0.0
> {code:java}
> $ mvn project-info-reports:dependencies
> [WARNING] Unable to create Maven project from repository for artifact
> xml-resolver:xml-resolver:jar:1.2
> org.apache.maven.project.ProjectBuildingException: Some problems were
> encountered while processing the POMs:
> [ERROR] 'distributionManagement.status' must not be specified. @ line 36,
> column 13
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:191)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:326)
> at
> org.apache.maven.report.projectinfo.dependencies.RepositoryUtils.getMavenProjectFromRepository
> (RepositoryUtils.java:125)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDescriptionsAndURLs
> (DependenciesRenderer.java:890)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDependencyListing
> (DependenciesRenderer.java:847)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDependencyListing
> (DependenciesRenderer.java:867)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDependencyListing
> (DependenciesRenderer.java:867)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.printDependencyListing
> (DependenciesRenderer.java:867)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderSectionDependencyTree
> (DependenciesRenderer.java:486)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderSectionProjectDependencyGraph
> (DependenciesRenderer.java:449)
> at
> org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderBody
> (DependenciesRenderer.java:222)
> at org.apache.maven.reporting.AbstractMavenReportRenderer.render
> (AbstractMavenReportRenderer.java:80)
> at org.apache.maven.report.projectinfo.DependenciesReport.executeReport
> (DependenciesReport.java:162)
> at org.apache.maven.reporting.AbstractMavenReport.generate
> (AbstractMavenReport.java:251)
> at org.apache.maven.report.projectinfo.AbstractProjectInfoReport.execute
> (AbstractProjectInfoReport.java:220)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at
[GitHub] [maven-checkstyle-plugin] elharo commented on issue #28: [MCHECKSTYLE-387] emit a warning when using an old version of checkstyle
elharo commented on issue #28: [MCHECKSTYLE-387] emit a warning when using an old version of checkstyle URL: https://github.com/apache/maven-checkstyle-plugin/pull/28#issuecomment-593919594 FYI, I'm not a maintainer here, just an occasional low level committer and reviewer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process
michael-o commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r386393075 ## File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java ## @@ -375,9 +454,7 @@ private ModelSource createStubModelSource( Artifact artifact ) boolean noErrors = build( results, interimResults, projectIndex, pomFiles, new LinkedHashSet<>(), true, recursive, - config ); - -populateReactorModelPool( modelPool, interimResults ); + config, poolBuilder ); Review comment: Why do you pass around and reuse the builder? I have the feeling your are misusing a build like a caching factory. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
