[GitHub] [maven] slawekjaranowski commented on a change in pull request #650: MNG 7263
slawekjaranowski commented on a change in pull request #650:
URL: https://github.com/apache/maven/pull/650#discussion_r780083814
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/CleanLifecycleProvider.java
##
@@ -19,45 +19,33 @@
* under the License.
*/
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashMap;
-
import javax.inject.Inject;
import javax.inject.Named;
-import javax.inject.Provider;
import javax.inject.Singleton;
-import org.apache.maven.lifecycle.Lifecycle;
-import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-
+/**
+ * {@code clean} lifecycle provider.
+ */
@Named( "clean" )
@Singleton
public final class CleanLifecycleProvider
-implements Provider
+extends AbstractLifecycleProvider
{
- private final Lifecycle lifecycle;
+private static final String LIFECYCLE_ID = "clean";
- @Inject
- public CleanLifecycleProvider()
- {
-HashMap phases = new HashMap<>();
-phases.put( "clean", new LifecyclePhase(
"org.apache.maven.plugins:maven-clean-plugin:3.1.0:clean" ) );
-
-this.lifecycle = new Lifecycle(
+private static final String[] PHASES = {
+"pre-clean",
"clean",
-Collections.unmodifiableList( Arrays.asList(
-"pre-clean",
-"clean",
-"post-clean"
-) ),
-Collections.unmodifiableMap( phases )
-);
- }
-
- @Override
- public Lifecycle get()
- {
-return lifecycle;
- }
+"post-clean"
+};
+
+private static final String[] BINDINGS = {
+"clean", "org.apache.maven.plugins:maven-clean-plugin:3.1.0:clean"
+};
+
+@Inject
+public CleanLifecycleProvider()
+{
Review comment:
Why `Inject` on constructor without arguments?
What should be injected ... ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-mvnd] Oliverwqcwrw opened a new issue #568: I failed to execute MVND on MAC
Oliverwqcwrw opened a new issue #568: URL: https://github.com/apache/maven-mvnd/issues/568 mvnd-0.7.1-linux-amd64 that is my installed ,when I execute MVND ,show me "cannot execute binary file" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #434: Remove ConsoleLogger interface from TestSetRunListener
slawekjaranowski commented on pull request #434: URL: https://github.com/apache/maven-surefire/pull/434#issuecomment-1007204624 By design source code should not contains dead code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #434: Remove ConsoleLogger interface from TestSetRunListener
slawekjaranowski commented on pull request #434: URL: https://github.com/apache/maven-surefire/pull/434#issuecomment-1007196648 @Tibor17 It is clean up of code. As we see implementation of `ConsoleLogger` is not needed for `TestSetRunListener`. The code of surefire project is too complicated, it is difficult to read, to understand so the unneeded code should be removed. There is not connected with `JUnit47ParallelIT.forcedShutdownVerifyingLogs`, I only list why build is not green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470375#comment-17470375
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 7:16 AM:
-
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation, governed
by ASF rules
Maven Central repository area has a Maven2 repository format, governed by Maven
code + repository managers and other build/dependency tools reuse + Maven
Central reuse
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
then when I read the issue title "create correct SHA512 content", it all
summarises the lack of clarity we discovered in 2019 when working on MPOM-244:
"correct" for which rules?
Because at least, ASF and Maven share the SHA-512 algorithm value: now, what
should be the format of the .sha512 file in each case is another question (it
is expected to be used by who? with which tool? mvn? shasum? other?)
was (Author: hboutemy):
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation, governed
by ASF rules
Maven Central repository area has a Maven2 repository format, governed by Maven
code + repository managers and other build/dependency tools reuse + Maven
Central reuse
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
then when I read the issue title "create correct SHA512 content", it all
summarises the lack of clarity we discovered in 2019 when working on MPOM-244:
"correct" for which rules?
Because at least, one this ASF and Maven share is that SHA-512 algorithm value
is the same: now, what should be the format of the .sha512 file in each case is
another question
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted S
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470380#comment-17470380
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 7:12 AM:
-
INFRA-22540 is another pass at that same root cause issue, this time seen as
ASF's Nexus Repository staging rules level (repository.apache.org) to check
file existence, but not on file format (which is implicitely meant as "format
for Maven2 repository format on checksums")
was (Author: hboutemy):
INFRA-22540 is another pass at that same root cause issue, this time seen as
ASF's Nexus Repository staging rules level (repository.apache.org)
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470380#comment-17470380
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 7:10 AM:
-
INFRA-22540 is another pass at that same root cause issue, this time seen as
ASF's Nexus Repository staging rules level (repository.apache.org)
was (Author: hboutemy):
INFRA-22540 is another pass at that same root cause issue, this time seen as
Nexus Repository staging rules level
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470375#comment-17470375
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 7:09 AM:
-
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation, governed
by ASF rules
Maven Central repository area has a Maven2 repository format, governed by Maven
code + repository managers and other build/dependency tools reuse + Maven
Central reuse
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
then when I read the issue title "create correct SHA512 content", it all
summarises the lack of clarity we discovered in 2019 when working on MPOM-244:
"correct" for which rules?
Because at least, one this ASF and Maven share is that SHA-512 algorithm value
is the same: now, what should be the format of the .sha512 file in each case is
another question
was (Author: hboutemy):
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation, governed
by ASF rules
Maven Central repository area has a Maven2 repository format, governed by Maven
code + repository managers and other build/dependency tools reuse + Maven
Central reuse
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
then when I read the issue title "create correct SHA512 content", it all
summarises the lack of clarity: "correct" for which rules?
Because at least, one this ASF and Maven share is that SHA-512 algorithm value
is the same: now, what should be the format of the .sha512 file in each case is
another question
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
[jira] [Commented] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470380#comment-17470380
]
Herve Boutemy commented on MPOM-282:
INFRA-22540 is another pass at that same root cause issue, this time seen as
Nexus Repository staging rules level
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470375#comment-17470375
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 7:05 AM:
-
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation, governed
by ASF rules
Maven Central repository area has a Maven2 repository format, governed by Maven
code + repository managers and other build/dependency tools reuse + Maven
Central reuse
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
then when I read the issue title "create correct SHA512 content", it all
summarises the lack of clarity: "correct" for which rules?
Because at least, one this ASF and Maven share is that SHA-512 algorithm value
is the same: now, what should be the format of the .sha512 file in each case is
another question
was (Author: hboutemy):
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation, governed
by ASF rules
Maven Central repository area has a Maven2 repository format, governed by Maven
code + repository managers and other build/dependency tools reuse + Maven
Central reuse
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470375#comment-17470375
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 7:02 AM:
-
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation, governed
by ASF rules
Maven Central repository area has a Maven2 repository format, governed by Maven
code + repository managers and other build/dependency tools reuse + Maven
Central reuse
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
was (Author: hboutemy):
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation
Maven Central repository area has a Maven2 repository format
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470375#comment-17470375
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 6:59 AM:
-
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the ASF parent POM for that source-release part:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation
Maven Central repository area has a Maven2 repository format
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
was (Author: hboutemy):
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the parent POM:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation
Maven Central repository area has a Maven2 repository format
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470375#comment-17470375
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 6:59 AM:
-
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the parent POM:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation
Maven Central repository area has a Maven2 repository format
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
was (Author: hboutemy):
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the parent POM:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation
Maven Central repository area has a Maven2 repository format
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470375#comment-17470375
]
Herve Boutemy edited comment on MPOM-282 at 1/7/22, 6:58 AM:
-
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the parent POM:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache Software Foundation
Maven Central repository area has a Maven2 repository format
In the past, both asked for SHA1 = the start of thinking that both checksums
files were forced to be the same
When Apache Software Foundation started to require sha512 but not Maven2
repository format, we started to see the mix
was (Author: hboutemy):
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the parent POM:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache
Maven Central repository area has a Maven2 repository format
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470375#comment-17470375
]
Herve Boutemy commented on MPOM-282:
bq. Hm, after rereading original issue: "the created SHA512 which is used for
the distribution area" – is it maybe us misinterpreting this?
+1
there are 2 separate needs that are constantly conflated.
I'll show 1 concrete example = the binary distribution of Maven 3.8.4
apache-maven-3.8.4-bin.zip :
- there is the sha512 file from Apache distribution area ("Apache distribution
area" is ASF specific, obviously):
https://archive.apache.org/dist/maven/maven-3/3.8.4/binaries/
- there is (eventually) the sha512 from Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/ :
you'll see we even did not publish sha512 here (because Maven core does not use
the shared ASF parent POM)
let's look at maven wagon wagon-3.5.1-source-release.zip, that uses (like most
of our Maven releases) the parent POM:
- Apache distribution area ("Apache distribution area" is ASF specific,
obviously): https://archive.apache.org/dist/maven/wagon/
- Maven Central repository:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon/3.5.1/
Apache distribution area is free form of Apache
Maven Central repository area has a Maven2 repository format
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-release] dependabot[bot] opened a new pull request #98: Bump aether-connector-file from 1.7 to 1.13.1
dependabot[bot] opened a new pull request #98: URL: https://github.com/apache/maven-release/pull/98 Bumps [aether-connector-file](https://github.com/sonatype/sonatype-aether) from 1.7 to 1.13.1. Commits https://github.com/sonatype/sonatype-aether/commit/50983e14b99ff694cbb150612352c621b3d7d695";>50983e1 [maven-release-plugin] prepare release aether-1.13.1 https://github.com/sonatype/sonatype-aether/commit/2edd0b8c2ee12cad48b718d3d4d11f991d868f2b";>2edd0b8 [maven-release-plugin] prepare for next development iteration https://github.com/sonatype/sonatype-aether/commit/2277471fc6fade88e66f1c637d90073cd4235831";>2277471 [maven-release-plugin] prepare release aether-1.13.1 https://github.com/sonatype/sonatype-aether/commit/bce194c4e13451ef3806401a338ab3d7ffe798e8";>bce194c o Declared content length for checksums to avoid chunked transfer encoding wh... https://github.com/sonatype/sonatype-aether/commit/7c6ea371877c3fae2cb645bee254df8505e975da";>7c6ea37 o Updated readme to mention Eclipse resources where appropriate https://github.com/sonatype/sonatype-aether/commit/a7aaf6318cd8b47ff2704bcdc9660b8d5b2d1fb6";>a7aaf63 [AETHER-127] Ordering implemented by GenericVersionScheme is not well-defined https://github.com/sonatype/sonatype-aether/commit/c249b3fe643312e6951dcdea586eeac849727626";>c249b3f o Fixed code to obey API contract with regard to null handling https://github.com/sonatype/sonatype-aether/commit/0c2020c338c65ba2bc2dfe8e0f472b7b658f9345";>0c2020c o Extended docs https://github.com/sonatype/sonatype-aether/commit/24f08a84528fea2e2055ab91f6c7fe8a06d0ca83";>24f08a8 o Improved docs https://github.com/sonatype/sonatype-aether/commit/b077ffd62364398a2d7ca4fec94e88cc7cd0bdc7";>b077ffd o Fixed typos Additional commits viewable in https://github.com/sonatype/sonatype-aether/compare/aether-1.7...aether-1.13.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #87: Bump maven-archiver from 3.5.1 to 3.5.2
dependabot[bot] opened a new pull request #87: URL: https://github.com/apache/maven-jlink-plugin/pull/87 Bumps [maven-archiver](https://github.com/apache/maven-archiver) from 3.5.1 to 3.5.2. Commits https://github.com/apache/maven-archiver/commit/e17dadfafff78826de72fafe466b1bb4e1bc01fb";>e17dadf [maven-release-plugin] prepare release maven-archiver-3.5.2 https://github.com/apache/maven-archiver/commit/e44988258196b183db2da00386befc265a2e2917";>e449882 [MSHARED-1013] Upgrade Plexus Archiver to 4.2.7 https://github.com/apache/maven-archiver/commit/b50de9db5bcd7c4623ade96b1bc49d7d9e9ab839";>b50de9d update CI url https://github.com/apache/maven-archiver/commit/24dfab4dd15ec65522250766c54b88c011894aed";>24dfab4 add more values unit tests https://github.com/apache/maven-archiver/commit/b15117219111c040ec76b693fb8097e8e4416261";>b151172 Bump plexus-archiver from 4.2.3 to 4.2.4 https://github.com/apache/maven-archiver/commit/1cf2d124bf90655892a867e740e7c7cde4339daa";>1cf2d12 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-archiver/compare/maven-archiver-3.5.1...maven-archiver-3.5.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request #60: Bump maven-release-plugin from 3.0.0-M4 to 3.0.0-M5
dependabot[bot] opened a new pull request #60: URL: https://github.com/apache/maven-apache-parent/pull/60 Bumps [maven-release-plugin](https://github.com/apache/maven-release) from 3.0.0-M4 to 3.0.0-M5. Commits https://github.com/apache/maven-release/commit/5c2f6fa6127e932303e56f5dfd95cbb31567dc49";>5c2f6fa [maven-release-plugin] prepare release maven-release-3.0.0-M5 https://github.com/apache/maven-release/commit/eca939b0de1e184d14ea4baa1e11cd9aa690d3c7";>eca939b Bump version to 3.0.0-M5-SNAPSHOT https://github.com/apache/maven-release/commit/53d6743ecee3f62067c31c083ffa68ad062dc75e";>53d6743 [MRELEASE-1076] Upgrade Plexus Utils to 3.4.1 https://github.com/apache/maven-release/commit/309652bd0fda03c6d0c4e31026301ffa6e59f9f3";>309652b [MRELEASE-1074] Upgrade Maven SCM to 1.12.2 https://github.com/apache/maven-release/commit/ac76d691586c139684a3bca684ffbe13b80244a3";>ac76d69 [MRELEASE-1075] Move CVS-based tests to Subversion or Git https://github.com/apache/maven-release/commit/0193b314d883a72d4650cc40444f3747b5c70ab1";>0193b31 Change interface implemented by MavenArtifactVersion https://github.com/apache/maven-release/commit/d91b784796e93171171bbcd27c2dc7c97a186c82";>d91b784 Remove unused formal parameters https://github.com/apache/maven-release/commit/cb55288a4c16a2d69aeba0c03a59dc4e47a5c1fd";>cb55288 (doc) javadoc:fix (auto) https://github.com/apache/maven-release/commit/f94b60e4abf5d40ed9422d9961fc789ded5f4ad9";>f94b60e [MRELEASE-1066] Use try-with-resources https://github.com/apache/maven-release/commit/67dc2f854e01ec33d0dbc021305ac99f5472ecce";>67dc2f8 [MRELEASE-1053] scm element removed during release:prepare when parent != rea... Additional commits viewable in https://github.com/apache/maven-release/compare/maven-release-3.0.0-M4...maven-release-3.0.0-M5";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] NoSugarCoffee edited a comment on issue #496: [discussion] run mvnd in docker
NoSugarCoffee edited a comment on issue #496: URL: https://github.com/apache/maven-mvnd/issues/496#issuecomment-1007109084 So mvnd has less potential on CI, because can‘t benifit from daemon, more suitable for local build and run proeject again and again, is it right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] NoSugarCoffee edited a comment on issue #496: [discussion] run mvnd in docker
NoSugarCoffee edited a comment on issue #496: URL: https://github.com/apache/maven-mvnd/issues/496#issuecomment-1007109084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] NoSugarCoffee edited a comment on issue #496: [discussion] run mvnd in docker
NoSugarCoffee edited a comment on issue #496: URL: https://github.com/apache/maven-mvnd/issues/496#issuecomment-1007109084 so mvnd have less potential on CI, because can‘t benifit from daemon, is it right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] NoSugarCoffee commented on issue #496: [discussion] run mvnd in docker
NoSugarCoffee commented on issue #496: URL: https://github.com/apache/maven-mvnd/issues/496#issuecomment-1007109084 so mvnd have less protention on CI, because can‘t benifit from daemon, is it right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] Hccake closed issue #567: Cannot change Platform Encoding
Hccake closed issue #567: URL: https://github.com/apache/maven-mvnd/issues/567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] Hccake commented on issue #567: Cannot change Platform Encoding
Hccake commented on issue #567: URL: https://github.com/apache/maven-mvnd/issues/567#issuecomment-1007104237 > You may also try to add the following line to `~/.m2/mvnd.properties`: > > ``` > mvnd.jvmArgs=-Dfile.encoding\=UTF-8 > ``` Thanks for replying, it works for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] NoSugarCoffee edited a comment on issue #558: build failed in some projects
NoSugarCoffee edited a comment on issue #558: URL: https://github.com/apache/maven-mvnd/issues/558#issuecomment-1005350471 @gnodet Did you try `mvnd clean compile` or `mvnd clean test` rather than `verify` and `install` for sonar. Although I know `verify` also run `compile` and `test` phases, but it stable reproduce for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7382) log4j remote security execution implicated in maven-compiler-plugin
Ronald Ayoub created MNG-7382: - Summary: log4j remote security execution implicated in maven-compiler-plugin Key: MNG-7382 URL: https://issues.apache.org/jira/browse/MNG-7382 Project: Maven Issue Type: Bug Components: Dependencies Affects Versions: 3.8.4 Environment: Windows 10. But I know how to make it work like Linux. Reporter: Ronald Ayoub Attachments: Capture.PNG I use maven to build a java war to a tomcat webapps directory. During this process, I've issued that I am not using log4j anywhere. Nevertheless, every time I build log4j appears in the .m2 directory. I walked dependencies trees and executed finds in a variety of directories and can't find the dependency. However, when I executed maven with verbose mode I found it. Apparently, the maven-compiler-plugin requires a old and vulnerable version of log4j. Worse yet, I believe Tomcat is using it dynamically without configuration by it's mere presence in the .m2 directory. Hence, a security scanner flagged my website as having the log4j vulnerability. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #434: Remove ConsoleLogger interface from TestSetRunListener
Tibor17 commented on pull request #434: URL: https://github.com/apache/maven-surefire/pull/434#issuecomment-1007029234 @slawekjaranowski Can you please explain what you are aiming for and why? Can you please explain the argument and logical connection to the `JUnit47ParallelIT.forcedShutdownVerifyingLogs`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
gnodet commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779916524
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
+this.extension = extension;
+}
+
+public CoreExtension getExtension()
+{
+return extension;
+}
+
+public static String getId( CoreExtension extension )
+{
+StringBuilder id = new StringBuilder( 128 );
+
+id.append( ( extension.getGroupId() == null ) ? "[unknown-group-id]" :
extension.getGroupId() );
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470226#comment-17470226
]
Michael Osipov commented on MPOM-282:
-
I guess if the format is fixed, this should be removed:
{{true}}.
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] michael-o commented on pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
michael-o commented on pull request #648: URL: https://github.com/apache/maven/pull/648#issuecomment-1006984567 > > > > I did add an IT with [apache/maven-integration-testing#133](https://github.com/apache/maven-integration-testing/pull/133), but it works locally but not on github CI, not sure why yet... The test works for me correctly. Though I have noticed that Maven is terminated prematurely. I don't see the `BUILD FAILURE` output since this happens very early in the build. Do you think this can be reasonably improved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reopened MPOM-282:
-
Reopening since it should be fixed for all of us.
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Moved] (MPOM-282) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MPOM-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov moved MNG-6784 to MPOM-282:
--
Component/s: asf
(was: Deployment)
Key: MPOM-282 (was: MNG-6784)
Affects Version/s: (was: 3.6.2)
Project: Maven POMs (was: Maven)
> Create correct SHA512 content
> -
>
> Key: MPOM-282
> URL: https://issues.apache.org/jira/browse/MPOM-282
> Project: Maven POMs
> Issue Type: Improvement
> Components: asf
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] michael-o commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
michael-o commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779906259
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
+this.extension = extension;
+}
+
+public CoreExtension getExtension()
+{
+return extension;
+}
+
+public static String getId( CoreExtension extension )
+{
+StringBuilder id = new StringBuilder( 128 );
+
+id.append( ( extension.getGroupId() == null ) ? "[unknown-group-id]" :
extension.getGroupId() );
Review comment:
Then why not have it generated by Modello just like for `Plugin`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] gnodet commented on a change in pull request #133: [MNG-6326] Make the build fail if core extensions can not be loaded
gnodet commented on a change in pull request #133:
URL:
https://github.com/apache/maven-integration-testing/pull/133#discussion_r779902006
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6326CoreExtensionsNotFoundTest.java
##
@@ -0,0 +1,74 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-6326";>MNG-6326:
+ * check that Maven fails if it cannot load core extensions contributed by
.mvn/extensions.xml.
+ */
+public class MavenITmng6326CoreExtensionsNotFoundTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng6326CoreExtensionsNotFoundTest()
+{
+super( "(3.2.5,)" );
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470211#comment-17470211
]
Christopher Tubbs commented on MNG-6784:
There's also a related discussion on
https://github.com/apache/maven-apache-parent/pull/40 for MPOM, but the
conversation moved because a lot of it was out of scope of MPOM...
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SUREFIRE-1972) Use current version of surefire-shared-utils
[
https://issues.apache.org/jira/browse/SUREFIRE-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1972:
---
Priority: Major (was: Critical)
> Use current version of surefire-shared-utils
>
>
> Key: SUREFIRE-1972
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1972
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> surefire-shared-utils - contains dependencies to external shared utils.
> During build all dependencies are repacked under
> {{org.apache.maven.surefire.shared}} package by {{maven-shade-plugin}}.
> In this approach it is difficult to use in current version of module in
> project.
> We can delegate used shared classes and methods in open way and we can simply
> use it in project.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] gnodet commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
gnodet commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779900286
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
+this.extension = extension;
+}
+
+public CoreExtension getExtension()
+{
+return extension;
+}
+
+public static String getId( CoreExtension extension )
+{
+StringBuilder id = new StringBuilder( 128 );
+
+id.append( ( extension.getGroupId() == null ) ? "[unknown-group-id]" :
extension.getGroupId() );
Review comment:
I suppose an exception will be thrown. Fwiw, the `getId()` is simply
copied from the `Plugin` class and that's what is used in the
`PluginResolutionException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #423: Deploy artifacts only for master branch
Tibor17 commented on pull request #423: URL: https://github.com/apache/maven-surefire/pull/423#issuecomment-1006971127 @slawekjaranowski See [here](https://github.com/apache/maven-surefire/pull/423/files/7db8cd664de94c5be73ff1cdc4c075490962bd63). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470210#comment-17470210
]
Michael Osipov commented on MNG-6784:
-
[~ctubbsii], correct. Back then people requested Resolver to do that and I
refused because I consider those to be an implemenation detail of Resolver.
Therefore, this approach has been used. Obviously, we need to make a difference
for ALL Maven-based plugins in ASF. I think should be moved to MPOM.
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470206#comment-17470206
]
Christopher Tubbs commented on MNG-6784:
If we're talking about the files generated by the plugin in MPOM, and not the
resolver stuff, then here's the related upstream ticket I filed awhile back:
https://github.com/nicoulaj/checksum-maven-plugin/issues/127
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils
Tibor17 edited a comment on pull request #426: URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1006964448 @slawekjaranowski I was able to avoid `build-helper-maven-plugin` and used the trick with setting properties (`distRepoId`, `distRepoUrl`) for snapshots by default and for release versions as well. The other two plugins could not be avoided. This works fine with IntelliJ IDEA/ Eclipse. The solution previously used with a classifier did not work with IDEA - red lines in the import section and hanging tests in the module `surefire-booter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470204#comment-17470204
]
Michael Osipov edited comment on MNG-6784 at 1/6/22, 9:59 PM:
--
If this is going to change it should happen ASF wide, not just us. It is part
of the Maven Apache Parent.
was (Author: michael-o):
If this is going to change it should happen ASF wide, not just us.
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470205#comment-17470205
]
Michael Osipov commented on MNG-6784:
-
http://checksum-maven-plugin.nicoulaj.net/ is used.
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470204#comment-17470204
]
Michael Osipov commented on MNG-6784:
-
If this is going to change it should happen ASF wide, not just us.
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils
Tibor17 commented on pull request #426: URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1006964448 @slawekjaranowski I was able to avoid `build-helper-maven-plugin` and use the trick with setting properties (`distRepoId`, `distRepoUrl`) for snapshots by default and for release as well. The other two plugins could not be avoided. This works fine with IntelliJ IDEA/ Eclipse. The solution previously used with a classifier did not work with IDEA - red lines in the import section and hanging tests in the module `surefire-booter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470203#comment-17470203
]
Christopher Tubbs commented on MNG-6784:
I'm not sure if this issue is about the resolver, or about files produced by
some plugin for the release distribution area. In any case, I do think it would
make sense if anywhere these files were created, they wrote in a format that
included the filename, so it can be more easily verified with standard tooling.
It does no harm to include the filename, and makes it easier for anybody,
regardless of context to use a checksum file they encounter to verify the file
it accompanies.
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] hboutemy commented on a change in pull request #650: MNG 7263
hboutemy commented on a change in pull request #650:
URL: https://github.com/apache/maven/pull/650#discussion_r779886566
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/AbstractLifecycleProvider.java
##
@@ -0,0 +1,64 @@
+package org.apache.maven.lifecycle.providers;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+
+import javax.inject.Provider;
+
+import org.apache.maven.lifecycle.Lifecycle;
+import org.apache.maven.lifecycle.mapping.LifecyclePhase;
+
+/**
+ * Base lifecycle provider.
+ */
+public abstract class AbstractLifecycleProvider
+implements Provider
+{
+private final Lifecycle lifecycle;
+
+protected AbstractLifecycleProvider( String id, String[] phases, String[]
pluginBindings )
+{
+HashMap defaultBindings = null;
+if ( pluginBindings != null )
+{
+int len = pluginBindings.length;
+defaultBindings = new HashMap<>();
+for ( int i = 0; i < len; i++ )
+{
+defaultBindings.put( pluginBindings[i++], new LifecyclePhase(
pluginBindings[i] ) );
Review comment:
done in
https://github.com/apache/maven/commit/1053bf4776dc24f59e7fb6e3772ad09839120400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #133: [MNG-6326] Make the build fail if core extensions can not be loaded
michael-o commented on a change in pull request #133:
URL:
https://github.com/apache/maven-integration-testing/pull/133#discussion_r779885080
##
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6326CoreExtensionsNotFoundTest.java
##
@@ -0,0 +1,74 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-6326";>MNG-6326:
+ * check that Maven fails if it cannot load core extensions contributed by
.mvn/extensions.xml.
+ */
+public class MavenITmng6326CoreExtensionsNotFoundTest
+extends AbstractMavenIntegrationTestCase
+{
+public MavenITmng6326CoreExtensionsNotFoundTest()
+{
+super( "(3.2.5,)" );
Review comment:
3.8.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
michael-o commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779877572
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
Review comment:
Agreed, make it wrong, but consistent with the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
michael-o commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779877025
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
+this.extension = extension;
+}
+
+public CoreExtension getExtension()
+{
+return extension;
+}
+
+public static String getId( CoreExtension extension )
+{
+StringBuilder id = new StringBuilder( 128 );
+
+id.append( ( extension.getGroupId() == null ) ? "[unknown-group-id]" :
extension.getGroupId() );
Review comment:
I wonder what the resolver will say when the input in non-sense...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-5561) Plugin relocation loses configuration
[
https://issues.apache.org/jira/browse/MNG-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470189#comment-17470189
]
Hudson commented on MNG-5561:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7263 #4
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7263/4/
> Plugin relocation loses configuration
> -
>
> Key: MNG-5561
> URL: https://issues.apache.org/jira/browse/MNG-5561
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 3.1.1
>Reporter: Julien CARSIQUE
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: screenshot-1.png
>
>
> Hi,
> Applying a relocation on a plugin seems to lose its configuration.
> In the following sample, I relocated "nuxeo-distribution-tools" to
> "ant-assembly-maven-plugin" and the missing configured parameter is
> "buildFile". The relocation itself went well but the execution fails because
> of a missing parameter.
> {code:title=~/.m2/repository/org/nuxeo/build/nuxeo-distribution-tools/2.0-SNAPSHOT/nuxeo-distribution-tools-2.0-SNAPSHOT.pom}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd";>
> 4.0.0
> org.nuxeo.build
> nuxeo-distribution-tools
> 2.0-SNAPSHOT
> maven-plugin
> Nuxeo Distribution Build
> Assemble Nuxeo distributions
>
>
> ant-assembly-maven-plugin
>
>
> {code}
> {code:title=executed POM extract}
>
>
>
> org.nuxeo.build
>
> nuxeo-distribution-tools
>
>
>
>
> assemble
> package
>
>
> src/main/assemble/assembly.xml
>
>
> build
>
>
>
>
>
>
> {code}
> Here is the diff between an "mvn package -X" with nuxeo-distribution-tools
> (ie: with relocation; line starting with "<") and another one with
> ant-assembly-maven-plugin (ie: without relocation; line starting with ">"):
> {noformat}< [DEBUG] Dependency collection stats:
> {ConflictMarker.analyzeTime=1, ConflictMarker.markTime=0,
> ConflictMarker.nodeCount=72, ConflictIdSorter.graphTime=0,
> ConflictIdSorter.topsortTime=0, ConflictIdSorter.conflictIdCount=34,
> ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=1,
> ConflictResolver.conflictItemCount=71,
> DefaultDependencyCollector.collectTime=10,
> DefaultDependencyCollector.transformTime=2}
> > [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=1,
> > ConflictMarker.markTime=0, ConflictMarker.nodeCount=72,
> > ConflictIdSorter.graphTime=0, ConflictIdSorter.topsortTime=0,
> > ConflictIdSorter.conflictIdCount=34,
> > ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2,
> > ConflictResolver.conflictItemCount=71,
> > DefaultDependencyCollector.collectTime=65,
> > DefaultDependencyCollector.transformTime=3}
> ---
> < [DEBUG] Created new class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> < [DEBUG] Importing foreign packages into class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> > [DEBUG] Created new class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> > [DEBUG] Importing foreign packages into class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> ---
> < [DEBUG] Populating class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> > [DEBUG] Populating class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> ---
> < [DEBUG] Configuring mojo
> org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT:build from plugin
> realm
> ClassRealm[plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT,
> parent: sun.misc.Launcher$AppClassLoader@591ce4fe]
> > [DEBUG] Configuring mojo
> > org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT:build from plugin
> > realm
> > ClassRealm[plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT,
> > parent: sun.misc.Launcher$AppClassLoader@77fe0d66]
> ---
> > [DEBUG] (f) buildFile =
> > /home/julien/ws-ssd/nuxeo/nuxeo-distribution/nuxeo-distribution-resources/src/main/assemble/assembly.xml{noformat}
> The last line highlights the missing parameter.
> Indeed, it seems that in case of a relocation, all the "Parameter" Mojo
> fields take their default value (or none) whereas the "Component" fields are
> still properly injected.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470179#comment-17470179
]
Tamás Cservenák commented on MNG-6784:
--
And one more thing: re checksum content, there are (to me at least) 3 "formats"
known:
* resolver style {{checksum}} (just checksum in file)
* GNU style {{checksum filename}}
* BSD style {{alg(filename) = checksum}}
Resolver can READ all 3 types of checksum styles, but WRITES only the first
type.
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470177#comment-17470177
]
Tamás Cservenák commented on MNG-6784:
--
Hm, after rereading original issue: "the created SHA512 which is used for the
distribution area" – is it maybe us misinterpreting this? As it is not resolver
that creates "checksum for the distribution area", is it? If it is, it is
wrong. If it is not, what does it create it?
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] gnodet commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
gnodet commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779834038
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java
##
@@ -128,19 +128,27 @@ private CoreExtensionEntry createExtension( CoreExtension
extension, List resolveExtension( CoreExtension extension,
RepositorySystemSession repoSession,
List
repositories, DependencyFilter dependencyFilter )
-throws PluginResolutionException
+throws ExtensionResolutionException
{
-Plugin plugin = new Plugin();
-plugin.setGroupId( extension.getGroupId() );
-plugin.setArtifactId( extension.getArtifactId() );
-plugin.setVersion( extension.getVersion() );
-
-DependencyNode root =
-pluginDependenciesResolver.resolveCoreExtension( plugin,
dependencyFilter, repositories, repoSession );
-PreorderNodeListGenerator nlg = new PreorderNodeListGenerator();
-root.accept( nlg );
-List artifacts = nlg.getArtifacts( false );
-
-return artifacts;
+try
+{
+Plugin plugin = new Plugin();
+plugin.setGroupId( extension.getGroupId() );
+plugin.setArtifactId( extension.getArtifactId() );
+plugin.setVersion( extension.getVersion() );
+
+DependencyNode root = pluginDependenciesResolver
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470175#comment-17470175
]
Tamás Cservenák commented on MNG-6784:
--
Agreed, please do not mix the two: md5/sha1 is used by resolver ONLY to
eliminate transport corruption (bitrot). While SHA1 (and MD5) are deprecated in
cryptography, this is not cryptography, just data integrity (and even today
many Linux/Unix use MD5 for same purpose). Also, see
[https://en.wikipedia.org/wiki/SHA-1] the "Data integrity" section.
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] gnodet commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
gnodet commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779832412
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
Review comment:
Right, but if the PluginDependenciesResolver interface is enhanced, the
exception will be moved along the new method I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] gnodet commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
gnodet commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779832412
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
Review comment:
Right, but if the interface is enhanced, the exception will be moved
along the new method I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] gnodet commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
gnodet commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779831944
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
+this.extension = extension;
+}
+
+public CoreExtension getExtension()
+{
+return extension;
+}
+
+public static String getId( CoreExtension extension )
+{
+StringBuilder id = new StringBuilder( 128 );
+
+id.append( ( extension.getGroupId() == null ) ? "[unknown-group-id]" :
extension.getGroupId() );
Review comment:
I don't see any place where this is checked, so my best guess is that if
the user does not fill it, it will be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MSHARED-991) Require Java 8
[ https://issues.apache.org/jira/browse/MSHARED-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSHARED-991: -- Assignee: (was: Michael Osipov) > Require Java 8 > -- > > Key: MSHARED-991 > URL: https://issues.apache.org/jira/browse/MSHARED-991 > Project: Maven Shared Components > Issue Type: Task > Components: maven-archiver >Reporter: Sylwester Lachiewicz >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MDEPLOY-286) Wrong documentation for format of altDeploymentRepository
[
https://issues.apache.org/jira/browse/MDEPLOY-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MDEPLOY-286.
--
Resolution: Done
> Wrong documentation for format of altDeploymentRepository
> -
>
> Key: MDEPLOY-286
> URL: https://issues.apache.org/jira/browse/MDEPLOY-286
> Project: Maven Deploy Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-M1
>Reporter: Roland Illig
>Assignee: Michael Osipov
>Priority: Minor
>
> [https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html] says:
> > Format: id::layout::url
> As of version 3.0.0-M1, this is wrong. The format is now simply `id::url`.
> The old format is no longer accepted.
> While here, the documentation for {{altReleaseDeploymentRepository}} and
> {{altSnapshotDeploymentRepository}}. could be extended to contain the same
> information as the {{altDeploymentRepository}}. The current documentation is
> not completely clear on whether the syntax of these 3 properties follows the
> same rules.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] michael-o commented on a change in pull request #650: MNG 7263
michael-o commented on a change in pull request #650:
URL: https://github.com/apache/maven/pull/650#discussion_r779789439
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/AbstractLifecycleProvider.java
##
@@ -0,0 +1,64 @@
+package org.apache.maven.lifecycle.providers;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+
+import javax.inject.Provider;
+
+import org.apache.maven.lifecycle.Lifecycle;
+import org.apache.maven.lifecycle.mapping.LifecyclePhase;
+
+/**
+ * Base lifecycle provider.
+ */
+public abstract class AbstractLifecycleProvider
+implements Provider
+{
+private final Lifecycle lifecycle;
+
+protected AbstractLifecycleProvider( String id, String[] phases, String[]
pluginBindings )
+{
+HashMap defaultBindings = null;
+if ( pluginBindings != null )
+{
+int len = pluginBindings.length;
+defaultBindings = new HashMap<>();
+for ( int i = 0; i < len; i++ )
+{
+defaultBindings.put( pluginBindings[i++], new LifecyclePhase(
pluginBindings[i] ) );
Review comment:
Can we apply the same sanity check as with the previous PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOURCES-280) Test resources are copied into production WAR file
[
https://issues.apache.org/jira/browse/MRESOURCES-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470137#comment-17470137
]
Michael Osipov commented on MRESOURCES-280:
---
Truly weird, provide a sample reproducer which depicts the actual issue.
> Test resources are copied into production WAR file
> --
>
> Key: MRESOURCES-280
> URL: https://issues.apache.org/jira/browse/MRESOURCES-280
> Project: Maven Resources Plugin
> Issue Type: Bug
> Components: copy
>Affects Versions: 3.2.0
>Reporter: Dries Elliott
>Priority: Major
>
> When specifying an {{outputDirectory}} for the Maven Resources plugin, as
> shown below we are seeing some weird behavior in the plug-in.
> {code:java}
>
> org.apache.maven.plugins
> maven-resources-plugin
>
> ${project.build.outputDirectory}
>
> {code}
> When running a build with {{{}mvn clean install{}}}, we notice that our test
> resources from {{src/test/resources}} end up in the final WAR file that is
> created. It seems strange to us that test resource files would end up in a
> WAR file that will later on be deployed to production.
> Commenting out the {{outputDirectory}} in the above example, resolves the
> issue and the test resources end up in the correct place again.
> Why does setting {{outputDirectory}} to the same its default value explicitly
> cause this behavior? (see
> [https://maven.apache.org/plugins/maven-resources-plugin/resources-mojo.html)]
> Is this a bug?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-verifier] michael-o commented on pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
michael-o commented on pull request #4: URL: https://github.com/apache/maven-verifier/pull/4#issuecomment-1006838137 > > it seems that it contains unrelated changes. > > which changes are you referring to exactly? I am fine with your explanations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #651: [MNG-7264] refactor packaging bindings providers to ease maintenance
mthmulders commented on a change in pull request #651:
URL: https://github.com/apache/maven/pull/651#discussion_r779783453
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java
##
@@ -22,50 +22,40 @@
import java.util.Collections;
import java.util.HashMap;
-import javax.inject.Inject;
-import javax.inject.Named;
import javax.inject.Provider;
-import javax.inject.Singleton;
import org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping;
import org.apache.maven.lifecycle.mapping.Lifecycle;
import org.apache.maven.lifecycle.mapping.LifecycleMapping;
import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-@Named( "pom" )
-@Singleton
-public final class PomLifecycleMappingProvider
+/**
+ * Base lifecycle mapping provider, ie per-packaging plugin bindings for
{@code default} lifecycle.
+ */
+public abstract class AbstractLifecycleMappingProvider
implements Provider
{
- private final LifecycleMapping lifecycleMapping;
-
- @Inject
- public PomLifecycleMappingProvider()
- {
-HashMap lifecyclePhases = new HashMap<>();
-lifecyclePhases.put(
-"install",
-new LifecyclePhase(
"org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install" )
-);
-lifecyclePhases.put(
-"deploy",
-new LifecyclePhase(
"org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy" )
-);
-
-Lifecycle lifecycle = new Lifecycle();
-lifecycle.setId( "default" );
-lifecycle.setLifecyclePhases( Collections.unmodifiableMap( lifecyclePhases
) );
-
-this.lifecycleMapping = new DefaultLifecycleMapping(
-Collections.singletonList(
-lifecycle
-)
-);
- }
-
- @Override
- public LifecycleMapping get()
- {
-return lifecycleMapping;
- }
+private final LifecycleMapping lifecycleMapping;
+
+protected AbstractLifecycleMappingProvider( String[] pluginBindings )
Review comment:
Makes sense, one improvement at a time... Getting rid of the XML
descriptors is a big win already!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] kwin commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
kwin commented on a change in pull request #4:
URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779783183
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -182,22 +203,28 @@ private Verifier( String basedir, String settingsFile,
boolean debug, Boolean fo
setDebug( debug );
findLocalRepo( settingsFile );
-findDefaultMavenHome();
+if ( mavenHome == null )
+{
+this.mavenHome = getDefaultMavenHome();
+useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
Review comment:
See above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] kwin commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
kwin commented on a change in pull request #4:
URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779783103
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -103,23 +103,32 @@
private boolean debug;
+/**
+ * If {@code true} uses {@link ForkedLauncher}, if {@code false} uses
{@link Embedded3xLauncher},
+ * otherwise considers the value {@link #forkMode}.
+ */
private Boolean forkJvm;
private String logFileName = LOG_FILENAME;
-private String defaultMavenHome;
-
-private String defaultClassworldConf;
-
-private String defaultClasspath;
+private String mavenHome;
// will launch mvn with --debug
private boolean mavenDebug = false;
+/**
+ * Either "auto" (use {@link ForkedLauncher} when {@link
#environmentVariables} is not empty,
+ * otherwise use {@link Embedded3xLauncher}) , "embedder" (always use
{@link Embedded3xLauncher})
+ * or something else (always use {@link ForkedLauncher}).
+ * Set through system property {@code verifier.forkMode}.
+ * Only relevant if {@link #forkJvm} is {@code null}.
+ */
private String forkMode;
private boolean debugJvm = false;
+private boolean useWrapper;
Review comment:
Obviously when using a dedicated maven home no `mvnw` should be used,
therefore this required to determine this in the constructor and introducing
this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] kwin commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
kwin commented on a change in pull request #4:
URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779782517
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -103,23 +103,32 @@
private boolean debug;
+/**
+ * If {@code true} uses {@link ForkedLauncher}, if {@code false} uses
{@link Embedded3xLauncher},
+ * otherwise considers the value {@link #forkMode}.
+ */
Review comment:
Sorry but I don't think that adding javadoc to existing/unmodified
fields/methods deserves a dedicated JIRA nor PR. This was mostly for me to
understand how the functionality works. I can remove it if you want, but I
won't dedicated time to recontribute that again in another PR.
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -103,23 +103,32 @@
private boolean debug;
+/**
+ * If {@code true} uses {@link ForkedLauncher}, if {@code false} uses
{@link Embedded3xLauncher},
+ * otherwise considers the value {@link #forkMode}.
+ */
private Boolean forkJvm;
private String logFileName = LOG_FILENAME;
-private String defaultMavenHome;
-
-private String defaultClassworldConf;
-
-private String defaultClasspath;
+private String mavenHome;
// will launch mvn with --debug
private boolean mavenDebug = false;
+/**
+ * Either "auto" (use {@link ForkedLauncher} when {@link
#environmentVariables} is not empty,
+ * otherwise use {@link Embedded3xLauncher}) , "embedder" (always use
{@link Embedded3xLauncher})
+ * or something else (always use {@link ForkedLauncher}).
+ * Set through system property {@code verifier.forkMode}.
+ * Only relevant if {@link #forkJvm} is {@code null}.
+ */
Review comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
michael-o commented on a change in pull request #4:
URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779781214
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -182,22 +203,28 @@ private Verifier( String basedir, String settingsFile,
boolean debug, Boolean fo
setDebug( debug );
findLocalRepo( settingsFile );
-findDefaultMavenHome();
+if ( mavenHome == null )
+{
+this.mavenHome = getDefaultMavenHome();
+useWrapper = Files.exists( Paths.get( getBasedir(), "mvnw" ) );
Review comment:
This
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
michael-o commented on a change in pull request #4:
URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779781109
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -103,23 +103,32 @@
private boolean debug;
+/**
+ * If {@code true} uses {@link ForkedLauncher}, if {@code false} uses
{@link Embedded3xLauncher},
+ * otherwise considers the value {@link #forkMode}.
+ */
private Boolean forkJvm;
private String logFileName = LOG_FILENAME;
-private String defaultMavenHome;
-
-private String defaultClassworldConf;
-
-private String defaultClasspath;
+private String mavenHome;
// will launch mvn with --debug
private boolean mavenDebug = false;
+/**
+ * Either "auto" (use {@link ForkedLauncher} when {@link
#environmentVariables} is not empty,
+ * otherwise use {@link Embedded3xLauncher}) , "embedder" (always use
{@link Embedded3xLauncher})
+ * or something else (always use {@link ForkedLauncher}).
+ * Set through system property {@code verifier.forkMode}.
+ * Only relevant if {@link #forkJvm} is {@code null}.
+ */
private String forkMode;
private boolean debugJvm = false;
+private boolean useWrapper;
Review comment:
This
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] michael-o commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
michael-o commented on a change in pull request #4:
URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779780872
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -103,23 +103,32 @@
private boolean debug;
+/**
+ * If {@code true} uses {@link ForkedLauncher}, if {@code false} uses
{@link Embedded3xLauncher},
+ * otherwise considers the value {@link #forkMode}.
+ */
Review comment:
This
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -103,23 +103,32 @@
private boolean debug;
+/**
+ * If {@code true} uses {@link ForkedLauncher}, if {@code false} uses
{@link Embedded3xLauncher},
+ * otherwise considers the value {@link #forkMode}.
+ */
private Boolean forkJvm;
private String logFileName = LOG_FILENAME;
-private String defaultMavenHome;
-
-private String defaultClassworldConf;
-
-private String defaultClasspath;
+private String mavenHome;
// will launch mvn with --debug
private boolean mavenDebug = false;
+/**
+ * Either "auto" (use {@link ForkedLauncher} when {@link
#environmentVariables} is not empty,
+ * otherwise use {@link Embedded3xLauncher}) , "embedder" (always use
{@link Embedded3xLauncher})
+ * or something else (always use {@link ForkedLauncher}).
+ * Set through system property {@code verifier.forkMode}.
+ * Only relevant if {@link #forkJvm} is {@code null}.
+ */
Review comment:
This
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] kwin commented on pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
kwin commented on pull request #4: URL: https://github.com/apache/maven-verifier/pull/4#issuecomment-1006830932 > it seems that it contains unrelated changes. which changes are you referring to exactly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-verifier] kwin commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
kwin commented on a change in pull request #4: URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779777041 ## File path: .gitignore ## @@ -3,7 +3,7 @@ target/ .classpath .settings/ .svn/ -bin/ +/bin/ Review comment: a bin folder is included in the test resources as this is part of the layout below maven home (https://github.com/apache/maven-verifier/pull/4/files#diff-770f62c0c49568f6bdd2aaabe732e084a54c6646756e823382668d9b888563cfR1)! The intent here is to only exclude compiled classes which will only ever end up in the to-level directory /bin (if at all)! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-verifier] kwin commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
kwin commented on a change in pull request #4: URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779777041 ## File path: .gitignore ## @@ -3,7 +3,7 @@ target/ .classpath .settings/ .svn/ -bin/ +/bin/ Review comment: a bin folder is included in the test resources as this is part of the layout below maven home! The intent here is to only exclude compiled classes which will only ever end up in the to-level directory /bin (if at all)! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] hboutemy commented on a change in pull request #651: [MNG-7264] refactor packaging bindings providers to ease maintenance
hboutemy commented on a change in pull request #651:
URL: https://github.com/apache/maven/pull/651#discussion_r779733342
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java
##
@@ -22,50 +22,40 @@
import java.util.Collections;
import java.util.HashMap;
-import javax.inject.Inject;
-import javax.inject.Named;
import javax.inject.Provider;
-import javax.inject.Singleton;
import org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping;
import org.apache.maven.lifecycle.mapping.Lifecycle;
import org.apache.maven.lifecycle.mapping.LifecycleMapping;
import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-@Named( "pom" )
-@Singleton
-public final class PomLifecycleMappingProvider
+/**
+ * Base lifecycle mapping provider, ie per-packaging plugin bindings for
{@code default} lifecycle.
+ */
+public abstract class AbstractLifecycleMappingProvider
implements Provider
{
- private final LifecycleMapping lifecycleMapping;
-
- @Inject
- public PomLifecycleMappingProvider()
- {
-HashMap lifecyclePhases = new HashMap<>();
-lifecyclePhases.put(
-"install",
-new LifecyclePhase(
"org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install" )
-);
-lifecyclePhases.put(
-"deploy",
-new LifecyclePhase(
"org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy" )
-);
-
-Lifecycle lifecycle = new Lifecycle();
-lifecycle.setId( "default" );
-lifecycle.setLifecyclePhases( Collections.unmodifiableMap( lifecyclePhases
) );
-
-this.lifecycleMapping = new DefaultLifecycleMapping(
-Collections.singletonList(
-lifecycle
-)
-);
- }
-
- @Override
- public LifecycleMapping get()
- {
-return lifecycleMapping;
- }
+private final LifecycleMapping lifecycleMapping;
+
+protected AbstractLifecycleMappingProvider( String[] pluginBindings )
Review comment:
previously, everything was pure XML parsing: Tamás switched to Provider
code, but still using old `new LifecyclePhase( String )` that parses (and
splits on comma if there are multiple bindings).
So we're going step by step from Plexus XML to perfectly maintainable code
(and maintainable code will match the documentation objective: code before this
PR is just not readable for documentation, then is not maintainable either =
what is even more important than documentation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
michael-o commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779772113
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
Review comment:
I guess this duplicated the previous exception, but duplicating the
cause message isn't right.
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java
##
@@ -128,19 +128,27 @@ private CoreExtensionEntry createExtension( CoreExtension
extension, List resolveExtension( CoreExtension extension,
RepositorySystemSession repoSession,
List
repositories, DependencyFilter dependencyFilter )
-throws PluginResolutionException
+throws ExtensionResolutionException
{
-Plugin plugin = new Plugin();
-plugin.setGroupId( extension.getGroupId() );
-plugin.setArtifactId( extension.getArtifactId() );
-plugin.setVersion( extension.getVersion() );
-
-DependencyNode root =
-pluginDependenciesResolver.resolveCoreExtension( plugin,
dependencyFilter, repositories, repoSession );
-PreorderNodeListGenerator nlg = new PreorderNodeListGenerator();
-root.accept( nlg );
-List artifacts = nlg.getArtifacts( false );
-
-return artifacts;
+try
+{
+Plugin plugin = new Plugin();
+plugin.setGroupId( extension.getGroupId() );
+plugin.setArtifactId( extension.getArtifactId() );
+plugin.setVersion( extension.getVersion() );
+
+DependencyNode root = pluginDependenciesResolver
Review comment:
Can you add a TODO that the interface likely needs to change to receive
`CoreExtension` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #648: [MNG-6326] Make the build fail if core extensions can not be loaded
michael-o commented on a change in pull request #648:
URL: https://github.com/apache/maven/pull/648#discussion_r779771833
##
File path:
maven-embedder/src/main/java/org/apache/maven/cli/internal/ExtensionResolutionException.java
##
@@ -0,0 +1,59 @@
+package org.apache.maven.cli.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.cli.internal.extension.model.CoreExtension;
+
+/**
+ * Exception occurring trying to resolve a plugin.
+ *
+ * @author mailto:br...@apache.org";>Brett Porter
+ */
+public class ExtensionResolutionException
+extends Exception
+{
+
+private final CoreExtension extension;
+
+public ExtensionResolutionException( CoreExtension extension, Throwable
cause )
+{
+super( "Extension " + getId( extension ) + " or one of its
dependencies could not be resolved: "
++ cause.getMessage(), cause );
+this.extension = extension;
+}
+
+public CoreExtension getExtension()
+{
+return extension;
+}
+
+public static String getId( CoreExtension extension )
+{
+StringBuilder id = new StringBuilder( 128 );
+
+id.append( ( extension.getGroupId() == null ) ? "[unknown-group-id]" :
extension.getGroupId() );
Review comment:
Do we expect them to be be null??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6727) Using version range in parent and CI Friendly Version fails
[
https://issues.apache.org/jira/browse/MNG-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470111#comment-17470111
]
Michael Osipov commented on MNG-6727:
-
[~jeff.maxwell], one year has passed, today is my birthday again and make me a
present: Take a look at my comments on the PR and I will review and merge.
> Using version range in parent and CI Friendly Version fails
> ---
>
> Key: MNG-6727
> URL: https://issues.apache.org/jira/browse/MNG-6727
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation, POM, Reactor and Workspace
>Affects Versions: 3.5.2, 3.6.1, 3.6.2, 3.6.3
>Reporter: Tom Kiemes
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.x-candidate, 3.8.x-candidate
>
>
> We would like to pass a [version
> range|https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] to
> the parent which should be possible since 3.5.0
> At the same time, we would like to use [CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html] for the artifact
> itself.
> Both on their own work well, but combined they don't.
> {{}}
> {{http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> }}{{xsi:schemaLocation="[http://maven.apache.org/POM/4.0.0]
> [http://maven.apache.org/xsd/maven-4.0.0.xsd]";>}}
> {{ 4.0.0}}
> {{ }}
> {{ org.springframework.boot}}
> {{ spring-boot-starter-parent}}
> {{ [2.1,3.0)}}
> {{ }}
> {{ com.example}}
> {{ test}}
> {{ ${revision}}}
> {{ pom}}
> {{ }}
> {{ 0.0.1}}
> {{ }}
> {{}}
>
> The resulting error is:
> {{The project com.example:test:${revision} (/Users/d045390/scratch/test.pom)
> has 1 error}}
> {{[ERROR] Version must be a constant @ line 13, column 12}}
>
> Changing the version range of the parent to a fixed version e.g.
> \{{2.1.5.Release}}, building works.
> Changing the artifact version from ${revision} to a fixed version e.g. 0.0.1
> without using the {{properties}} works as well.
> So it somehow must be the combination of both features which are actually not
> really related or am I missing something?
> PS: I left the modules out for abbreviation purpose. The pom itself can still
> be used to reproduced
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-verifier] michael-o commented on a change in pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
michael-o commented on a change in pull request #4: URL: https://github.com/apache/maven-verifier/pull/4#discussion_r779764509 ## File path: .gitignore ## @@ -3,7 +3,7 @@ target/ .classpath .settings/ .svn/ -bin/ +/bin/ Review comment: ??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o removed a comment on pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version
michael-o removed a comment on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-1006815704
@jmax01 `${pom.parent.version}` also needs to be added. Also rebase and
reconcile the conflict. Targetting for 3.8.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version
michael-o commented on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-1006815704
@jmax01 `${pom.parent.version}` also needs to be added. Also rebase and
reconcile the conflict. Targetting for 3.8.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-verifier] kwin commented on pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
kwin commented on pull request #4: URL: https://github.com/apache/maven-verifier/pull/4#issuecomment-1006813175 @michael-o or @rfscholte : Can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-5561) Plugin relocation loses configuration
[
https://issues.apache.org/jira/browse/MNG-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470103#comment-17470103
]
Hudson commented on MNG-5561:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7264 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7264/2/
> Plugin relocation loses configuration
> -
>
> Key: MNG-5561
> URL: https://issues.apache.org/jira/browse/MNG-5561
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 3.1.1
>Reporter: Julien CARSIQUE
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: screenshot-1.png
>
>
> Hi,
> Applying a relocation on a plugin seems to lose its configuration.
> In the following sample, I relocated "nuxeo-distribution-tools" to
> "ant-assembly-maven-plugin" and the missing configured parameter is
> "buildFile". The relocation itself went well but the execution fails because
> of a missing parameter.
> {code:title=~/.m2/repository/org/nuxeo/build/nuxeo-distribution-tools/2.0-SNAPSHOT/nuxeo-distribution-tools-2.0-SNAPSHOT.pom}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd";>
> 4.0.0
> org.nuxeo.build
> nuxeo-distribution-tools
> 2.0-SNAPSHOT
> maven-plugin
> Nuxeo Distribution Build
> Assemble Nuxeo distributions
>
>
> ant-assembly-maven-plugin
>
>
> {code}
> {code:title=executed POM extract}
>
>
>
> org.nuxeo.build
>
> nuxeo-distribution-tools
>
>
>
>
> assemble
> package
>
>
> src/main/assemble/assembly.xml
>
>
> build
>
>
>
>
>
>
> {code}
> Here is the diff between an "mvn package -X" with nuxeo-distribution-tools
> (ie: with relocation; line starting with "<") and another one with
> ant-assembly-maven-plugin (ie: without relocation; line starting with ">"):
> {noformat}< [DEBUG] Dependency collection stats:
> {ConflictMarker.analyzeTime=1, ConflictMarker.markTime=0,
> ConflictMarker.nodeCount=72, ConflictIdSorter.graphTime=0,
> ConflictIdSorter.topsortTime=0, ConflictIdSorter.conflictIdCount=34,
> ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=1,
> ConflictResolver.conflictItemCount=71,
> DefaultDependencyCollector.collectTime=10,
> DefaultDependencyCollector.transformTime=2}
> > [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=1,
> > ConflictMarker.markTime=0, ConflictMarker.nodeCount=72,
> > ConflictIdSorter.graphTime=0, ConflictIdSorter.topsortTime=0,
> > ConflictIdSorter.conflictIdCount=34,
> > ConflictIdSorter.conflictIdCycleCount=0, ConflictResolver.totalTime=2,
> > ConflictResolver.conflictItemCount=71,
> > DefaultDependencyCollector.collectTime=65,
> > DefaultDependencyCollector.transformTime=3}
> ---
> < [DEBUG] Created new class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> < [DEBUG] Importing foreign packages into class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> > [DEBUG] Created new class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> > [DEBUG] Importing foreign packages into class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> ---
> < [DEBUG] Populating class realm
> plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT
> > [DEBUG] Populating class realm
> > plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT
> ---
> < [DEBUG] Configuring mojo
> org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT:build from plugin
> realm
> ClassRealm[plugin>org.nuxeo.build:nuxeo-distribution-tools:2.0-SNAPSHOT,
> parent: sun.misc.Launcher$AppClassLoader@591ce4fe]
> > [DEBUG] Configuring mojo
> > org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT:build from plugin
> > realm
> > ClassRealm[plugin>org.nuxeo.build:ant-assembly-maven-plugin:2.0-SNAPSHOT,
> > parent: sun.misc.Launcher$AppClassLoader@77fe0d66]
> ---
> > [DEBUG] (f) buildFile =
> > /home/julien/ws-ssd/nuxeo/nuxeo-distribution/nuxeo-distribution-resources/src/main/assemble/assembly.xml{noformat}
> The last line highlights the missing parameter.
> Indeed, it seems that in case of a relocation, all the "Parameter" Mojo
> fields take their default value (or none) whereas the "Component" fields are
> still properly injected.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (MNG-7373) Maven should not attempt to download the jar when pom
[
https://issues.apache.org/jira/browse/MNG-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-7373:
---
Assignee: (was: Michael Osipov)
> Maven should not attempt to download the jar when pom
>
>
> Key: MNG-7373
> URL: https://issues.apache.org/jira/browse/MNG-7373
> Project: Maven
> Issue Type: Improvement
>Reporter: S L
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Hello,
> maybe a corner case of what exactly should be part of a "relocation pom"
> ([https://maven.apache.org/guides/mini/guide-relocation.html]), but I created
> a release just consisting of the relocation-info
> ([https://repo1.maven.org/maven2/pl/project13/maven/git-commit-id-plugin/4.9.9/git-commit-id-plugin-4.9.9.pom])
> as type `pom` (since I only wanted to publish the
> relocation information).
> Using this depdendency.e.g. via:
> {code}
>
>
>
> pl.project13.maven
> git-commit-id-plugin
> 4.9.9
>
>
>
> {code}
> yields in the incorrect attempt of downloading a JAR-File from the new
> repository location:
> {code}
> [INFO] Building Git Commit Id Plugin Maven Mojo Debugging 0.0.3-SNAPSHOT
> [1/3]
> [INFO] [ pom
> ]-
> Downloading from central-secure:
> https://repo.maven.apache.org/maven2/io/github/git-commit-id/git-commit-id-maven-plugin/4.9.9/git-commit-id-maven-plugin-4.9.9.pom
> [WARNING] The POM for
> io.github.git-commit-id:git-commit-id-maven-plugin:jar:4.9.9 is missing, no
> dependency information available
> Downloading from central-secure:
> https://repo.maven.apache.org/maven2/io/github/git-commit-id/git-commit-id-maven-plugin/4.9.9/git-commit-id-maven-plugin-4.9.9.jar
> [INFO]
>
> [INFO] Reactor Summary for Git Commit Id Plugin Maven Mojo Debugging
> 0.0.3-SNAPSHOT:
> [INFO]
> [INFO] Git Commit Id Plugin Maven Mojo Debugging .. FAILURE [ 0.850
> s]
> [INFO] submodule-one .. SKIPPED
> [INFO] submodule-two .. SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 1.000 s
> [INFO] Finished at: 2021-07-12T21:42:15+02:00
> [INFO]
>
> [ERROR] Plugin pl.project13.maven:git-commit-id-plugin:4.9.9 or one of its
> dependencies could not be resolved: Could not find artifact
> io.github.git-commit-id:git-commit-id-maven-plugin:jar:4.9.9 in
> central-secure (https://repo.maven.apache.org/maven2) -> [Help 1]
> {code}
> IMHO Maven should not even try to search for a jar when
> `pom`. Simply raise an error that the package was
> relocated. the new location is at least detected, since it tries to download
> the artifact from a new location.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-7357) All Maven Core JARs have unusual entry order
[
https://issues.apache.org/jira/browse/MNG-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7357:
Fix Version/s: 4.0.0
4.0.0-alpha-1
3.8.5
> All Maven Core JARs have unusual entry order
>
>
> Key: MNG-7357
> URL: https://issues.apache.org/jira/browse/MNG-7357
> Project: Maven
> Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
> Attachments: screenshot-1.png, zipinfo-maven-master.txt
>
>
> Built from 3a06530dbce82e2054afa3cc4c81631910474bd0 I receive this:
> {noformat}
> mosipov@bsd1srv:/usr/home/mosipov/var/Projekte/maven (master *=)
> $ find . -name maven-\*4.0.0-alpha-1-SNAPSHOT.jar -type f -exec sh -c
> 'zipinfo {} | head -4' \; 2>&1 | less
> Archive: ./maven-bom/target/maven-bom-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 7277 bytes, number of entries: 10
> -rw-r--r-- 2.0 unx 358 b- defN 20-Jan-26 09:04 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 20-Jan-26 09:04 META-INF/
> Archive:
> ./maven-model-builder/target/maven-model-builder-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 217583 bytes, number of entries: 173
> -rw-r--r-- 2.0 unx 352 b- defN 21-Apr-05 08:12 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 21-Apr-05 08:12 META-INF/
> Archive: ./maven-model/target/maven-model-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 203201 bytes, number of entries: 76
> -rw-r--r-- 2.0 unx 336 b- defN 21-Apr-05 08:12 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 21-Apr-05 08:12 META-INF/
> Archive:
> ./maven-slf4j-provider/target/maven-slf4j-provider-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 25315 bytes, number of entries: 26
> Archive: ./maven-bom/target/maven-bom-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 7277 bytes, number of entries: 10
> -rw-r--r-- 2.0 unx 358 b- defN 20-Jan-26 09:04 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 20-Jan-26 09:04 META-INF/
> Archive:
> ./maven-model-builder/target/maven-model-builder-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 217583 bytes, number of entries: 173
> -rw-r--r-- 2.0 unx 352 b- defN 21-Apr-05 08:12 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 21-Apr-05 08:12 META-INF/
> Archive: ./maven-model/target/maven-model-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 203201 bytes, number of entries: 76
> -rw-r--r-- 2.0 unx 336 b- defN 21-Apr-05 08:12 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 21-Apr-05 08:12 META-INF/
> Archive:
> ./maven-slf4j-provider/target/maven-slf4j-provider-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 25315 bytes, number of entries: 26
> Archive: ./maven-bom/target/maven-bom-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 7277 bytes, number of entries: 10
> -rw-r--r-- 2.0 unx 358 b- defN 20-Jan-26 09:04 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 20-Jan-26 09:04 META-INF/
> Archive:
> ./maven-model-builder/target/maven-model-builder-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 217583 bytes, number of entries: 173
> -rw-r--r-- 2.0 unx 352 b- defN 21-Apr-05 08:12 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 21-Apr-05 08:12 META-INF/
> Archive: ./maven-model/target/maven-model-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 203201 bytes, number of entries: 76
> -rw-r--r-- 2.0 unx 336 b- defN 21-Apr-05 08:12 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 21-Apr-05 08:12 META-INF/
> Archive:
> ./maven-slf4j-provider/target/maven-slf4j-provider-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 25315 bytes, number of entries: 26
> Archive: ./maven-bom/target/maven-bom-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 7277 bytes, number of entries: 10
> -rw-r--r-- 2.0 unx 358 b- defN 20-Jan-26 09:04 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 20-Jan-26 09:04 META-INF/
> Archive:
> ./maven-model-builder/target/maven-model-builder-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 217583 bytes, number of entries: 173
> -rw-r--r-- 2.0 unx 352 b- defN 21-Apr-05 08:12 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 21-Apr-05 08:12 META-INF/
> Archive: ./maven-model/target/maven-model-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 203201 bytes, number of entries: 76
> -rw-r--r-- 2.0 unx 336 b- defN 21-Apr-05 08:12 META-INF/MANIFEST.MF
> drwxr-xr-x 2.0 unx0 b- stor 21-Apr-05 08:12 META-INF/
> Archive:
> ./maven-slf4j-provider/target/maven-slf4j-provider-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 25315 bytes, number of entries: 26
> Archive: ./maven-bom/target/maven-bom-4.0.0-alpha-1-SNAPSHOT.jar
> Zip file size: 7277 bytes, number of entries: 10
> -rw-r--r-- 2.0 unx 358
[GitHub] [maven] michael-o closed pull request #649: [MNG-6802] Fix bug in FileProfileActivator (#347)
michael-o closed pull request #649: URL: https://github.com/apache/maven/pull/649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #649: [MNG-6802] Fix bug in FileProfileActivator (#347)
michael-o commented on pull request #649: URL: https://github.com/apache/maven/pull/649#issuecomment-1006803524 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-6802) FileProfileActivator changes FileProfileActivator.exists which lets flattened resolveCiFriendliesOnly depending fail activating profile
[
https://issues.apache.org/jira/browse/MNG-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6802.
---
Resolution: Fixed
Fixed with
[3fabb639a31d6076b1649c1a08828febabddf44a|https://gitbox.apache.org/repos/asf?p=maven.git&a=commit&h=3fabb639a31d6076b1649c1a08828febabddf44a]
in master and with
[0f3c39b8ed1a875ec58ebe91b2b18ca8b64b2fd3|https://gitbox.apache.org/repos/asf?p=maven.git&a=commit&h=0f3c39b8ed1a875ec58ebe91b2b18ca8b64b2fd3]
in 3.8.x.
> FileProfileActivator changes FileProfileActivator.exists which lets flattened
> resolveCiFriendliesOnly depending fail activating profile
> ---
>
> Key: MNG-6802
> URL: https://issues.apache.org/jira/browse/MNG-6802
> Project: Maven
> Issue Type: Bug
> Components: Profiles
>Affects Versions: 3.2.2, 3.6.2
>Reporter: Stefan Cordes
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
>
> In my pom.xml I have
>
> {noformat}
> ...
>
>
>cas-mule4-app
>
>
> mule-artifact.json
>
>
> ...{noformat}
>
> which worked fine.
> After switching to ci-friendly pom.xml with revision and flatten the
> published .flattened-pom.xml contains absolute path:
>
> {noformat}
>
> cas-mule4-app
>
>
>
> D:\jenkins\workspace\mulestac-multibranch_mule4-DWHLMU7ZMPDNCYK6LVMSYLB6GODEIQS7CUNRQQVSISU47ME72PRQ\mule-artifact.json
>
>
> {noformat}
>
> (which is the temporary path of our jenkins container)
> and so other projects using that pom.xml as parent will fail to activate the
> profile.
>
> This came in with MNG-1775 or a related issue via adding
> {noformat}
> // replace activation value with interpolated value
> if ( missing )
> {
> file.setMissing( path );
> }
> else
> {
> file.setExists( path );
> }
> {noformat}
> in org.apache.maven.model.profile.activation.FileProfileActivator.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6802) FileProfileActivator changes FileProfileActivator.exists which lets flattened resolveCiFriendliesOnly depending fail activating profile
[
https://issues.apache.org/jira/browse/MNG-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470096#comment-17470096
]
Hudson commented on MNG-6802:
-
Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #101
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/101/
> FileProfileActivator changes FileProfileActivator.exists which lets flattened
> resolveCiFriendliesOnly depending fail activating profile
> ---
>
> Key: MNG-6802
> URL: https://issues.apache.org/jira/browse/MNG-6802
> Project: Maven
> Issue Type: Bug
> Components: Profiles
>Affects Versions: 3.2.2, 3.6.2
>Reporter: Stefan Cordes
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
>
> In my pom.xml I have
>
> {noformat}
> ...
>
>
>cas-mule4-app
>
>
> mule-artifact.json
>
>
> ...{noformat}
>
> which worked fine.
> After switching to ci-friendly pom.xml with revision and flatten the
> published .flattened-pom.xml contains absolute path:
>
> {noformat}
>
> cas-mule4-app
>
>
>
> D:\jenkins\workspace\mulestac-multibranch_mule4-DWHLMU7ZMPDNCYK6LVMSYLB6GODEIQS7CUNRQQVSISU47ME72PRQ\mule-artifact.json
>
>
> {noformat}
>
> (which is the temporary path of our jenkins container)
> and so other projects using that pom.xml as parent will fail to activate the
> profile.
>
> This came in with MNG-1775 or a related issue via adding
> {noformat}
> // replace activation value with interpolated value
> if ( missing )
> {
> file.setMissing( path );
> }
> else
> {
> file.setExists( path );
> }
> {noformat}
> in org.apache.maven.model.profile.activation.FileProfileActivator.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MNG-7048) Adding a constant class generator.
[ https://issues.apache.org/jira/browse/MNG-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7048. --- Fix Version/s: (was: wontfix-candidate) Resolution: Won't Fix > Adding a constant class generator. > -- > > Key: MNG-7048 > URL: https://issues.apache.org/jira/browse/MNG-7048 > Project: Maven > Issue Type: Improvement >Reporter: Terrien Jean-Yves >Priority: Trivial > Labels: features > > Hello > I suggest adding a plugin or a feature in an existing plugin. For automatic > creating of a class of constants containing Maven values. > To date, this requires filtering a properties file which is read at runtime. > Adding a class allows to have constants and not variables, which are defined > at compilation. > This is a simple example of an implementation. > https://github.com/jyterrien/constants-maven-plugin -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MNG-7283) add dependency when maven exec
[ https://issues.apache.org/jira/browse/MNG-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7283. --- Fix Version/s: (was: wontfix-candidate) Resolution: Information Provided > add dependency when maven exec > -- > > Key: MNG-7283 > URL: https://issues.apache.org/jira/browse/MNG-7283 > Project: Maven > Issue Type: Wish > Components: Dependencies >Reporter: wangjie >Priority: Major > > *1、background* > as we all kown, each cloud environment has different component > implementations. For example: The message queue components of AWS and Alibaba > Cloud are similar in function, but different in implementation. > we are try to build a unified API specification, developers only need to > introduce unified standardized APIs for these components when developing. > When the project is built and deployed on different clouds, we will > automatically introduce the implementation dependencies of different > components under different clouds for the project. > *2、issues* > Due to the above reason, we hope to add some dependencies when maven starts > to build the project. After reading the documentation and google related > issues, I found that maven does not support this feature(I don’t know much > about maven. If maven supports this feature, please share with me. Thanks in > advance). > If maven does not support adding dependencies at the beginning of the build, > can the community consider supporting this feature? > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470088#comment-17470088
]
Michael Osipov commented on MNG-6784:
-
The linked paragraph by [~kwin], contains a lot of non-sense since checksum and
hash are used interchangeably which is wrong. All of the checksums we provide
are solely for the consumption of Resolver to detect bitrot. Nothing else.
[~cstamas]
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.x-candidate, wontfix-candidate
>
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MNG-6784) Create correct SHA512 content
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6784.
---
Fix Version/s: (was: wontfix-candidate)
(was: 4.0.x-candidate)
Resolution: Won't Fix
I am quite certain that this will not change.
> Create correct SHA512 content
> -
>
> Key: MNG-6784
> URL: https://issues.apache.org/jira/browse/MNG-6784
> Project: Maven
> Issue Type: Improvement
> Components: Deployment
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the created SHA512 which is used for the distribution area contains
> only the checksum but not the filename which results in bad output if the
> checksums being checked via command line tool:
> {code}
> $ shasum -c apache-maven-3.2.5-bin.tar.gz.sha512
> $ shasum: apache-maven-3.2.5-bin.tar.gz.sha512: no properly formatted SHA
> checksum lines found
> {code}
> The checksum should be enhanced to support that correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-7096) Maven master and m-shade-p 3.2.1 hangs forever
[
https://issues.apache.org/jira/browse/MNG-7096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470085#comment-17470085
]
Michael Osipov commented on MNG-7096:
-
[~cstamas], ping!
> Maven master and m-shade-p 3.2.1 hangs forever
> --
>
> Key: MNG-7096
> URL: https://issues.apache.org/jira/browse/MNG-7096
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.x-candidate
>Reporter: Tamás Cservenák
>Priority: Critical
>
> A fairly huge build, works okay with Maven 3.6.3, but with Maven
> 4.0.0-alpha-1-SNAPSHOT (ab20190a1a9fecdc8f85b40e8d03d806f3da4fc6) hangs
> forever at maven-shade-plugin:3.2.1 shade:shade goal.
> Env
> {noformat}
> $ ~/bin/maven/apache-maven-4.0.0-alpha-1-SNAPSHOT/bin/mvn -v
> Apache Maven 4.0.0-alpha-1-SNAPSHOT (ab20190a1a9fecdc8f85b40e8d03d806f3da4fc6)
> Maven home: /home/cstamas/bin/maven/apache-maven-4.0.0-alpha-1-SNAPSHOT
> Java version: 1.8.0_282, vendor: AdoptOpenJDK, runtime:
> /usr/lib/jvm/adoptopenjdk-8-hotspot-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.8.0-43-generic", arch: "amd64", family: "unix"
> {noformat}
> JStack shows this:
> {{"main" #1 prio=5 os_prio=0 tid=0x7fa84000b000 nid=0x9846 runnable
> [0x7fa84634d000]"main" #1 prio=5 os_prio=0 tid=0x7fa84000b000
> nid=0x9846 runnable [0x7fa84634d000] java.lang.Thread.State: RUNNABLE
> at
> org.jdom2.output.support.AbstractFormattedWalker.next(AbstractFormattedWalker.java:465)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:925)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printElement(AbstractXMLOutputProcessor.java:868)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:946)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printElement(AbstractXMLOutputProcessor.java:868)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:946)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printElement(AbstractXMLOutputProcessor.java:868)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:946)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printElement(AbstractXMLOutputProcessor.java:868)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printContent(AbstractXMLOutputProcessor.java:946)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printElement(AbstractXMLOutputProcessor.java:868)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.printDocument(AbstractXMLOutputProcessor.java:533)
> at
> org.jdom2.output.support.AbstractXMLOutputProcessor.process(AbstractXMLOutputProcessor.java:191)
> at org.jdom2.output.XMLOutputter.output(XMLOutputter.java:822) at
> org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2159)
> at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at
> org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049)
> at
> org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978)
> at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:151)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:115)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:79)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:64)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:131)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:338) at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:217) at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:130) at
> org.apache.maven.cli.MavenCli.execute(MavenCli.java:980) at
> org.apache.maven.cli.MavenCli.doMain(MavenCli.java:294) at
> org.apache.maven.cli.MavenCli.main(MavenCli.java:198) at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java
[GitHub] [maven] hboutemy commented on a change in pull request #651: [MNG-7264] refactor packaging bindings providers to ease maintenance
hboutemy commented on a change in pull request #651:
URL: https://github.com/apache/maven/pull/651#discussion_r779733342
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java
##
@@ -22,50 +22,40 @@
import java.util.Collections;
import java.util.HashMap;
-import javax.inject.Inject;
-import javax.inject.Named;
import javax.inject.Provider;
-import javax.inject.Singleton;
import org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping;
import org.apache.maven.lifecycle.mapping.Lifecycle;
import org.apache.maven.lifecycle.mapping.LifecycleMapping;
import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-@Named( "pom" )
-@Singleton
-public final class PomLifecycleMappingProvider
+/**
+ * Base lifecycle mapping provider, ie per-packaging plugin bindings for
{@code default} lifecycle.
+ */
+public abstract class AbstractLifecycleMappingProvider
implements Provider
{
- private final LifecycleMapping lifecycleMapping;
-
- @Inject
- public PomLifecycleMappingProvider()
- {
-HashMap lifecyclePhases = new HashMap<>();
-lifecyclePhases.put(
-"install",
-new LifecyclePhase(
"org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install" )
-);
-lifecyclePhases.put(
-"deploy",
-new LifecyclePhase(
"org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy" )
-);
-
-Lifecycle lifecycle = new Lifecycle();
-lifecycle.setId( "default" );
-lifecycle.setLifecyclePhases( Collections.unmodifiableMap( lifecyclePhases
) );
-
-this.lifecycleMapping = new DefaultLifecycleMapping(
-Collections.singletonList(
-lifecycle
-)
-);
- }
-
- @Override
- public LifecycleMapping get()
- {
-return lifecycleMapping;
- }
+private final LifecycleMapping lifecycleMapping;
+
+protected AbstractLifecycleMappingProvider( String[] pluginBindings )
Review comment:
previously, everything was pure XML parsing: Tamasz switched to Provider
code, but still using old `new LifecyclePhase( String )` that parses (and
splits on comma if there are multiple bindings).
So we're going step by step from Plexus XML to perfectly maintainable code
(and maintainable code will match the documentation objective: code before this
PR is just not readable for documentation, then is not maintainable either =
what is even more important than documentation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] hboutemy commented on a change in pull request #651: [MNG-7264] refactor packaging bindings providers to ease maintenance
hboutemy commented on a change in pull request #651:
URL: https://github.com/apache/maven/pull/651#discussion_r779733342
##
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java
##
@@ -22,50 +22,40 @@
import java.util.Collections;
import java.util.HashMap;
-import javax.inject.Inject;
-import javax.inject.Named;
import javax.inject.Provider;
-import javax.inject.Singleton;
import org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping;
import org.apache.maven.lifecycle.mapping.Lifecycle;
import org.apache.maven.lifecycle.mapping.LifecycleMapping;
import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-@Named( "pom" )
-@Singleton
-public final class PomLifecycleMappingProvider
+/**
+ * Base lifecycle mapping provider, ie per-packaging plugin bindings for
{@code default} lifecycle.
+ */
+public abstract class AbstractLifecycleMappingProvider
implements Provider
{
- private final LifecycleMapping lifecycleMapping;
-
- @Inject
- public PomLifecycleMappingProvider()
- {
-HashMap lifecyclePhases = new HashMap<>();
-lifecyclePhases.put(
-"install",
-new LifecyclePhase(
"org.apache.maven.plugins:maven-install-plugin:3.0.0-M1:install" )
-);
-lifecyclePhases.put(
-"deploy",
-new LifecyclePhase(
"org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy" )
-);
-
-Lifecycle lifecycle = new Lifecycle();
-lifecycle.setId( "default" );
-lifecycle.setLifecyclePhases( Collections.unmodifiableMap( lifecyclePhases
) );
-
-this.lifecycleMapping = new DefaultLifecycleMapping(
-Collections.singletonList(
-lifecycle
-)
-);
- }
-
- @Override
- public LifecycleMapping get()
- {
-return lifecycleMapping;
- }
+private final LifecycleMapping lifecycleMapping;
+
+protected AbstractLifecycleMappingProvider( String[] pluginBindings )
Review comment:
previously, everything was pure XML parsing: Tamasz switched to Provider
code, but still using old `new LifecyclePhase( String )` that parses (and
splits on comma if there are multiple bindings
so we're going step by step from Plexus XML to perfectly maintainable code
(and maintainable code will match the documentation objective: code before this
PR is just not readable for documentation, then is not maintainable either =
what is even more important than documentation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MNG-6802) FileProfileActivator changes FileProfileActivator.exists which lets flattened resolveCiFriendliesOnly depending fail activating profile
[
https://issues.apache.org/jira/browse/MNG-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-6802:
---
Assignee: Michael Osipov (was: Robert Scholte)
> FileProfileActivator changes FileProfileActivator.exists which lets flattened
> resolveCiFriendliesOnly depending fail activating profile
> ---
>
> Key: MNG-6802
> URL: https://issues.apache.org/jira/browse/MNG-6802
> Project: Maven
> Issue Type: Bug
> Components: Profiles
>Affects Versions: 3.2.2, 3.6.2
>Reporter: Stefan Cordes
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
>
> In my pom.xml I have
>
> {noformat}
> ...
>
>
>cas-mule4-app
>
>
> mule-artifact.json
>
>
> ...{noformat}
>
> which worked fine.
> After switching to ci-friendly pom.xml with revision and flatten the
> published .flattened-pom.xml contains absolute path:
>
> {noformat}
>
> cas-mule4-app
>
>
>
> D:\jenkins\workspace\mulestac-multibranch_mule4-DWHLMU7ZMPDNCYK6LVMSYLB6GODEIQS7CUNRQQVSISU47ME72PRQ\mule-artifact.json
>
>
> {noformat}
>
> (which is the temporary path of our jenkins container)
> and so other projects using that pom.xml as parent will fail to activate the
> profile.
>
> This came in with MNG-1775 or a related issue via adding
> {noformat}
> // replace activation value with interpolated value
> if ( missing )
> {
> file.setMissing( path );
> }
> else
> {
> file.setExists( path );
> }
> {noformat}
> in org.apache.maven.model.profile.activation.FileProfileActivator.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-6802) FileProfileActivator changes FileProfileActivator.exists which lets flattened resolveCiFriendliesOnly depending fail activating profile
[
https://issues.apache.org/jira/browse/MNG-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6802:
Fix Version/s: 3.8.5
(was: 3.8.x-candidate)
> FileProfileActivator changes FileProfileActivator.exists which lets flattened
> resolveCiFriendliesOnly depending fail activating profile
> ---
>
> Key: MNG-6802
> URL: https://issues.apache.org/jira/browse/MNG-6802
> Project: Maven
> Issue Type: Bug
> Components: Profiles
>Affects Versions: 3.2.2, 3.6.2
>Reporter: Stefan Cordes
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
>
> In my pom.xml I have
>
> {noformat}
> ...
>
>
>cas-mule4-app
>
>
> mule-artifact.json
>
>
> ...{noformat}
>
> which worked fine.
> After switching to ci-friendly pom.xml with revision and flatten the
> published .flattened-pom.xml contains absolute path:
>
> {noformat}
>
> cas-mule4-app
>
>
>
> D:\jenkins\workspace\mulestac-multibranch_mule4-DWHLMU7ZMPDNCYK6LVMSYLB6GODEIQS7CUNRQQVSISU47ME72PRQ\mule-artifact.json
>
>
> {noformat}
>
> (which is the temporary path of our jenkins container)
> and so other projects using that pom.xml as parent will fail to activate the
> profile.
>
> This came in with MNG-1775 or a related issue via adding
> {noformat}
> // replace activation value with interpolated value
> if ( missing )
> {
> file.setMissing( path );
> }
> else
> {
> file.setExists( path );
> }
> {noformat}
> in org.apache.maven.model.profile.activation.FileProfileActivator.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-6802) FileProfileActivator changes FileProfileActivator.exists which lets flattened resolveCiFriendliesOnly depending fail activating profile
[
https://issues.apache.org/jira/browse/MNG-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6802:
Fix Version/s: 4.0.0
4.0.0-alpha-1
> FileProfileActivator changes FileProfileActivator.exists which lets flattened
> resolveCiFriendliesOnly depending fail activating profile
> ---
>
> Key: MNG-6802
> URL: https://issues.apache.org/jira/browse/MNG-6802
> Project: Maven
> Issue Type: Bug
> Components: Profiles
>Affects Versions: 3.2.2, 3.6.2
>Reporter: Stefan Cordes
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.x-candidate
>
>
> In my pom.xml I have
>
> {noformat}
> ...
>
>
>cas-mule4-app
>
>
> mule-artifact.json
>
>
> ...{noformat}
>
> which worked fine.
> After switching to ci-friendly pom.xml with revision and flatten the
> published .flattened-pom.xml contains absolute path:
>
> {noformat}
>
> cas-mule4-app
>
>
>
> D:\jenkins\workspace\mulestac-multibranch_mule4-DWHLMU7ZMPDNCYK6LVMSYLB6GODEIQS7CUNRQQVSISU47ME72PRQ\mule-artifact.json
>
>
> {noformat}
>
> (which is the temporary path of our jenkins container)
> and so other projects using that pom.xml as parent will fail to activate the
> profile.
>
> This came in with MNG-1775 or a related issue via adding
> {noformat}
> // replace activation value with interpolated value
> if ( missing )
> {
> file.setMissing( path );
> }
> else
> {
> file.setExists( path );
> }
> {noformat}
> in org.apache.maven.model.profile.activation.FileProfileActivator.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] (MNG-5612) effective pom should not contain file-based profile activation fully interpolated but with limited interpolation like seen during profile activation
[ https://issues.apache.org/jira/browse/MNG-5612 ]
Michael Osipov deleted comment on MNG-5612:
-
was (Author: hudson):
Build failed in Jenkins: Maven TLP » maven-studies » maven-metrics #4
See
https://builds.apache.org/job/maven-box/job/maven-studies/job/maven-metrics/4/
> effective pom should not contain file-based profile activation fully
> interpolated but with limited interpolation like seen during profile
> activation
>
>
> Key: MNG-5612
> URL: https://issues.apache.org/jira/browse/MNG-5612
> Project: Maven
> Issue Type: Bug
> Components: Profiles
>Affects Versions: 3.2.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.2.2
>
>
> mvn help:effective-pom on a pom.xml containing
> {code:xml}
>
>
> ${project.basedir}/pom.xml
>
> {code}
> shows interpolated value, which points to an existing file then is misleading
> but the profile isn't activated since $\{project.basedir} isn't interpreted
> during profile activation
> we added a warning in MNG-5608, but showing the value interpolated exactly as
> done during profile interpolation would be more logic
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven] hboutemy commented on pull request #652: Proposal to change abstract provider
hboutemy commented on pull request #652: URL: https://github.com/apache/maven/pull/652#issuecomment-1006775384 nice improvements, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
