[jira] [Commented] (MINVOKER-283) Change in behaviour with maven 3.8.2, invoker plugin is trying to install its parent

2023-02-17 Thread Delany (Jira)


[ 
https://issues.apache.org/jira/browse/MINVOKER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690703#comment-17690703
 ] 

Delany commented on MINVOKER-283:
-

Broken in 3.5.0 (Maven 3.9.0)

[https://github.com/delanym/MINVOKER-283.git]

New ticket?

> Change in behaviour with maven 3.8.2, invoker plugin is trying to install its 
> parent
> 
>
> Key: MINVOKER-283
> URL: https://issues.apache.org/jira/browse/MINVOKER-283
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.1, 3.2.2
> Environment: mvn -f pom.xml -s /maven/settings.xml --version
> Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f)
> Maven home: /usr/local/Cellar/maven/3.8.2/libexec
> Java version: 16.0.2, vendor: Homebrew, runtime: 
> /usr/local/Cellar/openjdk/16.0.2/libexec/openjdk.jdk/Contents/Home
> Default locale: en_NZ, platform encoding: UTF-8
> OS name: "mac os x", version: "11.5.2", arch: "x86_64", family: "mac"
>Reporter: Jonathan Tew
>Priority: Major
>
> When running maven 3.8.2, the integration test phase attempts the 
> installation of the parent.
>  
> It fails when its already present in the respository.
>  
> This is a change in behaviour from running on maven 3.8.1.
> h2. maven 3.8.2
>  
> [*INFO*] *---* maven-invoker-plugin:3.2.1:install *(...integration-test)* @ 
> something-v3 *---*
> [*INFO*] Installing 
> /..blah../maven/repository/blah/blah-parent/2.10/blah-parent-2.10.pom to 
> /..blah../maven/repository/blah/blah-parent/2.10/blah-parent-2.10.pom
> [*INFO*] 
> **
> [*INFO*] *BUILD FAILURE*
> [*INFO*] 
> **
> [*INFO*] Total time:  8.758 s
> [*INFO*] Finished at: 2021-08-27T09:48:34+12:00
> [*INFO*] 
> **
> [*INFO*] Totally detected 0 potential finishing task(s)
> [*ERROR*] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.2.1:install 
> *(...integration-test)* on project something-v3: *Failed to install project 
> parents: MavenProject: something:something-v3:1.999-SNAPSHOT @ 
> something-v3/pom.xml*: Failed to install POM: MavenProject: 
> blah:blah-parent:2.10 @ 
> /..blah../maven/repository/blah/blah-parent/2.10/blah-parent-2.10.pom: Failed 
> to install artifact: blah:blah-parent:pom:2.10: Failed to install artifact 
> blah:blah-parent:pom:2.10: cannot install 
> /..blah../maven/repository/blah/blah-parent/2.10/blah-parent-2.10.pom to same 
> path -> *[Help 1]*
>  
>  
>  
> h2. maven 3.8.1
> [*INFO*] *---* maven-invoker-plugin:3.2.1:integration-test 
> *(integration-test)* @ something-v3 *---*
> [*INFO*] Building: *sanity/pom.xml*
> [*INFO*] Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> [*INFO*] Maven home: /usr/local/Cellar/maven/3.8.1
> [*INFO*] Java version: 16.0.2, vendor: Homebrew, runtime: 
> /usr/local/Cellar/openjdk/16.0.2/libexec/openjdk.jdk/Contents/Home
> [*INFO*] Default locale: en_NZ, platform encoding: UTF-8
> [*INFO*] OS name: "mac os x", version: "11.5.2", arch: "x86_64", family: "mac"
> [*INFO*] [INFO] Error stacktraces are turned on.
> [*INFO*] [INFO] Scanning for projects...
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MBUILDCACHE-46) Add maven.build.cache.remote.enabled parameter

2023-02-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690701#comment-17690701
 ] 

ASF GitHub Bot commented on MBUILDCACHE-46:
---

olamy commented on PR #43:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/43#issuecomment-1435495745

   if remote cache is enabled/disabled via configuration does this correctly 
override it? 
   @gnodet  I wonder in configuring remote url via cli would be useful as well?




> Add maven.build.cache.remote.enabled parameter
> --
>
> Key: MBUILDCACHE-46
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-46
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.1
>
>
> PR https://github.com/apache/maven-build-cache-extension/pull/43



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-build-cache-extension] olamy commented on pull request #43: [MBUILDCACHE-46] Add maven.build.cache.remote.enabled parameter

2023-02-17 Thread via GitHub


olamy commented on PR #43:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/43#issuecomment-1435495745

   if remote cache is enabled/disabled via configuration does this correctly 
override it? 
   @gnodet  I wonder in configuring remote url via cli would be useful as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MBUILDCACHE-46) Add maven.build.cache.remote.enabled parameter

2023-02-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690700#comment-17690700
 ] 

ASF GitHub Bot commented on MBUILDCACHE-46:
---

olamy commented on PR #43:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/43#issuecomment-1435494583

   created here https://issues.apache.org/jira/browse/MBUILDCACHE-46




> Add maven.build.cache.remote.enabled parameter
> --
>
> Key: MBUILDCACHE-46
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-46
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 1.0.1
>
>
> PR https://github.com/apache/maven-build-cache-extension/pull/43



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-46) Add maven.build.cache.remote.enabled parameter

2023-02-17 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated MBUILDCACHE-46:
--
Labels: pull-request-available  (was: )

> Add maven.build.cache.remote.enabled parameter
> --
>
> Key: MBUILDCACHE-46
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-46
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.1
>
>
> PR https://github.com/apache/maven-build-cache-extension/pull/43



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-build-cache-extension] olamy commented on pull request #43: [MBUILDCACHE-46] Add maven.build.cache.remote.enabled parameter

2023-02-17 Thread via GitHub


olamy commented on PR #43:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/43#issuecomment-1435494583

   created here https://issues.apache.org/jira/browse/MBUILDCACHE-46


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MBUILDCACHE-46) Add maven.build.cache.remote.enabled parameter

2023-02-17 Thread Olivier Lamy (Jira)
Olivier Lamy created MBUILDCACHE-46:
---

 Summary: Add maven.build.cache.remote.enabled parameter
 Key: MBUILDCACHE-46
 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-46
 Project: Maven Build Cache Extension
  Issue Type: Improvement
Reporter: Olivier Lamy
Assignee: Olivier Lamy
 Fix For: 1.0.1


PR https://github.com/apache/maven-build-cache-extension/pull/43



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MPOM-346) publish SBOM on release

2023-02-17 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690672#comment-17690672
 ] 

Herve Boutemy edited comment on MPOM-346 at 2/18/23 1:56 AM:
-

done in 
https://github.com/apache/maven-parent/commit/186959e88b02936e6a8ecb9f4a2d5e2509958ac8
 for Maven Parent
later upgraded to 2.7.5 in 
https://github.com/apache/maven-parent/commit/a20cb32384b3434ba9aee8f62c2b9f28fee45266
and verbose output disabled in 
https://github.com/apache/maven-parent/commit/005d7d1306b0cf63901142e0d732a5f20139b423


was (Author: hboutemy):
done in 
https://github.com/apache/maven-parent/commit/186959e88b02936e6a8ecb9f4a2d5e2509958ac8
 for Maven Parent

> publish SBOM on release
> ---
>
> Key: MPOM-346
> URL: https://issues.apache.org/jira/browse/MPOM-346
> Project: Maven POMs
>  Issue Type: New Feature
>  Components: asf
>Affects Versions: ASF-27, MAVEN-39, ASF-29
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-40
>
>
> like done in commons-parent https://github.com/apache/commons-parent/pull/122
> with discussions 
> https://lists.apache.org/thread/kvdz39t5wndojbtqqn84smm51rt89fnx and 
> https://lists.apache.org/thread/l8661o0t1r8498bhy01wdwg1s2kkhogy
> leading to ASF draft strategy 
> https://cwiki.apache.org/confluence/display/COMDEV/SBOM



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPOM-346) publish SBOM on release

2023-02-17 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690672#comment-17690672
 ] 

Herve Boutemy commented on MPOM-346:


done in 
https://github.com/apache/maven-parent/commit/186959e88b02936e6a8ecb9f4a2d5e2509958ac8
 for Maven Parent

> publish SBOM on release
> ---
>
> Key: MPOM-346
> URL: https://issues.apache.org/jira/browse/MPOM-346
> Project: Maven POMs
>  Issue Type: New Feature
>  Components: asf
>Affects Versions: ASF-27, MAVEN-39, ASF-29
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-40
>
>
> like done in commons-parent https://github.com/apache/commons-parent/pull/122
> with discussions 
> https://lists.apache.org/thread/kvdz39t5wndojbtqqn84smm51rt89fnx and 
> https://lists.apache.org/thread/l8661o0t1r8498bhy01wdwg1s2kkhogy
> leading to ASF draft strategy 
> https://cwiki.apache.org/confluence/display/COMDEV/SBOM



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7197) Simplify exit code handling in Windows command startup script

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7197:

Fix Version/s: 3.8.x-candidate
   3.9.1-candidate

> Simplify exit code handling in Windows command startup script
> -
>
> Key: MNG-7197
> URL: https://issues.apache.org/jira/browse/MNG-7197
> Project: Maven
>  Issue Type: Task
>  Components: Command Line
>Affects Versions: 3.8.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.1-candidate, 4.0.0-alpha-2, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7674) Windows mvn.cmd should call cmd.exe explicitly

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7674:

Affects Version/s: 3.9.0

> Windows mvn.cmd should call cmd.exe explicitly
> --
>
> Key: MNG-7674
> URL: https://issues.apache.org/jira/browse/MNG-7674
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.8.6, 3.8.7, 3.9.0
>Reporter: Fei Dai
>Priority: Trivial
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Summary:
> As I saw in 3.8.6, on Windows, in mvn.cmd, line 200, it starts with:
> {code:java}
> cmd /C... {code}
>  
> It can reach the system "cmd.exe" correctly most of the time.
> However, in one of my project root directory, I accidently made a "cmd.bat", 
> which is used by eclipse to enter the project directory quickly. Then the 
> above quoted code will hit my code instead of the expected one.
> 
> Steps to reproduce problem:
> in the root directory of a maven project, create cmd.bat, with 1-line content
> {code:java}
> cmd /k cd %~dp0 {code}
> If running it from eclipse, because eclipse run it from 
> "C:\windows\system32", it will correctly open the command-line.
> If running "mvn" in the root directory, with current line 200, the mvn.cmd 
> will go into this cmd.bat, and it will then enter itself, and cause infinite 
> loop.
> This problem might not be that easy to locate, because after writing that 
> cmd.bat, it works as expected in Eclipse. At the same time, when mvn.bat goes 
> into infinite loop, there's no special prompt, and all works of mvn.bat are 
> done already.
> 
> Recommended fix:
> In that line 200, change it to start with:
> {code:java}
> cmd.exe /C...{code}
> by adding ".exe"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-doxia-sitetools] dependabot[bot] opened a new pull request, #90: Bump apache/maven-gh-actions-shared from 2 to 3

2023-02-17 Thread via GitHub


dependabot[bot] opened a new pull request, #90:
URL: https://github.com/apache/maven-doxia-sitetools/pull/90

   Bumps 
[apache/maven-gh-actions-shared](https://github.com/apache/maven-gh-actions-shared)
 from 2 to 3.
   
   Commits
   
   https://github.com/apache/maven-gh-actions-shared/commit/101cb08f66a0b3be6e2113675cc30e9f03d13db1;>101cb08
 Switch to Maven 3.9.0
   https://github.com/apache/maven-gh-actions-shared/commit/9073820ea078880a0f4edc7ce2000ea4ade4;>907
 Switch to Maven 3.9.0
   https://github.com/apache/maven-gh-actions-shared/commit/2017ef85117901461707b842c5278c5b97145817;>2017ef8
 Bump release-drafter/release-drafter from 5.21.1 to 5.22.0
   https://github.com/apache/maven-gh-actions-shared/commit/f8899b22048c2d119df764ac6b6113d79bd6ccdc;>f8899b2
 Use Maven 3.8.7 for builds as default
   https://github.com/apache/maven-gh-actions-shared/commit/201a323ee6ea58a2bb0be8812d58f935eafe71f1;>201a323
 Bump release-drafter/release-drafter from 5.21.0 to 5.21.1
   https://github.com/apache/maven-gh-actions-shared/commit/4235ab01b21870fa59a7419b3165674b157cc082;>4235ab0
 Bump release-drafter/release-drafter from 5.20.1 to 5.21.0
   https://github.com/apache/maven-gh-actions-shared/commit/94393bdffbcd9f8ba6c836a5089377dd90446a5c;>94393bd
 Bump release-drafter/release-drafter from 5.20.0 to 5.20.1
   https://github.com/apache/maven-gh-actions-shared/commit/5c6d8aa5e7ba76cf86e74c2e6ec29782af752da0;>5c6d8aa
 add a clean to ensure we do not lock files for a windows build (https://github-redirect.dependabot.com/apache/maven-gh-actions-shared/issues/55;>#55)
   https://github.com/apache/maven-gh-actions-shared/commit/1c7666c6b750fea498ce3532cb3aef45cfab3ea2;>1c7666c
 Upload on failure - fix path variable
   See full diff in https://github.com/apache/maven-gh-actions-shared/compare/v2...v3;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=apache/maven-gh-actions-shared=github_actions=2=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7376) Maven artifact caching breaks in context of Jenkins Artifactory Plugin

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690661#comment-17690661
 ] 

Michael Osipov commented on MNG-7376:
-

Did 3.8.3 work for you? If yes, can you identify the commit which broke it for 
you?

> Maven artifact caching breaks in context of Jenkins Artifactory Plugin
> --
>
> Key: MNG-7376
> URL: https://issues.apache.org/jira/browse/MNG-7376
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.4
> Environment: Jenkins, Docker image based on upstream maven:3.8 image, 
> JFrog Artifactory as artifact proxy
>Reporter: Christian Frommeyer
>Priority: Major
>
> We recently run into a build issue after a library update. While local builds 
> would still work as expected, builds on our build machine would cause 
> reproducible failures. The actual failure happens during site-reports are 
> generated in the surefire report plugin but I believe the actual place is 
> just a coincidence.
> Unfortunately I wasn't able to find the trigger for the changed behavior. All 
> we did was update the version of pact-jvm in the pom. Before the change no 
> failure after the change every build fails. As this is proprietary code base 
> I unfortunately currently cannot provide a sample project. However there is a 
> couple of information I was able to find:
> As there is little related logging even on debug level I had a look at the 
> code. Using the stacktrace from the Jenkins log this pointed 
> [here|https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/project/artifact/DefaultProjectArtifactsCache.java#L207].
>  Complaining about a re-caching of the project artifacts.
> Looking at the calling code [here 
> |https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java#L147]
>  this doesn't seems to be possible. As the Cache-put is only called after the 
> Cache-get returns {{{}null{}}}. This would only be the case if the cache was 
> behaving incorrect (it's backed by a Java Concurrent HashMap, so pretty 
> unlikely), or the key is not behaving as expected.
> Looking at the 
> [CacheKey|https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/project/artifact/DefaultProjectArtifactsCache.java#L58]
>  reveals that this key in fact has been crafted to explicitly make it behave 
> nicely. Most fields are immutable. However there is a small set of 
> (potentially) mutable fields that would alter hashcode and equals result. If 
> e.g. the RemoteRepositories stored in the {{repositories}} property would be 
> altered this would change hashcode and equals. While the property is 
> {{final}} and the constructor assures that it contains a fresh ArrayList, 
> this is neither unmodifiable, nor are the repositories added to the list 
> immutable.
> To be sure I created a java-agent to monitor the behavior. I logged the key 
> for both {{get}} and {{put}} and actually found different URLs for the 
> repositories. Apparently the Jenkins-Artifactory-Plugin had changed them. And 
> actually looking at the debug log there are log lines saying _Replacing 
> resolution repository URL..._.
> While this seems to happen very rarely it happens and if it does it's not fun 
> debugging. I still don't know why it only happens rarely as I assume the 
> plugin does rewrite the URLs always. But maybe there is only rare cases where 
> the cache actually has data.
> This are the updated artifacts:
> {code:xml}
> 
> 
> au.com.dius.pact.consumer
> junit5
> ${pact.version}
> test
> 
> 
> au.com.dius.pact.provider
> junit5spring
> ${pact.version}
> test
> 
> 
> 
> 
> au.com.dius.pact.provider
> maven
> ${pact.version}
> 
> 
> {code}
> The variable {{pact.version}} changed from 4.2.14 to 4.3.11



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7183) Plugin declaration silently ignored if groupId uses property references

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690660#comment-17690660
 ] 

Michael Osipov commented on MNG-7183:
-

[~gnodet], gentle reminder.

> Plugin declaration silently ignored if groupId uses property references
> ---
>
> Key: MNG-7183
> URL: https://issues.apache.org/jira/browse/MNG-7183
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build, Inheritance and Interpolation
>Affects Versions: 3.6.2, 3.6.3, 3.8.1
>Reporter: Martin D'Aloia
>Priority: Minor
> Attachments: bug-example.zip
>
>
> Declaring a plugin where its {{}} value is/contains a property 
> reference ({{$\{example}}}) is silently ignored and no error is thrown since 
> Maven 3.6.2 (worked on 3.6.1).
> *Actual behavior:*
>  - Plugin configuration silently ignored
> *Expected behavior:*
>  - Work as in 3.6.1, or
>  - Produce an error if such config is not allowed
> *Workaround:*
>  * Use a static value for the  without property references
> *Suspecting root cause:*
>  * MNG-6697
> Attached you could find a self-contained example using the 
> {{maven-clean-plugin}} (but also happens with third-party plugins).
>  To ease the comparison, this has 2 profiles: one declares the value 
> explicitly and the other (indirect) via a property reference.
> Execute it as: {{./run.sh}}
>  and you will get at the end:
> {noformat}
> ./out/maven-3.8.1-profile-indirect.log:[INFO] --- 
> maven-clean-plugin:2.5:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.8.1-profile-indirect.log:[DEBUG] (f) skip = false
> ./out/maven-3.8.1-profile-explicit.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.8.1-profile-explicit.log:[DEBUG] (f) skip = true
> ./out/maven-3.6.3-profile-indirect.log:[INFO] --- 
> maven-clean-plugin:2.5:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.3-profile-indirect.log:[DEBUG] (f) skip = false
> ./out/maven-3.6.3-profile-explicit.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.3-profile-explicit.log:[DEBUG] (f) skip = true
> ./out/maven-3.6.2-profile-indirect.log:[INFO] --- 
> maven-clean-plugin:2.5:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.2-profile-indirect.log:[DEBUG] (f) skip = false
> ./out/maven-3.6.2-profile-explicit.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.2-profile-explicit.log:[DEBUG] (f) skip = true
> ./out/maven-3.6.1-profile-indirect.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.1-profile-indirect.log:[DEBUG] (f) skip = true
> ./out/maven-3.6.1-profile-explicit.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.1-profile-explicit.log:[DEBUG] (f) skip = true
> {noformat}
> Here you could see that the plugin version (2.5) and skip (false) 
> configuration isn't what was configured for {{indirect}} profile.
> Another example, defining a base config as {{}}, it is also 
> ignoring the specific {{}} on {{}} usage.
> Execute it as: {{./run.sh pom-pluginManagement.xml}}
>  and you will get at the end:
> {noformat}
> ./out/maven-3.8.1-profile-indirect.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.8.1-profile-indirect.log:[DEBUG] (f) skip = false
> ./out/maven-3.8.1-profile-explicit.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.8.1-profile-explicit.log:[DEBUG] (f) skip = true
> ./out/maven-3.6.3-profile-indirect.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.3-profile-indirect.log:[DEBUG] (f) skip = false
> ./out/maven-3.6.3-profile-explicit.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.3-profile-explicit.log:[DEBUG] (f) skip = true
> ./out/maven-3.6.2-profile-indirect.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.2-profile-indirect.log:[DEBUG] (f) skip = false
> ./out/maven-3.6.2-profile-explicit.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.2-profile-explicit.log:[DEBUG] (f) skip = true
> ./out/maven-3.6.1-profile-indirect.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.1-profile-indirect.log:[DEBUG] (f) skip = true
> ./out/maven-3.6.1-profile-explicit.log:[INFO] --- 
> maven-clean-plugin:3.1.0:clean (default-clean) @ maven-bug-example ---
> ./out/maven-3.6.1-profile-explicit.log:[DEBUG] 

[jira] [Updated] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-5222:

Fix Version/s: (was: 3.8.x-candidate)

> Maven 3 no longer logs warnings about deprecated plugin parameters.
> ---
>
> Key: MNG-5222
> URL: https://issues.apache.org/jira/browse/MNG-5222
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.0.3
>Reporter: Christian Schulte
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Providing a value for a deprecated plugin parameter, Maven 2.2.1 used to log 
> a warning. Currently Maven 3 does not.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MNG-7701) Incompatible version sorting changes

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690643#comment-17690643
 ] 

Michael Osipov edited comment on MNG-7701 at 2/17/23 11:27 PM:
---

Yeah, this is really really ugly. No spec and no real docs.
Can you describe how this affects you with 3.8.x?


was (Author: michael-o):
Yeah, this is really really ugly. No spec and not real docs.
Can you describe how this affects you with 3.8.x?

> Incompatible version sorting changes
> 
>
> Key: MNG-7701
> URL: https://issues.apache.org/jira/browse/MNG-7701
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> Between 3.8.6 and 3.8.7, the sorting of a variety of version strings has 
> changed. This table captures the observed relations:
> ||Input 1||3.8.6||3.8.7||Input 2||
> |{{0.x}}|{{>}}|{{==}}|{{0-x}}|
> |{{1.x}}|{{<}}|{{==}}|{{1-x}}|
> |{{1.x}}|{{<}}|{{>}}|{{1_y}}|
> |{{1.y}}|{{<}}|{{>}}|{{1_x}}|
> |{{1-alpha}}|{{>}}|{{==}}|{{1.alpha}}|



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690648#comment-17690648
 ] 

Michael Osipov commented on MNG-7353:
-

Fixed with 
[5c0315193900bc2616aa943e07d086f967ef0b4b|https://gitbox.apache.org/repos/asf?p=maven.git=commit=5c0315193900bc2616aa943e07d086f967ef0b4b]
 for {{maven-3.8.x}} branch.

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7451 #6

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7451/6/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-776 #4

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-776/4/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7699) Remove all Maven 3.9.0+ ITs from maven-3.8.x branch

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7699:

Description: 
These are skipped and cannot be executed on {{maven-3.8.x}} branch anyway:
{noformat}
$ grep SKIPPED skipped  | grep -e 3.9.0 -e 4.0
mng7474 SessionScope.SessionScope().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7443 
ConsistencyOfOptionalProjectsAndProfiles.ConsistentLoggingOfOptionalProfilesAndProjects()
 SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7504 NotWarnUnsupportedReportPlugins.WarnNotPresent(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,3.9.0]
mng7468 UnsupportedPluginsParameters.ValidParameterAlias()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InPluginManagement() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InBuildMixed().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InBuildExecution().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.ValidParameter() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.WithForkedGoalExecution() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.NoConfiguration()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InPluginManagementParent() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.ValidParameterForOtherGoal() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InBuildPlugin(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7470 ResolverTransport.ResolverTransportDefault(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7470 ResolverTransport.ResolverTransportNative().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7470 ResolverTransport.ResolverTransportWagon()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7464 ReadOnlyMojoParametersWarning.ReadOnlyProperty(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7464 ReadOnlyMojoParametersWarning.ReadOnlyConfig()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7464 ReadOnlyMojoParametersWarning.EmptyConfiguration()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7404 IgnorePrefixlessExpressions.IgnorePrefixlessExpressions() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng5222 MojoDeprecated.DeprecatedProperty().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng5222 MojoDeprecated.DeprecatedConfig() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng5222 MojoDeprecated.EmptyConfiguration().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7390 SelectModuleOutsideCwd.SelectModuleByRelativePath().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7390 SelectModuleOutsideCwd.SelectMultipleModulesByCoordinate() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7390 
SelectModuleOutsideCwd.SelectModulesOutsideCwdDoesNotWorkWhenDotMvnIsNotPresent()
 SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7390 SelectModuleOutsideCwd.SelectModulesByRelativePath(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7390 SelectModuleOutsideCwd.SelectModuleByCoordinate() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7244 IgnorePomPrefixInExpressions.IgnorePomPrefixInExpressions() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng4463 DependencyManagementImportVersionRanges.FailureWithoutUpperBound() 
SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng4463 
DependencyManagementImportVersionRanges.ExclusiveUpperBoundResolvesToHighestVersion()
 SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng4463 
DependencyManagementImportVersionRanges.InclusiveUpperBoundResolvesToHighestVersion()
 SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7112 ProjectsWithNonRecursive.AggregatesCanBeDeselectedNonRecursively() 
SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7112 ProjectsWithNonRecursive.AggregatesCanBeBuiltNonRecursively() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng6511 OptionalProjectSelection.DeselectExistingOptionalProfile() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)

[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build failed in Jenkins: Maven » Maven TLP » maven » master #72

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/72/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #56

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/56/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build unstable in Jenkins: Maven » Maven TLP » maven » PR-394 #19

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-394/19/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #78

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/78/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #63

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/63/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #82

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/82/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #60

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/60/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7353:

Fix Version/s: 3.8.8

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build unstable in Jenkins: Maven » Maven TLP » maven » PR-791 #4

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-791/4/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7353 ]


Michael Osipov deleted comment on MNG-7353:
-

was (Author: hudson):
Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #42

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/42/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-529) Improve the docs about usage 1.8 vs. 8 for source/target

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690647#comment-17690647
 ] 

Michael Osipov commented on MCOMPILER-529:
--

This isn't mentioned in the ticket.

> Improve the docs about usage 1.8 vs. 8 for source/target
> 
>
> Key: MCOMPILER-529
> URL: https://issues.apache.org/jira/browse/MCOMPILER-529
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Affects Versions: 3.10.1
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> The current descriptions/docs only mentioned the usage of {{1.8}} for 
> source/target. But it looks like I can use also {{8}} instead. But all the 
> examples on the usage page etc. using {{1.8}}... even the error message tells 
> me to do:
> {{code}}
> use -source 8 ...
> {{code}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-529) Improve the docs about usage 1.8 vs. 8 for source/target

2023-02-17 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690644#comment-17690644
 ] 

Slawomir Jaranowski commented on MCOMPILER-529:
---

but {{release}} options support only *8*

> Improve the docs about usage 1.8 vs. 8 for source/target
> 
>
> Key: MCOMPILER-529
> URL: https://issues.apache.org/jira/browse/MCOMPILER-529
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Affects Versions: 3.10.1
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> The current descriptions/docs only mentioned the usage of {{1.8}} for 
> source/target. But it looks like I can use also {{8}} instead. But all the 
> examples on the usage page etc. using {{1.8}}... even the error message tells 
> me to do:
> {{code}}
> use -source 8 ...
> {{code}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7701) Incompatible version sorting changes

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690643#comment-17690643
 ] 

Michael Osipov commented on MNG-7701:
-

Yeah, this is really really ugly. No spec and not real docs.
Can you describe how this affects you with 3.8.x?

> Incompatible version sorting changes
> 
>
> Key: MNG-7701
> URL: https://issues.apache.org/jira/browse/MNG-7701
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> Between 3.8.6 and 3.8.7, the sorting of a variety of version strings has 
> changed. This table captures the observed relations:
> ||Input 1||3.8.6||3.8.7||Input 2||
> |{{0.x}}|{{>}}|{{==}}|{{0-x}}|
> |{{1.x}}|{{<}}|{{==}}|{{1-x}}|
> |{{1.x}}|{{<}}|{{>}}|{{1_y}}|
> |{{1.y}}|{{<}}|{{>}}|{{1_x}}|
> |{{1-alpha}}|{{>}}|{{==}}|{{1.alpha}}|



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-324) Make the BF algorithm as the default option to speed up maven dependency resolution and downloading

2023-02-17 Thread Steven Schlansker (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690641#comment-17690641
 ] 

Steven Schlansker commented on MRESOLVER-324:
-

Wow. We tried out the BF changes in our full rebuild pipeline, and the download 
set was 2.9GB before with DF and only 900MB with BF! I almost don't believe how 
much better it is...

If no regressions are found, BF should be the new default!

> Make the BF algorithm as the default option to speed up maven dependency 
> resolution and downloading
> ---
>
> Key: MRESOLVER-324
> URL: https://issues.apache.org/jira/browse/MRESOLVER-324
> Project: Maven Resolver
>  Issue Type: Wish
>  Components: Resolver
>Affects Versions: 1.10.0
>Reporter: wei cai
>Priority: Major
>
> This is a WISH type Jira :D. So far, Maven 3.9.0 has released a BF algorithm 
> which includes changes from below JIRAs along with the DF option (default).
>  * MRESOLVER-228
>  * MRESOLVER-247
>  * MRESOLVER-7
> The BF algorithm solves:
>  * Cache missing issue when comes to resolve heavy dependencies with 
> different exclusions, it can help speed up dependency resolution especially 
> for large scale enterprise level projects.
>  * Improve download speed by:
>  ** Skip downloading poms for conflict losers.
>  ** Download poms in parallel.
> Below is the introduction in 
> [https://maven.apache.org/docs/3.9.0/release-notes.html:]
> {noformat}
> Choice of resolver collectors: a new BF collector (with parallel POM 
> downloads) has been added along the existing DF one.{noformat}
> The solution is already widely adopted at eBay. You can simply enable it by 
> putting below config item into file: ${maven.projectBasedir}/.mvn/maven.config
> {code:java}
> aether.dependencyCollector.impl=bf {code}
> More introduction about this option: 
> [https://maven.apache.org/resolver/configuration.html]
> Please try and tells us how much it helps by running:
> {code:java}
> 1. mvn clean install -DskipTests -Dmaven.repo.local=bf 
> -Daether.dependencyCollector.impl=bf 
> 2. mvn clean install -DskipTests -Dmaven.repo.local=df{code}
> With more feedback collected, we would be able to propose the changes to 
> Maven team to make BF as the default.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MNGSITE-510) guides/plugin/guide-java-plugin-development.html links incorrect

2023-02-17 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MNGSITE-510.
---
Resolution: Fixed

Done.

> guides/plugin/guide-java-plugin-development.html links incorrect
> 
>
> Key: MNGSITE-510
> URL: https://issues.apache.org/jira/browse/MNGSITE-510
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: James Nord
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> the page 
> https://maven.apache.org/guides/plugin/guide-java-plugin-development.html has 
> various links in the introduction section - yet many of them lead to a 404.
> on inspection it looks like they should be referencing the named anchors in 
> the current page but instead are not.
> e.g.
> Your First Plugin -> https://maven.apache.org/guides/plugin/Your_First_Plugin
> should probably be 
> https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#your-first-plugin



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-site] slawekjaranowski merged pull request #385: Refresh - Guide to Developing Java Plugins

2023-02-17 Thread via GitHub


slawekjaranowski merged PR #385:
URL: https://github.com/apache/maven-site/pull/385


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7501) display relative path to pom.xml

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690638#comment-17690638
 ] 

Michael Osipov commented on MNG-7501:
-

Fixed with 
[47bf22022d79a611cdbecc49cc2fa51d84306835|https://gitbox.apache.org/repos/asf?p=maven.git=commit=64da2c58243bc6f48827301b744b9f6312497550]
 for {{maven-3.8.x}} branch.

> display relative path to pom.xml
> 
>
> Key: MNG-7501
> URL: https://issues.apache.org/jira/browse/MNG-7501
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.8.6
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> when building large multi-module project, when a failure happens in the 
> middle of the build, it's not easy to even identify where the module is 
> located in the source tree: Maven displays the module name, but not the path 
> to pom.xml. Then often we have to read output log of goals that have run 
> hoping to find a hint
> it would be nice to have by default the path to the pom.xml displayed during 
> Maven run.
> I see 2 options:
> 1. either in the module build header:
> {noformat}
> [INFO] --< org.apache.maven.its.plugins:maven-it-plugin-dependency-resolution 
> >--
> [INFO] Building Maven IT Plugin :: Dependency Resolution 2.1-SNAPSHOT   
> [31/78]
> [INFO] 
> core-it-support/core-it-plugins/maven-it-plugin-dependency-resolution/pom.xml
> [INFO] [ maven-plugin 
> ]
> {noformat}
> 2. or in each goal execution line during the module build:
> {noformat}
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
> maven-it-plugin-dependency-resolution 
> core-it-support/core-it-plugins/maven-it-plugin-dependency-resolution/pom.xml 
> ---
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7501) display relative path to pom.xml

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7501:

Fix Version/s: 3.8.8

> display relative path to pom.xml
> 
>
> Key: MNG-7501
> URL: https://issues.apache.org/jira/browse/MNG-7501
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.8.6
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> when building large multi-module project, when a failure happens in the 
> middle of the build, it's not easy to even identify where the module is 
> located in the source tree: Maven displays the module name, but not the path 
> to pom.xml. Then often we have to read output log of goals that have run 
> hoping to find a hint
> it would be nice to have by default the path to the pom.xml displayed during 
> Maven run.
> I see 2 options:
> 1. either in the module build header:
> {noformat}
> [INFO] --< org.apache.maven.its.plugins:maven-it-plugin-dependency-resolution 
> >--
> [INFO] Building Maven IT Plugin :: Dependency Resolution 2.1-SNAPSHOT   
> [31/78]
> [INFO] 
> core-it-support/core-it-plugins/maven-it-plugin-dependency-resolution/pom.xml
> [INFO] [ maven-plugin 
> ]
> {noformat}
> 2. or in each goal execution line during the module build:
> {noformat}
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
> maven-it-plugin-dependency-resolution 
> core-it-support/core-it-plugins/maven-it-plugin-dependency-resolution/pom.xml 
> ---
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7701) Incompatible version sorting changes

2023-02-17 Thread David M. Lloyd (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690635#comment-17690635
 ] 

David M. Lloyd commented on MNG-7701:
-

Assuming this is intentional, I don't think it is appropriate to change this 
behavior in a micro version. It's nearly impossible to accurately describe the 
Maven version scheme thanks to MNG-6964 and now MNG-7644. Also, I'm thinking 
about this comment: 
https://github.com/apache/maven/pull/930#issuecomment-1363838716

> Incompatible version sorting changes
> 
>
> Key: MNG-7701
> URL: https://issues.apache.org/jira/browse/MNG-7701
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> Between 3.8.6 and 3.8.7, the sorting of a variety of version strings has 
> changed. This table captures the observed relations:
> ||Input 1||3.8.6||3.8.7||Input 2||
> |{{0.x}}|{{>}}|{{==}}|{{0-x}}|
> |{{1.x}}|{{<}}|{{==}}|{{1-x}}|
> |{{1.x}}|{{<}}|{{>}}|{{1_y}}|
> |{{1.y}}|{{<}}|{{>}}|{{1_x}}|
> |{{1-alpha}}|{{>}}|{{==}}|{{1.alpha}}|



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread David M. Lloyd (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David M. Lloyd updated MNG-7700:

Description: 
The canonicalization logic for versions is incorrect.

Using the method {{ComparableVersion#getCanonical}} as in {{new 
ComparableVersion(input).getCanonical()}}, the following results can be 
observed:

||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
|{{1}}|{{1}}|yes|{{1}}|yes|
|{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
|{{0-1}}|{{1}}|no|{{1}}|no|
|{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
|{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
|{{0.x}}|{{0.x}}|yes|{{x}}|no|
|{{0-x}}|{{x}}|no|{{x}}|no|
|{{x}}|{{x}}|yes|{{x}}|yes|
|{{0.rc}}|{{0.rc}}|yes|{{rc}}|no|


The "OK?" columns indicate whether parsing the canonical version string will 
yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
from the original input, i.e. it's internally consistent.

The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
intentional or not, but it is definitely a change.

These canonicalizations seem to have gotten less consistent in the move to 
3.9.0.

  was:
The canonicalization logic for versions is incorrect.

Using the method {{ComparableVersion#getCanonical}} as in {{new 
ComparableVersion(input).getCanonical()}}, the following results can be 
observed:

||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
|{{1}}|{{1}}|yes|{{1}}|yes|
|{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
|{{0-1}}|{{1}}|no|{{1}}|no|
|{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
|{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
|{{0.x}}|{{0.x}}|yes|{{x}}|no|
|{{0-x}}|{{x}}|no|{{x}}|no|
|{{x}}|{{x}}|yes|{{x}}|yes|


The "OK?" columns indicate whether parsing the canonical version string will 
yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
from the original input, i.e. it's internally consistent.

The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
intentional or not, but it is definitely a change.

These canonicalizations seem to have gotten less consistent in the move to 
3.9.0.


> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> |{{0.rc}}|{{0.rc}}|yes|{{rc}}|no|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread David M. Lloyd (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690628#comment-17690628
 ] 

David M. Lloyd commented on MNG-7700:
-

I don't think MNG-7644 covers this one; this is about canonical form. If `0-1` 
is canonically `1`, then `0-1` should equal `1`, but it does not.

The test is like this:

{code:java}
ComparableVersion parsed = new ComparableVersion(str);
ComparableVersion canon = new ComparableVersion(parsed.getCanonical());
boolean ok = parsed.equals(canon) && parsed.compareTo(canon) == 0 && 
canon.compareTo(parsed) == 0;
{code}

For the versions listed with "No" under "OK?", this test does not pass.

> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-resources-plugin] dependabot[bot] opened a new pull request, #46: Bump apache/maven-gh-actions-shared from 2 to 3

2023-02-17 Thread via GitHub


dependabot[bot] opened a new pull request, #46:
URL: https://github.com/apache/maven-resources-plugin/pull/46

   Bumps 
[apache/maven-gh-actions-shared](https://github.com/apache/maven-gh-actions-shared)
 from 2 to 3.
   
   Commits
   
   https://github.com/apache/maven-gh-actions-shared/commit/101cb08f66a0b3be6e2113675cc30e9f03d13db1;>101cb08
 Switch to Maven 3.9.0
   https://github.com/apache/maven-gh-actions-shared/commit/9073820ea078880a0f4edc7ce2000ea4ade4;>907
 Switch to Maven 3.9.0
   https://github.com/apache/maven-gh-actions-shared/commit/2017ef85117901461707b842c5278c5b97145817;>2017ef8
 Bump release-drafter/release-drafter from 5.21.1 to 5.22.0
   https://github.com/apache/maven-gh-actions-shared/commit/f8899b22048c2d119df764ac6b6113d79bd6ccdc;>f8899b2
 Use Maven 3.8.7 for builds as default
   https://github.com/apache/maven-gh-actions-shared/commit/201a323ee6ea58a2bb0be8812d58f935eafe71f1;>201a323
 Bump release-drafter/release-drafter from 5.21.0 to 5.21.1
   https://github.com/apache/maven-gh-actions-shared/commit/4235ab01b21870fa59a7419b3165674b157cc082;>4235ab0
 Bump release-drafter/release-drafter from 5.20.1 to 5.21.0
   https://github.com/apache/maven-gh-actions-shared/commit/94393bdffbcd9f8ba6c836a5089377dd90446a5c;>94393bd
 Bump release-drafter/release-drafter from 5.20.0 to 5.20.1
   https://github.com/apache/maven-gh-actions-shared/commit/5c6d8aa5e7ba76cf86e74c2e6ec29782af752da0;>5c6d8aa
 add a clean to ensure we do not lock files for a windows build (https://github-redirect.dependabot.com/apache/maven-gh-actions-shared/issues/55;>#55)
   https://github.com/apache/maven-gh-actions-shared/commit/1c7666c6b750fea498ce3532cb3aef45cfab3ea2;>1c7666c
 Upload on failure - fix path variable
   See full diff in https://github.com/apache/maven-gh-actions-shared/compare/v2...v3;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=apache/maven-gh-actions-shared=github_actions=2=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (MNGSITE-510) guides/plugin/guide-java-plugin-development.html links incorrect

2023-02-17 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MNGSITE-510:
---

Assignee: Slawomir Jaranowski

> guides/plugin/guide-java-plugin-development.html links incorrect
> 
>
> Key: MNGSITE-510
> URL: https://issues.apache.org/jira/browse/MNGSITE-510
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: James Nord
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> the page 
> https://maven.apache.org/guides/plugin/guide-java-plugin-development.html has 
> various links in the introduction section - yet many of them lead to a 404.
> on inspection it looks like they should be referencing the named anchors in 
> the current page but instead are not.
> e.g.
> Your First Plugin -> https://maven.apache.org/guides/plugin/Your_First_Plugin
> should probably be 
> https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#your-first-plugin



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-site] slawekjaranowski merged pull request #387: Notice about new lines in maven.config

2023-02-17 Thread via GitHub


slawekjaranowski merged PR #387:
URL: https://github.com/apache/maven-site/pull/387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690620#comment-17690620
 ] 

Michael Osipov commented on MNG-7438:
-

Fixed with 
[64da2c58243bc6f48827301b744b9f6312497550|https://gitbox.apache.org/repos/asf?p=maven.git=commit=64da2c58243bc6f48827301b744b9f6312497550]
 for {{maven-3.8.x}} branch.

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7438:

Fix Version/s: 3.8.8
   (was: 3.8.x-candidate)

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7700:

Fix Version/s: (was: waiting-for-feedback)

> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7701) Incompatible version sorting changes

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690619#comment-17690619
 ] 

Michael Osipov commented on MNG-7701:
-

Please check MNG-7644.

> Incompatible version sorting changes
> 
>
> Key: MNG-7701
> URL: https://issues.apache.org/jira/browse/MNG-7701
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> Between 3.8.6 and 3.8.7, the sorting of a variety of version strings has 
> changed. This table captures the observed relations:
> ||Input 1||3.8.6||3.8.7||Input 2||
> |{{0.x}}|{{>}}|{{==}}|{{0-x}}|
> |{{1.x}}|{{<}}|{{==}}|{{1-x}}|
> |{{1.x}}|{{<}}|{{>}}|{{1_y}}|
> |{{1.y}}|{{<}}|{{>}}|{{1_x}}|
> |{{1-alpha}}|{{>}}|{{==}}|{{1.alpha}}|



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690618#comment-17690618
 ] 

Michael Osipov commented on MNG-7700:
-

Please check MNG-7644.

> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread David M. Lloyd (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690617#comment-17690617
 ] 

David M. Lloyd commented on MNG-7700:
-

This is easy to test by hand using [JBang|https://www.jbang.dev/]:


{code}
$ jbang org.apache.maven:maven-artifact:3.8.6 1.x
Display parameters as parsed by Maven (in canonical form and as a list of 
tokens) and comparison result:
1. 1.x -> 1.x; tokens: [1, x]
{code}

{code}
$ jbang org.apache.maven:maven-artifact:3.8.7 1.x
Display parameters as parsed by Maven (in canonical form and as a list of 
tokens) and comparison result:
1. 1.x -> 1-x; tokens: [1, [x]]
{code}


> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7701) Incompatible version sorting changes

2023-02-17 Thread David M. Lloyd (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690615#comment-17690615
 ] 

David M. Lloyd commented on MNG-7701:
-

This is easy to test by hand using [JBang|https://www.jbang.dev/]:


{code}
$ jbang org.apache.maven:maven-artifact:3.8.6 1.alpha 1-alpha
Display parameters as parsed by Maven (in canonical form and as a list of 
tokens) and comparison result:
1. 1.alpha -> 1.alpha; tokens: [1, alpha]
   1.alpha < 1-alpha
2. 1-alpha -> 1-alpha; tokens: [1, [alpha]]
{code}

{code}
$ jbang org.apache.maven:maven-artifact:3.8.7 1.alpha 1-alpha
Display parameters as parsed by Maven (in canonical form and as a list of 
tokens) and comparison result:
1. 1.alpha -> 1-alpha; tokens: [1, [alpha]]
   1.alpha == 1-alpha
2. 1-alpha -> 1-alpha; tokens: [1, [alpha]]
{code}


> Incompatible version sorting changes
> 
>
> Key: MNG-7701
> URL: https://issues.apache.org/jira/browse/MNG-7701
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> Between 3.8.6 and 3.8.7, the sorting of a variety of version strings has 
> changed. This table captures the observed relations:
> ||Input 1||3.8.6||3.8.7||Input 2||
> |{{0.x}}|{{>}}|{{==}}|{{0-x}}|
> |{{1.x}}|{{<}}|{{==}}|{{1-x}}|
> |{{1.x}}|{{<}}|{{>}}|{{1_y}}|
> |{{1.y}}|{{<}}|{{>}}|{{1_x}}|
> |{{1-alpha}}|{{>}}|{{==}}|{{1.alpha}}|



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build unstable in Jenkins: Maven » Maven TLP » maven » PR-509 #14

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-509/14/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-565 #14

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-565/14/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7451 #4

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7451/4/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7448 #2

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7448/2/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-691 #9

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-691/9/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7457/2/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7273 #3

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7273/3/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-600 #14

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-600/14/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #31

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/31/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #17

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/17/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build unstable in Jenkins: Maven » Maven TLP » maven » PR-394 #15

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-394/15/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-721 #2

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-721/2/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7438) add execution id to "Configuring mojo xxx with basic configurator" debug message

2023-02-17 Thread Michael Osipov (Jira)


[ https://issues.apache.org/jira/browse/MNG-7438 ]


Michael Osipov deleted comment on MNG-7438:
-

was (Author: hudson):
Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-720 #3

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-720/3/

> add execution id to "Configuring mojo xxx with basic configurator" debug 
> message
> 
>
> Key: MNG-7438
> URL: https://issues.apache.org/jira/browse/MNG-7438
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.8.5
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-2, 4.0.0
>
>
> currently, when running goals/mojos, we have in debug logs
> {noformat}
> [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
> org.example.apache.maven.execution ---
> [DEBUG] Configuring mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator -->
> [DEBUG]   (s) additionalClasspathElements = []
> [DEBUG]   (s) basedir = /home/herve/tmp/org.example.apache.maven.execution
> {noformat}
> on the "{{Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' with basic 
> configurator}}" line, it completely hides the fact that configuration is 
> valid for an execution id, that has a default value when nobody defined any 
> (see https://maven.apache.org/guides/mini/guide-default-execution-ids.html )
> Just adding "{{execution 'default-test'}}" would make things more clear so 
> people learn about execution ids
> {noformat}
> [DEBUG] Configuring mojo 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test' execution 
> 'default-test' with basic configurator -->
> {noformat}
> h2. final debug messages
> {noformat}
> [DEBUG] Loading mojo 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test from plugin 
> realm 
> ClassRealm[plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5, 
> parent: sun.misc.Launcher$AppClassLoader@7852e922]
> [DEBUG] Configuring mojo execution 
> 'org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test:default-test' 
> with basic configurator -->
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7511) Ensure the degreeOfConcurrency is a positive number in MavenExecutionRequest

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690613#comment-17690613
 ] 

Michael Osipov commented on MNG-7511:
-

Fixed with 
[a1c537342bea5c395bfefb2031abd08b5830b43a|https://gitbox.apache.org/repos/asf?p=maven.git=commit=a1c537342bea5c395bfefb2031abd08b5830b43a]
 for {{maven-3.8.x}} branch.

> Ensure the degreeOfConcurrency is a positive number in MavenExecutionRequest
> 
>
> Key: MNG-7511
> URL: https://issues.apache.org/jira/browse/MNG-7511
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.6
>Reporter: Josef Cacek
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> The {{degreeOfConcurrency}} should always be a positive number, otherwise 
> builds might fail.
> In Hazelcast we build with threads set to {{-T 0.5C}} in 
> [{{.mvn/maven.config}}|https://github.com/hazelcast/hazelcast/blob/v5.1.2/.mvn/maven.config].
> This is fine until we run the build on a single CPU machine. It fails then 
> with {{IllegalArgumentException}} as the computed {{degreeOfConcurrency == 
> 0}}.
> Stacktrace from Maven 3.6.3:
> {code}
> [ERROR] IllegalArgumentException
> java.lang.IllegalArgumentException
> at java.util.concurrent.ThreadPoolExecutor. 
> (ThreadPoolExecutor.java:1293)
> at java.util.concurrent.ThreadPoolExecutor. 
> (ThreadPoolExecutor.java:1215)
> at java.util.concurrent.Executors.newFixedThreadPool (Executors.java:155)
> at 
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder.build
>  (MultiThreadedBuilder.java:88)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7511) Ensure the degreeOfConcurrency is a positive number in MavenExecutionRequest

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7511:

Fix Version/s: 3.8.8
   (was: 3.8.x-candidate)

> Ensure the degreeOfConcurrency is a positive number in MavenExecutionRequest
> 
>
> Key: MNG-7511
> URL: https://issues.apache.org/jira/browse/MNG-7511
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.6
>Reporter: Josef Cacek
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> The {{degreeOfConcurrency}} should always be a positive number, otherwise 
> builds might fail.
> In Hazelcast we build with threads set to {{-T 0.5C}} in 
> [{{.mvn/maven.config}}|https://github.com/hazelcast/hazelcast/blob/v5.1.2/.mvn/maven.config].
> This is fine until we run the build on a single CPU machine. It fails then 
> with {{IllegalArgumentException}} as the computed {{degreeOfConcurrency == 
> 0}}.
> Stacktrace from Maven 3.6.3:
> {code}
> [ERROR] IllegalArgumentException
> java.lang.IllegalArgumentException
> at java.util.concurrent.ThreadPoolExecutor. 
> (ThreadPoolExecutor.java:1293)
> at java.util.concurrent.ThreadPoolExecutor. 
> (ThreadPoolExecutor.java:1215)
> at java.util.concurrent.Executors.newFixedThreadPool (Executors.java:155)
> at 
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder.build
>  (MultiThreadedBuilder.java:88)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread David M. Lloyd (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690611#comment-17690611
 ] 

David M. Lloyd commented on MNG-7700:
-

The behavior changed between 3.8.6 and 3.8.7 (which behaves the same as 3.9.0).

> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.6, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread David M. Lloyd (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David M. Lloyd updated MNG-7700:

Affects Version/s: 3.8.7
   (was: 3.8.6)

> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-7701) Incompatible version sorting changes

2023-02-17 Thread David M. Lloyd (Jira)
David M. Lloyd created MNG-7701:
---

 Summary: Incompatible version sorting changes
 Key: MNG-7701
 URL: https://issues.apache.org/jira/browse/MNG-7701
 Project: Maven
  Issue Type: Bug
  Components: Core
Affects Versions: 3.9.0, 3.8.7
Reporter: David M. Lloyd


Between 3.8.6 and 3.8.7, the sorting of a variety of version strings has 
changed. This table captures the observed relations:

||Input 1||3.8.6||3.8.7||Input 2||
|{{0.x}}|{{>}}|{{==}}|{{0-x}}|
|{{1.x}}|{{<}}|{{==}}|{{1-x}}|
|{{1.x}}|{{<}}|{{>}}|{{1_y}}|
|{{1.y}}|{{<}}|{{>}}|{{1_x}}|
|{{1-alpha}}|{{>}}|{{==}}|{{1.alpha}}|





--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690610#comment-17690610
 ] 

Michael Osipov commented on MNG-7648:
-

Fixed with 
[91d8c6594e881151d2feabf8c3d4119d9aa05497|https://gitbox.apache.org/repos/asf?p=maven.git=commit=91d8c6594e881151d2feabf8c3d4119d9aa05497]
 for {{maven-3.8.x}} branch.

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-4, 4.0.0, 3.8.8
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7648) Generated model reader is not setting location information

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7648:

Fix Version/s: 3.8.8
   (was: 3.8.x-candidate)

> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-4, 4.0.0, 3.8.8
>
>
> -Generated model reader is not setting {{location}} property - 
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
>  .-
> Project model does not have location property in plugin execution (potential 
> issue when merging model parent configuration?). This causes issues for 
> example in Maven Enforcer Plugin which uses this information (see 
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7697) Cannot parse POM that contains an emoji in a comment

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690608#comment-17690608
 ] 

Michael Osipov commented on MNG-7697:
-

[~cstamas], funny, isn't it. One needs to bisect down to the offending 
changeset.

> Cannot parse POM that contains an emoji in a comment
> 
>
> Key: MNG-7697
> URL: https://issues.apache.org/jira/browse/MNG-7697
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 3.9.0
> Environment: MacOS 13.2.1
> OpenJDK Runtime Environment Temurin-17.0.4+8 
>Reporter: Andrew Rosenberg
>Priority: Major
> Attachments: pom.xml
>
>
> {noformat}
>  mvn -e  clean install                            
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-parseable POM 
> /Users/andrew.rosenberg/.m2/repository/com/verygood/security/base-pom-17/0.2.47/base-pom-17-0.2.47.pom:
>  Illegal character 0xd83d found in comment (position: START_TAG seen 
> ...\n      

[jira] [Updated] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7700:

Fix Version/s: waiting-for-feedback

> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.6, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690607#comment-17690607
 ] 

Michael Osipov commented on MNG-7700:
-

Please verify 3.8.7 and not 3.8.6.

> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.6, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7698) Allow comments in .mvn/maven.config

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690606#comment-17690606
 ] 

Michael Osipov commented on MNG-7698:
-

I know, just saying that we need to know what options are out there. Maybe we 
will say that picocli, spite its name, is too large/complex...
Look at this Commons CLI fuckup: 
https://github.com/apache/maven/blob/b17c968a0bad4c418f71015a8f721f21b29bfd98/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L404-L414

> Allow comments in .mvn/maven.config
> ---
>
> Key: MNG-7698
> URL: https://issues.apache.org/jira/browse/MNG-7698
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Since {{.mvn/maven.config}} requires each arguments in new line,
> it is easy to skip line beginning with special char - like {{#}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-filtering] slawekjaranowski merged pull request #68: Bump apache/maven-gh-actions-shared from 2 to 3

2023-02-17 Thread via GitHub


slawekjaranowski merged PR #68:
URL: https://github.com/apache/maven-filtering/pull/68


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread David M. Lloyd (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David M. Lloyd updated MNG-7700:

Affects Version/s: 3.8.6
   (was: 3.8.7)

> Improper canonicalization of versions
> -
>
> Key: MNG-7700
> URL: https://issues.apache.org/jira/browse/MNG-7700
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.8.6, 3.9.0
>Reporter: David M. Lloyd
>Priority: Major
>
> The canonicalization logic for versions is incorrect.
> Using the method {{ComparableVersion#getCanonical}} as in {{new 
> ComparableVersion(input).getCanonical()}}, the following results can be 
> observed:
> ||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
> |{{1}}|{{1}}|yes|{{1}}|yes|
> |{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
> |{{0-1}}|{{1}}|no|{{1}}|no|
> |{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
> |{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
> |{{0.x}}|{{0.x}}|yes|{{x}}|no|
> |{{0-x}}|{{x}}|no|{{x}}|no|
> |{{x}}|{{x}}|yes|{{x}}|yes|
> The "OK?" columns indicate whether parsing the canonical version string will 
> yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
> from the original input, i.e. it's internally consistent.
> The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
> considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
> intentional or not, but it is definitely a change.
> These canonicalizations seem to have gotten less consistent in the move to 
> 3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7698) Allow comments in .mvn/maven.config

2023-02-17 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690602#comment-17690602
 ] 

Slawomir Jaranowski commented on MNG-7698:
--

picocli - AtFiles has support for comments :)

> Allow comments in .mvn/maven.config
> ---
>
> Key: MNG-7698
> URL: https://issues.apache.org/jira/browse/MNG-7698
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Since {{.mvn/maven.config}} requires each arguments in new line,
> it is easy to skip line beginning with special char - like {{#}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7515) Cannot see a dependency tree for apache-maven module

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690601#comment-17690601
 ] 

Michael Osipov commented on MNG-7515:
-

Fixed with 
[9afae9f4a46b5df423e33397586e5e870a0b7d0e|https://gitbox.apache.org/repos/asf?p=maven.git=commit=9afae9f4a46b5df423e33397586e5e870a0b7d0e]
 for {{maven-3.8.x}} branch.

> Cannot see a dependency tree for apache-maven module
> 
>
> Key: MNG-7515
> URL: https://issues.apache.org/jira/browse/MNG-7515
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.8.6
>Reporter: Rafael Chaves
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> The {{apache-maven}} module configures maven-dependency-plugin under the 
> {{}} element, which prevents that plug-in from being used with custom 
> configuration from the command-line.
>  
> {noformat}
> mvn org.apache.maven.plugins:maven-dependency-plugin:3.3.0:list -f 
> apache-maven 
> [INFO] Scanning for projects...
> [INFO] 
> [INFO] ---< org.apache.maven:apache-maven 
> >
> [INFO] Building Apache Maven Distribution 3.6.3
> [INFO] [ pom 
> ]-
> [INFO] 
> [INFO] --- maven-dependency-plugin:3.3.0:list (default-cli) @ apache-maven ---
> [INFO] 
> [INFO] The following files have been resolved:
> [INFO]    org.fusesource.jansi:jansi:jar:1.17.1:compile -- module jansi (auto)
> [INFO] 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time:  0.483 s
> [INFO] Finished at: 2022-07-14T16:55:57-03:00
> [INFO] 
> {noformat}
> The `dependency:tree` goal under debug mode shows something interesting:
> {noformat}
> [DEBUG] + Filtering dependency tree by artifact include patterns: 
> [META-INF/native/**]{noformat}
>  Turns out the apache-maven module configures the dependency plugin in a way 
> that prevents it from being used from the command-line:
>  
> {noformat}
> 
>       
>         org.apache.maven.plugins
>         maven-dependency-plugin
>         
>           jansi
>           META-INF/native/**
>         
>         
>           
>             unpack-jansi-native
>             
>               unpack-dependencies
>             
>           
>         
>       {noformat}
>  
>  Moving the configuration element to under the {{}} element avoids 
> the issue:
> {noformat}
> mvn org.apache.maven.plugins:maven-dependency-plugin:3.3.0:list -f 
> apache-maven  
> [INFO] Scanning for projects...
> [INFO] 
> [INFO] ---< org.apache.maven:apache-maven 
> >
> [INFO] Building Apache Maven Distribution 3.6.3
> [INFO] [ pom 
> ]-
> [INFO] 
> [INFO] --- maven-dependency-plugin:3.3.0:list (default-cli) @ apache-maven ---
> [INFO] 
> [INFO] The following files have been resolved:
> [INFO]org.apache.maven:maven-embedder:jar:3.6.3:compile -- module 
> maven.embedder (auto)
> [INFO]org.apache.maven:maven-settings:jar:3.6.3:compile -- module 
> maven.settings (auto)
> [INFO]org.apache.maven:maven-settings-builder:jar:3.6.3:compile -- module 
> maven.settings.builder (auto)
> [INFO]org.apache.maven:maven-plugin-api:jar:3.6.3:compile -- module 
> maven.plugin.api (auto)
> [INFO]org.apache.maven:maven-model:jar:3.6.3:compile -- module 
> maven.model (auto)
> [INFO]org.apache.maven:maven-model-builder:jar:3.6.3:compile -- module 
> maven.model.builder (auto)
> [INFO]org.apache.maven:maven-builder-support:jar:3.6.3:compile -- module 
> maven.builder.support (auto)
> [INFO]org.apache.maven.resolver:maven-resolver-api:jar:1.4.1:compile -- 
> module org.apache.maven.resolver [auto]
> [INFO]org.apache.maven.resolver:maven-resolver-util:jar:1.4.1:compile -- 
> module org.apache.maven.resolver.util [auto]
> [INFO]org.apache.maven.shared:maven-shared-utils:jar:3.2.1:compile -- 
> module maven.shared.utils (auto)
> [INFO]commons-io:commons-io:jar:2.5:compile -- module commons.io (auto)
> [INFO]com.google.inject:guice:jar:no_aop:4.2.1:compile -- module 
> com.google.guice [auto]
> [INFO]com.google.guava:guava:jar:25.1-android:compile -- module 
> com.google.common [auto]
> [INFO]javax.inject:javax.inject:jar:1:compile -- module javax.inject 
> (auto)
> [INFO]javax.annotation:jsr250-api:jar:1.0:compile -- module jsr250.api 
> (auto)
> [INFO]org.codehaus.plexus:plexus-utils:jar:3.2.1:compile -- module 
> plexus.utils (auto)
> [INFO]org.codehaus.plexus:plexus-classworlds:jar:2.6.0:compile -- 

[jira] [Updated] (MNG-7515) Cannot see a dependency tree for apache-maven module

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7515:

Fix Version/s: 3.8.8
   (was: 3.8.x-candidate)

> Cannot see a dependency tree for apache-maven module
> 
>
> Key: MNG-7515
> URL: https://issues.apache.org/jira/browse/MNG-7515
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.8.6
>Reporter: Rafael Chaves
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> The {{apache-maven}} module configures maven-dependency-plugin under the 
> {{}} element, which prevents that plug-in from being used with custom 
> configuration from the command-line.
>  
> {noformat}
> mvn org.apache.maven.plugins:maven-dependency-plugin:3.3.0:list -f 
> apache-maven 
> [INFO] Scanning for projects...
> [INFO] 
> [INFO] ---< org.apache.maven:apache-maven 
> >
> [INFO] Building Apache Maven Distribution 3.6.3
> [INFO] [ pom 
> ]-
> [INFO] 
> [INFO] --- maven-dependency-plugin:3.3.0:list (default-cli) @ apache-maven ---
> [INFO] 
> [INFO] The following files have been resolved:
> [INFO]    org.fusesource.jansi:jansi:jar:1.17.1:compile -- module jansi (auto)
> [INFO] 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time:  0.483 s
> [INFO] Finished at: 2022-07-14T16:55:57-03:00
> [INFO] 
> {noformat}
> The `dependency:tree` goal under debug mode shows something interesting:
> {noformat}
> [DEBUG] + Filtering dependency tree by artifact include patterns: 
> [META-INF/native/**]{noformat}
>  Turns out the apache-maven module configures the dependency plugin in a way 
> that prevents it from being used from the command-line:
>  
> {noformat}
> 
>       
>         org.apache.maven.plugins
>         maven-dependency-plugin
>         
>           jansi
>           META-INF/native/**
>         
>         
>           
>             unpack-jansi-native
>             
>               unpack-dependencies
>             
>           
>         
>       {noformat}
>  
>  Moving the configuration element to under the {{}} element avoids 
> the issue:
> {noformat}
> mvn org.apache.maven.plugins:maven-dependency-plugin:3.3.0:list -f 
> apache-maven  
> [INFO] Scanning for projects...
> [INFO] 
> [INFO] ---< org.apache.maven:apache-maven 
> >
> [INFO] Building Apache Maven Distribution 3.6.3
> [INFO] [ pom 
> ]-
> [INFO] 
> [INFO] --- maven-dependency-plugin:3.3.0:list (default-cli) @ apache-maven ---
> [INFO] 
> [INFO] The following files have been resolved:
> [INFO]org.apache.maven:maven-embedder:jar:3.6.3:compile -- module 
> maven.embedder (auto)
> [INFO]org.apache.maven:maven-settings:jar:3.6.3:compile -- module 
> maven.settings (auto)
> [INFO]org.apache.maven:maven-settings-builder:jar:3.6.3:compile -- module 
> maven.settings.builder (auto)
> [INFO]org.apache.maven:maven-plugin-api:jar:3.6.3:compile -- module 
> maven.plugin.api (auto)
> [INFO]org.apache.maven:maven-model:jar:3.6.3:compile -- module 
> maven.model (auto)
> [INFO]org.apache.maven:maven-model-builder:jar:3.6.3:compile -- module 
> maven.model.builder (auto)
> [INFO]org.apache.maven:maven-builder-support:jar:3.6.3:compile -- module 
> maven.builder.support (auto)
> [INFO]org.apache.maven.resolver:maven-resolver-api:jar:1.4.1:compile -- 
> module org.apache.maven.resolver [auto]
> [INFO]org.apache.maven.resolver:maven-resolver-util:jar:1.4.1:compile -- 
> module org.apache.maven.resolver.util [auto]
> [INFO]org.apache.maven.shared:maven-shared-utils:jar:3.2.1:compile -- 
> module maven.shared.utils (auto)
> [INFO]commons-io:commons-io:jar:2.5:compile -- module commons.io (auto)
> [INFO]com.google.inject:guice:jar:no_aop:4.2.1:compile -- module 
> com.google.guice [auto]
> [INFO]com.google.guava:guava:jar:25.1-android:compile -- module 
> com.google.common [auto]
> [INFO]javax.inject:javax.inject:jar:1:compile -- module javax.inject 
> (auto)
> [INFO]javax.annotation:jsr250-api:jar:1.0:compile -- module jsr250.api 
> (auto)
> [INFO]org.codehaus.plexus:plexus-utils:jar:3.2.1:compile -- module 
> plexus.utils (auto)
> [INFO]org.codehaus.plexus:plexus-classworlds:jar:2.6.0:compile -- module 
> plexus.classworlds (auto)
> [INFO]org.sonatype.plexus:plexus-sec-dispatcher:jar:1.4:compile -- module 
> plexus.sec.dispatcher (auto)
> 

[jira] [Created] (MNG-7700) Improper canonicalization of versions

2023-02-17 Thread David M. Lloyd (Jira)
David M. Lloyd created MNG-7700:
---

 Summary: Improper canonicalization of versions
 Key: MNG-7700
 URL: https://issues.apache.org/jira/browse/MNG-7700
 Project: Maven
  Issue Type: Bug
  Components: Core
Affects Versions: 3.9.0, 3.8.7
Reporter: David M. Lloyd


The canonicalization logic for versions is incorrect.

Using the method {{ComparableVersion#getCanonical}} as in {{new 
ComparableVersion(input).getCanonical()}}, the following results can be 
observed:

||Input||3.8.6 Output||3.8.6 OK?||3.9.0 Output||3.9.0 OK?||
|{{1}}|{{1}}|yes|{{1}}|yes|
|{{0.1}}|{{0.1}}|yes|{{0.1}}|yes|
|{{0-1}}|{{1}}|no|{{1}}|no|
|{{1.x}}|{{1.x}}|yes|{{1-x}}|maybe*|
|{{1-x}}|{{1-x}}|yes|{{1-x}}|yes|
|{{0.x}}|{{0.x}}|yes|{{x}}|no|
|{{0-x}}|{{x}}|no|{{x}}|no|
|{{x}}|{{x}}|yes|{{x}}|yes|


The "OK?" columns indicate whether parsing the canonical version string will 
yield a {{ComparableVersion}} instance that is {{equal}} to one constructed 
from the original input, i.e. it's internally consistent.

The "maybe*" item indicates that starting with 3.9.0, version `1.x` is now 
considered to be equal to `1-x`. I'm not sure if this is a bug or not, or was 
intentional or not, but it is definitely a change.

These canonicalizations seem to have gotten less consistent in the move to 
3.9.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7564) Potential NPE in MavenMetadataSource

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690595#comment-17690595
 ] 

Michael Osipov commented on MNG-7564:
-

Fixed with 
[7ec2c66b536ad4577c9cbcfcad096149ea120289|https://gitbox.apache.org/repos/asf?p=maven.git=commit=7ec2c66b536ad4577c9cbcfcad096149ea120289]
 for {{maven-3.8.x}} branch.

> Potential NPE in MavenMetadataSource
> 
>
> Key: MNG-7564
> URL: https://issues.apache.org/jira/browse/MNG-7564
> Project: Maven
>  Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.9.0, 4.0.0-alpha-3, 4.0.0, 3.8.8
>
>
> In here: 
> https://github.com/apache/maven/blob/cb54aa429d9e63bf78c4c808898fbef1cc01ff33/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java#L198-L203
> {{LegacySupport#getSession()}} can be {{null}}, but never tested. If {{null}} 
> an empty list should be returned.
> This was indirectly found by [~gnodet].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7564) Potential NPE in MavenMetadataSource

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7564:

Fix Version/s: 3.8.8
   (was: 3.8.x-candidate)

> Potential NPE in MavenMetadataSource
> 
>
> Key: MNG-7564
> URL: https://issues.apache.org/jira/browse/MNG-7564
> Project: Maven
>  Issue Type: Bug
>Reporter: Michael Osipov
>Assignee: Maarten Mulders
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.9.0, 4.0.0-alpha-3, 4.0.0, 3.8.8
>
>
> In here: 
> https://github.com/apache/maven/blob/cb54aa429d9e63bf78c4c808898fbef1cc01ff33/maven-core/src/main/java/org/apache/maven/project/artifact/MavenMetadataSource.java#L198-L203
> {{LegacySupport#getSession()}} can be {{null}}, but never tested. If {{null}} 
> an empty list should be returned.
> This was indirectly found by [~gnodet].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7698) Allow comments in .mvn/maven.config

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690593#comment-17690593
 ] 

Michael Osipov commented on MNG-7698:
-

Reference: https://picocli.info/#AtFiles

Very similar to Python's {{argparse}} module.

> Allow comments in .mvn/maven.config
> ---
>
> Key: MNG-7698
> URL: https://issues.apache.org/jira/browse/MNG-7698
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Since {{.mvn/maven.config}} requires each arguments in new line,
> it is easy to skip line beginning with special char - like {{#}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] tbw777 commented on a diff in pull request #998: Using Set<>() for contains()

2023-02-17 Thread via GitHub


tbw777 commented on code in PR #998:
URL: https://github.com/apache/maven/pull/998#discussion_r1110337752


##
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##
@@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader {
 
 public static final String PROJECT_LOCAL_REPO = "project-local-repo";
 
-private static final Collection COMPILE_PHASE_TYPES =
-Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client");
+private static final Set COMPILE_PHASE_TYPES;
+
+static {
+COMPILE_PHASE_TYPES = new HashSet<>(
+Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", 
"par", "sar", "wsr", "har", "app-client"));
+}

Review Comment:
   https://gist.github.com/tbw777/716907b110df7eac1792de7148f8eb32
   
   ```java
   private static final Collection COMPILE_PHASE_TYPES_LIST =
   Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client");
   private static final Collection COMPILE_PHASE_TYPES_SET = new 
HashSet<>(
   Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client")
   );
   
   @Benchmark
   public void COMPILE_PHASE_TYPES_LIST() {
   boolean ejb3 = COMPILE_PHASE_TYPES_LIST.contains(str);
   }
   
   @Benchmark
   public void COMPILE_PHASE_TYPES_SET() {
   boolean ejb3 = COMPILE_PHASE_TYPES_SET.contains(str);
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (MNG-7698) Allow comments in .mvn/maven.config

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690589#comment-17690589
 ] 

Michael Osipov edited comment on MNG-7698 at 2/17/23 8:54 PM:
--

Commons CLI is in maintenance mode. It has no real future. Maybe Java will 
expose its API in future, but I can think of, at least:

* https://github.com/kohsuke/args4j
* https://github.com/cbeust/jcommander
* https://github.com/remkop/picocli
* https://github.com/jopt-simple/jopt-simple

See: https://sfuhrm.de/en/java-command-line-parsing-libraries-compared/

Of course, they need first to over our current requirements...

In an ideal library, we'd just provide the patch to the {{@argfile}} without 
parsing ourselves.


was (Author: michael-o):
Commons CLI is in maintenance mode. It has no real future. Maybe Java will 
expose its API in future, but I can think of, at least:

* https://github.com/kohsuke/args4j
* https://github.com/cbeust/jcommander
* https://github.com/remkop/picocli
* https://github.com/jopt-simple/jopt-simple

See: https://sfuhrm.de/en/java-command-line-parsing-libraries-compared/

Of course, they need first to over our current requirements...

> Allow comments in .mvn/maven.config
> ---
>
> Key: MNG-7698
> URL: https://issues.apache.org/jira/browse/MNG-7698
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Since {{.mvn/maven.config}} requires each arguments in new line,
> it is easy to skip line beginning with special char - like {{#}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7698) Allow comments in .mvn/maven.config

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690589#comment-17690589
 ] 

Michael Osipov commented on MNG-7698:
-

Commons CLI is in maintenance mode. It has no real future. Maybe Java will 
expose its API in future, but I can think of, at least:

* https://github.com/kohsuke/args4j
* https://github.com/cbeust/jcommander
* https://github.com/remkop/picocli
* https://github.com/jopt-simple/jopt-simple

See: https://sfuhrm.de/en/java-command-line-parsing-libraries-compared/

Of course, they need first to over our current requirements...

> Allow comments in .mvn/maven.config
> ---
>
> Key: MNG-7698
> URL: https://issues.apache.org/jira/browse/MNG-7698
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Since {{.mvn/maven.config}} requires each arguments in new line,
> it is easy to skip line beginning with special char - like {{#}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] tbw777 commented on a diff in pull request #998: Using Set<>() for contains()

2023-02-17 Thread via GitHub


tbw777 commented on code in PR #998:
URL: https://github.com/apache/maven/pull/998#discussion_r1110337752


##
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##
@@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader {
 
 public static final String PROJECT_LOCAL_REPO = "project-local-repo";
 
-private static final Collection COMPILE_PHASE_TYPES =
-Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client");
+private static final Set COMPILE_PHASE_TYPES;
+
+static {
+COMPILE_PHASE_TYPES = new HashSet<>(
+Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", 
"par", "sar", "wsr", "har", "app-client"));
+}

Review Comment:
   https://gist.github.com/tbw777/716907b110df7eac1792de7148f8eb32
   
   ```java
 private static final Collection COMPILE_PHASE_TYPES_LIST =
 Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client");
 private static final Set COMPILE_PHASE_TYPES_SET = new HashSet<>(
 Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client"));
   
 @Benchmark
 public void COMPILE_PHASE_TYPES() {
 boolean ejb3 = COMPILE_PHASE_TYPES_LIST.contains(str);
 }
   
 @Benchmark
 public void COMPILE_PHASE_TYPES_SET() {
 boolean ejb3 = COMPILE_PHASE_TYPES_SET.contains(str);
 }
   ```



##
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##
@@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader {
 
 public static final String PROJECT_LOCAL_REPO = "project-local-repo";
 
-private static final Collection COMPILE_PHASE_TYPES =
-Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client");
+private static final Set COMPILE_PHASE_TYPES;
+
+static {
+COMPILE_PHASE_TYPES = new HashSet<>(
+Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", 
"par", "sar", "wsr", "har", "app-client"));
+}

Review Comment:
   https://gist.github.com/tbw777/716907b110df7eac1792de7148f8eb32
   
   ```java
   private static final Collection COMPILE_PHASE_TYPES_LIST =
   Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client");
   private static final Set COMPILE_PHASE_TYPES_SET = new HashSet<>(
   Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client"));
   
   @Benchmark
   public void COMPILE_PHASE_TYPES() {
   boolean ejb3 = COMPILE_PHASE_TYPES_LIST.contains(str);
   }
   
   @Benchmark
   public void COMPILE_PHASE_TYPES_SET() {
   boolean ejb3 = COMPILE_PHASE_TYPES_SET.contains(str);
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] tbw777 commented on a diff in pull request #998: Using Set<>() for contains()

2023-02-17 Thread via GitHub


tbw777 commented on code in PR #998:
URL: https://github.com/apache/maven/pull/998#discussion_r1110337752


##
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##
@@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader {
 
 public static final String PROJECT_LOCAL_REPO = "project-local-repo";
 
-private static final Collection COMPILE_PHASE_TYPES =
-Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client");
+private static final Set COMPILE_PHASE_TYPES;
+
+static {
+COMPILE_PHASE_TYPES = new HashSet<>(
+Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", 
"par", "sar", "wsr", "har", "app-client"));
+}

Review Comment:
   https://gist.github.com/tbw777/716907b110df7eac1792de7148f8eb32



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (MNG-7160) Extension And Classloaders: difference of result given extension types

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690578#comment-17690578
 ] 

Michael Osipov edited comment on MNG-7160 at 2/17/23 8:34 PM:
--

Fixed with 
[77ba96f686e82e5333403ed0597bfefad29d9283|https://gitbox.apache.org/repos/asf?p=maven.git=commit=77ba96f686e82e5333403ed0597bfefad29d9283]
 for {{maven-3.8.x}} branch.


was (Author: michael-o):
Fixed with 
[77ba96f686e82e5333403ed0597bfefad29d9283|https://gitbox.apache.org/repos/asf?p=maven.git=commit=77ba96f686e82e5333403ed0597bfefad29d9283]
 for maven-3.8.x branch.

> Extension And Classloaders: difference of result given extension types
> --
>
> Key: MNG-7160
> URL: https://issues.apache.org/jira/browse/MNG-7160
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.2, 3.8.1
>Reporter: Nick Cross
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> I have a project that we use for all of our internal Red Hat builds (although 
> primarily through its CLI mode hence not noticing this until 
> [https://github.com/release-engineering/pom-manipulation-ext/issues/832] was 
> submitted in the community). This project creates an extension (lib/ext 
> style) but trying to use it as a ".mvn/extensions.xml" it _seems_ to get a 
> classloader problem as _I think _the Maven Model/Plugin objects are created 
> within a different classloader which means when the Plugin configuration is 
> retrieved and cast to a Xpp3Dom object it fails. Is there some configuration 
> we are missing or is there a problem in how the classloading in Maven for 
> core extensions is working when using Xpp3Dom ?
> An reproducer branch is 
> [https://github.com/rnc/pom-manipulation-ext/tree/ISSUE832] 
>  (Simply build and install the project, then use it on any simple Maven 
> project with an extensions.xml with the command e.g. "mvn -X 
> -DversionSuffix=redhat-1" )
> An example log is below:
> {noformat}
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /home/rnc/Software/apache-maven-3.8.1
> Java version: 11.0.11, vendor: Red Hat, Inc., runtime: 
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.fc33.x86_64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "5.11.14-200.fc33.x86_64", arch: "amd64", family: 
> "unix"
> [DEBUG] Reading global settings from 
> /home/rnc/Software/apache-maven-3.8.1/conf/settings.xml
> [DEBUG] Reading user settings from /home/rnc/.m2/settings.xml
> [DEBUG] Using manager EnhancedLocalRepositoryManager with priority 10.0 for 
> /home/rnc/.m2/repository
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> repository.jboss.org (http://repository.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> snapshots.jboss.org (http://snapshots.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> oss.sonatype.org/jboss-snapshots 
> (http://oss.sonatype.org/content/repositories/jboss-snapshots).
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=644417, 
> ConflictMarker.markTime=145101, ConflictMarker.nodeCount=11, 
> ConflictIdSorter.graphTime=429885, ConflictIdSorter.topsortTime=359266, 
> ConflictIdSorter.conflictIdCount=10, ConflictIdSorter.conflictIdCycleCount=0, 
> ConflictResolver.totalTime=2854763, ConflictResolver.conflictItemCount=11, 
> DefaultDependencyCollector.collectTime=122702048, 
> DefaultDependencyCollector.transformTime=6173804}
> [DEBUG] org.commonjava.maven.ext:pom-manipulation-ext:jar:4.4-SNAPSHOT
> [DEBUG]javax.inject:javax.inject:jar:1:compile
> [DEBUG]org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.4:compile
> [DEBUG]   javax.enterprise:cdi-api:jar:1.0:compile
> [DEBUG]  javax.annotation:jsr250-api:jar:1.0:compile
> [DEBUG]   org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.3.4:compile
> [DEBUG]   
> org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
> [DEBUG]   org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile
> [DEBUG]   org.codehaus.plexus:plexus-utils:jar:3.1.0:compile (version 
> managed from default)
> [DEBUG]org.slf4j:slf4j-api:jar:1.7.30:compile
> [DEBUG] Populating class realm 
> coreExtension>org.commonjava.maven.ext:pom-manipulation-ext:4.4-SNAPSHOT
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/commonjava/maven/ext/pom-manipulation-ext/4.4-SNAPSHOT/pom-manipulation-ext-4.4-SNAPSHOT.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.4/org.eclipse.sisu.inject-0.3.4.jar
> [DEBUG]   Included 
> 

[jira] [Created] (MNG-7699) Remove all Maven 3.9.0+ ITs from maven-3.8.x branch

2023-02-17 Thread Michael Osipov (Jira)
Michael Osipov created MNG-7699:
---

 Summary: Remove all Maven 3.9.0+ ITs from maven-3.8.x branch
 Key: MNG-7699
 URL: https://issues.apache.org/jira/browse/MNG-7699
 Project: Maven
  Issue Type: Task
  Components: Integration Tests
Reporter: Michael Osipov
Assignee: Michael Osipov


These are skipped and cannot be executed on {{maven-3.8.x}} branch anyway:
{noformat}
$ grep SKIPPED skipped  | grep -e 3.9.0 -e 4.0
mng7474 SessionScope.SessionScope().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7443 
ConsistencyOfOptionalProjectsAndProfiles.ConsistentLoggingOfOptionalProfilesAndProjects()
 SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7353 CliGoalInvocation.PrefixGoal()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7353 CliGoalInvocation.GroupIdArtifactIdVersionGoalAtId(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7353 CliGoalInvocation.PrefixVersionGoal() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7353 CliGoalInvocation.GroupIdArtifactIdVersionGoal(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7353 CliGoalInvocation.PrefixVersionGoalAtId() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7353 CliGoalInvocation.PrefixGoalAtId()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7353 CliGoalInvocation.GroupIdArtifactIdGoal() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7353 CliGoalInvocation.GroupIdArtifactIdGoalAtId() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7504 NotWarnUnsupportedReportPlugins.WarnNotPresent(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,3.9.0]
mng7468 UnsupportedPluginsParameters.ValidParameterAlias()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InPluginManagement() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InBuildMixed().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InBuildExecution().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.ValidParameter() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.WithForkedGoalExecution() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.NoConfiguration()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InPluginManagementParent() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.ValidParameterForOtherGoal() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7468 UnsupportedPluginsParameters.InBuildPlugin(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7470 ResolverTransport.ResolverTransportDefault(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7470 ResolverTransport.ResolverTransportNative().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7470 ResolverTransport.ResolverTransportWagon()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7464 ReadOnlyMojoParametersWarning.ReadOnlyProperty(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7464 ReadOnlyMojoParametersWarning.ReadOnlyConfig()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7464 ReadOnlyMojoParametersWarning.EmptyConfiguration()... SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7404 IgnorePrefixlessExpressions.IgnorePrefixlessExpressions() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng5222 MojoDeprecated.DeprecatedProperty().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng5222 MojoDeprecated.DeprecatedConfig() SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng5222 MojoDeprecated.EmptyConfiguration().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [3.9.0,)
mng7390 SelectModuleOutsideCwd.SelectModuleByRelativePath().. SKIPPED - Maven 
version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7390 SelectModuleOutsideCwd.SelectMultipleModulesByCoordinate() SKIPPED - 
Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7390 
SelectModuleOutsideCwd.SelectModulesOutsideCwdDoesNotWorkWhenDotMvnIsNotPresent()
 SKIPPED - Maven version 3.8.8-SNAPSHOT not in range [4.0.0-alpha-1,)
mng7390 SelectModuleOutsideCwd.SelectModulesByRelativePath(). SKIPPED - Maven 
version 3.8.8-SNAPSHOT not 

[GitHub] [maven] michael-o commented on a diff in pull request #998: Using Set<>() for contains()

2023-02-17 Thread via GitHub


michael-o commented on code in PR #998:
URL: https://github.com/apache/maven/pull/998#discussion_r1110325874


##
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##
@@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader {
 
 public static final String PROJECT_LOCAL_REPO = "project-local-repo";
 
-private static final Collection COMPILE_PHASE_TYPES =
-Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par", 
"sar", "wsr", "har", "app-client");
+private static final Set COMPILE_PHASE_TYPES;
+
+static {
+COMPILE_PHASE_TYPES = new HashSet<>(
+Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", 
"par", "sar", "wsr", "har", "app-client"));
+}

Review Comment:
   True, but does the type has to change to set from collection for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7160) Extension And Classloaders: difference of result given extension types

2023-02-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690579#comment-17690579
 ] 

ASF GitHub Bot commented on MNG-7160:
-

michael-o commented on PR #999:
URL: https://github.com/apache/maven/pull/999#issuecomment-1435229772

   Merged.




> Extension And Classloaders: difference of result given extension types
> --
>
> Key: MNG-7160
> URL: https://issues.apache.org/jira/browse/MNG-7160
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.2, 3.8.1
>Reporter: Nick Cross
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> I have a project that we use for all of our internal Red Hat builds (although 
> primarily through its CLI mode hence not noticing this until 
> [https://github.com/release-engineering/pom-manipulation-ext/issues/832] was 
> submitted in the community). This project creates an extension (lib/ext 
> style) but trying to use it as a ".mvn/extensions.xml" it _seems_ to get a 
> classloader problem as _I think _the Maven Model/Plugin objects are created 
> within a different classloader which means when the Plugin configuration is 
> retrieved and cast to a Xpp3Dom object it fails. Is there some configuration 
> we are missing or is there a problem in how the classloading in Maven for 
> core extensions is working when using Xpp3Dom ?
> An reproducer branch is 
> [https://github.com/rnc/pom-manipulation-ext/tree/ISSUE832] 
>  (Simply build and install the project, then use it on any simple Maven 
> project with an extensions.xml with the command e.g. "mvn -X 
> -DversionSuffix=redhat-1" )
> An example log is below:
> {noformat}
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /home/rnc/Software/apache-maven-3.8.1
> Java version: 11.0.11, vendor: Red Hat, Inc., runtime: 
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.fc33.x86_64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "5.11.14-200.fc33.x86_64", arch: "amd64", family: 
> "unix"
> [DEBUG] Reading global settings from 
> /home/rnc/Software/apache-maven-3.8.1/conf/settings.xml
> [DEBUG] Reading user settings from /home/rnc/.m2/settings.xml
> [DEBUG] Using manager EnhancedLocalRepositoryManager with priority 10.0 for 
> /home/rnc/.m2/repository
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> repository.jboss.org (http://repository.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> snapshots.jboss.org (http://snapshots.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> oss.sonatype.org/jboss-snapshots 
> (http://oss.sonatype.org/content/repositories/jboss-snapshots).
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=644417, 
> ConflictMarker.markTime=145101, ConflictMarker.nodeCount=11, 
> ConflictIdSorter.graphTime=429885, ConflictIdSorter.topsortTime=359266, 
> ConflictIdSorter.conflictIdCount=10, ConflictIdSorter.conflictIdCycleCount=0, 
> ConflictResolver.totalTime=2854763, ConflictResolver.conflictItemCount=11, 
> DefaultDependencyCollector.collectTime=122702048, 
> DefaultDependencyCollector.transformTime=6173804}
> [DEBUG] org.commonjava.maven.ext:pom-manipulation-ext:jar:4.4-SNAPSHOT
> [DEBUG]javax.inject:javax.inject:jar:1:compile
> [DEBUG]org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.4:compile
> [DEBUG]   javax.enterprise:cdi-api:jar:1.0:compile
> [DEBUG]  javax.annotation:jsr250-api:jar:1.0:compile
> [DEBUG]   org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.3.4:compile
> [DEBUG]   
> org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
> [DEBUG]   org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile
> [DEBUG]   org.codehaus.plexus:plexus-utils:jar:3.1.0:compile (version 
> managed from default)
> [DEBUG]org.slf4j:slf4j-api:jar:1.7.30:compile
> [DEBUG] Populating class realm 
> coreExtension>org.commonjava.maven.ext:pom-manipulation-ext:4.4-SNAPSHOT
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/commonjava/maven/ext/pom-manipulation-ext/4.4-SNAPSHOT/pom-manipulation-ext-4.4-SNAPSHOT.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.4/org.eclipse.sisu.inject-0.3.4.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/codehaus/plexus/plexus-utils/3.1.0/plexus-utils-3.1.0.jar
> [DEBUG] Populating class realm maven.ext
> [INFO] Running Maven Manipulation Extension (PME) 

[jira] [Commented] (MNG-7160) Extension And Classloaders: difference of result given extension types

2023-02-17 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690580#comment-17690580
 ] 

ASF GitHub Bot commented on MNG-7160:
-

michael-o closed pull request #999: [3.8.x][MNG-7160] Ability to customize core 
extensions classloaders (#616)
URL: https://github.com/apache/maven/pull/999




> Extension And Classloaders: difference of result given extension types
> --
>
> Key: MNG-7160
> URL: https://issues.apache.org/jira/browse/MNG-7160
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.2, 3.8.1
>Reporter: Nick Cross
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> I have a project that we use for all of our internal Red Hat builds (although 
> primarily through its CLI mode hence not noticing this until 
> [https://github.com/release-engineering/pom-manipulation-ext/issues/832] was 
> submitted in the community). This project creates an extension (lib/ext 
> style) but trying to use it as a ".mvn/extensions.xml" it _seems_ to get a 
> classloader problem as _I think _the Maven Model/Plugin objects are created 
> within a different classloader which means when the Plugin configuration is 
> retrieved and cast to a Xpp3Dom object it fails. Is there some configuration 
> we are missing or is there a problem in how the classloading in Maven for 
> core extensions is working when using Xpp3Dom ?
> An reproducer branch is 
> [https://github.com/rnc/pom-manipulation-ext/tree/ISSUE832] 
>  (Simply build and install the project, then use it on any simple Maven 
> project with an extensions.xml with the command e.g. "mvn -X 
> -DversionSuffix=redhat-1" )
> An example log is below:
> {noformat}
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /home/rnc/Software/apache-maven-3.8.1
> Java version: 11.0.11, vendor: Red Hat, Inc., runtime: 
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.fc33.x86_64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "5.11.14-200.fc33.x86_64", arch: "amd64", family: 
> "unix"
> [DEBUG] Reading global settings from 
> /home/rnc/Software/apache-maven-3.8.1/conf/settings.xml
> [DEBUG] Reading user settings from /home/rnc/.m2/settings.xml
> [DEBUG] Using manager EnhancedLocalRepositoryManager with priority 10.0 for 
> /home/rnc/.m2/repository
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> repository.jboss.org (http://repository.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> snapshots.jboss.org (http://snapshots.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> oss.sonatype.org/jboss-snapshots 
> (http://oss.sonatype.org/content/repositories/jboss-snapshots).
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=644417, 
> ConflictMarker.markTime=145101, ConflictMarker.nodeCount=11, 
> ConflictIdSorter.graphTime=429885, ConflictIdSorter.topsortTime=359266, 
> ConflictIdSorter.conflictIdCount=10, ConflictIdSorter.conflictIdCycleCount=0, 
> ConflictResolver.totalTime=2854763, ConflictResolver.conflictItemCount=11, 
> DefaultDependencyCollector.collectTime=122702048, 
> DefaultDependencyCollector.transformTime=6173804}
> [DEBUG] org.commonjava.maven.ext:pom-manipulation-ext:jar:4.4-SNAPSHOT
> [DEBUG]javax.inject:javax.inject:jar:1:compile
> [DEBUG]org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.4:compile
> [DEBUG]   javax.enterprise:cdi-api:jar:1.0:compile
> [DEBUG]  javax.annotation:jsr250-api:jar:1.0:compile
> [DEBUG]   org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.3.4:compile
> [DEBUG]   
> org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
> [DEBUG]   org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile
> [DEBUG]   org.codehaus.plexus:plexus-utils:jar:3.1.0:compile (version 
> managed from default)
> [DEBUG]org.slf4j:slf4j-api:jar:1.7.30:compile
> [DEBUG] Populating class realm 
> coreExtension>org.commonjava.maven.ext:pom-manipulation-ext:4.4-SNAPSHOT
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/commonjava/maven/ext/pom-manipulation-ext/4.4-SNAPSHOT/pom-manipulation-ext-4.4-SNAPSHOT.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.4/org.eclipse.sisu.inject-0.3.4.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/codehaus/plexus/plexus-utils/3.1.0/plexus-utils-3.1.0.jar
> [DEBUG] Populating class realm maven.ext
> [INFO] Running 

[GitHub] [maven] michael-o closed pull request #999: [3.8.x][MNG-7160] Ability to customize core extensions classloaders (#616)

2023-02-17 Thread via GitHub


michael-o closed pull request #999: [3.8.x][MNG-7160] Ability to customize core 
extensions classloaders (#616)
URL: https://github.com/apache/maven/pull/999


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] michael-o commented on pull request #999: [3.8.x][MNG-7160] Ability to customize core extensions classloaders (#616)

2023-02-17 Thread via GitHub


michael-o commented on PR #999:
URL: https://github.com/apache/maven/pull/999#issuecomment-1435229772

   Merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MNG-7160) Extension And Classloaders: difference of result given extension types

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7160:

Fix Version/s: 3.8.8
   (was: 3.8.x-candidate)

> Extension And Classloaders: difference of result given extension types
> --
>
> Key: MNG-7160
> URL: https://issues.apache.org/jira/browse/MNG-7160
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.2, 3.8.1
>Reporter: Nick Cross
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> I have a project that we use for all of our internal Red Hat builds (although 
> primarily through its CLI mode hence not noticing this until 
> [https://github.com/release-engineering/pom-manipulation-ext/issues/832] was 
> submitted in the community). This project creates an extension (lib/ext 
> style) but trying to use it as a ".mvn/extensions.xml" it _seems_ to get a 
> classloader problem as _I think _the Maven Model/Plugin objects are created 
> within a different classloader which means when the Plugin configuration is 
> retrieved and cast to a Xpp3Dom object it fails. Is there some configuration 
> we are missing or is there a problem in how the classloading in Maven for 
> core extensions is working when using Xpp3Dom ?
> An reproducer branch is 
> [https://github.com/rnc/pom-manipulation-ext/tree/ISSUE832] 
>  (Simply build and install the project, then use it on any simple Maven 
> project with an extensions.xml with the command e.g. "mvn -X 
> -DversionSuffix=redhat-1" )
> An example log is below:
> {noformat}
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /home/rnc/Software/apache-maven-3.8.1
> Java version: 11.0.11, vendor: Red Hat, Inc., runtime: 
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.fc33.x86_64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "5.11.14-200.fc33.x86_64", arch: "amd64", family: 
> "unix"
> [DEBUG] Reading global settings from 
> /home/rnc/Software/apache-maven-3.8.1/conf/settings.xml
> [DEBUG] Reading user settings from /home/rnc/.m2/settings.xml
> [DEBUG] Using manager EnhancedLocalRepositoryManager with priority 10.0 for 
> /home/rnc/.m2/repository
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> repository.jboss.org (http://repository.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> snapshots.jboss.org (http://snapshots.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> oss.sonatype.org/jboss-snapshots 
> (http://oss.sonatype.org/content/repositories/jboss-snapshots).
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=644417, 
> ConflictMarker.markTime=145101, ConflictMarker.nodeCount=11, 
> ConflictIdSorter.graphTime=429885, ConflictIdSorter.topsortTime=359266, 
> ConflictIdSorter.conflictIdCount=10, ConflictIdSorter.conflictIdCycleCount=0, 
> ConflictResolver.totalTime=2854763, ConflictResolver.conflictItemCount=11, 
> DefaultDependencyCollector.collectTime=122702048, 
> DefaultDependencyCollector.transformTime=6173804}
> [DEBUG] org.commonjava.maven.ext:pom-manipulation-ext:jar:4.4-SNAPSHOT
> [DEBUG]javax.inject:javax.inject:jar:1:compile
> [DEBUG]org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.4:compile
> [DEBUG]   javax.enterprise:cdi-api:jar:1.0:compile
> [DEBUG]  javax.annotation:jsr250-api:jar:1.0:compile
> [DEBUG]   org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.3.4:compile
> [DEBUG]   
> org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
> [DEBUG]   org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile
> [DEBUG]   org.codehaus.plexus:plexus-utils:jar:3.1.0:compile (version 
> managed from default)
> [DEBUG]org.slf4j:slf4j-api:jar:1.7.30:compile
> [DEBUG] Populating class realm 
> coreExtension>org.commonjava.maven.ext:pom-manipulation-ext:4.4-SNAPSHOT
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/commonjava/maven/ext/pom-manipulation-ext/4.4-SNAPSHOT/pom-manipulation-ext-4.4-SNAPSHOT.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.4/org.eclipse.sisu.inject-0.3.4.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/codehaus/plexus/plexus-utils/3.1.0/plexus-utils-3.1.0.jar
> [DEBUG] Populating class realm maven.ext
> [INFO] Running Maven Manipulation Extension (PME) 4.4-SNAPSHOT ( SHA: 
> 305cdb0d )
> [DEBUG] Created new class realm maven.api
> [DEBUG] 

[jira] [Commented] (MNG-7160) Extension And Classloaders: difference of result given extension types

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690578#comment-17690578
 ] 

Michael Osipov commented on MNG-7160:
-

Fixed with 
[77ba96f686e82e5333403ed0597bfefad29d9283|https://gitbox.apache.org/repos/asf?p=maven.git=commit=77ba96f686e82e5333403ed0597bfefad29d9283]
 for maven-3.8.x branch.

> Extension And Classloaders: difference of result given extension types
> --
>
> Key: MNG-7160
> URL: https://issues.apache.org/jira/browse/MNG-7160
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.6.2, 3.8.1
>Reporter: Nick Cross
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-2, 4.0.0, 3.8.8
>
>
> I have a project that we use for all of our internal Red Hat builds (although 
> primarily through its CLI mode hence not noticing this until 
> [https://github.com/release-engineering/pom-manipulation-ext/issues/832] was 
> submitted in the community). This project creates an extension (lib/ext 
> style) but trying to use it as a ".mvn/extensions.xml" it _seems_ to get a 
> classloader problem as _I think _the Maven Model/Plugin objects are created 
> within a different classloader which means when the Plugin configuration is 
> retrieved and cast to a Xpp3Dom object it fails. Is there some configuration 
> we are missing or is there a problem in how the classloading in Maven for 
> core extensions is working when using Xpp3Dom ?
> An reproducer branch is 
> [https://github.com/rnc/pom-manipulation-ext/tree/ISSUE832] 
>  (Simply build and install the project, then use it on any simple Maven 
> project with an extensions.xml with the command e.g. "mvn -X 
> -DversionSuffix=redhat-1" )
> An example log is below:
> {noformat}
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /home/rnc/Software/apache-maven-3.8.1
> Java version: 11.0.11, vendor: Red Hat, Inc., runtime: 
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.fc33.x86_64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "5.11.14-200.fc33.x86_64", arch: "amd64", family: 
> "unix"
> [DEBUG] Reading global settings from 
> /home/rnc/Software/apache-maven-3.8.1/conf/settings.xml
> [DEBUG] Reading user settings from /home/rnc/.m2/settings.xml
> [DEBUG] Using manager EnhancedLocalRepositoryManager with priority 10.0 for 
> /home/rnc/.m2/repository
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> repository.jboss.org (http://repository.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> snapshots.jboss.org (http://snapshots.jboss.org/maven2).
> [DEBUG] Using mirror maven-default-http-blocker (http://0.0.0.0/) for 
> oss.sonatype.org/jboss-snapshots 
> (http://oss.sonatype.org/content/repositories/jboss-snapshots).
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=644417, 
> ConflictMarker.markTime=145101, ConflictMarker.nodeCount=11, 
> ConflictIdSorter.graphTime=429885, ConflictIdSorter.topsortTime=359266, 
> ConflictIdSorter.conflictIdCount=10, ConflictIdSorter.conflictIdCycleCount=0, 
> ConflictResolver.totalTime=2854763, ConflictResolver.conflictItemCount=11, 
> DefaultDependencyCollector.collectTime=122702048, 
> DefaultDependencyCollector.transformTime=6173804}
> [DEBUG] org.commonjava.maven.ext:pom-manipulation-ext:jar:4.4-SNAPSHOT
> [DEBUG]javax.inject:javax.inject:jar:1:compile
> [DEBUG]org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.4:compile
> [DEBUG]   javax.enterprise:cdi-api:jar:1.0:compile
> [DEBUG]  javax.annotation:jsr250-api:jar:1.0:compile
> [DEBUG]   org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.3.4:compile
> [DEBUG]   
> org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
> [DEBUG]   org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile
> [DEBUG]   org.codehaus.plexus:plexus-utils:jar:3.1.0:compile (version 
> managed from default)
> [DEBUG]org.slf4j:slf4j-api:jar:1.7.30:compile
> [DEBUG] Populating class realm 
> coreExtension>org.commonjava.maven.ext:pom-manipulation-ext:4.4-SNAPSHOT
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/commonjava/maven/ext/pom-manipulation-ext/4.4-SNAPSHOT/pom-manipulation-ext-4.4-SNAPSHOT.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.4/org.eclipse.sisu.inject-0.3.4.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
> [DEBUG]   Included 
> /home/rnc/.m2/repository/org/codehaus/plexus/plexus-utils/3.1.0/plexus-utils-3.1.0.jar
> [DEBUG] Populating class realm maven.ext
> 

[jira] [Commented] (MNG-7697) Cannot parse POM that contains an emoji in a comment

2023-02-17 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690577#comment-17690577
 ] 

Michael Osipov commented on MNG-7697:
-

Confirmed:
{noformat}
$ ./apache-maven-3.9.1-SNAPSHOT/bin/mvn -V package
Apache Maven 3.9.1-SNAPSHOT (0a299275e3666cee4bfa6ac6a5942344d3280a4b)
Maven home: /tmp/apache-maven-3.9.1-SNAPSHOT
Java version: 1.8.0_362, vendor: OpenJDK BSD Porting Team, runtime: 
/usr/local/openjdk8/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "freebsd", version: "12.4-stable", arch: "amd64", family: "unix"
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /tmp/pom.xml: Illegal character 0xd83d found in 
comment (position: START_TAG seen ...\n
> Key: MNG-7697
> URL: https://issues.apache.org/jira/browse/MNG-7697
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 3.9.0
> Environment: MacOS 13.2.1
> OpenJDK Runtime Environment Temurin-17.0.4+8 
>Reporter: Andrew Rosenberg
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
> Attachments: pom.xml
>
>
> {noformat}
>  mvn -e  clean install                            
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-parseable POM 
> /Users/andrew.rosenberg/.m2/repository/com/verygood/security/base-pom-17/0.2.47/base-pom-17-0.2.47.pom:
>  Illegal character 0xd83d found in comment (position: START_TAG seen 
> ...\n      

[jira] [Updated] (MNG-7697) Cannot parse POM that contains an emoji in a comment

2023-02-17 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7697:

Fix Version/s: (was: waiting-for-feedback)
   (was: wontfix-candidate)

> Cannot parse POM that contains an emoji in a comment
> 
>
> Key: MNG-7697
> URL: https://issues.apache.org/jira/browse/MNG-7697
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 3.9.0
> Environment: MacOS 13.2.1
> OpenJDK Runtime Environment Temurin-17.0.4+8 
>Reporter: Andrew Rosenberg
>Priority: Major
> Attachments: pom.xml
>
>
> {noformat}
>  mvn -e  clean install                            
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-parseable POM 
> /Users/andrew.rosenberg/.m2/repository/com/verygood/security/base-pom-17/0.2.47/base-pom-17-0.2.47.pom:
>  Illegal character 0xd83d found in comment (position: START_TAG seen 
> ...\n      

  1   2   >