[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #215: Fixes
slawekjaranowski commented on code in PR #215: URL: https://github.com/apache/maven-plugin-tools/pull/215#discussion_r1191937147 ## maven-plugin-report-plugin/pom.xml: ## @@ -88,6 +86,7 @@ org.apache.maven.doxia doxia-sink-api + 1.11.1 Review Comment: Most of dependency is managed, this one will not - only small inconsistency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] dependabot[bot] opened a new pull request, #115: Bump build-helper-maven-plugin from 3.3.0 to 3.4.0
dependabot[bot] opened a new pull request, #115:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/115
Bumps
[build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin)
from 3.3.0 to 3.4.0.
Release notes
Sourced from https://github.com/mojohaus/build-helper-maven-plugin/releases;>build-helper-maven-plugin's
releases.
3.4.0
Changes
New features and improvements
Get rid of ArtifactRepository - ${localRepository} (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/179;>#179)
https://github.com/slawekjaranowski;>@slawekjaranowski
Added a property name to the sources parameter for CLI usage
(https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/157;>#157)
https://github.com/gjd6640;>@gjd6640
Bug Fixes
Use UTF-8 for the pom (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/173;>#173)
https://github.com/gnodet;>@gnodet
Dependency updates
Bump maven-plugin-annotations from 3.8.1 to 3.8.2 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/177;>#177)
https://github.com/dependabot;>@dependabot
Bump parent from 72 to 74 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/175;>#175)
https://github.com/slawekjaranowski;>@slawekjaranowski
Bump maven-invoker-plugin to 3.5.1 - add support to run its with Java 20
(https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/172;>#172)
https://github.com/slachiewicz;>@slachiewicz
Bump actions/stale from 7 to 8 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/171;>#171)
https://github.com/dependabot;>@dependabot
Bump maven-plugin-annotations from 3.7.1 to 3.8.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/169;>#169)
https://github.com/dependabot;>@dependabot
Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/170;>#170)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 70 to 72 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/165;>#165)
https://github.com/dependabot;>@dependabot
Bump assertj-core from 3.24.1 to 3.24.2 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/164;>#164)
https://github.com/dependabot;>@dependabot
Bump maven-plugin-annotations from 3.7.0 to 3.7.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/163;>#163)
https://github.com/dependabot;>@dependabot
Bump assertj-core from 3.24.0 to 3.24.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/162;>#162)
https://github.com/dependabot;>@dependabot
Bump assertj-core from 3.23.1 to 3.24.0 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/161;>#161)
https://github.com/dependabot;>@dependabot
Bump actions/stale from 6 to 7 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/160;>#160)
https://github.com/dependabot;>@dependabot
Bump maven-plugin-annotations from 3.6.4 to 3.7.0 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/158;>#158)
https://github.com/dependabot;>@dependabot
Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/151;>#151)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 69 to 70 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/141;>#141)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 68 to 69 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/140;>#140)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 67 to 68 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/138;>#138)
https://github.com/dependabot;>@dependabot
Bump assertj-core from 3.22.0 to 3.23.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/137;>#137)
https://github.com/dependabot;>@dependabot
Bump plexus-utils from 3.4.1 to 3.4.2 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/135;>#135)
https://github.com/dependabot;>@dependabot
Bump actions/stale from 4 to 5 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/132;>#132)
https://github.com/dependabot;>@dependabot
Bump actions/setup-java from 2 to 3 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/133;>#133)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 65 to 67 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/130;>#130)
https://github.com/dependabot;>@dependabot
Bump actions/checkout from 2 to 3 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/128;>#128)
https://github.com/dependabot;>@dependabot
Bump maven-plugin-annotations from 3.6.2 to 3.6.4 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/126;>#126)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #215: Fixes
slawekjaranowski commented on code in PR #215:
URL:
https://github.com/apache/maven-plugin-tools/pull/215#discussion_r1191935798
##
pom.xml:
##
@@ -182,32 +180,11 @@
maven-settings
${mavenVersion}
-
+
-org.apache.maven.doxia
-doxia-sink-api
-${doxiaVersion}
-
-
-org.codehaus.plexus
-plexus-container-default
Review Comment:
I we have it on dependency list will generate warning in 3.9.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721978#comment-17721978 ] ASF GitHub Bot commented on MPIR-431: - belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1545008672 Yes this is the kind of conclusions I'd like to derive about the jdk versions by looking at the report, and just separating test scoped deps into its own column I agree it is too simplistic, but I think it offers more value than having only one column for all scopes. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] belingueres commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1545008672 Yes this is the kind of conclusions I'd like to derive about the jdk versions by looking at the report, and just separating test scoped deps into its own column I agree it is too simplistic, but I think it offers more value than having only one column for all scopes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPIR-437) 'Java version' is set to 0.0 when no JDK details are detected in dependencies
[ https://issues.apache.org/jira/browse/MPIR-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721976#comment-17721976 ] ASF GitHub Bot commented on MPIR-437: - belingueres opened a new pull request, #51: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/51 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPIR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPIR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MPIR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > 'Java version' is set to 0.0 when no JDK details are detected in dependencies > - > > Key: MPIR-437 > URL: https://issues.apache.org/jira/browse/MPIR-437 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.3 >Reporter: Gabriel Belingueres >Priority: Minor > Attachments: image-2023-05-11-22-20-45-789.png > > > Column 'Java version' in the summary row prints '0.0' when no JDK details are > detected in dependencies. Should print a '-' to be uniform with the remainder > of items in the table. > !image-2023-05-11-22-20-45-789.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] belingueres opened a new pull request, #51: [MPIR-437] 'Java version' is set to 0.0 when no JDK details are detected
belingueres opened a new pull request, #51: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/51 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPIR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPIR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MPIR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MPIR-437) 'Java version' is set to 0.0 when no JDK details are detected in dependencies
[ https://issues.apache.org/jira/browse/MPIR-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Belingueres updated MPIR-437: - Summary: 'Java version' is set to 0.0 when no JDK details are detected in dependencies (was: 'Java version' is se to 0.0 when no JDK details are detected in dependencies) > 'Java version' is set to 0.0 when no JDK details are detected in dependencies > - > > Key: MPIR-437 > URL: https://issues.apache.org/jira/browse/MPIR-437 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependencies >Affects Versions: 3.4.3 >Reporter: Gabriel Belingueres >Priority: Minor > Attachments: image-2023-05-11-22-20-45-789.png > > > Column 'Java version' in the summary row prints '0.0' when no JDK details are > detected in dependencies. Should print a '-' to be uniform with the remainder > of items in the table. > !image-2023-05-11-22-20-45-789.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPIR-437) 'Java version' is se to 0.0 when no JDK details are detected in dependencies
Gabriel Belingueres created MPIR-437: Summary: 'Java version' is se to 0.0 when no JDK details are detected in dependencies Key: MPIR-437 URL: https://issues.apache.org/jira/browse/MPIR-437 Project: Maven Project Info Reports Plugin Issue Type: Bug Components: dependencies Affects Versions: 3.4.3 Reporter: Gabriel Belingueres Attachments: image-2023-05-11-22-20-45-789.png Column 'Java version' in the summary row prints '0.0' when no JDK details are detected in dependencies. Should print a '-' to be uniform with the remainder of items in the table. !image-2023-05-11-22-20-45-789.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721965#comment-17721965
]
ASF GitHub Bot commented on MPIR-431:
-
belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191817536
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I'll create a separate issue for this. However the jdk detection seems to be
more complex. Currently org.codehaus.plexus:plexus-utils:3.5.0 dependency does
not detect any jdk details.
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] belingueres commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191817536
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I'll create a separate issue for this. However the jdk detection seems to be
more complex. Currently org.codehaus.plexus:plexus-utils:3.5.0 dependency does
not detect any jdk details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] dependabot[bot] opened a new pull request, #417: Bump build-helper-maven-plugin from 3.3.0 to 3.4.0
dependabot[bot] opened a new pull request, #417:
URL: https://github.com/apache/maven-site/pull/417
Bumps
[build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin)
from 3.3.0 to 3.4.0.
Release notes
Sourced from https://github.com/mojohaus/build-helper-maven-plugin/releases;>build-helper-maven-plugin's
releases.
3.4.0
Changes
New features and improvements
Get rid of ArtifactRepository - ${localRepository} (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/179;>#179)
https://github.com/slawekjaranowski;>@slawekjaranowski
Added a property name to the sources parameter for CLI usage
(https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/157;>#157)
https://github.com/gjd6640;>@gjd6640
Bug Fixes
Use UTF-8 for the pom (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/173;>#173)
https://github.com/gnodet;>@gnodet
Dependency updates
Bump maven-plugin-annotations from 3.8.1 to 3.8.2 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/177;>#177)
https://github.com/dependabot;>@dependabot
Bump parent from 72 to 74 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/175;>#175)
https://github.com/slawekjaranowski;>@slawekjaranowski
Bump maven-invoker-plugin to 3.5.1 - add support to run its with Java 20
(https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/172;>#172)
https://github.com/slachiewicz;>@slachiewicz
Bump actions/stale from 7 to 8 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/171;>#171)
https://github.com/dependabot;>@dependabot
Bump maven-plugin-annotations from 3.7.1 to 3.8.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/169;>#169)
https://github.com/dependabot;>@dependabot
Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/170;>#170)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 70 to 72 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/165;>#165)
https://github.com/dependabot;>@dependabot
Bump assertj-core from 3.24.1 to 3.24.2 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/164;>#164)
https://github.com/dependabot;>@dependabot
Bump maven-plugin-annotations from 3.7.0 to 3.7.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/163;>#163)
https://github.com/dependabot;>@dependabot
Bump assertj-core from 3.24.0 to 3.24.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/162;>#162)
https://github.com/dependabot;>@dependabot
Bump assertj-core from 3.23.1 to 3.24.0 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/161;>#161)
https://github.com/dependabot;>@dependabot
Bump actions/stale from 6 to 7 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/160;>#160)
https://github.com/dependabot;>@dependabot
Bump maven-plugin-annotations from 3.6.4 to 3.7.0 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/158;>#158)
https://github.com/dependabot;>@dependabot
Bump plexus-utils from 3.4.2 to 3.5.0 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/151;>#151)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 69 to 70 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/141;>#141)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 68 to 69 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/140;>#140)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 67 to 68 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/138;>#138)
https://github.com/dependabot;>@dependabot
Bump assertj-core from 3.22.0 to 3.23.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/137;>#137)
https://github.com/dependabot;>@dependabot
Bump plexus-utils from 3.4.1 to 3.4.2 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/135;>#135)
https://github.com/dependabot;>@dependabot
Bump actions/stale from 4 to 5 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/132;>#132)
https://github.com/dependabot;>@dependabot
Bump actions/setup-java from 2 to 3 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/133;>#133)
https://github.com/dependabot;>@dependabot
Bump mojo-parent from 65 to 67 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/130;>#130)
https://github.com/dependabot;>@dependabot
Bump actions/checkout from 2 to 3 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/128;>#128)
https://github.com/dependabot;>@dependabot
Bump maven-plugin-annotations from 3.6.2 to 3.6.4 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/126;>#126)
[jira] [Updated] (MCHECKSTYLE-429) Deprecation warning
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lenny Primak updated MCHECKSTYLE-429:
-
Affects Version/s: 3.2.2
> Deprecation warning
> ---
>
> Key: MCHECKSTYLE-429
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-429
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Lenny Primak
>Priority: Major
>
> Every time checkstyle plugin is ran, the following warning occurs:
> {code:java}
> [INFO] --- checkstyle:3.2.1:checkstyle (default) @ shiro-cdi ---
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> [INFO] Rendering content with
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [INFO] Starting audit...
> Audit done.
> {code}
> Looks like maven 3.9.x deprecated `localRepository` variable and the plugin
> needs to be updated to reflect this
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCHECKSTYLE-429) Deprecation warning
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721955#comment-17721955
]
Lenny Primak commented on MCHECKSTYLE-429:
--
Thanks guys! Looking forward to the fix!
> Deprecation warning
> ---
>
> Key: MCHECKSTYLE-429
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-429
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 3.2.1
>Reporter: Lenny Primak
>Priority: Major
>
> Every time checkstyle plugin is ran, the following warning occurs:
> {code:java}
> [INFO] --- checkstyle:3.2.1:checkstyle (default) @ shiro-cdi ---
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> [INFO] Rendering content with
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [INFO] Starting audit...
> Audit done.
> {code}
> Looks like maven 3.9.x deprecated `localRepository` variable and the plugin
> needs to be updated to reflect this
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPLUGIN-472) Use Plexus I18N rather than fiddling with resource bundles directly
[
https://issues.apache.org/jira/browse/MPLUGIN-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MPLUGIN-472:
---
Summary: Use Plexus I18N rather than fiddling with resource bundles
directly (was: Use Plexus I18N rathen than fiddling with resource bundles
directly)
> Use Plexus I18N rather than fiddling with resource bundles directly
> ---
>
> Key: MPLUGIN-472
> URL: https://issues.apache.org/jira/browse/MPLUGIN-472
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
>Affects Versions: 3.8.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0
>
>
> All reporting plugins use {{I18N}} for simplified and cached access to
> localized resource bundles. Replace direct access to RBs with the {{I18N}}
> interface.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MSHARED-1252) Bump plexus-io to 3.4.1 for maven-assembly-plugin
[ https://issues.apache.org/jira/browse/MSHARED-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1252. Resolution: Fixed > Bump plexus-io to 3.4.1 for maven-assembly-plugin > - > > Key: MSHARED-1252 > URL: https://issues.apache.org/jira/browse/MSHARED-1252 > Project: Maven Shared Components > Issue Type: Task > Components: maven-shared-utils >Affects Versions: maven-shared-utils-3.4.1 >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-shared-utils-3.4.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1252) Bump plexus-io to 3.4.1 for maven-assembly-plugin
[ https://issues.apache.org/jira/browse/MSHARED-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721906#comment-17721906 ] ASF GitHub Bot commented on MSHARED-1252: - slawekjaranowski merged PR #141: URL: https://github.com/apache/maven-shared-utils/pull/141 > Bump plexus-io to 3.4.1 for maven-assembly-plugin > - > > Key: MSHARED-1252 > URL: https://issues.apache.org/jira/browse/MSHARED-1252 > Project: Maven Shared Components > Issue Type: Task > Components: maven-shared-utils >Affects Versions: maven-shared-utils-3.4.1 >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-shared-utils-3.4.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-shared-utils] slawekjaranowski merged pull request #141: [MSHARED-1252] Bump plexus-io to 3.4.1 for maven-assembly-plugin
slawekjaranowski merged PR #141: URL: https://github.com/apache/maven-shared-utils/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7740) Target directory is flooded with consumer*pom files
[
https://issues.apache.org/jira/browse/MNG-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721900#comment-17721900
]
ASF GitHub Bot commented on MNG-7740:
-
Giovds commented on code in PR #1105:
URL: https://github.com/apache/maven/pull/1105#discussion_r1191651779
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -77,13 +80,34 @@ public void injectTransformedArtifacts(MavenProject
project, RepositorySystemSes
Files.createDirectories(buildDir);
generatedFile = Files.createTempFile(buildDir,
CONSUMER_POM_CLASSIFIER, "pom");
}
+
+removeOldConsumerPomFiles(generatedFile);
+
project.addAttachedArtifact(new ConsumerPomArtifact(project,
generatedFile, session));
} else if (project.getModel().isRoot()) {
throw new IllegalStateException(
"The use of the root attribute on the model requires the
buildconsumer feature to be active");
}
}
+private void removeOldConsumerPomFiles(Path generatedFile) throws
IOException {
+List oldConsumerPomFiles;
Review Comment:
I had a couple of reasons for it. The first reason for me is readability (as
I'll show down below).
The second is that I don't think its a good practice to wrap the checked
exception into a runtime exception (also introducing more code or a wrapper
'delete' method). Especially since `injectTransformedArtifacts()` already
throws a checked exception which is probably accounted for somewhere at some
point.
As far as I know when you rewrite the stream to something like
`stream.filter(path -> /*filter*/ }).forEach(Files::delete);` you either have
to wrap the checked exception thrown by `Files.delete(path)` into a runtime
exception:
```java
private void delete( Path path ) {
try { Files.delete( path ); }
catch ( IOException e ) { throw new RuntimeException("", e); }
}
/* obfuscated*/
stream.filter(path -> /*filter*/ })
.forEach(this::delete);
```
Or handle it:
```java
stream.filter(path -> /*filter*/ })
.forEach(path -> {
try { Files.delete(path); }
catch (IOException ex) { /*handle the exception*/ }
});
```
> Target directory is flooded with consumer*pom files
> ---
>
> Key: MNG-7740
> URL: https://issues.apache.org/jira/browse/MNG-7740
> Project: Maven
> Issue Type: Improvement
> Components: build/consumer, Core
>Affects Versions: 4.0.0-alpha-4
> Environment: Apache Maven 4.0.0-alpha-4
> (009cf4a7213aead8a7946a2397e2396c5927f30f)
> Maven home: /Users/maarten/Tools/apache-maven-4.0.0-alpha-4
> Java version: 17.0.6, vendor: Eclipse Adoptium, runtime:
> /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home
> Default locale: en_NL, platform encoding: UTF-8
> OS name: "mac os x", version: "13.2.1", arch: "aarch64", family: "mac"
>Reporter: Maarten Mulders
>Priority: Minor
> Labels: up-for-grabs
>
> After invoking Mavens {{validate}} or later lifecycle phase, there is a
> *consumerXXXpom* file left in the build directory. Here, XXX is a bunch of
> numbers.
> It is not harmful, but I dislike the fact that for every invocation of Maven,
> the file gets generated again and again. This can quickly lead to tens of
> files that are never used again anymore. I feel we should clean those files
> when we're done using them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] Giovds commented on a diff in pull request #1105: [MNG-7740] Remove old temporary consumer*pom files from buildDir
Giovds commented on code in PR #1105:
URL: https://github.com/apache/maven/pull/1105#discussion_r1191651779
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -77,13 +80,34 @@ public void injectTransformedArtifacts(MavenProject
project, RepositorySystemSes
Files.createDirectories(buildDir);
generatedFile = Files.createTempFile(buildDir,
CONSUMER_POM_CLASSIFIER, "pom");
}
+
+removeOldConsumerPomFiles(generatedFile);
+
project.addAttachedArtifact(new ConsumerPomArtifact(project,
generatedFile, session));
} else if (project.getModel().isRoot()) {
throw new IllegalStateException(
"The use of the root attribute on the model requires the
buildconsumer feature to be active");
}
}
+private void removeOldConsumerPomFiles(Path generatedFile) throws
IOException {
+List oldConsumerPomFiles;
Review Comment:
I had a couple of reasons for it. The first reason for me is readability (as
I'll show down below).
The second is that I don't think its a good practice to wrap the checked
exception into a runtime exception (also introducing more code or a wrapper
'delete' method). Especially since `injectTransformedArtifacts()` already
throws a checked exception which is probably accounted for somewhere at some
point.
As far as I know when you rewrite the stream to something like
`stream.filter(path -> /*filter*/ }).forEach(Files::delete);` you either have
to wrap the checked exception thrown by `Files.delete(path)` into a runtime
exception:
```java
private void delete( Path path ) {
try { Files.delete( path ); }
catch ( IOException e ) { throw new RuntimeException("", e); }
}
/* obfuscated*/
stream.filter(path -> /*filter*/ })
.forEach(this::delete);
```
Or handle it:
```java
stream.filter(path -> /*filter*/ })
.forEach(path -> {
try { Files.delete(path); }
catch (IOException ex) { /*handle the exception*/ }
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MASSEMBLY-974) Drop deprecated repository element
[ https://issues.apache.org/jira/browse/MASSEMBLY-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721890#comment-17721890 ] ASF GitHub Bot commented on MASSEMBLY-974: -- slawekjaranowski merged PR #145: URL: https://github.com/apache/maven-assembly-plugin/pull/145 > Drop deprecated repository element > -- > > Key: MASSEMBLY-974 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-974 > Project: Maven Assembly Plugin > Issue Type: Task >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.6.0 > > > As a followup for MASSEMBLY-957, the deprecated element is being dropped. > This updates model version to 2.2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721883#comment-17721883
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191606276
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
Look at
https://github.com/apache/maven-shared-jar/blob/3cd1e4d7060bba0b378c2f3bcb5bd00037b299dc/src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java#L92-L156.
If classes are corrupt or JAR contains only resources that value would be
`null`. Though this we can test with an minimal non-class JAR.
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191606276
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
Look at
https://github.com/apache/maven-shared-jar/blob/3cd1e4d7060bba0b378c2f3bcb5bd00037b299dc/src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java#L92-L156.
If classes are corrupt or JAR contains only resources that value would be
`null`. Though this we can test with an minimal non-class JAR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721881#comment-17721881
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191590748
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
Ha, you are right! Can we move to a separate issue? I think the wiser step
would be a change from `double` to `Double` and use `null` truly.
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191590748
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
Ha, you are right! Can we move to a separate issue? I think the wiser step
would be a change from `double` to `Double` and use `null` truly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721877#comment-17721877
]
ASF GitHub Bot commented on MPIR-431:
-
belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191582040
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I think that was a bug. If all dependencies have jarDetails.getJdkRevision()
== null, then the summary column would print "0.0" instead of "-". The same
goes for test scope dependencies (it might be the case that there are no test
scoped dependencies at all). Perhaps this is clearer: "if (version > 0.0d) "
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] belingueres commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version
belingueres commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191582040
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I think that was a bug. If all dependencies have jarDetails.getJdkRevision()
== null, then the summary column would print "0.0" instead of "-". The same
goes for test scope dependencies (it might be the case that there are no test
scoped dependencies at all). Perhaps this is clearer: "if (version > 0.0d) "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721875#comment-17721875 ] ASF GitHub Bot commented on MPIR-431: - michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1544525489 I think I do understand the objective behind this change, though I am not really happy with the output. I have changed the `full-pom` IT to contain a runtime and provided dependency, now lets look at the output:  It doesn't look right, it says that 19 dependencies requrie Java 1.8 to run, which is not correct and the same again with 1.5, but when tests are run they do not require 1.5, they do require 1.8 because the max version is necessary. I understand the opposite case where your code and deps need 1.8, but test deps are on 11. I don't think that the information is properly visualized here avoid misunderstandings. > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version
michael-o commented on PR #47: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1544525489 I think I do understand the objective behind this change, though I am not really happy with the output. I have changed the `full-pom` IT to contain a runtime and provided dependency, now lets look at the output:  It doesn't look right, it says that 19 dependencies requrie Java 1.8 to run, which is not correct and the same again with 1.5, but when tests are run they do not require 1.5, they do require 1.8 because the max version is necessary. I understand the opposite case where your code and deps need 1.8, but test deps are on 11. I don't think that the information is properly visualized here avoid misunderstandings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSKINS-228) Github Ribbon displaces header menu for width < 980px
[ https://issues.apache.org/jira/browse/MSKINS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721867#comment-17721867 ] Michael Osipov commented on MSKINS-228: --- Also look at MSKINS-209. > Github Ribbon displaces header menu for width < 980px > - > > Key: MSKINS-228 > URL: https://issues.apache.org/jira/browse/MSKINS-228 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.11.0 >Reporter: Konrad Windszus >Priority: Major > Attachments: Screenshot 2023-05-11 at 12.28.39.png, Screenshot > 2023-05-11 at 12.30.27.png > > > In case the browser width is less than 980px the hamburger menu appears in > the header bar. It is hidden though by the GitHub ribbon which inserts an > unneeded space at the top. > See attached screenshots which can be reproduced at > https://jackrabbit.apache.org/filevault/index.html > Width < 980 > !Screenshot 2023-05-11 at 12.28.39.png! > Width >= 980 > !Screenshot 2023-05-11 at 12.30.27.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[ https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MPIR-431: --- Assignee: Michael Osipov > Dependency file details section: segregate Java version column into execution > and test versions > --- > > Key: MPIR-431 > URL: https://issues.apache.org/jira/browse/MPIR-431 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependencies >Reporter: Gabriel Belingueres >Assignee: Michael Osipov >Priority: Minor > > In order to easily spot which is the minimum java version for execution > versus the minimum java version for building the project, divide the "Java > version" column into two columns: > Java version: max version between dependencies with scopes: compile, runtime, > provided, system. > Test Java version: max java version between all the test scoped dependencies. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions
[
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721866#comment-17721866
]
ASF GitHub Bot commented on MPIR-431:
-
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191545277
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I don't understand this. Why wasn't this required before?
> Dependency file details section: segregate Java version column into execution
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: dependencies
>Reporter: Gabriel Belingueres
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution
> versus the minimum java version for building the project, divide the "Java
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime,
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version
michael-o commented on code in PR #47:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1191545277
##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -632,6 +647,13 @@ private void renderSectionDependencyFileDetails() {
endSection();
}
+private String getHighestVersion(double version) {
+if (version >= 1.0d) {
Review Comment:
I don't understand this. Why wasn't this required before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MPMD-376) localRepository is deprecated
Gili created MPMD-376:
-
Summary: localRepository is deprecated
Key: MPMD-376
URL: https://issues.apache.org/jira/browse/MPMD-376
Project: Maven PMD Plugin
Issue Type: Bug
Reporter: Gili
When running PMD on my project, I get the following warning messages that seem
to be a problem in the Maven Plugin:
PMD 3.20.0
{code:java}
[WARNING] Parameter 'localRepository' is deprecated core expression; Avoid use
of ArtifactRepository type. If you need access to local repository, switch to
'${repositorySystemSession}' expression and get LRM from it instead.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[WARNING] Unable to locate Source XRef to link to - DISABLED
[WARNING] Unable to locate Source XRef to link to - DISABLED
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] ppalaga commented on issue #772: Timeout when connecting maven daemon
ppalaga commented on issue #772: URL: https://github.com/apache/maven-mvnd/issues/772#issuecomment-1544303112 @adamretter could you please try with the latest mvnd release? Do all those installation steps work for you locally on a fresh Windows machine? It would be nice to see in which state is the daemon process when client gives up trying to connect. Is the daemon process alive at all - to check that , you could add some sort of windows counterpart of `ps | grep java` to your GH actions script. Is it listening on the requested port (I'd do `netstat -tulpen | grep java` on linux)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] samarlah opened a new pull request, #1106: Create Jenkins artifact
samarlah opened a new pull request, #1106: URL: https://github.com/apache/maven/pull/1106 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] samarlah opened a new pull request, #1107: Create Jenkins artifact
samarlah opened a new pull request, #1107: URL: https://github.com/apache/maven/pull/1107 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on issue #840: Error resolving dependencies with variables and parent POMs - here: ${pom.version}
ppalaga commented on issue #840: URL: https://github.com/apache/maven-mvnd/issues/840#issuecomment-1544228597 @tmuerell it sounds like `pom.version` is supposed to be a built-in Maven property? I must say I never heart of such one. Could you perhaps try to replace it with a more standard `project.version` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7740) Target directory is flooded with consumer*pom files
[
https://issues.apache.org/jira/browse/MNG-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721826#comment-17721826
]
ASF GitHub Bot commented on MNG-7740:
-
mthmulders commented on code in PR #1105:
URL: https://github.com/apache/maven/pull/1105#discussion_r1191343803
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -77,13 +80,34 @@ public void injectTransformedArtifacts(MavenProject
project, RepositorySystemSes
Files.createDirectories(buildDir);
generatedFile = Files.createTempFile(buildDir,
CONSUMER_POM_CLASSIFIER, "pom");
}
+
+removeOldConsumerPomFiles(generatedFile);
+
project.addAttachedArtifact(new ConsumerPomArtifact(project,
generatedFile, session));
} else if (project.getModel().isRoot()) {
throw new IllegalStateException(
"The use of the root attribute on the model requires the
buildconsumer feature to be active");
}
}
+private void removeOldConsumerPomFiles(Path generatedFile) throws
IOException {
+List oldConsumerPomFiles;
Review Comment:
Why does the code collect all the files in a list if it could as well remove
them in the terminal operation of the `j.u.s.Stream`?
> Target directory is flooded with consumer*pom files
> ---
>
> Key: MNG-7740
> URL: https://issues.apache.org/jira/browse/MNG-7740
> Project: Maven
> Issue Type: Improvement
> Components: build/consumer, Core
>Affects Versions: 4.0.0-alpha-4
> Environment: Apache Maven 4.0.0-alpha-4
> (009cf4a7213aead8a7946a2397e2396c5927f30f)
> Maven home: /Users/maarten/Tools/apache-maven-4.0.0-alpha-4
> Java version: 17.0.6, vendor: Eclipse Adoptium, runtime:
> /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home
> Default locale: en_NL, platform encoding: UTF-8
> OS name: "mac os x", version: "13.2.1", arch: "aarch64", family: "mac"
>Reporter: Maarten Mulders
>Priority: Minor
> Labels: up-for-grabs
>
> After invoking Mavens {{validate}} or later lifecycle phase, there is a
> *consumerXXXpom* file left in the build directory. Here, XXX is a bunch of
> numbers.
> It is not harmful, but I dislike the fact that for every invocation of Maven,
> the file gets generated again and again. This can quickly lead to tens of
> files that are never used again anymore. I feel we should clean those files
> when we're done using them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] mthmulders commented on a diff in pull request #1105: [MNG-7740] Remove old temporary consumer*pom files from buildDir
mthmulders commented on code in PR #1105:
URL: https://github.com/apache/maven/pull/1105#discussion_r1191343803
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##
@@ -77,13 +80,34 @@ public void injectTransformedArtifacts(MavenProject
project, RepositorySystemSes
Files.createDirectories(buildDir);
generatedFile = Files.createTempFile(buildDir,
CONSUMER_POM_CLASSIFIER, "pom");
}
+
+removeOldConsumerPomFiles(generatedFile);
+
project.addAttachedArtifact(new ConsumerPomArtifact(project,
generatedFile, session));
} else if (project.getModel().isRoot()) {
throw new IllegalStateException(
"The use of the root attribute on the model requires the
buildconsumer feature to be active");
}
}
+private void removeOldConsumerPomFiles(Path generatedFile) throws
IOException {
+List oldConsumerPomFiles;
Review Comment:
Why does the code collect all the files in a list if it could as well remove
them in the terminal operation of the `j.u.s.Stream`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-mvnd] stefanzilske commented on issue #839: Custom settings file not found
stefanzilske commented on issue #839: URL: https://github.com/apache/maven-mvnd/issues/839#issuecomment-1543928494 Sorry, all I cannot say for now is that it is still an issue and it also exists with using Maven 3.9.1 and also 3.9.2 without mvnd. I will setup a small example project and share it with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-862) warns about depending on plexus-container-default
Jim Sellers created MDEP-862:
Summary: warns about depending on plexus-container-default
Key: MDEP-862
URL: https://issues.apache.org/jira/browse/MDEP-862
Project: Maven Dependency Plugin
Issue Type: Improvement
Affects Versions: 3.5.0
Environment: Apache Maven 3.9.2
(c9616018c7a021c1c39be70fb2843d6f5f9b8a1c)
Maven home: /mnt/c/users/sellersj/Downloads/apache-maven-3.9.2
Java version: 17.0.6, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "5.10.16.3-microsoft-standard-wsl2", arch: "amd64",
family: "unix"
Reporter: Jim Sellers
When using 3.9.2 it warns about using plexus-container-default
{code:title=sample command, path to maven specific}
~/Downloads/apache-maven-3.9.2/bin/mvn -V -B --lax-checksums
org.apache.maven.plugins:maven-dependency-plugin:RELEASE:unpack
-Dtransitive=false -DoutputDirectory=. -Dmdep.stripVersion=true
-Dartifact="org.apache.maven:apache-maven:3.9.2:zip:bin"
-Dmaven.plugin.validation=VERBOSE
{code}
{code:title=sample warning}
[WARNING]
[WARNING] Plugin validation issues were detected in 1 plugin(s)
[WARNING]
[WARNING] * org.apache.maven.plugins:maven-dependency-plugin:3.5.0
[WARNING] Declared at location(s):
[WARNING]* unknown
[WARNING] Used in module(s):
[WARNING]* org.apache.maven:standalone-pom:1
[WARNING] Plugin issue(s):
[WARNING]* Plugin depends on plexus-container-default, which is EOL
[WARNING]
[WARNING]
[WARNING] Fix reported issues by adjusting plugin configuration or by upgrading
above listed plugins. If no upgrade available, please notify plugin maintainers
about reported issues.
[WARNING] For more or less details, use 'maven.plugin.validation' property with
one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
[WARNING]
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-acr-plugin] dependabot[bot] opened a new pull request, #18: Bump mavenVersion from 3.2.5 to 3.9.2
dependabot[bot] opened a new pull request, #18: URL: https://github.com/apache/maven-acr-plugin/pull/18 Bumps `mavenVersion` from 3.2.5 to 3.9.2. Updates `maven-plugin-api` from 3.2.5 to 3.9.2 Release notes Sourced from https://github.com/apache/maven/releases;>maven-plugin-api's releases. 3.9.2 https://maven.apache.org/docs/3.9.2/release-notes.html;>Release Notes - Maven - Version 3.9.2 Bug [https://issues.apache.org/jira/browse/MNG-7750;>MNG-7750] - Interpolated properties in originalModel in an active profile. [https://issues.apache.org/jira/browse/MNG-7759;>MNG-7759] - java.lang.NullPointerException at org.apache.maven.repository.internal.DefaultModelCache.newInstance (DefaultModelCache.java:37) Improvement [https://issues.apache.org/jira/browse/MNG-7712;>MNG-7712] - Core should issue a warning if plugin depends on maven-compat [https://issues.apache.org/jira/browse/MNG-7741;>MNG-7741] - Add more information when using -Dmaven.repo.local.recordReverseTree=true [https://issues.apache.org/jira/browse/MNG-7754;>MNG-7754] - Improvement and extension of plugin validation [https://issues.apache.org/jira/browse/MNG-7767;>MNG-7767] - Tone down plugin validation report [https://issues.apache.org/jira/browse/MNG-7778;>MNG-7778] - Maven should print suppressed exceptions when a mojo fails Task [https://issues.apache.org/jira/browse/MNG-7749;>MNG-7749] - Upgrade animal-sniffer from 1.21 to 1.23 [https://issues.apache.org/jira/browse/MNG-7774;>MNG-7774] - Maven config and command line interpolation Dependency upgrade [https://issues.apache.org/jira/browse/MNG-7670;>MNG-7670] - Upgrade misc dependencies [https://issues.apache.org/jira/browse/MNG-7753;>MNG-7753] - Upgrade to Maven Resolver 1.9.8 [https://issues.apache.org/jira/browse/MNG-7769;>MNG-7769] - Upgrade to Maven Resolver 1.9.10 3.9.1 https://maven.apache.org/docs/3.9.1/release-notes.html;>Release Notes - Maven - Version 3.9.1 Overview About the Changes Regression fixes from Maven 3.9.0. General performance and other fixes. Potentially Breaking Core Changes (if migrating from 3.8.x) The Maven Resolver transport has changed from Wagon to “native HTTP”, see https://maven.apache.org/guides/mini/guide-resolver-transport.html;>Resolver Transport guide. Maven 2.x was auto-injecting an ancient version of plexus-utils dependency into the plugin classpath, and Maven 3.x continued doing this to preserve backward compatibility. Starting with Maven 3.9, it does not happen anymore. This change may lead to plugin breakage. The fix for affected plugin maintainers is to explicitly declare a dependency on plexus-utils. The workaround for affected plugin users is to add this dependency to plugin dependencies until issue is fixed by the affected plugin maintainer. See https://issues.apache.org/jira/browse/MNG-6965;>MNG-6965. Mojos are prevented to boostrap new instance of RepositorySystem (for example by using deprecated ServiceLocator), they should reuse RepositorySystem instance provided by Maven instead. See https://issues.apache.org/jira/browse/MNG-7471;>MNG-7471. Each line in .mvn/maven.config is now interpreted as a single argument. That is, if the file contains multiple arguments, these must now be placed on separate lines, see https://issues.apache.org/jira/browse/MNG-7684;>MNG-7684. ... (truncated) Commits https://github.com/apache/maven/commit/c9616018c7a021c1c39be70fb2843d6f5f9b8a1c;>c961601 [maven-release-plugin] prepare release maven-3.9.2 https://github.com/apache/maven/commit/c2331d37f52b81e036bd119ba985a4ae6d439f45;>c2331d3 [MNG-7778] - Include suppressed exceptions when logging failures (https://redirect.github.com/apache/maven/issues/1103;>#1103) https://github.com/apache/maven/commit/79556ddc6b1a560cc61ca9fe6a81be0b53fd1e09;>79556dd [MNG-7774] Maven config and command line interpolation (https://redirect.github.com/apache/maven/issues/1098;>#1098) https://github.com/apache/maven/commit/7cb87a6686505bb80167b9309293af2f204d6a3f;>7cb87a6 [MNG-7769] Update Resolver to 1.9.10 (https://redirect.github.com/apache/maven/issues/1101;>#1101) https://github.com/apache/maven/commit/a2428a69148d91c8eb7e063fad64d01635b5a829;>a2428a6 [MNG-7767] Tone down plugin validator (https://redirect.github.com/apache/maven/issues/1092;>#1092) https://github.com/apache/maven/commit/924dbfecf87fa7cc3cc21c840057272321440ea8;>924dbfe [MNG-7670] Update misc dependencies (https://redirect.github.com/apache/maven/issues/1089;>#1089) https://github.com/apache/maven/commit/a4b753253586db486dc8c5b2d44166aeb0c8cd51;>a4b7532 [MNG-7753] Upgrade to Resolver 1.9.8 (https://redirect.github.com/apache/maven/issues/1077;>#1077) https://github.com/apache/maven/commit/eb7cdefaaa90143b55c70febf5e67e14831fdb38;>eb7cdef [MNG-7759] Maven2
[GitHub] [maven-mvnd] gnodet commented on issue #839: Custom settings file not found
gnodet commented on issue #839: URL: https://github.com/apache/maven-mvnd/issues/839#issuecomment-1543857074 @stefanzilske do you have any more info ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MCHANGES-391) Change package from org.apache.maven.plugins.* to org.apache.maven.plugins.changes.*
[
https://issues.apache.org/jira/browse/MCHANGES-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MCHANGES-391:
---
Priority: Major (was: Blocker)
> Change package from org.apache.maven.plugins.* to
> org.apache.maven.plugins.changes.*
>
>
> Key: MCHANGES-391
> URL: https://issues.apache.org/jira/browse/MCHANGES-391
> Project: Maven Changes Plugin
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> The package structure should be made consistent with other plugins currently
> the tree looks like this:
> {noformat}
> .
> └── org
> └── apache
> └── maven
> └── plugins
> ├── announcement
> │ └── mailsender
> ├── changes
> │ └── schema
> ├── github
> ├── issues
> ├── jira
> ├── resource
> │ └── loader
> └── trac
> {noformat}
> And it should look like this:
> {noformat}
> .
> └── org
> └── apache
> └── maven
> └── plugins
> └── changes
> ├── announcement
> │ └── mailsender
> ├── github
> ├── issues
> ├── jira
> ├── resource
> │ └── loader
> ├── schema
> └── trac
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MCHANGES-396) Upgrade Eclipse EGit Github client to 5.3.0
[ https://issues.apache.org/jira/browse/MCHANGES-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MCHANGES-396: -- Assignee: Elliotte Rusty Harold > Upgrade Eclipse EGit Github client to 5.3.0 > --- > > Key: MCHANGES-396 > URL: https://issues.apache.org/jira/browse/MCHANGES-396 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade > Components: github >Affects Versions: 2.12.1 >Reporter: Luc Maisonobe >Assignee: Elliotte Rusty Harold >Priority: Major > Labels: Java8 > > In order to solve issue MCHANGES-378, it would be necessary > to first update the GiHubClient to the lastest version as commit > https://github.com/eclipse/egit-github/commit/03f87a38a842acf0f2958ef41d5dc34936eff074 > allows to set up a proxy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCHANGES-396) Upgrade Eclipse EGit Github client to 5.3.0
[ https://issues.apache.org/jira/browse/MCHANGES-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721733#comment-17721733 ] Elliotte Rusty Harold commented on MCHANGES-396: can now move to Java 1.8 so this should be unblocked > Upgrade Eclipse EGit Github client to 5.3.0 > --- > > Key: MCHANGES-396 > URL: https://issues.apache.org/jira/browse/MCHANGES-396 > Project: Maven Changes Plugin > Issue Type: Dependency upgrade > Components: github >Affects Versions: 2.12.1 >Reporter: Luc Maisonobe >Assignee: Elliotte Rusty Harold >Priority: Major > Labels: Java8 > > In order to solve issue MCHANGES-378, it would be necessary > to first update the GiHubClient to the lastest version as commit > https://github.com/eclipse/egit-github/commit/03f87a38a842acf0f2958ef41d5dc34936eff074 > allows to set up a proxy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCHANGES-416) Update parent pom to 39
Elliotte Rusty Harold created MCHANGES-416: -- Summary: Update parent pom to 39 Key: MCHANGES-416 URL: https://issues.apache.org/jira/browse/MCHANGES-416 Project: Maven Changes Plugin Issue Type: Dependency upgrade Reporter: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6829) Remove commons-lang3 dependency
[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721729#comment-17721729
]
ASF GitHub Bot commented on MNG-6829:
-
elharo merged PR #28:
URL: https://github.com/apache/maven-changes-plugin/pull/28
> Remove commons-lang3 dependency
> ---
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Labels: close-pending
> Fix For: 4.0.x-candidate
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-changes-plugin] elharo merged pull request #28: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
elharo merged PR #28: URL: https://github.com/apache/maven-changes-plugin/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSKINS-228) Github Ribbon displaces header menu for width < 980px
[
https://issues.apache.org/jira/browse/MSKINS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721721#comment-17721721
]
Konrad Windszus commented on MSKINS-228:
The problem is the {{position: static}} for {{navbar-fixed-top}} at
https://github.com/apache/maven-fluido-skin/blob/caa42db9d8de608cbfaa617dd0b3c0242ee12e3a/src/main/resources/css/bootstrap-2.3.2-responsive.css#L958.
That conflicts with the ribbon CSS
https://github.com/apache/maven-fluido-skin/blob/caa42db9d8de608cbfaa617dd0b3c0242ee12e3a/src/main/resources/css/gh-fork-ribbon.css#L30.
So one workaround would be to always display the top-bar (i.e. keep using
{{position: absolute}} even for width < 980).
> Github Ribbon displaces header menu for width < 980px
> -
>
> Key: MSKINS-228
> URL: https://issues.apache.org/jira/browse/MSKINS-228
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
>Affects Versions: fluido-1.11.0
>Reporter: Konrad Windszus
>Priority: Major
> Attachments: Screenshot 2023-05-11 at 12.28.39.png, Screenshot
> 2023-05-11 at 12.30.27.png
>
>
> In case the browser width is less than 980px the hamburger menu appears in
> the header bar. It is hidden though by the GitHub ribbon which inserts an
> unneeded space at the top.
> See attached screenshots which can be reproduced at
> https://jackrabbit.apache.org/filevault/index.html
> Width < 980
> !Screenshot 2023-05-11 at 12.28.39.png!
> Width >= 980
> !Screenshot 2023-05-11 at 12.30.27.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MSKINS-228) Github Ribbon displaces header menu for width < 980px
Konrad Windszus created MSKINS-228: -- Summary: Github Ribbon displaces header menu for width < 980px Key: MSKINS-228 URL: https://issues.apache.org/jira/browse/MSKINS-228 Project: Maven Skins Issue Type: Bug Components: Fluido Skin Affects Versions: fluido-1.11.0 Reporter: Konrad Windszus Attachments: Screenshot 2023-05-11 at 12.28.39.png, Screenshot 2023-05-11 at 12.30.27.png In case the browser width is less than 980px the hamburger menu appears in the header bar. It is hidden though by the GitHub ribbon which inserts an unneeded space at the top. See attached screenshots which can be reproduced at https://jackrabbit.apache.org/filevault/index.html Width < 980 !Screenshot 2023-05-11 at 12.28.39.png! Width >= 980 !Screenshot 2023-05-11 at 12.30.27.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] gnodet commented on issue #840: Error resolving dependencies with variables and parent POMs - here: ${pom.version}
gnodet commented on issue #840: URL: https://github.com/apache/maven-mvnd/issues/840#issuecomment-1543713750 @tmuerell do you have a reproducer ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-5227) The 'optional' flag of a dependency should be manageable.
[
https://issues.apache.org/jira/browse/MNG-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721711#comment-17721711
]
Stamatis Zampetakis commented on MNG-5227:
--
I hit this problem today in the Apache Hive project. To avoid licensing
problems we declared all JDBC driver dependencies as _runtime_ and _optional_
in the dependencyManagement section
([https://github.com/apache/hive/blob/47c784b46a951d4ee9ce2712f62aa6af92b71395/pom.xml#L1336)].
It took me a while to understand that actually the optional declaration in
dependencyManagement is ignored cause for some reason the maven dependency
plugin was showing that the dependency is optional when running the
{{dependency:tree}}.
Contrary to what others may think I would argue that this is a bug not a new
feature. If _optional_ is the only thing that is not handled in the
{{dependencyManagement}} section then this is quite unexpected. I think it
definitely deserves a mention in the
[documentation|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Management]
till this issue is fixed.
Are there any plans to include this in the next 4 release? Can I help with
something to move this forward.
> The 'optional' flag of a dependency should be manageable.
> -
>
> Key: MNG-5227
> URL: https://issues.apache.org/jira/browse/MNG-5227
> Project: Maven
> Issue Type: New Feature
> Components: Artifacts and Repositories
>Affects Versions: 3.0.3
>Reporter: Christian Schulte
>Priority: Minor
> Fix For: 4.0.x-candidate
>
> Attachments: MNG-5227.patch, MNG-5227.patch
>
>
> {code}
>
>
>
> groupId
> artifactId
> version
> false
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated
[ https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721703#comment-17721703 ] Slawomir Jaranowski commented on MASSEMBLY-843: --- [~abrarovm] - I have a plan to release in a few days, maybe today > finalName as readonly parameter makes common usecases very complicated > -- > > Key: MASSEMBLY-843 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-843 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.6.0 > > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-843) finalName as readonly parameter makes common usecases very complicated
[ https://issues.apache.org/jira/browse/MASSEMBLY-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721701#comment-17721701 ] Marat Abrarov commented on MASSEMBLY-843: - Hi [~sjaranowski], Are you aware of the schedule for release of Maven Assembly Plugin 3.6.0? This fix should help us to get rid of annoying build log messages which confuse my team members. Thank you. > finalName as readonly parameter makes common usecases very complicated > -- > > Key: MASSEMBLY-843 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-843 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Ulf Dreyer >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.6.0 > > > The "improvement" done in MASSEMBLY-817 makes some usecases very inconvenient: > We need to create an archive with one stable name (independent of e.g. > version) so we don't have to propagate these information to a bunch of > scripts. > The general solution (i.e. Stack-overflow) refers exactly to the finalName: > [http://stackoverflow.com/questions/20697144/can-not-set-the-final-jar-name-with-maven-assembly-plugin] > *Please change finalName back to a settable property.* > It being settable does not hurt anyone satisfied with the default naming > convention but makes some usecases vastly simpler (otherwise you have to > rename the artifact using yet another plugin or propagate version info > possibly through a chain of scripts) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-build-cache-extension] dependabot[bot] opened a new pull request, #80: Bump testcontainers-bom from 1.18.0 to 1.18.1
dependabot[bot] opened a new pull request, #80:
URL: https://github.com/apache/maven-build-cache-extension/pull/80
Bumps
[testcontainers-bom](https://github.com/testcontainers/testcontainers-java)
from 1.18.0 to 1.18.1.
Release notes
Sourced from https://github.com/testcontainers/testcontainers-java/releases;>testcontainers-bom's
releases.
1.18.1
What's Changed
Revert Add docker rootless support for macOS and desktop for Linux
(https://redirect.github.com/testcontainers/testcontainers-java/issues/6907;>#6907)
(https://redirect.github.com/testcontainers/testcontainers-java/issues/7015;>#7015)
https://github.com/eddumelendez;>@eddumelendez
Favor copy compose file instead of mount (https://redirect.github.com/testcontainers/testcontainers-java/issues/6945;>#6945)
https://github.com/eddumelendez;>@eddumelendez
Allow @Container to be used as a meta-annotation (https://redirect.github.com/testcontainers/testcontainers-java/issues/6914;>#6914)
https://github.com/eddumelendez;>@eddumelendez
Update docs version to ${GITHUB_REF##*/} (https://redirect.github.com/testcontainers/testcontainers-java/issues/6891;>#6891)
https://github.com/github-actions;>@github-actions
Update testcontainers version to ${GITHUB_REF##*/} (https://redirect.github.com/testcontainers/testcontainers-java/issues/6890;>#6890)
https://github.com/github-actions;>@github-actions
Features Enhancements
Support Kraft post Confluent Platform 7.4.0 (https://redirect.github.com/testcontainers/testcontainers-java/issues/7014;>#7014)
https://github.com/danielpetisme;>@danielpetisme
[Enhancement]: Alternative waiting strategy for Mockserver container (https://redirect.github.com/testcontainers/testcontainers-java/issues/6951;>#6951)
https://github.com/DenilssonMontoya;>@DenilssonMontoya
Update RedpandaContainer.java (https://redirect.github.com/testcontainers/testcontainers-java/issues/6939;>#6939)
https://github.com/shelajev;>@shelajev
Add docker rootless support for macOS and desktop for Linux (https://redirect.github.com/testcontainers/testcontainers-java/issues/6907;>#6907)
https://github.com/eddumelendez;>@eddumelendez
Bug Fixes
Lowercase identifier in DockerComposeContainer (https://redirect.github.com/testcontainers/testcontainers-java/issues/6944;>#6944)
https://github.com/eddumelendez;>@eddumelendez
Use the current thread's classloader for classes (https://redirect.github.com/testcontainers/testcontainers-java/issues/6926;>#6926)
https://github.com/snowe2010;>@snowe2010
Documentation
Support Kraft post Confluent Platform 7.4.0 (https://redirect.github.com/testcontainers/testcontainers-java/issues/7014;>#7014)
https://github.com/danielpetisme;>@danielpetisme
Add new section for test integrations (https://redirect.github.com/testcontainers/testcontainers-java/issues/6930;>#6930)
https://github.com/LeoColman;>@LeoColman
Fix typos in HiveMQ doc (https://redirect.github.com/testcontainers/testcontainers-java/issues/6925;>#6925)
https://github.com/DenilssonMontoya;>@DenilssonMontoya
Add real on_failure page (https://redirect.github.com/testcontainers/testcontainers-java/issues/6784;>#6784)
https://github.com/kiview;>@kiview
粒 Housekeeping
Update CassandraContainer comment to reflect compaitiblity with 4.x (https://redirect.github.com/testcontainers/testcontainers-java/issues/7013;>#7013)
https://github.com/wakingrufus;>@wakingrufus
Update lombok version to 1.18.26 (https://redirect.github.com/testcontainers/testcontainers-java/issues/6935;>#6935)
https://github.com/eddumelendez;>@eddumelendez
Fix generated pom with duplicated entries (https://redirect.github.com/testcontainers/testcontainers-java/issues/6931;>#6931)
https://github.com/eddumelendez;>@eddumelendez
Remove source compatibility check for kafka, localstack and mongodb (https://redirect.github.com/testcontainers/testcontainers-java/issues/6892;>#6892)
https://github.com/eddumelendez;>@eddumelendez
Dependency updates
Bump Pulsar version to 3.0.0 (https://redirect.github.com/testcontainers/testcontainers-java/issues/7016;>#7016)
https://github.com/nicoloboschi;>@nicoloboschi
Update Gradle Wrapper to 8.1.1 (https://redirect.github.com/testcontainers/testcontainers-java/issues/6933;>#6933)
https://github.com/github-actions;>@github-actions
Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/6912;>#6912)
https://github.com/eddumelendez;>@eddumelendez
Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/6908;>#6908)
https://github.com/eddumelendez;>@eddumelendez
Commits
https://github.com/testcontainers/testcontainers-java/commit/c64aab9fd5e3a452ee0faf793560327eb4da9841;>c64aab9
Support Kraft post Confluent Platform 7.4.0
[jira] [Closed] (MRESOLVER-304) DirectoryUtils should consider interpolation
[ https://issues.apache.org/jira/browse/MRESOLVER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-304. - Resolution: Won't Fix No need for code change in Resolver, this is handled in Maven 3.9.2 > DirectoryUtils should consider interpolation > > > Key: MRESOLVER-304 > URL: https://issues.apache.org/jira/browse/MRESOLVER-304 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 1.10.0 > > > As currently it cannot be interpolated, and it applies this logic: > * if "relative path" it resolves against local repo > * if "absolute path" it resolves against path > what would be ideal to introduce somehow 3rd case: > * resolve against local repo > * resolve against maven.multiModuleProjectDirectory > * resolve against absolute path > As new 2nd option would allow to check in filter config along with sources. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-304) DirectoryUtils should consider interpolation
[ https://issues.apache.org/jira/browse/MRESOLVER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721666#comment-17721666 ] Tamas Cservenak commented on MRESOLVER-304: --- This is now a reality with 3.9.2, so closing this issue out. DirectoryUtils lack context anyway, and proper solution is like refd MNG-7774, to do this on Maven level. > DirectoryUtils should consider interpolation > > > Key: MRESOLVER-304 > URL: https://issues.apache.org/jira/browse/MRESOLVER-304 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 1.10.0 > > > As currently it cannot be interpolated, and it applies this logic: > * if "relative path" it resolves against local repo > * if "absolute path" it resolves against path > what would be ideal to introduce somehow 3rd case: > * resolve against local repo > * resolve against maven.multiModuleProjectDirectory > * resolve against absolute path > As new 2nd option would allow to check in filter config along with sources. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-site] cstamas merged pull request #414: Maven 3.9.2 Release Notes
cstamas merged PR #414: URL: https://github.com/apache/maven-site/pull/414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
