[jira] [Closed] (MPOM-487) Bump parent to 32

2024-04-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MPOM-487.

Resolution: Fixed

> Bump parent to 32
> -
>
> Key: MPOM-487
> URL: https://issues.apache.org/jira/browse/MPOM-487
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-42
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPOM-487) Bump parent to 32

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836867#comment-17836867
 ] 

Slawomir Jaranowski commented on MPOM-487:
--

Done in 
https://github.com/apache/maven-parent/commit/015775545a339435be9841e110132155894a1649

> Bump parent to 32
> -
>
> Key: MPOM-487
> URL: https://issues.apache.org/jira/browse/MPOM-487
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-42
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836865#comment-17836865
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

slawekjaranowski commented on code in PR #234:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/234#discussion_r1564254632


##
src/test/java/org/apache/maven/plugin/compiler/CompilerTest.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugin.compiler;
+
+import java.io.File;
+
+import org.apache.maven.api.plugin.testing.InjectMojo;

Review Comment:
   Please use - `org.apache.maven.plugin.testing.junit5.InjectMojo`
   and other from `org.apache.maven.plugin.testing.junit5...`
   
   Package `org.apache.maven.api.plugin.testing` is for Maven 4





> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MCOMPILER-588-compiler-test] JUnit4 test framework to JUnit5 migration [maven-compiler-plugin]

2024-04-13 Thread via GitHub


slawekjaranowski commented on code in PR #234:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/234#discussion_r1564254632


##
src/test/java/org/apache/maven/plugin/compiler/CompilerTest.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugin.compiler;
+
+import java.io.File;
+
+import org.apache.maven.api.plugin.testing.InjectMojo;

Review Comment:
   Please use - `org.apache.maven.plugin.testing.junit5.InjectMojo`
   and other from `org.apache.maven.plugin.testing.junit5...`
   
   Package `org.apache.maven.api.plugin.testing` is for Maven 4



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ https://issues.apache.org/jira/browse/MCOMPILER-588 ]


Mikhail Deviatov deleted comment on MCOMPILER-588:


was (Author: JIRAUSER305049):
[~sjaranowski] sure
[https://github.com/apache/maven-compiler-plugin/pull/234|https://github.com/apache/maven-compiler-plugin/pull/234]

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836863#comment-17836863
 ] 

Mikhail Deviatov commented on MCOMPILER-588:


[~sjaranowski] sure
[https://github.com/apache/maven-compiler-plugin/pull/234|https://github.com/apache/maven-compiler-plugin/pull/234]

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPOM-447) activate javac's release flag when building with JDK supporting that feature

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836861#comment-17836861
 ] 

Slawomir Jaranowski commented on MPOM-447:
--

As we have the same in parent - it is not needed in Maven POMs

> activate javac's release flag when building with JDK supporting that feature
> 
>
> Key: MPOM-447
> URL: https://issues.apache.org/jira/browse/MPOM-447
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: MAVEN-41
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-42
>
>
> easy to do, prepares smooth transitioning
> and absolutely needeed when building with JDK 11+ as without this flag, it 
> may inject JDK APIs calls that are not supported by target platform



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836860#comment-17836860
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er opened a new pull request, #234:
URL: https://github.com/apache/maven-compiler-plugin/pull/234

   plexus-xml dependency didn't solve the problem




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MCOMPILER-588-compiler-test] JUnit4 test framework to JUnit5 migration [maven-compiler-plugin]

2024-04-13 Thread via GitHub


MidNight-er opened a new pull request, #234:
URL: https://github.com/apache/maven-compiler-plugin/pull/234

   plexus-xml dependency didn't solve the problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (MPOM-474) Bump org.codehaus.mojo:extra-enforcer-rules from 1.7.0 to 1.8.0

2024-04-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MPOM-474:


Assignee: Slawomir Jaranowski

> Bump org.codehaus.mojo:extra-enforcer-rules from 1.7.0 to 1.8.0
> ---
>
> Key: MPOM-474
> URL: https://issues.apache.org/jira/browse/MPOM-474
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-42
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836859#comment-17836859
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
---

Please create a PR even with simple one test ... I will can checkout and test 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836858#comment-17836858
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
---

to resolve {{java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode}} 
- please add:
{code:xml}

  org.codehaus.plexus
  plexus-xml
  3.0.0
  test

{code}

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ https://issues.apache.org/jira/browse/MCOMPILER-588 ]


Slawomir Jaranowski deleted comment on MCOMPILER-588:
---

was (Author: slawekjaranowski):
to resolve {{java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode}} 
- please add:
{code:xml}

  org.codehaus.plexus
  plexus-xml
  3.0.0
  test

{code}

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836854#comment-17836854
 ] 

Mikhail Deviatov edited comment on MCOMPILER-588 at 4/13/24 8:14 PM:
-

[~sjaranowski] 

I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait for so long when internal API is stabilized?
my solution binds to an internal API of specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 


was (Author: JIRAUSER305049):
[~sjaranowski] 

I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to an internal API of specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836854#comment-17836854
 ] 

Mikhail Deviatov edited comment on MCOMPILER-588 at 4/13/24 8:14 PM:
-

[~sjaranowski] 

I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait for so long when internal Maven API is stabilized?
my solution binds to an internal API of specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 


was (Author: JIRAUSER305049):
[~sjaranowski] 

I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait for so long when internal API is stabilized?
my solution binds to an internal API of specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836854#comment-17836854
 ] 

Mikhail Deviatov edited comment on MCOMPILER-588 at 4/13/24 8:12 PM:
-

[~sjaranowski] 

I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to an internal API of specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 


was (Author: JIRAUSER305049):
I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to an internal API of specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836854#comment-17836854
 ] 

Mikhail Deviatov edited comment on MCOMPILER-588 at 4/13/24 8:11 PM:
-

I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to an internal API of specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 


was (Author: JIRAUSER305049):
I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to internal API specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836854#comment-17836854
 ] 

Mikhail Deviatov edited comment on MCOMPILER-588 at 4/13/24 8:11 PM:
-

I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to internal API specific version of 
*maven-plugin-testing-harness* that is not gonna be subject to change. Applying 
it we get JUnit5 support right away. when internal maven API can be applied we 
can drop my solution in favor of native support.
what do you think about this approach?

 


was (Author: JIRAUSER305049):
I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to internal API *maven-plugin-testing-harness* that is not 
gonna be subject to change for a very long time. Applying it we get JUnit5 
support right away. when internal maven API can be applied we can drop my 
solution in favor of native support.
what do you think about this approach?

 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836854#comment-17836854
 ] 

Mikhail Deviatov commented on MCOMPILER-588:


I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to internal API *maven-plugin-testing-harness* that is not 
gonna be subject to change for a very long time. Applying it we get JUnit5 
support right away. when internal maven API can be applied we can drop my 
solution in favor of native support.
what do you think about this approach?

 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default

2024-04-13 Thread Gary D. Gregory (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836847#comment-17836847
 ] 

Gary D. Gregory commented on MARTIFACT-60:
--

YW & TY as well  

> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.0, 3.5.1
> Environment: Apache Maven 3.9.6 
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program 
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> Running the plugin is too chatty by default, for example, I don't need 
> everything that's NOT wrong. Just tell me what's wrong or nothing:
> {noformat}
> [INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
> [INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-artifact-plugin:3.5.0
> [INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
> [INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
> [INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-resources-plugin:3.3.1
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-compiler-plugin:3.13.0
> [INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>= 
> 5.1.9)
> [INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-surefire-plugin:3.2.5
> [INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0 
> (>= 3.2.0)
> [INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
> [INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1 
> (>= 3.2.1)
> [INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
> [INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
> [INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>= 
> 1.0.0.Final)
> [INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
> [INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
> {noformat}
> Either say nothing or, if you must, perhaps a single log event:
> "No issues found in 16 plugins." Note that sentences should start with a 
> capital letter.
> The current info would be fine at the debug logging level IMO.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836841#comment-17836841
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er commented on PR #233:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/233#issuecomment-2053705057

   maven-plugin-testing-harness has native JUnit5 support




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MCOMPILER-588] JUnit4 test framework to JUnit5 migration [maven-compiler-plugin]

2024-04-13 Thread via GitHub


MidNight-er commented on PR #233:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/233#issuecomment-2053705057

   maven-plugin-testing-harness has native JUnit5 support


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836840#comment-17836840
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er closed pull request #233: [MCOMPILER-588] JUnit4 test framework to 
JUnit5 migration
URL: https://github.com/apache/maven-compiler-plugin/pull/233




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MCOMPILER-588] JUnit4 test framework to JUnit5 migration [maven-compiler-plugin]

2024-04-13 Thread via GitHub


MidNight-er closed pull request #233: [MCOMPILER-588] JUnit4 test framework to 
JUnit5 migration
URL: https://github.com/apache/maven-compiler-plugin/pull/233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHADE-471) still timestamp issues

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836839#comment-17836839
 ] 

ASF GitHub Bot commented on MSHADE-471:
---

rmannibucau commented on PR #220:
URL: 
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2053704080

   Ultimately it could need some unit test (or it but it is overkill there and 
hard to do right) + what about documenting how to not need it (local=utc for 
the build)?




> still timestamp issues
> --
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: next-release
>
>
> MSHADE-420 is incomplete, problems still appear like 
> {noformat}1 / 1 
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar 
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │  -rw 2.0 fat   50 bl defN 24-Jan-23 12:20 
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw 2.0 fat0 bl defN 23-Oct-12 07:38 
> META-INF/native-image/jansi/
> │ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38 
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw 2.0 fat   60 bl defN 23-Oct-12 07:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38 
> META-INF/native-image/jansi/
> │ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38 
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw 2.0 fat   60 bl defN 23-Oct-12 06:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │  -rw 2.0 fat0 bl defN 24-Apr-11 20:18 
> eu/maveniverse/maven/toolbox/shared/
> {noformat}
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
> looks related to DST: probably need to apply what has been done in 
> plexus-archiver 
> https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHADE-471] deal with DST [maven-shade-plugin]

2024-04-13 Thread via GitHub


rmannibucau commented on PR #220:
URL: 
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2053704080

   Ultimately it could need some unit test (or it but it is overkill there and 
hard to do right) + what about documenting how to not need it (local=utc for 
the build)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MGPG-125] Fix "bestPractices" [maven-gpg-plugin]

2024-04-13 Thread via GitHub


cstamas merged PR #95:
URL: https://github.com/apache/maven-gpg-plugin/pull/95


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPOM-487) Bump parent to 32

2024-04-13 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-487:


 Summary: Bump parent to 32
 Key: MPOM-487
 URL: https://issues.apache.org/jira/browse/MPOM-487
 Project: Maven POMs
  Issue Type: Dependency upgrade
  Components: maven
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: MAVEN-42






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836837#comment-17836837
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
---

[~midnighter] you should be able to close your PR by yourself

We can split such work for some a few smaller PRs.
We can have - simple unit test which can be migrated first.
We can use both JUnit4 and JUnit 5 i one project, so we ca do it step by step.

By the way thanks for the effort and contributions.
 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836836#comment-17836836
 ] 

Mikhail Deviatov commented on MCOMPILER-588:


yeah, there is realy native JUnit5 suport. please close my PR in favor of their 
solution

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default

2024-04-13 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy closed MARTIFACT-60.
--
Fix Version/s: 3.5.2
 Assignee: Herve Boutemy
   Resolution: Fixed

> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.0, 3.5.1
> Environment: Apache Maven 3.9.6 
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program 
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> Running the plugin is too chatty by default, for example, I don't need 
> everything that's NOT wrong. Just tell me what's wrong or nothing:
> {noformat}
> [INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
> [INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-artifact-plugin:3.5.0
> [INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
> [INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
> [INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-resources-plugin:3.3.1
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-compiler-plugin:3.13.0
> [INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>= 
> 5.1.9)
> [INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-surefire-plugin:3.2.5
> [INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0 
> (>= 3.2.0)
> [INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
> [INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1 
> (>= 3.2.1)
> [INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
> [INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
> [INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>= 
> 1.0.0.Final)
> [INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
> [INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
> {noformat}
> Either say nothing or, if you must, perhaps a single log event:
> "No issues found in 16 plugins." Note that sentences should start with a 
> capital letter.
> The current info would be fine at the debug logging level IMO.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836834#comment-17836834
 ] 

ASF GitHub Bot commented on MARTIFACT-60:
-

hboutemy commented on PR #32:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/32#issuecomment-2053692701

   perfect, thank you




> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.0, 3.5.1
> Environment: Apache Maven 3.9.6 
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program 
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Priority: Major
>  Labels: pull-request-available
>
> Running the plugin is too chatty by default, for example, I don't need 
> everything that's NOT wrong. Just tell me what's wrong or nothing:
> {noformat}
> [INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
> [INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-artifact-plugin:3.5.0
> [INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
> [INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
> [INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-resources-plugin:3.3.1
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-compiler-plugin:3.13.0
> [INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>= 
> 5.1.9)
> [INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-surefire-plugin:3.2.5
> [INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0 
> (>= 3.2.0)
> [INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
> [INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1 
> (>= 3.2.1)
> [INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
> [INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
> [INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>= 
> 1.0.0.Final)
> [INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
> [INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
> {noformat}
> Either say nothing or, if you must, perhaps a single log event:
> "No issues found in 16 plugins." Note that sentences should start with a 
> capital letter.
> The current info would be fine at the debug logging level IMO.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836833#comment-17836833
 ] 

ASF GitHub Bot commented on MARTIFACT-60:
-

hboutemy merged PR #32:
URL: https://github.com/apache/maven-artifact-plugin/pull/32




> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.0, 3.5.1
> Environment: Apache Maven 3.9.6 
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program 
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Priority: Major
>  Labels: pull-request-available
>
> Running the plugin is too chatty by default, for example, I don't need 
> everything that's NOT wrong. Just tell me what's wrong or nothing:
> {noformat}
> [INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
> [INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-artifact-plugin:3.5.0
> [INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
> [INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
> [INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-resources-plugin:3.3.1
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-compiler-plugin:3.13.0
> [INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>= 
> 5.1.9)
> [INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
> [INFO] no known issue with 
> org.apache.maven.plugins:maven-surefire-plugin:3.2.5
> [INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0 
> (>= 3.2.0)
> [INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
> [INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1 
> (>= 3.2.1)
> [INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
> [INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
> [INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>= 
> 1.0.0.Final)
> [INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
> [INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
> {noformat}
> Either say nothing or, if you must, perhaps a single log event:
> "No issues found in 16 plugins." Note that sentences should start with a 
> capital letter.
> The current info would be fine at the debug logging level IMO.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MARTIFACT-60] artifact:3.5.0:check-buildplan is too chatty by default [maven-artifact-plugin]

2024-04-13 Thread via GitHub


hboutemy commented on PR #32:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/32#issuecomment-2053692701

   perfect, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MARTIFACT-60] artifact:3.5.0:check-buildplan is too chatty by default [maven-artifact-plugin]

2024-04-13 Thread via GitHub


hboutemy merged PR #32:
URL: https://github.com/apache/maven-artifact-plugin/pull/32


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MPOM-486) Enable autoVersionSubmodules for maven-release-plugin

2024-04-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MPOM-486.

Resolution: Fixed

> Enable autoVersionSubmodules for maven-release-plugin
> -
>
> Key: MPOM-486
> URL: https://issues.apache.org/jira/browse/MPOM-486
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-32
>
>
> In simple project this has no impact.
> In multi module project configuration can be simplified.
>  
> https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#autoVersionSubmodules



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPOM-486] Enable autoVersionSubmodules for maven-release-plugin [maven-apache-parent]

2024-04-13 Thread via GitHub


slawekjaranowski merged PR #213:
URL: https://github.com/apache/maven-apache-parent/pull/213


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add `defaultValue` for all boolean Mojo parameters defaulting to `false` [maven-shade-plugin]

2024-04-13 Thread via GitHub


hboutemy commented on code in PR #219:
URL: 
https://github.com/apache/maven-shade-plugin/pull/219#discussion_r1564118467


##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -197,7 +197,7 @@ public class ShadeMojo extends AbstractMojo {
  * 
  * If you like to change the name of the native artifact, you may use the 
build>finalName> setting. If this
  * is set to something different than build>finalName>, no file 
replacement will be performed, even if
- * shadedArtifactAttached is being used.
+ * {@link #shadedArtifactAttached} is false.

Review Comment:
   this part of the PR should IMHO just be dropped



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPLUGINTESTING-93) Prepare documentation / examples for JUnit 5 and Maven 3/4

2024-04-13 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPLUGINTESTING-93:
-

 Summary: Prepare documentation / examples for JUnit 5 and Maven 3/4
 Key: MPLUGINTESTING-93
 URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-93
 Project: Maven Plugin Testing
  Issue Type: Task
Reporter: Slawomir Jaranowski


We have implementation but documentation is lack ...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836832#comment-17836832
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
---

*maven-plugin-testing-harness* since 4.0.0-alpha-2 - MPLUGINTESTING-84 support 
Junit 5 for Maven 3 

Please look at example: https://github.com/apache/maven-clean-plugin/pull/27

yes ... documentation is missing, so I created issue to not forget 
MPLUGINTESTING-93

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


 [ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Deviatov updated MCOMPILER-588:
---
Description: 
We have JUnit5 test framework for a long time. 
It have modular architecture, good support in IDE and quite fast. It would be 
good to add support JUnit5 to the project.
The problem is that there are 2 library used for testing in project 
*maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
don't have JUnit5 support.
I created a solution that overrides parts of code used derived and my own 
implementation.
Please take a look at it
https://github.com/apache/maven-compiler-plugin/pull/233

  was:
We have JUnit5 test framework for a long time. 
It have modular architecture, good support in IDE and quite fast. It would be 
good to add support JUnit5 to the project.
The problem is that there are 2 library used for testing in project 
*maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
don't have JUnit5 support.


> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Add `defaultValue` for all boolean Mojo parameters defaulting to `false` [maven-shade-plugin]

2024-04-13 Thread via GitHub


hboutemy commented on code in PR #219:
URL: 
https://github.com/apache/maven-shade-plugin/pull/219#discussion_r1564113505


##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -197,7 +197,7 @@ public class ShadeMojo extends AbstractMojo {
  * 
  * If you like to change the name of the native artifact, you may use the 
build>finalName> setting. If this
  * is set to something different than build>finalName>, no file 
replacement will be performed, even if
- * shadedArtifactAttached is being used.
+ * {@link #shadedArtifactAttached} is false.

Review Comment:
   to me, "shadedArtifactAttached is being used" means setting it to `true`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add `defaultValue` for all boolean Mojo parameters defaulting to `false` [maven-shade-plugin]

2024-04-13 Thread via GitHub


hboutemy commented on code in PR #219:
URL: 
https://github.com/apache/maven-shade-plugin/pull/219#discussion_r1564113505


##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -197,7 +197,7 @@ public class ShadeMojo extends AbstractMojo {
  * 
  * If you like to change the name of the native artifact, you may use the 
build>finalName> setting. If this
  * is set to something different than build>finalName>, no file 
replacement will be performed, even if
- * shadedArtifactAttached is being used.
+ * {@link #shadedArtifactAttached} is false.

Review Comment:
   to me, "shadedArtifactAttached is being used" means setting is t to `true`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [MCOMPILER-588] JUnit4 test framework to JUnit5 migration [maven-compiler-plugin]

2024-04-13 Thread via GitHub


MidNight-er opened a new pull request, #233:
URL: https://github.com/apache/maven-compiler-plugin/pull/233

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ x] Each commit in the pull request should have a meaningful subject 
line and body.
- [ x] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ x] You have run the integration tests successfully (`mvn -Prun-its 
clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] DependencyScopeManager [maven]

2024-04-13 Thread via GitHub


cstamas closed pull request #1400: DependencyScopeManager
URL: https://github.com/apache/maven/pull/1400


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836831#comment-17836831
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er opened a new pull request, #233:
URL: https://github.com/apache/maven-compiler-plugin/pull/233

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ x] Each commit in the pull request should have a meaningful subject 
line and body.
- [ x] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ x] You have run the integration tests successfully (`mvn -Prun-its 
clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]

2024-04-13 Thread via GitHub


cstamas commented on PR #916:
URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2053687725

   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


 [ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Deviatov updated MCOMPILER-588:
---
Description: 
We have JUnit5 test framework for a long time. 
It have modular architecture, good support in IDE and quite fast. It would be 
good to add support JUnit5 to the project.
The problem is that there are 2 library used for testing in project 
*maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
don't have JUnit5 support.

  was:We have JUnit5 test framework for a long time. It have modular 
architecture, good support in IDE and quite fast. It would be good to add 
support JUnit5 to the project


> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)
Mikhail Deviatov created MCOMPILER-588:
--

 Summary: JUnit4 test framework to JUnit5 migration
 Key: MCOMPILER-588
 URL: https://issues.apache.org/jira/browse/MCOMPILER-588
 Project: Maven Compiler Plugin
  Issue Type: Improvement
Reporter: Mikhail Deviatov


We have JUnit5 test framework for a long time. It have modular architecture, 
good support in IDE and quite fast. It would be good to add support JUnit5 to 
the project



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHADE-471) still timestamp issues

2024-04-13 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MSHADE-471:
-
Fix Version/s: next-release

> still timestamp issues
> --
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: next-release
>
>
> MSHADE-420 is incomplete, problems still appear like 
> {noformat}1 / 1 
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar 
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │  -rw 2.0 fat   50 bl defN 24-Jan-23 12:20 
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw 2.0 fat0 bl defN 23-Oct-12 07:38 
> META-INF/native-image/jansi/
> │ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38 
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw 2.0 fat   60 bl defN 23-Oct-12 07:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38 
> META-INF/native-image/jansi/
> │ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38 
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw 2.0 fat   60 bl defN 23-Oct-12 06:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │  -rw 2.0 fat0 bl defN 24-Apr-11 20:18 
> eu/maveniverse/maven/toolbox/shared/
> {noformat}
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
> looks related to DST: probably need to apply what has been done in 
> plexus-archiver 
> https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHADE-471) still timestamp issues

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836829#comment-17836829
 ] 

ASF GitHub Bot commented on MSHADE-471:
---

hboutemy opened a new pull request, #220:
URL: https://github.com/apache/maven-shade-plugin/pull/220

   (no comment)




> still timestamp issues
> --
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Herve Boutemy
>Priority: Major
>
> MSHADE-420 is incomplete, problems still appear like 
> {noformat}1 / 1 
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar 
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │  -rw 2.0 fat   50 bl defN 24-Jan-23 12:20 
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw 2.0 fat0 bl defN 23-Oct-12 07:38 
> META-INF/native-image/jansi/
> │ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38 
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw 2.0 fat   60 bl defN 23-Oct-12 07:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38 
> META-INF/native-image/jansi/
> │ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38 
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw 2.0 fat   60 bl defN 23-Oct-12 06:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │  -rw 2.0 fat0 bl defN 24-Apr-11 20:18 
> eu/maveniverse/maven/toolbox/shared/
> {noformat}
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
> looks related to DST: probably need to apply what has been done in 
> plexus-archiver 
> https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHADE-471) still timestamp issues

2024-04-13 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MSHADE-471:
-
Description: 
MSHADE-420 is incomplete, problems still appear like 

{noformat}1 / 1 
target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar 
toolbox/target/toolbox-0.1.5-cli.jar
--- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
+++ toolbox/target/toolbox-0.1.5-cli.jar
├── zipinfo {}
│ @@ -735,96 +735,96 @@
│  -rw 2.0 fat   50 bl defN 24-Jan-23 12:20 
META-INF/maven/org.jline/jline/pom.properties
│ --rw 2.0 fat0 bl defN 23-Oct-12 07:38 
META-INF/native-image/jansi/
│ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38 
META-INF/native-image/jansi/jni-config.json
...
│ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.xml
│ --rw 2.0 fat   60 bl defN 23-Oct-12 07:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.properties
│ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38 
META-INF/native-image/jansi/
│ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38 
META-INF/native-image/jansi/jni-config.json
...
│ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.xml
│ +-rw 2.0 fat   60 bl defN 23-Oct-12 06:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.properties
│  -rw 2.0 fat0 bl defN 24-Apr-11 20:18 
eu/maveniverse/maven/toolbox/shared/
{noformat}

https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md

looks related to DST: probably need to apply what has been done in 
plexus-archiver 
https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36

  was:
MSHADE-420 is incomplete, problems still appear like 

{noformat}1 / 1 
target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar 
toolbox/target/toolbox-0.1.5-cli.jar
--- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
+++ toolbox/target/toolbox-0.1.5-cli.jar
├── zipinfo {}
│ @@ -735,96 +735,96 @@
│  -rw 2.0 fat   50 bl defN 24-Jan-23 12:20 
META-INF/maven/org.jline/jline/pom.properties
│ --rw 2.0 fat0 bl defN 23-Oct-12 07:38 
META-INF/native-image/jansi/
│ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38 
META-INF/native-image/jansi/jni-config.json
...
│ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.xml
│ --rw 2.0 fat   60 bl defN 23-Oct-12 07:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.properties
│ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38 
META-INF/native-image/jansi/
│ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38 
META-INF/native-image/jansi/jni-config.json
...
│ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.xml
│ +-rw 2.0 fat   60 bl defN 23-Oct-12 06:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.properties
│  -rw 2.0 fat0 bl defN 24-Apr-11 20:18 
eu/maveniverse/maven/toolbox/shared/
{noformat}

https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md


> still timestamp issues
> --
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Herve Boutemy
>Priority: Major
>
> MSHADE-420 is incomplete, problems still appear like 
> {noformat}1 / 1 
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar 
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │  -rw 2.0 fat   50 bl defN 24-Jan-23 12:20 
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw 2.0 fat0 bl defN 23-Oct-12 07:38 
> META-INF/native-image/jansi/
> │ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38 
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw 2.0 fat   60 bl defN 23-Oct-12 07:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38 
> META-INF/native-image/jansi/
> │ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38 
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38 
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw 2.0 fat   60 bl defN 23-Oct-12 06:38 
> 

[jira] [Updated] (MPOM-486) Enable autoVersionSubmodules for maven-release-plugin

2024-04-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-486:
-
Summary: Enable autoVersionSubmodules for maven-release-plugin  (was: Set 
autoVersionSubmodules to true for maven-release-plugin)

> Enable autoVersionSubmodules for maven-release-plugin
> -
>
> Key: MPOM-486
> URL: https://issues.apache.org/jira/browse/MPOM-486
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-32
>
>
> In simple project this has no impact.
> In multi module project configuration can be simplified.
>  
> https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#autoVersionSubmodules



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MPOM-486] Enable autoVersionSubmodules for maven-release-plugin [maven-apache-parent]

2024-04-13 Thread via GitHub


slawekjaranowski opened a new pull request, #213:
URL: https://github.com/apache/maven-apache-parent/pull/213

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPOM-486) Set autoVersionSubmodules to true for maven-release-plugin

2024-04-13 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-486:


 Summary: Set autoVersionSubmodules to true for maven-release-plugin
 Key: MPOM-486
 URL: https://issues.apache.org/jira/browse/MPOM-486
 Project: Maven POMs
  Issue Type: Improvement
  Components: asf
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: ASF-32


In simple project this has no impact.

In multi module project configuration can be simplified.

 

https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#autoVersionSubmodules



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MPOM-483) Make a separate module for documentation

2024-04-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MPOM-483.

Resolution: Fixed

> Make a separate module for documentation
> 
>
> Key: MPOM-483
> URL: https://issues.apache.org/jira/browse/MPOM-483
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf, maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-32, MAVEN-42
>
>
> Instead of having separate poms like {{site-pom.xml}} we can create separate 
> module for documentation.
> Thanks to this, we will get rid of the last manual step during release.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPOM-483) Make a separate module for documentation

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836826#comment-17836826
 ] 

ASF GitHub Bot commented on MPOM-483:
-

slawekjaranowski merged PR #513:
URL: https://github.com/apache/maven-site/pull/513




> Make a separate module for documentation
> 
>
> Key: MPOM-483
> URL: https://issues.apache.org/jira/browse/MPOM-483
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf, maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-32, MAVEN-42
>
>
> Instead of having separate poms like {{site-pom.xml}} we can create separate 
> module for documentation.
> Thanks to this, we will get rid of the last manual step during release.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPOM-483] Make a separate module for documentation [maven-apache-parent]

2024-04-13 Thread via GitHub


slawekjaranowski merged PR #210:
URL: https://github.com/apache/maven-apache-parent/pull/210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MPOM-483] Update Releasing A Parent POM according to new modules [maven-site]

2024-04-13 Thread via GitHub


slawekjaranowski merged PR #513:
URL: https://github.com/apache/maven-site/pull/513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MPOM-483] Make a separate module for documentation [maven-parent]

2024-04-13 Thread via GitHub


slawekjaranowski merged PR #171:
URL: https://github.com/apache/maven-parent/pull/171


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MPOM-120) attach site descriptor only for pom packaging

2024-04-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MPOM-120.

Resolution: Won't Fix

> attach site descriptor only for pom packaging
> -
>
> Key: MPOM-120
> URL: https://issues.apache.org/jira/browse/MPOM-120
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-17
>Reporter: Herve Boutemy
>Priority: Minor
>
> publishing site.xml is only useful for parent poms, not for jar or any other 
> packaging: running attach-descriptor that will then skip attach is not useful
> would be better to avoid running the goal



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MPOM-485) Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1

2024-04-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MPOM-485.

Resolution: Fixed

> Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1
> -
>
> Key: MPOM-485
> URL: https://issues.apache.org/jira/browse/MPOM-485
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: MAVEN-42
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPOM-485] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [maven-parent]

2024-04-13 Thread via GitHub


slawekjaranowski merged PR #173:
URL: https://github.com/apache/maven-parent/pull/173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPOM-485) Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1

2024-04-13 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-485:


 Summary: Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1
 Key: MPOM-485
 URL: https://issues.apache.org/jira/browse/MPOM-485
 Project: Maven POMs
  Issue Type: Dependency upgrade
  Components: maven
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: MAVEN-42






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [maven-parent]

2024-04-13 Thread via GitHub


dependabot[bot] opened a new pull request, #173:
URL: https://github.com/apache/maven-parent/pull/173

   Bumps 
[org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils)
 from 4.0.0 to 4.0.1.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/plexus-utils/releases;>org.codehaus.plexus:plexus-utils's
 releases.
   
   4.0.1
   
    New features and improvements
   
   Add .gitignore to default excludes (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/269;>#269)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   downgrade plexus-xml from 4 to 3: keep Maven 3 compatibility (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/263;>#263)
 https://github.com/hboutemy;>@​hboutemy
   
    Dependency updates
   
   Bump org.codehaus.plexus:plexus from 16 to 17 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/268;>#268)
 https://github.com/dependabot;>@​dependabot
   Bump release-drafter/release-drafter from 5 to 6 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/267;>#267)
 https://github.com/dependabot;>@​dependabot
   Bump org.codehaus.plexus:plexus from 15 to 16 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/266;>#266)
 https://github.com/dependabot;>@​dependabot
   Bump org.codehaus.plexus:plexus from 14 to 15 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/265;>#265)
 https://github.com/dependabot;>@​dependabot
   downgrade plexus-xml from 4 to 3: keep Maven 3 compatibility (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/263;>#263)
 https://github.com/hboutemy;>@​hboutemy
   Bump plexus-xml from 4.0.0 to 4.0.2 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/259;>#259)
 https://github.com/dependabot;>@​dependabot
   Bump org.codehaus.plexus:plexus from 13 to 14 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/262;>#262)
 https://github.com/dependabot;>@​dependabot
   Bump org.junit.jupiter:junit-jupiter from 5.9.3 to 5.10.0 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/261;>#261)
 https://github.com/dependabot;>@​dependabot
   Bump junit-jupiter from 5.9.2 to 5.9.3 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/251;>#251)
 https://github.com/dependabot;>@​dependabot
   
    Maintenance
   
   pom.mxl and site.xml cleanup (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/257;>#257)
 https://github.com/hboutemy;>@​hboutemy
   
   
   
   
   Commits
   
   https://github.com/codehaus-plexus/plexus-utils/commit/31ef81812095709ebbfa0e4b707e1c3ad00a51e5;>31ef818
 [maven-release-plugin] prepare release plexus-utils-4.0.1
   https://github.com/codehaus-plexus/plexus-utils/commit/2f541fdfb253757a1f3beca33d75a86b124f78f5;>2f541fd
 Add .gitignore to default excludes
   https://github.com/codehaus-plexus/plexus-utils/commit/d44d2ec844fe3e420407936bbda0c015a386b5c5;>d44d2ec
 Bump org.codehaus.plexus:plexus from 16 to 17
   https://github.com/codehaus-plexus/plexus-utils/commit/13c1d5108a480cda6dd78c9b259690ac0f47822e;>13c1d51
 Bump release-drafter/release-drafter from 5 to 6
   https://github.com/codehaus-plexus/plexus-utils/commit/c7b6e18e1234c9debf72424e6abcdc2aa7bd6ba7;>c7b6e18
 Bump org.codehaus.plexus:plexus from 15 to 16
   https://github.com/codehaus-plexus/plexus-utils/commit/d4f0d2de40c5d6cb5d80c8a199fa4f32a4e59879;>d4f0d2d
 Cleanup after pom update
   https://github.com/codehaus-plexus/plexus-utils/commit/014185bd3799a304e81f1b45a4180def559eafde;>014185b
 Bump org.codehaus.plexus:plexus from 14 to 15
   https://github.com/codehaus-plexus/plexus-utils/commit/e0106e4bff35cf92b3429871cf69e725a7d71755;>e0106e4
 downgrade plexus-xml from 4 to 3: keep Maven 3 compatibility
   https://github.com/codehaus-plexus/plexus-utils/commit/b2cf572555a060e6c20ee223fb247c3d1e2139ad;>b2cf572
 describe optional dependency on plexus-xml
   https://github.com/codehaus-plexus/plexus-utils/commit/26f683a352d538090542018ab3ee03ba2a19ee08;>26f683a
 Bump plexus-xml from 4.0.0 to 4.0.2
   Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-4.0.0...plexus-utils-4.0.1;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-utils=maven=4.0.0=4.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate 

[jira] [Commented] (MPOM-483) Make a separate module for documentation

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836794#comment-17836794
 ] 

ASF GitHub Bot commented on MPOM-483:
-

slawekjaranowski opened a new pull request, #513:
URL: https://github.com/apache/maven-site/pull/513

   (no comment)




> Make a separate module for documentation
> 
>
> Key: MPOM-483
> URL: https://issues.apache.org/jira/browse/MPOM-483
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf, maven
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-32, MAVEN-42
>
>
> Instead of having separate poms like {{site-pom.xml}} we can create separate 
> module for documentation.
> Thanks to this, we will get rid of the last manual step during release.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MPOM-484) Bump org.apache.maven.plugins:maven-jar-plugin from 3.3.0 to 3.4.0

2024-04-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MPOM-484.

Resolution: Fixed

> Bump org.apache.maven.plugins:maven-jar-plugin from 3.3.0 to 3.4.0
> --
>
> Key: MPOM-484
> URL: https://issues.apache.org/jira/browse/MPOM-484
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-32
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8095) Usage of session.rootDirectory / session.topDirectory does not work

2024-04-13 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836779#comment-17836779
 ] 

Michael Osipov commented on MNG-8095:
-

This should have stayed open until the release notes are fixed.

> Usage of session.rootDirectory / session.topDirectory does not work
> ---
>
> Key: MNG-8095
> URL: https://issues.apache.org/jira/browse/MNG-8095
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2, 3.9.3, 3.9.4, 3.9.5, 3.9.6
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> I have setup a project which uses the following parts 
> (https://maven.apache.org/docs/3.9.2/release-notes.html)
> * {{$session.topDirectory}} 
> * {{$session.rootDirectory}} 
> * {{$project.rootDirectory}} 
> but unfortately they are not being replaced during the run of the project... 
> A small excerpt from the project... using the following simple configuration:
> {code:xml}
>   
> com.soebes.maven.plugins
> echo-maven-plugin
> 0.5.0
> 
>   
> initialize
> 
>   echo
> 
> 
>   
> 
> project.rootDirectory: '${project.rootDirectory}'
> session.rootDirectory: '${session.rootDirectory}'
> session.topDirectory: '${session.topDirectory}'
> project.basedir: '${project.basedir}'
> project.build.directory: 
> '${project.build.directory}'
> 
>   
> 
>   
> 
>   
> {code}
> My expectation is that during the build the values should be replaced with 
> the appropriate values which works with Maven 4 (Tested with Maven 
> 4-alpha-13) like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '/projects/props'
> [INFO] session.rootDirectory: '/projects/props'
> [INFO] session.topDirectory: '/projects/props'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> But the run with Maven 3.9.X it looks like this:
> {code}
> [INFO] --- echo:0.5.0:echo (default) @ sub-mod-2 ---
> [INFO] =
> [INFO] project.rootDirectory: '${project.rootDirectory}'
> [INFO] session.rootDirectory: '${session.rootDirectory}'
> [INFO] session.topDirectory: '${session.topDirectory}'
> [INFO] project.basedir: '/projects/props/sub-mod-2'
> [INFO] project.build.directory: '/projects/props/sub-mod-2/target'
> [INFO] =
> {code}
> I have setup a full working example here:
> https://github.com/khmarbaise/maven-bugs/tree/master/MNG-8095



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPOM-484] Bump org.apache.maven.plugins:maven-jar-plugin from 3.3.0 to 3.4.0 [maven-apache-parent]

2024-04-13 Thread via GitHub


slawekjaranowski merged PR #212:
URL: https://github.com/apache/maven-apache-parent/pull/212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPOM-484) Bump org.apache.maven.plugins:maven-jar-plugin from 3.3.0 to 3.4.0

2024-04-13 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-484:


 Summary: Bump org.apache.maven.plugins:maven-jar-plugin from 3.3.0 
to 3.4.0
 Key: MPOM-484
 URL: https://issues.apache.org/jira/browse/MPOM-484
 Project: Maven POMs
  Issue Type: Dependency upgrade
  Components: asf
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: ASF-32






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Bump org.apache.maven.plugins:maven-jar-plugin from 3.3.0 to 3.4.0 [maven-apache-parent]

2024-04-13 Thread via GitHub


dependabot[bot] opened a new pull request, #212:
URL: https://github.com/apache/maven-apache-parent/pull/212

   Bumps 
[org.apache.maven.plugins:maven-jar-plugin](https://github.com/apache/maven-jar-plugin)
 from 3.3.0 to 3.4.0.
   
   Release notes
   Sourced from https://github.com/apache/maven-jar-plugin/releases;>org.apache.maven.plugins:maven-jar-plugin's
 releases.
   
   3.4.0
   
    New features and improvements
   
   https://issues.apache.org/jira/browse/MJAR-296;>[MJAR-296] 
- Allow including files excluded by default. (https://redirect.github.com/apache/maven-jar-plugin/pull/67;>#67) https://github.com/redzi;>@​redzi
   https://issues.apache.org/jira/browse/MJAR-302;>[MJAR-302] 
- Require Maven 3.6.3 (https://redirect.github.com/apache/maven-jar-plugin/pull/77;>#77) https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MJAR-292;>[MJAR-292] 
- Detect MRJAR and add Multi-Release manifest entry (https://redirect.github.com/apache/maven-jar-plugin/pull/57;>#57) https://github.com/jorsol;>@​jorsol
   
    Bug Fixes
   
   https://issues.apache.org/jira/browse/MJAR-62;>[MJAR-62] - 
Set Build-Jdk according to used toolchain (https://redirect.github.com/apache/maven-jar-plugin/pull/73;>#73) https://github.com/slawekjaranowski;>@​slawekjaranowski
   
    Dependency updates
   
   https://issues.apache.org/jira/browse/MJAR-306;>[MJAR-306] 
- Use properties for plugins versions in LifecycleMapping (https://redirect.github.com/apache/maven-jar-plugin/pull/82;>#82) https://github.com/slawekjaranowski;>@​slawekjaranowski
   Bump org.junit:junit-bom from 5.10.1 to 5.10.2 (https://redirect.github.com/apache/maven-jar-plugin/pull/74;>#74) https://github.com/dependabot;>@​dependabot
   https://issues.apache.org/jira/browse/MJAR-298;>[MJAR-298] 
- Update Maven-Archiver to 3.6.2 (https://redirect.github.com/apache/maven-jar-plugin/pull/78;>#78) https://github.com/slawekjaranowski;>@​slawekjaranowski
   Bump apache/maven-gh-actions-shared from 2 to 4 (https://redirect.github.com/apache/maven-jar-plugin/pull/72;>#72) https://github.com/dependabot;>@​dependabot
   Bump commons-io:commons-io from 2.14.0 to 2.15.1 (https://redirect.github.com/apache/maven-jar-plugin/pull/68;>#68) https://github.com/dependabot;>@​dependabot
   https://issues.apache.org/jira/browse/MJAR-297;>[MJAR-297] 
- Update Parent to 40 (https://redirect.github.com/apache/maven-jar-plugin/pull/64;>#64) https://github.com/jorsol;>@​jorsol
   https://issues.apache.org/jira/browse/MJAR-298;>[MJAR-298] 
- Update Maven-Archiver to 3.6.1 (https://redirect.github.com/apache/maven-jar-plugin/pull/65;>#65) https://github.com/jorsol;>@​jorsol
   https://issues.apache.org/jira/browse/MJAR-293;>[MJAR-293] 
- Update Parent to 39 (https://redirect.github.com/apache/maven-jar-plugin/pull/59;>#59) https://github.com/jorsol;>@​jorsol
   
    Maintenance
   
   https://issues.apache.org/jira/browse/MJAR-304;>[MJAR-304] 
- Refresh download page (https://redirect.github.com/apache/maven-jar-plugin/pull/80;>#80) https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MJAR-303;>[MJAR-303] 
- Cleanup declared dependencies (https://redirect.github.com/apache/maven-jar-plugin/pull/79;>#79) https://github.com/slawekjaranowski;>@​slawekjaranowski
   Remove dependency on plexus (https://redirect.github.com/apache/maven-jar-plugin/pull/63;>#63) https://github.com/elharo;>@​elharo
   
   
   
   
   Commits
   
   https://github.com/apache/maven-jar-plugin/commit/992f44a2ef710326a6b98e18d4e40f724bea5f90;>992f44a
 [maven-release-plugin] prepare release maven-jar-plugin-3.4.0
   https://github.com/apache/maven-jar-plugin/commit/5e31b9933a68a44b180a499636f7f43c8521648c;>5e31b99
 [MJAR-296] Allow including files excluded by default. (https://redirect.github.com/apache/maven-jar-plugin/issues/67;>#67)
   https://github.com/apache/maven-jar-plugin/commit/ddfb635b55ec1ad23f83c4884a743b4a6c80a273;>ddfb635
 [MJAR-306] Use properties for plugins versions in LifecycleMapping
   https://github.com/apache/maven-jar-plugin/commit/aeffa392dd83040cde908c633b0ce2406850193b;>aeffa39
 [MJAR-304] Refresh download page
   https://github.com/apache/maven-jar-plugin/commit/ee85d599e14cbc69b71c65ade07b57f616217b57;>ee85d59
 [MJAR-303] Cleanup declared dependencies
   https://github.com/apache/maven-jar-plugin/commit/845c12071f2ec733c985c3d0eab3e48b1c15a486;>845c120
 Bump org.junit:junit-bom from 5.10.1 to 5.10.2
   https://github.com/apache/maven-jar-plugin/commit/8dd0d3f176fb28aa779cd2ddec9c342e834f38c6;>8dd0d3f
 [MJAR-298] Update Maven-Archiver to 3.6.2
   https://github.com/apache/maven-jar-plugin/commit/1b958d1804fa894eb4838c13b0532742751e5836;>1b958d1
 [MJAR-302] Require Maven 3.6.3
   https://github.com/apache/maven-jar-plugin/commit/fa4330fa687a98b1fa43c9bc8a574408b2ffe40b;>fa4330f
 [MJAR-62] Set Build-Jdk according to used toolchain
   

Re: [PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-apache-parent]

2024-04-13 Thread via GitHub


slawekjaranowski merged PR #211:
URL: https://github.com/apache/maven-apache-parent/pull/211


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MSHADE-471) still timestamp issues

2024-04-13 Thread Herve Boutemy (Jira)
Herve Boutemy created MSHADE-471:


 Summary: still timestamp issues
 Key: MSHADE-471
 URL: https://issues.apache.org/jira/browse/MSHADE-471
 Project: Maven Shade Plugin
  Issue Type: Bug
Affects Versions: 3.5.2
Reporter: Herve Boutemy


MSHADE-420 is incomplete, problems still appear like 

{noformat}1 / 1 
target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar 
toolbox/target/toolbox-0.1.5-cli.jar
--- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
+++ toolbox/target/toolbox-0.1.5-cli.jar
├── zipinfo {}
│ @@ -735,96 +735,96 @@
│  -rw 2.0 fat   50 bl defN 24-Jan-23 12:20 
META-INF/maven/org.jline/jline/pom.properties
│ --rw 2.0 fat0 bl defN 23-Oct-12 07:38 
META-INF/native-image/jansi/
│ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38 
META-INF/native-image/jansi/jni-config.json
...
│ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.xml
│ --rw 2.0 fat   60 bl defN 23-Oct-12 07:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.properties
│ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38 
META-INF/native-image/jansi/
│ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38 
META-INF/native-image/jansi/jni-config.json
...
│ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.xml
│ +-rw 2.0 fat   60 bl defN 23-Oct-12 06:38 
META-INF/maven/org.fusesource.jansi/jansi/pom.properties
│  -rw 2.0 fat0 bl defN 24-Apr-11 20:18 
eu/maveniverse/maven/toolbox/shared/
{noformat}

https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md



--
This message was sent by Atlassian Jira
(v8.20.10#820010)