[GitHub] cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7)
cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435514071 @jglick re copying, then we open a total different "pandora" box, think about dep artifact GAVs with differrent G's but same As and Vs (for example `/org/foo/1.0/api-1.0.jar` vs `/com/bar/1.0/api-1.0.jar`), we'd need to handle conflicts like these. Or we could copy them in maven2 layout (ie. create a mini "local repo" for surefire booter), and handle that. I'd def look into other directions as well... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7)
cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435506871
Btw, second look:
SiblingAggregatorIT POMs are not using `it-parent`, so that IT is kinda
fluke, it always tests with use Maven (3.6.0 it my case) Super-POM defined
surefire, not the built one. So it will never pass on affected JDK.
Surefire162CharsetProviderIT copied the jcharset into wrong repo, this is
why it did not found the artifact in local repo: it copied it to
`surefire-its/${env.HOME}/.m2/repository-oss/jcharset/jcharset/1.2.1/jcharset-1.2.1.jar`,
like did not interpolate things. Yes, my settings.xml defines my local repo as
`${env.HOME}/.m2/repository-oss`.
and finally, the Surefire1535TestNGParallelSuitesIT failure you got, don't
know what is it about, but: seems you are on Windows and you have local repo
and maven workdir on different drive letters. With affected JDK and this kind
of Windows setup this PR will not work. Unlike UN*X, Windows due drive letter
will not be able to "relativise" paths like these.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7)
cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435416391 @Tibor17 Tested 3.0.0-M1 on my machine, and it is OK. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7)
cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435387194 I just removed the log :) But go ahead, I dont want to stall This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7)
cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435386084 @Tibor17 So, do you want the changes you asked or you are fine? (priv method, logging changes, etc)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7)
cstamas commented on issue #197: SUREFIRE-1588 Patch (Java7) URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434728533 @Tibor17 Hi there! It might become necessary to make 2.22.2 bugfix release, as this seems to affect a LOT of people out there (seems this check is also in Oracle Java 1.8.0_191?) Will try to backport to java6 code then the fix, to not perform java language version change in a bugfix release. (or anyone out there is welcome to do the same) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
