[GitHub] khmarbaise commented on a change in pull request #1: [MWAR-371] - Overlays break first-win rule for web resource with target path ending with '/'
khmarbaise commented on a change in pull request #1: [MWAR-371] - Overlays break first-win rule for web resource with target path ending with '/' URL: https://github.com/apache/maven-war-plugin/pull/1#discussion_r223189348 ## File path: src/it/MWAR-371/pom.xml ## @@ -0,0 +1,25 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + mwar371 + mwar371 + 0.0.1-SNAPSHOT + pom + + generic + custom + + + + + + maven-war-plugin + 2.6 + Review comment: Why defining an different version than you are build with this build? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise commented on a change in pull request #1: [MWAR-371] - Overlays break first-win rule for web resource with target path ending with '/'
khmarbaise commented on a change in pull request #1: [MWAR-371] - Overlays break first-win rule for web resource with target path ending with '/' URL: https://github.com/apache/maven-war-plugin/pull/1#discussion_r223189332 ## File path: src/it/MWAR-371/custom/pom.xml ## @@ -0,0 +1,47 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + mwar371 + mwar371 + 0.0.1-SNAPSHOT + + custom + war + + + mwar371 + generic + 0.0.1-SNAPSHOT + war + + + + + + + maven-war-plugin + 3.2.3-SNAPSHOT + Review comment: The hard coded version is not a good idea...you should look at the other IT's as an example how to do this correctly. `@project.version@` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
