[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739721#comment-17739721
]
ASF GitHub Bot commented on MNG-6401:
-
gnodet commented on PR #163:
URL: https://github.com/apache/maven/pull/163#issuecomment-1619078481
Superseded by #1194
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739722#comment-17739722
]
ASF GitHub Bot commented on MNG-6401:
-
gnodet closed pull request #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739708#comment-17739708
]
ASF GitHub Bot commented on MNG-6401:
-
gnodet opened a new pull request, #1194:
URL: https://github.com/apache/maven/pull/1194
JIRA: https://issues.apache.org/jira/browse/MNG-6401
IT PR: https://github.com/apache/maven-integration-testing/pull/275
We do leverage the fact that we introduce a new model in 4.0 to add this
change in the model. The v3 model
still uses an int for the port, but the v4 uses a string to allow
interpolation of the port during the loading of the settings.xml
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737044#comment-17737044
]
ASF GitHub Bot commented on MNG-6401:
-
jjaychen1e commented on PR #163:
URL: https://github.com/apache/maven/pull/163#issuecomment-1606970900
Any updates?
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726436#comment-17726436
]
ASF GitHub Bot commented on MNG-6401:
-
WilliamYuhangLee commented on PR #163:
URL: https://github.com/apache/maven/pull/163#issuecomment-1563688366
Hi, can we please get some traction on this issue? It's now the middle of
2023 and yet Maven still has silly problems like this
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585147#comment-17585147
]
ASF GitHub Bot commented on MNG-6401:
-
jkatada commented on PR #163:
URL: https://github.com/apache/maven/pull/163#issuecomment-1228044228
@michael-o
My understanding of the current status of this PR is as follows
1. My PR is a regression to string interpolation. This PR should not be
merged.
2. The [`MNG-6401-2`](https://github.com/apache/maven/tree/MNG-6401-2)
branch by @hboutemy can resolve this issue while keeping object interpolation.
The `MNG-6401-2` branch can be rebased onto `master` and passed [my new
IT](https://github.com/apache/maven-integration-testing/pull/31).
```
[INFO] Tests run: 925, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
396.822 s - in org.apache.maven.it.IntegrationTestSuite
```
So I think the `MNG-6401-2` branch should be merged.
Is there anything else I can do to close this PR?
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17572162#comment-17572162
]
ASF GitHub Bot commented on MNG-6401:
-
berenddeboer commented on PR #163:
URL: https://github.com/apache/maven/pull/163#issuecomment-1197488679
So we're now close 5 years after this bug was first report. Numerous
developers have run into this bug and wasted their time googling this. Was this
really necessary
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031110#comment-17031110
]
Bruno commented on MNG-6401:
Hi, for the builds we are working on we need to use properties in settings.xml
to configure the proxy.
Then, the fix for this issue would be more than welcomed for us.
Do you have any status, timeline or information for the resolution ?
Thanks.
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 3.7.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731014#comment-16731014
]
Hervé Boutemy commented on MNG-6401:
[~slachiewicz] the interesting branch to merge is MNG-6401-2, which changes the
model to manage a String instead of an int, which permits variables
the MNG-6401 branch is a regression to XML as String interpolation which should
be avoided
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731013#comment-16731013
]
Hervé Boutemy commented on MNG-6401:
I re-read too: I didn't try the new IT with the code changed from int to
String, but I don't see why it would not work
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730838#comment-16730838
]
Michael Osipov commented on MNG-6401:
-
[~slachiewicz], as far as I remember I was about to merge this a couple of
months ago and [~hboutemy] and [~rfscholte] rushed in and gave some good
counter arguments in the PR itself. Have you read it? I will re-read it too.
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730833#comment-16730833
]
Sylwester Lachiewicz commented on MNG-6401:
---
[~michael-o] maybe w can try to add this to 3.6.1?
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, Settings
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483585#comment-16483585
]
ASF GitHub Bot commented on MNG-6401:
-
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-390888715
@hboutemy , looks good to me. Did you have a chance to run the new IT on?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.6.0-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483092#comment-16483092
]
ASF GitHub Bot commented on MNG-6401:
-
hboutemy commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-390789509
branch 6401-2 pushed, with port and active fields as String and handwritten
methods to provide compatibility
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.6.0-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483060#comment-16483060
]
ASF GitHub Bot commented on MNG-6401:
-
hboutemy commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-390782288
on handwritten, look at optional field in maven.mdo
I'm working on another branch to apply the same strategy: I'm currently
running core-its to check it works as expected, will report soon
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.6.0-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482815#comment-16482815
]
ASF GitHub Bot commented on MNG-6401:
-
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-390731655
> I know that we have such a case with booleans, where we do not put the
effective field type in the descriptor but String for more flexibility: in this
boolean case, it was about inheritance, to make the difference between
inheriting and overriding with a value.
Then there is a hand-written getter to get the field as boolean (instead of
the internal String)
This is another issue with our interpolation. Can you point me to that
handwritten spot?
> I don't know if we have such cases in Maven core with ints, but the
previous pattern hand-writing a typed getter to int should do the job.
The core model does not use ints, but only booleans for activation.
> switch back to String based interpolation instead of Object interpolation?
I don't see any quality difference between those two, from user POV
> change the field from int to String and add the hand-written getter?
This is going to be hard because a lot of our code relies on the int
#getPort().
If this PR breaks our approach w/o understanding previous motives, I'd stall
it for 3.6.0 or later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482453#comment-16482453
]
ASF GitHub Bot commented on MNG-6401:
-
hboutemy commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-390640786
on String interpolation vs Object interpolation:
String based interpolation was replaced by Object interpolation a few years
ago (perhaps during the switch from Maven 2 to Maven 3, I need to get precise
facts if necessary): I don't precisely know why (is Object interpolation more
robust, against XML injection?)
what I see in this precise case of proxy port interpolation: it's an int,
then it's hard to do Object interpolation on "${param}" value once it has been
transfrmed to a String...
at least, this give us the good root cause: if we want interpolation with
Object implementation, we need to change the field type to String
I know that we have such a case with booleans, where we do not put the
effective field type in the descriptor but String for more flexibility: in this
boolean case, it was about inheritance, to make the difference between
inheriting and overriding with a value.
Then there is a hand-written getter to get the field as boolean (instead of
the internal String)
I don't know if we have such cases in Maven core with ints, but the previous
pattern hand-writing a typed getter to int should do the job.
Now what's the best solution for now:
- switch back to String based interpolation instead of Object interpolation?
- change the field from int to String and add the hand-written getter?
at this time, I don't have strong opinion: I wanted to write and share the
analysis.
Now I need to dig into the reasons why we switched from String based
interpolation to Object based: this is where we should find the best view on
what issue could arise when getting back to former solution
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482064#comment-16482064
]
Hudson commented on MNG-6401:
-
Build failed in Jenkins: Maven TLP » maven » MNG-6401 #2
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6401/2/
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466759#comment-16466759
]
ASF GitHub Bot commented on MNG-6401:
-
jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-387263748
@rfscholte I changed the variable name. Please check.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466484#comment-16466484
]
ASF GitHub Bot commented on MNG-6401:
-
rfscholte commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-387209745
Looks interesting. It also looks more efficient. I would like to avoid
`effectiveSettings` here, because effective is the result after merging. Better
call it `interpolatedSettings`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465009#comment-16465009
]
ASF GitHub Bot commented on MNG-6401:
-
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386841740
As far as I understand this PR, you are interpolating the settings before it
is fed to `SettingsXpp3Reader`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464986#comment-16464986
]
ASF GitHub Bot commented on MNG-6401:
-
jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386855007
> As far as I understand this PR, you are interpolating the settings before
it is fead to SettingsXpp3Reader?
Yes, you are right.
> Can you also provide an IT for that?
I added the test to maven-integration-testing project. The PR is
[here](https://github.com/apache/maven-integration-testing/pull/31).
It tests not only int field (proxy.port) but also boolean field
(proxy.active).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464985#comment-16464985
]
ASF GitHub Bot commented on MNG-6401:
-
jkatada opened a new pull request #31: [MNG-6401] Add IT for interpolation in
settings.xml
URL: https://github.com/apache/maven-integration-testing/pull/31
[Corresponding Maven pull request.](https://github.com/apache/maven/pull/163)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464940#comment-16464940
]
Michael Osipov commented on MNG-6401:
-
Same applies to all boolean fields. It is even worse, you don't see a failure,
you it just sets value to {{false}}.
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464935#comment-16464935
]
ASF GitHub Bot commented on MNG-6401:
-
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386842019
Can you also provide an IT for that?
@hboutemy, @rfscholte This is a very interesting case and I can confirm that
our approach is incorrect. We need to interpolate the XML first and then
unmarshal to objects and not the other way around. Everything, but `String`
will be killed otherwise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464936#comment-16464936
]
Michael Osipov commented on MNG-6401:
-
Issue confirmed.
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464933#comment-16464933
]
ASF GitHub Bot commented on MNG-6401:
-
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386841740
As far as I understand this PR, you are interpolating the settings before it
is fead to `SettingsXpp3Reader`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464925#comment-16464925
]
KATADA Junya commented on MNG-6401:
---
Sorry, 3.5.3 is also affected.
I updated "Affects Version/s" field.
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464741#comment-16464741
]
Michael Osipov commented on MNG-6401:
-
Only 3.0 is affected? What about 3.5.3?
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
>
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
>
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`,
> but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460482#comment-16460482
]
ASF GitHub Bot commented on MNG-6401:
-
jkatada opened a new pull request #163: [MNG-6401] - Cannot interpolate
property in proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build
>Affects Versions: 3.0
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is
> [here|https://github.com/jkatada/maven-property-demo].
> In my demo, export two environment variables as follows.
> {quote}export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {quote}
> These variables are used in settings.xml for proxy settings.
> {quote}
> my_proxy
> true
> http
> ${env.MAVEN_PROXY_HOST_STRING}
> ${env.MAVEN_PROXY_PORT_INT}
> local.net|some.host.com
>
> {quote}
> Execute maven-help-plugin to show effective settings.xml.
> {quote}mvn help:effective-settings -X
> {quote}
> The result is as follows.
> {quote}
> 0
> proxy.foo.com
> local.net|some.host.com
> my_proxy
>
> {quote}
>
> `${env.MAVEN_PROXY_HOST_STRING}` is replaced with `proxy.foo.com`,
> but `${env.MAVEN_PROXY_PORT_INT}` is not replaced with `18080`.
> I found the following WARNING message in console.
> {quote}[WARNING] Some problems were encountered while building the effective
> settings
> [WARNING] Unable to parse element 'port', must be an integer (position:
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused
> by: java.lang.NumberFormatException: For input string:
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {quote}
> I think that the cause of this problem is to parse settings.xml before
> interpolation.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
