[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-12-03 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707952#comment-16707952
 ] 

Hervé Boutemy commented on MRESOLVER-36:


https://github.com/apache/maven-resolver/commit/e1976767cf714da24336339f7a6286c6ab50986a

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: 1.3.0
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-10-28 Thread JIRA


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1355#comment-1355
 ] 

Hervé Boutemy commented on MRESOLVER-36:


notice that some methods were removed, then compatibility is not kept and this 
breaks Intellij Maven integration: 
[https://youtrack.jetbrains.com/issue/IDEA-201282]

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: 1.3.0
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-07-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543404#comment-16543404
 ] 

ASF GitHub Bot commented on MRESOLVER-36:
-

slachiewicz closed pull request #18: [MRESOLVER-36] Make slf4j dependency 
required
URL: https://github.com/apache/maven-resolver/pull/18
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-resolver-connector-basic/pom.xml 
b/maven-resolver-connector-basic/pom.xml
index 0e896bc8..601e356e 100644
--- a/maven-resolver-connector-basic/pom.xml
+++ b/maven-resolver-connector-basic/pom.xml
@@ -62,7 +62,6 @@
 
   org.slf4j
   slf4j-api
-  provided
 
 
org.slf4j
diff --git a/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml 
b/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml
index 99a11503..733ac99d 100644
--- a/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml
+++ b/maven-resolver-demos/maven-resolver-demo-snippets/pom.xml
@@ -110,7 +110,6 @@
 
   org.slf4j
   slf4j-api
-  provided
 
 
   org.slf4j
diff --git a/maven-resolver-impl/pom.xml b/maven-resolver-impl/pom.xml
index ddfa9fc0..11365979 100644
--- a/maven-resolver-impl/pom.xml
+++ b/maven-resolver-impl/pom.xml
@@ -75,8 +75,6 @@
 
   org.slf4j
   slf4j-api
-  provided
-  true
 
 
   org.slf4j
diff --git a/maven-resolver-transport-file/pom.xml 
b/maven-resolver-transport-file/pom.xml
index ee670189..70445a47 100644
--- a/maven-resolver-transport-file/pom.xml
+++ b/maven-resolver-transport-file/pom.xml
@@ -79,7 +79,6 @@
 
   org.slf4j
   slf4j-api
-  provided
 
 
   org.slf4j
diff --git a/maven-resolver-transport-http/pom.xml 
b/maven-resolver-transport-http/pom.xml
index dce3dcd9..533150d1 100644
--- a/maven-resolver-transport-http/pom.xml
+++ b/maven-resolver-transport-http/pom.xml
@@ -125,7 +125,6 @@
 
   org.slf4j
   slf4j-api
-  provided
 
 
   org.slf4j
diff --git a/maven-resolver-transport-wagon/pom.xml 
b/maven-resolver-transport-wagon/pom.xml
index 5371d2a7..7a980ab4 100644
--- a/maven-resolver-transport-wagon/pom.xml
+++ b/maven-resolver-transport-wagon/pom.xml
@@ -111,7 +111,6 @@
 
   org.slf4j
   slf4j-api
-  provided
 
 
   org.slf4j
diff --git a/pom.xml b/pom.xml
index 8ccbfdbb..edaad986 100644
--- a/pom.xml
+++ b/pom.xml
@@ -203,7 +203,6 @@
 org.slf4j
 slf4j-api
 ${slf4jVersion}
-provided
   
   
 org.slf4j


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.2
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-07-13 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542764#comment-16542764
 ] 

Hudson commented on MRESOLVER-36:
-

Build succeeded in Jenkins: Maven TLP » maven-resolver » MRESOLVER-46 #4

See 
https://builds.apache.org/job/maven-box/job/maven-resolver/job/MRESOLVER-46/4/

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.2
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-07-13 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542738#comment-16542738
 ] 

Hudson commented on MRESOLVER-36:
-

Build succeeded in Jenkins: Maven TLP » maven-resolver » master #8

See https://builds.apache.org/job/maven-box/job/maven-resolver/job/master/8/

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.2
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-07-13 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542726#comment-16542726
 ] 

Hudson commented on MRESOLVER-36:
-

Build succeeded in Jenkins: Maven TLP » maven-resolver » MRESOLVER-36 #2

See 
https://builds.apache.org/job/maven-box/job/maven-resolver/job/MRESOLVER-36/2/

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.2
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-07-08 Thread Sylwester Lachiewicz (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536429#comment-16536429
 ] 

Sylwester Lachiewicz commented on MRESOLVER-36:
---

Thx you for finding this regression - dependency to the slf4j-api was 
optional/provided and internally Guice was unable to create objects due to lack 
of slf4j api on maven-provider project classpath.

With change in pull 18 Maven will pass all tests (internal and it-s).

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.2
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-07-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536416#comment-16536416
 ] 

ASF GitHub Bot commented on MRESOLVER-36:
-

slachiewicz opened a new pull request #18: [MRESOLVER-36] Make slf4j dependency 
required
URL: https://github.com/apache/maven-resolver/pull/18
 
 
   Dependency to slf4j-api is still optional


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.2
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-07-02 Thread Sylwester Lachiewicz (JIRA)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530461#comment-16530461
 ] 

Sylwester Lachiewicz commented on MRESOLVER-36:
---

i’ll look on this tommorow

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.2
>
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-04-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429735#comment-16429735
 ] 

ASF GitHub Bot commented on MRESOLVER-36:
-

olamy closed pull request #13: [MRESOLVER-36] Change internal logging to sl4j
URL: https://github.com/apache/maven-resolver/pull/13
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-resolver-connector-basic/pom.xml 
b/maven-resolver-connector-basic/pom.xml
index 781d2467..0e896bc8 100644
--- a/maven-resolver-connector-basic/pom.xml
+++ b/maven-resolver-connector-basic/pom.xml
@@ -59,6 +59,16 @@
   provided
   true
 
+
+  org.slf4j
+  slf4j-api
+  provided
+
+
+   org.slf4j
+   slf4j-simple
+   test
+
 
   org.sonatype.sisu
   sisu-guice
diff --git 
a/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java
 
b/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java
index bc1ee35e..87c81915 100644
--- 
a/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java
+++ 
b/maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java
@@ -54,7 +54,6 @@
 import org.eclipse.aether.spi.connector.transport.Transporter;
 import org.eclipse.aether.spi.connector.transport.TransporterProvider;
 import org.eclipse.aether.spi.io.FileProcessor;
-import org.eclipse.aether.spi.log.Logger;
 import org.eclipse.aether.transfer.ChecksumFailureException;
 import org.eclipse.aether.transfer.NoRepositoryConnectorException;
 import org.eclipse.aether.transfer.NoRepositoryLayoutException;
@@ -65,6 +64,8 @@
 import org.eclipse.aether.util.ConfigUtils;
 import org.eclipse.aether.util.concurrency.RunnableErrorForwarder;
 import org.eclipse.aether.util.concurrency.WorkerThreadFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  */
@@ -80,7 +81,7 @@
 
 private static final String CONFIG_PROP_SMART_CHECKSUMS = 
"aether.connector.smartChecksums";
 
-private final Logger logger;
+private static final Logger LOGGER = LoggerFactory.getLogger( 
BasicRepositoryConnector.class );
 
 private final FileProcessor fileProcessor;
 
@@ -108,8 +109,7 @@
 
 BasicRepositoryConnector( RepositorySystemSession session, 
RemoteRepository repository,
  TransporterProvider transporterProvider, 
RepositoryLayoutProvider layoutProvider,
- ChecksumPolicyProvider 
checksumPolicyProvider, FileProcessor fileProcessor,
- Logger logger )
+ ChecksumPolicyProvider 
checksumPolicyProvider, FileProcessor fileProcessor )
 throws NoRepositoryConnectorException
 {
 try
@@ -133,7 +133,6 @@
 this.session = session;
 this.repository = repository;
 this.fileProcessor = fileProcessor;
-this.logger = logger;
 
 maxThreads = ConfigUtils.getInteger( session, 5, CONFIG_PROP_THREADS, 
"maven.artifact.threads" );
 smartChecksums = ConfigUtils.getBoolean( session, true, 
CONFIG_PROP_SMART_CHECKSUMS );
@@ -150,7 +149,7 @@
 ConfigUtils.getInteger( session, 
ConfigurationProperties.DEFAULT_REQUEST_TIMEOUT,
 ConfigurationProperties.REQUEST_TIMEOUT + 
'.' + repository.getId(),
 ConfigurationProperties.REQUEST_TIMEOUT );
-partialFileFactory = new PartialFile.Factory( resumeDownloads, 
resumeThreshold, requestTimeout, logger );
+partialFileFactory = new PartialFile.Factory( resumeDownloads, 
resumeThreshold, requestTimeout );
 }
 
 private Executor getExecutor( Collection artifacts, Collection 
metadatas )
@@ -403,7 +402,7 @@ protected void runTask()
 super( path, listener );
 this.file = requireNonNull( file, "destination file cannot be 
null" );
 checksumValidator =
-new ChecksumValidator( logger, file, fileProcessor, this, 
checksumPolicy, safe( checksums ) );
+new ChecksumValidator( file, fileProcessor, this, 
checksumPolicy, safe( checksums ) );
 }
 
 public void checkRemoteAccess()
@@ -438,7 +437,7 @@ protected void runTask()
 PartialFile partFile = partialFileFactory.newInstance( file, this 
);
 if ( partFile == null )
 {
-logger.debug( "Concurrent download of " + file + " just 
finished, skipping download" );
+LOGGER.

[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-04-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429734#comment-16429734
 ] 

ASF GitHub Bot commented on MRESOLVER-36:
-

slachiewicz commented on issue #13: [MRESOLVER-36] Change internal logging to 
sl4j
URL: https://github.com/apache/maven-resolver/pull/13#issuecomment-379543587
 
 
   hi, any plan to verify this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2018-03-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405331#comment-16405331
 ] 

ASF GitHub Bot commented on MRESOLVER-36:
-

slachiewicz commented on issue #13: [MRESOLVER-36] Change internal logging to 
sl4j
URL: https://github.com/apache/maven-resolver/pull/13#issuecomment-374344909
 
 
   ok, new version finished. 
   After more tests (like replace .jar)  with maven 3.5.0/3.5.3 i need to leave 
more classes and initializations. Works fine as a swap in place.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2017-12-09 Thread Sylwester Lachiewicz (JIRA)

[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285047#comment-16285047
 ] 

Sylwester Lachiewicz commented on MRESOLVER-36:
---

Pull request added https://github.com/apache/maven-resolver/pull/13

To test with Maven it will require small changes - but they can be implemented 
before new maven-resolver version.

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MRESOLVER-36) SLFJ - remove LoggerFactory from dependency injection

2017-12-08 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MRESOLVER-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284267#comment-16284267
 ] 

Michael Osipov commented on MRESOLVER-36:
-

Makes sense! Willing to merge a PR.

> SLFJ - remove LoggerFactory from dependency injection
> -
>
> Key: MRESOLVER-36
> URL: https://issues.apache.org/jira/browse/MRESOLVER-36
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Maven Artifact Resolver 1.1.1
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> Because Maven moved to SL4J as the primary login structure we can remove 
> {{NullLoggerFactory}} class and replace {{loggerFactory}} variables with 
> {{LoggerFactory.getLogger}}
> To maintain compatibility constructors will be Deprecated



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)