[jira] [Commented] (SUREFIRE-1137) Problem with Umlauts in stdout

[Andreas Gudian (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126899#comment-15126899
 ] 

Andreas Gudian commented on SUREFIRE-1137:
--

[~michael-o], well, that's too long ago for me to remember. What I do remember 
is that I kept trying out different approaches and it took more than one 
iteration to get it to the point where it was then.

OK, I checked the commit as well. I think one problem that I had was that 
specifying {{-Dfile.encoding}} didn't always have the desired effect. That's 
also kind of what the docs say, which is: don't trust that thing - it's more of 
an internal piece of information that may be used by some of the JRE classes, 
but it is never guaranteed that it is actually obeyed. Other information from 
the installation, the system or the environment variables can come into play as 
well.

So why using {{ISO-8859-1}}? It's pretty arbitrary, but it is one of the 
canonical charsets that contain ASCII in unchanged form. It's just a fixture to 
transport the ASCII-fied information between the forks. Byte arrays are to be 
transferred as they are (but printable), CharSequences are transported using 
their unicode codepoints in ASCII. All of them are reconstructed on the other 
side hopefully to their original state. For some output variants, Strings 
encoded as byte-arrays need to be re-coded to fit a target encoding (e.g. the 
XML files need to be UTF-8)... So far for the idea...

But you're right with the StreamPumpers... The intention was to pass the 
charset in {{CommandLineUtils.executeCommandLineAsCallable}} to the 
{{StreamPumper}} instances. If the host process uses a charset that doesn't 
start with the ASCII table, we're in trouble. No idea if that wouldn't break 
even more things than just some glitches in the output, though... 

> Problem with Umlauts in stdout
> --
>
> Key: SUREFIRE-1137
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1137
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.18
> Environment: Linux
>Reporter: Jürgen Zeller
>Assignee: Andreas Gudian
> Fix For: 2.19
>
> Attachments: TEST-eu.jzeller.AppTest.xml, surefire-test.zip, 
> surefire-test.zip
>
>
> When using Cp1252 as file encoding, the generated Surefire stdout report 
> contains invalid characters when run on Linux. When running the same test on 
> Windows, everything is fine.
> A simular Problem was reported in SUREFIRE-998



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1137) Problem with Umlauts in stdout

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124500#comment-15124500
 ] 

Michael Osipov commented on SUREFIRE-1137:
--

[~agudian], just checked the Git diff for the commit while working on 
SUREFIRE-1220 and this is very good work but why did you introduce 
{{FORK_STREAM_CHARSET_NAME}} with {{ISO-8859-1}}? The interal string utils do 
align all {{stdout}} output to 7-bit ASCII and {{executeCommandLineAsCallable}} 
does not even pass that {{Charset}} to the created {{StreamPumpers}}. In theory 
this could create incorrectly or even unmappable input? Moreover, in some 
places a {{char}} is properly 7-bit aligned and {{ReportEntries}} are passed 
and aligned too. Everything is aligned with {{escapeToPrintable}} or 
{{escapeBytesToPrintable}}. I'd be happy to receive an explanation on this!

> Problem with Umlauts in stdout
> --
>
> Key: SUREFIRE-1137
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1137
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.18
> Environment: Linux
>Reporter: Jürgen Zeller
>Assignee: Andreas Gudian
> Fix For: 2.19
>
> Attachments: TEST-eu.jzeller.AppTest.xml, surefire-test.zip, 
> surefire-test.zip
>
>
> When using Cp1252 as file encoding, the generated Surefire stdout report 
> contains invalid characters when run on Linux. When running the same test on 
> Windows, everything is fine.
> A simular Problem was reported in SUREFIRE-998



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)