[jira] [Commented] (MSHARED-976) Maven 3.1.1 prerequisite to run ( + move to JSR-330)
[ https://issues.apache.org/jira/browse/MSHARED-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280132#comment-17280132 ] Sylwester Lachiewicz commented on MSHARED-976: -- Yes, I'm aware of that - the title is just to indicate to anyone trying to upgrade to new lib that it should be used only with Maven 3.1.1+ (ie first bump other plugin's minimum Maven version). Main part it to move away from Plexus annotations and move to plain @Inject > Maven 3.1.1 prerequisite to run ( + move to JSR-330) > > > Key: MSHARED-976 > URL: https://issues.apache.org/jira/browse/MSHARED-976 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-invoker-3.1.0 > > > Sync with other projects to have Maven 3.1.1 as a prerequisite. > Convert also Plexus annotations to JSR-330 annotations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-976) Maven 3.1.1 prerequisite to run ( + move to JSR-330)
[ https://issues.apache.org/jira/browse/MSHARED-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280131#comment-17280131 ] Herve Boutemy commented on MSHARED-976: --- [~slachiewicz] notice: "Maven prerequisite" is only used by plugins to define runtime requirement, not by libraries (which do not have Maven runtime requirement) then "Maven 3.3.1 prerequisite to run" on a library like this one is not really what the update does: IIUC, it aligns library dependencies version to Maven 3.1.1 (which anyway won't be used in a plugin context, because Maven core provides the dependencies) to me, updating these dependencies is nice, but not such a move that it is worth doing the effort of a release: I'm just saying that to be sure that time passed on releasing is useful, thanks for your efforts > Maven 3.1.1 prerequisite to run ( + move to JSR-330) > > > Key: MSHARED-976 > URL: https://issues.apache.org/jira/browse/MSHARED-976 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-invoker-3.1.0 > > > Sync with other projects to have Maven 3.1.1 as a prerequisite. > Convert also Plexus annotations to JSR-330 annotations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-150) AbstractJxrReport.java uses or overrides a deprecated API.
[ https://issues.apache.org/jira/browse/JXR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-150: - Fix Version/s: next-release > AbstractJxrReport.java uses or overrides a deprecated API. > -- > > Key: JXR-150 > URL: https://issues.apache.org/jira/browse/JXR-150 > Project: Maven JXR > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: next-release, 3.1.0 > > > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java > uses or overrides a deprecated API. > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > Recompile with -Xlint:deprecation for details. > [INFO] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (JXR-150) AbstractJxrReport.java uses or overrides a deprecated API.
[ https://issues.apache.org/jira/browse/JXR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned JXR-150: Assignee: Sylwester Lachiewicz > AbstractJxrReport.java uses or overrides a deprecated API. > -- > > Key: JXR-150 > URL: https://issues.apache.org/jira/browse/JXR-150 > Project: Maven JXR > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Minor > Labels: up-for-grabs > > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java > uses or overrides a deprecated API. > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > Recompile with -Xlint:deprecation for details. > [INFO] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-150) AbstractJxrReport.java uses or overrides a deprecated API.
[ https://issues.apache.org/jira/browse/JXR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-150: - Fix Version/s: 3.1.0 > AbstractJxrReport.java uses or overrides a deprecated API. > -- > > Key: JXR-150 > URL: https://issues.apache.org/jira/browse/JXR-150 > Project: Maven JXR > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Minor > Labels: up-for-grabs > Fix For: 3.1.0 > > > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java > uses or overrides a deprecated API. > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > Recompile with -Xlint:deprecation for details. > [INFO] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-150) AbstractJxrReport.java uses or overrides a deprecated API.
[ https://issues.apache.org/jira/browse/JXR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-150: - Labels: (was: up-for-grabs) > AbstractJxrReport.java uses or overrides a deprecated API. > -- > > Key: JXR-150 > URL: https://issues.apache.org/jira/browse/JXR-150 > Project: Maven JXR > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.1.0 > > > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java > uses or overrides a deprecated API. > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > Recompile with -Xlint:deprecation for details. > [INFO] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JXR-157) Upgrade Velocity templating engine
Sylwester Lachiewicz created JXR-157: Summary: Upgrade Velocity templating engine Key: JXR-157 URL: https://issues.apache.org/jira/browse/JXR-157 Project: Maven JXR Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz Upgrade velocity templating engine to 2.2 [https://velocity.apache.org/engine/2.2/upgrading.html] Requires Java 8 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-157) Upgrade Velocity templating engine
[ https://issues.apache.org/jira/browse/JXR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-157: - Labels: Java8 (was: ) > Upgrade Velocity templating engine > -- > > Key: JXR-157 > URL: https://issues.apache.org/jira/browse/JXR-157 > Project: Maven JXR > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Labels: Java8 > > Upgrade velocity templating engine to 2.2 > [https://velocity.apache.org/engine/2.2/upgrading.html] > > Requires Java 8 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-157) Upgrade Velocity templating engine
[ https://issues.apache.org/jira/browse/JXR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-157: - Labels: Java8 up-for-grabs (was: Java8) > Upgrade Velocity templating engine > -- > > Key: JXR-157 > URL: https://issues.apache.org/jira/browse/JXR-157 > Project: Maven JXR > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Labels: Java8, up-for-grabs > > Upgrade velocity templating engine to 2.2 > [https://velocity.apache.org/engine/2.2/upgrading.html] > > Requires Java 8 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-976) Maven 3.1.1 prerequisite to run ( + move to JSR-330)
[ https://issues.apache.org/jira/browse/MSHARED-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280135#comment-17280135 ] Herve Boutemy commented on MSHARED-976: --- ok; great > Maven 3.1.1 prerequisite to run ( + move to JSR-330) > > > Key: MSHARED-976 > URL: https://issues.apache.org/jira/browse/MSHARED-976 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-invoker-3.1.0 > > > Sync with other projects to have Maven 3.1.1 as a prerequisite. > Convert also Plexus annotations to JSR-330 annotations -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x
[ https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280167#comment-17280167 ] Hudson commented on MNGSITE-393: Build succeeded in Jenkins: Maven » Maven TLP » maven-jxr » master #21 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-jxr/job/master/21/ > Remove references to Maven 2.x > -- > > Key: MNGSITE-393 > URL: https://issues.apache.org/jira/browse/MNGSITE-393 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > > Maven 3.x is over a decade old now and we're talking about Maven 4. It's time > to clean out all the random discussion here and there about how Maven 2.x did > things, differences between Maven 2 and 3, what works in Maven 3 but not 2, > etc. > Assume Maven 3.0 as the minimum, probably Maven 3.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-jxr] elharo closed pull request #26: deps: plexus-java 1.0.6
elharo closed pull request #26: URL: https://github.com/apache/maven-jxr/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] elharo opened a new pull request #28: [JXR-153] use locales for string comparison
elharo opened a new pull request #28: URL: https://github.com/apache/maven-jxr/pull/28 @slachiewicz This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] slachiewicz commented on pull request #28: [JXR-153] use locales for string comparison
slachiewicz commented on pull request #28: URL: https://github.com/apache/maven-jxr/pull/28#issuecomment-774476687 Please change commit message from "use lcoales for string comparison" to "[JXR-153] use locales for string comparison" - PR title will not propagate to git This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MRESOLVER-159) Mark singleton components as Sisu Singletons
[
https://issues.apache.org/jira/browse/MRESOLVER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MRESOLVER-159:
Assignee: Michael Osipov
> Mark singleton components as Sisu Singletons
>
>
> Key: MRESOLVER-159
> URL: https://issues.apache.org/jira/browse/MRESOLVER-159
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamás Cservenák
>Assignee: Michael Osipov
>Priority: Major
>
> When using resolver with Ssisu, key components that are expected to be
> singletons are actually not marked as such (in contrary to Guice module for
> example): they lack {{@Singleton}} annotation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MPLUGINTESTING-62) use maven API 3.6.0 and Plexus 2.0.0
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPLUGINTESTING-62: --- Labels: close-pending (was: ) > use maven API 3.6.0 and Plexus 2.0.0 > > > Key: MPLUGINTESTING-62 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-62 > Project: Maven Plugin Testing > Issue Type: Dependency upgrade >Reporter: Samael Bate >Priority: Major > Labels: close-pending > > Along with updating to use Java 7 (MPLUGINTESTING-61) the plugin should use a > recent maven API. > As there is no 3.6.0 for maven-aether-provider it will need be set to 3.3.9 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-jxr] slachiewicz commented on a change in pull request #27: tidy up test dependencies
slachiewicz commented on a change in pull request #27: URL: https://github.com/apache/maven-jxr/pull/27#discussion_r571434015 ## File path: maven-jxr/pom.xml ## @@ -104,12 +104,6 @@ under the License. 3.8.1 - Review comment: why remove? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] elharo commented on a change in pull request #27: tidy up test dependencies
elharo commented on a change in pull request #27: URL: https://github.com/apache/maven-jxr/pull/27#discussion_r571440715 ## File path: maven-jxr/pom.xml ## @@ -104,12 +104,6 @@ under the License. 3.8.1 - Review comment: Because this isn't actually used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] slachiewicz commented on pull request #26: deps: plexus-java 1.0.6
slachiewicz commented on pull request #26: URL: https://github.com/apache/maven-jxr/pull/26#issuecomment-774459873 Already done in 32f83f3309a432c0380efbbdbc49aea394d6e93f This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (JXR-158) StringEntry needs equals and hashCode
Elliotte Rusty Harold created JXR-158:
-
Summary: StringEntry needs equals and hashCode
Key: JXR-158
URL: https://issues.apache.org/jira/browse/JXR-158
Project: Maven JXR
Issue Type: Bug
Reporter: Elliotte Rusty Harold
Because it implements Comparable. Per Oracle,
It is strongly recommended, but _not_ strictly required that
{{(x.compareTo(y)==0) == (x.equals(y))}}. Generally speaking, any class that
implements the {{Comparable}} interface and violates this condition should
clearly indicate this fact. The recommended language is "Note: this class has a
natural ordering that is inconsistent with equals."
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-jxr] slachiewicz commented on pull request #28: [JXR-153] use locales for string comparison
slachiewicz commented on pull request #28: URL: https://github.com/apache/maven-jxr/pull/28#issuecomment-774476895 If ypu plan to as for review - You can use Github Reviewers - top right, instead of putting someone's name on the first comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MSHARED-975) Big speed improvements for patterns that do not contain any wildcard
[ https://issues.apache.org/jira/browse/MSHARED-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MSHARED-975: Assignee: Sylwester Lachiewicz > Big speed improvements for patterns that do not contain any wildcard > > > Key: MSHARED-975 > URL: https://issues.apache.org/jira/browse/MSHARED-975 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-common-artifact-filters >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-common-artifact-filters-3.2.0 > > > This can be a huge boost for dependency sets that contains lots of artifact > ids such as > [https://github.com/apache/camel/blob/2870bb9e619b4e18bfe8de11b449be9cd67d1f3c/apache-camel/src/main/descriptors/common-bin.xml] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280198#comment-17280198
]
Tibor Digana commented on SUREFIRE-1881:
Hi [~kriegaex],
Thx for the reproducible project.
Maybe there are two issues in one. So i want to make sure if the config
{{}}
prevents from freeze the build.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-resolver] asfgit closed pull request #93: [MRESOLVER-159] Mark components as Singletons
asfgit closed pull request #93: URL: https://github.com/apache/maven-resolver/pull/93 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-159) Mark singleton components as Sisu Singletons
[
https://issues.apache.org/jira/browse/MRESOLVER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRESOLVER-159.
Fix Version/s: 1.7.0
Resolution: Fixed
Fixed with
[1240e229c3aff76ca8bc89409362f1223c4fa046|https://gitbox.apache.org/repos/asf?p=maven-resolver.git=commit=1240e229c3aff76ca8bc89409362f1223c4fa046].
> Mark singleton components as Sisu Singletons
>
>
> Key: MRESOLVER-159
> URL: https://issues.apache.org/jira/browse/MRESOLVER-159
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamás Cservenák
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.7.0
>
>
> When using resolver with Ssisu, key components that are expected to be
> singletons are actually not marked as such (in contrary to Guice module for
> example): they lack {{@Singleton}} annotation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JXR-150) AbstractJxrReport.java uses or overrides a deprecated API.
[ https://issues.apache.org/jira/browse/JXR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280159#comment-17280159 ] Sylwester Lachiewicz commented on JXR-150: -- Done in [a439639ef7879b911051c5bdbc26a5aeae425944|https://gitbox.apache.org/repos/asf?p=maven-jxr.git;a=commit;h=a439639ef7879b911051c5bdbc26a5aeae425944] > AbstractJxrReport.java uses or overrides a deprecated API. > -- > > Key: JXR-150 > URL: https://issues.apache.org/jira/browse/JXR-150 > Project: Maven JXR > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: next-release, 3.1.0 > > > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java > uses or overrides a deprecated API. > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > Recompile with -Xlint:deprecation for details. > [INFO] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-jxr] elharo opened a new pull request #27: tidy up test dependencies
elharo opened a new pull request #27: URL: https://github.com/apache/maven-jxr/pull/27 @slachiewicz This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #333: Add failOnFlakeCount option
Tibor17 commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-774443779 @oehme Hi, that would be great, thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] elharo opened a new pull request #25: [MNGSITE-393] dropping Maven 2
elharo opened a new pull request #25: URL: https://github.com/apache/maven-jxr/pull/25 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] elharo opened a new pull request #26: deps: plexus-java 1.0.6
elharo opened a new pull request #26: URL: https://github.com/apache/maven-jxr/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (JXR-150) AbstractJxrReport.java uses or overrides a deprecated API.
[ https://issues.apache.org/jira/browse/JXR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed JXR-150. Resolution: Fixed > AbstractJxrReport.java uses or overrides a deprecated API. > -- > > Key: JXR-150 > URL: https://issues.apache.org/jira/browse/JXR-150 > Project: Maven JXR > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: next-release, 3.1.0 > > > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java > uses or overrides a deprecated API. > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > Recompile with -Xlint:deprecation for details. > [INFO] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-jxr] asfgit closed pull request #25: [MNGSITE-393] dropping Maven 2
asfgit closed pull request #25: URL: https://github.com/apache/maven-jxr/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-remote-resources-plugin] slachiewicz commented on a change in pull request #2: Implement MRRESOURCES-102
slachiewicz commented on a change in pull request #2:
URL:
https://github.com/apache/maven-remote-resources-plugin/pull/2#discussion_r571431033
##
File path:
src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java
##
@@ -944,12 +944,12 @@ private void fileWriteIfDiffers( DeferredFileOutputStream
outStream )
}
}
-private MavenFileFilterRequest setupRequest( File source, File file,
boolean isFiltering )
+private MavenFileFilterRequest setupRequest( File source, File file )
{
MavenFileFilterRequest req = new MavenFileFilterRequest();
req.setFrom( source );
req.setTo( file );
-req.setFiltering( isFiltering );
+req.setFiltering( true );
Review comment:
@rfscholte do we need more review here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-doxia] slachiewicz commented on pull request #56: Maven 3.1.1 Prepare switch plexus-container-default to org.eclipse.si…
slachiewicz commented on pull request #56: URL: https://github.com/apache/maven-doxia/pull/56#issuecomment-774472619 initial commit to fix known differences with Sisu Plexus. Final commit will change org.codehaus.plexus:plexus-container-default to org.eclipse.sisu:org.eclipse.sisu.plexus In all Maven libs/plugins - from Maven 3.1 (ie switch to Eclipse Sisu) we are no longer use plexus-container-default This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] elharo merged pull request #28: [JXR-153] use locales for string comparison
elharo merged pull request #28: URL: https://github.com/apache/maven-jxr/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] slachiewicz merged pull request #27: tidy up test dependencies
slachiewicz merged pull request #27: URL: https://github.com/apache/maven-jxr/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] michael-o commented on pull request #56: Maven 3.1.1 Prepare switch plexus-container-default to org.eclipse.si…
michael-o commented on pull request #56: URL: https://github.com/apache/maven-doxia/pull/56#issuecomment-774488591 Very very nice... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-158) Simplify SimpleDigest class
[ https://issues.apache.org/jira/browse/MRESOLVER-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-158. > Simplify SimpleDigest class > --- > > Key: MRESOLVER-158 > URL: https://issues.apache.org/jira/browse/MRESOLVER-158 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.7.0 > > > The class SimpleDigest contains some code hinting it MAY work on JVM not > supporting SHA1 and MD5, but this is actually not true. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MRESOLVER-160) Deprecate ServiceLocator
[
https://issues.apache.org/jira/browse/MRESOLVER-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRESOLVER-160.
> Deprecate ServiceLocator
>
>
> Key: MRESOLVER-160
> URL: https://issues.apache.org/jira/browse/MRESOLVER-160
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 1.7.0
>
>
> As prequel to MRESOLVER-157 we need to deprecate (to warn users of) the
> {{ServiceLocator}} in Maven Resolver. This change may go out in some upcoming
> release, as it is not breaking change, unlike MRESOLVER-157 will be.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] garydgregory edited a comment on pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory edited a comment on pull request #441: URL: https://github.com/apache/maven/pull/441#issuecomment-774534433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] elharo opened a new pull request #30: make SLF4J dependency explicit
elharo opened a new pull request #30: URL: https://github.com/apache/maven-jxr/pull/30 Alternative would be to remove the SLF4J loggers and debug log statements completely. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280228#comment-17280228
]
Alexander Kriegisch commented on SUREFIRE-1881:
---
Actually it is the other way around, that option causes the freeze. Commenting
it out avoids it.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MNG-7093) Construct exceptions with args to String.format().
Gary D. Gregory created MNG-7093:
Summary: Construct exceptions with args to String.format().
Key: MNG-7093
URL: https://issues.apache.org/jira/browse/MNG-7093
Project: Maven
Issue Type: New Feature
Components: Plugin API
Reporter: Gary D. Gregory
Construct exceptions with args to String.format() to allow for a simpler and
richer way to build messages, for example, right now, in the Apache Commons
release plugin, I say:
{code:java}
throw new MojoExecutionException("Failed to add files to SCM: " +
addResult.getProviderMessage()
+ " [" + addResult.getCommandOutput() + "]");
...
throw new MojoExecutionException(String.format("Failed to copy '%s' to '%s'",
name, scmTargetPath), e);
{code}
But it would be nicer to say:
{code:java}
throw new MojoExecutionException("Failed to add files to SCM: %s [%s]",
addResult.getProviderMessage(), addResult.getCommandOutput());
...
throw new MojoExecutionException(e, "Failed to copy '%s' to '%s'", name,
scmTargetPath));
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (JXR-159) Prerequisites - Maven 3.1.1
[ https://issues.apache.org/jira/browse/JXR-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-159: - Fix Version/s: 3.1.0 next-release > Prerequisites - Maven 3.1.1 > --- > > Key: JXR-159 > URL: https://issues.apache.org/jira/browse/JXR-159 > Project: Maven JXR > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: next-release, 3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JXR-159) Prerequisites - Maven 3.1.1
Sylwester Lachiewicz created JXR-159: Summary: Prerequisites - Maven 3.1.1 Key: JXR-159 URL: https://issues.apache.org/jira/browse/JXR-159 Project: Maven JXR Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-jxr] bmarwell commented on pull request #30: make SLF4J dependency explicit
bmarwell commented on pull request #30: URL: https://github.com/apache/maven-jxr/pull/30#issuecomment-774499713 As discussed on the mailing list, we should prefer to remove slf4j instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] slachiewicz merged pull request #29: correct XML declaration
slachiewicz merged pull request #29: URL: https://github.com/apache/maven-jxr/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] garydgregory edited a comment on pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory edited a comment on pull request #441: URL: https://github.com/apache/maven/pull/441#issuecomment-774534433 https://issues.apache.org/jira/browse/MNG-7093 Passed: `mvn -DdistributionTargetDir="/temp/apache-maven-3.7.x-SNAPSHOT" clean package` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7093) Construct exceptions with args to String.format().
[
https://issues.apache.org/jira/browse/MNG-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated MNG-7093:
-
External issue URL: https://github.com/apache/maven/pull/441
> Construct exceptions with args to String.format().
> --
>
> Key: MNG-7093
> URL: https://issues.apache.org/jira/browse/MNG-7093
> Project: Maven
> Issue Type: New Feature
> Components: Plugin API
>Reporter: Gary D. Gregory
>Priority: Minor
>
> Construct exceptions with args to String.format() to allow for a simpler and
> richer way to build messages, for example, right now, in the Apache Commons
> release plugin, I say:
> {code:java}
> throw new MojoExecutionException("Failed to add files to SCM: " +
> addResult.getProviderMessage()
> + " [" + addResult.getCommandOutput() + "]");
> ...
> throw new MojoExecutionException(String.format("Failed to copy '%s' to '%s'",
> name, scmTargetPath), e);
> {code}
> But it would be nicer to say:
> {code:java}
> throw new MojoExecutionException("Failed to add files to SCM: %s [%s]",
> addResult.getProviderMessage(), addResult.getCommandOutput());
> ...
> throw new MojoExecutionException(e, "Failed to copy '%s' to '%s'", name,
> scmTargetPath));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] garydgregory edited a comment on pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory edited a comment on pull request #441: URL: https://github.com/apache/maven/pull/441#issuecomment-774534433 - https://issues.apache.org/jira/browse/MNG-7093 - I did not add Javadoc since tags since it is not clear to me if the next release will be 3.6.4, 3,7,0, or 4.0.0. - Passed: `mvn -DdistributionTargetDir="/temp/apache-maven-3.7.x-SNAPSHOT" clean package` - FYI, I am ggregory at Apache. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] elharo opened a new pull request #29: correct XML declaration
elharo opened a new pull request #29: URL: https://github.com/apache/maven-jxr/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (JXR-153) JxrReportTest depends on platform default encoding
[ https://issues.apache.org/jira/browse/JXR-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed JXR-153. Resolution: Fixed > JxrReportTest depends on platform default encoding > -- > > Key: JXR-153 > URL: https://issues.apache.org/jira/browse/JXR-153 > Project: Maven JXR > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: next-release, 3.1.0 > > > probably other classes too -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (JXR-153) JxrReportTest depends on platform default encoding
[ https://issues.apache.org/jira/browse/JXR-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned JXR-153: Assignee: Elliotte Rusty Harold > JxrReportTest depends on platform default encoding > -- > > Key: JXR-153 > URL: https://issues.apache.org/jira/browse/JXR-153 > Project: Maven JXR > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > > probably other classes too -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-153) JxrReportTest depends on platform default encoding
[ https://issues.apache.org/jira/browse/JXR-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-153: - Fix Version/s: 3.1.0 next-release > JxrReportTest depends on platform default encoding > -- > > Key: JXR-153 > URL: https://issues.apache.org/jira/browse/JXR-153 > Project: Maven JXR > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: next-release, 3.1.0 > > > probably other classes too -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-jxr] slachiewicz commented on pull request #30: make SLF4J dependency explicit
slachiewicz commented on pull request #30: URL: https://github.com/apache/maven-jxr/pull/30#issuecomment-774505861 Soon we must update dependency to Velocity to 2.2 (with Java 8) - they use slf4j API for logging  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] garydgregory edited a comment on pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory edited a comment on pull request #441: URL: https://github.com/apache/maven/pull/441#issuecomment-774534433 https://issues.apache.org/jira/browse/MNG-7093 I did not add Javadoc since tags since it is not clear to me if the next release will be 3.6.4, 3,7,0, or 4.0.0. Passed: `mvn -DdistributionTargetDir="/temp/apache-maven-3.7.x-SNAPSHOT" clean package` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] slachiewicz commented on a change in pull request #30: make SLF4J dependency explicit
slachiewicz commented on a change in pull request #30: URL: https://github.com/apache/maven-jxr/pull/30#discussion_r571456941 ## File path: maven-jxr/pom.xml ## @@ -92,7 +92,11 @@ under the License. org.codehaus.plexus plexus-utils - + + org.slf4j + slf4j-api + 1.7.30 Review comment: better would be to use the latest available with 3.1.1 - to avoid any linking exceptions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280266#comment-17280266
]
Tibor Digana commented on SUREFIRE-1881:
[~kriegaex]
Maybe you can tell me why the Java Instrumentation refused remote network
connection in the fork JVM.
What happens with that?
{noformat}
java.io.IOException: java.io.IOException: The remote computer refused the
network connection
at
org.apache.maven.surefire.booter.spi.SurefireMasterProcessChannelProcessorFactory.connect(SurefireMasterProcessChannelProcessorFactory.java:85)
at
org.apache.maven.surefire.booter.ForkedBooter.setupBooter(ForkedBooter.java:126)
at
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:561)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
Caused by: java.io.IOException: The remote computer refused the network
connection
at java.base/sun.nio.ch.Iocp.translateErrorToIOException(Iocp.java:299)
at java.base/sun.nio.ch.Iocp$EventHandlerTask.run(Iocp.java:389)
at
java.base/sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
{noformat}
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] garydgregory commented on pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory commented on pull request #441: URL: https://github.com/apache/maven/pull/441#issuecomment-774534486 FYI, I am ggregory at Apache. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] garydgregory opened a new pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory opened a new pull request #441: URL: https://github.com/apache/maven/pull/441 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] garydgregory commented on pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory commented on pull request #441: URL: https://github.com/apache/maven/pull/441#issuecomment-774534433 https://issues.apache.org/jira/browse/MNG-7093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] garydgregory removed a comment on pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory removed a comment on pull request #441: URL: https://github.com/apache/maven/pull/441#issuecomment-774534486 FYI, I am ggregory at Apache. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] elharo merged pull request #30: make SLF4J dependency explicit
elharo merged pull request #30: URL: https://github.com/apache/maven-jxr/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280352#comment-17280352
]
Alexander Kriegisch commented on SUREFIRE-1881:
---
On my machine, if I activate the fork node, there is no {{failsafe-reports}}
directory, just an indefinitely hanging build, I have to kill the process.
Otherwise I would have noticed the dump file. All I see is
{code:text}
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (integration-test) @
surefire-print-console-problems ---
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
{code}
and then nothing else for minutes.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280352#comment-17280352
]
Alexander Kriegisch edited comment on SUREFIRE-1881 at 2/7/21, 2:15 AM:
On my machine, if I activate the fork node, there is no {{failsafe-reports}}
directory, just an indefinitely hanging build, I have to kill the process.
Otherwise I would have noticed the dump file. All I see is
{code:none}
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (integration-test) @
surefire-print-console-problems ---
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
{code}
and then nothing else for minutes.
was (Author: kriegaex):
On my machine, if I activate the fork node, there is no {{failsafe-reports}}
directory, just an indefinitely hanging build, I have to kill the process.
Otherwise I would have noticed the dump file. All I see is
{code:text}
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (integration-test) @
surefire-print-console-problems ---
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
{code}
and then nothing else for minutes.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (JXR-159) Prerequisites - Maven 3.1.1
[ https://issues.apache.org/jira/browse/JXR-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned JXR-159: Assignee: Sylwester Lachiewicz > Prerequisites - Maven 3.1.1 > --- > > Key: JXR-159 > URL: https://issues.apache.org/jira/browse/JXR-159 > Project: Maven JXR > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: next-release, 3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (JXR-159) Prerequisites - Maven 3.1.1
[ https://issues.apache.org/jira/browse/JXR-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280311#comment-17280311 ] Sylwester Lachiewicz commented on JXR-159: -- Done in [052d865cd4175042c322f0455fd1a126483b7782|https://gitbox.apache.org/repos/asf?p=maven-jxr.git;a=commit;h=052d865cd4175042c322f0455fd1a126483b7782] > Prerequisites - Maven 3.1.1 > --- > > Key: JXR-159 > URL: https://issues.apache.org/jira/browse/JXR-159 > Project: Maven JXR > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: next-release, 3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (JXR-159) Prerequisites - Maven 3.1.1
[ https://issues.apache.org/jira/browse/JXR-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed JXR-159. Resolution: Fixed > Prerequisites - Maven 3.1.1 > --- > > Key: JXR-159 > URL: https://issues.apache.org/jira/browse/JXR-159 > Project: Maven JXR > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: next-release, 3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] garydgregory edited a comment on pull request #441: [MNG-7093] Construct exceptions with args to String.format().
garydgregory edited a comment on pull request #441: URL: https://github.com/apache/maven/pull/441#issuecomment-774534433 - https://issues.apache.org/jira/browse/MNG-7093 - I did not add Javadoc since tags since it is not clear to me if the next release will be 3.6.4, 3,7,0, or 4.0.0. - Build success: `mvn -DdistributionTargetDir="/temp/apache-maven-3.7.x-SNAPSHOT" clean package` - Build success: `mvn clean verify` - FYI, I am ggregory at Apache. Running IT crashed the JVM at the end: ``` mvn clean test -Prun-its -DmavenHome=/temp/apache-maven-3.7.x-SNAPSHOT ... [INFO] javaagent 1.0-SNAPSHOT . SUCCESS [ 1.158 s] [INFO] Maven Core ITs suite 2.1-SNAPSHOT .. FAILURE [54:31 min] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 55:56 min [INFO] Finished at: 2021-02-06T16:19:15-05:00 [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on project core-it-suite: There are test failures. [ERROR] [ERROR] Please refer to C:\d3vsrc\git\apache\maven-integration-testing\core-it-suite\target\surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :core-it-suite ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JXR-150) AbstractJxrReport.java uses or overrides a deprecated API.
[ https://issues.apache.org/jira/browse/JXR-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-150: - Fix Version/s: (was: next-release) > AbstractJxrReport.java uses or overrides a deprecated API. > -- > > Key: JXR-150 > URL: https://issues.apache.org/jira/browse/JXR-150 > Project: Maven JXR > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.1.1 > > > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java > uses or overrides a deprecated API. > [INFO] > /home/elharo/maven-jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java: > Recompile with -Xlint:deprecation for details. > [INFO] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280343#comment-17280343
]
Alexander Kriegisch edited comment on SUREFIRE-1881 at 2/7/21, 1:22 AM:
Actually, I am not sure which remote network connection you are talking about.
I have never seen this kind of error before. Can you elaborate, please? I
cannot see Java instrumentation in the picture here, at least not in the stack
trace. The instrumentation I set up here is in process, the agent does not
connect to a remote host or an external process on the same host. What kind of
environment did you run the build in? Which Java version? Anything that could
help, I am not sure which details would be helpful yet.
Is this maybe related to Maven talking to the forked process rather than
instrumentation?
was (Author: kriegaex):
Actually, I am not sure which remote network connection you are talking about.
I have never seen this kind of error before. Can you elaborate, please? I
cannot see Java instrumentation in the picture here, at least not in the stack
trace. The instrumentation I set up here is in process, the agent does not
connect to a remote host or an external process on the same host. What kind of
environment did you run the build in? Which Java version? Anything that could
help, I am not sure which details would be help ful yet.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280343#comment-17280343
]
Alexander Kriegisch commented on SUREFIRE-1881:
---
Actually, I am not sure which remote network connection you are talking about.
I have never seen this kind of error before. Can you elaborate, please? I
cannot see Java instrumentation in the picture here, at least not in the stack
trace. The instrumentation I set up here is in process, the agent does not
connect to a remote host or an external process on the same host. What kind of
environment did you run the build in? Which Java version? Anything that could
help, I am not sure which details would be help ful yet.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280348#comment-17280348
]
Tibor Digana commented on SUREFIRE-1881:
If you activate the _fokNode_ in the config as you did, the TCP/IP
communication and socket communication is used between the Failsafe plugin and
the forked JVM. I am using Java 15 with your code. This is _argLine_ agnostic.
My stacktrace was observed from the dump file
_Maven_Surefire_PrintToConsoleProblems\target\failsafe-reports\2021-02-06T20-20-27_890-jvmRun1.dump_
Pls have a look on your system.
I do not have professional experiences with Java Instrumentation and so I do
not have imagination how this could break opening the TCP connection.
What was strange to me was the fact that your code operates with internal
Failsafe code, basically all classes on the JVM.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SUREFIRE-1886) Upgrade plexus-java to Version 1.0.6
Tibor Digana created SUREFIRE-1886: -- Summary: Upgrade plexus-java to Version 1.0.6 Key: SUREFIRE-1886 URL: https://issues.apache.org/jira/browse/SUREFIRE-1886 Project: Maven Surefire Issue Type: Dependency upgrade Components: Maven Failsafe Plugin, Maven Surefire Plugin Reporter: Tibor Digana Fix For: 3.0.0-M6 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280353#comment-17280353
]
Alexander Kriegisch commented on SUREFIRE-1881:
---
BTW, if you wish to make this a little more interactive, my Gitter account is
_kriegaex_.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (JXR-153) JxrReportTest depends on platform default encoding
[ https://issues.apache.org/jira/browse/JXR-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-153: - Fix Version/s: (was: next-release) > JxrReportTest depends on platform default encoding > -- > > Key: JXR-153 > URL: https://issues.apache.org/jira/browse/JXR-153 > Project: Maven JXR > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > Fix For: 3.1.1 > > > probably other classes too -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-159) Prerequisites - Maven 3.1.1
[ https://issues.apache.org/jira/browse/JXR-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-159: - Fix Version/s: (was: next-release) > Prerequisites - Maven 3.1.1 > --- > > Key: JXR-159 > URL: https://issues.apache.org/jira/browse/JXR-159 > Project: Maven JXR > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.1.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7068) Active dependency management for Google Guice/Guava
[ https://issues.apache.org/jira/browse/MNG-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280319#comment-17280319 ] Hudson commented on MNG-7068: - Build unstable in Jenkins: Maven » Maven TLP » maven » revert-MNG-6772 #11 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/revert-MNG-6772/11/ > Active dependency management for Google Guice/Guava > --- > > Key: MNG-7068 > URL: https://issues.apache.org/jira/browse/MNG-7068 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.6.3 >Reporter: Boris Unckel >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-1 > > > The current pom includes com.google.inject:guice with the default transitive > dependency of com.google.guava:guava. Guava has declared several > dependencies, which are not needed at runtime. Only > com.google.guava:failureaccess is needed. > The proposal is first to add com.google.guava:guava to the excludes of guice. > Second guava and failureaccess shall be added as direct dependencies. > This has two advantages: Downstream projects only get the needed dependencies > and the version of guava can be independently set. > The runtime dependencies for Guava are explained in the last section of the > [README|https://github.com/google/guava/tree/v30.1] "Important Warnings" #3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7029) Remove super POM release profile
[ https://issues.apache.org/jira/browse/MNG-7029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280320#comment-17280320 ] Hudson commented on MNG-7029: - Build unstable in Jenkins: Maven » Maven TLP » maven » revert-MNG-6772 #11 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/revert-MNG-6772/11/ > Remove super POM release profile > > > Key: MNG-7029 > URL: https://issues.apache.org/jira/browse/MNG-7029 > Project: Maven > Issue Type: Task >Affects Versions: 3.6.3 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-1 > > > The release profile has been deprecated for a long time with scheduled for > removal. This ticket formally represents this task. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-7051) Optionally skip non-existing profiles
[
https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280317#comment-17280317
]
Hudson commented on MNG-7051:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » revert-MNG-6772 #11
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/revert-MNG-6772/11/
> Optionally skip non-existing profiles
> -
>
> Key: MNG-7051
> URL: https://issues.apache.org/jira/browse/MNG-7051
> Project: Maven
> Issue Type: Sub-task
> Components: Profiles
>Reporter: Maarten Mulders
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> For Maven 4, the behaviour of the {{-P}} command line option will change:
> * {{-P apache-release}} will activate the *apache-release* profile. If such
> a profile cannot be found, the build will break.
> * {{-P ?apache-release}} will activate the *apache-release* profile. If such
> a profile cannot be found, the build will continue but log a warning.
> {color:#ff}
> Note that this breaks the current behaviour of Maven 3 in two ways:
> {color}
> # {{-P apache-release}} will currently log a warning and not break the build.
> That behaviour can be restored by adding the {{?}}.
> # A profile that has an identifier that not valid (i.e., contains anything
> else than {{a}} - {{z}}, {{A}} to {{Z}}, {{0}} - {{9}}, {{-}}, {{_}} or
> {{.}}) will break the build.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6772) Super POM overwrites remapped central repository in nested import POMs
[
https://issues.apache.org/jira/browse/MNG-6772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280321#comment-17280321
]
Hudson commented on MNG-6772:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » revert-MNG-6772 #11
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/revert-MNG-6772/11/
> Super POM overwrites remapped central repository in nested import POMs
> --
>
> Key: MNG-6772
> URL: https://issues.apache.org/jira/browse/MNG-6772
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories, POM
>Affects Versions: 3.6.2
>Reporter: Eddie Wiegers
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> My projects define a repository with {{central,}} which is meant to
> specifically override the entry in the Super POM. This is specifically what
> [JFrog Artifactory
> recommends|https://www.jfrog.com/confluence/display/RTF/Maven+Repository#MavenRepository-ManuallyOverridingtheBuilt-inRepositories]
> doing, and seems valid in situations where the _real_ Maven Central may be
> unreachable.
>
> The override takes precedence almost all of the time. However, there is at
> least one scenario where this is not the case, and that is when importing a
> POM that in turn imports another POM.
>
> Digging into the code, it appears the reason this happens is because the
> {{DefaultModelBuilder}} overwrites repositories after interpolation is
> complete:
> [https://github.com/apache/maven/blob/53f04f03e3e58c75dcc791d557758357a6ec7983/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java#L411]
>
> From what I can tell, this is done with the intention of overwriting
> repositories that were added to the local resolver prior to interpolation
> with the interpolated version. Due to the way the {{DefaultModelResolver}}
> works, an unintended side effect is that the {{central}} repository from the
> Super POM is added once after each interpolation. The first time the
> repository is added, it is added to the {{repositoryIds}} but doesn't
> actually remove the original repository. The second time it is added is when
> the original repository will be replaced. Currently, the repositoryIds are
> preserved in the {{ModelResolver}} when resolving import POMs, leading to the
> behavior I am seeing where the second nested import POM ends up being where
> the failure occurs.
>
> I am planning on submitting a PR to clone the {{ModelResolver}} in a way that
> resets the repositoryIds prior to import POMs being resolved, since they are
> separate artifact builds. That seems like the most consistent fix to me that
> covers cases outside of the the Super POM's {{central}} definition.
>
> *Workarounds*:
> The current workaround is to use a repository ID other than {{central}} for
> my Artifactory repository, which isn't ideal since it leaves the potential
> for long timeouts to occur on the real {{central}} when an artifact can't be
> resolved from my Artifactory repository.
>
> Mirrors are not an ideal workaround since getting them in place on all
> possible build environments isn't trivial.
>
> When looking at the code I noticed
> {{RepositorySystemSession#isIgnoreArtifactDescriptorRepositories()}} being
> checked in various places, which seems like it would also act as a potential
> workaround, but I don't see a way to enable this value via MavenCLI or
> properties of any kind. It seems like this value aligns well with what
> Artifactory is already trying to enforce, so it would make sense to enable
> this in projects that intend to exclusively use Artifactory. Is there a
> supported way to set this value outside of constructing a Maven build in code?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280343#comment-17280343
]
Alexander Kriegisch edited comment on SUREFIRE-1881 at 2/7/21, 1:23 AM:
Actually, I am not sure which remote network connection you are talking about.
I have never seen this kind of error before. Can you elaborate, please? I
cannot see Java instrumentation in the picture here, at least not in the stack
trace. The instrumentation I set up here is in process, the agent does not
connect to a remote host or an external process on the same host. What kind of
environment did you run the build in? Which Java version? Anything that could
help, I am not sure which details would be helpful yet.
Is this maybe related to Maven talking to the forked process rather than
instrumentation? Or does the error go away if you remove the {{argLine}}
parameter with the Java agent?
was (Author: kriegaex):
Actually, I am not sure which remote network connection you are talking about.
I have never seen this kind of error before. Can you elaborate, please? I
cannot see Java instrumentation in the picture here, at least not in the stack
trace. The instrumentation I set up here is in process, the agent does not
connect to a remote host or an external process on the same host. What kind of
environment did you run the build in? Which Java version? Anything that could
help, I am not sure which details would be helpful yet.
Is this maybe related to Maven talking to the forked process rather than
instrumentation?
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280352#comment-17280352
]
Alexander Kriegisch edited comment on SUREFIRE-1881 at 2/7/21, 2:19 AM:
On my machine, if I activate the fork node, there is no {{failsafe-reports}}
directory, just an indefinitely hanging build, I have to kill the process.
Otherwise I would have noticed the dump file. All I see is
{code:none}
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (integration-test) @
surefire-print-console-problems ---
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
{code}
and then nothing else for minutes.
{quote}What was strange to me was the fact that your code operates with
internal Failsafe code, basically all classes on the JVM.{quote}
Well, that is what Java agents do and what they exist for. But as you can see,
my dummy agent does not modify any byte code, it just prints log lines, so you
can see something and also reproduce the console output garbling effect I see
when the fork node setting is inactive.
Did you try this on a Windows (10) machine or on Linux or maybe MacOS?
was (Author: kriegaex):
On my machine, if I activate the fork node, there is no {{failsafe-reports}}
directory, just an indefinitely hanging build, I have to kill the process.
Otherwise I would have noticed the dump file. All I see is
{code:none}
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (integration-test) @
surefire-print-console-problems ---
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
{code}
and then nothing else for minutes.
{quote}What was strange to me was the fact that your code operates with
internal Failsafe code, basically all classes on the JVM.{quote}
Well, that is what Java agents do and what they exist for. But as you can see,
my dummy agent does not modify any byte code, it just prints log lines, so you
can see something and also reproduce the console output garbling effect I see
when the fork node setting is inactive.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory
[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280352#comment-17280352
]
Alexander Kriegisch edited comment on SUREFIRE-1881 at 2/7/21, 2:17 AM:
On my machine, if I activate the fork node, there is no {{failsafe-reports}}
directory, just an indefinitely hanging build, I have to kill the process.
Otherwise I would have noticed the dump file. All I see is
{code:none}
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (integration-test) @
surefire-print-console-problems ---
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
{code}
and then nothing else for minutes.
{quote}What was strange to me was the fact that your code operates with
internal Failsafe code, basically all classes on the JVM.{quote}
Well, that is what Java agents do and what they exist for. But as you can see,
my dummy agent does not modify any byte code, it just prints log lines, so you
can see something and also reproduce the console output garbling effect I see
when the fork node setting is inactive.
was (Author: kriegaex):
On my machine, if I activate the fork node, there is no {{failsafe-reports}}
directory, just an indefinitely hanging build, I have to kill the process.
Otherwise I would have noticed the dump file. All I see is
{code:none}
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (integration-test) @
surefire-print-console-problems ---
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
{code}
and then nothing else for minutes.
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> --
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Alexander Kriegisch
>Priority: Major
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{ implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
